1. 24 Jan, 2013 24 commits
    • aandrey@chromium.org's avatar
      Web Inspector: [Canvas] REGRESSION: stack traces in the replay log are gone · af9d57b5
      aandrey@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107805
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      The V8's Error.prepareStackTrace is now called from the Error.captureStackTrace
      function instead of the "stack" getter function.
      
      Test: inspector/profiler/canvas2d/canvas-stack-trace.html
      
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      
      LayoutTests:
      
      A simple test to dump a canvas 2D trace log with function call stack traces.
      
      * inspector/profiler/canvas-profiler-test.js:
      (initialize_CanvasWebGLProfilerTest.):
      (initialize_CanvasWebGLProfilerTest.InspectorTest.dumpTraceLog):
      * inspector/profiler/canvas2d/canvas-stack-trace-expected.txt: Added.
      * inspector/profiler/canvas2d/canvas-stack-trace.html: Added.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af9d57b5
    • aandrey@chromium.org's avatar
      Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame vs consecutive frames · 67df93b3
      aandrey@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107688
      
      Reviewed by Pavel Feldman.
      
      Allow capturing several canvas frames in a row.
      
      * English.lproj/localizedStrings.js:
      * inspector/InjectedScriptCanvasModule.cpp:
      (WebCore::InjectedScriptCanvasModule::traceLog):
      * inspector/InjectedScriptCanvasModule.h:
      (InjectedScriptCanvasModule):
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      * inspector/Inspector.json:
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::getTraceLog):
      * inspector/InspectorCanvasAgent.h:
      (InspectorCanvasAgent):
      * inspector/front-end/CanvasProfileView.js:
      (WebInspector.CanvasProfileView):
      (WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
      (WebInspector.CanvasProfileView.prototype._requestTraceLog):
      (WebInspector.CanvasProfileType):
      (WebInspector.CanvasProfileType.prototype.get statusBarItems):
      (WebInspector.CanvasProfileType.prototype.get buttonTooltip):
      (WebInspector.CanvasProfileType.prototype.buttonClicked):
      (WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
      (WebInspector.CanvasProfileType.prototype._startFrameCapturing):
      (WebInspector.CanvasProfileType.prototype._stopFrameCapturing.didStopCapturing):
      (WebInspector.CanvasProfileType.prototype._stopFrameCapturing):
      (WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
      (WebInspector.CanvasProfileType.prototype.setRecordingProfile):
      (WebInspector.CanvasProfileType.prototype._isSingleFrameMode):
      (WebInspector.CanvasProfileHeader):
      (WebInspector.CanvasProfileHeader.prototype._updateCapturingStatus):
      (WebInspector.CanvasProfileHeader.prototype._requestCapturingStatus):
      * inspector/front-end/ProfileLauncherView.js:
      (WebInspector.ProfileLauncherView):
      * inspector/front-end/ProfilesPanel.js:
      (WebInspector.ProfileType.prototype.get statusBarItems):
      (WebInspector.ProfilesPanel):
      (WebInspector.ProfilesPanel.prototype.get statusBarItems):
      (WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
      (WebInspector.ProfilesPanel.prototype._reset):
      (WebInspector.ProfilesPanel.prototype._showLauncherView):
      (WebInspector.ProfilesPanel.prototype.showProfile):
      (WebInspector.ProfilesPanel.prototype._updateInterface):
      (WebInspector.ProfilesPanel.prototype._resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67df93b3
    • akling@apple.com's avatar
      Add CSSSelectorList::isValid(). · b3b891b1
      akling@apple.com authored
      <http://webkit.org/b/107809>
      
      Reviewed by Antti Koivisto.
      
      Add an isValid() method to CSSSelectorList and use that where applicable instead of checking
      if first() is a null pointer.
      
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::setSelectorText):
      * css/CSSSelectorList.cpp:
      * css/CSSSelectorList.h:
      (WebCore::CSSSelectorList::isValid):
      (WebCore::CSSSelectorList::first):
      (CSSSelectorList):
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::setSelectorText):
      * html/shadow/HTMLContentElement.cpp:
      (WebCore::HTMLContentElement::validateSelect):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::checkStyleRuleSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3b891b1
    • michael.bruning@digia.com's avatar
      [Qt][WK2] Pages / resources cannot be loaded from qrc files. · 44c1e1e8
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107031
      
      Reviewed by Jocelyn Turcotte.
      
      Enables WebKit2 Qt applications to load files from the bundled
      qrc files. This is achieved by adding a url scheme handler for
      the "qrc" scheme using the application scheme handler and ignoring
      all handlers for the qrc application scheme that the application might
      set.
      
      * UIProcess/API/qt/qquickurlschemedelegate.cpp:
      (QQuickQrcSchemeDelegate::QQuickQrcSchemeDelegate):
      (QQuickQrcSchemeDelegate::readResourceAndSend):
      * UIProcess/API/qt/qquickurlschemedelegate_p.h:
      (QQuickQrcSchemeDelegate):
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::initialize):
      (QQuickWebViewExperimental::schemeDelegates_Append):
      (QQuickWebViewExperimental::invokeApplicationSchemeHandler):
      * UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
      * UIProcess/API/qt/tests/qmltests/common/qrctest.html: Added.
      * UIProcess/API/qt/tests/qmltests/resources.qrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44c1e1e8
    • michael.bruning@digia.com's avatar
      [Qt] Webkit debug build links against release binaries of ANGLE libEGL, libGLESv2 · a2cc5ff5
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106217
      
      Patch by Kai Koehne <kai.koehne@digia.com> on 2013-01-24
      Reviewed by Jocelyn Turcotte.
      
      Use libEGLd, libEGLSv2d if qtbase was compiled with ANGLE.
      
      * WebCore.pri: Mirror logic of qtbase\mkspecs\features\win32\opengl.prf
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2cc5ff5
    • commit-queue@webkit.org's avatar
      Adding "has-landed" command to webkit-patch which compares a · 336ec42a
      commit-queue@webkit.org authored
      committed patch to the changes which exist locally (ignoring the
      ChangeLog file).
      
      https://bugs.webkit.org/show_bug.cgi?id=106402
      
      Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-24
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/checkout/diff_parser.py:
      (git_diff_to_svn_diff):
      * Scripts/webkitpy/common/net/bugzilla/bug.py:
      (Bug.commit_revision):
      * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
      (BugTest.test_is_in_comments):
      (BugTest):
      (BugTest.test_commit_revision):
      * Scripts/webkitpy/tool/commands/upload.py:
      (HasLanded):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/haslanded.py: Added.
      (HasLanded):
      (HasLanded.convert_to_svn):
      (HasLanded.strip_change_log):
      (run):
      
      * Scripts/webkitpy/common/net/bugzilla/bug.py:
      (Bug.commit_revision):
      * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
      (BugTest.test_is_in_comments):
      (BugTest):
      (BugTest.test_commit_revision):
      * Scripts/webkitpy/tool/commands/upload.py:
      (HasLanded):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/haslanded.py: Added.
      (HasLanded):
      (HasLanded.convert_to_svn):
      (HasLanded.strip_change_log):
      (HasLanded.diff_diff):
      (HasLanded.run):
      * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
      (HasLandedTest):
      (HasLandedTest.test_run):
      (test_convert_to_svn_and_strip_change_log):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      336ec42a
    • alexis@webkit.org's avatar
      Unreviewed cleanup of comments and a commented test. · a129f181
      alexis@webkit.org authored
      * transitions/transitions-parsing.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a129f181
    • sergio@webkit.org's avatar
      [GTK] Unreviewed build fix. · f6ff1168
      sergio@webkit.org authored
      Do not include the header file WebKitDOMPerformanceEntryList.h in
      the build sources because we do not want the DOM bindings
      generator to include it in webkitdomdefes.h twice.
      
      * bindings/gobject/GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6ff1168
    • commit-queue@webkit.org's avatar
      Fix Qt build (KO since r140610), typo error for QString::fromUtf16 function. · 966da665
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107803
      
      Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2013-01-24
      Reviewed by Andreas Kling.
      
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::decodeNamedEntity):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      966da665
    • zandobersek@gmail.com's avatar
      Unreviewed gardening. · 5e03549f
      zandobersek@gmail.com authored
      Removing failure expectations for the ietestcenter/css3/valuesandunits/units-010.htm
      layout test. It was fixed in r140300.
      
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-4.8/TestExpectations:
      * platform/qt-mac/TestExpectations:
      * platform/qt/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e03549f
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 35a25d49
      zandobersek@gmail.com authored
      Classifying some IndexedDB failures as flaky.
      Removing the expectation for the passing fast/forms/text-input-event.html test.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35a25d49
    • commit-queue@webkit.org's avatar
      [chromium] move most WebViewHost printf calls to WebTestProxy · 6ae1c599
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107553
      
      Patch by Dan Carney <dcarney@google.com> on 2013-01-24
      Reviewed by Jochen Eisinger.
      
      * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
      (WebKit):
      (WebTestProxyBase):
      (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
      (WebTestRunner::WebTestProxy::didAddMessageToConsole):
      (WebTestRunner::WebTestProxy::runModalAlertDialog):
      (WebTestRunner::WebTestProxy::runModalConfirmDialog):
      (WebTestRunner::WebTestProxy::runModalPromptDialog):
      (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
      (WebTestRunner::WebTestProxyBase::reset):
      (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
      (WebTestRunner):
      (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
      (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
      (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
      (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
      (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
      (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::showDevTools):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::didAddMessageToConsole):
      (WebViewHost::runModalAlertDialog):
      (WebViewHost::runModalConfirmDialog):
      (WebViewHost::runModalPromptDialog):
      (WebViewHost::runModalBeforeUnloadDialog):
      (WebViewHost::unableToImplementPolicyWithError):
      (WebViewHost::reset):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ae1c599
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Expose accessibility hierarchy in WebKit2-EFL. · 358e4267
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106216
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-24
      Reviewed by Andreas Kling.
      
      Create WebPage's accessibility object on WebPage initialization.
      Wrap around WebCore's accessibility objects.
      Updating accessibility hierarchy. Expands accessibility implementation
      of WebKit-GTK to be used in EFL.
      
      * PlatformEfl.cmake:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * WebProcess/WebPage/WebPage.h:
      (WebPage):
      * WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
      (webPageAccessibilityObjectGetIndexInParent):
      (web_page_accessibility_object_init):
      * WebProcess/WebPage/efl/WebPageEfl.cpp:
      (WebKit::WebPage::platformInitialize):
      (WebKit):
      (WebKit::WebPage::updateAccessibilityTree):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      358e4267
    • pfeldman@chromium.org's avatar
      Web Inspector: breakpoints are not restored upon reload for scripts with script mapping. · ecbafade
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107799
      
      Source/WebCore:
      
      The problem is that source mapping is set after UISourceCode gets into the workspace.
      Breakpoint manager will now only restore breakpoints upon setting the source maps.
      
      Reviewed by Alexander Pavlov.
      
      * inspector/front-end/BreakpointManager.js:
      (WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
      (WebInspector.BreakpointManager.prototype._uiSourceCodeMappingChanged):
      * inspector/front-end/CompilerScriptMapping.js:
      (WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
      (WebInspector.CompilerScriptMapping.prototype.get addScript):
      
      LayoutTests:
      
      Reviewed by Alexander Pavlov.
      
      * inspector/debugger/breakpoint-manager.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecbafade
    • tkent@chromium.org's avatar
      Refactoring: Use AtomicString for an InputType::create argument · aaba4941
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107791
      
      Reviewed by Kentaro Hara.
      
      A string passed to InputType::create is a 'type' attribute value, which
      is an AtomicString. Also, InputTypeFactoryMap is created with members of
      InputTypeName, which are AtomicStrings. We had better use AtomicStrings
      for them.
      
      No new tests. This is just a refactoring.
      
      * html/InputType.cpp:
      Change the key type of InputTypeFactoryMap from String to AtomicString.
      (WebCore::InputType::create):
      Change an argument type from const String& to const AtomicString&.
      * html/InputType.h:
      (InputType): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaba4941
    • mihnea@adobe.com's avatar
      [CSSRegions] Add test cases for auto-size regions and window resize · 3db308dd
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107686
      
      Reviewed by Tony Chang.
      
      The fix for https://bugs.webkit.org/show_bug.cgi?id=102954 also solved
      https://bugs.webkit.org/show_bug.cgi?id=102221. This patch adds two tests
      for webkit bug 102221.
      
      * fast/regions/autosize-region-container-resize-expected.html: Added.
      * fast/regions/autosize-region-container-resize.html: Added.
      * fast/regions/autosize-region-window-resize-expected.html: Added.
      * fast/regions/autosize-region-window-resize.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3db308dd
    • commit-queue@webkit.org's avatar
      [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in... · 3defb9e8
      commit-queue@webkit.org authored
      [CSSRegions] remove setExperimentalCSSRegionsEnabled deprecated API in Source/WebKit/chromium/public/WebSettings.h
      https://bugs.webkit.org/show_bug.cgi?id=104564
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-01-24
      Reviewed by Adam Barth.
      
      Fixing bug 101192 has deprecated the use of setExperimentalCSSRegionsEnabled.
      After http://code.google.com/p/chromium/issues/detail?id=164162 , setExperimentalCSSRegionsEnabled is no longer used anywhere.
      
      * public/WebSettings.h:
      removed setExperimentalCSSRegionsEnabled.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3defb9e8
    • commit-queue@webkit.org's avatar
      [CMake] Remove the definition of WTF_PLATFORM_WIN from the build system · 4f2fb8f4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101635
      
      Patch by Soo-Hyun Choi <s.choi@hackerslab.eu> on 2013-01-24
      Reviewed by Laszlo Gombos.
      
      WTF_PLATFORM_WIN defined twice: Source/cmake/OptionsWindows.cmake and in
      Source/WTF/wtf/Platform.h.
      It would be more future-proof to have it only defined in common C++ code in
      Platform.h.
      
      * Source/cmake/OptionsWindows.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f2fb8f4
    • haraken@chromium.org's avatar
      Unreviewed. Build fix. · 9657934f
      haraken@chromium.org authored
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::isDOMWrapper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9657934f
    • akling@apple.com's avatar
      AX: Fix the debug build after r140658. (Constructor initializer order.) · 25c9657f
      akling@apple.com authored
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::AccessibilityNodeObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c9657f
    • morrita@google.com's avatar
      There are a few of wrong removeAllChildren() call · 8b92e0f8
      morrita@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107790
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      removeAllChildren() is designed for trashing deleting children out.
      It doesn't detach() children and could have possible leak.
      This change replaces such removeAllChildren() usage with safer removeChildren().
      
      No new tests. Covered by existing tests.
      
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::parseAttribute):
      * html/InputType.cpp:
      (WebCore::InputType::destroyShadowSubtree):
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processEndTag):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp: Repalced removeAllChildren() with safer removeChildren()
      (QWebElement::removeAllChildren):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b92e0f8
    • dmazzoni@google.com's avatar
      AX: should init an AXObject only after AXObjectCache has added it · 36019066
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107533
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore:
      
      Initialize each AXObject after the AXObjectCache has
      finished adding it to its hash maps, so that it's
      impossible for initialization of an AXObject to result in
      exploring the tree and creating another AXObject instance
      that points to the same renderer / node.
      
      Test: accessibility/duplicate-axrenderobject-crash.html
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::getOrCreate):
      * accessibility/AccessibilityARIAGrid.cpp:
      (WebCore::AccessibilityARIAGrid::create):
      * accessibility/AccessibilityARIAGridCell.cpp:
      (WebCore::AccessibilityARIAGridCell::create):
      * accessibility/AccessibilityARIAGridRow.cpp:
      (WebCore::AccessibilityARIAGridRow::create):
      * accessibility/AccessibilityList.cpp:
      (WebCore::AccessibilityList::create):
      * accessibility/AccessibilityListBox.cpp:
      (WebCore::AccessibilityListBox::create):
      * accessibility/AccessibilityMediaControls.cpp:
      (WebCore::AccessibilityMediaControl::create):
      (WebCore::AccessibilityMediaControlsContainer::create):
      (WebCore::AccessibilityMediaTimeline::create):
      (WebCore::AccessibilityMediaTimeDisplay::create):
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::create):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::create):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::init):
      (AccessibilityObject):
      * accessibility/AccessibilityProgressIndicator.cpp:
      (WebCore::AccessibilityProgressIndicator::create):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::create):
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
          assert that the object has been initialized
      * accessibility/AccessibilitySVGRoot.cpp:
      (WebCore::AccessibilitySVGRoot::create):
      * accessibility/AccessibilitySlider.cpp:
      (WebCore::AccessibilitySlider::create):
      * accessibility/AccessibilityTable.cpp:
      (WebCore::AccessibilityTable::create):
      * accessibility/AccessibilityTableCell.cpp:
      (WebCore::AccessibilityTableCell::create):
      * accessibility/AccessibilityTableRow.cpp:
      (WebCore::AccessibilityTableRow::create):
      
      LayoutTests:
      
      Adds a new test that demonstrates a crash if an AXObject
      initializes itself before the AXObjectCache has added it to
      the cache.
      
      * accessibility/duplicate-axrenderobject-crash-expected.txt: Added.
      * accessibility/duplicate-axrenderobject-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36019066
    • haraken@chromium.org's avatar
      Implement MouseEvent constructor · c39399e6
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107630
      
      Reviewed by Adam Barth.
      
      Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
      
      Source/WebCore:
      
      The MouseEvent constructor should be implemented under a DOM4_EVENTS_CONSTRUCTOR flag.
      This significantly simplifies JavaScript code to construct a MouseEvent.
      
      Before:
        event = document.createEvent("MouseEvents");
        event.initMouseEvent("click", true, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
      
      After:
        event = new MouseEvent("click");
      
      Test: fast/events/constructors/mouse-event-constructor.html
      
      * bindings/scripts/CodeGenerator.pm:
      (IsSubType):
      (IsInheritExtendedAttribute):
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeader):
      (GenerateNamedConstructorCallback):
      (GenerateImplementation):
      * bindings/scripts/test/V8/V8Float64Array.cpp:
      (WebCore):
      (WebCore::V8Float64Array::createWrapper):
      * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
      (WebCore):
      (WebCore::V8TestActiveDOMObject::createWrapper):
      * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
      (WebCore):
      (WebCore::V8TestCustomNamedGetter::createWrapper):
      * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
      (WebCore):
      (WebCore::V8TestEventConstructor::createWrapper):
      * bindings/scripts/test/V8/V8TestEventTarget.cpp:
      (WebCore):
      (WebCore::V8TestEventTarget::toEventTarget):
      (WebCore::V8TestEventTarget::createWrapper):
      * bindings/scripts/test/V8/V8TestEventTarget.h:
      (V8TestEventTarget):
      * bindings/scripts/test/V8/V8TestException.cpp:
      (WebCore):
      (WebCore::V8TestException::createWrapper):
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore):
      (WebCore::V8TestInterface::toActiveDOMObject):
      (WebCore::V8TestInterface::createWrapper):
      * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
      (WebCore):
      (WebCore::V8TestMediaQueryListListener::createWrapper):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore):
      (WebCore::V8TestNamedConstructor::toActiveDOMObject):
      (WebCore::V8TestNamedConstructor::createWrapper):
      * bindings/scripts/test/V8/V8TestNode.cpp:
      (WebCore):
      (WebCore::V8TestNode::toEventTarget):
      (WebCore::V8TestNode::createWrapper):
      * bindings/scripts/test/V8/V8TestNode.h:
      (V8TestNode):
      * bindings/scripts/test/V8/V8TestObj.cpp:
      (WebCore):
      (WebCore::V8TestObj::createWrapper):
      * bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
      (WebCore):
      (WebCore::V8TestOverloadedConstructors::createWrapper):
      * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
      (WebCore):
      (WebCore::V8TestSerializedScriptValueInterface::createWrapper):
      * bindings/v8/Dictionary.cpp:
      (WebCore::Dictionary::get):
      (WebCore):
      * bindings/v8/Dictionary.h:
      (Dictionary):
      * bindings/v8/NPV8Object.cpp:
      (WebCore::npObjectTypeInfo):
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::isDOMWrapper):
      (WebCore):
      * bindings/v8/V8DOMWrapper.h:
      (V8DOMWrapper):
      * bindings/v8/WrapperTypeInfo.h:
      (WebCore):
      (WebCore::WrapperTypeInfo::toEventTarget):
      (WrapperTypeInfo):
      * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
      (WebCore):
      * dom/MouseEvent.cpp:
      (WebCore::MouseEventInit::MouseEventInit):
      (WebCore):
      (WebCore::MouseEvent::create):
      (WebCore::MouseEvent::MouseEvent):
      * dom/MouseEvent.h:
      (MouseEventInit):
      (WebCore):
      (MouseEvent):
      (WebCore::MouseEvent::create):
      (WebCore::MouseEvent::button):
      (WebCore::MouseEvent::buttonDown):
      (WebCore::MouseEvent::relatedTarget):
      (WebCore::MouseEvent::setRelatedTarget):
      (WebCore::MouseEvent::clipboard):
      (WebCore::MouseEvent::dataTransfer):
      * dom/MouseEvent.idl:
      
      LayoutTests:
      
      The MouseEvent constructor should be implemented under a DOM4_EVENTS_CONSTRUCTOR flag.
      
      * fast/dom/constructed-objects-prototypes-expected.txt:
      * fast/dom/dom-constructors-expected.txt:
      * fast/dom/dom-constructors.html:
      * fast/events/constructors/mouse-event-constructor-expected.txt: Added.
      * fast/events/constructors/mouse-event-constructor.html: Added.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c39399e6
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Unreviewed build fix after r140605 · 37f9d1bb
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107787
      
      Unreviewed build fix.
      
      Build break after r140605.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-01-23
      
      * UIProcess/WebBatteryManagerProxy.cpp:
      * UIProcess/WebBatteryManagerProxy.h:
      (WebBatteryManagerProxy):
      * UIProcess/WebNetworkInfoManagerProxy.cpp:
      * UIProcess/WebNetworkInfoManagerProxy.h:
      (WebNetworkInfoManagerProxy):
      * UIProcess/WebVibrationProxy.cpp:
      * UIProcess/WebVibrationProxy.h:
      (WebVibrationProxy):
      * UIProcess/soup/WebSoupRequestManagerProxy.cpp:
      * UIProcess/soup/WebSoupRequestManagerProxy.h:
      (WebSoupRequestManagerProxy):
      * WebProcess/Battery/WebBatteryManager.cpp:
      * WebProcess/Battery/WebBatteryManager.h:
      (WebBatteryManager):
      * WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
      * WebProcess/NetworkInfo/WebNetworkInfoManager.h:
      (WebNetworkInfoManager):
      * WebProcess/soup/WebSoupRequestManager.cpp:
      * WebProcess/soup/WebSoupRequestManager.h:
      (WebSoupRequestManager):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37f9d1bb
  2. 23 Jan, 2013 16 commits
    • tkent@chromium.org's avatar
      Add form-related instrumentations, and support 33+ features in FeatureObserver · 5ca02f41
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107770
      
      Reviewed by Kentaro Hara.
      
      No new tests. This doesn't make behavior changes.
      
      * page/FeatureObserver.h:
      - Add form-related features.
      - Add a Document* version of observe().
      - Use BitVector to represent features to support 33+ features.
      (WebCore::FeatureObserver::didObserve):
      (FeatureObserver):
      * page/FeatureObserver.cpp:
      (WebCore::FeatureObserver::FeatureObserver):
      (WebCore::FeatureObserver::~FeatureObserver):
      (WebCore::FeatureObserver::observe):
      
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::create): Calls FeatureObserver::observe.
      * html/DateInputType.cpp:
      (WebCore::DateInputType::create): Ditto.
      * html/DateTimeInputType.cpp:
      (WebCore::DateTimeInputType::create): Ditto.
      * html/DateTimeLocalInputType.cpp:
      (WebCore::DateTimeLocalInputType::create): Ditto.
      * html/EmailInputType.cpp:
      (WebCore::EmailInputType::create): Ditto.
      * html/HTMLDataListElement.cpp:
      (WebCore::HTMLDataListElement::create): Ditto.
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::parseAttribute): Ditto.
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::parseAttribute): Ditto.
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::parseAttribute): Ditto.
      * html/InputType.cpp:
      (WebCore::InputType::create):
      Record type=datetime and type=week even if these types are not enabled.
      * html/MonthInputType.cpp:
      (WebCore::MonthInputType::create): Calls FeatureObserver::observe.
      * html/NumberInputType.cpp:
      (WebCore::NumberInputType::create): Ditto.
      * html/RangeInputType.cpp:
      (WebCore::RangeInputType::create): Ditto.
      * html/SearchInputType.cpp:
      (WebCore::SearchInputType::create): Ditto.
      * html/TelephoneInputType.cpp:
      (WebCore::TelephoneInputType::create): Ditto.
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::create): Ditto.
      * html/URLInputType.cpp:
      (WebCore::URLInputType::create): Ditto.
      * html/WeekInputType.cpp:
      (WebCore::WeekInputType::create): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ca02f41
    • yosin@chromium.org's avatar
      Unreviewed, rebaseline for Chromium-Linux and Chromium-Win · 8d955c61
      yosin@chromium.org authored
      editing/selection/range-between-block-and-inline.html
      
      * platform/chromium-linux/editing/selection/range-between-block-and-inline-expected.png:
      * platform/chromium-win/editing/selection/range-between-block-and-inline-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d955c61
    • pilgrim@chromium.org's avatar
      [Chromium] Give webkit_support a chance to reset state between layout test runs · dbb8f254
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107132
      
      Reviewed by Adam Barth.
      
      We currently only have need for this on OS(ANDROID), but now it
      would be useful to have a hook for resetting state on all
      platforms. Will soon be using this for IDBFactory initialization.
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbb8f254
    • commit-queue@webkit.org's avatar
      QueueStatusServer crashes in production on next-patch · 6d3f7a2d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107775
      
      Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-23
      Reviewed by Adam Barth.
      
      Replaced Python 2.5 incompatible call to timedelta.total_seconds().
      
      * QueueStatusServer/app.yaml:
      * QueueStatusServer/model/patchlog.py:
      (PatchLog.calculate_wait_duration):
      (PatchLog.calculate_process_duration):
      (PatchLog):
      (PatchLog._time_delta_to_seconds):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d3f7a2d
    • commit-queue@webkit.org's avatar
      [Inspector] Add events for tracking page loads and scheduled navigations. · daffe2f1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104168
      
      Patch by Ken Kania <kkania@chromium.org> on 2013-01-23
      Reviewed by Pavel Feldman.
      
      These events are needed for clients who need to be aware of when a page is
      navigating or about to navigate. Some clients may wish to prevent interaction
      with the page during this time. Two of the new events track loading start and
      stop, as measured by the ProgressTracker. The other two events track when a
      page has a new scheduled navigation and when it no longer has a scheduled
      navigation. These latter two events won't allow the client to determine if
      a load is going to happen in all circumstances, but is sufficient for many cases.
      Make sure we hold a reference to the frame in NavigationScheduler::timerFired
      in case the redirect causes the frame to be detached.
      
      Also, minor update to InspectorInputAgent::dispatchMouseEvent to reorder params
      to match dispatchKeyEvent.
      
      Source/WebCore:
      
      Tests: inspector-protocol/page/frameScheduledNavigation.html
             inspector-protocol/page/frameStartedLoading.html
      
      * inspector/Inspector.json:
      * inspector/InspectorInputAgent.cpp:
      (WebCore::InspectorInputAgent::dispatchMouseEvent):
      * inspector/InspectorInputAgent.h:
      (InspectorInputAgent):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
      (WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):
      (WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
      (WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):
      * inspector/InspectorInstrumentation.h:
      (InspectorInstrumentation):
      (WebCore::InspectorInstrumentation::frameStartedLoading):
      (WebCore):
      (WebCore::InspectorInstrumentation::frameStoppedLoading):
      (WebCore::InspectorInstrumentation::frameScheduledNavigation):
      (WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::frameStartedLoading):
      (WebCore):
      (WebCore::InspectorPageAgent::frameStoppedLoading):
      (WebCore::InspectorPageAgent::frameScheduledNavigation):
      (WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
      * inspector/InspectorPageAgent.h:
      * inspector/front-end/ResourceTreeModel.js:
      (WebInspector.PageDispatcher.prototype.frameDetached):
      (WebInspector.PageDispatcher.prototype.frameStartedLoading):
      (WebInspector.PageDispatcher.prototype.frameStoppedLoading):
      (WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
      (WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
      * loader/NavigationScheduler.cpp:
      (WebCore::NavigationScheduler::clear):
      (WebCore::NavigationScheduler::timerFired):
      (WebCore::NavigationScheduler::startTimer):
      (WebCore::NavigationScheduler::cancel):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::finalProgressComplete):
      
      LayoutTests:
      
      * inspector-protocol/page/frameScheduledNavigation-expected.txt: Added.
      * inspector-protocol/page/frameScheduledNavigation.html: Added.
      * inspector-protocol/page/frameStartedLoading-expected.txt: Added.
      * inspector-protocol/page/frameStartedLoading.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daffe2f1
    • simon.fraser@apple.com's avatar
      Source/WebCore: Avoid creating background layers on pages with a fixed background, but no image · a54c54d3
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107783
      <rdar://problem/13074450>
      
      Reviewed by Beth Dakin.
      
      http://www.nme.com has background-attachment: fixed on the <body>, but
      not background image. In that case there's no point making a layer
      for the fixed root background.
      
      Test: platform/mac/tiled-drawing/fixed-background/fixed-background-no-image.html
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::allLayersAreFixed): Check to see if we have an image, as well
      as fixed attachment.
      
      LayoutTests: Avoid creating background layers on pages with a fixed background, but no image
      https://bugs.webkit.org/show_bug.cgi?id=107783
      
      Reviewed by Beth Dakin.
      
      Testcase with body { background-attachment:fixed; } but no image.
      
      * platform/mac/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-background-no-image.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a54c54d3
    • yosin@chromium.org's avatar
      Layout Test platform/chromium-win/fast/events/panScroll-panIcon.html is failing · be68cef3
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107729
      
      Reviewed by Hajime Morita.
      
      This patch changes panScroll-panIcon.html test to HTML ref test rather than
      pixel ref test to avoid rebaseline among Windows versions, and enables
      panScroll-panIcon.html.
      
      * platform/chromium-win/fast/events/panScroll-panIcon.html: Changed not to move mouse pointer to avoid motion of scroll thumb.
      * platform/chromium-win/fast/events/panScroll-panIcon-expected.html: Added.
      * platform/chromium-win/fast/events/panScroll-panIcon-expected.png: Removed.
      * platform/chromium-win/fast/events/panScroll-panIcon-expected.txt: Removed.
      * platform/chromium-win/TestExpectations: Changed to enable panScroll-panIcon.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be68cef3
    • commit-queue@webkit.org's avatar
      Enable autoplay when <video>'s src is from media stream · a223a262
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105224
      
      Patch by Wei Jia <wjia@chromium.org> on 2013-01-23
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      Enable autoplay when <video>'s src is from media stream. This would avoid requesting multiple gestures when <video> is used for WebRTC.
      The test is done by modifying platform/chromium/media/video-capture-preview.html.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::loadResource):
      
      LayoutTests:
      
      Always turns on mediaPlaybackRequiresUserGesture at the beginning.
      HTMLMediaElement is supposed to turn it off when <video>'s src is from media stream.
      * platform/chromium/media/video-capture-preview.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a223a262
    • roger_fong@apple.com's avatar
      Remove ForwardingHeaders/wtf from WebCore. · 650c51d8
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107723
      
      The folders are empty, nothings actually being copied over anymore from the ForwardingHeaders/wtf folder.
      
      Reviewed by Benjamin Poulain.
      
      * ForwardingHeaders/wtf: Removed.
      * ForwardingHeaders/wtf/dtoa: Removed.
      * ForwardingHeaders/wtf/text: Removed.
      * ForwardingHeaders/wtf/unicode: Removed.
      * ForwardingHeaders/wtf/unicode/icu: Removed.
      * ForwardingHeaders/wtf/unicode/wince: Removed.
      * ForwardingHeaders/wtf/url: Removed.
      * WebCore.vcproj/copyForwardingHeaders.cmd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650c51d8
    • hayato@chromium.org's avatar
      Group parameters (firstRuleIndex and lastRuleIndex) into a parameter object, RuleRange. · 14feca1f
      hayato@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107095
      
      Reviewed by Darin Adler.
      
      This is a continued effort after r139817.
      
      Factoring, no change in behavior.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRules):
      (WebCore::StyleResolver::collectMatchingRulesForRegion):
      (WebCore::StyleResolver::matchScopedAuthorRules):
      (WebCore::StyleResolver::matchHostRules):
      (WebCore::StyleResolver::matchAuthorRules):
      (WebCore::StyleResolver::matchUserRules):
      (WebCore::StyleResolver::matchUARules):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      (WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
      * css/StyleResolver.h:
      (WebCore::StyleResolver::RuleRange::RuleRange):
      (RuleRange): Newly introduced to group parameters.
      (StyleResolver):
      (WebCore::StyleResolver::MatchRanges::UARuleRange):
      (WebCore::StyleResolver::MatchRanges::authorRuleRange):
      (WebCore::StyleResolver::MatchRanges::userRuleRange):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14feca1f
    • macpherson@chromium.org's avatar
      Support variables inside -webkit-box-reflect CSS property. · 30f917dc
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106856
      
      Source/WebCore:
      
      Reviewed by Tony Chang.
      
      The primary change is to make the direction parameter a CSSPrimitiveValue style ident,
      so that it can also be a variable reference.
      
      Covered by existing LayoutTests/compositing/reflections/ tests.
      Added Test: fast/css/variables/var-inside-box-reflect.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForReflection):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseReflect):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore):
      (WebCore::CSSPrimitiveValue::operator CSSReflectionDirection):
      (WebCore::CSSPrimitiveValue::convertToLength):
      * css/CSSReflectValue.cpp:
      (WebCore::CSSReflectValue::customCssText):
      Use String addition operator instead of StringBuilder.
      (WebCore):
      (WebCore::CSSReflectValue::customSerializeResolvingVariables):
      Use String addition operator instead of StringBuilder.
      * css/CSSReflectValue.h:
      (WebCore::CSSReflectValue::create):
      (WebCore::CSSReflectValue::direction):
      (CSSReflectValue):
      (WebCore::CSSReflectValue::CSSReflectValue):
      * css/CSSValue.cpp:
      (WebCore::CSSValue::serializeResolvingVariables):
      * css/StyleResolver.cpp:
      (WebCore::hasVariableReference):
      (WebCore::StyleResolver::applyProperty):
      
      LayoutTests:
      
      Adds test for variables as -webkit-box-reflect parameters.
      
      Reviewed by Tony Chang.
      
      * fast/css/variables/var-inside-box-reflect-expected.html: Added.
      * fast/css/variables/var-inside-box-reflect.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30f917dc
    • rniwa@webkit.org's avatar
      The previous patch wasn't complete. Finish reverting r139998 for real. · 3bd5cf95
      rniwa@webkit.org authored
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
      (ProfilerAgent.getProfile):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bd5cf95
    • inferno@chromium.org's avatar
      Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad casts in rendering · 6d978e13
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107743
      
      Reviewed by Eric Seidel.
      
      * rendering/InlineFlowBox.h:
      (WebCore::toInlineFlowBox):
      * rendering/RenderBR.h:
      (WebCore::toRenderBR):
      * rendering/RenderBlock.h:
      (WebCore::toRenderBlock):
      * rendering/RenderBox.h:
      (WebCore::toRenderBox):
      * rendering/RenderBoxModelObject.h:
      (WebCore::toRenderBoxModelObject):
      * rendering/RenderButton.h:
      (WebCore::toRenderButton):
      * rendering/RenderCombineText.h:
      (WebCore::toRenderCombineText):
      * rendering/RenderCounter.h:
      (WebCore::toRenderCounter):
      * rendering/RenderDetailsMarker.h:
      (WebCore::toRenderDetailsMarker):
      * rendering/RenderEmbeddedObject.h:
      (WebCore::toRenderEmbeddedObject):
      * rendering/RenderFieldset.h:
      (WebCore::toRenderFieldset):
      * rendering/RenderFileUploadControl.h:
      (WebCore::toRenderFileUploadControl):
      * rendering/RenderFlowThread.h:
      (WebCore::toRenderFlowThread):
      * rendering/RenderFrame.h:
      (WebCore::toRenderFrame):
      * rendering/RenderFrameSet.h:
      (WebCore::toRenderFrameSet):
      * rendering/RenderFullScreen.h:
      (WebCore::toRenderFullScreen):
      * rendering/RenderIFrame.h:
      (WebCore::toRenderIFrame):
      * rendering/RenderImage.h:
      (WebCore::toRenderImage):
      * rendering/RenderInline.h:
      (WebCore::toRenderInline):
      * rendering/RenderLayerModelObject.h:
      (WebCore::toRenderLayerModelObject):
      * rendering/RenderListBox.h:
      (WebCore::toRenderListBox):
      * rendering/RenderListItem.h:
      (WebCore::toRenderListItem):
      * rendering/RenderListMarker.h:
      (WebCore::toRenderListMarker):
      * rendering/RenderMedia.h:
      (WebCore::toRenderMedia):
      * rendering/RenderMenuList.h:
      (WebCore::toRenderMenuList):
      * rendering/RenderMeter.h:
      (WebCore::toRenderMeter):
      * rendering/RenderMultiColumnBlock.h:
      (WebCore::toRenderMultiColumnBlock):
      * rendering/RenderMultiColumnSet.h:
      (WebCore::toRenderMultiColumnSet):
      * rendering/RenderNamedFlowThread.h:
      (WebCore::toRenderNamedFlowThread):
      * rendering/RenderPart.h:
      (WebCore::toRenderPart):
      * rendering/RenderProgress.h:
      (WebCore::toRenderProgress):
      * rendering/RenderQuote.h:
      (WebCore::toRenderQuote):
      * rendering/RenderRegion.h:
      (WebCore::toRenderRegion):
      * rendering/RenderRubyRun.h:
      (WebCore::toRenderRubyRun):
      * rendering/RenderScrollbarPart.h:
      (WebCore::toRenderScrollbarPart):
      * rendering/RenderSearchField.h:
      (WebCore::toRenderSearchField):
      * rendering/RenderSlider.h:
      (WebCore::toRenderSlider):
      * rendering/RenderSnapshottedPlugIn.h:
      (WebCore::toRenderSnapshottedPlugIn):
      * rendering/RenderTable.h:
      (WebCore::toRenderTable):
      * rendering/RenderTableCaption.h:
      (WebCore::toRenderTableCaption):
      * rendering/RenderTableCell.h:
      (WebCore::toRenderTableCell):
      * rendering/RenderTableCol.h:
      (WebCore::toRenderTableCol):
      * rendering/RenderTableRow.h:
      (WebCore::toRenderTableRow):
      * rendering/RenderTableSection.h:
      (WebCore::toRenderTableSection):
      * rendering/RenderText.h:
      (WebCore::toRenderText):
      * rendering/RenderTextControl.h:
      (WebCore::toRenderTextControl):
      * rendering/RenderTextControlMultiLine.h:
      (WebCore::toRenderTextControlMultiLine):
      * rendering/RenderTextControlSingleLine.h:
      (WebCore::toRenderTextControlSingleLine):
      * rendering/RenderVideo.h:
      (WebCore::toRenderVideo):
      * rendering/RenderView.h:
      (WebCore::toRenderView):
      * rendering/RenderWidget.h:
      (WebCore::toRenderWidget):
      * rendering/mathml/RenderMathMLBlock.h:
      (WebCore::toRenderMathMLBlock):
      * rendering/svg/RenderSVGContainer.h:
      (WebCore::toRenderSVGContainer):
      * rendering/svg/RenderSVGGradientStop.h:
      (WebCore::toRenderSVGGradientStop):
      * rendering/svg/RenderSVGImage.h:
      (WebCore::toRenderSVGImage):
      * rendering/svg/RenderSVGInlineText.h:
      (WebCore::toRenderSVGInlineText):
      * rendering/svg/RenderSVGRoot.h:
      (WebCore::toRenderSVGRoot):
      * rendering/svg/RenderSVGShape.h:
      (WebCore::toRenderSVGShape):
      * rendering/svg/RenderSVGText.h:
      (WebCore::toRenderSVGText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d978e13
    • rniwa@webkit.org's avatar
      Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code. · 67bad28b
      rniwa@webkit.org authored
      * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
      (ProfilerAgent.getProfile):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67bad28b
    • commit-queue@webkit.org's avatar
      Don't allocate rare data on every Element on removal · 291b557d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107756
      
      Patch by Elliott Sprehn <esprehn@gmail.com> on 2013-01-23
      Reviewed by Eric Seidel.
      
      We should not allocate an ElementRareData for every element
      in Element::removedFrom. Previously calls to setIsInTopLayer
      would unconditionally call ensureElementRareData(), and this was
      called from Element::removedFrom meaning removing an element
      made the entire subtree suddenly balloon to huge in size as each
      one got an ElementRareData.
      
      This is a regression from my patch on Bug 103912 where I removed a check
      that avoided this allocation.
      
      No new tests needed, covered by existing tests.
      
      * dom/Element.cpp:
      (WebCore::Element::setIsInTopLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      291b557d
    • commit-queue@webkit.org's avatar
      Unreviewed. Rolled Chromium DEPS to r178434. Requested by · ccc14976
      commit-queue@webkit.org authored
      "Yoshifumi Inoue" <yosin@chromium.org> via sheriffbot.
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-23
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc14976