1. 05 Apr, 2006 16 commits
    • darin's avatar
      LayoutTests: · aeb741cb
      darin authored
              Reviewed by Adele.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8111
                REGRESSION (NativeTextField): first click in form field on weather.com leaves focus
                but no caret
      
              - updated results for improved dumping of selection location in DumpRenderTree
      
              * fast/forms/input-text-self-emptying-click-expected.checksum: Added.
              * fast/forms/input-text-self-emptying-click-expected.png: Added.
              * fast/forms/input-text-self-emptying-click-expected.txt: Added.
              * fast/forms/input-text-self-emptying-click.html: Added.
      
              * editing/selection/3690703-2-expected.txt: Updated.
              * fast/forms/input-appearance-focus-expected.txt: Updated.
              * fast/forms/input-appearance-readonly-expected.txt: Updated.
              * fast/forms/input-appearance-selection-expected.txt: Updated.
              * fast/forms/input-paste-undo-expected.txt: Updated.
              * fast/forms/input-text-double-click-expected.txt: Updated.
              * fast/forms/input-text-option-delete-expected.txt: Updated.
              * fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
              * fast/forms/plaintext-mode-2-expected.txt: Updated.
      
      WebCore:
      
              Reviewed by Adele.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8111
                REGRESSION (NativeTextField): first click in form field on weather.com leaves focus
                but no caret
      
              Test: fast/forms/input-text-self-emptying-click.html
      
              * page/MouseEventWithHitTestResults.h: Removed url, target, m_url and m_target,
              replacing them with isOverLink and m_isOverLink. Replaced innerNode with targetNode,
              and added logic to handle the case where the target node is removed from the document
              but the element the target node was in is still inside the document.
              * page/MouseEventWithHitTestResults.cpp: Added.
      
              * WebCore.xcodeproj/project.pbxproj: Added MouseEventWithHitTestResults.cpp.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
      
              * kwq/RenderTreeAsText.cpp: (nodePosition): Added a call to shadowParentNode so we
              correctly dump positions within shadow trees. This was needed to give a good result
              from my new test for this bug.
      
              * dom/Document.cpp:
              (WebCore::Document::prepareMouseEvent): Update to pass fewer parameters to the
              constructor for MouseEventWithHitTestResults. Now takes isOverLink boolean, and no
              longer takes href and target parameters.
      
              * page/Frame.cpp:
              (WebCore::Frame::handleMousePressEventDoubleClick): Use new name targetNode, instead
              of old name innerNode.
              (WebCore::Frame::handleMousePressEventTripleClick): Ditto.
              (WebCore::Frame::handleMousePressEventSingleClick): Ditto. Also change code to check
              if over a link to use !isOverLink instead of url.isNull.
              (WebCore::Frame::handleMousePressEvent): Ditto. Also remove unused "url" local variable.
              (WebCore::Frame::handleMouseMoveEvent): Ditto.
              (WebCore::Frame::handleMouseReleaseEvent): Ditto.
              (WebCore::Frame::passWidgetMouseDownEventToWidget): Ditto.
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::handleMousePressEvent): Use new name targetNode, instead of old
              name innerNode.
              (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
              (WebCore::FrameMac::passSubframeEventToSubframe): Ditto.
              (WebCore::FrameMac::sendContextMenuEvent): Ditto.
      
              * page/FrameView.cpp:
              (WebCore::subframeForEvent): Use new name targetNode, instead of old name innerNode.
              (WebCore::FrameView::handleMousePressEvent): Ditto.
              (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto.
              (WebCore::selectCursor): Ditto. Also change code to check if over a link to use
              isOverLink instead of !url.isNull.
              (WebCore::FrameView::handleMouseMoveEvent): Ditto.
              (WebCore::FrameView::handleMouseReleaseEvent): Ditto.
              (WebCore::FrameView::updateDragAndDrop): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeb741cb
    • mjs's avatar
      Reviewed by Eric. · 98f00f91
      mjs authored
              
              - start on factoring WebArchive unpacking more into a separate class.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8208
              
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebDataSource.m:
              (-[WebDataSourcePrivate dealloc]):
              (-[WebDataSource _addToUnarchiveState:]):
              (-[WebDataSource _popSubframeArchiveWithName:]):
              (-[WebDataSource _documentFragmentWithArchive:]):
              (-[WebDataSource _setupForReplaceByMIMEType:]):
              (-[WebDataSource subresourceForURL:]):
              * WebView/WebDataSourcePrivate.h:
              * WebView/WebFrame.m:
              (-[WebFrame _loadRequest:archive:]):
              (-[WebFrame loadRequest:]):
              (-[WebFrame loadArchive:]):
              * WebView/WebFramePrivate.h:
              * WebView/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation loadArchive]):
              * WebView/WebUnarchivingState.h: Added.
              * WebView/WebUnarchivingState.m: Added.
              (-[WebUnarchivingState init]):
              (-[WebUnarchivingState addArchive:]):
              (-[WebUnarchivingState archivedResourceForURL:]):
              (-[WebUnarchivingState popSubframeArchiveWithFrameName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98f00f91
    • mjs's avatar
      Fixed date in ChangeLog entries for last checkin. · 87eaed34
      mjs authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87eaed34
    • mjs's avatar
      LayoutTests: · 66185b64
      mjs authored
              Reviewed and landed by Maciej.
      
              - updated test result for http://bugzilla.opendarwin.org/show_bug.cgi?id=8184
                REGRESSION (r13655): Layer outline not clipped where it should be
      
              * fast/clip/outline-overflowClip-expected.txt: Reverted to the correct
              expected result.
      
      WebCore:
      
              Reviewed and landed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8184
                REGRESSION (r13655): Layer outline not clipped where it should be
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::calculateRects): Reverted this part of the fix for bug 7943.
              The outlineRect should not be inflated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66185b64
    • mjs's avatar
      LayoutTests: · 0e304391
      mjs authored
              Reviewed by Eric, landed by Maciej.
      
              * svg/custom/class-selector.svg: Added.
      
      WebCore:
      
              Reviewed by Eric, landed by Maciej.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7627:
              SVG from the W3C SVG 1.1 test suite (cubic01.svg) renders as all black
      
              Fix this svg stylesheet to use strict-mode, as this makes sure
              class selecting is done correctly.
      
              * ksvg2/svg/SVGStyleElement.cpp:
              (SVGStyleElement::childrenChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e304391
    • mjs's avatar
      Reviewed by Darin, landed by Maciej. · 15819bcb
      mjs authored
              * BuildSlaveSupport/build-launcher-app: Added.  Builds WebKit.app from WebKitLauncher
                and bundles the WebKit frameworks inside it.
              * BuildSlaveSupport/build-launcher-dmg: Added.  Builds, and optionally uploads, a disk image
                containing WebKit.app.
              * BuildSlaveSupport/run-performance-tests:  Use currentSVNRevision.
              * Scripts/webkitdirs.pm:  Add currentSVNRevision to retrieve the revision
                number of the SVN working copy.
              * WebKitLauncher: Added.
              * WebKitLauncher/Info.plist: Added.
              * WebKitLauncher/WebKitLauncher.xcodeproj: Added.
              * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Added.
              * WebKitLauncher/WebKitNightlyEnabler.m: Added.  This makes
                up the WebKitNightlyEnabler dylib which is loaded into Safari's address space
                to cause LaunchServices to treat Safari.app as WebKit.app when it is run from
                the nightly launcher.
              * WebKitLauncher/main.m: Added.  The WebKit.app launcher.
                It sets up the environment to have Safari use the bundled frameworks
                and load the WebKitNightlyEnabler dylib before exec'ing Safari
              * WebKitLauncher/start.html: Added.
              * WebKitLauncher/webkit.icns: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15819bcb
    • darin's avatar
      Reviewed by Maciej. · 2f078d34
      darin authored
              - fix memory leak introduced by the previous change
      
              * kxmlcore/HashTable.h: Specialize NeedsRef so that it correctly returns true when
              the value in question is a pair where one of the pair needs a ref and the other
              of the pair does not.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f078d34
    • justing's avatar
      Reviewed by mjs · 071662ae
      justing authored
              I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
              so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
              implicit removes.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      071662ae
    • justing's avatar
      Should fix the build · 2dcbd8e4
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dcbd8e4
    • mjs's avatar
      LayoutTests: · 9d8e6958
      mjs authored
              Reviewed by Anders.
      
              Update prototype chain for the following fix:
      
              - autogenerate bindings for all of the methods and properties of Document
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8163
      
              * fast/dom/prototype-chain-expected.txt:
      
      WebCore:
      
              Reviewed by Anders.
      
              - autogenerate bindings for all of the methods and properties of Document
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8163
      
              - also removed document.actualEncoding since it is not in any spec
              or implemented by any other browser
              
              * DerivedSources.make: add JSDocument.h to results
              * WebCore.xcodeproj/project.pbxproj: Added new files to project
              * bindings/scripts/CodeGeneratorJS.pm: Support for new stuff needed by Document.
              * dom/Document.cpp:
              (WebCore::Document::readyState): moved impl here from JS bindings
              (WebCore::Document::inputEncoding): ditto
              (WebCore::Document::defaultCharset): ditto
              (WebCore::Document::setCharset): ditto
              * dom/Document.h:
              (WebCore::Document::charset): added, synonym for inputEncoding.
              (WebCore::Document::characterSet): ditto
              * dom/Document.idl: Added. Full interface for the Document object.
              * khtml/ecma/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): JSDocument, not DOMDocument
              * khtml/ecma/JSXSLTProcessor.cpp:
              (KJS::XSLTProcessorProtoFunc::callAsFunction): ditto
              * khtml/ecma/kjs_binding.cpp:
              (KJS::jsStringOrFalse): Added this convenience for the method on Document
              that bizzarely returns false on failure and a string otherwise.
              * khtml/ecma/kjs_binding.h:
              * khtml/ecma/kjs_css.cpp:
              (KJS::toJS): renamed for consistency
              * khtml/ecma/kjs_css.h:
              * khtml/ecma/kjs_dom.cpp:
              - removed all traces of DOMDocument
              (KJS::toJS): JSDocument, not DOMDocument
              * khtml/ecma/kjs_dom.h:
              * khtml/ecma/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLDocument::JSHTMLDocument): inherit from JSDocument
              (KJS::JSHTMLDocument::getOwnPropertySlot): ditto
              (KJS::JSHTMLDocument::put): ditto
              * khtml/ecma/kjs_html.h:
              * khtml/ecma/kjs_traversal.cpp:
              (KJS::toJS): added overloads
              (KJS::toNodeFilter): handle JS functions as well as impl NodeFilter objects
              * khtml/ecma/kjs_traversal.h:
              * platform/AtomicString.h:
              (WebCore::AtomicString::AtomicString): Allow implicit conversion from String.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d8e6958
    • justing's avatar
      LayoutTests: · 277af6e9
      justing authored
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
              Hitting an assert on undo paste
      
              * editing/pasteboard/undoable-fragment-removes-expected.checksum: Added.
              * editing/pasteboard/undoable-fragment-removes-expected.png: Added.
              * editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
              * editing/pasteboard/undoable-fragment-removes.html: Added.
      
      WebCore:
      
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
              Hitting an assert on undo paste
              
              ReplaceSelectionCommand was doing a combination of undoable and non-undoable 
              removes from the ReplacementFragment.  On Undo Paste, the undoable removes 
              couldn't be undone because the tree was in a different state than it was
              at the time of the remove.  This patch makes all the removes from the fragment 
              non-undoable.  We could make them all undoable, but I can't think of any reason 
              why we'd want the fragment to be reconstructed on an Undo Paste.
      
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::doApply):
              Assert that the node to append isn't already in a tree, since if it is, it will 
              be removed in a non-undoable way.
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): 
              Nodes were being moved from the fragment to the document with undoable inserts.  
              Undoable inserts implicitly remove the node (in a non-undoable way) from its 
              old location if it is already in a tree.  I now explicitly remove the nodes 
              from the fragment before inserting them into the document to make it clear that 
              they are being removed in a non-non-undoable way.  I also changed the one undoable 
              remove from the fragment to a non-undoable remove.
              * editing/ReplaceSelectionCommand.h: 
              Made ReplacementFragment's non-undoable removeNode public.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      277af6e9
    • darin's avatar
      - fixed the build · d45728ec
      darin authored
              * WebCore.xcodeproj/project.pbxproj: Oops! Resolved merge conflict.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d45728ec
    • darin's avatar
      JavaScriptCore: · 6f2a3ef3
      darin authored
              Reviewed by Maciej.
      
              - JavaScriptCore part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8049
                StringImpl hash traits deleted value creates an init routine for WebCore
                <rdar://problem/4442248> REGRESSION: WebCore has init routines (8049)
      
              Change HashMap and HashSet implementation so they fold various types together.
              This allows us to implement maps and sets that use RefPtr<WebCore::StringImpl>
              and WebCore::String in terms of the underlying raw pointer type, and hence use
              -1 for the deleted value.
      
              * kxmlcore/HashTraits.h: Added a new type to HashTraits, StorageTraits, which is a
              type to be used when storing a value that has the same layout as the type itself.
              This is used only for non-key cases. In the case of keys, the hash function must also
              be considered. Moved emptyValue out of GenericHashTraitsBase into GenericHashTraits.
              Added a new bool to HashTraits, needsRef, which indicates whether the type needs
              explicit reference counting. If the type itself has needsRef true, but the storage
              type has needsRef false, then the HashSet or HashMap has to handle the reference
              counting explicitly. Added hash trait specializations for all signed integer values
              that give -1 as the deleted value. Gave all integers StorageTraits of the canonical
              integer type of the same size so int and long will share code. Gave all pointers and
              RefPtrs StorageTraits of the appropriately sized integer type. Removed redundant
              TraitType and emptyValue definitions in the pointer specialization for HashTraits.
              Added PairBaseHashTraits, which doesn't try to set up needsDestruction and deletedValue.
              Useful for types where we don't want to force the existence of deletedValue, such as
              the type of a pair in a HashMap which is not the actual storage type. Removed an
              unneeded parameter from the DeletedValueAssigner template. Added HashKeyStorageTraits
              template, which determines what type can be used to store a given hash key type with
              a given hash function, and specialized it for pointers and RefPtr so that pointer
              hash tables share an underlying HashTable that uses IntHash.
      
              * kxmlcore/HashTable.h: Added HashTableConstIteratorAdapter, HashTableIteratorAdapter,
              NeedsRef, RefCountManagerBase, RefCountManager, HashTableRefCountManagerBase, and
              HashTableRefCountManager. All are used by both HashSet and HashMap to handle hash
              tables where the type stored is not the same as the real value type.
              
              * kxmlcore/HashFunctions.h: Added a new struct named IntTypes that finds an
              integer type given a sizeof value. Renamed pointerHash to intHash and made it
              use overloading and take integer parameters. Added an IntHash struct which is
              a hash function that works for integers. Changed PtrHash to call IntHash with
              an appropriately sized integer. Made IntHash the default hash function for
              many integer types. Made PtrHash the default hash function for RefPtr as well
              as for raw pointers.
      
              * kxmlcore/HashSet.h: Changed implementation to use a separate "storage type"
              derived from the new traits. The HashTable will use the storage type and all
              necessary translation and ref/deref is done at the HashSet level. Also reorganized
              the file so that the HashSet is at the top and has no inline implementation inside
              it so it's easy to read the interface to HashSet.
      
              * kxmlcore/HashMap.h: Changed implementation to use a separate "storage type"
              derived from the new traits. The HashTable will use the storage type and all
              necessary translation and ref/deref is done at the HashMap level. Also reorganized
              the file so that the HashMap is at the top and has no inline implementation inside
              it so it's easy to read the interface to HashMap.
      
              * kxmlcore/HashMapPtrSpec.h: Removed. Superceded by optimizations in HashMap itself.
      
              * JavaScriptCore.xcodeproj/project.pbxproj: Remove HashMapPtrSpec.h, resort files,
              and also remove some unnecessary build settings from the aggregate target that
              generates derived sources.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8049
                StringImpl hash traits deleted value creates an init routine for WebCore
                <rdar://problem/4442248> REGRESSION: WebCore has init routines (8049)
      
              * platform/StringHash.h: Added. Moved hash functions and such for
              WebCore::String and friends into this file so we don't have to include
              the hash traits header everywhere. Changed hashing for WebCore::StringImpl
              and WebCore::String so that they use a raw pointer for the underlying
              storage type, taking advantage of the new feature added in JavaScriptCore.
      
              * platform/AtomicString.h: Moved StrHash specialization to StringHash.h.
              * platform/PlatformString.h: Moved StrHash specialization to StringHash.h.
              * platform/StringImpl.h: Moved StrHash, CaseInsensitiveHash, and HashTraits
              to StringHash.h. Left DefaultHash behind so that you can't get the wrong
              hash function by accident if you forget to include "StringHash.h".
      
              * platform/StringImpl.cpp: Added include of StringHash.h and removed
              RefPtr<StringImpl> HashTraits<RefPtr<StringImpl> >::_deleted, which is
              the object with a global initializer causing all the trouble!
      
              * kwq/AccessibilityObjectCache.h: Changed hash function to be IntHash
              instead of PtrHash.
      
              * dom/StyledElement.cpp: Changed MappedAttributeKeyTraits to inherit from
              the generic traits in KXMLCore so we get a StorageType. Also cleaned up a
              tiny bit by adding default values to the MappedAttributeKey constructor.
      
              * platform/CharsetNames.cpp: Changed hash traits here to be a new
              TextEncodingIDHashTraits struct rather than defining new default traits
              for the integer type since more integer types have default traits in
              HashTraits.h now. Also added a specialization so this class will share
              the underlying implementation (since InvalidEncoding happens to be -1).
      
              * bridge/mac/FrameMac.h:
              * dom/Document.h:
              * dom/xml_tokenizer.h:
              * khtml/xsl/XSLTProcessor.h:
              * kwq/JavaAppletWidget.h:
              * page/FramePrivate.h:
              * page/Page.cpp:
              * platform/AtomicString.cpp:
              * platform/TransferJob.h:
              * rendering/render_applet.h:
              Added include of StringHash.h.
      
              * WebCore.xcodeproj/project.pbxproj: Added StringHash.h. Remove unneeded
              CREATE_HASH_TABLE variable in build settings. Re-sorted some file lists.
              Added quotes to the CREATE_HASH_TABLE initialization in the rule that
              builds generated files. Removed various unneeded build settings for that
              target as well.
      
              * ForwardingHeaders/kxmlcore/HashTraits.h: Added.
      
              - other minor cleanup
      
              * bridge/mac/FrameMac.mm: Sorted includes.
              * dom/Node.cpp: Removed bogus symbol after #endif.
      
              * khtml/xsl/XSLTProcessor.cpp: Sorted includes. Removed redundant using
              namespace WebCore.
              * loader/Cache.cpp: Ditto.
      
      WebKitTools:
      
              Reviewed by Maciej.
      
              * Scripts/check-for-global-initializers: Remove StringImpl from the list of files that
              are allowed to have global initializers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f2a3ef3
    • bdakin's avatar
      Reviewed by Darin. · 422b505e
      bdakin authored
              Fix for <rdar://problem/4502311> text-transform:capitalize needs to 
              treat nbsp as a regular space when ICU changes
      
              There will be future changes in ICU to match the Unicode 4.1 
              standard which no longer recognizes &nbsp as a word separator. We 
              need to work around this with text-transform:capitalize because 
              words after non-breaking spaces still need to be capitalized.
      
              No layout tests added because existing layout tests cover this.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      422b505e
    • ap's avatar
      Reviewed by Darin. · b2508201
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8110
                Define navigator.vendorSub (bcms.gov.uk doesn't allow access to login page)
      
              Test: fast/dom/navigator-vendorSub.html
      
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::Navigator::getValueProperty): Return an empty string for vendorSub property.
              * khtml/ecma/kjs_navigator.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2508201
    • ggaren's avatar
      Reviewed by OMG BETH · a2350f18
      ggaren authored
              * Scripts/run-testkjs:
              - pipe STDERR to /dev/null by default; new --verbose option overrides
              this behavior
              - set DYLD_FRAMEWORK_PATH to the webkit-configured path
              - output run command in a format that can be copied and pasted into the
              terminal to run manually
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2350f18
  2. 04 Apr, 2006 21 commits
    • darin's avatar
      LayoutTests: · d497abd1
      darin authored
              Reviewed by Justin and Adele.
      
              * fast/forms/plaintext-mode-2-expected.txt: Updated because there's no longer
              and extra <div> element added.
      
      WebCore:
      
              Reviewed by Justin (editing parts) and Adele (the rest).
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8182
                some text-field-related layout tests are failing
      
              The smart paste code was getting confused and adding extra spaces.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Use isStartOfParagraph instead of
              isStartOfLine.
              (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto.
      
              * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::enclosingEmptyListItem):
              Change to call isStart/EndOfParagraph instead of Line.
      
              * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
              Add a comment about how isStartOfLine is almost certainly wrong here.
      
              - clean up some loose ends in the Frame class from the recent renaming
      
              * page/Frame.h: Removed declarations of deleteMe1, deleteMe2, and
              handleMouseMoveEventPart2.
              * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): Removed
              handleMouseMoveEventPart2 by renaming it to handleMouseMoveEvent and removing
              handleMouseMoveEvent itself.
      
              - invoke the makefile directly, removing the generate-derived-sources script
      
              * WebCore.vcproj/WebCore/build-generated-files.sh: Call make directly.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * generate-derived-sources: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d497abd1
    • hyatt's avatar
      Update table results after my change to create fewer RenderTexts. · 55da4f88
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55da4f88
    • hyatt's avatar
      Update fast results after my change to create fewer RenderTexts. · 1675e927
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1675e927
    • adele's avatar
      LayoutTests: · 2d3c49fd
      adele authored
              - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8158
              REGRESSION: Clicking past RTL text in a new text field puts the caret on the wrong side of the text
      
              * editing/selection/caret-rtl-expected.checksum: Added.
              * editing/selection/caret-rtl-expected.png: Added.
              * editing/selection/caret-rtl-expected.txt: Added.
              * editing/selection/caret-rtl.html: Added.
              * editing/selection/caret-rtl-2-expected.checksum: Added.
              * editing/selection/caret-rtl-2-expected.png: Added.
              * editing/selection/caret-rtl-2-expected.txt: Added.
              * editing/selection/caret-rtl-2.html: Added.
      
      WebCore:
      
              Reviewed by Justin.
      
              - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8158
              REGRESSION: Clicking past RTL text in a new text field puts the caret on the wrong side of the text
      
              Tests:
              editing/selection/caret-rtl.html
              editing/selection/caret-rtl-2.html
      
              * rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
              When calculating the position for the beginning or end of an InlineTextBox,
              we now use offsetForPosition instead of just using m_start and m_len, because
              offsetForPosition will take rtl text into account.  I also made some formatting
              changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d3c49fd
    • adele's avatar
      New results for · a447820e
      adele authored
              * fast/forms/input-truncate-newline-expected.txt
      
              Filed bug:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8187
              input-truncate-newline layout test fails when run as part of larger set of tests
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a447820e
    • hyatt's avatar
      Fix for bug 8065, inline blocks incorrectly loses spaces between them. · 5c143888
      hyatt authored
              Reviewed by beth
      
              * dom/Text.cpp:
              (WebCore::Text::rendererIsNeeded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c143888
    • adele's avatar
      LayoutTests: · f187f353
      adele authored
               - Test for:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
              REGRESSION (NativeTextField): table contents misaligned in Netflix queue
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
              REGRESSION: Native text field fails to wrap inside table
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
              REGRESSION: text fields at connect.apple.com spill out of the containing box
      
              * fast/forms/input-table-expected.checksum: Added.
              * fast/forms/input-table-expected.png: Added.
              * fast/forms/input-table-expected.txt: Added.
              * fast/forms/input-table.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - Fix for:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
              REGRESSION (NativeTextField): table contents misaligned in Netflix queue
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
              REGRESSION: Native text field fails to wrap inside table
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
              REGRESSION: text fields at connect.apple.com spill out of the containing box
      
              Test: fast/forms/input-table.html
      
              Rewrote calcMinMaxWidth for text fields so it considers width, 
              min-width, and max-width settings as well as the size attribute.
      
              * rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f187f353
    • bdakin's avatar
      Reviewed by Darin. · 10390e26
      bdakin authored
              This is a followup to my fix for <rdar://problem/4493218>
              
              This patch re-names computeIntLength() and computerShortLength() to 
              be computeLengthInt() and computeLengthShort(), respectively, to 
              match the pre-existing computeLengthFloat(). This patch also adds 
              the slightly confusing-ly named computeLengthIntForLength() which 
              uses the max and min values of a 28-bit integer as bounds for 
              overflow. This function is necessary because Length objects expect 
              28-bit integers. 
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10390e26
    • thatcher's avatar
      JavaScriptCore: · 8e5a95c7
      thatcher authored
              Reviewed by Darin.
      
              The Debug and Release frameworks are now built with install paths relative to the build products directory.
              This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore. 
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      JavaScriptGlue:
      
              Reviewed by Darin.
      
              The Debug and Release frameworks are now built with install paths relative to the build products directory.
              This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore. 
      
              * JavaScriptGlue.xcodeproj/project.pbxproj:
      
      WebCore:
      
              Reviewed by Darin.
      
              The Debug and Release frameworks are now built with install paths relative to the build products directory.
              This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore. 
      
              * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
              Reviewed by Darin.
      
              The Debug and Release frameworks are now built with install paths relative to the build products directory.
              This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore. 
      
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e5a95c7
    • justing's avatar
      LayoutTests: · 217ded8c
      justing authored
              Reviewed by darin
      
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
              REGRESSION: Line disappears when deleting
      
              Added:
              * editing/deleting/merge-different-styles-expected.checksum: Added.
              * editing/deleting/merge-different-styles-expected.png: Added.
              * editing/deleting/merge-different-styles-expected.txt: Added.
              * editing/deleting/merge-different-styles.html: Added.
              * editing/deleting/merge-no-br-expected.checksum: Added.
              * editing/deleting/merge-no-br-expected.png: Added.
              * editing/deleting/merge-no-br-expected.txt: Added.
              * editing/deleting/merge-no-br.html: Added.
              * editing/deleting/merge-whitespace-pre-expected.checksum: Added.
              * editing/deleting/merge-whitespace-pre-expected.png: Added.
              * editing/deleting/merge-whitespace-pre-expected.txt: Added.
              * editing/deleting/merge-whitespace-pre.html: Added.
      
              Fixes (not enough style on nodes for the fixes to be reflected in pixel results):
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
      
              Equivalent render trees:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              
              Forgot to checkin these new expected results after fixing the DRT bug:
              * fast/lists/drag-into-marker-expected.checksum:
              * fast/lists/drag-into-marker-expected.png:
              * fast/lists/drag-into-marker-expected.txt:
      
      WebCore:
      
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
              REGRESSION: Line disappears when deleting
              
              Rewrote moveNodesAfterNode to address these problems:
              It moved nodes without preserving their style. 
              It traversed over siblings looking for a br to know when
              to stop merging.  If the br was burried inside a span, it 
              wouldn't find it.  If the text is whitespace:pre, it wouldn't
              stop.
              In theory it would crash if the "enclosingInlineElements" of the start of the
              selection to delete and the end of the selection to delete were the
              same.  We think that this will fix these:
              <rdar://problems/3950559&4498113>
              CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
              CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
              But we haven't been able to construct a reproducible case.
              
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand.
              (WebCore::CompositeEditCommand::prune): Ditto.
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
              (WebCore::DeleteSelectionCommand::doApply):
              * editing/DeleteSelectionCommand.h:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::):
              * editing/markup.cpp:
              (WebCore::createMarkup): 
              Was crashing when passed a collapsed range.  I early return an empty string instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      217ded8c
    • eseidel's avatar
      2006-04-04 Eric Seidel <eseidel@apple.com> · b7b8a03c
      eseidel authored
              Reviewed by ggaren.
      
              Fix win32 build.
              Disable ASSERT redefinition warnings for now.
      
              * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
              * kxmlcore/Assertions.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7b8a03c
    • sullivan's avatar
      Reviewed by Adele Peterson. · 44dd52ca
      sullivan authored
              - WebKit part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
      
              * WebView/WebView.m:
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
              Pass private browsing setting down to WebCore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dd52ca
    • sullivan's avatar
      Reviewed by Adele Peterson. · faf563bd
      sullivan authored
              
              - WebCore part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
      
              * bridge/mac/WebCoreSettings.h:
              * bridge/mac/WebCoreSettings.mm:
              (-[WebCoreSettings setPrivateBrowsingEnabled:]):
              (-[WebCoreSettings privateBrowsingEnabled]):
              Teach WebCoreSettings about private browsing (WebKit knew, but WebCore didn't)
              
              * kwq/KWQKHTMLSettings.h:
              (KHTMLSettings::privateBrowsingEnabled):
              (KHTMLSettings::setPrivateBrowsingEnabled):
              Teach KHTMLSettings about private browsing
              
              * kwq/KWQLineEdit.mm:
              Fix wrong class in a category method declaration; the compiler didn't seem to mind.
              
              * kwq/WebCoreTextField.mm:
              (-[KWQSearchFieldCell _addStringToRecentSearches:]):
              Override this method to bail out if private browsing is enabled.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf563bd
    • darin's avatar
      Reviewed by Hyatt. · dfe48e15
      darin authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7951
              REGRESSION: Safari crashes when printing a google map w/directions
      
              Tests: none, because I believe it only happens when printing, due to the relayouts
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::recalcSectionsIfNeeded): Add new utility to let the cells
              ensure the sections' grid data is up to date.
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::calcMinMaxWidth):  Call above method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfe48e15
    • eseidel's avatar
      2006-04-04 Bjrn Graf <bjoern.graf@gmail.com> · 251208b0
      eseidel authored
              Reviewed by ggaren & darin.  Landed by eseidel.
      
              Integrate CURL version of gettimeofday
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7399
              Disable crash report dialogs for testkjs.exe in Release mode
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8113
      
              * kjs/testkjs.cpp:
              (StopWatch::start):
              (StopWatch::stop):
              (StopWatch::getElapsedMS):
              (main):
              (kjsmain):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      251208b0
    • eseidel's avatar
      2006-04-03 Justin Haygood <jhaygood@spsu.edu> · 5fbf0b2c
      eseidel authored
              Reviewed by eseidel.  Landed by eseidel.
      
              - WIN32: maximumScroll() is the maximum scroll delta, not the maximum scroll position. Update to use
                the real maximum scroll position.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8160
      
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::updateScrollBars):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fbf0b2c
    • eseidel's avatar
      2006-04-04 Eric Seidel <eseidel@apple.com> · 6e43a9f7
      eseidel authored
              Reviewed by andersca.
      
              Work-around spaces-in-pathnames issue in gnumake on win32.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8173
      
              * WebCore.vcproj/WebCore/build-generated-files.sh:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e43a9f7
    • eseidel's avatar
      2006-04-04 Eric Seidel <eseidel@apple.com> · 129ad882
      eseidel authored
              Reviewed by mjs.
      
              * kjs/number_object.cpp:
              (NumberProtoFunc::callAsFunction): remove trunc() to fix win32.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      129ad882
    • mjs's avatar
      Reviewed by Darin. · d19ac207
      mjs authored
              
              - fixed "toPrecision sometimes messes up the last digit on intel Macs"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7748
      
              * kjs/number_object.cpp:
              (intPow10): Compute integer powers of 10 using exponentiation by squaring.
              (NumberProtoFunc::callAsFunction): Use intPow10(n) in place of all pow(10.0, n),
              plus a bit of refactoring.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d19ac207
    • darin's avatar
      - tried to fix build again · 4660cad6
      darin authored
              * WebCore.xcodeproj/project.pbxproj: Removed JSStyleSheet files.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4660cad6
    • darin's avatar
      - fixed properties on a bunch of files · 8e8fb9ca
      darin authored
                (removed allow-tabs and svn:executable from many)
      
              * css/css_base.cpp:
              * html/html_headimpl.cpp:
              * khtml/ecma/kjs_traversal.cpp:
              * kwq/DeprecatedPtrListImpl.cpp:
              * kwq/DeprecatedValueListImpl.cpp:
              * loader/CachedScript.h:
              * platform/ArrayImpl.cpp:
              * platform/StringImpl.cpp:
              * rendering/DataRef.h:
              * rendering/RenderContainer.cpp:
              * rendering/RenderTableCell.cpp:
              * rendering/bidi.h:
              * rendering/render_list.cpp:
              * rendering/render_style.cpp:
              * rendering/table_layout.h:
              Converted tabs to spaces.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e8fb9ca
  3. 03 Apr, 2006 3 commits