1. 14 Mar, 2011 40 commits
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · aea439d1
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              EventHandler calls shouldChangeSelection needlessly
              https://bugs.webkit.org/show_bug.cgi?id=56324
      
              Extracted setSelectionIfNeeded and setNonDirectionalSelectionIfNeeded and
              avoided calling shouldChangeSelection and setSelection when the existing
              selection is identical to that of new selection.
      
              * page/EventHandler.cpp:
              (WebCore::setSelectionIfNeeded): Extracted.
              (WebCore::setNonDirectionalSelectionIfNeeded): Extracted.
              (WebCore::EventHandler::selectClosestWordFromMouseEvent): Calls a helper function above.
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Ditto.
              (WebCore::EventHandler::handleMousePressEventTripleClick): Ditto.
              (WebCore::EventHandler::handleMousePressEventSingleClick): Ditto.
              (WebCore::EventHandler::updateSelectionForMouseDrag): Ditto.
              (WebCore::EventHandler::handleMouseReleaseEvent): Ditto.
      2011-03-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * platform/chromium/test_expectations.txt: Temporary suppress text differences.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aea439d1
    • antonm@chromium.org's avatar
      2011-03-14 Anton Muhin <antonm@chromium.org> · 8675b60b
      antonm@chromium.org authored
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * platform/chromium/test_expectations.txt: Temporary suppress text differences.
      2011-03-14  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Adam Barth.
      
              [v8] Rework object group building.
              https://bugs.webkit.org/show_bug.cgi?id=55399
      
              Instead of going top-down (from owner to owned elements), go up---from objects
              to their group ids.  That fits better to v8's object grouping model and guarantees
              that each wrapper belongs to the single group.
      
              Alas, this cannot be implemented for one kind of objects---CSSProperties.
      
              Part of core GC algorithm and tested extensively by exisiting layout tests.
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/V8/V8TestInterface.cpp:
              * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              * bindings/v8/V8GCController.cpp:
              (WebCore::calculateGroupId):
              (WebCore::calculateRootStyleSheet):
              (WebCore::GrouperVisitor::visitDOMWrapper):
              (WebCore::GrouperVisitor::applyGrouping):
              (WebCore::V8GCController::gcPrologue):
              * bindings/v8/WrapperTypeInfo.h:
              (WebCore::WrapperTypeInfo::isSubclass):
              * css/CSSRuleList.h:
              (WebCore::CSSRuleList::styleList):
              * css/StyleSheetList.h:
              (WebCore::StyleSheetList::document):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8675b60b
    • luiz@webkit.org's avatar
      3482a00c
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 50eab63b
      rniwa@webkit.org authored
              Mac Leopard rebaselines for r81053 (Grabbed off of Chromium bots).
      
              * platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.checksum:
              * platform/mac-leopard/fast/text/atsui-rtl-override-selection-expected.png:
              * platform/mac-leopard/editing/selection/drag-select-1-expected.checksum:
              * platform/mac-leopard/editing/selection/drag-select-1-expected.png:
              * platform/mac-leopard/editing/selection/fake-drag-expected.checksum:
              * platform/mac-leopard/editing/selection/fake-drag-expected.png:
              * platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.checksum:
              * platform/mac-leopard/editing/selection/inline-closest-leaf-child-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50eab63b
    • tkent@chromium.org's avatar
      Assertion failure by form validation message for <select required> with float:left · 32441d26
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=55995
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Test: fast/forms/interactive-validation-select-crash.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::canMergeContiguousAnonymousBlocks):
        isAnonymousBlock() doesn't mean it is a RenderBlock. We need to check isRenderBlock().
      
      LayoutTests:
      
      * fast/forms/interactive-validation-select-crash-expected.txt: Added.
      * fast/forms/interactive-validation-select-crash.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32441d26
    • msaboff@apple.com's avatar
      2011-03-14 Michael Saboff <msaboff@apple.com> · f468550b
      msaboff@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Look-ahead assertions with back references don’t work as expected
              https://bugs.webkit.org/show_bug.cgi?id=56082
      
              Changed parentheses assertion processing to temporarily back out the 
              number of known characters after the assertion while processing the 
              assertion.  This was done so that assertions don't fail due to 
              checking the number of required characters as additional to the 
              rest of the express since assertions don't "consume" input.
              Added a byte code to uncheck characters to support the change.
      
              * yarr/YarrInterpreter.cpp:
              (JSC::Yarr::Interpreter::matchDisjunction):
              (JSC::Yarr::ByteCompiler::uncheckInput):
              (JSC::Yarr::ByteCompiler::emitDisjunction):
              * yarr/YarrInterpreter.h:
              (JSC::Yarr::ByteTerm::UncheckInput):
      2011-03-14  Michael Saboff  <msaboff@apple.com>
      
              Reviewed by Gavin Barraclough.
      
              Look-ahead assertions with back references don’t work as expected
              https://bugs.webkit.org/show_bug.cgi?id=56082
      
              New tests to verify the corresponding changes.
      
              * fast/regex/assertion-expected.txt: Added.
              * fast/regex/assertion.html: Added.
              * fast/regex/script-tests/assertion.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f468550b
    • levin@chromium.org's avatar
      It's the same old song (about the linux debug crash). · 87211842
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87211842
    • levin@chromium.org's avatar
      Add more linux debug crashers to the sad list. · 6e90ab69
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e90ab69
    • mrobinson@webkit.org's avatar
      2011-03-14 Martin Robinson <mrobinson@igalia.com> · b8dfaa95
      mrobinson@webkit.org authored
              Update GTK+ pixel results after r81053.
      
              * platform/gtk/editing/selection/drag-select-1-expected.checksum:
              * platform/gtk/editing/selection/drag-select-1-expected.png:
              * platform/gtk/editing/selection/fake-drag-expected.checksum: Added.
              * platform/gtk/editing/selection/fake-drag-expected.png: Added.
              * platform/gtk/editing/selection/inline-closest-leaf-child-expected.checksum: Added.
              * platform/gtk/editing/selection/inline-closest-leaf-child-expected.png: Added.
              * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
              * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
              * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8dfaa95
    • levin@chromium.org's avatar
      Upstream test expectations from the chromium repository to WebKit. · d61cca8e
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d61cca8e
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 1de9ea46
      rniwa@webkit.org authored
              Mac pixel rebaselines for r81053.
      
              * platform/mac/editing/selection/drag-select-1-expected.checksum:
              * platform/mac/editing/selection/drag-select-1-expected.png:
              * platform/mac/editing/selection/fake-drag-expected.checksum:
              * platform/mac/editing/selection/fake-drag-expected.png:
              * platform/mac/fast/text/atsui-rtl-override-selection-expected.checksum:
              * platform/mac/fast/text/atsui-rtl-override-selection-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1de9ea46
    • levin@chromium.org's avatar
      Update the chromium windows baselines for r81053. · 8a471452
      levin@chromium.org authored
      * platform/chromium-win/editing/selection/drag-select-1-expected.checksum:
      * platform/chromium-win/editing/selection/drag-select-1-expected.png:
      * platform/chromium-win/editing/selection/drag-select-1-expected.txt:
      * platform/chromium-win/editing/selection/fake-drag-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      * platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a471452
    • rniwa@webkit.org's avatar
      Fixed typo in the change log entry for r81066. · d866f720
      rniwa@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d866f720
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · c7aba117
      rniwa@webkit.org authored
              GTK rebaselines or r81053.
      
              * platform/gtk/editing/selection/drag-select-1-expected.txt:
              * platform/gtk/editing/selection/fake-drag-expected.txt:
              * platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
              * platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
              * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
              * platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
              * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7aba117
    • levin@chromium.org's avatar
      Add rebaselines due to two changes: · b73df83e
      levin@chromium.org authored
      For r81053, we have
         editing/selection/drag-select-1.html, editing/selection/fake-drag.html, svg/custom/mouse-move-on-svg-container-standalone.svg,
         svg/custom/mouse-move-on-svg-container.xhtml, svg/custom/mouse-move-on-svg-root-standalone.svg, svg/custom/mouse-move-on-svg-root.xhtml
      
      For r81049, we have
         fast/table/overflowHidden.html, fast/table/relative-position-containment.html, fast/table/relative-position-offsets.html, fast/table/relative-position-stacking.html
      
      * platform/chromium-linux/editing/selection/drag-select-1-expected.checksum:
      * platform/chromium-linux/editing/selection/drag-select-1-expected.png:
      * platform/chromium-linux/editing/selection/drag-select-1-expected.txt: Added.
      * platform/chromium-linux/editing/selection/fake-drag-expected.txt: Added.
      * platform/chromium-linux/fast/table/relative-position-containment-expected.checksum: Added.
      * platform/chromium-linux/fast/table/relative-position-containment-expected.png: Added.
      * platform/chromium-linux/fast/table/relative-position-offsets-expected.checksum: Added.
      * platform/chromium-linux/fast/table/relative-position-offsets-expected.png: Added.
      * platform/chromium-linux/fast/table/relative-position-stacking-expected.checksum: Added.
      * platform/chromium-linux/fast/table/relative-position-stacking-expected.png: Added.
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
      * platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
      * platform/chromium-win/fast/table/overflowHidden-expected.txt:
      * platform/chromium-win/fast/table/relative-position-containment-expected.checksum: Added.
      * platform/chromium-win/fast/table/relative-position-containment-expected.png: Added.
      * platform/chromium-win/fast/table/relative-position-containment-expected.txt: Added.
      * platform/chromium-win/fast/table/relative-position-offsets-expected.checksum: Added.
      * platform/chromium-win/fast/table/relative-position-offsets-expected.png: Added.
      * platform/chromium-win/fast/table/relative-position-offsets-expected.txt: Added.
      * platform/chromium-win/fast/table/relative-position-stacking-expected.checksum: Added.
      * platform/chromium-win/fast/table/relative-position-stacking-expected.png: Added.
      * platform/chromium-win/fast/table/relative-position-stacking-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b73df83e
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 89647c8f
      rniwa@webkit.org authored
              Removed redundant baselines from Windows port so that rebaselines done in r81059 take effect.
      
              * platform/win/svg/custom/mouse-move-on-svg-container-expected.txt: Removed.
              * platform/win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Removed.
              * platform/win/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
              * platform/win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89647c8f
    • luiz@webkit.org's avatar
      Adjusting Snow Leopard expected results after r81035. · accda4d1
      luiz@webkit.org authored
      * platform/mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-1-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-10-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-2-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-3-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-4-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-5-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-6-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-7-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-8-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-add-summary-9-expected.txt: Added.
      * platform/mac/fast/html/details-no-summary1-expected.txt: Added.
      * platform/mac/fast/html/details-no-summary2-expected.txt: Added.
      * platform/mac/fast/html/details-no-summary3-expected.txt: Added.
      * platform/mac/fast/html/details-no-summary4-expected.txt: Added.
      * platform/mac/fast/html/details-open-javascript-expected.txt: Added.
      * platform/mac/fast/html/details-open1-expected.txt: Added.
      * platform/mac/fast/html/details-open2-expected.txt: Added.
      * platform/mac/fast/html/details-open3-expected.txt: Added.
      * platform/mac/fast/html/details-open4-expected.txt: Added.
      * platform/mac/fast/html/details-open5-expected.txt: Added.
      * platform/mac/fast/html/details-open6-expected.txt: Added.
      * platform/mac/fast/html/details-position-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-1-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-2-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-3-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-4-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-5-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
      * platform/mac/fast/html/details-remove-summary-6-expected.txt: Added.
      * platform/mac/fast/html/details-writing-mode-expected.txt: Added.
      * platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      accda4d1
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 55e11c9c
      rniwa@webkit.org authored
              Qt rebaselines for r81053.
      
              * platform/qt/editing/selection/drag-select-1-expected.txt:
              * platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
              * platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
              * platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
              * platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55e11c9c
    • rniwa@webkit.org's avatar
      2011-03-14 Ryosuke Niwa <rniwa@webkit.org> · 812789cb
      rniwa@webkit.org authored
              Mac rebaselines for r81053.
      
              * platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt:
              * platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      812789cb
    • aestes@apple.com's avatar
      2011-03-13 Andy Estes <aestes@apple.com> · 6e4d5b2f
      aestes@apple.com authored
              Reviewed by Darin Adler.
      
              Timer-based events should inherit the user gesture state of their
              originating event in certain cases.
              https://bugs.webkit.org/show_bug.cgi?id=55104
      
              * fast/events/popup-blocking-timers-expected.txt: Added.
              * fast/events/popup-blocking-timers.html: Added.
      2011-03-14  Andy Estes  <aestes@apple.com>
      
              Reviewed by Darin Adler.
      
              Timer-based events should inherit the user gesture state of their
              originating event in certain cases.
              https://bugs.webkit.org/show_bug.cgi?id=55104
      
              If a timer is installed by a gesture-originated event and will fire
              within one second, the timer-initiated event should behave as if it
              were also initiated by a user gesture. Multi-shot timers should only
              get this behavior on their first execution. Nested timers should not
              get this behavior. This makes us compatible with Gecko when handling
              popups and file chooser dialogs created from timer events.
      
              Test: fast/events/popup-blocking-timers.html
      
              * page/DOMTimer.cpp:
              (WebCore::timeoutId): Create a helper function so that m_timeoutId can
              be initialized in the data member initialization list.
              (WebCore::shouldForwardUserGesture): Ditto, but for
              m_shouldForwardUserGesture.
              (WebCore::DOMTimer::DOMTimer): Move initialization of data members from
              the ctor body to the data member initialization list. Also rename the
              argument 'timeout' to 'interval'.
              (WebCore::DOMTimer::fired): Create a UserGestureIndicator and set its
              state based on the value of m_shouldForwardUserGesture.
              (WebCore::DOMTimer::adjustMinimumTimerInterval): m_originalTimeout was
              renamed to m_originalInterval.
              * page/DOMTimer.h: Add m_shouldForwardUserGesture and rename
              m_originalTimeout to m_originalInterval.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e4d5b2f
    • leviw@chromium.org's avatar
      2011-03-09 Levi Weintraub <leviw@chromium.org> · 688f641f
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Deleting content directly following a button inserts an unnecessary placeholder
              https://bugs.webkit.org/show_bug.cgi?id=56053
      
              Test to ensure unnecessary placeholders aren't inserted after buttons when delete is pressed.
      
              * editing/deleting/delete-inserts-br-after-button-expected.txt: Added.
              * editing/deleting/delete-inserts-br-after-button.html: Added.
      2011-03-09  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Deleting content directly following a button inserts an unnecessary placeholder
              https://bugs.webkit.org/show_bug.cgi?id=56053
      
              Fixing a use of Node's enclosingBlockFlowElement with enclosingBlock htmlediting's
              enclosingBlock, as enclosingBlockFlowElement would return inline-block elements despite
              DeleteSelectionCommand treating them as blockflow.
      
              Test: editing/deleting/delete-inserts-br-after-button.html
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      688f641f
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=45164 · da170758
      hyatt@apple.com authored
      Reviewed by Dan Bernstein.
      
      REGRESSION: <a><img align=top></a> Clickable area too large
              
      Make sure to clamp hit testing of quirky inline flow boxes the same way we already clamped
      painting.
      
      Source/WebCore: 
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::nodeAtPoint):
      
      LayoutTests: 
      
      * fast/inline/inline-position-top-align-expected.txt: Added.
      * fast/inline/inline-position-top-align.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da170758
    • rniwa@webkit.org's avatar
      2011-03-11 Ryosuke Niwa <rniwa@webkit.org> · f018c464
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              Selection uses first mousemove's localRect instead of that of mousedown
              https://bugs.webkit.org/show_bug.cgi?id=56213
      
              Fixed the bug by adding an extra call to updateSelectionForMouseDrag in handleMouseDraggedEvent
              using the mouse coordinates of the mousedown event that started the drag.
      
              Test: editing/selection/drag-select-rapidly.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseDraggedEvent):
      2011-03-11  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Tony Chang.
      
              Selection uses first mousemove's localRect instead of that of mousedown
              https://bugs.webkit.org/show_bug.cgi?id=56213
      
              Added a test to ensure the selection start is computed using the mouse coordinates passed down
              to the corresponding mousedown event instead of that of the first mousemove event.
      
              The test is co-authored by Evan Martin.
      
              * editing/selection/anchor-focus2-expected.txt: Editing delegate changes.
              * editing/selection/anchor-focus3-expected.txt: Ditto.
              * editing/selection/drag-select-rapidly-expected.txt: Added.
              * editing/selection/drag-select-rapidly.html: Added.
              * platform/mac/editing/selection/drag-select-1-expected.txt: Selects the correct range of text.
              * platform/mac/editing/selection/fake-drag-expected.txt: Ditto.
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f018c464
    • levin@chromium.org's avatar
      Add a baseline for linux for this test since it matches what we have for OSX · 01abfaa3
      levin@chromium.org authored
      except for the typical minor font differences.
      
      * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
      * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
      * platform/chromium-linux/css2.1/t1008-c44-ln-box-02-d-ag-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01abfaa3
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=56246 · dc8d43d5
      hyatt@apple.com authored
              
      Reviewed by Beth Dakin.
      
      Add support for relative positioning to table cells.   Back out the code that hacked around the lack of support
      for offsetLeft, and add new tests to demonstrate that relative positioning works.
      
      Source/WebCore: 
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::adjustRenderStyle):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::offsetParent):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::isRelPositioned):
      * rendering/RenderTableCell.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      
      LayoutTests: 
      
      * fast/table/relative-position-containment.html: Added.
      * fast/table/relative-position-offsets.html: Added.
      * fast/table/relative-position-stacking.html: Added.
      * platform/mac/fast/table/overflowHidden-expected.txt:
      * platform/mac/fast/table/relative-position-containment-expected.checksum: Added.
      * platform/mac/fast/table/relative-position-containment-expected.png: Added.
      * platform/mac/fast/table/relative-position-containment-expected.txt: Added.
      * platform/mac/fast/table/relative-position-offsets-expected.checksum: Added.
      * platform/mac/fast/table/relative-position-offsets-expected.png: Added.
      * platform/mac/fast/table/relative-position-offsets-expected.txt: Added.
      * platform/mac/fast/table/relative-position-stacking-expected.checksum: Added.
      * platform/mac/fast/table/relative-position-stacking-expected.png: Added.
      * platform/mac/fast/table/relative-position-stacking-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc8d43d5
    • levin@chromium.org's avatar
      Improvements for the mondo linux debug failure list changes: · 83778ab3
      levin@chromium.org authored
       + Add more tests that belong there.
       + Sort the tests that are there.
       + Add PASS to the lines that are there since these tests are known to pass and a passing
         result for them shouldn't cause a test run to go orange.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83778ab3
    • levin@chromium.org's avatar
      Rebaselines due to r81035. · 5b1e784b
      levin@chromium.org authored
      Also, added yet more tests to the linux debug crash sweeping through the layout tests.
      
      * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-1-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-10-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-2-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-3-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-4-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-5-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-6-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-7-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-8-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-add-summary-9-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
      * platform/chromium-linux/fast/html/details-no-summary1-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
      * platform/chromium-linux/fast/html/details-no-summary2-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
      * platform/chromium-linux/fast/html/details-no-summary3-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
      * platform/chromium-linux/fast/html/details-no-summary4-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open-javascript-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open1-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open1-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open2-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open2-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open3-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open3-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open4-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open4-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open5-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open5-expected.png: Added.
      * platform/chromium-linux/fast/html/details-open6-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-open6-expected.png: Added.
      * platform/chromium-linux/fast/html/details-position-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-position-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-1-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-2-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-3-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-4-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-5-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-6-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
      * platform/chromium-linux/fast/html/details-writing-mode-expected.checksum: Added.
      * platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-1-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-1-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-10-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-10-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-2-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-2-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-3-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-3-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-4-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-4-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-5-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-5-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-6-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-6-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-7-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-7-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-8-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-8-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-add-summary-9-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
      * platform/chromium-mac/fast/html/details-add-summary-9-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-no-summary1-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
      * platform/chromium-mac/fast/html/details-no-summary1-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-no-summary2-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
      * platform/chromium-mac/fast/html/details-no-summary2-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-no-summary3-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
      * platform/chromium-mac/fast/html/details-no-summary3-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-no-summary4-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
      * platform/chromium-mac/fast/html/details-no-summary4-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open-javascript-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open-javascript-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open1-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open1-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open1-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open2-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open2-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open2-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open3-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open3-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open3-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open4-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open4-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open4-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open5-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open5-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open5-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-open6-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-open6-expected.png: Added.
      * platform/chromium-mac/fast/html/details-open6-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-position-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-position-expected.png: Added.
      * platform/chromium-mac/fast/html/details-position-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-1-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-1-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-2-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-2-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-3-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-3-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-4-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-4-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-5-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-5-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-6-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
      * platform/chromium-mac/fast/html/details-remove-summary-6-expected.txt: Added.
      * platform/chromium-mac/fast/html/details-writing-mode-expected.checksum: Added.
      * platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
      * platform/chromium-mac/fast/html/details-writing-mode-expected.txt: Added.
      * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-1-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-1-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-1-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-10-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-10-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-10-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-2-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-2-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-2-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-3-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-3-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-3-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-4-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-4-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-4-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-5-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-5-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-5-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-6-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-6-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-6-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-7-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-7-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-7-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-8-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-8-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-8-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-add-summary-9-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-add-summary-9-expected.png: Added.
      * platform/chromium-win/fast/html/details-add-summary-9-expected.txt: Added.
      * platform/chromium-win/fast/html/details-no-summary1-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-no-summary1-expected.png: Added.
      * platform/chromium-win/fast/html/details-no-summary1-expected.txt: Added.
      * platform/chromium-win/fast/html/details-no-summary2-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-no-summary2-expected.png: Added.
      * platform/chromium-win/fast/html/details-no-summary2-expected.txt: Added.
      * platform/chromium-win/fast/html/details-no-summary3-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-no-summary3-expected.png: Added.
      * platform/chromium-win/fast/html/details-no-summary3-expected.txt: Added.
      * platform/chromium-win/fast/html/details-no-summary4-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-no-summary4-expected.png: Added.
      * platform/chromium-win/fast/html/details-no-summary4-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open-javascript-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open-javascript-expected.png: Added.
      * platform/chromium-win/fast/html/details-open-javascript-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open1-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open1-expected.png: Added.
      * platform/chromium-win/fast/html/details-open1-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open2-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open2-expected.png: Added.
      * platform/chromium-win/fast/html/details-open2-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open3-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open3-expected.png: Added.
      * platform/chromium-win/fast/html/details-open3-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open4-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open4-expected.png: Added.
      * platform/chromium-win/fast/html/details-open4-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open5-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open5-expected.png: Added.
      * platform/chromium-win/fast/html/details-open5-expected.txt: Added.
      * platform/chromium-win/fast/html/details-open6-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-open6-expected.png: Added.
      * platform/chromium-win/fast/html/details-open6-expected.txt: Added.
      * platform/chromium-win/fast/html/details-position-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-position-expected.png: Added.
      * platform/chromium-win/fast/html/details-position-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-1-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-1-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-1-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-2-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-2-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-2-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-3-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-3-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-3-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-4-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-4-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-4-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-5-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-5-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-5-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
      * platform/chromium-win/fast/html/details-remove-summary-6-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-remove-summary-6-expected.png: Added.
      * platform/chromium-win/fast/html/details-remove-summary-6-expected.txt: Added.
      * platform/chromium-win/fast/html/details-writing-mode-expected.checksum: Added.
      * platform/chromium-win/fast/html/details-writing-mode-expected.png: Added.
      * platform/chromium-win/fast/html/details-writing-mode-expected.txt: Added.
      * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b1e784b
    • jer.noble@apple.com's avatar
      2011-03-12 Jer Noble <jer.noble@apple.com> · 67f9c90a
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              FullScreen: Handle entering full screen security restrictions
              https://bugs.webkit.org/show_bug.cgi?id=56264
      
              * fullscreen/full-screen-css.html: Use runWithKeyDown.
              * fullscreen/full-screen-remove-ancestor.html: Ditto.
              * fullscreen/full-screen-remove.html: Ditto.
              * fullscreen/full-screen-request.html: Ditto.
              * fullscreen/full-screen-twice.html: Ditto.
              * fullscreen/full-screen-test.js:
              * fullscreen/full-screen-iframe-allowed-expected.txt: Added.
              * fullscreen/full-screen-iframe-allowed.html: Added.
              * fullscreen/full-screen-iframe-not-allowed-expected.txt: Added.
              * fullscreen/full-screen-iframe-not-allowed.html: Added.
              (runWithKeyDown): Added.  Wraps the command in a keyDown/keyPress
                  listener.
              * platform/mac-wk2/Skipped: Added new tests to skipped list.
              * platform/qt-wk2/Skipped: Ditto.
      2011-03-13  Jer Noble  <jer.noble@apple.com>
      
              FullScreen: Handle entering full screen security restrictions
              https://bugs.webkit.org/show_bug.cgi?id=56264
      
              Tests: fullscreen/full-screen-iframe-allowed.html
                     fullscreen/full-screen-iframe-not-allowed.html
      
              Disable full screen documents in the following conditions:
              1) requesting element is in an iframe which does not have a
              webkitallowfullscreen attribute.
              2) page is not processing a user gesture.
      
              * dom/Document.cpp:
              (WebCore::Document::fullScreenIsAllowedForElement): Added.  Checks
                  to see if elements contained in IFRAMES are allowed to
                  enter full screen.
              (WebCore::Document::webkitRequestFullScreenForElement): Checks
                  if page is currently processing a user gesture.
              * dom/Document.h:
              * html/HTMLAttributeNames.in: Added webkitallowfullscreenAttr.
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::allowFullScreen): Added.
              * html/HTMLFrameElementBase.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67f9c90a
    • luiz@webkit.org's avatar
      HTML5 <details> and <summary>: rendering · fb0b8be9
      luiz@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=51071
      
      Reviewed by Dave Hyatt.
      
      Source/WebCore:
      
      Tests: fast/html/details-add-summary-1-and-click.html
             fast/html/details-add-summary-1.html
             fast/html/details-add-summary-10-and-click.html
             fast/html/details-add-summary-10.html
             fast/html/details-add-summary-2-and-click.html
             fast/html/details-add-summary-2.html
             fast/html/details-add-summary-3-and-click.html
             fast/html/details-add-summary-3.html
             fast/html/details-add-summary-4-and-click.html
             fast/html/details-add-summary-4.html
             fast/html/details-add-summary-5-and-click.html
             fast/html/details-add-summary-5.html
             fast/html/details-add-summary-6-and-click.html
             fast/html/details-add-summary-6.html
             fast/html/details-add-summary-7-and-click.html
             fast/html/details-add-summary-7.html
             fast/html/details-add-summary-8-and-click.html
             fast/html/details-add-summary-8.html
             fast/html/details-add-summary-9-and-click.html
             fast/html/details-add-summary-9.html
             fast/html/details-mouse-click.html
             fast/html/details-no-summary1.html
             fast/html/details-no-summary2.html
             fast/html/details-no-summary3.html
             fast/html/details-no-summary4.html
             fast/html/details-open-javascript.html
             fast/html/details-open1.html
             fast/html/details-open2.html
             fast/html/details-open3.html
             fast/html/details-open4.html
             fast/html/details-open5.html
             fast/html/details-open6.html
             fast/html/details-position.html
             fast/html/details-remove-summary-1-and-click.html
             fast/html/details-remove-summary-1.html
             fast/html/details-remove-summary-2-and-click.html
             fast/html/details-remove-summary-2.html
             fast/html/details-remove-summary-3-and-click.html
             fast/html/details-remove-summary-3.html
             fast/html/details-remove-summary-4-and-click.html
             fast/html/details-remove-summary-4.html
             fast/html/details-remove-summary-5-and-click.html
             fast/html/details-remove-summary-5.html
             fast/html/details-remove-summary-6-and-click.html
             fast/html/details-remove-summary-6.html
             fast/html/details-writing-mode.html
      
      http://www.w3.org/TR/html5/interactive-elements.html#the-details-element
      
      The main <summary> element is the first <summary> element of a <details> element.
      All other childs of the <details> element are rendered only if the attribute 'open' is set.
      Click event toggles the 'open' attribute.
      
      * html/HTMLDetailsElement.cpp:
      (WebCore::HTMLDetailsElement::HTMLDetailsElement):
      (WebCore::HTMLDetailsElement::findMainSummary):
      (WebCore::HTMLDetailsElement::childrenChanged):
      (WebCore::HTMLDetailsElement::finishParsingChildren):
      (WebCore::HTMLDetailsElement::parseMappedAttribute):
      (WebCore::HTMLDetailsElement::childShouldCreateRenderer):
      (WebCore::HTMLDetailsElement::defaultEventHandler):
      * html/HTMLDetailsElement.h:
      (WebCore::HTMLDetailsElement::mainSummary):
      
      Method createRenderer added to class HTMLSummaryElement.
      
      * html/HTMLSummaryElement.cpp:
      (WebCore::HTMLSummaryElement::createRenderer):
      * html/HTMLSummaryElement.h:
      
      The first <summary> element is positioned at the top of its <details> parent.
      The area occupied by this main <summary> element is the interactive area of the
      <details> element. If the <details> tag has no <summary> child an OwnedSummaryRenderer
      is created and added to the corresponding RenderDetails object.
      
      * rendering/RenderDetails.cpp:
      (WebCore::RenderDetails::RenderDetails):
      (WebCore::RenderDetails::destroy):
      (WebCore::RenderDetails::summaryBlock):
      (WebCore::RenderDetails::contentBlock):
      (WebCore::RenderDetails::addChild):
      (WebCore::RenderDetails::removeChild):
      (WebCore::RenderDetails::setMarkerStyle):
      (WebCore::RenderDetails::styleDidChange):
      (WebCore::RenderDetails::getRenderPosition):
      (WebCore::RenderDetails::markerDestroyed):
      (WebCore::RenderDetails::summaryDestroyed):
      (WebCore::RenderDetails::moveSummaryToContents):
      (WebCore::RenderDetails::createSummaryStyle):
      (WebCore::RenderDetails::replaceMainSummary):
      (WebCore::RenderDetails::createDefaultSummary):
      (WebCore::RenderDetails::checkMainSummary):
      (WebCore::RenderDetails::layout):
      (WebCore::RenderDetails::isOpen):
      (WebCore::RenderDetails::getParentOfFirstLineBox):
      (WebCore::RenderDetails::firstNonMarkerChild):
      (WebCore::RenderDetails::updateMarkerLocation):
      * rendering/RenderDetails.h:
      (WebCore::RenderDetails::interactiveArea):
      (WebCore::RenderDetails::removeLeftoverAnonymousBlock):
      (WebCore::RenderDetails::createsAnonymousWrapper):
      (WebCore::RenderDetails::requiresForcedStyleRecalcPropagation):
      
      A marker is added to the main <summary> element to indicate the current value of the 'open'
      attribute of the <details> element.
      
      * rendering/RenderDetailsMarker.cpp:
      (WebCore::RenderDetailsMarker::RenderDetailsMarker):
      (WebCore::RenderDetailsMarker::destroy):
      (WebCore::RenderDetailsMarker::lineHeight):
      (WebCore::RenderDetailsMarker::baselinePosition):
      (WebCore::RenderDetailsMarker::computePreferredLogicalWidths):
      (WebCore::RenderDetailsMarker::layout):
      (WebCore::RenderDetailsMarker::getRelativeMarkerRect):
      (WebCore::RenderDetailsMarker::isOpen):
      (WebCore::createPath):
      (WebCore::createDownArrowPath):
      (WebCore::createUpArrowPath):
      (WebCore::createLeftArrowPath):
      (WebCore::createRightArrowPath):
      (WebCore::RenderDetailsMarker::orientation):
      (WebCore::RenderDetailsMarker::getCanonicalPath):
      (WebCore::RenderDetailsMarker::getPath):
      (WebCore::RenderDetailsMarker::paint):
      * rendering/RenderDetailsMarker.h:
      (WebCore::toRenderDetailsMarker):
      
      * rendering/RenderSummary.cpp:
      (WebCore::RenderSummary::RenderSummary):
      (WebCore::RenderSummary::destroy):
      (WebCore::RenderSummary::parentDetails):
      (WebCore::RenderSummary::styleDidChange):
      * rendering/RenderSummary.h:
      
      * rendering/RenderTreeAsText.cpp:
      (WebCore::RenderTreeAsText::writeRenderObject):
      
      LayoutTests:
      
      * fast/html/details-add-summary-1-and-click.html: Added.
      * fast/html/details-add-summary-1.html: Added.
      * fast/html/details-add-summary-10-and-click.html: Added.
      * fast/html/details-add-summary-10.html: Added.
      * fast/html/details-add-summary-2-and-click.html: Added.
      * fast/html/details-add-summary-2.html: Added.
      * fast/html/details-add-summary-3-and-click.html: Added.
      * fast/html/details-add-summary-3.html: Added.
      * fast/html/details-add-summary-4-and-click.html: Added.
      * fast/html/details-add-summary-4.html: Added.
      * fast/html/details-add-summary-5-and-click.html: Added.
      * fast/html/details-add-summary-5.html: Added.
      * fast/html/details-add-summary-6-and-click.html: Added.
      * fast/html/details-add-summary-6.html: Added.
      * fast/html/details-add-summary-7-and-click.html: Added.
      * fast/html/details-add-summary-7.html: Added.
      * fast/html/details-add-summary-8-and-click.html: Added.
      * fast/html/details-add-summary-8.html: Added.
      * fast/html/details-add-summary-9-and-click.html: Added.
      * fast/html/details-add-summary-9.html: Added.
      * fast/html/details-mouse-click-expected.txt: Added.
      * fast/html/details-mouse-click.html: Added.
      * fast/html/details-no-summary1.html: Added.
      * fast/html/details-no-summary2.html: Added.
      * fast/html/details-no-summary3.html: Added.
      * fast/html/details-no-summary4.html: Added.
      * fast/html/details-open-javascript.html: Added.
      * fast/html/details-open1.html: Added.
      * fast/html/details-open2.html: Added.
      * fast/html/details-open3.html: Added.
      * fast/html/details-open4.html: Added.
      * fast/html/details-open5.html: Added.
      * fast/html/details-open6.html: Added.
      * fast/html/details-position.html: Added.
      * fast/html/details-remove-summary-1-and-click.html: Added.
      * fast/html/details-remove-summary-1.html: Added.
      * fast/html/details-remove-summary-2-and-click.html: Added.
      * fast/html/details-remove-summary-2.html: Added.
      * fast/html/details-remove-summary-3-and-click.html: Added.
      * fast/html/details-remove-summary-3.html: Added.
      * fast/html/details-remove-summary-4-and-click.html: Added.
      * fast/html/details-remove-summary-4.html: Added.
      * fast/html/details-remove-summary-5-and-click.html: Added.
      * fast/html/details-remove-summary-5.html: Added.
      * fast/html/details-remove-summary-6-and-click.html: Added.
      * fast/html/details-remove-summary-6.html: Added.
      * fast/html/details-writing-mode.html: Added.
      * platform/qt/fast/html/details-add-summary-1-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-1-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-10-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-10-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-2-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-2-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-3-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-3-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-4-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-4-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-5-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-5-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-6-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-6-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-7-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-7-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-8-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-8-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-9-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-add-summary-9-expected.txt: Added.
      * platform/qt/fast/html/details-no-summary1-expected.txt: Added.
      * platform/qt/fast/html/details-no-summary2-expected.txt: Added.
      * platform/qt/fast/html/details-no-summary3-expected.txt: Added.
      * platform/qt/fast/html/details-no-summary4-expected.txt: Added.
      * platform/qt/fast/html/details-open-javascript-expected.txt: Added.
      * platform/qt/fast/html/details-open1-expected.txt: Added.
      * platform/qt/fast/html/details-open2-expected.txt: Added.
      * platform/qt/fast/html/details-open3-expected.txt: Added.
      * platform/qt/fast/html/details-open4-expected.txt: Added.
      * platform/qt/fast/html/details-open5-expected.txt: Added.
      * platform/qt/fast/html/details-open6-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-1-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-2-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-3-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-4-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-5-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt: Added.
      * platform/qt/fast/html/details-remove-summary-6-expected.txt: Added.
      * platform/qt/fast/html/details-writing-mode-expected.txt: Added.
      * platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb0b8be9
    • podivilov@chromium.org's avatar
      2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com> · 70a50b0a
      podivilov@chromium.org authored
              Unreviewed, rolling out r81026.
              http://trac.webkit.org/changeset/81026
              https://bugs.webkit.org/show_bug.cgi?id=56313
      
              Breaks gtk 64-bit tests (Requested by podivilov on #webkit).
      
              * inspector/debugger/xhr-breakpoints-expected.txt: Removed.
              * inspector/debugger/xhr-breakpoints.html: Removed.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r81026.
              http://trac.webkit.org/changeset/81026
              https://bugs.webkit.org/show_bug.cgi?id=56313
      
              Breaks gtk 64-bit tests (Requested by podivilov on #webkit).
      
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
              (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
              (WebCore::InspectorBrowserDebuggerAgent::clear):
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager.prototype.createXHRBreakpoint):
              (WebInspector.BreakpointManager.prototype._createXHRBreakpoint):
              (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
              (WebInspector.BreakpointManager.prototype._projectChanged):
              (WebInspector.BreakpointManager.prototype._validateBreakpoints):
              (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
              (WebInspector.BreakpointManager.prototype._createXHRBreakpointId):
              (WebInspector.XHRBreakpoint):
              (WebInspector.XHRBreakpoint.prototype._enable):
              (WebInspector.XHRBreakpoint.prototype._disable):
              (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
              (WebInspector.XHRBreakpointView):
              (WebInspector.XHRBreakpointView.prototype.compareTo):
              (WebInspector.XHRBreakpointView.prototype.populateEditElement):
              (WebInspector.XHRBreakpointView.prototype.populateLabelElement):
              (WebInspector.XHRBreakpointView.prototype.populateStatusMessageElement):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked):
              (WebInspector.XHRBreakpointsSidebarPane):
              (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog):
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype._clearInterface):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
              (WebInspector.resetFocusElement):
              (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded):
              (WebInspector.createXHRBreakpointsSidebarPane):
              (WebInspector.set attached):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a50b0a
    • mnaganov@chromium.org's avatar
      2011-03-14 Mikhail Naganov <mnaganov@chromium.org> · b7022855
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
              https://bugs.webkit.org/show_bug.cgi?id=56312
      
              Test: inspector/utilities.html
      
              * inspector/front-end/utilities.js:
      
      2011-03-14  Mikhail Naganov  <mnaganov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Factor out binary search algo from the insertionIndexForObjectInListSortedByFunction function.
              https://bugs.webkit.org/show_bug.cgi?id=56312
      
              * inspector/utilities-expected.txt: Added.
              * inspector/utilities.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7022855
    • podivilov@chromium.org's avatar
      2011-03-12 Pavel Podivilov <podivilov@chromium.org> · e83126f1
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: re-implement xhr breakpoints.
              https://bugs.webkit.org/show_bug.cgi?id=56252
      
              * inspector/debugger/xhr-breakpoints-expected.txt: Added.
              * inspector/debugger/xhr-breakpoints.html: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2011-03-12  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: re-implement xhr breakpoints.
              https://bugs.webkit.org/show_bug.cgi?id=56252
      
              - restore xhr breakpoints one by one instead of using setAllBrowserBreakpoints
              - store xhr breakpoints in a separate setting
              - move presentation-related code from BreakpointManager to XHRBreakpointsSidebarPane
      
              Test: inspector/debugger/xhr-breakpoints.html
      
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
              (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
              (WebCore::InspectorBrowserDebuggerAgent::clear):
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager.prototype.setXHRBreakpoint):
              (WebInspector.BreakpointManager.prototype.removeXHRBreakpoint):
              (WebInspector.BreakpointManager.prototype.breakpointViewForEventData):
              (WebInspector.BreakpointManager.prototype._projectChanged):
              (WebInspector.BreakpointManager.prototype._validateBreakpoints):
              (WebInspector.BreakpointManager.prototype._createEventListenerBreakpointId):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.XHRBreakpointsSidebarPane):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked.finishEditing):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._addButtonClicked):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu.removeBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked.finishEditing):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._labelClicked):
              (WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
              (WebInspector.XHRBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._saveBreakpoints):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._restoreBreakpoints):
              (WebInspector.XHRBreakpointsSidebarPane.prototype._projectChanged):
              * inspector/front-end/CallStackSidebarPane.js:
              (WebInspector.CallStackSidebarPane.prototype.update):
              (WebInspector.CallStackSidebarPane.prototype._xhrBreakpointHit):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype._clearInterface):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.js:
              (WebInspector.resetFocusElement):
              (WebInspector.set attached):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e83126f1
    • podivilov@chromium.org's avatar
      2011-03-14 Pavel Podivilov <podivilov@chromium.org> · 07d0a3b8
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move breakpoints restoring to debugger presentation model.
              https://bugs.webkit.org/show_bug.cgi?id=56123
      
              * http/tests/inspector/debugger-test.js:
              (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
      2011-03-14  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: move breakpoints restoring to debugger presentation model.
              https://bugs.webkit.org/show_bug.cgi?id=56123
      
              DebuggerModel's "breakpoint-added" and "breakpoint-removed" events are gone since
              setBreakpoint/removeBreakpoint are now called from DPM only.
      
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::disable):
              (WebCore::InspectorDebuggerAgent::enableDebuggerAfterShown):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.enableDebugger):
              (WebInspector.DebuggerModel.prototype._debuggerWasEnabled):
              (WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
              (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
              (WebInspector.DebuggerModel.prototype.setBreakpoint):
              (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
              (WebInspector.DebuggerModel.prototype.removeBreakpoint):
              (WebInspector.DebuggerModel.prototype._breakpointResolved):
              (WebInspector.DebuggerModel.prototype.reset):
              (WebInspector.DebuggerDispatcher.prototype.debuggerWasEnabled):
              (WebInspector.DebuggerDispatcher.prototype.debuggerWasDisabled):
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel):
              (WebInspector.DebuggerPresentationModel.prototype._debuggerWasEnabled):
              (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
              (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
              (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
              (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
              (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
              (WebInspector.DebuggerPresentationModel.prototype.reset):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07d0a3b8
    • pfeldman@chromium.org's avatar
      2011-03-14 Pavel Feldman <pfeldman@chromium.org> · 4f90804c
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: don't use innerText, use textContent instead.
              https://bugs.webkit.org/show_bug.cgi?id=56307
      
              * inspector/elements/edit-dom-actions-expected.txt:
              * inspector/elements/edit-dom-actions.html:
              * inspector/extensions/extensions-audits-expected.txt:
      2011-03-14  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: don't use innerText, use textContent instead.
              https://bugs.webkit.org/show_bug.cgi?id=56307
      
              * inspector/front-end/AuditFormatters.js:
              (WebInspector.AuditFormatters.snippet):
              * inspector/front-end/ElementsTreeOutline.js:
              * inspector/front-end/GoToLineDialog.js:
              * inspector/front-end/HelpScreen.js:
              (WebInspector.HelpScreen):
              * inspector/front-end/ShortcutsHelp.js:
              (WebInspector.ShortcutsSection.prototype.renderSection):
              (WebInspector.ShortcutsSection.prototype._renderHeader):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f90804c
    • apavlov@chromium.org's avatar
      2011-03-10 Alexander Pavlov <apavlov@chromium.org> · 4178de0c
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
              https://bugs.webkit.org/show_bug.cgi?id=56111
      
              * inspector/styles/styles-new-API.html:
              * inspector/styles/styles-source-offsets.html:
      2011-03-10  Alexander Pavlov  <apavlov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Optimize backend-frontend data transfer volume for CSS styles
              https://bugs.webkit.org/show_bug.cgi?id=56111
      
              This change reduces the getStylesForNode() payload more than twice for BODY elements.
      
              * inspector/InspectorStyleSheet.cpp:
              (WebCore::InspectorStyle::populateObjectWithStyleProperties):
              * inspector/front-end/CSSStyleModel.js:
              (WebInspector.CSSProperty.parsePayload):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4178de0c
    • jknotten@chromium.org's avatar
      2011-03-14 John Knottenbelt <jknotten@chromium.org> · 04fa8dd6
      jknotten@chromium.org authored
              Reviewed by Steve Block.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              Ensure that all geolocation permission requests are cancelled
              when the page is detached from its frame.
      
              Fix fast/dom/Geolocation/window-close-popup.html to ignore position error
              generated on watch when window is closed.
      
              * fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
              * fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
              * fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
              * fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt-wk2/Skipped:
      2011-03-14  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              On Page destruction, any outstanding Geolocation permission
              requests should be cancelled, because the Geolocation can only
              access the client indirectly via m_frame->page().
      
              Page destruction is signalled by a call to the
              Frame::pageDestroyed() method. This explictly calls
              DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
      
              Geolocation::reset() detaches from the GeolocationController,
              cancels requests, watches and single shots, and sets the
              permission state back to Unknown.
      
              Frame::pageDestroyed() is also called by FrameLoader even though
              the page is not destroyed. We should still cancel permission
              requests, because the GeolocationClient will become inaccessible
              to the Geolocation object after this call.
      
              Frame::transferChildFrameToNewDocument also indirectly calls
              Geolocation::reset when the frame is reparented between
              pages. Ideally we would like the Geolocation's activities to
              continue after reparenting, see bug
              https://bugs.webkit.org/show_bug.cgi?id=55577
      
              Since GeolocationController is owned by Page, and all Geolocation
              objects will now unsubscribe from the GeolocationController on
              pageDetached(), we no longer need to call stopUpdating() from the
              GeolocationController's destructor. Instead we can simply assert
              that there should be no no observers. See related bug
              https://bugs.webkit.org/show_bug.cgi?id=52216 .
      
              Introduced new method 'numberOfPendingPermissionRequests' on
              GeolocationClientMock to count the number of outstanding pending
              permission requests. This provides a reusable implementation for
              client-based implementations of the LayoutTestController's
              numberOfPendingGeolocationPermissionRequests method.
      
              Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::resetGeolocation):
              * page/DOMWindow.h:
              * page/Frame.cpp:
              (WebCore::Frame::pageDestroyed):
              (WebCore::Frame::transferChildFrameToNewDocument):
              * page/Geolocation.cpp:
              (WebCore::Geolocation::~Geolocation):
              (WebCore::Geolocation::page):
              (WebCore::Geolocation::reset):
              (WebCore::Geolocation::disconnectFrame):
              (WebCore::Geolocation::lastPosition):
              (WebCore::Geolocation::requestPermission):
              (WebCore::Geolocation::startUpdating):
              (WebCore::Geolocation::stopUpdating):
              * page/Geolocation.h:
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
              * page/Navigator.cpp:
              (WebCore::Navigator::resetGeolocation):
              * page/Navigator.h:
              * platform/mock/GeolocationClientMock.cpp:
              (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
              * platform/mock/GeolocationClientMock.h:
      2011-03-14  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              Add accessors to the WebGeolocationClientMock to allow the number of
              pending geolocation permission requests to be queried.
      
              * public/WebGeolocationClientMock.h:
              * src/WebGeolocationClientMock.cpp:
              (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):
      2011-03-14  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Steve Block.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              Extend the layout test controller to expose the number of pending
              geolocation requests, so that we can test that the requests have
              been cancelled on page close.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (numberOfPendingGeolocationPermissionRequestsCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/mac/UIDelegate.h:
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04fa8dd6
    • alex@webkit.org's avatar
      2011-03-14 Alejandro G. Castro <alex@igalia.com> · f4b1196d
      alex@webkit.org authored
              Rebaseline GTK+ tests after r80996.
      
              * platform/gtk/fast/text/soft-hyphen-2-expected.txt:
              * platform/gtk/fast/text/soft-hyphen-4-expected.checksum: Added.
              * platform/gtk/fast/text/soft-hyphen-4-expected.png: Added.
              * platform/gtk/fast/text/soft-hyphen-4-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4b1196d
    • jknotten@chromium.org's avatar
      2011-03-14 John Knottenbelt <jknotten@chromium.org> · 8fee225b
      jknotten@chromium.org authored
              Reviewed by Steve Block.
      
              Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
              https://bugs.webkit.org/show_bug.cgi?id=56202
      
              By testing for geolocation watch errors, the test tests more than
              it should, which can cause a flaky result as demonstrated by
              https://bugs.webkit.org/show_bug.cgi?id=56126 .
      
              * fast/dom/Geolocation/resources/window-close-popup.html:
              * fast/dom/Geolocation/script-tests/window-close-crash.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fee225b
    • alex@webkit.org's avatar
      2011-03-14 Alejandro G. Castro <alex@igalia.com> · 07c033c2
      alex@webkit.org authored
              Update more expectations after r80857.
      
              * platform/gtk/fast/layers/video-layer-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07c033c2
    • levin@chromium.org's avatar
      Move the crash result and the bug to the debug line for the test (instead of release) · b08524bb
      levin@chromium.org authored
      since that is where the crash occurs.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b08524bb