1. 01 Feb, 2007 9 commits
    • andersca's avatar
      LayoutTests: · ae911848
      andersca authored
              Reviewed by Darin.
      
              Update test results that have console messages.
              
              * dom/html/level2/html/HTMLFrameElement09-expected.txt:
              * dom/html/level2/html/HTMLIFrameElement11-expected.txt:
              * dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
              * dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
              * dom/xhtml/level2/html/frame-expected.txt:
              * dom/xhtml/level2/html/iframe-expected.txt:
              * editing/execCommand/4920488-expected.txt:
              * editing/selection/contenteditable-click-inside-expected.txt:
              * editing/selection/contenteditable-click-outside-expected.txt:
              * fast/AppleScript/001-expected.txt:
              * fast/dynamic/015-expected.txt:
              * fast/events/iframe-object-onload-expected.txt:
              * fast/events/updateLayoutForHitTest-expected.txt:
              * fast/forms/display-none-in-onchange-keyboard-expected.txt:
              * fast/forms/input-text-click-inside-expected.txt:
              * fast/forms/input-text-click-outside-expected.txt:
              * fast/forms/selected-index-assert-expected.txt:
              * fast/js/array-foreach-expected.txt:
              * fast/js/array-some-expected.txt:
              * fast/js/kde/exception_propagation-expected.txt:
              * fast/js/kde/garbage-n-expected.txt:
              * fast/js/kde/string-1-n-expected.txt:
              * fast/js/kde/string-2-n-expected.txt:
              * fast/parser/script-tag-with-trailing-slash-expected.txt:
              * fast/table/click-near-anonymous-table-expected.txt:
              * fast/tokenizer/002-expected.txt:
              * fast/tokenizer/external-script-document-write_2-expected.txt:
              * fast/tokenizer/script_extra_close-expected.txt:
              * fast/xsl/transform-xhr-doc-expected.txt:
              * http/tests/navigation/error404-goback-expected.txt:
              * http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
              * svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
              * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
              * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
              * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
              * svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
              * svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
              * svg/custom/dynamic-empty-path-expected.txt:
              * svg/custom/js-update-container-expected.txt:
              * svg/custom/js-update-gradient-expected.txt:
              * svg/custom/js-update-polygon-changes-expected.txt:
              * svg/custom/js-update-polygon-removal-expected.txt:
              * svg/custom/path-bad-data-expected.txt:
              * svg/custom/polyline-hittest-expected.txt:
              * svg/custom/polyline-invalid-points-expected.txt:
              * svg/custom/polyline-setattribute-points-null-expected.txt:
              * svg/custom/svgpolyparser-extra-space-expected.txt:
              * svg/custom/use-modify-target-symbol-expected.txt:
              * svg/custom/viewbox-syntax-expected.txt:
              * tables/mozilla/bugs/bug53690-1-expected.txt:
              * tables/mozilla/bugs/bug9024-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
              * tables/mozilla_expected_failures/core/captions1-expected.txt:
              * tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
              * tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
              * tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
              * tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
      
      WebKitTools:
      
              Reviewed by Darin.
      
              * DumpRenderTree/UIDelegate.m:
              (-[UIDelegate webView:addMessageToConsole:]):
              Dump console messages.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae911848
    • bdakin's avatar
      WebCore: · 84823642
      bdakin authored
              Reviewed by Hyatt.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION 
              (r12065-r12082): Navigation graphic wraps to the next line on 
              duart.com and <rdar://problem/4960505> REGRESSION: The Awesome 
              Windows Vista page has a layout error in the header table (10517)
      
              The problem is that we never supported a quirk that other browsers 
              support where, under very specific circumstances, a table cell will 
              grow to fit an image inside of it. This is only a regression 
              because a bug was fixed were we were 1 pixel off in the calculation 
              of overflow in some cases.
      
              * rendering/RenderBlock.cpp:
              (WebCore::shouldGrowTableCellForImage):
              (WebCore::RenderBlock::calcInlineMinMaxWidth):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84823642
    • lars's avatar
      Reviewed by Adam. · 8e55fe8f
      lars authored
              Fix form loading for the Qt build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e55fe8f
    • darin's avatar
      * fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test... · dd4dfe84
      darin authored
              * fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result to reflect failure
              because bug 12506 isn't fixed yet; we'll change it back once the bug is re-fixed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4dfe84
    • zack's avatar
      Implement native look for comboboxes · 92379b69
      zack authored
      and fix/implement popup menus. Also add the m_timestamp
      and m_eventType setting to PlatformMouseEvent
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92379b69
    • mjs's avatar
      Reviewed by Adam. · 62f6733d
      mjs authored
              
              <rdar://problem/4730469> REGRESSION: Assertion failure in -[WebDataSource(WebInternal) _bridge] when forwarding message
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource subresources]): Check for being uncommitted and return emtpy result.
              (-[WebDataSource subresourceForURL:]): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62f6733d
    • darin's avatar
      LayoutTests: · c736acc1
      darin authored
              Reviewed by Maciej.
      
              - test for <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
      
              * fast/forms/search-event-delay-expected.txt: Added.
              * fast/forms/search-event-delay.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
      
              * rendering/RenderTextControl.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::RenderTextControl): Set up timer.
              (WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event.
              (WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event.
              (WebCore::RenderTextControl::stopSearchEventTimer): Added.
              (WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is
              no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep
              typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.
      
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to
              stop the timer, since we're sending a search event. This helps when a caller other than
              the timer decides to send an explicit search event.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c736acc1
    • mjs's avatar
      Fix by Darin, reviewed by Maciej. · 1051900a
      mjs authored
              - fix ~10% performance regression from encoding fix
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic
              error which made huge strings accidentally.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1051900a
    • lars's avatar
      fix the Qt build · 7ad877a5
      lars authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ad877a5
  2. 31 Jan, 2007 31 commits
    • darin's avatar
      LayoutTests: · 65a4bc4f
      darin authored
              Reviewed by Adam and Geoff.
      
              - test for <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text
      
              * fast/forms/select-width-font-change-expected.txt: Added.
              * fast/forms/select-width-font-change.html: Added.
      
      WebCore:
      
              Reviewed by Adam and Geoff.
      
              - fix <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text
      
              Test: fast/forms/select-width-font-change.html
      
              * rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h.
              Made a lot more things private, including the PopupMenuClient base class, all of the virtual
              functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes.
              (WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement.
              Changed to do nothing when m_optionsWidth is already correct.
              (WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new
              updateOptionsWidth function.
              (WebCore::RenderMenuList::text): Made const.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65a4bc4f
    • oliver's avatar
      · a485c2f2
      oliver authored
      liver Hunt  <oliver@apple.com>
      
              Reviewed by Adam.
      WebCore:
              Migrate more drag and drop logic to WebCore, start preparing
              to move EventHandler::handleDrag from EventHandlerMac to EventHandler 
      
              * WebCore.exp:   
                updating methods
                          
              * dom/Clipboard.cpp:
              * dom/Clipboard.h:
              (WebCore::Clipboard::Clipboard):
              (WebCore::Clipboard::setDragHasStarted):
              (WebCore::Clipboard::dragStarted): 
                Moving from ClipboardMac to Clipboard 
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchMouseEvent):
                PlatformMouseEvent no longer lies about button state, however 
                DOM Events don't allow NoButton, so we need to convert NoButton 
                to LeftButton when we create a DOM Event from PlatformMouseEvent
      
              * page/DragClient.h:
                Tidying comment 
      
              * page/DragController.cpp:
              (WebCore::createMouseEvent):
                Updated for new PlatformMouseEvent constructors
              (WebCore::DragController::mayStartDragAtEventLocation):
                Migrated from WebKit
      
              * page/DragController.h:
                Added above function declarations
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dragState): 
              (WebCore::EventHandler::dragHysteresisExceeded):
              (WebCore::EventHandler::freeClipboard):
              (WebCore::EventHandler::shouldDragAutoNode):
                Moved from EventHandlerMac
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::eventMayStartDrag):
              (WebCore::EventHandler::handleMousePressEvent):
                Use DragController     
      
              * page/EventHandler.h:
                Added DragState struct definition to EventHandler
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::eventActivatedView):
              (WebCore::EventHandler::handleDrag):
              (WebCore::EventHandler::handleMouseUp):
              (WebCore::EventHandler::mouseDown):
                Update to use DragController and PlatformMouseEvent
      
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge dragSourceMovedTo:]):
              (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
                Use DragController for state               
      
      WebKit:
              Migrating methods to WebCore
      
              * WebCoreSupport/WebFrameBridge.mm:
              * WebView/WebHTMLView.mm:
              * WebView/WebHTMLViewPrivate.h:
                                               
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a485c2f2
    • weinig's avatar
      LayoutTests: · a820830e
      weinig authored
              Reviewed by Darin.
      
              http://bugs.webkit.org/show_bug.cgi?id=12506
              REGRESSION: Safari doesn't display hebrew text on a web page,
              displayed correctly on Tiger
      
              * fast/encoding/pseudo-tags-in-attributes-expected.txt: Added.
              * fast/encoding/pseudo-tags-in-attributes.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              http://bugs.webkit.org/show_bug.cgi?id=12506
              REGRESSION: Safari doesn't display hebrew text on a web page,
              displayed correctly on Tiger
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::checkForHeadCharset): Skip over 
              quoted attributes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a820830e
    • weinig's avatar
      Reviewed by Darin. · 75890e6c
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=12510
              Initialize the variable m_totalLoops
              Is tested by LayoutTests/fast/css/MarqueeLayoutTest.html
      
              * rendering/RenderLayer.cpp:
              (WebCore::Marquee::Marquee):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75890e6c
    • andersca's avatar
      LayoutTests: · 02b031d7
      andersca authored
              Reviewed by Maciej.
      
              <rdar://problem/4886776>
              REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
      
              * webarchive/loading/resources/helloworld.webarchive: Added.
              * webarchive/loading/test-loading-archive-expected.txt: Added.
              * webarchive/loading/test-loading-archive.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              <rdar://problem/4886776>
              REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
      
              * WebCore.exp:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::continueLoadWithData):
              * loader/FrameLoader.h:
              New function which continues a load but using a given buffer instead.
      
      WebKit:
      
              Reviewed by Maciej.
      
              <rdar://problem/4886776>
              REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file
              
              "Revert" the change done in 13734.
              
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation loadArchive]):
              Don't do a new load here, as this would cancel the current load and call the resource load
              delegate's didFailLoadingWithError: method. Instead, call continueLoadWithData.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02b031d7
    • andersca's avatar
      * DumpRenderTree/ResourceLoadDelegate.m: · 9c27450e
      andersca authored
              (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
              Use an NSString here so we can guarantee that -description always returns the same value.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c27450e
    • mjs's avatar
      Reviewed by Adam. · 49f2bf40
      mjs authored
              
              - fix sporadic crash
      
              * wtf/ListHashSet.h:
              (WTF::::remove): remove before deleting
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49f2bf40
    • adele's avatar
      Reviewed by Adam. · c96dafe2
      adele authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=12516
              REGRESSION (r19313): All keyboard navigation has stopped working
      
              For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent. 
      
              * editing/Editor.cpp:
              (WebCore::selectionForEvent): Moved this to the top of the file.
              (WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c96dafe2
    • mjs's avatar
      Reviewed by Maciej. · f794cd5d
      mjs authored
              Fix run-pageloadtest to actually work again.
      
              * Misc/WebNSWindowExtras.m:
              (+[NSWindow _webkit_displayThrottledWindows]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f794cd5d
    • ggaren's avatar
      WebCore: · 884d9e49
      ggaren authored
              Reviewed by Darin Adler.
      
              Added a Range counter to detect leaks. Tweaked the Node counter.
              
              Also fixed a TextIterator destructive modification bug that I noticed along the
              way. No test case for this bug because no clients have been bitten by it
              yet.
      
              * dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter
              to unsigned, fixed formatting to match style guidelines.
              (WebCore::NodeCounter::~NodeCounter):
              (WebCore::Node::Node):
              (WebCore::Node::~Node):
      
              * dom/Range.cpp:
              (WebCore::RangeCounter::~RangeCounter): Added.
              (WebCore::Range::Range):
              (WebCore::Range::~Range):
              (WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid
              annoying NULL checks.
              * dom/Range.h:
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::subrange): 
              (1) Don't initialize result with entireRange --  doing so would create a 
              PassRefPtr that pointed to entireRange, so this function would destructively 
              modify the Range you passed it. Initialize it with a new Range instead.
              (2) Don't use a PassRefPtr as a local variable, because they have sneaky
              semantics. Use a RefPtr instead.
              (3) Don't call CharacterIterator::range() willy-nilly, since it does 
              non-trivial work. Use a local variable instead.
      
      WebKitTools:
      
              Reviewed by Darin Adler.
      
              Added Selection::toRange to the leaks -exclude list, since it comes up
              as a false positive (Radar 4967949).
              
              Also added RangeCounter to the global initializer exclude list. I added
              a RangeCounter since leaks won't detect all Range leaks anymore.
      
              * Scripts/check-for-global-initializers:
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      884d9e49
    • andersca's avatar
      * DumpRenderTree/ResourceLoadDelegate.m: · a45aa0aa
      andersca authored
              (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
              Don't try to create an identifier if resource loads shouldn't be dumped.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a45aa0aa
    • andersca's avatar
      Reviewed by Geoff. · 954927bd
      andersca authored
              Add dumping of resource loads. This isn't completely tweaked yet since the test results would
              rely on resources being delivered in the same order which might not always be true. However, it works good
              enough for the simple webarchive tests I want to do right now.
              
              * DumpRenderTree/DumpRenderTree.h:
              * DumpRenderTree/DumpRenderTree.m:
              (dumpRenderTree):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController dumpResourceLoadCallbacks]):
              (runTest):
              
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/ResourceLoadDelegate.h: Added.
              * DumpRenderTree/ResourceLoadDelegate.m: Added.
              Add new resource load delegate.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      954927bd
    • zimmermann's avatar
      Reviewed by Maciej. · e74ab81e
      zimmermann authored
      Fix run-pageloadtest to actually work again.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e74ab81e
    • adele's avatar
      LayoutTests: · 6ef54cf7
      adele authored
              Reviewed by Darin.
      
              Test for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
      
              * fast/events/keypress-focus-change-expected.txt: Added.
              * fast/events/keypress-focus-change.html: Added.
              * fast/events/resources/keypress-frame.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              WebCore part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
      
              Test: fast/events/keypress-focus-change.html
      
              * editing/Editor.cpp:
              (WebCore::selectionForEvent): Added.  This computes a selection that considers the case where an event handler 
               has moved the selection outside of a text control.  In that case, we use the target control's selection.
              (WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable,
               and calls TypingCommand::insertText with the correct selection.
      
              * editing/TypingCommand.h: Added a version of insertText that takes a selection.  The old version of insertText will call this, and pass
                in the frame's selection.
              * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to 
                set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.
      
              * page/Page.h: Added convenience method to get selection from focused or main frame.
              * page/Page.cpp: (WebCore::Page::selection):
      
              * html/HTMLInputElement.h: Added selection methods to get selection for text controls.
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
              * html/HTMLTextAreaElement.h:
              * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
              * rendering/RenderTextControl.h:
              * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):
      
      WebKit:
      
              Reviewed by Darin.
      
              WebKit part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control
      
              * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Instead of using the selected frame, use the
                frame for the target of the keyboard event.  Also, don't do the canEdit check here, since the target's frame might not
                have a selection at this point.  Do the canEdit check within Editor::insertText, where we determine which selection to use
                for inserting text.
              * WebView/WebEditingDelegatePrivate.h: Added forward declaration of DOMHTMLElement. This is needed after reordering includes in WebEditorClient.mm.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef54cf7
    • ggaren's avatar
      Backing out the CFRunLoopRunSpecific exclude command because it was overly · bc8f2f65
      ggaren authored
              broad. We'll either need to work around this leak in DRT, or do some
              custom grep-based leak ignoring.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc8f2f65
    • aliceli1's avatar
      Reviewed by Tim Hatcher. · 95f8353a
      aliceli1 authored
              Turning an accidental API change to an SPI change
      
              * WebView/WebEditingDelegate.h:
              * WebView/WebEditingDelegatePrivate.h:
              move some declarations into private header.  
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95f8353a
    • darin's avatar
      WebCore: · 0a6bf133
      darin authored
              - fix build
      
              * ForwardingHeaders/wtf/ListHashSet.h: Added.
      
      WebKit:
      
              - fix build
      
              * ForwardingHeaders/wtf/ListHashSet.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a6bf133
    • zack's avatar
      Implement native colors for selections. · 6689e575
      zack authored
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6689e575
    • zack's avatar
      Expose the fact that the form has been edited · c4ff7bc0
      zack authored
      in the public Qt api.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4ff7bc0
    • mjs's avatar
      JavaScriptCore: · 9033c82a
      mjs authored
              Reviewed by Mark with help from Lars.
              
              - added new ListHashSet class, which combines a hashtable and a linked list to provide a set
              that keeps elements in inserted order
              
              This is to assist in fixing the following:
              <rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
              http://bugs.webkit.org/show_bug.cgi?id=10541
      
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * wtf/HashTable.h:
              (WTF::HashTable::find):
              (WTF::HashTable::contains):
              (WTF::::find):
              (WTF::::contains):
              * wtf/ListHashSet.h: Added.
              (WTF::ListHashSetNode::ListHashSetNode):
              (WTF::ListHashSetNodeHashFunctions::hash):
              (WTF::ListHashSetNodeHashFunctions::equal):
              (WTF::ListHashSetIterator::ListHashSetIterator):
              (WTF::ListHashSetIterator::get):
              (WTF::ListHashSetIterator::operator*):
              (WTF::ListHashSetIterator::operator->):
              (WTF::ListHashSetIterator::operator++):
              (WTF::ListHashSetIterator::operator--):
              (WTF::ListHashSetIterator::operator==):
              (WTF::ListHashSetIterator::operator!=):
              (WTF::ListHashSetIterator::operator const_iterator):
              (WTF::ListHashSetIterator::node):
              (WTF::ListHashSetConstIterator::ListHashSetConstIterator):
              (WTF::ListHashSetConstIterator::get):
              (WTF::ListHashSetConstIterator::operator*):
              (WTF::ListHashSetConstIterator::operator->):
              (WTF::ListHashSetConstIterator::operator++):
              (WTF::ListHashSetConstIterator::operator--):
              (WTF::ListHashSetConstIterator::operator==):
              (WTF::ListHashSetConstIterator::operator!=):
              (WTF::ListHashSetConstIterator::node):
              (WTF::ListHashSetTranslator::hash):
              (WTF::ListHashSetTranslator::equal):
              (WTF::ListHashSetTranslator::translate):
              (WTF::::ListHashSet):
              (WTF::::operator):
              (WTF::::~ListHashSet):
              (WTF::::size):
              (WTF::::capacity):
              (WTF::::isEmpty):
              (WTF::::begin):
              (WTF::::end):
              (WTF::::find):
              (WTF::::contains):
              (WTF::::add):
              (WTF::::remove):
              (WTF::::clear):
              (WTF::::unlinkAndDelete):
              (WTF::::appendNode):
              (WTF::::deleteAllNodes):
              (WTF::::makeIterator):
              (WTF::::makeConstIterator):
              (WTF::deleteAllValues):
      
      WebCore:
      
              Reviewed by Mark.
      
              - fixed <rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
              http://bugs.webkit.org/show_bug.cgi?id=10541
      
              * dom/Document.cpp:
              (WebCore::Document::formElementsState):
              * dom/Document.h:
              
              I couldn't figure out the back/forward support in the tests enough
              to make an automated test, but this maual test reproduces the
              problem 100% without this patch:
              
              * manual-tests/back.html: Added.
              * manual-tests/form-control-madness.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9033c82a
    • ddkilzer's avatar
      Added Bugzilla bug number. Thanks Mitz! · 05fccbeb
      ddkilzer authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05fccbeb
    • ddkilzer's avatar
      WebCore: · e7605025
      ddkilzer authored
              Reviewed by Mitz.
      
              No test cases since there is no change in functionality.
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7605025
    • zack's avatar
      Adding comments explaining how the focus ring implementation · e3bc53b4
      zack authored
      works on the Qt platform and just move focus ring rendering
      related code to the same spot.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3bc53b4
    • mjs's avatar
      Reviewed by Eric. · 46d1dc4b
      mjs authored
              
              - add back no-op version of silly method so that shipping Safari can still run the PLT
      
              * Misc/WebNSWindowExtras.m:
              (-[NSWindow _webkit_displayThrottledWindows]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46d1dc4b
    • zack's avatar
      Clean up key event handling on Qt. · a43eb012
      zack authored
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a43eb012
    • staikos's avatar
      Fix a double delete on cancel as well as a crash with proxy · ae2eaca7
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae2eaca7
    • bdash's avatar
      2007-01-31 Mark Rowe <mrowe@apple.com> · 6be0ad08
      bdash authored
              More build fixing.
      
              * Misc/WebKitLogging.h: Use !defined() rather than !.
              * Plugins/WebNetscapePluginStream.h: Remove #if __cplusplus as this file is only included from Obj-C++ files.
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Use #ifdef rather than #if.
              * WebView/WebView.mm:
              (-[WebView isGrammarCheckingEnabled]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6be0ad08
    • bdash's avatar
      2007-01-31 Mark Rowe <mrowe@apple.com> · a9cb76fc
      bdash authored
              Build fix.
      
              * WebView/WebView.mm:
              (-[WebView initWithFrame:frameName:groupName:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9cb76fc
    • staikos's avatar
      fix a crash on exit · 324337fd
      staikos authored
      remove focusFrame
      add childFrames
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      324337fd
    • bdash's avatar
      2007-01-31 Mark Rowe <mrowe@apple.com> · b2988705
      bdash authored
              Reviewed by Oliver.
      
              Enable -Wundef in WebKit, and change misuses of #if to #ifdef or #ifndef as appropriate.
      
              * Misc/WebKitLogging.h:
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebFrame.mm:
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView validateUserInterfaceItem:]):
              (-[WebHTMLView delete:]):
              (-[WebHTMLView showGuessPanel:]):
              (-[WebHTMLView copy:]):
              (-[WebHTMLView cut:]):
              (-[WebHTMLView paste:]):
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebView.mm:
              (-[WebViewPrivate init]):
              (-[WebView validateUserInterfaceItem:]):
              * WebView/WebViewPrivate.h:
      
      2007-01-31  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Oliver.
      
              * dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2988705
    • lars's avatar
      Fix the Qt build. · 16453637
      lars authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16453637