1. 23 Jan, 2012 40 commits
    • dcheng@chromium.org's avatar
      Convert DataTransferItem/DataTransferItemList back into an interface class · ae86f2ab
      dcheng@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76856
      
      When Qt implemented the DataTransferItemList, a lot of logic was moved into the shared
      classes since Chromium/Qt happened to implement it the same way. Now that I want to do some
      refactoring/cleanup work to better implement DataTransferItemList in Chromium, we won't
      share the same data anymore so it doesn't make sense to keep that code in a common location.
      
      Reviewed by David Levin.
      
      Covered by existing tests.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/DataTransferItem.cpp:
      * dom/DataTransferItem.h:
      * dom/DataTransferItemList.cpp: Removed.
      * dom/DataTransferItemList.h:
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::mayUpdateItems):
      * platform/chromium/DataTransferItemChromium.cpp:
      (WebCore::DataTransferItemChromium::create):
      (WebCore::DataTransferItemChromium::DataTransferItemChromium):
      (WebCore::DataTransferItemChromium::getAsString):
      (WebCore::DataTransferItemChromium::getAsFile):
      (WebCore::DataTransferItemChromium::clipboardChromium):
      * platform/chromium/DataTransferItemChromium.h:
      (WebCore::DataTransferItemChromium::kind):
      (WebCore::DataTransferItemChromium::type):
      * platform/chromium/DataTransferItemListChromium.cpp:
      (WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
      * platform/chromium/DataTransferItemListChromium.h:
      * platform/qt/DataTransferItemListQt.cpp:
      (WebCore::DataTransferItemListQt::DataTransferItemListQt):
      (WebCore::DataTransferItemListQt::length):
      (WebCore::DataTransferItemListQt::item):
      (WebCore::DataTransferItemListQt::deleteItem):
      (WebCore::DataTransferItemListQt::clear):
      (WebCore::DataTransferItemListQt::add):
      * platform/qt/DataTransferItemListQt.h:
      * platform/qt/DataTransferItemQt.cpp:
      (WebCore::DataTransferItemQt::create):
      (WebCore::DataTransferItemQt::DataTransferItemQt):
      (WebCore::DataTransferItemQt::getAsString):
      (WebCore::DataTransferItemQt::getAsFile):
      * platform/qt/DataTransferItemQt.h:
      (WebCore::DataTransferItemQt::kind):
      (WebCore::DataTransferItemQt::type):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae86f2ab
    • mikelawther@chromium.org's avatar
      getComputedStyle margin percentage test for CSS calc · 26421928
      mikelawther@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76130
      
      Reviewed by Darin Adler.
      
      Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
      
      These tests are expected to 'fail', and will pass once calc() functionality is landed.
      For now, they serve to demonstrate that the current code doesn't crash on these tests.
      
      * css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
      * css3/calc/getComputedStyle-margin-percentage.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26421928
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=76855 · 09041a4e
      barraclough@apple.com authored
      Implement a JIT-code aware sampling profiler for JSC
      
      Reviewed by Geoff Garen.
      
      Step 2: generalize RedBlackTree. The profiler is going to want tio use
      a RedBlackTree, allow this class to work with subclasses of
      RedBlackTree::Node, Node should not need to know the names of the m_key
      and m_value fields (the subclass can provide a key() accessor), and
      RedBlackTree does not need to know anything about ValueType.
      
      * JavaScriptCore.exp:
      * wtf/MetaAllocator.cpp:
      (WTF::MetaAllocator::findAndRemoveFreeSpace):
      (WTF::MetaAllocator::debugFreeSpaceSize):
      (WTF::MetaAllocator::addFreeSpace):
      * wtf/MetaAllocator.h:
      (WTF::MetaAllocator::FreeSpaceNode::FreeSpaceNode):
      (WTF::MetaAllocator::FreeSpaceNode::key):
      * wtf/MetaAllocatorHandle.h:
      (WTF::MetaAllocatorHandle::key):
      * wtf/RedBlackTree.h:
      (WTF::RedBlackTree::Node::successor):
      (WTF::RedBlackTree::Node::predecessor):
      (WTF::RedBlackTree::Node::parent):
      (WTF::RedBlackTree::Node::setParent):
      (WTF::RedBlackTree::Node::left):
      (WTF::RedBlackTree::Node::setLeft):
      (WTF::RedBlackTree::Node::right):
      (WTF::RedBlackTree::Node::setRight):
      (WTF::RedBlackTree::insert):
      (WTF::RedBlackTree::remove):
      (WTF::RedBlackTree::findExact):
      (WTF::RedBlackTree::findLeastGreaterThanOrEqual):
      (WTF::RedBlackTree::findGreatestLessThanOrEqual):
      (WTF::RedBlackTree::first):
      (WTF::RedBlackTree::last):
      (WTF::RedBlackTree::size):
      (WTF::RedBlackTree::treeMinimum):
      (WTF::RedBlackTree::treeMaximum):
      (WTF::RedBlackTree::treeInsert):
      (WTF::RedBlackTree::leftRotate):
      (WTF::RedBlackTree::rightRotate):
      (WTF::RedBlackTree::removeFixup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09041a4e
    • kling@webkit.org's avatar
      Unreviewed buildfix for ENABLE(MUTATION_OBSERVERS) following r105642. · 79f1c352
      kling@webkit.org authored
      * css/CSSMutableStyleDeclaration.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79f1c352
    • rniwa@webkit.org's avatar
      run-perf-tests ignore Skipped list on chromium · 81d631ba
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76764
      
      Reviewed by Dirk Pranke.
      
      Move skipped_perf_tests from WebKit port to Base port so that Chromium port
      can also find skipped list. Chromium port only uses test_expectations.txt for
      layout tests but performacne tests don't use test_expectations.txt so Chromium port
      also needs to use Skipped list.
      
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port._tests_from_skipped_file_contents):
      (Port):
      (Port._expectations_from_skipped_files):
      (Port.skipped_perf_tests):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_skipped_perf_tests):
      (PortTest.test_skipped_perf_tests.add_text_file):
      * Scripts/webkitpy/layout_tests/port/webkit.py:
      (WebKitPort._skipped_tests_for_unsupported_features):
      (WebKitPort._skipped_file_search_paths):
      (WebKitPort.skipped_layout_tests):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81d631ba
    • commit-queue@webkit.org's avatar
      Update uniteIfNonZero to use isZero. · 3d93ef60
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76637
      
      Patch by Philip Rogers <pdr@google.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      No new tests. (I found no existing codepath that would be affected by
      this change but I think this change is still valuable in preventing
      future bugs.)
      
      * platform/graphics/FloatRect.cpp:
      (WebCore::FloatRect::uniteIfNonZero):
      
      The following change is a minor followup to
      https://bugs.webkit.org/show_bug.cgi?id=76177#c12 and is not directly
      related to the rest of this patch.
      * rendering/svg/SVGRenderSupport.cpp:
      (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d93ef60
    • antti@apple.com's avatar
      Eliminate CSSElementStyleDeclaration · 241a650f
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76848
      
      Reviewed by Andreas Kling.
      
      CSSElementStyleDeclaration has little functionality. It can merge with CSSMutableStyleDeclaration simplifying the code.
              
      Having an element parent is mutually exclusive with having a css rule parent. We can keep them in a union. This also
      shrinks all inline style declarations by one pointer.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMBinding.h:
      (WebCore::root):
      * css/CSSAllInOne.cpp:
      * css/CSSElementStyleDeclaration.cpp: Removed.
      * css/CSSElementStyleDeclaration.h: Removed.
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
      * css/CSSMutableStyleDeclaration.h:
      (WebCore::CSSMutableStyleDeclaration::createInline):
      (WebCore::CSSMutableStyleDeclaration::createForSVGFontFaceElement):
      (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
      * css/CSSStyleDeclaration.cpp:
      (WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
      (WebCore::CSSStyleDeclaration::parentStyleSheet):
              
          Merge the CSSElementStyleDeclaration::styleSheet() logic here.
              
      * css/CSSStyleDeclaration.h:
      (WebCore::CSSStyleDeclaration::parentRule):
      (WebCore::CSSStyleDeclaration::clearParentRule):
      (WebCore::CSSStyleDeclaration::parentElement):
      (WebCore::CSSStyleDeclaration::clearParentElement):
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::setSelectorText):
              
          CSSStyleRule's style declaration can't have isElementStyleDeclaration set, the dead code can be removed.
          This is asserted in setDeclaration() and again implicitly in the destructor (by clearParentRule()).
              
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::createInlineStyleDecl):
      (WebCore::StyledElement::destroyInlineStyleDecl):
      (WebCore::StyledElement::ensureInlineStyleDecl):
      (WebCore::StyledElement::copyNonAttributeProperties):
      * dom/StyledElement.h:
      (WebCore::StyledElement::inlineStyleDecl):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
      (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::createDeletionUI):
      * html/ValidationMessage.cpp:
      (WebCore::adjustBubblePosition):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlPanelElement::makeOpaque):
      (WebCore::MediaControlPanelElement::makeTransparent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::TrackLimiterElement::create):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      241a650f
    • senorblanco@chromium.org's avatar
      2436e67e
    • senorblanco@chromium.org's avatar
      rolling chromium DEPS to r118713 · cf312841
      senorblanco@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76849
      
      Patch by Justin Novosad <junov@chromium.org> on 2012-01-23
      Reviewed by Stephen White.
      
      This is to pick up a change to skia build configuration
      
      * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf312841
    • aestes@apple.com's avatar
      Fix the build after r105635. · 48b735f2
      aestes@apple.com authored
      Source/JavaScriptCore:
      
      * JavaScriptCore.exp:
      
      Tools:
      
      * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
      (TestWebKitAPI::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48b735f2
    • mhahnenberg@apple.com's avatar
      Remove StackBounds from JSGlobalData · 2ef8a3fe
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76310
      
      Reviewed by Sam Weinig.
      
      Removed StackBounds and the stack() function from JSGlobalData since it no 
      longer accessed any members of JSGlobalData.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::BytecodeGenerator):
      * heap/MachineStackMarker.cpp:
      (JSC::MachineThreads::addCurrentThread):
      (JSC::MachineThreads::gatherFromCurrentThread):
      * parser/Parser.cpp:
      (JSC::::Parser):
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ef8a3fe
    • benjamin@webkit.org's avatar
      Use OVERRIDE for PopupMenuClient's implementations · bd81e4f9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76774
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-23
      Reviewed by Darin Adler.
      
      * rendering/RenderMenuList.h: Also sort the methods to the same
      order as PopupMenuClient.
      * rendering/RenderTextControlSingleLine.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd81e4f9
    • barraclough@apple.com's avatar
      Implement a JIT-code aware sampling profiler for JSC · b6a00d35
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76855
      
      Rubber stanmped by Geoff Garen.
      
      Mechanical change - pass CodeBlock through to the executable allocator,
      such that we will be able to map ranges of JIT code back to their owner.
      
      * assembler/ARMAssembler.cpp:
      (JSC::ARMAssembler::executableCopy):
      * assembler/ARMAssembler.h:
      * assembler/AssemblerBuffer.h:
      (JSC::AssemblerBuffer::executableCopy):
      * assembler/AssemblerBufferWithConstantPool.h:
      (JSC::AssemblerBufferWithConstantPool::executableCopy):
      * assembler/LinkBuffer.h:
      (JSC::LinkBuffer::LinkBuffer):
      (JSC::LinkBuffer::linkCode):
      * assembler/MIPSAssembler.h:
      (JSC::MIPSAssembler::executableCopy):
      * assembler/SH4Assembler.h:
      (JSC::SH4Assembler::executableCopy):
      * assembler/X86Assembler.h:
      (JSC::X86Assembler::executableCopy):
      (JSC::X86Assembler::X86InstructionFormatter::executableCopy):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::compile):
      (JSC::DFG::JITCompiler::compileFunction):
      * dfg/DFGOSRExitCompiler.cpp:
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::generateProtoChainAccessStub):
      (JSC::DFG::tryCacheGetByID):
      (JSC::DFG::tryBuildGetByIDList):
      (JSC::DFG::tryCachePutByID):
      * dfg/DFGThunks.cpp:
      (JSC::DFG::osrExitGenerationThunkGenerator):
      * jit/ExecutableAllocator.cpp:
      (JSC::ExecutableAllocator::allocate):
      * jit/ExecutableAllocator.h:
      * jit/ExecutableAllocatorFixedVMPool.cpp:
      (JSC::ExecutableAllocator::allocate):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompile):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::privateCompileCTIMachineTrampolines):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::privateCompileCTIMachineTrampolines):
      (JSC::JIT::privateCompileCTINativeCall):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::stringGetByValStubGenerator):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::stringGetByValStubGenerator):
      (JSC::JIT::privateCompilePutByIdTransition):
      (JSC::JIT::privateCompilePatchGetArrayLength):
      (JSC::JIT::privateCompileGetByIdProto):
      (JSC::JIT::privateCompileGetByIdSelfList):
      (JSC::JIT::privateCompileGetByIdProtoList):
      (JSC::JIT::privateCompileGetByIdChainList):
      (JSC::JIT::privateCompileGetByIdChain):
      * jit/JITStubs.cpp:
      * jit/SpecializedThunkJIT.h:
      (JSC::SpecializedThunkJIT::finalize):
      * yarr/YarrJIT.cpp:
      (JSC::Yarr::YarrGenerator::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a00d35
    • wangxianzhu@chromium.org's avatar
      Basic enhancements to StringBuilder · b458c9cb
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67081
      
      Source/JavaScriptCore:
      
      This change contains the following enhancements to StringBuilder,
      for convenience, performance, testability, etc.:
      - Change toStringPreserveCapacity() to const
      - new public methods: capacity(), swap(), toAtomicString(), canShrink()
        and append(const StringBuilder&)
      - == and != opearators to compare StringBuilders and a StringBuilder/String
      
      Unit tests: Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp
      
      Reviewed by Darin Adler.
      
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * wtf/text/AtomicString.cpp:
      (WTF::SubstringTranslator::hash):
      (WTF::SubstringTranslator::equal):
      (WTF::SubstringTranslator::translate):
      (WTF::AtomicString::add):
      (WTF::AtomicString::addSlowCase):
      * wtf/text/AtomicString.h:
      (WTF::AtomicString::AtomicString):
      (WTF::AtomicString::add):
      * wtf/text/StringBuilder.cpp:
      (WTF::StringBuilder::reifyString):
      (WTF::StringBuilder::resize):
      (WTF::StringBuilder::canShrink):
      (WTF::StringBuilder::shrinkToFit):
      * wtf/text/StringBuilder.h:
      (WTF::StringBuilder::append):
      (WTF::StringBuilder::toString):
      (WTF::StringBuilder::toStringPreserveCapacity):
      (WTF::StringBuilder::toAtomicString):
      (WTF::StringBuilder::isEmpty):
      (WTF::StringBuilder::capacity):
      (WTF::StringBuilder::is8Bit):
      (WTF::StringBuilder::swap):
      (WTF::equal):
      (WTF::operator==):
      (WTF::operator!=):
      * wtf/text/StringImpl.h:
      
      Source/WebCore:
      
      These changes are because we explicitly disallowed StringBuilder's
      copy constructor and assignment operator, and the change of return
      type of StringBuilder::toString().
      
      Reviewed by Darin Adler.
      
      No new tests. All layout tests and unit tests should run as before.
      
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
      * svg/SVGPathStringBuilder.h:
      (WebCore::SVGPathStringBuilder::cleanup):
      
      Source/WebKit/chromium:
      
      This change is because we explicitly disallowed StringBuilder's
      copy constructor and assignment operator.
      
      Reviewed by Darin Adler.
      
      No new tests. All layout tests and unit tests should run as before.
      
      * src/WebPageSerializerImpl.cpp:
      (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
      
      Tools:
      
      Reviewed by Darin Adler.
      
      * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
      (TestWebKitAPI::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b458c9cb
    • wjmaclean@chromium.org's avatar
      [chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura. · 632ff8f0
      wjmaclean@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=75732
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Add WebSolidColorLayer to paint solid-color layers without a backing texture.
      
      Test: unit test for CCSolidColorLayerImpl.
      
      * WebCore.gypi:
      * platform/graphics/chromium/SolidColorLayerChromium.cpp: Added.
      (WebCore::SolidColorLayerChromium::createCCLayerImpl):
      (WebCore::SolidColorLayerChromium::create):
      (WebCore::SolidColorLayerChromium::SolidColorLayerChromium):
      (WebCore::SolidColorLayerChromium::~SolidColorLayerChromium):
      * platform/graphics/chromium/SolidColorLayerChromium.h: Added.
      * platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Added.
      (WebCore::CCSolidColorLayerImpl::CCSolidColorLayerImpl):
      (WebCore::CCSolidColorLayerImpl::~CCSolidColorLayerImpl):
      (WebCore::CCSolidColorLayerImpl::quadTransform):
      (WebCore::CCSolidColorLayerImpl::appendQuads):
      * platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Added.
      (WebCore::CCSolidColorLayerImpl::create):
      (WebCore::CCSolidColorLayerImpl::layerTypeAsString):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * WebKit.gypi:
      * public/platform/WebSolidColorLayer.h: Added.
      * src/WebSolidColorLayer.cpp: Added.
      (WebKit::WebSolidColorLayer::create):
      (WebKit::WebSolidColorLayer::WebSolidColorLayer):
      (WebKit::WebSolidColorLayer::setBackgroundColor):
      * src/WebSolidColorLayerImpl.cpp: Added.
      (WebKit::WebSolidColorLayerImpl::create):
      (WebKit::WebSolidColorLayerImpl::WebSolidColorLayerImpl):
      (WebKit::WebSolidColorLayerImpl::~WebSolidColorLayerImpl):
      * src/WebSolidColorLayerImpl.h: Added.
      * tests/CCLayerTestCommon.cpp: Added.
      (CCLayerTestCommon::completelyContains):
      (CCLayerTestCommon::verifyQuadsExactlyCoverRect):
      * tests/CCLayerTestCommon.h: Added.
      * tests/CCSolidColorLayerImplTest.cpp: Added.
      (CCLayerTestCommon::TEST):
      * tests/CCTiledLayerImplTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      632ff8f0
    • abarth@webkit.org's avatar
      Update the baselines for a number of tests that use gradients. The new · ee769d43
      abarth@webkit.org authored
      results are just slightly different than the old results.
      
      * fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
      * fast/gradients/border-image-gradient-expected.txt: Added.
      * fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Added.
      * platform/chromium-linux-x86/fast/gradients: Removed.
      * platform/chromium-linux/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
      * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
      * platform/chromium-linux/fast/dom/HTMLMeterElement/meter-styles-expected.png:
      * platform/chromium-linux/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
      * platform/chromium-linux/fast/gradients/css3-color-stops-expected.png: Removed.
      * platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png:
      * platform/chromium-linux/fast/gradients/generated-gradients-expected.png:
      * platform/chromium-linux/fast/gradients/simple-gradients-expected.png:
      * platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
      * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac-leopard/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-mac-leopard/fast/gradients/generated-gradients-expected.png:
      * platform/chromium-mac-leopard/fast/reflections/reflection-masks-expected.png:
      * platform/chromium-mac-snowleopard/fast/canvas/fillrect_gradient-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement: Added.
      * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/css3-color-stops-expected.png:
      * platform/chromium-mac-snowleopard/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/generated-gradients-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/gradients/simple-gradients-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/reflections/reflection-masks-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-2-expected.png:
      * platform/chromium-mac-snowleopard/svg/filters/big-sized-filter-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/chromium-mac/fast/canvas/fillrect_gradient-expected.png: Removed.
      * platform/chromium-mac/fast/canvas/gradient-add-second-start-end-stop-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/border-image-gradient-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/generated-gradients-expected.png: Removed.
      * platform/chromium-mac/fast/gradients/simple-gradients-expected.png: Removed.
      * platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
      * platform/chromium-mac/svg/filters/big-sized-filter-expected.png: Removed.
      * platform/chromium-win-vista/fast/gradients: Removed.
      * platform/chromium-win-xp/svg/as-background-image: Removed.
      * platform/chromium-win/fast/canvas/fillrect_gradient-expected.png:
      * platform/chromium-win/fast/canvas/gradient-add-second-start-end-stop-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.png:
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
      * platform/chromium-win/fast/gradients/border-image-gradient-expected.png:
      * platform/chromium-win/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
      * platform/chromium-win/fast/gradients/css3-color-stops-expected.png:
      * platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png:
      * platform/chromium-win/fast/gradients/generated-gradients-expected.png:
      * platform/chromium-win/fast/gradients/simple-gradients-expected.png:
      * platform/chromium-win/fast/reflections/reflection-masks-expected.png:
      * platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
      * platform/chromium-win/svg/filters/big-sized-filter-expected.png:
      * platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
      * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
      * platform/gtk/fast/gradients/border-image-gradient-expected.txt: Removed.
      * platform/gtk/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
      * platform/mac/fast/gradients/border-image-gradient-expected.txt: Removed.
      * platform/mac/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
      * platform/qt/fast/gradients/border-image-gradient-expected.txt: Removed.
      * platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee769d43
    • antti@apple.com's avatar
      Attempt to fix Qt build. · 482c8690
      antti@apple.com authored
          
      Not reviewed.
      
      * css/CSSElementStyleDeclaration.cpp:
      * css/CSSElementStyleDeclaration.h:
      (WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      482c8690
    • kling@webkit.org's avatar
      Move m_rootEditableElementForSelectionOnMouseDown off of HTMLAnchorElement. · dd8f105d
      kling@webkit.org authored
      <http://webkit.org/b/76833>
      
      Reviewed by Antti Koivisto.
      
      Move HTMLAnchorElement::m_rootEditableElementForSelectionOnMouseDown to a rare
      data-style hashmap, effectively shrinking HTMLAnchorElement by one CPU word.
      
      The pointer is only used during interactive event handling, so it shouldn't have
      any noticeable effects on web performance.
      
      This reduces memory consumption by 256 kB (on 64-bit) when viewing the full
      HTML5 spec at <http://whatwg.org/c>.
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::HTMLAnchorElement):
      (WebCore::HTMLAnchorElement::~HTMLAnchorElement):
      (WebCore::HTMLAnchorElement::defaultEventHandler):
      (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
      (WebCore::rootEditableElementMap):
      (WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
      (WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown):
      * html/HTMLAnchorElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd8f105d
    • antti@apple.com's avatar
      Eliminate CSSElementStyleDeclaration subclasses · c5ffc313
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=76827
      
      Reviewed by Andreas Kling.
      
      CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no real purpose.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSElementStyleDeclaration.cpp:
      (WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement):
      (WebCore::CSSElementStyleDeclaration::styleSheet):
      * css/CSSElementStyleDeclaration.h:
      (WebCore::CSSElementStyleDeclaration::createInline):
      (WebCore::toCSSElementStyleDeclaration):
      * css/CSSInlineStyleDeclaration.h: Removed.
      * css/CSSMutableStyleDeclaration.cpp:
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::createInlineStyleDecl):
      (WebCore::StyledElement::ensureInlineStyleDecl):
      (WebCore::StyledElement::copyNonAttributeProperties):
      * dom/StyledElement.h:
      (WebCore::StyledElement::inlineStyleDecl):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
      (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::createDeletionUI):
      * html/ValidationMessage.cpp:
      (WebCore::adjustBubblePosition):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlPanelElement::setPosition):
      (WebCore::MediaControlPanelElement::resetPosition):
      (WebCore::MediaControlPanelElement::makeOpaque):
      (WebCore::MediaControlPanelElement::makeTransparent):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::TrackLimiterElement::create):
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5ffc313
    • philn@webkit.org's avatar
      Unreviewed, unskip now passing tests on GTK. Spotted by Zan Dobersek. · 28cbe9ee
      philn@webkit.org authored
      * platform/gtk/Skipped: Unskip tests 5 tests using ArrayBuffer
      which is no longer tied to 3D_CANVAS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28cbe9ee
    • pfeldman@chromium.org's avatar
      Not reviewed: annotate inspector's js so that it compiled. · fbac799c
      pfeldman@chromium.org authored
      * inspector/front-end/ElementsTreeOutline.js:
      * inspector/front-end/TextPrompt.js:
      (WebInspector.TextPrompt.SuggestBox.prototype.upKeyPressed):
      (WebInspector.TextPrompt.SuggestBox.prototype.downKeyPressed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbac799c
    • philn@webkit.org's avatar
      Unreviewed, mark another test as flaky crash. · dd959658
      philn@webkit.org authored
      * platform/gtk/test_expectations.txt:
      editing/execCommand/19455.html is flaky, sometimes hitting an ASSERT.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd959658
    • philn@webkit.org's avatar
      [GStreamer] fix WebAudio build after r105431 · 9044d10e
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76819
      
      Reviewed by Martin Robinson.
      
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      (WebCore::copyGstreamerBuffersToAudioChannel): Use mutableData()
      when copying.
      * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
      (webKitWebAudioSrcLoop): Drop constness when setting the buffer
      data pointer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9044d10e
    • pfeldman@chromium.org's avatar
      Web Inspector: add touch events to the event listeners list. · 19626316
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76830
      
      Reviewed by Yury Semikhatsky.
      
      * English.lproj/localizedStrings.js:
      * inspector/InjectedScriptSource.js:
      (.):
      * inspector/front-end/BreakpointsSidebarPane.js:
      (WebInspector.EventListenerBreakpointsSidebarPane):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19626316
    • philn@webkit.org's avatar
      Unreviewed, GTK gardening. Rebaseline after r105613, marked 3 svg · b6fe8cbe
      philn@webkit.org authored
      flaky tests and added baselines for 15 tests.
      
      * platform/gtk/css3/images/cross-fade-background-size-expected.txt: Added.
      * platform/gtk/fast/backgrounds/mask-box-image-expected.txt: Added.
      * platform/gtk/fast/borders/scaled-border-image-expected.txt: Added.
      * platform/gtk/fast/css/text-overflow-input-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-floating-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-into-floats-expected.txt: Added.
      * platform/gtk/fast/line-grid/line-grid-positioned-expected.txt: Added.
      * platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
      * platform/gtk/svg/custom/relative-sized-image-expected.txt: Added.
      * platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
      * platform/gtk/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
      * platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Added.
      * platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Added.
      * platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Added.
      * platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Added.
      * platform/gtk/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6fe8cbe
    • pfeldman@chromium.org's avatar
      Web Inspector: inspector close button is missing in the dock-to-right mode. · 5cb7b36f
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76829
      
      Reviewed by Timothy Hatcher.
      
      * inspector/front-end/inspector.js:
      (WebInspector.set attached):
      (WebInspector.get _setCompactMode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cb7b36f
    • ossy@webkit.org's avatar
      [Qt] Unreviewed gardening after r105613. · 8e6c1b2c
      ossy@webkit.org authored
      * platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Updated.
      * platform/qt/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e6c1b2c
    • vsevik@chromium.org's avatar
      Web Inspector: IndexedDBModel should keep track of requests sent to the backend. · e198d1ac
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76705
      
      Reviewed by Pavel Feldman.
      
      * inspector/Inspector.json:
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/front-end/IndexedDBModel.js:
      (WebInspector.IndexedDBModel):
      (WebInspector.IndexedDBModel.prototype._frameDetached):
      (WebInspector.IndexedDBModel.prototype._reset):
      (WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
      (WebInspector.IndexedDBRequestManager):
      (WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame.innerCallback):
      (WebInspector.IndexedDBRequestManager.prototype.requestDatabaseNamesForFrame):
      (WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
      (WebInspector.IndexedDBRequestManager.prototype._requestId):
      (WebInspector.IndexedDBRequestManager.prototype._frameDetached):
      (WebInspector.IndexedDBRequestManager.prototype._reset):
      (WebInspector.IndexedDBRequestManager.DatabasesForFrameRequest):
      (WebInspector.IndexedDBDispatcher):
      (WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e198d1ac
    • pfeldman@chromium.org's avatar
      Web Inspector: Inspecting an element inside an iframe no longer works · 80167912
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76808
      
      Reviewed by Timothy Hatcher.
      
      Source/WebCore:
      
      Test: http/tests/inspector/inspect-element.html
      
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::innerParentNode):
      * inspector/front-end/DOMAgent.js:
      (WebInspector.DOMNode.prototype.getChildNodes.mycallback):
      (WebInspector.DOMNode.prototype.getChildNodes):
      (WebInspector.DOMNode.prototype._setChildrenPayload):
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged):
      
      LayoutTests:
      
      * http/tests/inspector/inspect-element-expected.txt: Added.
      * http/tests/inspector/inspect-element.html: Added.
      * http/tests/inspector/resources/inspect-element-iframe.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80167912
    • caseq@chromium.org's avatar
      Web Inspector: response.bodySize in HAR is invalid (negative) for cached resources · 0ab20076
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76823
      
      Reviewed by Yury Semikhatsky.
      
      - fix response.bodySize for cached resources;
      Also some drive-by fixes:
      - pretty-print HAR when exported
      - proper annotation for JSON.stringify()
      - de-obfuscate a piece of code in TimelinePanel
      
      * inspector/front-end/HAREntry.js:
      (WebInspector.HAREntry.prototype.get responseBodySize):
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkLogView.prototype._exportAll):
      (WebInspector.NetworkLogView.prototype._exportResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ab20076
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · deec8393
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      New files for the implementation of the AtkAction interface,
      containing the related code from WebKitAccessibleWrapperAtk.cpp.
      
      * accessibility/gtk/WebKitAccessibleInterfaceAction.cpp: Added.
      (core):
      (webkitAccessibleActionInterfaceInit):
      (webkitAccessibleActionDoAction):
      (webkitAccessibleActionGetNActions):
      (webkitAccessibleActionGetDescription):
      (webkitAccessibleActionGetKeybinding):
      (webkitAccessibleActionGetName):
      * accessibility/gtk/WebKitAccessibleInterfaceAction.h: Added.
      
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Remove code
      related to the implementation of the AtkAction interface.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleInterfaceAction.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deec8393
    • mario@webkit.org's avatar
      [GTK] run-gtk-tests randomly fails while running the xprop comand · 17fa5a45
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76817
      
      Reviewed by Gustavo Noronha Silva.
      
      No need to use xprop to remove the AT_SPI_BUS property since
      run-gtk-tests will always run new instances of Xvfb.
      
      * Scripts/run-gtk-tests:
      (TestRunner): Unskip TestWebKitAccessibility.
      (TestRunner.run): Uncomment lines for launching the accessibility
      bus and registry daemon, and remove lines for running xprop.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17fa5a45
    • vestbo@webkit.org's avatar
      [Qt] Don't warn about override and final being C++11 extensions · 3fc4b82c
      vestbo@webkit.org authored
      Clang will emit a warning when these extensions are used without passing
      --std=c++11, but we use feature checking to decide if we have the right
      extensions, so we can safely ignore these warnings. The XCode and Windows
      project files have the same workaround.
      
      The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
      we only have one extra compiler for Objective-C, which is also used for
      Objective-C++ sources, so we have to pass the flag, even if it doesn't
      make sense for Objective-C.
      
      Reviewed by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fc4b82c
    • antonm@chromium.org's avatar
      Unreviewed tweaking of test expectations: it should be IMAGE instead of IMAGE+TEXT. · 45e09340
      antonm@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45e09340
    • antonm@chromium.org's avatar
      Unreviewed rebaseline after r105613 (SVG animation repaint issue...). · 4bb94b2e
      antonm@chromium.org authored
      * platform/chromium-mac-leopard/svg/custom/relative-sized-image-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/custom/relative-sized-image-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bb94b2e
    • zimmermann@webkit.org's avatar
      SVG animation repaint issue with image and dynamic clipPath · 6ec5f2fb
      zimmermann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76559
      
      Reviewed by Zoltan Herczeg.
      
      Source/WebCore:
      
      Based on patch by Kelly Norton <knorton@google.com>. I extended the patch
      to correctly handle relative length resolution as well.
      
      RenderSVGImage doesn't react on setNeedsBoundariesUpdate() calls
      and thus fails to update its boundaries in some cases.
      
      The logic is also inconsistent, compared to the other renderers.
      Fix that properly, by reusing the method used in RenderSVGViewportContainer.
      Call calculateImageViewport() immediately, after initializing the LayoutRepainter.
      Previously we resolved the image viewport in RenderSVGImage::updateFromElement. This is
      wrong, as it queries the frameRect() of the RenderSVGRoot in a state, where the renderer
      still needs layout, leading to wrong results.
      
      I turned Kellys manual testcase into a predictable test, see svg/repaint/image-with-clip-path.svg
      Relative sized image handling is tested in svg/custom/relative-sized-image.xhtml now.
      
      Tests: svg/custom/relative-sized-image.xhtml
             svg/repaint/image-with-clip-path.svg
      
      * rendering/svg/RenderSVGImage.cpp:
      (WebCore::RenderSVGImage::RenderSVGImage):
      (WebCore::RenderSVGImage::updateImageViewport):
      (WebCore::RenderSVGImage::layout):
      * rendering/svg/RenderSVGImage.h:
      (WebCore::RenderSVGImage::setNeedsBoundariesUpdate):
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::svgAttributeChanged):
      
      LayoutTests:
      
      Update results after fixing RenderSVGImage repainting.
      
      * platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
      * platform/chromium/test_expectations.txt:
      * platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
      * platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
      * platform/mac/svg/custom/relative-sized-image-expected.png: Added.
      * platform/mac/svg/custom/relative-sized-image-expected.txt: Added.
      * platform/mac/svg/repaint/image-with-clip-path-expected.png: Added.
      * svg/custom/relative-sized-image.xhtml: Added.
      * svg/repaint/image-with-clip-path-expected.txt: Added.
      * svg/repaint/image-with-clip-path.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ec5f2fb
    • zimmermann@webkit.org's avatar
      <feImage> has problems referencing local elements · cf042420
      zimmermann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76800
      
      Reviewed by Zoltan Herczeg.
      
      Source/WebCore:
      
      <feImage> referencing local elements are currently rendered into an ImageBuffer
      by SVGFEImageElement, using the local coordinates of the referenced renderer.
      
      This approach is buggy and should be avoided, by moving the rendering fully
      into SVGFEImage, which takes care of respecting the correct transformations.
      
      This fixes <feImage> + local references, which currently breaks two tests in trunk.
      Covered by existing tests.
      
      * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
      (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
      * svg/SVGFEImageElement.cpp:
      (WebCore::SVGFEImageElement::build):
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::FEImage):
      (WebCore::FEImage::createWithImage):
      (WebCore::FEImage::createWithIRIReference):
      (WebCore::FEImage::determineAbsolutePaintRect):
      (WebCore::FEImage::referencedRenderer):
      (WebCore::FEImage::platformApplySoftware):
      (WebCore::FEImage::externalRepresentation):
      * svg/graphics/filters/SVGFEImage.h:
      (WebCore::FEImage::~FEImage):
      * svg/graphics/filters/SVGFilter.h:
      (WebCore::SVGFilter::absoluteTransform):
      
      LayoutTests:
      
      Update svg/filters/feImage-reference-* results, which are fixed now.
      
      * platform/chromium/test_expectations.txt : Updated.
      * platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Update for marginal change.
      * svg/filters/feImage-reference-invalidation-expected.png:
      * svg/filters/feImage-reference-svg-primitive-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf042420
    • zimmermann@webkit.org's avatar
      2012-01-23 Nikolas Zimmermann <nzimmermann@rim.com> · 0902cc0a
      zimmermann@webkit.org authored
              Not reviewed. Fix Mac build, by exporting a new symbol.
      
              * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0902cc0a
    • mario@webkit.org's avatar
      [GTK] Refactor GTK's accessibilitity code to be more modular · 7ceffa4d
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76783
      
      Reviewed by Martin Robinson.
      
      Move common function returnString() from the wrapper and
      hyperlink implementations to a new utility file.
      
      * accessibility/gtk/WebKitAccessibleUtil.cpp: Added.
      (returnString): Taken from WebKitAccessibleWrapperAtk.cpp and
      WebKitAccessibleHyperlink.cpp
      * accessibility/gtk/WebKitAccessibleUtil.h: Added.
      
      * accessibility/gtk/WebKitAccessibleHyperlink.cpp: Remove local
      implementation of returnString.
      * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp: Ditto.
      
      Add new files to build files.
      
      * GNUmakefile.list.am: Add WebKitAccessibleUtil.[h|cpp].
      * WebCore.gypi: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ceffa4d
    • ossy@webkit.org's avatar
      WebKit fails IETC composition event types · 500ff25a
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=76690
      
      Unreviewed gardening after r105605.
      
      * fast/events/ime-composition-events-001-expected.txt: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      500ff25a