1. 15 Oct, 2012 1 commit
    • tonikitoo@webkit.org's avatar
      [BlackBerry] Clean up BackingStoreClient (part II) · ae434975
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99327
      
      Reviewed by Yong Li.
      Patch by Antonio Gomes <agomes@rim.com>
      
      Remove more unneeded BackingStoreClient <-> WebPageClient integration
      methods:
      - BackingStoreClient* backingStoreClientForFrame(...)
      - void addBackingStoreClientForFrame(...)
      - void removeBackingStoreClientForFrame(...)
      
      Change places calling WPPriv::backingStoreClientForFrame to directly
      access WPPriv::backingStoreClient instead, since only the main frame will
      have a BackingStoreClient instance associated with it, and it is owned by
      the WKPriv.
      
      Remove non-mainframe only references to BackingStoreClient completely,
      since it is dead code now.
      
      * Api/InRegionScroller.cpp:
      (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::backingStoreClient):
      (BlackBerry::WebKit::WebPage::destroy):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
      (WebCore::ChromeClientBlackBerry::scroll):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      (WebCore::FrameLoaderClientBlackBerry::detachedFromParent2):
      * WebKitSupport/BackingStoreClient.cpp:
      (BlackBerry::WebKit::BackingStoreClient::create):
      (BlackBerry::WebKit::BackingStoreClient::BackingStoreClient):
      (BlackBerry::WebKit::BackingStoreClient::~BackingStoreClient):
      * WebKitSupport/BackingStoreClient.h:
      (BackingStoreClient):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setBatchEditingActive):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@131314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae434975
  2. 10 Oct, 2012 2 commits
  3. 05 Oct, 2012 1 commit
  4. 01 Oct, 2012 1 commit
  5. 26 Sep, 2012 1 commit
  6. 25 Sep, 2012 3 commits
  7. 19 Sep, 2012 3 commits
  8. 18 Sep, 2012 2 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Use didCancel and didSucceed instead of didCheckCancel and didCheckSucceed · d4618a15
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97033
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-09-18
      Reviewed by Rob Buis.
      
      Using these preferred public methods (the latter has a note to be made private) ensures that
      the right SpellChecker object is being called during the callback in spellCheckingRequestProcessed
      and spellCheckingRequestCancelled.
      
      Internally reviewed by Mike Fenton.
      
      By referencing the TextCheckingRequest object's methods, we don't need to keep track of the associated
      SpellChecker for each request. Removing much of the code that was put in place incorrectly to achieve this.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::InputHandler):
      (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
      (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
      (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
      (BlackBerry::WebKit::InputHandler::getSpellChecker):
      * WebKitSupport/InputHandler.h:
      (InputHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4618a15
    • anilsson@rim.com's avatar
      [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active · e7e9791f
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96750
      
      Reviewed by Antonio Gomes.
      
      The region of interest mechanism replaces the scrolling/zooming
      functionality in InputHandler::ensureFocusTextElementVisible().
      
      We introduce a new fine-grained setting for the various adjustment
      modes. The WebKit embedder can disable all scroll types in favor of the
      region of interest mechanism by using the new setting.
      
      PR #208387
      
      Reviewed internally by Mike Fenton.
      
      * WebKitSupport/AboutData.cpp:
      (BlackBerry::WebKit::configPage):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
      * WebKitSupport/InputHandler.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7e9791f
  9. 14 Sep, 2012 1 commit
  10. 13 Sep, 2012 1 commit
  11. 11 Sep, 2012 3 commits
  12. 06 Sep, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [BlackBerry] Implement a color picker · 723bbd48
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96001
      
      Patch by Crystal Zhang <haizhang@rim.com> on 2012-09-06
      Reviewed by Rob Buis.
      
      Source/WebKit:
      
      Add color picker files into building system.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:
      
      Add files for color picker, replace old hook to AIR color picker.
      
      * WebCoreSupport/ColorPickerClient.cpp: Added.
      (WebCore):
      (WebCore::ColorPickerClient::ColorPickerClient):
      (WebCore::ColorPickerClient::~ColorPickerClient):
      (WebCore::ColorPickerClient::generateHTML):
      (WebCore::ColorPickerClient::closePopup):
      (WebCore::ColorPickerClient::contentSize):
      (WebCore::ColorPickerClient::htmlSource):
      (WebCore::ColorPickerClient::setValueAndClosePopup):
      (WebCore::ColorPickerClient::didClosePopup):
      (WebCore::ColorPickerClient::writeDocument):
      * WebCoreSupport/ColorPickerClient.h: Added.
      (WebKit):
      (WebCore):
      (ColorPickerClient):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::openColorPopup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      723bbd48
  13. 05 Sep, 2012 1 commit
  14. 04 Sep, 2012 1 commit
  15. 29 Aug, 2012 1 commit
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Adjust wtf include header style · 778b9b06
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95368
      
      Reviewed by Yong Li.
      
      Switch to #include <wtf/...> like the other ports.
      
      Source/WebCore:
      
      * platform/graphics/blackberry/LayerFilterRenderer.h:
      
      Source/WebKit/blackberry:
      
      * Api/BlackBerryGlobal.cpp:
      * Api/WebPage.cpp:
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      * WebCoreSupport/GeolocationControllerClientBlackBerry.h:
      * WebCoreSupport/SelectPopupClient.h:
      * WebKitSupport/AboutData.cpp:
      * WebKitSupport/DOMSupport.cpp:
      * WebKitSupport/GLES2Context.cpp:
      * WebKitSupport/InPageSearchManager.h:
      * WebKitSupport/InputHandler.cpp:
      
      Tools:
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
      * DumpRenderTree/blackberry/PNGImageEncoder.h:
      * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
      * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
      * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      778b9b06
  16. 28 Aug, 2012 2 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Spellcheck should be enabled if undefined in content. · bde97cc7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95139
      
      Currently we only enable spellcheck if it is defined as such in
      the web content explicitly.
      Making this change to enable by default, and only turn off if it is
      explicitly set, or if we expect the field to be a username, email or
      url.
      
      Internally reviewed by Mike Fenton.
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-28
      Reviewed by Rob Buis.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
      (BlackBerry::WebKit::InputHandler::setElementFocused):
      (BlackBerry::WebKit::InputHandler::unlockSequenceMap):
      (WebKit):
      (BlackBerry::WebKit::InputHandler::shouldSpellCheckElement):
      * WebKitSupport/InputHandler.h:
      (InputHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bde97cc7
    • commit-queue@webkit.org's avatar
      [BlackBerry] Range boundaries should use endOfBlock instead of endOfLine. · aac8d7d6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95135
      
      The original implementation used nextLinePosition to iterate
      through the field from the start of each line, and was bounded in
      comparison to the endOfLine. This works fine as long as there aren't any
      empty lines between paragraphs of text, since these will have
      startOfLine == endOfLine and break out.
      
      Also, protect map access with a mutex in case we get a response
      before updating the map. Further, we should check the Range pointer
      before using it, since its not guaranteed to be valid.
      
      Internally reviewed by Mike Fenton.
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-08-28
      Reviewed by Antonio Gomes.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::spellCheckBlock):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aac8d7d6
  17. 16 Aug, 2012 1 commit
  18. 15 Aug, 2012 2 commits
  19. 14 Aug, 2012 2 commits
  20. 13 Aug, 2012 1 commit
  21. 08 Aug, 2012 1 commit
  22. 07 Aug, 2012 1 commit
    • mifenton@rim.com's avatar
      [BlackBerry] Update API for spell checking suggestions. · 77cbd20a
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=93356
      
      Reviewed by Antonio Gomes.
      
      PR 163283.
      
      Add connections for updated spell checking options request API.  Move
      all this logic into InputHandler.
      
      Reviewed Internally by Gen Mak and Nima Ghanavatian.
      
      * Api/WebPageClient.h:
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
      (WebKit):
      (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
      * WebKitSupport/InputHandler.h:
      (Platform):
      (InputHandler):
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      * WebKitSupport/TouchEventHandler.h:
      (TouchEventHandler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77cbd20a
  23. 01 Aug, 2012 1 commit
  24. 31 Jul, 2012 1 commit
  25. 30 Jul, 2012 1 commit
    • mifenton@rim.com's avatar
      [BlackBerry] Optimize the generation of selection details generation. · fb68f99e
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=92522
      
      Reviewed by Antonio Gomes.
      
      PR 179264.
      
      Reduce the number of times we generate selection details notifications.
      
      This removes several notifications that are handled by the standard
      notification path and makes skipping duplicate notifications the default
      so that only those that must generate a response do.
      
      Reviewed Internally by Gen Mak.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
      (BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
      (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
      (BlackBerry::WebKit::SelectionHandler::setSelection):
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      * WebKitSupport/SelectionHandler.h:
      (SelectionHandler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb68f99e
  26. 27 Jul, 2012 1 commit
  27. 26 Jul, 2012 2 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] Support async spellcheck for the blackberry port · e828e9fc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92160
      
      Source/WebCore:
      
      Set USE_UNIFIED_TEXT_CHECKING for PLATFORM(BLACKBERRY) to use the
      asynchronous spellchecking code path.
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
      Reviewed by Rob Buis.
      
      Internally reviewed by Mike Fenton.
      
      * platform/text/TextChecking.h:
      (WebCore):
      
      Source/WebKit/blackberry:
      
      PR124517
      Implementing support for async spellcheck.
      
      Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-07-26
      Reviewed by Rob Buis.
      
      Internally reviewed by Mike Fenton.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::spellCheckingRequestCancelled):
      (WebKit):
      (BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      * Api/WebPage.h:
      * Api/WebSettings.cpp:
      (WebKit):
      (BlackBerry::WebKit::WebSettings::standardSettings):
      (BlackBerry::WebKit::WebSettings::isAsynchronousSpellCheckingEnabled):
      (BlackBerry::WebKit::WebSettings::setAsynchronousSpellCheckingEnabled):
      * Api/WebSettings.h:
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore):
      (WebCore::EditorClientBlackBerry::requestCheckingOfString):
      (WebCore::EditorClientBlackBerry::checkTextOfParagraph):
      * WebCoreSupport/EditorClientBlackBerry.h:
      (EditorClientBlackBerry):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::requestCheckingOfString):
      (BlackBerry::WebKit::InputHandler::convertTransactionIdToSequenceId):
      (WebKit):
      (BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
      (BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
      (BlackBerry::WebKit::InputHandler::getSpellChecker):
      * WebKitSupport/InputHandler.h:
      (WebCore):
      (InputHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e828e9fc
    • mifenton@rim.com's avatar
      [BlackBerry] InputHandler failure logs should be logAlways and critical. · 9d223074
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=92403
      
      Reviewed by Rob Buis.
      
      Update Log level for failures and fix mask in log.
      
      Reviewed Internally by Nima Ghanavatian.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::convertStringToWchar):
      (BlackBerry::WebKit::convertStringToWcharVector):
      (BlackBerry::WebKit::convertSpannableStringToString):
      (BlackBerry::WebKit::InputHandler::spannableTextInRange):
      (BlackBerry::WebKit::InputHandler::setTextAttributes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d223074
  28. 25 Jul, 2012 1 commit