1. 22 Mar, 2013 40 commits
    • mhahnenberg@apple.com's avatar
      opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData · ad21fd2f
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113086
      
      Reviewed by Geoffrey Garen.
      
      opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to 
      share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause 
      a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move 
      this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.
      
      * API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
      * API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.
      (OpaqueJSClass::contextData):
      * API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
      * API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts
      doesn't cause leaks of the original global object.
      (leakFinalize):
      (nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
      objects and keeping them alive, ruining the test result.
      (testLeakingPrototypesAcrossContexts):
      (main):
      * API/tests/testapi.mm: extern "C" this so we can continue using it here.
      * runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.
      (JSC::JSGlobalData::~JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that 
      clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
      (JSGlobalObject):
      (JSGlobalObjectRareData):
      (JSC::JSGlobalObject::opaqueJSClassData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad21fd2f
    • mrobinson@webkit.org's avatar
      [GTK] Add WebCoreDOM to the gyp build · 675e03dd
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112737
      
      Reviewed by Nico Weber.
      
      * WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      675e03dd
    • mrobinson@webkit.org's avatar
      [GTK] Add WebCoreHTML to the gyp build · c6b5f2df
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112727
      
      Reviewed by Nico Weber.
      
      * WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under
      the HTML directory. This includes splitting off common WebCore dependencies
      into an aggregate target and adding a top-level WebCore target.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6b5f2df
    • timothy_horton@apple.com's avatar
      Plugin Snapshotting: Auto-start dominant plugins · b33e5e04
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113111
      <rdar://problem/13475726>
      
      Reviewed by Dean Jackson.
      
      * html/HTMLPlugInElement.cpp:
      (WebCore::HTMLPlugInElement::defaultEventHandler):
      Acknowledge the new "Restarting" DisplayState.
      * html/HTMLPlugInElement.h:
      Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
      Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
      (WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
      (WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
      (WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
      (WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
      Move the plugin to Restarting unless it's already marked as PendingMouseClick.
      (WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
      (WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.
      * html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
      (WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
      (WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::didInitializePlugin):
      (WebKit::PluginView::paint):
      (WebKit::PluginView::invalidateRect):
      (WebKit::PluginView::isAcceleratedCompositingEnabled):
      Acknowledge the new "Restarting" DisplayState.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b33e5e04
    • pkasting@chromium.org's avatar
      [chromium] Mark test as expected to timeout. · 0bf551a3
      pkasting@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113114
      
      Unreviewed, test expectations update.
      
      * platform/chromium/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bf551a3
    • mrobinson@webkit.org's avatar
      [GTK] Add support for building the WebCore bindings to the gyp build · 4bf12a55
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112638
      
      Reviewed by Nico Weber.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct
      dependents and fix the indentation of the libjavascriptcore target.
      
      Source/WebCore:
      
      Add targets, actions, and rules for building the WebCore bindings. This is
      the first part of the WebCoreGTK build.
      
      * WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
      * WebCore.gyp/MakeNames.gypi: Added.
      * WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted
      from the Chromium build.
      * WebCore.gypi: Updated list of derived sources files and added a parameter
      for adjusting the location of the built files. We don't want to force the
      Mac build to change, but we'd still like to reuse the scripts that the
      Chromium build uses.
      
      Source/WebKit/gtk:
      
      * gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of
      the WebCore derived sources.
      * gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK
      gyp file the default for the build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf12a55
    • mrobinson@webkit.org's avatar
      [GTK] [gyp] Expose a few more compiler defines for the gyp build · 081a3897
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113109
      
      Reviewed by Gustavo Noronha Silva.
      
      * gyp/Configuration.gypi.in: Expose the version number string and data
      directory to the gyp build as command-line arguments.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      081a3897
    • mrobinson@webkit.org's avatar
      [GTK] [gyp] Feature defines are not space separated · 8f5a4aee
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113108
      
      Reviewed by Gustavo Noronha Silva.
      
      * gyp/configure.ac: Properly export feature defines for gyp during
      configure phase.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f5a4aee
    • commit-queue@webkit.org's avatar
      [BlackBerry] Build fix in InputHandler · 1488d2de
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113092
      
      Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1488d2de
    • jer.noble@apple.com's avatar
      After switching to another space and back, video races to catch up with audio · 051dc09b
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113006
      
      Reviewed by Anders Carlsson.
      
      Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
      a visibility update when that notification is observed.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView dealloc]): Unregister the observer.
      (-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
      (-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      051dc09b
    • commit-queue@webkit.org's avatar
      Add client callbacks to notify of changes of associated from controls · 8756e329
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110375
      
      Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
      Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
      are dynamically created, autofill can know to re-query the autofill server and keep going.
      https://bugs.webkit.org/show_bug.cgi?id=110375
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::didAssociateFormControl):
      (WebCore):
      (WebCore::Document::didAssociateFormControlsTimerFired):
      * dom/Document.h:
      (Document):
      added method didAssociateFormControl, which batches form changes
      and calls out to ChromeClient on a timer.
      * html/FormAssociatedElement.cpp:
      (WebCore::FormAssociatedElement::resetFormOwner):
      (WebCore::FormAssociatedElement::formAttributeChanged):
      (WebCore):
      * html/FormAssociatedElement.h:
      (FormAssociatedElement):
      add calls to Document::didAssociateFormControl when form changes
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::insertedInto):
      (WebCore):
      * html/HTMLFormElement.h:
      add call to Document::didAssociateFormControl
      * loader/EmptyClients.h:
      (EmptyChromeClient):
      (WebCore::EmptyChromeClient::didAssociateFormControls):
      (WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):
      * page/ChromeClient.h:
      (ChromeClient):
      add new method didAssociateFormControls
      
      Source/WebKit/chromium:
      
      Implement form association methods of ChromeClient
      to inform autofill of form changes after a page has loaded
      
      * public/WebAutofillClient.h:
      (WebAutofillClient):
      (WebKit::WebAutofillClient::didAssociateInput):
      (WebKit::WebAutofillClient::didAddForm):
      (WebKit::WebAutofillClient::didAssociateFormControls):
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::didAssociateFormControls):
      (WebKit):
      (WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8756e329
    • schenney@chromium.org's avatar
      [Chromium] Test expectations after Skia changes · 9e72d68b
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      The next round.
      
      Too many files to list, plus ...
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e72d68b
    • fpizlo@apple.com's avatar
      Fix some minor issues in the DFG's profiling of heap accesses · c5c0fa4e
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113010
      
      Reviewed by Goeffrey Garen.
              
      1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.
      
      2) If a CodeBlock clears a structure stub during GC, it should record this, and
      the DFG should prefer to not inline that access (i.e. treat it as if it had an
      exit site).
      
      3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
      but it chose not to, then assume that it will take slow path.
      
      4) If we frequently exited because of a structure check on a weak constant,
      don't try to inline that access in the future.
      
      5) Treat all exits that were counted as being frequent.
              
      81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::finalizeUnconditionally):
      (JSC):
      (JSC::CodeBlock::resetStubDuringGCInternal):
      (JSC::CodeBlock::reoptimize):
      (JSC::CodeBlock::jettison):
      (JSC::ProgramCodeBlock::jettisonImpl):
      (JSC::EvalCodeBlock::jettisonImpl):
      (JSC::FunctionCodeBlock::jettisonImpl):
      (JSC::CodeBlock::tallyFrequentExitSites):
      * bytecode/CodeBlock.h:
      (CodeBlock):
      (JSC::CodeBlock::tallyFrequentExitSites):
      (ProgramCodeBlock):
      (EvalCodeBlock):
      (FunctionCodeBlock):
      * bytecode/GetByIdStatus.cpp:
      (JSC::GetByIdStatus::computeFor):
      * bytecode/PutByIdStatus.cpp:
      (JSC::PutByIdStatus::computeFor):
      * bytecode/StructureStubInfo.h:
      (JSC::StructureStubInfo::StructureStubInfo):
      (StructureStubInfo):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::handleGetById):
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGOSRExit.cpp:
      (JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
      * dfg/DFGOSRExit.h:
      (JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
      (OSRExit):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * runtime/Options.h:
      (JSC):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5c0fa4e
    • benjamin@webkit.org's avatar
      Name correctly the argument of StringImpl::setIsAtomic() · ba3942d1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113000
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
      Reviewed by Geoffrey Garen.
      
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::setIsAtomic):
      The argument was probably an unfortunate copy-paste from setIsIdentifier().
      Fix the name.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba3942d1
    • ap@apple.com's avatar
      Split ResourceHandleMac into multiple files · 6366a11b
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113100
      
              Reviewed by Geoff Garen.
      
              It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
              substantially more complicated yet.
      
              1. Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
              2. Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into
              separate files.
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/SynchronousLoaderClient.cpp: Added.
              * platform/network/SynchronousLoaderClient.h: Added.
              * platform/network/cf/ResourceHandleCFNet.cpp:
              * platform/network/mac/SynchronousLoaderClient.mm: Added.
              * platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
              * platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6366a11b
    • schenney@chromium.org's avatar
      [Chromium] Test expectation after Skia changes · 774064e3
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      SVG and Compositing tests
      
      Too many files to list, plus ...
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      774064e3
    • rniwa@webkit.org's avatar
    • ggaren@apple.com's avatar
      Added a setting for whether JavaScript markup is enabled · aaeb65ec
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112999
      
      Reviewed by Maciej Stachowiak.
      
      This setting is useful for clients that want protection from script
      injection attacks.
      
      ../WebCore: 
      
      * page/Settings.h:
      (Settings): Clarified which clients should call canExecuteScripts().
      
      * page/Settings.in: Added the new setting.
      
      ../WebKit2: 
      
      * Shared/WebPreferencesStore.h:
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesGetJavaScriptMarkupEnabled):
      (WKPreferencesSetJavaScriptMarkupEnabled):
      (WKPreferencesGetJavaScriptEnabled):
      * UIProcess/API/C/WKPreferences.h:
      * UIProcess/API/mac/WKBrowsingContextGroup.mm:
      (-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
      (-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences): Plumbed through to API.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaeb65ec
    • rniwa@webkit.org's avatar
      Add a failing test expectation to media/track/track-prefer-captions.html on Windows after r146647. · 4f321bbc
      rniwa@webkit.org authored
      The failure is tracked by the bug 113106.
      
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f321bbc
    • rniwa@webkit.org's avatar
      [Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails · 1adfa937
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113102
      
      Skip a test added by r146644 since writing into clipboard is not supported on Windows port.
      
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1adfa937
    • roger_fong@apple.com's avatar
      Unreviewed build fix. · 6865796c
      roger_fong@apple.com authored
      * bindings/scripts/preprocessor.pm:
      (applyPreprocessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6865796c
    • pdr@google.com's avatar
      Update svg/custom/marker-orient-auto expectations · b16d0b69
      pdr@google.com authored
      Unreviewed update of test expectations.
      
      * platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.png: Added.
      * platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.txt: Added.
      * platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.png: Added.
      * platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.txt: Added.
      * platform/chromium-mac/svg/custom/marker-orient-auto-expected.png: Added.
      * platform/chromium-mac/svg/custom/marker-orient-auto-expected.txt: Added.
      * platform/chromium-win/svg/custom/marker-orient-auto-expected.png: Added.
      * platform/chromium-win/svg/custom/marker-orient-auto-expected.txt: Added.
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b16d0b69
    • rniwa@webkit.org's avatar
      Add failing test expectations for two more position: sticky tests to make Mac EWS happy. · 1c5dbcb5
      rniwa@webkit.org authored
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c5dbcb5
    • rniwa@webkit.org's avatar
      NRWT: Enable pixel tests when retrying tests · 429520cf
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112898
      
      Reviewed by Dirk Pranke.
      
      Tools: 
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
      if we've forced pixel tests in the retry.
      (Manager._run_tests):
      (Manager._clean_up_run): Fixed the capitalizations.
      (Manager._force_pixel_tests_if_needed): Added.
      
      * Scripts/webkitpy/layout_tests/models/test_run_results.py:
      (_interpret_test_failures): Now that this function maybe called multiple times, only set
      'image_diff_percent' if it doesn't already exist.
      
      (summarize_results): When the first attempt resulted in a text failure and the second attempt
      resulted in image and text failures and we've forced to run pixel tests in the retry run,
      treat this as a regular regression instead of a flakiness.
      
      Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
      run had image diffs.
      
      * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
      (summarized_results):
      
      * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
      Also removed some dead code.
      
      (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
      pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
      is set and pixel_tests_enabled is set to false.
      (EndToEndTest.test_reftest_with_two_notrefs):
      
      LayoutTests: 
      
      Link to images and image diff in retries when they're only available in retries.
      
      * fast/harness/resources/results-test.js: Added a test case.
      * fast/harness/results-expected.txt:
      * fast/harness/results.html:
      (imageResultsCell): Extracted from tableRow.
      (tableRow): Split the actual result into two tokens (first attempt and retry),
      and then check if the image failure was detected in the first attempt. If not,
      add hyperlinks to the actual results in the retry run.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      429520cf
    • pdr@google.com's avatar
      Update svg/custom/marker-orient-auto-expected test expectation. · 66c3734e
      pdr@google.com authored
      Unreviewed update of test expectations.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66c3734e
    • schenney@chromium.org's avatar
      [Chromium] Test expectation after Skia changes · 7e8a2753
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      One more not-expected failure, fixed.
      
      * platform/chromium-mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png:
      * platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
      * platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e8a2753
    • schenney@chromium.org's avatar
      [Chromium] Test expectation after Skia changes · f8a839f0
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      Some more currently failing (not expected) tests.
      
      * platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png:
      * platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
      * platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-expected.png:
      * platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
      * platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
      * platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8a839f0
    • fpizlo@apple.com's avatar
      DFG folding of PutById to SimpleReplace should consider the specialized function case · fd016b18
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113093
      
      Reviewed by Geoffrey Garen and Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * bytecode/PutByIdStatus.cpp:
      (JSC::PutByIdStatus::computeFor):
      
      LayoutTests: 
      
      * fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function-expected.txt: Added.
      * fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js: Added.
      (foo):
      (baz):
      (fuzz):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd016b18
    • rniwa@webkit.org's avatar
      Add failing test expectations to the test added by r146644 on Mac. · abf10ce4
      rniwa@webkit.org authored
      The failure is tracked by http://webkit.org/b/113094.
      
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abf10ce4
    • roger_fong@apple.com's avatar
      Unreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process hangs. · d47ef245
      roger_fong@apple.com authored
      This problem is occuring on the WinEWS bots where there are somehow multiple gcc-3 processes existing at the same time.
      This is a speculative fix. There should only be 1 gcc-3.exe process running at a time ever.
      
      * bindings/scripts/preprocessor.pm:
      (applyPreprocessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d47ef245
    • timothy_horton@apple.com's avatar
      Make it possible to run layout tests on Retina MBP · 084f0f24
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=93673
      
      Reviewed by Ryosuke Niwa.
      
      Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
      windows on 2x machines still run at 1x.
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (createWebViewAndOffscreenWindow):
      Reset the window resolution to 1x on creation.
      * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
      * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
      (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
      * WebKitTestRunner/mac/PlatformWebViewMac.mm:
      (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
      (WTR::PlatformWebView::PlatformWebView):
      Add NSWindow details, reset the window resolution to 1x on creation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      084f0f24
    • eric.carlson@apple.com's avatar
      Cleanup text track selection logic · d4e6f18f
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113062
      
      Reviewed by Jer Noble.
      
      No new tests, covered by existing tests.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Remove.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Don't look at track attributes directly,
          use captionPreferences->textTrackSelectionScore to calculate track rank.
      (WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_processingPreferenceChange here
          instead of in captionPreferencesChanged.
      (WebCore::HTMLMediaElement::captionPreferencesChanged): Don't suppress calls to setClosedCaptionsVisible,
          existing code already makes sure we don't do unnecessary work.
      * html/HTMLMediaElement.h:
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay): Drive by cleanup, don't
          process inactive cues.
      
      * html/shadow/MediaControlsApple.cpp:
      (WebCore::MediaControlsApple::changedClosedCaptionsVisibility): Call resetTrackListMenu instead
          of updateDisplay so we only mark the menu as needing a recalculation and do the work when
          it is displayed.
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::shouldShowCaptions): When in testing mode, return true if
          the caption or subtitle preference has been set.
      (WebCore::CaptionUserPreferences::setShouldShowCaptions): In testing mode, clear the caption
          and subtitle preference when passed false.
      (WebCore::CaptionUserPreferences::textTrackSelectionScore): Calculate the track score based on
          track type preference and preferred language.
      (WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Score a track according to
          the language presence and position in the preferred languages list.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate track language score 
          according to user preferences.
      
      * platform/Language.cpp:
      (WebCore::indexOfBestMatchingLanguageInList): Repurposed the static bestMatchingLanguage
          function to return the location of a language in a Vector.
      (WebCore::preferredLanguageFromList): Removed.
      * platform/Language.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4e6f18f
    • commit-queue@webkit.org's avatar
      Build fix for TransformationMatrix · d0b4bad6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113087
      
      Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-22
      Reviewed by Martin Robinson.
      
      This is a trivial build fix for clutter ac backend. Clutter AC backend doesn't use
      TextureMapper so there is nowhere including TransformationMatrix.h.
      For the reason, we include it explicitly.
      
      No new tests because of no functionality change.
      
      * platform/graphics/clutter/GraphicsContext3DPrivate.cpp:
      * platform/graphics/clutter/GraphicsContext3DPrivate.h:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0b4bad6
    • commit-queue@webkit.org's avatar
      Coordinates.idl lacks Conditional=GEOLOCATION · f8bca006
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112949
      
      Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
      Reviewed by Steve Block.
      
      No new tests, build optimization only.
      
      * page/Coordinates.idl: Added GEOLOCATION conditional guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8bca006
    • dcheng@chromium.org's avatar
      Data store should be readable in dragstart/copy/cut events · 3a4311f2
      dcheng@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=23695
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      There were several events where data could be written but not read back due to the fact that
      different Clipboard method implementations checked permissions inconsistently. This patch
      adds helper methods to check if an operation is permitted on a Clipboard and refactors all
      direct comparisons against Clipboard::m_policy to use the new helpers instead. This fixes
      several bugs where Clipboard::types and Clipboard::getData are not usable inside the
      aforementioned events.
      
      Tests: editing/pasteboard/can-read-in-copy-and-cut-events.html
             editing/pasteboard/can-read-in-dragstart-event.html
      
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::canReadTypes): Formerly restricted to ClipboardReadable and
                                          ClipboardTypesReadable; now allows ClipboardWritable as
                                          well.
      (WebCore::Clipboard::canReadData): Formerly restricted to ClipboardReadable; now allows
                                         ClipboardWritable as well.
      (WebCore::Clipboard::canWriteData):
      (WebCore::Clipboard::canSetDragImage):
      (WebCore::Clipboard::hasFileOfType):
      (WebCore::Clipboard::hasStringOfType):
      (WebCore::Clipboard::setDropEffect):
      (WebCore::Clipboard::setEffectAllowed):
      * dom/Clipboard.h:
      (Clipboard):
      * platform/blackberry/ClipboardBlackBerry.cpp:
      (WebCore::ClipboardBlackBerry::clearData):
      (WebCore::ClipboardBlackBerry::clearAllData):
      (WebCore::ClipboardBlackBerry::getData):
      (WebCore::ClipboardBlackBerry::setData):
      (WebCore::ClipboardBlackBerry::types):
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::DataTransferItemPolicyWrapper::kind):
      (WebCore::DataTransferItemPolicyWrapper::type):
      (WebCore::DataTransferItemPolicyWrapper::getAsString):
      (WebCore::DataTransferItemPolicyWrapper::getAsFile):
      (WebCore::ClipboardChromium::clearData):
      (WebCore::ClipboardChromium::clearAllData):
      (WebCore::ClipboardChromium::getData):
      (WebCore::ClipboardChromium::setData):
      (WebCore::ClipboardChromium::types):
      (WebCore::ClipboardChromium::files):
      (WebCore::ClipboardChromium::setDragImage):
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::clearData):
      (WebCore::ClipboardGtk::clearAllData):
      (WebCore::ClipboardGtk::getData):
      (WebCore::ClipboardGtk::setData):
      (WebCore::ClipboardGtk::types):
      (WebCore::ClipboardGtk::files):
      (WebCore::ClipboardGtk::setDragImage):
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::clearData):
      (WebCore::ClipboardMac::clearAllData):
      (WebCore::ClipboardMac::getData):
      (WebCore::ClipboardMac::setData):
      (WebCore::ClipboardMac::types):
      (WebCore::ClipboardMac::files):
      (WebCore::ClipboardMac::setDragImage):
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::clearData):
      (WebCore::ClipboardQt::clearAllData):
      (WebCore::ClipboardQt::getData):
      (WebCore::ClipboardQt::setData):
      (WebCore::ClipboardQt::types):
      (WebCore::ClipboardQt::files):
      (WebCore::ClipboardQt::setDragImage):
      (WebCore::ClipboardQt::items):
      * platform/qt/DataTransferItemListQt.cpp:
      (WebCore::DataTransferItemListQt::length):
      (WebCore::DataTransferItemListQt::item):
      (WebCore::DataTransferItemListQt::deleteItem):
      (WebCore::DataTransferItemListQt::clear):
      (WebCore::DataTransferItemListQt::add):
      * platform/qt/DataTransferItemQt.cpp:
      (WebCore::DataTransferItemQt::getAsString):
      * platform/win/ClipboardWin.cpp:
      (WebCore::ClipboardWin::clearData):
      (WebCore::ClipboardWin::clearAllData):
      (WebCore::ClipboardWin::getData):
      (WebCore::ClipboardWin::setData):
      (WebCore::ClipboardWin::types):
      (WebCore::ClipboardWin::files):
      (WebCore::ClipboardWin::setDragImage):
      
      LayoutTests:
      
      * editing/pasteboard/can-read-in-copy-and-cut-events-expected.txt: Added.
      * editing/pasteboard/can-read-in-copy-and-cut-events.html: Added.
      * editing/pasteboard/can-read-in-dragstart-event-expected.txt: Added.
      * editing/pasteboard/can-read-in-dragstart-event.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a4311f2
    • schenney@chromium.org's avatar
      [Chromium] Test expectation after Skia changes · 62c74382
      schenney@chromium.org authored
      Unreviewed expectations update.
      
      Only the things failing on the bots, not already accounted for.
      
      * platform/chromium-linux/fast/text/international/danda-space-expected.png:
      * platform/chromium-mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png:
      * platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png:
      * platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png:
      * platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
      * platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
      * platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
      * platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
      * platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
      * platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
      * platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
      * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
      * platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62c74382
    • abucur@adobe.com's avatar
      [CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView · 3f8f1333
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113084
      
      Reviewed by Dirk Schulze.
      
      Remove void pushLayoutState(RenderFlowThread*, bool regionsChanged) from RenderView.h because it's not used.
      
      Tests: Code cleanup. No tests needed.
      
      * rendering/RenderView.h:
      (RenderView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f8f1333
    • commit-queue@webkit.org's avatar
      Check focused node reference when traversing through history · 538ddbcd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113082
      
      Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
      Reviewed by Rob Buis.
      
      PR312101
      Check if we have a valid node and document before attempting to access its frame and
      frame selection. This is causing issues when going back to a page after a redirect
      where a stale pointer is used.
      Further, the focused node should be changed after the frame is fully loaded.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::setElementUnfocused):
      (BlackBerry::WebKit::InputHandler::restoreViewState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      538ddbcd
    • commit-queue@webkit.org's avatar
      [EFL] Fix build issues to enable CSS Filter and Shaders support. · eea65964
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111274
      
      Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
      Reviewed by Noam Rosenthal.
      
      This is in preperation to enable CSS Filter and Shaders support.
      This patch fixes related build issues to enable the support.
      
      * platform/graphics/surfaces/efl/GLTransportSurface.cpp:
      * platform/graphics/texmap/TextureMapper.cpp:
      * platform/graphics/texmap/TextureMapper.h:
      (WebCore):
      * platform/graphics/texmap/TextureMapperGL.cpp:
      * platform/graphics/texmap/TextureMapperGL.h:
      (WebCore):
      * platform/graphics/texmap/TextureMapperShaderProgram.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eea65964
    • pkasting@chromium.org's avatar
      [chromium] Remove Android platform expectations from Chromium TestExpectations. · 296fc8f7
      pkasting@chromium.org authored
      (Too many bug URLs to list)
      
      Unreivewed, test expectations update.
      
      * platform/chromium/TestExpectations:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      296fc8f7