1. 29 Jul, 2006 7 commits
    • darin's avatar
      JavaScriptCore: · ad19609e
      darin authored
              Reviewed by Darin.
      
              - fixes for Linux build
      
              * JavaScriptCoreSources.bkl: Added new files to build, kjs/PropertyNameArray.cpp
              and kjs/testkjs.cpp, and removed old files.
      
      WebCore:
      
              Reviewed and tweaked by Darin.
      
              - fixes for Linux build
                (still might not compile, since Darin tweaked but was unable to test).
      
              * WebCoreSources.bkl: Added some new sources, removed some obsolete ones.
              * Projects/gdk/webcore-gdk.bkl: Added RenderPopupMenuGdk.cpp
      
              * html/HTMLPlugInElement.h: Removed incorrect syntax with class name
              before ::.
      
              * platform/gdk/FrameGdk.h:
              * platform/gdk/FrameGdk.cpp: Updated parameters of constructor. Moved a couple stubs
              out of this file.
              * platform/gdk/RenderPopupMenuGdk.h: Added.
              * platform/gdk/RenderPopupMenuGdk.cpp: Added. Just a file full of empty stubs.
              * platform/gdk/RenderThemeGdk.h:
              * platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): Added.
      
              * platform/gdk/TemporaryLinkStubs.cpp: Add some new stubs.
      
      WebKitTools:
      
              Reviewed by Darin.
      
              - fixes for Linux build
      
              * GdkLauncher/mk: Added call to bakefile_gen before calling make.
              * GdkLauncher/gdklauncher.bkl: Tweak comment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad19609e
    • darin's avatar
      - changed this test to a plain-text one and added text explaining what it tests · 5c89e9f1
      darin authored
              * fast/forms/input-named-action-overrides-action-attribute.html: Added explanation text,
              got rid of some incorrect HTML syntax, added a call to dumpAsText(), and used a paragraph
              element instead of a span element for the result.
              * fast/forms/input-named-action-overrides-action-attribute-expected.txt: Updated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c89e9f1
    • darin's avatar
      Reviewed by Darin. · 2b76a137
      darin authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10022
              Bug 10022: REGRESSION: Crash in WebCore::XMLTokenizer::characters
      
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::resumeParsing): If the write() call resulted in new callbacks being
              added, don't call through to end() just yet.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b76a137
    • darin's avatar
      WebCore: · af8b72c7
      darin authored
              Reviewed by John Sullivan.
      
              - manual test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9984
                ASSERTION FAILURE: _private->mouseDownEvent != nil
                (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
      
              * manual-tests/subview-click-assertion.html: Added.
      
      WebKit:
      
              Reviewed by John Sullivan.
      
               - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9984
                ASSERTION FAILURE: _private->mouseDownEvent != nil
                (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
      
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _setMouseDownEvent:]): Moved into the WebHTMLViewFileInternal category and changed
              to accept nil.
              (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
              Copy the hit HTMLView's mouse down event to the top HTMLView.
              (-[WebHTMLView acceptsFirstMouse:]): Added a call to _setMouseDownEvent:nil before returning.
              (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Added a call to _setMouseDownEvent:nil
              before returning.
              (-[WebHTMLView mouseUp:]): Added a call to _setMouseDownEvent:nil to clear the event set in
              mouseDown: (and used during dragging).
              (-[WebHTMLView _delegateDragSourceActionMask]): Copy the hit HTMLView's mouse down event to
              the top HTMLView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af8b72c7
    • darin's avatar
      LayoutTests: · 76d3b830
      darin authored
              Reviewed by Darin.
      
              Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
              REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly
      
              * fast/lists/ordered-list-with-no-ol-tag-expected.checksum: Added.
              * fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
              * fast/lists/ordered-list-with-no-ol-tag-expected.txt: Added.
              * fast/lists/ordered-list-with-no-ol-tag.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
              REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly
      
              * rendering/RenderListItem.cpp:
              (WebCore::enclosingList): If no real list element is found, use parent instead.
              (WebCore::previousListItem): Check list elements to see if they are list items -- the
              old code assumed that a list would never be a list item but this is entirely possible
              with CSS and especially with the new rule that means any DOM element could act as a list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76d3b830
    • ap's avatar
      Reviewed by Darin. · d2b4dbc5
      ap authored
              Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10147
              REGRESSION: custom attribute values set via javascript are not persistent
      
              Test: fast/dom/Element/setAttribute-case-insensitivity.html
      
              * dom/Element.cpp:
              (WebCore::Element::setAttribute): Use the lowercased localName for retrieving the old value, too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2b4dbc5
    • darin's avatar
      - rolled out the test for bug 9753, since we rolled out the fix · a0bcc6de
      darin authored
                we'll bring back the test when we bring back the fix
      
              * svg/custom/width-full-percentage-expected.checksum: Removed.
              * svg/custom/width-full-percentage-expected.png: Removed.
              * svg/custom/width-full-percentage-expected.txt: Removed.
              * svg/custom/width-full-percentage.svg: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0bcc6de
  2. 28 Jul, 2006 8 commits
    • thatcher's avatar
      Suggested by Darin. · e8e2d512
      thatcher authored
              Moving the implementation of isContentEditable to the
              the WebPrivate category.
      
              * bindings/objc/DOM.mm:
              (-[DOMNode isContentEditable]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8e2d512
    • justing's avatar
      LayoutTests: · 5c799c43
      justing authored
              Reviewed by levi
              
              <rdar://problem/4515463>
              REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
              
              Removed incorrect nesting:
              * editing/pasteboard/paste-table-001-expected.checksum:
              * editing/pasteboard/paste-table-001-expected.png:
              * editing/pasteboard/paste-table-001-expected.txt:
              * editing/pasteboard/paste-table-003-expected.txt:
      
      WebCore:
      
              Reviewed by levi
              
              First part of:
              <rdar://problem/4515463>
              REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
              
              Migrate to isBlock and enclosingBlock.
              Changed RendereringInfo::isBlock and ReplacementFragment::isBlock
              to wasBlock so that they don't conflict with isBlock and because
              it's more descriptive.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::mergeStartNode):
              (WebCore::ReplacementFragment::wasBlock):
              (WebCore::ReplacementFragment::saveRenderingInfo):
              (WebCore::ReplacementFragment::renderedBlocks):
              (WebCore::RenderingInfo::RenderingInfo):
              (WebCore::ReplaceSelectionCommand::shouldMergeStart):
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::RenderingInfo::wasBlock):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c799c43
    • justing's avatar
      LayoutTests: · 94d07250
      justing authored
              Reviewed by levi
              
              <rdar://problem/4242293>
              Poor paste fidelity of http://www.google.com/
      
              Removed one of the two extraneous newlines that are introduced on paste:
              * editing/pasteboard/paste-table-003-expected.checksum:
              * editing/pasteboard/paste-table-003-expected.png:
              * editing/pasteboard/paste-table-003-expected.txt:
              
              Fewer pastes remove nodes containing the selection b/c of 
              the changes to interchange newlines:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              
              Added:
              * editing/pasteboard/4242293-1-expected.checksum: Added.
              * editing/pasteboard/4242293-1-expected.png: Added.
              * editing/pasteboard/4242293-1-expected.txt: Added.
              * editing/pasteboard/4242293-1.html: Added.
              * editing/pasteboard/4242293-expected.checksum: Added.
              * editing/pasteboard/4242293-expected.png: Added.
              * editing/pasteboard/4242293-expected.txt: Added.
              * editing/pasteboard/4242293.html: Added.
      
      WebCore:
      
              Reviewed by levi
              
              More changes for:
              <rdar://problem/4242293>
              Poor paste fidelity of http://www.google.com/
      
              * editing/markup.cpp:
              (WebCore::needInterchangeNewlineAfter): Added.
              (WebCore::createMarkup): 
              Only add an interchangeNewline if we're annotating for interchange.  Can't test 
              this until we expose createMarkup in non-annotate mode (I'd expose Range::toHTML).
              Remove the FIXME about prepending the interchangeNewline before creating the rest 
              of the markup.  Its correct to surround the interchangeNewline in ancestors of the
              adjusted startNode.
              Fixed the check to see if an interchangeNewline is needed (!inSameBlock).  This would
              add an interchangeNewline for a selection that started before a table.
              Removed the workaround for the bug where markup for a table was not included when 
              selecting the contents of a table, since this change fixes the general problem of 
              markup for ancestors of the startNode being left out.
              Don't leave out ancestors of the startNode as we leave their subtrees.  Execute the
              code to include them even if we closed ancestors in the ancestorsToClose list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94d07250
    • thatcher's avatar
      Reviewed by John. · d2328b29
      thatcher authored
              <rdar://problem/4657473> REGRESSION: Spell check not available from contextual menu in Mail
      
              The context menu code should be checking isContentEditable
              on DOMNode not just DOMElement. This is needed because DOMText
              will be the node class of any text that is clicked.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.m:
              (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2328b29
    • thatcher's avatar
      WebCore: · d8ea1e3a
      thatcher authored
              Reviewed by John.
      
              Adding isContentEditable to DOMNode's private category. 
      
              * bindings/objc/DOMPrivate.h:
      
      WebKit:
      
              Reviewed by John.
      
              The context menu code should be checking isContentEditable
              on DOMNode not just DOMElement. This is needed because DOMText
              will be the node class of any text that is clicked.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.m:
              (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8ea1e3a
    • ap's avatar
      Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=6010 because of... · 86efdc34
      ap authored
          Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=6010 because of failing layout tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86efdc34
    • adele's avatar
      Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=9753... · ea5a7028
      adele authored
              Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 because of failing layout tests.
              SVG with width and height 100% leaves room for scrollbar on the right.
      
              * kcanvas/RenderPath.cpp:
              * kcanvas/RenderPath.h:
              * kcanvas/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout):
              * ksvg2/svg/SVGCircleElement.cpp:
              * ksvg2/svg/SVGCircleElement.h:
              * ksvg2/svg/SVGEllipseElement.cpp:
              * ksvg2/svg/SVGEllipseElement.h:
              * ksvg2/svg/SVGLineElement.cpp:
              * ksvg2/svg/SVGLineElement.h:
              * ksvg2/svg/SVGRectElement.cpp:
              * ksvg2/svg/SVGRectElement.h:
              * ksvg2/svg/SVGStyledElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea5a7028
    • eseidel's avatar
      2006-07-27 Eric Seidel <eric@eseidel.com> · d09b8f64
      eseidel authored
              Reviewed by darin.
              
              Add better SVGLoad event support.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
              There will still need to be additional support added for <link> and <script> elements.
              Not all of the error -> loaded -> error transition cases work yet.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchGenericEvent):
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::dispatchLoadEvent):
              * html/HTMLImageLoader.h:
              (WebCore::HTMLImageLoader::haveFiredLoadEvent):
              (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
              * ksvg2/misc/SVGImageLoader.cpp:
              (WebCore::SVGImageLoader::SVGImageLoader):
              (WebCore::SVGImageLoader::dispatchLoadEvent):
              * ksvg2/misc/SVGImageLoader.h:
              * ksvg2/svg/SVGAElement.cpp:
              (WebCore::SVGAElement::parseMappedAttribute):
              * ksvg2/svg/SVGAnimatedBoolean.h:
              * ksvg2/svg/SVGElement.cpp:
              (WebCore::SVGElement::SVGElement):
              (WebCore::SVGElement::parseMappedAttribute):
              (WebCore::SVGElement::haveLoadedRequiredResources):
              (WebCore::SVGElement::sendSVGLoadEventIfPossible):
              (WebCore::SVGElement::closeRenderer):
              * ksvg2/svg/SVGElement.h:
              (WebCore::SVGElement::rendererIsNeeded):
              (WebCore::svg_dynamic_cast):
              * ksvg2/svg/SVGExternalResourcesRequired.h:
              * ksvg2/svg/SVGImageElement.cpp:
              (SVGImageElement::SVGImageElement):
              (SVGImageElement::haveLoadedRequiredResources):
              * ksvg2/svg/SVGImageElement.h:
              * ksvg2/svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::parseMappedAttribute):
              * ksvg2/svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::SVGScriptElement):
              (WebCore::SVGScriptElement::parseMappedAttribute):
              (WebCore::SVGScriptElement::executeScript):
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d09b8f64
  3. 27 Jul, 2006 9 commits
    • adele's avatar
      Reviewed by Anders. · 80407614
      adele authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=10135
                Cleanup: remove useless parameters from RenderObject::position()
      
              No test possible (no functionality change)
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::position):
              * rendering/RenderBox.h:
              * rendering/RenderObject.h:
              (WebCore::RenderObject::position):
              * rendering/RenderTableRow.h:
              (WebCore::RenderTableRow::position):
              * rendering/RenderTableSection.h:
              (WebCore::RenderTableSection::position):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::position):
              * rendering/RenderText.h:
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::constructLine):
              (WebCore::RenderBlock::computeVerticalPositionsForLine):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80407614
    • adele's avatar
      LayoutTests: · ea0df1c1
      adele authored
              Reviewed by Maciej.
      
              Test case for
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
              SVG with width and height 100% leaves room for scrollbar on the right.
      
              * svg/custom/width-full-percentage-expected.txt: Added.
              * svg/custom/width-full-percentage-expected.checksum: Added.
              * svg/custom/width-full-percentage-expected.png: Added.
              * svg/custom/width-full-percentage.svg: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
              SVG with width and height 100% leaves room for scrollbar on the right.
      
              Relayout children of svg containers, except svg shapes that do not depend on percentages.
      
              * kcanvas/RenderPath.cpp: (WebCore::RenderPath::hasPercentageValues):
              * kcanvas/RenderPath.h:
              * kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
              * ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::hasPercentageValues):
              * ksvg2/svg/SVGCircleElement.h:
              * ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::hasPercentageValues):
              * ksvg2/svg/SVGEllipseElement.h:
              * ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::hasPercentageValues):
              * ksvg2/svg/SVGLineElement.h:
              * ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::hasPercentageValues):
              * ksvg2/svg/SVGRectElement.h:
              * ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasPercentageValues):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea0df1c1
    • justing's avatar
      LayoutTests: · af02b8bb
      justing authored
              Reviewed by levi
              
              <rdar://problem/4242293>
              Poor paste fidelity of http://www.google.com/
      
              * editing/pasteboard/styled-element-markup-expected.checksum: Added.
              * editing/pasteboard/styled-element-markup-expected.png: Added.
              * editing/pasteboard/styled-element-markup-expected.txt: Added.
              * editing/pasteboard/styled-element-markup.html: Added.
      
      WebCore:
      
              Reviewed by levi
              
              <rdar://problem/4242293>
              Poor paste fidelity of http://www.google.com/
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyle):  Fixed crasher with nil-check.
              * editing/markup.cpp:
              (WebCore::startMarkup): Style information wasn't added to an element if it had
              attributes but no style attribute.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af02b8bb
    • lypanov's avatar
      2006-07-27 Alexander Kellett <lypanov@kde.org> · bed13c1f
      lypanov authored
              Reviewed by Darin.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
                REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit
      
              * bindings/scripts/CodeGeneratorJS.pm: add new attribute - HasOverridingNameGetter
              * html/HTMLFormElement.idl:
      
      2006-07-27  Alexander Kellett  <lypanov@kde.org>
      
              Reviewed by Darin.
      
              Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
              REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit
      
              * fast/forms/input-named-action-overrides-action-attribute-expected.txt: Added.
              * fast/forms/input-named-action-overrides-action-attribute.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bed13c1f
    • rwlbuis's avatar
      Reviewed by Anders. · 350968f8
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8992
              Some HTML DOM attributes have incorrect types
      
              Adjust idl and dom source code for HTMLImageElement and
              HTMLBaseFontElement to choose correct type for
              HTMLImageElement::border and HTMLBaseFontElement::size
              attributes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      350968f8
    • justing's avatar
      LayoutTests: · 7a91e03f
      justing authored
              Reviewed by levi
              
              <rdar://problem/4628409>
              Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form
      
              * fast/forms/4628409-expected.txt: Added.
              * fast/forms/4628409.html: Added.
      
      WebCore:
      
              Reviewed by levi
              
              <rdar://problem/4628409>
              Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::removeBlockPlaceholder): 
              A script on the page shrinks the textarea down to zero rows just
              before insertion.  That gives the shadow div a zero height, removing
              [div, 0] as a candidate for a VisiblePosition.  Then 
              InsertTextCommand::input() tries to create a VisiblePosition from 
              [div, 0] and fails.  A nil check is a quick fix.  Another might
              be to make positions where there is a caret selection candidates.
              Another might be to make any [div, 0] where div is a shadow div inside
              a form element a candidate.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a91e03f
    • ap's avatar
      Fix by Graham Dennis, reviewed by Darin. · 75f0bd53
      ap authored
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10094
                Japanese characters improperly rendering in TOT
                
              Test: fast/encoding/denormalised-voiced-japanese-chars.html
      
              * platform/Font.cpp:
              (WebCore::WidthIterator::advance): pass currentCharacter to normalizeVoicingMarks
              (WebCore::WidthIterator::normalizeVoicingMarks): turn the currentCharacter variable
              into an argument as WidthIterator::advance doesn't update m_currentCharacter while
              looping
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75f0bd53
    • eseidel's avatar
      2006-07-27 Eric Seidel <eric@eseidel.com> · d676a5c9
      eseidel authored
              Reviewed by ap.
      
              Complex entities seem to fail on TOT
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6390
              Use an alternative work-around to an XML Entity parsing bug.
      
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::write):
              (WebCore::hackAroundLibXMLEntityBug): added.
              (WebCore::startElementNsHandler):
              (WebCore::endElementNsHandler):
              (WebCore::charactersHandler):
              (WebCore::processingInstructionHandler):
              (WebCore::cdataBlockHandler):
              (WebCore::commentHandler):
              (WebCore::getEntityHandler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d676a5c9
    • rwlbuis's avatar
      Reviewed by Darin. · 987dbc40
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9938
              Fix viewBox issues in Hixie's test
      
              Do a more accurate and quicker job of parsing the viewBox
              attribute. Handle properly on negative width/height and
              invalid syntax in general.
      
              * ksvg2/svg/SVGFitToViewBox.cpp:
              (SVGFitToViewBox::parseViewBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      987dbc40
  4. 26 Jul, 2006 5 commits
    • eseidel's avatar
      2006-07-27 Eric Seidel <eric@eseidel.com> · 3764f870
      eseidel authored
              Reviewed by ap.
      
              Enables getSVGDocument() support for HTMLObjectElement and HTMLEmbedElement
              This patch does not try to autogenerate anything, but enables the SVG functionality.
              Also fix HTMLObjectElement vspace and hspace to be numbers instead of strings to match IE & Firefox.
      
              * bindings/js/kjs_dom.cpp:
              (KJS::toJS):
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLElement::objectGetter):
              (KJS::HTMLElementFunction::callAsFunction):
              (KJS::JSHTMLElement::objectSetter):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * dom/Document.h:
              (WebCore::Document::isSVGDocument):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::contentDocument):
              (WebCore::HTMLEmbedElement::getSVGDocument):
              * html/HTMLEmbedElement.h:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::HTMLObjectElement):
              (WebCore::HTMLObjectElement::getInstance):
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              (WebCore::HTMLObjectElement::contentDocument):
              (WebCore::HTMLObjectElement::rendererIsNeeded):
              (WebCore::HTMLObjectElement::createRenderer):
              (WebCore::HTMLObjectElement::setCode):
              (WebCore::HTMLObjectElement::setArchive):
              (WebCore::HTMLObjectElement::setBorder):
              (WebCore::HTMLObjectElement::setCodeBase):
              (WebCore::HTMLObjectElement::setCodeType):
              (WebCore::HTMLObjectElement::setData):
              (WebCore::HTMLObjectElement::hspace):
              (WebCore::HTMLObjectElement::setHspace):
              (WebCore::HTMLObjectElement::setStandby):
              (WebCore::HTMLObjectElement::setType):
              (WebCore::HTMLObjectElement::setUseMap):
              (WebCore::HTMLObjectElement::vspace):
              (WebCore::HTMLObjectElement::setVspace):
              (WebCore::HTMLObjectElement::getSVGDocument):
              * html/HTMLObjectElement.h:
              * ksvg2/svg/SVGDocument.h:
              (WebCore::SVGDocument::isSVGDocument):
              * rendering/RenderWidget.h:
              (WebCore::RenderWidget::frameView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3764f870
    • ap's avatar
      Reviewed by Darin. · 7fb04af7
      ap authored
              Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9901
              XSLTProcessor cannot parse text nodes for INPUT ELEMENTS in an XSLT stylesheet
      
              Test: fast/js/xhtml-serialize.html
      
              * editing/markup.cpp:
              (WebCore::endMarkup): If the element has child nodes, write a closing tag even if it 
              is not permitted in HTML, to make it valid XML.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb04af7
    • aliceli1's avatar
      Reviewed by John Sullivan (and Kevin and Timo). · e19095e9
      aliceli1 authored
              landing this patch for John et al.  
              Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard
      
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              moved the call to didFirstLayout to above the check for needsLayout
              because we need to call didFirstLayout for every webview, not just
              ones we think need layout.  
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e19095e9
    • justing's avatar
      LayoutTests: · 6e060000
      justing authored
              Reviewed by darin
              
              <rdar://problem/4652788>
              REGRESSION: Can't change size or style of any text in message body
      
              * editing/style/designmode-expected.checksum: Added.
              * editing/style/designmode-expected.png: Added.
              * editing/style/designmode-expected.txt: Added.
              * editing/style/designmode.html: Added.
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/4652788>
              REGRESSION: Can't change size or style of any text in message body
      
              * dom/Node.cpp:
              (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::isContentRichlyEditable): First check
              the frame for editability, then userModify, like what
              HTMLElement::isContentEditable() does.
              * html/HTMLElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e060000
    • ap's avatar
      Fix by Mitz Pettel, reviewed by ap. · 033de0ab
      ap authored
              - fix debug-only information() string for table cells
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::information):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      033de0ab
  5. 25 Jul, 2006 5 commits
    • ggaren's avatar
      Reviewed by Maciej, inspired by John. · 9c4ee60d
      ggaren authored
              
              - Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to 
              repeated requests for non-existent favicon
              
              An optimization to avoid serializing favicon data for missing icons had stomped an
              optimization to avoid GETing a missing favicon more than once. The solution
              is a happy marriage of optimizations, ensuring that we *retain* the missing
              favicon's "i am missing" data without posting a notification or saving it to disk.
      
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase _setIconURL:forURL:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4ee60d
    • harrison's avatar
      WebCore: · 977d1be2
      harrison authored
              Reviewed by timo and Darin.
      
              <rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
              
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
              Add matchStyle parameter for use by WebKit.
      
      WebKit:
      
              Reviewed by timo and Darin.
      
              <rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
              
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebView.m:
              (-[WebView replaceSelectionWithNode:]):
              (-[WebView _replaceSelectionWithNode:matchStyle:]):
              * WebView/WebViewPrivate.h:
              (-[WebView _replaceSelectionWithNode:matchStyle::]):
              New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      977d1be2
    • justing's avatar
      LayoutTests: · dbf6c7ab
      justing authored
              Reviewed by adele
              
              <rdar://problem/4649560>
              REGRESSION: Can't Select All when the body is contentEditable="true"
      
              * editing/selection/select-all-005-expected.checksum: Added.
              * editing/selection/select-all-005-expected.png: Added.
              * editing/selection/select-all-005-expected.txt: Added.
              * editing/selection/select-all-005.html: Added.
              * editing/selection/select-all-006-expected.checksum: Added.
              * editing/selection/select-all-006-expected.png: Added.
              * editing/selection/select-all-006-expected.txt: Added.
              * editing/selection/select-all-006.html: Added.
      
      WebCore:
      
              Reviewed by adele
              
              <rdar://problem/4649560>
              REGRESSION: Can't Select All when the body is contentEditable="true"
      
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::canonicalPosition): Allow descent from a non-editable html
              element into an editable body as a convenience.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbf6c7ab
    • justing's avatar
      Reviewed by darin · 1c9170ed
      justing authored
              
              <rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">
      
              * dom/Document.cpp:
              (WebCore::Document::inDesignMode): Removed some spaces.
              * page/Frame.cpp:
              (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing.
              (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove
              it eventually.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c9170ed
    • ddkilzer's avatar
      WebCore: · dc0732fd
      ddkilzer authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9717
                Replace IDL ConvertUndefinedToTrue parameter attribute with Optional attribute
      
              No test added because there is no change in functionality.
      
              * bindings/js/kjs_binding.cpp: Removed valueToBooleanTreatUndefinedAsTrue() method.
              * bindings/js/kjs_binding.h: Ditto.
              * bindings/scripts/CodeGeneratorJS.pm: Removed support for ConvertUndefinedToTrue parameter attribute.
              * dom/Element.h: Set default value to true for scrollIntoView() and scrollIntoViewIfNeeded() arguments.
              * dom/Element.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute.
                Fixed name of scrollIntoViewIfNeeded() argument to match implementation.
              * page/DOMWindow.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc0732fd
  6. 24 Jul, 2006 6 commits
    • darin's avatar
      JavaScriptCore: · aacee81f
      darin authored
              Reviewed and tweaked a bit by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9902
                jsNull and NSNull not properly converted between JS and ObjC
      
              * bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
              Added case for converting NSNull to jsNull.
      
      LayoutTests:
      
              Reviewed and tweaked a bit by Darin.
      
              - added some new tests that use "echo" including one for JavaScript null
      
              * plugins/bindings-test-expected.txt: Added results.
              * plugins/bindings-test.html: Added tests.
      
      WebCore:
      
              Reviewed and tweaked a bunch by Darin.
      
              Test: plugins/bindings-test.html
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9902
                jsNull and NSNull not properly converted between JS and ObjC
      
              * bindings/objc/WebScriptObject.mm:
              (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
              Added case that converts jsNull to NSNull.
      
      WebKitTools:
      
              Reviewed and tweaked a bit by Darin.
      
              * DumpRenderTree/ObjCPlugin.m:
              (+[ObjCPlugin isSelectorExcludedFromWebScript:]): Added "echo:".
              (+[ObjCPlugin webScriptNameForSelector:]): Use the name "echo" for
              "echo:" so it's nice to call from JavaScript.
              (-[ObjCPlugin echo:]): Just returns the same object -- can be used
              to test a round trip through Objective-C types.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aacee81f
    • darin's avatar
      LayoutTests: · 38ae534e
      darin authored
              Reviewed by Adele and Justin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9630
                REGRESSION: some spaces typed in <textarea> are posted as non-breaking spaces
      
              * fast/forms/textarea-type-spaces-expected.txt: Added.
              * fast/forms/textarea-type-spaces.html: Added.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9939
                REGRESSION: Pasting text into native text area with newline at end does not preserve newline
      
              * fast/forms/textarea-paste-newline-expected.txt: Added.
              * fast/forms/textarea-paste-newline.html: Added.
      
              - updated tests affected by above changes, results are equivalent or better
      
              * editing/pasteboard/4641033-expected.checksum:
              * editing/pasteboard/4641033-expected.png:
              * editing/pasteboard/4641033-expected.txt:
              * editing/pasteboard/paste-table-003-expected.checksum:
              * editing/pasteboard/paste-table-003-expected.png:
              * editing/pasteboard/paste-table-003-expected.txt:
              * editing/pasteboard/paste-text-016-expected.txt:
              * editing/pasteboard/quirks-mode-br-1-expected.txt:
              * editing/pasteboard/quirks-mode-br-2-expected.txt:
              * fast/forms/textarea-scrolled-type-expected.checksum:
              * fast/forms/textarea-scrolled-type-expected.png:
              * fast/forms/textarea-scrolled-type-expected.txt:
      
              - changed a test to be a "dump as text" test
      
              * fast/forms/paste-into-textarea-expected.txt:
              * fast/forms/paste-into-textarea.html:
              * fast/forms/paste-into-textarea-expected.checksum: Removed.
              * fast/forms/paste-into-textarea-expected.png: Removed.
      
              - changed a test to be a "dump as text" test, improved test a bit and also checked in new results
      
              * fast/forms/textarea-scrolled-endline-caret-expected.txt:
              * fast/forms/textarea-scrolled-endline-caret.html:
      
              - fixed a test that was raising an exception every time it ran
      
              * fast/forms/attributed-strings-expected.txt:
              * fast/forms/attributed-strings.html:
      
              - corrected checksums on a bunch of tests (pngs were right, but checksums wrong, apparently)
      
              * editing/deleting/delete-to-select-table-expected.checksum:
              * editing/selection/3690719-expected.checksum:
              * editing/selection/clear-selection-expected.checksum:
              * editing/undo/undo-misspellings-expected.checksum:
      
              - added some missing pixel test results
      
              * editing/pasteboard/nested-blocks-with-text-area-expected.checksum: Added.
              * editing/pasteboard/nested-blocks-with-text-area-expected.png: Added.
              * editing/pasteboard/nested-blocks-with-text-field-expected.checksum: Added.
              * editing/pasteboard/nested-blocks-with-text-field-expected.png: Added.
      
      WebCore:
      
              Reviewed by Adele and Justin.
      
              - fix <rdar://problem/4613616> REGRESSION: some spaces typed in <textarea> are posted as non-breaking spaces (9630)
                http://bugzilla.opendarwin.org/show_bug.cgi?id=9630
              - also fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9939
                REGRESSION: Pasting text into native text area with newline at end does not preserve newline
              - removed some uses of DeprecatedPtrList in the markup code
      
              Test: fast/forms/textarea-type-spaces.html
              Test: fast/forms/textarea-paste-newline.html
      
              * bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithText:]):
              Updated call to pass a range -- in this case it is the range of the entire document,
              so this will not handle the whitespace properly.
      
              * bridge/mac/WebCoreFrameBridge.h: Added range context parameter to the
              documentFragmentWithText: method, so we can handle whitespace properly.
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge nodesFromList:]): Changed from DeprecatedPtrList to Vector.
              (-[WebCoreFrameBridge markupStringFromNode:nodes:]): Ditto.
              (-[WebCoreFrameBridge markupStringFromRange:nodes:]): Ditto.
              (-[WebCoreFrameBridge documentFragmentWithText:inContext:]): Added range context
              parameter -- pass it on to createFragmentFromText.
              (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): Changed from
              DeprecatedPtrList to Vector.
              (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]):
              Pass the range of the current selection as context when creating the fragment.
      
              * dom/Position.cpp: (WebCore::Position::inRenderedText): Replace range check with
              a call to the new containsCaretOffset function -- helps make the caret work right when
              it is past the end of the last line in a textarea.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Don't do anything if the
              style does not call for collapsing whitespace.
              (WebCore::CompositeEditCommand::rebalanceWhitespace): Call replaceWhitespaceAt
              to share code, including the new logic mentioned above.
      
              * editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
              Use a text node instead of a break element when inserting and the style is preserveNewline.
      
              * editing/JSEditor.cpp: (WebCore::execRemoveFormat): Pass the selection range
              to createFragmentFromText.
      
              * editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doApply):
              Assert that we're in a style that collapses whitespace. It's the caller's responsibility
              not to call otherwise.
      
              * editing/ReplaceSelectionCommand.h: Removed unused destructor, type, isSingleTextNode,
              isTreeFragment, m_type, and added a context parameter to inertFragmentForTestRendering.
              Also changed the constructor to take a selection rather than a pointer to the root
              editable element, replaced removeEndBRIfNeeded with shouldRemoveEndBR and removed an
              unused parameter from shouldMergeEnd.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment): Removed code to set up m_type.
              Compute root editable element from passed-in selection. Used the start of the selection
              as a base node for style purposes for the test rendering. Removed the special case
              "single text node" alternative to createFragmentFromText in the plain text case, since
              createFragmentFromText now handles that correctly.
              (WebCore::ReplacementFragment::insertFragmentForTestRendering): Copy the whitespace
              property from the source location when creating a temporary element for test rendering.
              (WebCore::ReplacementFragment::shouldMergeEnd): Removed unneeded boolean
              parameter fragmentHadInterchangeNewlineAtEnd, which is always false.
              (WebCore::ReplaceSelectionCommand::doApply): Update for ReplacementFragment changes,
              change code to not remove end BR when it can be re-used instead, don't call the
              paragraph separator insertion when the position is at the start of a paragraph already,
              removed redundant computation of identical "next" value, removed unneeded boolean
              parameter to shouldMergeEnd, add case for merging when all we need to do is to delete
              a newline character, removed unneeded code to set insertionPos after all code that uses
              it, and  use spaces instead of non-breaking spaces when doing smart paste if the
              context is one where we do not collapse white space.
              (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renamed and changed to return
              a boolean instead of doing the removal.
      
              * editing/markup.h: Use Vector instead of DeprecatedPtrList. Change the
              createFragmentFromText function to take a range for context instead of a document.
              * editing/markup.cpp:
              (WebCore::markup): Use Vector instead of DeprecatedPtrList.
              (WebCore::createMarkup): Ditto.
              (WebCore::createParagraphContentsFromString): Remove unneeded document parameter
              and changed a couple places to use isEmpty instead of comparing with "".
              (WebCore::createFragmentFromText): Given the new context parameter, if the context
              is one that preserves newlines, then use "\n" instead of <br> elements.
              (WebCore::createFragmentFromNodes): Use Vector instead of DeprecatedPtrList.
      
              * html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerText): Do not use <br>
              elements if the context of this node is one where we preserve newlines.
      
              * rendering/InlineTextBox.h:
              * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::containsCaretOffset):
              Added. Implements the appropriate rule for determining if a caret position is
              in this line or not. Returns true for both one line and the next in cases where
              affinity must be considered to determine which line the caret is on.
      
              * rendering/RenderText.h: Make atLineWrap no longer be a member function.
              * rendering/RenderText.cpp:
              (WebCore::atLineWrap): Remove special rule about preserveNewline and isLineBreak,
              which will no longer apply due to the new containsCaretOffset function logic.
              (WebCore::RenderText::caretRect): Use containsCaretOffset.
              (WebCore::RenderText::inlineBox): Ditto.
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::updateFromElement): Make a placeholder <br> element
              after calling setInnerText so that the last newline in the string has the effect
              we expect outside the HTML world (an additional line).
              (WebCore::RenderTextControl::setSelectionRange): Set granularity of the selection
              too. The layout tests caught this problem, which needs a better solution long term.
              (WebCore::RenderTextControl::text): Call textContent with the parameter false
              so it will not include newlines for <br> elements. Now the only <br> element
              that will ever be in the shadow DOM tree is the one to prevent collapsing, and
              that one should not show up in the text value.
      
              * rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Took a rule
              that specifically called out the pre whitespace mode and made it work for all
              the modes that preserve newlines. This makes sure we get a last line box for
              text after the last "\n" even in cases where there is no <br> afterward.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              Added assertions to make sure we don't do anything when we're not collapsing
              whitespace.
      
              * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setDefaultValue):
              Changed to use Vector instead of DeprecatedPtrList.
      
              * editing/HTMLInterchange.cpp: Removed obsolete comment.
      
              * loader/Cache.h: Removed a stray include.
      
      WebKit:
      
              Reviewed by Adele and Justin.
      
              - update for change to require context when creating fragments from text
                (needed to handle whitespace properly)
      
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
              Added context parameter, pass through to bridge.
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Pass selection range as context
              when calling above method.
              (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Pass drag caret as context when
              calling above method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38ae534e
    • adele's avatar
      LayoutTests: · 4c0884bb
      adele authored
              Reviewed by Justin.
      
              - Test for <rdar://problem/4632132> Changing style of content with mixed editability fails
      
              * editing/style/apple-style-editable-mix-expected.checksum: Added.
              * editing/style/apple-style-editable-mix-expected.png: Added.
              * editing/style/apple-style-editable-mix-expected.txt: Added.
              * editing/style/apple-style-editable-mix.html: Added.
      
      WebCore:
      
              Reviewed by Justin.
      
              - Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails
      
              Test: * editing/style/apple-style-editable-mix.html
      
              * dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root.  It now just
                checks the user modify property of its own renderer, since that is inherited.
              * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table,
              Adjust the end node to the last descendant of the table, so we don't skip over any runs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c0884bb
    • mjs's avatar
      Reviewed by Geoff. · d878a136
      mjs authored
              
              - fix <rdar://problem/4609195> Help Viewer loads empty window (not getting didFailLoadingWithError: callback)
              (without re-introducing http://bugzilla.opendarwin.org/show_bug.cgi?id=10062 )
      
              * WebView/WebLoader.h:
              * WebView/WebMainResourceLoader.m:
              (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper
              order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d878a136
    • darin's avatar
      Reviewed by Hyatt. · c06c4470
      darin authored
              - implement String::createCFString
      
              * WebCore.xcodeproj/project.pbxproj: Added StringImplMac.mm and StringMac.mm.
      
              * bindings/objc/DOMInternal.mm: Moved NSString conversion functions out of here.
      
              * platform/mac/StringImplMac.mm: Added. Moved NSString conversion members here
              and added the CFStringRef ones.
              * platform/mac/StringMac.mm: Added. Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c06c4470
    • hyatt's avatar
      Two bug fixes. · bddcc616
      hyatt authored
              (1) Make sure to mark positioned objects that depend on line position to
              mark themselves as needing layout when their line box placeholder gets
              repositioned.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::position):
             
              (2) Improve highlighting to factor the inflation into overflow so that
              invalidation and repainting will work properly.
      
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::addHighlightOverflow):
              * rendering/RootInlineBox.h:
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::layoutInlineChildren):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bddcc616