Skip to content

GitLab

W
webkit
Switch branch/tag
  1. 06 Jan, 2009 17 commits
  3. 05 Jan, 2009 23 commits
    • ddkilzer@apple.com's avatar
      WebKit/mac: · c75c1a00
      ddkilzer@apple.com authored 
      2009-01-05  David Kilzer  <ddkilzer@apple.com>

        Add SPI to enable, disable and check state of WebIconDatabase

        Reviewed by Darin Adler & Timothy Hatcher.

        Add -[WebIconDatabase isEnabled] and -[WebIconDatabase setEnabled:]
        SPI to make it possible to enable, disable and check the state of
        the icon database.

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]): Extracted code into -_startUpIconDatabase.
        (-[WebIconDatabase iconForURL:withSize:cache:]): Switched to use
        -isEnabled instead of -_isEnabled.
        (-[WebIconDatabase iconURLForURL:]): Ditto.
        (-[WebIconDatabase retainIconForURL:]): Ditto.
        (-[WebIconDatabase releaseIconForURL:]): Ditto.
        (-[WebIconDatabase isEnabled]): Renamed from -_isEnabled in
        WebInternal category.
        (-[WebIconDatabase setEnabled:]): Added.  Takes care of changing
        the enabled/disabled state of the icon database.
        (-[WebIconDatabase removeAllIcons]): Switched to use -isEnabled
        instead of -_isEnabled.
        (-[WebIconDatabase _startUpIconDatabase]): Added.  Extrated from
        -init.
        (-[WebIconDatabase _shutDownIconDatabase]): Added.  Remove
        observers when the icon database is disabled.
        * Misc/WebIconDatabaseInternal.h: Added declarations for
        -_startUpIconDatabase and -_shutDownIconDatabase.
        * Misc/WebIconDatabasePrivate.h: Added declarations for
        -isEnabled and -setEnabled:.

WebKit/win:

2009-01-05  David Kilzer  <ddkilzer@apple.com>

        Add API to enable, disable and check state of WebIconDatabase

        Reviewed by Darin Adler & Timothy Hatcher.

        Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
        API to make it possible to enable, disable and check the state of
        the icon database.

        * Interfaces/IWebIconDatabase.idl: Declared isEnabled() and
        setEnabled() methods.
        * WebIconDatabase.cpp:
        (WebIconDatabase::init): Extracted code into startUpIconDatabase().
        (WebIconDatabase::startUpIconDatabase): Added.  Extracted from
        init().
        (WebIconDatabase::shutDownIconDatabase): Added.  Method is empty
        since there is nothing to do yet on Windows.
        (isEnabled): Added.
        (setEnabled): Added.
        * WebIconDatabase.h: Added method declarations.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c75c1a00
    • simon.fraser@apple.com's avatar
      2009-01-05 Simon Fraser <simon.fraser@apple.com> · 6b8fefe6
      simon.fraser@apple.com authored 
              Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=22985

        Add an assertion that clip rects are being used when painting with the same
        rootLayer that they were computed with.

        Fix two issues detected by the assertion:

        RenderLayer::updateClipRects() should not unconditionally update the clip rects
        on its parent, but stop when reaching rootLayer (just like calculateClipRects()).

        We need to pass the temporaryClipRects flag down through reflection painting
        to handle the case of nested reflections.

        Also use temporary clip rects in RenderTreeAsText, since that code does not
        reset the painting root for transformed layers, so cached clip rects will not
        match those used for painting.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::updateClipRects):
        (WebCore::RenderLayer::clearClipRects):
        * rendering/RenderLayer.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::writeLayers):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b8fefe6
    • treat@webkit.org's avatar
      Fix the Qt build · 20965f5f
      treat@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20965f5f
    • mrowe@apple.com's avatar
      Fix the build some more. · 56aefe06
      mrowe@apple.com authored 
      * platform/graphics/cairo/AffineTransformCairo.cpp:
(WebCore::TransformationMatrix::TransformationMatrix):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56aefe06
    • oliver@apple.com's avatar
      Fix gtk build · b6b56093
      oliver@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b56093
    • beidson@apple.com's avatar
      2009-01-05 Brady Eidson <beidson@apple.com> · 24bae5dd
      beidson@apple.com authored 
              Reviewed by Jon Honeycutt

        Expose setting the last-visit-was-failure flag on a history items in preparation for <rdar://problem/6173319>

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _setLastVisitWasFailure:]):
        * History/WebHistoryItemPrivate.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24bae5dd
    • dino@apple.com's avatar
      2009-01-05 Dean Jackson <dino@apple.com> · 0cf2dc9d
      dino@apple.com authored 
              Reviewed by Darin Adler.

        Rename AffineTransform to TransformationMatrix in
        preparation for future enhancements (non-affine matrices)

        https://bugs.webkit.org/show_bug.cgi?id=22943

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.scons:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * platform/graphics/transforms/AffineTransform.cpp: Removed.
        * platform/graphics/transforms/AffineTransform.h: Removed.
        * platform/graphics/transforms/TransformationMatrix.cpp: Copied from WebCore/platform/graphics/transforms/AffineTransform.cpp.
        * platform/graphics/transforms/TransformationMatrix.h: Copied from WebCore/platform/graphics/transforms/AffineTransform.h.
        * lots of other files with s/AffineTransform/TransformationMatrix/g



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cf2dc9d
    • dino@apple.com's avatar
      2008-01-05 Dean Jackson <dino@apple.com> · 563bd1f6
      dino@apple.com authored 
              Reviewed by David Hyatt.

        Implement 'pointer-events' for HTML content. This involved
        adding a new value 'auto' which behaves as 'visiblePainted'
        in SVG content.

        Moved the property out of the SVG CSS code and into
        the general CSS (both parsing and RenderStyle).

        Changes to the hit testing functionality of the Render tree,
        specifically the nodeAtPoint methods. Where they used to
        test for visibility, they now use a helper function defined
        on base classes (RenderObject and InlineBox) that checks both
        visibility and pointer-events.

        https://bugs.webkit.org/show_bug.cgi?id=11395

        Tests: fast/events/pointer-events-2.html
               fast/events/pointer-events.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EPointerEvents):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/SVGCSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
        * css/SVGCSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applySVGProperty):
        * manual-tests/pointer-events.html: Added.
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::nodeAtPoint):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::visibleToHitTesting):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::nodeAtPoint):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::nodeAtPoint):
        * rendering/PointerEventsHitRules.cpp:
        (WebCore::PointerEventsHitRules::PointerEventsHitRules):
        * rendering/PointerEventsHitRules.h:
        (WebCore::PointerEventsHitRules::):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::nodeAtPoint):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::visibleToHitTesting):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::nodeAtPoint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::nodeAtPoint):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::nodeAtPoint):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::nodeAtPoint):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
        * rendering/style/RenderStyle.h:
        (WebCore::):
        (WebCore::InheritedFlags::setBitDefaults):
        (WebCore::InheritedFlags::pointerEvents):
        (WebCore::InheritedFlags::setPointerEvents):
        (WebCore::InheritedFlags::initialPointerEvents):
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):
        * rendering/style/SVGRenderStyle.h:
        (WebCore::SVGRenderStyle::InheritedFlags::operator==):
        (WebCore::SVGRenderStyle::setBitDefaults):
        * rendering/style/SVGRenderStyleDefs.h:
        * css/CSSValueKeywords.in:
        * css/SVGCSSValueKeywords.in:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      563bd1f6
    • alice.liu@apple.com's avatar
      Build fix from 39625 · 88c83c2e
      alice.liu@apple.com authored 
      

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88c83c2e
    • oliver@apple.com's avatar
      Fix Wx build. · 9b6f3e7a
      oliver@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b6f3e7a
    • alice.liu@apple.com's avatar
      2009-01-05 Oliver Hunt <oliver@apple.com> · 83ee2855
      alice.liu@apple.com authored 
              Windows build fixes

        Rubber-stamped by Alice Liu.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::Interpreter):
        * runtime/ByteArray.cpp:
        (JSC::ByteArray::create):
        * runtime/ByteArray.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83ee2855
    • andersca@apple.com's avatar
      2009-01-05 Anders Carlsson <andersca@apple.com> · 2db86ea4
      andersca@apple.com authored 
              Reviewed by Jon Honeycutt.

        Pass more information in the property bag passed to embeddedViewWithArguments.
        
        * Interfaces/IWebUIDelegatePrivate.idl:
        Declare new keys.
        
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::createPlugin):
        Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2db86ea4
    • andersca@apple.com's avatar
      2009-01-05 Anders Carlsson <andersca@apple.com> · 8ff5e5af
      andersca@apple.com authored 
              Reviewed by Darin Adler, Jon Honeycutt.

        Add a templatized COMVariant constructor so we can make COMVariants out of
        everything that has a COMVariantSetter specialization.
        
        Add a COMVariantSetter specialization for COMVariant.
        
        * COMVariantSetter.h:
        (COMVariant::COMVariant):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ff5e5af
    • pewtermoose@webkit.org's avatar
      2009-01-05 Brent Fulgham <bfulgham@gmail.com> · 6ec334c4
      pewtermoose@webkit.org authored 
              Reviewed by Oliver Hunt.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=23027

        Removes the WebKitGraphics files from the Cairo build, as well
        as excluding their link definitions.  These are not used outside
        of Safari, and should not be part of the 'Redistributable API.'

        * WebKit.vcproj/WebKit.vcproj:  Update *_Cairo targets to exclude
          the WebKitGraphics.cpp/.h files.
        * WebKit.vcproj/WebKit_Cairo.def: Added.  File without Safari
          link definitions.
        * WebKit.vcproj/WebKit_Cairo_debug.def: Added.  File without Safari
          link definitions.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ec334c4
    • andersca@apple.com's avatar
      2009-01-05 Anders Carlsson <andersca@apple.com> · bbbb49f2
      andersca@apple.com authored 
              Reviewed by Jon Honeycutt.

        Add a simple, memory managed, wrapper around a VARIANT struuct.
        
        * COMVariantSetter.h:
        (COMVariant::COMVariant):
        (COMVariant::~COMVariant):
        (COMVariant::operator=):
        (COMVariant::copyTo):
        (COMVariant::variantType):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbbb49f2
    • oliver@apple.com's avatar
      Fix Cairo/Gtk build · 88e2c447
      oliver@apple.com authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88e2c447
    • oliver@apple.com's avatar
      CanvasPixelArray performance is too slow · 46ff6a1e
      oliver@apple.com authored 
      <https://bugs.webkit.org/show_bug.cgi?id=23123>

Reviewed by Gavin Barraclough

JavaScriptCore:
The fix to this is to devirtualise get and put in a manner similar to
JSString and JSArray.  To do this I've added a ByteArray implementation
and JSByteArray wrapper to JSC.  We can then do vptr comparisons to
devirtualise the calls.

This devirtualisation improves performance by 1.5-2x in my somewhat ad
hoc tests.

WebCore:
Remove the WebCore CanvasPixelArray implementation and replace
CPA usage with JSC::ByteArray.  Replace the JSCanvasPixelArray
wrapper with an explicitly instantiated JSByteArray put on the
JSImageData object as an ordinary ReadOnly, DontDelete property.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ff6a1e
    • adele@apple.com's avatar
      2009-01-05 Adele Peterson <adele@apple.com> · e1811f45
      adele@apple.com authored 
              Windows build fix.

        * WebCoreSupport/WebChromeClient.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1811f45
    • andersca@apple.com's avatar
      2009-01-05 Anders Carlsson <andersca@apple.com> · e73aa0a4
      andersca@apple.com authored 
              Reviewed by Adam Roben.

        Make it possible to have per value variant types.
        
        * COMPropertyBag.h:
        (::Read):
        Call variantType here, passing in the value.
        
        (::GetPropertyInfo):
        Ditto.
        
        * COMVariantSetter.h:
        (COMVariantSetterBase::variantType):
        Add COMVariantSetterBase, whose variantType implementation just returns the
        VariantType variable. Make all existing classes inherit from COMVariantSetterBase.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e73aa0a4
    • treat@webkit.org's avatar
      Another blind mac build fix · fddd7237
      treat@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fddd7237
    • treat@webkit.org's avatar
      Blind mac build fix · 5b199a98
      treat@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b199a98
    • treat@webkit.org's avatar
      Fix mac build · 27ccd1ee
      treat@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27ccd1ee
    • treat@webkit.org's avatar
      Fix win build · 25f803fa
      treat@webkit.org authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25f803fa