1. 08 May, 2012 40 commits
    • inferno@chromium.org's avatar
      Crash due to owning renderer not removed from custom scrollbar. · ab769069
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80610
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Test: scrollbars/scrollbar-owning-renderer-crash.html
      
      Changed RenderScrollbar to keep pointer to owning node, instead of the
      renderer. Renderer can get destroyed without informing the scrollbar, causing
      crashes later. Remove code from r94107 since it is not needed anymore and saves
      times when RenderBox is getting destroyed.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::createScrollbar): pass renderer's node.
      * page/FrameView.h:
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::willBeDestroyed): no longer need this. came originally from r94107.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::createScrollbar): pass renderer's node.
      (WebCore::RenderLayer::destroyScrollbar): no longer need to clear owning renderer.
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::createScrollbar): pass renderer's node.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::createScrollbar): pass renderer's node.
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::createCustomScrollbar): Store owner node instead of renderer.
      (WebCore::RenderScrollbar::RenderScrollbar): Store owner node instead of renderer.
      (WebCore::RenderScrollbar::owningRenderer): calculate owning renderer from owner node.
      * rendering/RenderScrollbar.h:
      (RenderScrollbar):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::createScrollbar): pass renderer's node.
      
      LayoutTests:
      
      * scrollbars/scrollbar-owning-renderer-crash-expected.txt: Added.
      * scrollbars/scrollbar-owning-renderer-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab769069
    • commit-queue@webkit.org's avatar
      [EFL][DRT] Implement TextInputController. · b53499d5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=78559
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-08
      Reviewed by Martin Robinson.
      
      TextInputController has been created for an input emulation purpose in DRT.
      However, not like other ports, EFL doesn't have it.
      Therefore, this patch will enable EFL port to have an input emulation in DRT.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::setComposition):
      (DumpRenderTreeSupportEfl::hasComposition):
      (DumpRenderTreeSupportEfl::compositionRange):
      (DumpRenderTreeSupportEfl::confirmComposition):
      (DumpRenderTreeSupportEfl::firstRectForCharacterRange):
      (DumpRenderTreeSupportEfl::selectedRange):
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Tools:
      
      * DumpRenderTree/efl/CMakeLists.txt:
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::onWindowObjectCleared):
      * DumpRenderTree/efl/TextInputController.cpp: Added.
      (setMarkedTextCallback):
      (hasMarkedTextCallback):
      (markedRangeCallback):
      (insertTextCallback):
      (unmarkTextCallback):
      (firstRectForCharacterRangeCallback):
      (selectedRangeCallback):
      (makeTextInputController):
      * DumpRenderTree/efl/TextInputController.h: Added.
      
      LayoutTests:
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b53499d5
    • tony@chromium.org's avatar
      [chromium] force ENABLE_REGISTER_PROTOCOL_HANDLER=1 in features.gypi · 5d5dc49a
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85924
      
      Reviewed by Adam Barth.
      
      This has been enabled for a few months on Chromium trunk so remove the
      ability to turn it off via a gyp flag. This simplifies features.gypi.
      
      * features.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d5dc49a
    • jonlee@apple.com's avatar
      Safari warns that it needs to resend the form in an iFrame when going back · 4fa1eb7c
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82658
      <rdar://problem/11292558>
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Test: http/tests/loading/post-in-iframe-with-back-navigation.html
      
      * WebCore.exp.in: Add _wkCFURLRequestAllowAllPostCaching.
      * platform/mac/WebCoreSystemInterface.h: Add wkCFURLRequestAllowAllPostCaching.
      * platform/mac/WebCoreSystemInterface.mm: Add wkCFURLRequestAllowAllPostCaching.
      * platform/network/cf/ResourceRequestCFNet.cpp:
      (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.
      * platform/network/mac/ResourceRequestMac.mm:
      (WebCore::ResourceRequest::doUpdatePlatformRequest): Set the bit to cache all POST responses.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Add wkCFURLRequestAllowAllPostCaching.
      
      WebKitLibraries:
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceLion.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      LayoutTests:
      
      Add new test which navigates a series of pages in an iframe. Each navigation is a POST.
      At the third page we click on a back link, and expect to see stale POST data.
      
      * http/tests/loading/post-in-iframe-with-back-navigation-expected.txt: Added.
      * http/tests/loading/post-in-iframe-with-back-navigation.html: Added.
      * http/tests/loading/resources/post-in-iframe-with-back-navigation-page-1.php: Added.
      * http/tests/loading/resources/post-in-iframe-with-back-navigation-page-2.php: Added.
      * http/tests/loading/resources/post-in-iframe-with-back-navigation-page-3.php: Added.
      * http/tests/resources/js-test-post.js: Added. Copied from fast/js/resources since it is
      inaccessible to the test server.
      * http/tests/resources/js-test-pre.js: Added. Copied from fast/js/resources since it is
      inaccessible to the test server.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fa1eb7c
    • danakj@chromium.org's avatar
      [chromium] Reflections with masks should not occlude · 0af15753
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85927
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      When a surface does not have a mask, we make both it and its reflection
      occlude the things below them. However, if the reflection has a mask
      applied to it, then we should not consider it as occluding.
      
      Adds replicaHasMask() to the render surface classes so we can test if
      the mask is present.
      
      Unit Tests: CCOcclusionTrackerTestReplicaWithMask
      
      * platform/graphics/chromium/RenderSurfaceChromium.cpp:
      (WebCore::RenderSurfaceChromium::hasMask):
      This is unusued right now, but will allow us to remove a FIXME from
      CCOcclusionTracker::finishedTargetRenderSurface().
      (WebCore):
      (WebCore::RenderSurfaceChromium::replicaHasMask):
      * platform/graphics/chromium/RenderSurfaceChromium.h:
      (RenderSurfaceChromium):
      * platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
      (WebCore::::leaveToTargetRenderSurface):
      * platform/graphics/chromium/cc/CCRenderSurface.cpp:
      (WebCore::CCRenderSurface::hasMask):
      This is unusued right now, but will allow us to remove a FIXME from
      CCOcclusionTracker::finishedTargetRenderSurface().
      (WebCore):
      (WebCore::CCRenderSurface::replicaHasMask):
      * platform/graphics/chromium/cc/CCRenderSurface.h:
      (CCRenderSurface):
      
      Source/WebKit/chromium:
      
      * tests/CCOcclusionTrackerTest.cpp:
      (WebKitTests::CCOcclusionTrackerTest::TearDown):
      (WebKitTests::CCOcclusionTrackerTest::createMaskLayer):
      (CCOcclusionTrackerTest):
      (WebKitTests::CCOcclusionTrackerTest::setMask):
      (CCOcclusionTrackerTestReplicaWithMask):
      (WebKitTests::CCOcclusionTrackerTestReplicaWithMask::runMyTest):
      (WebKitTests):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0af15753
    • eric@webkit.org's avatar
      Add stylesheet inheritance support to IFRAME_SEAMLESS · 876b40e1
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85914
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      This work is already guarded by IFRAME_SEAMLESS, as
      Document::shouldDisplaySeamlesslyWithParent always returns false
      when IFRAME_SEAMLESS is off.
      
      This makes the child document use all author stylesheets from all parent documents,
      per the seamless spec:
      http://www.whatwg.org/specs/web-apps/current-work/#attr-iframe-seamless
      
      This support is slightly inefficient as every time a sheet is added
      to a parent document, the child document must do a full style selector recalc.
      Normally author sheet additions have a fast-path which avoids the full selector recalc,
      but such is not possible in the seamless case as we're inserting the parents sheets
      earlier in the child's cascade (instead of just appending them to the end of the list).
      
      The test covers both the static inheritance as well as addition of a stylesheet
      to the parent and testing that it caused a recalc of the child.
      
      Covered by fast/frames/seamless/seamless-css-cascade.html
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
      (WebCore):
      * css/StyleResolver.h:
      (StyleResolver):
      * dom/Document.cpp:
      (WebCore::Document::seamlessParentUpdatedStylesheets):
      (WebCore):
      (WebCore::Document::notifySeamlessChildDocumentsOfStylesheetUpdate):
      (WebCore::Document::updateActiveStylesheets):
      * dom/Document.h:
      (Document):
      
      LayoutTests:
      
      Update the results (for both static and dynamic inheritance)
      now that this support is landed.
      
      * fast/frames/seamless/seamless-css-cascade-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      876b40e1
    • rakuco@webkit.org's avatar
      [EFL] Pass a WTF::String directly from DRT to ewebkit when possible · 790f0864
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84634
      
      Reviewed by Gustavo Noronha Silva.
      
      Drop unnecessary const char* -> WTF::String conversions by
      creating String objects directly in LayoutTestController out of
      JSStringRef's and passing them to DumpRenderTreeSupportEfl.
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::setValueForUser):
      (DumpRenderTreeSupportEfl::addUserStyleSheet):
      (DumpRenderTreeSupportEfl::findString):
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Tools:
      
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      (LayoutTestController::queueLoad):
      (LayoutTestController::setValueForUser):
      (LayoutTestController::findString):
      (LayoutTestController::addUserStyleSheet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      790f0864
    • andersca@apple.com's avatar
      Can't scroll PDF in subframe · f767c0eb
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85932
      <rdar://problem/11405527>
      
      Reviewed by Sam Weinig.
      
      * WebProcess/Plugins/PDF/BuiltInPDFView.h:
      * WebProcess/Plugins/PDF/BuiltInPDFView.mm:
      (WebKit::BuiltInPDFView::updateScrollbars):
      Trigger a layout when scrollbars come and go so the non fast scrollable region gets recomputed.
      
      (WebKit::BuiltInPDFView::scrollableAreaBoundingBox):
      Implement this by calling out to the PluginView.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f767c0eb
    • rakuco@webkit.org's avatar
      [CMake] FindGStreamer: Fix the build with static WebCore. · 4c24e99c
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85930
      
      Reviewed by Daniel Bates.
      
      .:
      
      Building WebCore statically was failing because files in
      WebCore/platform/gstreamer when ENABLE_VIDEO was set required
      gstreamer-base, which was not being linked to after r116453.
      
      Fix that by looking for gstreamer-base, requiring and linking
      against it if GStreamer is used.
      
      * Source/cmake/FindGStreamer.cmake:
      
      Source/WebCore:
      
      No new tests, build fix.
      
      Building WebCore statically was failing because files in
      WebCore/platform/gstreamer when ENABLE_VIDEO was set required
      gstreamer-base, which was not being linked to after r116453.
      
      Fix that by looking for gstreamer-base, requiring and linking
      against it if GStreamer is used.
      
      * PlatformEfl.cmake: Link to GSTREAMER_LIBRARIES and
      GSTREAMER_BASE_LIBRARIES, and include GSTREAMER_INCLUDE_DIRS and
      GSTREAMER_BASE_INCLUDE_DIRS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c24e99c
    • jonlee@apple.com's avatar
      [WK2] Push wheel events if there are too many in queue · 40ea3eff
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85747
      <rdar://problem/11390790>
      
      Reviewed by Anders Carlsson.
      
      It is possible that a whole bunch of messages added to the message queue, or a series
      of long-running messages, cause unresponsiveness. The reason for this is that we have
      a scroll event waiting for acknowledgment from the web process before it sends the next
      event. And in the time between the user has scrolled, causing a large backlog of scroll
      events to be held in the UI process.
      
      We should push new scroll events if the queue accumulates too many of them.
      
      * UIProcess/WebPageProxy.h: The vector m_currentlyProcessedWheelEvents used to hold the
      series of wheel events that were coalesced and sent as a single wheel event to the web
      process. When the web process acknowledges this with didReceiveEvent, the UI process
      cleared that vector, then tried to coalesce the next wheel event to send. Now we might have
      multiple sets of coalesced wheel events that we are sending to the web process. To keep
      track of these sets, m_currentlyProcessedWheelEvents now is a queue of Vectors.
      (WebPageProxy):
      * UIProcess/WebPageProxy.cpp: Add new constant wheelEventQueueSizeThreshold representing
      the threshold of scroll events to look for before we start pushing events.
      (WebKit::canCoalesce): Move static function so that handleWheelEvent() has access. No changes.
      (WebKit::coalesce): Move static function so that handleWheelEvent() has access. No changes.
      (WebKit::coalescedWheelEvent): Move static function so that handleWheelEvent() has access. No changes.
      (WebKit::WebPageProxy::handleWheelEvent): If we are currently waiting for acknowledgment
      from the web process that a wheel event has been handled, we add it to the queue. We
      check to see that the queue size is within our threshold before we return early. Otherwise
      we will start pushing events in the queue. Refactor the rest of the function into
      processNextQueuedWheelEvent() and sendWheelEvent(). If we are not currently waiting for
      acknowledgment, nor have events in the queue, then we send the current wheel event.
      (WebKit::WebPageProxy::processNextQueuedWheelEvent): Try to coalesce events based on the
      wheel event at the head of the queue, and send that event to the web process.
      (WebKit::WebPageProxy::sendWheelEvent): Refactored from handleWheelEvent().
      (WebKit::WebPageProxy::didReceiveEvent): Instead of clearing m_currentlyProcessedWheelEvents,
      which contained the set of one coalesced wheel event, we pull the head Vector, which
      contains the same set of events. Refactor to use processNextQueuedWheelEvent().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40ea3eff
    • commit-queue@webkit.org's avatar
      JavaScriptAudioNode should not ASSERT if number of input channels is 0 · 30b9eab5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85818
      
      Patch by Raymond Toy <rtoy@google.com> on 2012-05-08
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Test: webaudio/javascriptaudionode-zero-input-channels.html
      
      * Modules/webaudio/JavaScriptAudioNode.cpp:
      (WebCore::JavaScriptAudioNode::process): Update buffersAreGood.
      (WebCore::JavaScriptAudioNode::fireProcessEvent): Remove ASSERT.
      
      LayoutTests:
      
      * webaudio/javascriptaudionode-zero-input-channels-expected.txt: Added.
      * webaudio/javascriptaudionode-zero-input-channels.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30b9eab5
    • commit-queue@webkit.org's avatar
      [EFL][DRT] EventSender needs implementation of leapForward function · 8591a1eb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83486
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08
      Reviewed by Eric Seidel.
      
      Tools:
      
      Implemented leapForward function in Efl's DRT. This function is required
      to delay and queue event execution and simulate real user behavior.
      
      * DumpRenderTree/efl/EventSender.cpp:
      (DelayedEvent):
      (MouseEventInfo::MouseEventInfo):
      (MouseEventInfo):
      (sendClick):
      (mouseDownCallback):
      (mouseUpCallback):
      (mouseMoveToCallback):
      (leapForwardCallback):
      (mouseScrollByCallback):
      (feedOrQueueMouseEvent):
      (feedMouseEvent):
      (feedQueuedMouseEvents):
      
      LayoutTests:
      
      Unskipping few tests that were failing due to the missing leapForward function
      Added EFL specific test result, since EFL doesnt support 2D wheel events
      
      * platform/efl/Skipped:
      * platform/efl/fast/events/platform-wheelevent-in-scrolling-div-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8591a1eb
    • danakj@chromium.org's avatar
      Region reads past end of spans · fb0dae82
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85909
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Region currently checks aSpan == aSpanEnd as the indicator that
      we passed all the spans. When aSpan < aSpanEnd, it uses aSpan+1
      to find the height of the span.
      
      If aSpan == aSpanEnd - 1, then aSpan+1 == aSpanEnd. This does not
      represent a valid span, since aSpanEnd is past the end of the
      array, not the last element in the array. The loop should terminate
      in this case.
      
      Checking aSegment != aSegmentEnd is acceptable in the inner loop since
      it increments by two each time (segments come in pairs, while spans
      come in singles).
      
      Test: RegionTest.ReadPastFullSpanVectorInIntersectsTest
      
      * platform/graphics/Region.cpp:
      (WebCore::Region::Shape::compareShapes):
      
      Source/WebKit/chromium:
      
      * tests/RegionTest.cpp:
      (WebCore::TEST):
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb0dae82
    • commit-queue@webkit.org's avatar
      Source/WebKit: [BlackBerry] Implement a popup client for HTML controls · 6aaf243c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85670
      
      Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08
      Reviewed by Rob Buis.
      
      Add popup client file to build system.
      
      * PlatformBlackBerry.cmake:
      
      Source/WebKit/blackberry:     [BlackBerry] Implement a popup client for HTML controls
          https://bugs.webkit.org/show_bug.cgi?id=85670
      
          Reviewed by Rob Buis.
      
          Implement a popup client for HTML controls, which would be used to load
          different popups according to popup type.
      
          * WebCoreSupport/PagePopupBlackBerry.cpp: Added.
          (WebCore):
          (PagePopupChromeClient):
          (WebCore::PagePopupChromeClient::PagePopupChromeClient):
          (WebCore::PagePopupChromeClient::closeWindowSoon):
          (WebCore::PagePopupChromeClient::webPage):
          (WebCore::PagePopupBlackBerry::PagePopupBlackBerry):
          (WebCore::PagePopupBlackBerry::~PagePopupBlackBerry):
          (WebCore::PagePopupBlackBerry::sendCreatePopupWebViewRequest):
          (WebCore::PagePopupBlackBerry::init):
          (WebCore::setValueAndClosePopupCallback):
          (WebCore::popUpExtensionInitialize):
          (WebCore::popUpExtensionFinalize):
          (WebCore::PagePopupBlackBerry::installDomFunction):
          (WebCore::PagePopupBlackBerry::handleMouseEvent):
          (WebCore::PagePopupBlackBerry::closePopup):
          (WebCore::PagePopupBlackBerry::closeWebPage):
          * WebCoreSupport/PagePopupBlackBerry.h: Added.
          (WebKit):
          (WebCore):
          (PagePopupBlackBerry):
      
      Patch by Crystal Zhang <haizhang@rim.com> on 2012-05-08
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aaf243c
    • ryuan.choi@samsung.com's avatar
      [EFL][DRT] WebKit/DRT should not paint webview for the pixel tests. · abd3b694
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=79853
      
      Reviewed by Eric Seidel.
      
      Screen buffer can be different from rendered results.
      For example, WebKit/Efl just moves tiles for ewk_view_tiled when scrolling
      contents.
      It means that pixel tests can't check regression of ewk_view_tiled.
      
      This patch changes a way to provide bitmap from painting webview to capturing
      evas.
      
      * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
      (createBitmapContextFromWebView):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abd3b694
    • tony@chromium.org's avatar
      move listener_leak_test to webkit_unit_tests · d4633875
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85922
      
      Reviewed by Ojan Vafai.
      
      Porting the test from src/webkit/tools/test_shell/listener_leak_test.cc.
      All I did was change the style and use the FrameTestHelper to load the file.
      
      * WebKit.gyp: Exclude file in components build.
      * WebKit.gypi: Add new file.
      * tests/ListenerLeakTest.cpp: Added.
      (WebKit):
      (WebKit::GetProperty):
      (WebKit::GetNumObjects):
      (ListenerLeakTest):
      (WebKit::ListenerLeakTest::ListenerLeakTest):
      (WebKit::ListenerLeakTest::RunTest):
      (WebKit::TEST_F):
      * tests/data/listener/listener_leak1.html: Added.
      * tests/data/listener/listener_leak2.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4633875
    • oliver@apple.com's avatar
    • pdr@google.com's avatar
      Prevent crash in animated lists · 54da2e3f
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85382
      
      Reviewed by Nikolas Zimmermann.
      
      Source/WebCore:
      
      Animated lists blindly assign the last list value to m_toAtEndOfDurationType
      in SVGAnimationElement::startedActiveInterval. If the last list value's length
      is larger or smaller than the animated "to" length, we crash.
      
      This change prevents accessing values off the end of toAtEndOfDuration by adding
      a check for this case. It may seem inefficient to perform this check on every
      animation update but the "to" value can change (in cardinality) while animating.
      
      I checked each of the other animation types (e.g., SVGAnimatedAngle,
      SVGAnimatedBoolean, etc.) and was only able to hit this style of crash
      in the three types modified in this change:
      SVGAnimatedLengthList, SVGAnimatedNumberList, and SVGAnimatedPointList.
      
      Tests: svg/animations/animate-linear-discrete-additive-b-expected.svg
             svg/animations/animate-linear-discrete-additive-b.svg
             svg/animations/animate-linear-discrete-additive-c-expected.svg
             svg/animations/animate-linear-discrete-additive-c.svg
             svg/animations/animate-linear-discrete-additive-expected.svg
             svg/animations/animate-linear-discrete-additive.svg
             svg/animations/animate-list-crash.svg
      
      * svg/SVGAnimatedLengthList.cpp:
      (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedNumberList.cpp:
      (WebCore::SVGAnimatedNumberListAnimator::calculateAnimatedValue):
      * svg/SVGAnimatedPointList.cpp:
      (WebCore::SVGAnimatedPointListAnimator::calculateAnimatedValue):
      
      LayoutTests:
      
      * svg/animations/animate-linear-discrete-additive-b-expected.svg: Added.
      * svg/animations/animate-linear-discrete-additive-b.svg: Added.
      * svg/animations/animate-linear-discrete-additive-c-expected.svg: Added.
      * svg/animations/animate-linear-discrete-additive-c.svg: Added.
      * svg/animations/animate-linear-discrete-additive-expected.svg: Added.
      * svg/animations/animate-linear-discrete-additive.svg: Added.
      * svg/animations/animate-list-crash-expected.txt: Added.
      * svg/animations/animate-list-crash.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54da2e3f
    • rafaelw@chromium.org's avatar
      HTMLElementStack::hasOnlyHTMLElementsInScope is no longer called · b85cd94e
      rafaelw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85908
      
      Reviewed by Eric Seidel.
      
      This patch just removes the dead code.
      
      No tests needed. Cleanup only.
      
      * html/parser/HTMLElementStack.cpp:
      * html/parser/HTMLElementStack.h:
      (HTMLElementStack):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85cd94e
    • wjmaclean@chromium.org's avatar
      [chromium] Create LinkHighlightLayerChromium class to provide link-highlight... · 7917a299
      wjmaclean@chromium.org authored
      [chromium] Create LinkHighlightLayerChromium class to provide link-highlight preview animations for GraphicsLayerChromium.
      https://bugs.webkit.org/show_bug.cgi?id=85084
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Unit test provided.
      
      Creates a layer delegate class to provide link highlight animations for link-preview feature.
      These are added to a GraphicsLayerChromium via provided methods. Moves dispensing of animation
      ids into a separate class.
      
      * WebCore.gypi:
      * platform/graphics/chromium/AnimationIdVendor.cpp: Added.
      (WebCore):
      (WebCore::AnimationIdVendor::getNextAnimationId):
      (WebCore::AnimationIdVendor::getNextGroupId):
      * platform/graphics/chromium/AnimationIdVendor.h: Added.
      (WebCore):
      (AnimationIdVendor):
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::willBeDestroyed):
      (WebCore::GraphicsLayerChromium::updateNames):
      (WebCore::GraphicsLayerChromium::addAnimation):
      (WebCore::GraphicsLayerChromium::addLinkHighlight):
      (WebCore):
      (WebCore::GraphicsLayerChromium::didFinishLinkHighlight):
      (WebCore::GraphicsLayerChromium::updateChildList):
      (WebCore::GraphicsLayerChromium::mapAnimationNameToId):
      * platform/graphics/chromium/GraphicsLayerChromium.h:
      (WebCore):
      (GraphicsLayerChromium):
      * platform/graphics/chromium/LinkHighlight.cpp: Added.
      (WebCore):
      (WebCore::LinkHighlight::create):
      (WebCore::LinkHighlight::LinkHighlight):
      (WebCore::LinkHighlight::~LinkHighlight):
      (WebCore::LinkHighlight::contentLayer):
      (WebCore::LinkHighlight::paintContents):
      (WebCore::LinkHighlight::notifyAnimationStarted):
      (WebCore::LinkHighlight::notifyAnimationFinished):
      * platform/graphics/chromium/LinkHighlight.h: Added.
      (WebCore):
      (LinkHighlight):
      
      Source/WebKit/chromium:
      
      * WebKit.gypi:
      * tests/LinkHighlightTest.cpp: Added.
      (WebCore):
      (MockGraphicsLayerClient):
      (WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
      (WebCore::MockGraphicsLayerClient::notifySyncRequired):
      (WebCore::MockGraphicsLayerClient::paintContents):
      (WebCore::MockGraphicsLayerClient::showDebugBorders):
      (WebCore::MockGraphicsLayerClient::showRepaintCounter):
      (WebCore::TEST):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7917a299
    • barraclough@apple.com's avatar
      SIGFPE on divide in classic interpreter · 635f9cd8
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=85917
      
      Rubber stamped by Oliver Hunt.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::privateExecute):
          - check for divisor of -1.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      635f9cd8
    • ojan@chromium.org's avatar
      Chromium rebaselines after http://trac.webkit.org/changeset/116438. · 546c54a7
      ojan@chromium.org authored
      * platform/chromium-linux/css2.1/20110323/first-letter-000-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-dynamic-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003a-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-inherit-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-nested-007-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-quote-001-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-quote-002-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-quote-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-quote-004-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-quote-005-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png.
      * platform/chromium-linux/css2.1/20110323/first-letter-quote-006-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png.
      * platform/chromium-linux/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png.
      * platform/chromium-linux/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-000-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
      * platform/chromium-mac-leopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
      * platform/chromium-mac-leopard/fast/css/first-letter-nested-positioned-expected.png: Added.
      * platform/chromium-mac-leopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-000-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-001-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-002-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-003-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-004-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-005-expected.png: Added.
      * platform/chromium-mac-snowleopard/css2.1/20110323/first-letter-quote-006-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/css/first-letter-nested-positioned-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-000-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-000-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-001-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-001-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.png: Added.
      * platform/chromium-mac/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
      * platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.png: Added.
      * platform/chromium-mac/fast/css/first-letter-nested-positioned-expected.txt: Added.
      * platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
      * platform/chromium-mac/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
      * platform/chromium-win/css2.1/20110323/first-letter-000-expected.png: Added.
      * platform/chromium-win/css2.1/20110323/first-letter-000-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
      * platform/chromium-win/css2.1/20110323/first-letter-inherit-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-nested-007-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-002-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-004-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-005-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.png: Copied from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/css2.1/20110323/first-letter-quote-006-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt.
      * platform/chromium-win/fast/css/first-letter-nested-positioned-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png.
      * platform/chromium-win/fast/css/first-letter-nested-positioned-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt.
      * platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png.
      * platform/chromium-win/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      546c54a7
    • rakuco@webkit.org's avatar
      [CMake] Rewrite FindGStreamer.cmake. · ac4c4463
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85857
      
      Reviewed by Daniel Bates.
      
      .:
      
      We are currently kind of duplicating the same
      FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
      to be found. Besides this approach not scaling very well, it
      relies on pkg-config for version checking, uses the LibFindMacros
      package that we should deprecate and all the find files could be
      merged into one, with users using the COMPONENTS feature of the
      FIND_PACKAGE() call to find the desired plugins.
      
      FindGStreamer.cmake has then been rewritten to take all that into
      account:
      - The LibFindMacros.cmake package is not used anymore.
      - Version check is performed in the CMake file itself by parsing
      the gstversion.h header.
      - All GStreamer plugins are searched and the COMPONENTS keyword
      used in the FIND_PACKAGE() call is used to check which plugins are
      required.
      - The plugins-base and base GStreamer plugins are not searched, as
      they were not used anywhere in the build system.
      
      * Source/cmake/FindGStreamer-App.cmake: Removed.
      * Source/cmake/FindGStreamer-Audio.cmake: Removed.
      * Source/cmake/FindGStreamer-Base.cmake: Removed.
      * Source/cmake/FindGStreamer-FFT.cmake: Removed.
      * Source/cmake/FindGStreamer-Interfaces.cmake: Removed.
      * Source/cmake/FindGStreamer-Pbutils.cmake: Removed.
      * Source/cmake/FindGStreamer-Plugins-Base.cmake: Removed.
      * Source/cmake/FindGStreamer-Video.cmake: Removed.
      * Source/cmake/FindGStreamer.cmake: Rewrite as described above.
      * Source/cmake/OptionsEfl.cmake: Use COMPONENTS to specify which
      GStreamer plugins to look for.
      
      Source/WebCore:
      
      No new tests, build system change.
      
      We are currently kind of duplicating the same
      FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
      to be found. Besides this approach not scaling very well, it
      relies on pkg-config for version checking, uses the LibFindMacros
      package that we should deprecate and all the find files could be
      merged into one, with users using the COMPONENTS feature of the
      FIND_PACKAGE() call to find the desired plugins.
      
      FindGStreamer.cmake has then been rewritten to take all that into
      account:
      - The LibFindMacros.cmake package is not used anymore.
      - Version check is performed in the CMake file itself by parsing
      the gstversion.h header.
      - All GStreamer plugins are searched and the COMPONENTS keyword
      used in the FIND_PACKAGE() call is used to check which plugins are
      required.
      - The plugins-base and base GStreamer plugins are not searched, as
      they were not used anywhere in the build system.
      
      * PlatformEfl.cmake: Update GStreamer-related variable names.
      
      Source/WebKit:
      
      We are currently kind of duplicating the same
      FindGStreamer-Foo.cmake file whenever a new GStreamer plugin needs
      to be found. Besides this approach not scaling very well, it
      relies on pkg-config for version checking, uses the LibFindMacros
      package that we should deprecate and all the find files could be
      merged into one, with users using the COMPONENTS feature of the
      FIND_PACKAGE() call to find the desired plugins.
      
      FindGStreamer.cmake has then been rewritten to take all that into
      account:
      - The LibFindMacros.cmake package is not used anymore.
      - Version check is performed in the CMake file itself by parsing
      the gstversion.h header.
      - All GStreamer plugins are searched and the COMPONENTS keyword
      used in the FIND_PACKAGE() call is used to check which plugins are
      required.
      - The plugins-base and base GStreamer plugins are not searched, as
      they were not used anywhere in the build system.
      
      * PlatformEfl.cmake: Update GStreamer-related variable names.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac4c4463
    • commit-queue@webkit.org's avatar
      [EFL] Handling of numeric-pad keys in EFL's PlatformKeyboardEvent · f4b42c87
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85479
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-08
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebCore:
      
      EFL's PlatformKeyboardEvent::isKeypad() now returns meaningful value.
      Added numeric-pad keys to the Key Map and Windows Key Map.
      
      No new tests.
      
      * platform/efl/EflKeyboardUtilities.cpp:
      (WebCore::createKeyMap):
      (WebCore::createWindowsKeyMap):
      * platform/efl/PlatformKeyboardEventEfl.cpp:
      (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
      
      LayoutTests:
      
      Unskipped fast/events/keydown-numpad-keys.html.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4b42c87
    • zimmermann@webkit.org's avatar
      Tie lifetime of SVGAnimateElement::m_animatedType to the duration of the animation · a45f816f
      zimmermann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85627
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Example:
      <rect width="10" height="100">
          <animate attributeName="width" from="10" to="100" begin="2s" dur="4s" fill="remove"/>
      </rect>
      
      At t=0s the <animate> element receives its first interval: begin=2s, end=6s.
      At this point we've created the 'OwnPtr<SVGAnimatedType> m_animatedType' in
      SVGAnimateElement, which holds the current animated value of the target type.
      In this example it contains a SVGLength with '10' as value at t=0s.
      
      Calling "rect.width.animVal.value" will return the value currently contained in the
      m_animatedType from the SVGAnimateElement, even though the animation didn't begin
      yet. This is fine, as the animVal equals to the baseVal, as long as no animation is
      running.
      
      At t=6s you'd expect that the whole 'animVal' object is destructed again, as it's no
      longer needed, as animVal will be equal to baseVal again, but the current code keeps
      the animVal alive, and just resets it to the baseVal. The animVals will be destructed
      once the animate element leaves the tree.
      
      CSS animations suffer from the same problem, we never remove the animated SMIL properties
      but we only reset them to the base value. This makes integration with CSS Animations and
      CSS Transitions harder, so this needs to be changed.
      
      This patch starts tracking the start/end of an animation chain properly, to destruct
      the animation effect for non-frozen animations at the end of their duration. This has to
      work properly together with seeking (SVGSVGElement.setCurrentTime), as our testing relies
      on the ability to drive the SMIL timeline from script.
      
      Tests: svg/animations/list-wrapper-assertion-expected.svg
             svg/animations/list-wrapper-assertion.svg
      
      * svg/SVGAnimateElement.cpp:
      (WebCore::SVGAnimateElement::resetAnimatedType):
      (WebCore::applyCSSPropertyToTarget):
      (WebCore::removeCSSPropertyFromTarget):
      (WebCore::applyCSSPropertyToTargetAndInstances):
      (WebCore::removeCSSPropertyFromTargetAndInstances):
      (WebCore::notifyTargetAboutAnimValChange):
      (WebCore::notifyTargetAndInstancesAboutAnimValChange):
      (WebCore::SVGAnimateElement::clearAnimatedType):
      (WebCore::SVGAnimateElement::applyResultsToTarget):
      (WebCore::SVGAnimateElement::targetElementWillChange):
      * svg/SVGAnimateElement.h:
      (SVGAnimateElement):
      * svg/SVGAnimateMotionElement.cpp:
      (WebCore::SVGAnimateMotionElement::resetAnimatedType):
      (WebCore::SVGAnimateMotionElement::clearAnimatedType):
      * svg/SVGAnimateMotionElement.h:
      (SVGAnimateMotionElement):
      * svg/SVGAnimationElement.cpp:
      * svg/SVGAnimationElement.h:
      * svg/animation/SMILTimeContainer.cpp:
      (WebCore::SMILTimeContainer::updateAnimations):
      * svg/animation/SVGSMILElement.cpp:
      (WebCore::SVGSMILElement::reset):
      (WebCore::SVGSMILElement::targetElementWillChange):
      (WebCore::SVGSMILElement::determineActiveState):
      (WebCore::SVGSMILElement::progress):
      * svg/animation/SVGSMILElement.h:
      (SVGSMILElement):
      * svg/properties/SVGAnimatedListPropertyTearOff.h:
          Remove svgAttributeChanged() calls from animationEnded/animValDidChange.
          Callers are now required to notify the target about changes. There are cases
          where we want to call animValDidChange without invoking svgAttributeChanged().
          That is supported now.
      (WebCore::SVGAnimatedListPropertyTearOff::animationEnded):
      (WebCore::SVGAnimatedListPropertyTearOff::animValDidChange):
      * svg/properties/SVGAnimatedProperty.h: Ditto.
      (WebCore::SVGAnimatedProperty::commitChange): Add safety guard.
      * svg/properties/SVGAnimatedPropertyTearOff.h: Ditto.
      (WebCore::SVGAnimatedPropertyTearOff::animationEnded):
      (WebCore::SVGAnimatedPropertyTearOff::animValDidChange):
      * svg/properties/SVGAnimatedStaticPropertyTearOff.h: Ditto.
      (WebCore::SVGAnimatedStaticPropertyTearOff::animationEnded):
      (WebCore::SVGAnimatedStaticPropertyTearOff::animValDidChange):
      
      LayoutTests:
      
      Update animate-target-id-changed.svg test to match Firefox behavior.
      When an animation element with fill="freeze" is changed to a new target
      eg, via animate.href = "#someOtherID", the animation effect should be removed.
      
      Add tests for assertions I ran into while developing this patch.
      
      * platform/chromium/test_expectations.txt: Require new results for animate-target-id-changed-expected.txt.
      * platform/mac/svg/custom/animate-target-id-changed-expected.png:
      * svg/animations/list-wrapper-assertion-expected.svg: Added.
      * svg/animations/list-wrapper-assertion.svg: Added.
      * svg/custom/animate-target-id-changed-expected.txt:
      * svg/custom/animate-target-id-changed.svg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a45f816f
    • ryuan.choi@samsung.com's avatar
      [EFL][DRT]Do not create ScrollbarEfl when mockScrollbar is enabled. · 38db405f
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=81315
      
      Reviewed by Chang Shu.
      
      ScrollbarEfl creates custom scrollbars as separated layer and they are
      not related to ScrollbarTheme.
      So, DRT/Efl creates custom scrollbars on webview which paints mockScrollbar.
      
      This patch prevents creating custom scrollbars when mockScrollbar is enabled.
      
      Because DRT/Efl only renders the webview now, expected results are same
      until Bug 79853 is landed.
      
      * platform/efl/ScrollbarEfl.cpp:
      (Scrollbar::createNativeScrollbar):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38db405f
    • timothy@apple.com's avatar
      Fix the SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL macro so it passes the full path to dlopen. · 2112aa19
      timothy@apple.com authored
      dyld only considers libraries in the versioned framework path if their install name
      matches the library that it is attempting to load. The path we were passing to
      dlopen lacked the Versions/A component of the path so dyld did not recognize that
      we wanted it to use the staged version if it is newer.
      
      <rdar://problem/11406517>
      
      Reviewed by Mark Rowe.
      
      Source/WebCore:
      
      * platform/mac/SoftLinking.h: Have SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL take the
      framework version as an argument and use it when constructing the path to dlopen.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebInspectorClient.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
      
      Source/WebKit2:
      
      * UIProcess/mac/WebInspectorProxyMac.mm: Pass A to SOFT_LINK_STAGED_FRAMEWORK_OPTIONAL for the version.
      * WebProcess/WebPage/mac/WebInspectorMac.mm: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2112aa19
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r116440. · f04be6b1
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/116440
      https://bugs.webkit.org/show_bug.cgi?id=85904
      
      Broke the Chromium Android bot (Requested by beverloo on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08
      
      * WTF.gyp/WTF.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f04be6b1
    • rafael.lobo@openbossa.org's avatar
      Build fix for Qt Snowleopard Release · 62546db9
      rafael.lobo@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85895
      
      Reviewed by Alexis Menard.
      
      The enum value JSUint8ClampedArray conflicted with the JSUint8ClampedArray class.
      I've added the 'Type' suffix to the enum value to make their names different.
      
      No new tests needed.
      
      * bridge/qt/qt_runtime_qt4.cpp:
      (JSC::Bindings::valueRealType):
      (JSC::Bindings::convertValueToQVariant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62546db9
    • commit-queue@webkit.org's avatar
      offsetLeft broken within CSS3 columns · 3a27f9da
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34875
      
      Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-05-08
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      Reimplement offsetLeft and offsetTop in terms of a new method called
      'offsetTopLeft'. The new method starts from a reference point (the
      top-left coordinate of a box or inline) and adjusts this reference
      point for columns as we traverse each parent. Note that the reference
      point needs to be adjusted in both dimensions, even though offsetLeft
      and offsetTop return only one of them.
      
      A new method called 'offsetForColumns' was added to RenderObject. This
      method is similar to adjustForColumns, except that it returns the
      offset instead of modifying a reference. This method is necessary to
      simplify the implementation of offsetTopLeft.
      
      Tests: fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt
             fast/block/positioning/offsetLeft-offsetTop-multicolumn.html
      
      * rendering/RenderBox.h:
      (RenderBox):
      Override offsetLeft and offsetTop.
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::offsetLeft):
      Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
      topLeftLocation as startPoint.
      (WebCore::RenderBox::offsetTop):
      Implemented in terms of RenderBoxModelObject::offsetTopLeft, using
      topLeftLocation as startPoint.
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::offsetTopLeft):
      New method to compute offsetLeft and offsetTop simultaneously, and
      adjusting for columns at each parent.
      (WebCore::RenderBoxModelObject::offsetLeft):
      Reimplemented in terms of offsetTopLeft.
      (WebCore::RenderBoxModelObject::offsetTop):
      Reimplemented in terms of offsetTopLeft.
      * rendering/RenderBoxModelObject.h:
      (RenderBoxModelObject):
      Declare new offsetTopLeft method.
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::offsetLeft):
      Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.
      (WebCore::RenderInline::offsetTop):
      Reimplemented in terms of RenderBoxModelObject::offsetTopLeft.
      * rendering/RenderObject.h:
      (RenderObject):
      (WebCore::RenderObject::offsetForColumns):
      New helper method to simplify implementation of offsetTopLeft.
      
      LayoutTests:
      
      Add test for offsetLeft and offsetTop within multi-columns.
      
      * fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.txt: Added.
      * fast/block/positioning/offsetLeft-offsetTop-multicolumn.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a27f9da
    • rakuco@webkit.org's avatar
      [EFL] media/video-play-require-user-gesture.html test is failing · 23d4983d
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85900
      
      Unreviewed gardening.
      
      Move media/video-play-require-user-gesture.html to test_expectations.txt since
      it requires Full Screen API support. Also move fullscreen tests from Skipped
      list to test_expectations.txt
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
      
      * platform/efl/Skipped:
      * platform/efl/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23d4983d
    • rakuco@webkit.org's avatar
      [EFL] Layout test fast/overflow/lots-of-sibling-inline-boxes.html is flaky in debug builds · 4d174b08
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85896
      
      Unreviewed gardening.
      
      Marking test as slow, since it times-out when executed using debug builds under
      heavy processor loads.
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-08
      
      * platform/efl/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d174b08
    • rakuco@webkit.org's avatar
      [EFL] Update Web Timing tests expectations · baee8afe
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85622
      
      Unreviewed Gardening.
      
      Removed http/tests/misc/webtiming-origins.html and
      http/tests/misc/webtiming-ssl from test expectations.
      They started to pass after r116160.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
      
      * platform/efl/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baee8afe
    • commit-queue@webkit.org's avatar
      [EFL] http/tests/security/cross-frame-access-* tests are failing · 96626564
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85899
      
      Unreviewed, move failing tests to test expectations.
      
      http/tests/security/cross-frame-access-* tests are failing because EFL port
      does not support showModalDialog. We need to move the test cases to test
      expectations while the feature is implemented.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
      
      * platform/efl/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96626564
    • abarth@webkit.org's avatar
      [Chromium] OS(ANDROID) ImageDiff requires us to build WTF for both host and target · 60cf837b
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85897
      
      Reviewed by Tony Chang.
      
      * WTF.gyp/WTF.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60cf837b
    • rniwa@webkit.org's avatar
      perf-o-matic fix attempt for dashboard images. · 9975d924
      rniwa@webkit.org authored
      Rubber-stamped by Antti Koivisto.
      
      Also stop generating images for 30, 90, and 365 days since they have been timing out.
      
      * Websites/webkit-perf.appspot.com/controller.py:
      (schedule_runs_update):
      * Websites/webkit-perf.appspot.com/models.py:
      (Runs.chart_params):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9975d924
    • robert@webkit.org's avatar
      CSS 2.1 failure: first-letter-nested-004.htm fails · bbf7edf4
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72987
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      When styling first-letter check each sibling and drill into its inlines until we find either (i) a text node
      that is not all whitespace, or (ii) a line break.
      
      This makes our rendering of the following tests compatible with FF and Opera. Our current behaviour is also conformant
      since the spec allows UAs to style just one element:
          css2.1/20110323/first-letter-quote-002.htm
          css2.1/20110323/first-letter-quote-003.htm
          css2.1/20110323/first-letter-quote-004.htm
          css2.1/20110323/first-letter-quote-005.htm
      
      This fixes the following two tests. We now drill into the descendants of an element styled with :first-letter looking
      for text to style:
          css2.1/20110323/first-letter-nested-004.htm
          css2.1/20110323/first-letter-nested-006.htm
      
      This patch changes our rendering of first-letter-dynamic-001.htm as we now render adjacent quotes in the second line as
      green. This is consistent with the spec, which allows this behaviour but does not require it. It's the 'right' behaviour
      since it is consistent with the rendering of such quotes in a single element with :first-letter style.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::findLastObjectWithFirstLetterText): Iterate through the child's siblings looking for the last
        object to be styled :first-letter.
      (WebCore::RenderBlock::findLastObjectAfterFirstLetterPunctuation): Style any leading punctuation as first-letter, drill
        down into the child's descendants looking for text if necessary.
      (WebCore::RenderBlock::updateFirstLetter): Refactor to drill into sibling's children looking for inlines
       that should be styled as first-letter.
      (WebCore::RenderBlock::addFirstLetter): Split out from updateFirstLetter so that it can be used when a
       descendant node inside a sibling is found in findLastObjectWithFirstLetterText() needs to be styled as first-letter.
      * rendering/RenderBlock.h:
      
      LayoutTests:
      
      * css2.1/20110323/first-letter-000.htm: Added.
      * css2.1/20110323/first-letter-001.htm: Added.
      * css2.1/20110323/first-letter-dynamic-001.htm: Added.
      * css2.1/20110323/first-letter-dynamic-002.htm: Added.
      * css2.1/20110323/first-letter-dynamic-003a.htm: Added.
      * css2.1/20110323/first-letter-dynamic-003b.htm: Added.
      * css2.1/20110323/first-letter-inherit-001.htm: Added.
      * css2.1/20110323/first-letter-nested-001.htm: Added.
      * css2.1/20110323/first-letter-nested-002.htm: Added.
      * css2.1/20110323/first-letter-nested-003.htm: Added.
      * css2.1/20110323/first-letter-nested-004.htm: Added.
      * css2.1/20110323/first-letter-nested-005.htm: Added.
      * css2.1/20110323/first-letter-nested-006.htm: Added.
      * css2.1/20110323/first-letter-nested-007.htm: Added.
      * css2.1/20110323/first-letter-quote-001.htm: Added.
      * css2.1/20110323/first-letter-quote-002.htm: Added.
      * css2.1/20110323/first-letter-quote-003.htm: Added.
      * css2.1/20110323/first-letter-quote-004.htm: Added.
      * css2.1/20110323/first-letter-quote-005.htm: Added.
      * css2.1/20110323/first-letter-quote-006.htm: Added.
      * fast/css/first-letter-capitalized-edit-select-crash-expected.txt:
        Rebaselined.
      * fast/css/first-letter-nested-positioned.htm: Added.
         Tests that text nested inside a positioned object is styled.
      * fast/css/first-letter-quotes-no-content-before-after.html: Added.
         Tests that two consecutive quotes, each in a :before and :after pseudo element surrounding
         an empty main element, get styled with first letter.
      
      Behold! Pixel Results!
      
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-000-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-001-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-001-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-002-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003a-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-dynamic-003b-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-inherit-001-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-001-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-002-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-003-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-004-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-005-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-006-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-nested-007-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-001-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-002-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-003-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-004-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-005-expected.txt: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.png: Added.
      * platform/chromium-linux-x86/css2.1/20110323/first-letter-quote-006-expected.txt: Added.
      * platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.png: Added.
      * platform/chromium-linux-x86/fast/css/first-letter-nested-positioned-expected.txt: Added.
      * platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.png: Added.
      * platform/chromium-linux-x86/fast/css/first-letter-quotes-no-content-before-after-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbf7edf4
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r116402. · b3223185
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/116402
      https://bugs.webkit.org/show_bug.cgi?id=85898
      
      Caused a 3% regression on Chromium's bloat-http test on Linux
      (Requested by ojan_gardening on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-08
      
      * WebCore.exp.in:
      * bindings/v8/RetainedDOMInfo.cpp:
      * dom/ContainerNode.h:
      * dom/Node.cpp:
      (WebCore::Node::traverseNextNode):
      (WebCore):
      (WebCore::Node::traverseNextSibling):
      * dom/Node.h:
      (Node):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3223185
    • commit-queue@webkit.org's avatar
      [CMake] Add ENABLE_IFRAME_SEAMLESS flag · 7557cf42
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=85838
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-08
      Reviewed by Eric Seidel.
      
      Add ENABLE_IFRAME_SEAMLESS flag to CMake and enable it by default.
      This flag was introduced by r116356.
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7557cf42
    • hbono@chromium.org's avatar
      [Chromium] Fix the position of an RTL resizer · 14f58908
      hbono@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80640
      
      Reviewed by Tony Chang.
      
      When rendering an RTL resizer, my r110073 renders it at the same position as the
      one used for rendering a LTR resizer. Unfortunately, this code renders the RTL
      resizer image at an incorrect position on Mac and Linux. This change uses the
      correct formula to calculate the position of an RTL resizer.
      
      Source/WebCore:
      
      Test: platform/chromium/scrollbars/rtl-resizer-position.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::drawPlatformResizerImage):
      
      LayoutTests:
      
      * platform/chromium/platform/chromium/scrollbars: Added.
      * platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.png: Added.
      * platform/chromium/platform/chromium/scrollbars/rtl-resizer-position-expected.txt: Added.
      * platform/chromium/scrollbars/rtl-resizer-position.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14f58908