1. 14 Mar, 2010 1 commit
  2. 27 Feb, 2010 1 commit
    • mitz@apple.com's avatar
      <rdar://problem/7696607> Links do not respect -webkit-user-drag: none · 29bb5006
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35475
      
      Reviewed by Maciej Stachowiak.
      
      WebCore: 
      
      Test: fast/css/user-drag-none.html
      
      * page/DragController.cpp:
      (WebCore::DragController::mayStartDragAtEventLocation): Added a node
      parameter. The image drag check is done against the node, rather than
      than against the hit test result. This prevents a non-draggable image
      with an auto-draggable ancestor from being dragged alone. The link drag
      check now ignores links that are -webkit-user-drag: none.
      * page/DragController.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::shouldDragAutoNode): Pass the current node
      to mayStartDragAtEventLocation().
      
      LayoutTests: 
      
      * fast/css/user-drag-none-expected.txt: Added.
      * fast/css/user-drag-none.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29bb5006
  3. 19 Feb, 2010 1 commit
    • pkasting@chromium.org's avatar
      WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean · 2cadd7b2
      pkasting@chromium.org authored
      up some code.
      https://bugs.webkit.org/show_bug.cgi?id=35136
      
      Reviewed by Darin Fisher.
      
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::updateRenderer): Shorten some code.
      * page/DragController.cpp:
      (WebCore::getImage): Shorten some code.
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeImage): NULL-check cachedImage().
      * platform/gtk/PasteboardGtk.cpp:
      (WebCore::Pasteboard::writeImage): NULL-check cachedImage().
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::writeImage): NULL-check cachedImage().
      * platform/qt/PasteboardQt.cpp:
      (WebCore::Pasteboard::writeImage): NULL-check cachedImage().
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::writeImage): NULL-check cachedImage().
      
      WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
      https://bugs.webkit.org/show_bug.cgi?id=35136
              
      Reviewed by Darin Fisher.
      
      This lets us properly enable/disable the "Copy Image" context menu entry
      (and, in the future, maybe add a "Load Image" function).
      
      * public/WebContextMenuData.h:
      * src/ContextMenuClientImpl.cpp:
      (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cadd7b2
  4. 04 Feb, 2010 1 commit
    • enrica@apple.com's avatar
      REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info. · 5b42a264
      enrica@apple.com authored
      <rdar://problem/7595685>
      https://bugs.webkit.org/show_bug.cgi?id=34609
      
      Reviewed by Oliver Hunt.
      
      WebCore: 
      
      Test: editing/pasteboard/drop-inputtext-acquires-style.html
      
      The dragging code did not distinguish the case of dragging the content of an input control
      as a special case. The markup placed in the pasteboard included the style information.
      I've modified the Clipboard class interface adding a new method writePlainText to match the
      behavior of the copy and cut commands and modified the drag code to detect the special case.
      I've modified all the platform specific implementations of the Clipboard class.
              
      * dom/Clipboard.h: Added writePlainText pure virtual function.
      * editing/Editor.cpp:
      (WebCore::Editor::cut): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
      (WebCore::Editor::copy): Renamed nodeIsTextFormControl to isNodeInTextFormControl.
      * editing/htmlediting.cpp:
      (WebCore::isNodeInTextFormControl): Added, after removing the implementation with the old name
      in Editor.cpp
      * editing/htmlediting.h:
      * page/DragController.cpp:
      (WebCore::DragController::startDrag):
      * platform/Pasteboard.h:
      * platform/android/ClipboardAndroid.cpp:
      (WebCore::ClipboardAndroid::writePlainText): Added.
      * platform/android/ClipboardAndroid.h:
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::writePlainText): Added.
      * platform/chromium/ClipboardChromium.h:
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::writePlainText): Added.
      * platform/gtk/ClipboardGtk.h:
      * platform/haiku/ClipboardHaiku.cpp:
      (WebCore::ClipboardHaiku::writePlainText): Added.
      * platform/haiku/ClipboardHaiku.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::writePlainText): Added.
      * platform/mac/PasteboardMac.mm:
      (WebCore::Pasteboard::writePlainText): Added helper function.
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::writePlainText): Added.
      * platform/qt/ClipboardQt.h:
      * platform/win/ClipboardWin.cpp:
      (WebCore::ClipboardWin::writePlainText): Added.
      * platform/win/ClipboardWin.h:
      
      LayoutTests: 
      
      * editing/pasteboard/drop-inputtext-acquires-style-expected.txt: Added.
      * editing/pasteboard/drop-inputtext-acquires-style.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b42a264
  5. 14 Jan, 2010 1 commit
    • bweinstein@apple.com's avatar
      Drag and Drop source/destination code needs cleanup. · 057730b0
      bweinstein@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=33691>.
              
      Reviewed by Adam Roben.
      
      WebCore: 
      
      Cleaned up some Drag and Drop code that deals with getting
      source and destination operations, and added some ASSERTS to make
      sure we don't get in bad states.
      
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::sourceOperation): Make this return the operation itself.
      (WebCore::Clipboard::destinationOperation): Ditto.
      (WebCore::Clipboard::setSourceOperation): Add an assert to make sure we're valud.
      (WebCore::Clipboard::setDestinationOperation): Ditto.
      * dom/Clipboard.h:
      * page/DragController.cpp:
      (WebCore::DragController::tryDHTMLDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleDrag):
      
      WebKit/chromium: 
      
      Update to new way of calling sourceOperation.
      
      * src/DragClientImpl.cpp:
      (WebKit::DragClientImpl::startDrag):
      
      WebKit/qt: 
      
      Update to new way of calling sourceOperation.
      
      * WebCoreSupport/DragClientQt.cpp:
      (WebCore::DragClientQt::startDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      057730b0
  6. 08 Oct, 2009 1 commit
  7. 18 Sep, 2009 1 commit
  8. 17 Sep, 2009 1 commit
  9. 16 Sep, 2009 1 commit
    • bolsinga@apple.com's avatar
      Add ENABLE(DRAG_SUPPORT) · 5db11076
      bolsinga@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29233
      
      Reviewed by David Kilzer.
      
      JavaScriptCore:
      
      * wtf/Platform.h:
      
      WebCore:
      
      No new tests. (No change in default behavior.)
      
      * DerivedSources.make: Use new WebCore.DragSupport.exp file if ENABLE_DRAG_SUPPORT.
      * WebCore.base.exp: Move Drag Support only exports to WebCore.DragSupport.exp.
      * WebCore.xcodeproj/project.pbxproj: Add WebCore.DragSupport.exp.
      * dom/Clipboard.h: Use ENABLE(DRAG_SUPPORT) where applicable.
      * loader/EmptyClients.h: Ditto.
      * page/DragController.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
      * page/EventHandler.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::handleMouseMoveEvent):
      * page/EventHandler.h: Ditto.
      * page/Page.cpp: Ditto.
      (WebCore::Page::Page):
      * page/Page.h: Ditto.
      * page/mac/DragControllerMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
      * page/mac/EventHandlerMac.mm: Use ENABLE(DRAG_SUPPORT) where applicable.
      (WebCore::EventHandler::passSubframeEventToSubframe):
      * platform/DragData.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
      * platform/DragImage.cpp: Wrap entire file in ENABLE(DRAG_SUPPORT).
      * platform/mac/ClipboardMac.h: Use ENABLE(DRAG_SUPPORT) where applicable.
      * platform/mac/ClipboardMac.mm: Ditto.
      * platform/mac/DragDataMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
      * platform/mac/DragImageMac.mm: Wrap entire file in ENABLE(DRAG_SUPPORT).
      * rendering/RenderLayer.cpp: Use ENABLE(DRAG_SUPPORT) where applicable.
      (WebCore::RenderLayer::autoscroll):
      * rendering/RenderObject.cpp: Ditto.
      * rendering/RenderObject.h: Ditto.
      * svg/graphics/SVGImage.cpp: Ditto.
      (WebCore::SVGImage::dataChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5db11076
  10. 11 Sep, 2009 1 commit
    • eric@webkit.org's avatar
      2009-09-11 Eric Seidel <eric@webkit.org> · 58165d43
      eric@webkit.org authored
              No review, rolling out r48229.
              http://trac.webkit.org/changeset/48229
      
              * fast/events/drag-dropeffect-expected.txt: Removed.
              * fast/events/drag-dropeffect.html: Removed.
      2009-09-11  Eric Seidel  <eric@webkit.org>
      
              No review, rolling out r48229.
              http://trac.webkit.org/changeset/48229
      
              * WebCore.base.exp:
              * dom/Clipboard.cpp:
              (WebCore::Clipboard::Clipboard):
              (WebCore::Clipboard::sourceOperation):
              * page/DragController.cpp:
              (WebCore::DragController::DragController):
              (WebCore::DragController::dragExited):
              (WebCore::DragController::performDrag):
              (WebCore::DragController::dragEnteredOrUpdated):
              (WebCore::DragController::tryDHTMLDrag):
              (WebCore::DragController::startDrag):
              * page/DragController.h:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::updateDragAndDrop):
              (WebCore::EventHandler::dragSourceMovedTo):
              (WebCore::EventHandler::handleDrag):
              * page/EventHandler.h:
      2009-09-11  Eric Seidel  <eric@webkit.org>
      
              No review, rolling out r48229.
              http://trac.webkit.org/changeset/48229
      
              * WebView/WebFrame.mm:
              (-[WebFrame _dragSourceMovedTo:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58165d43
  11. 09 Sep, 2009 1 commit
    • eric@webkit.org's avatar
      2009-09-09 Jens Alfke <snej@chromium.org> · 99e6cded
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Initialize DataTransfer's effectAllowed and dropEffect properties correctly
              according to HTML5 spec (sec. 7.9.2-7.9.3).
              https://bugs.webkit.org/show_bug.cgi?id=26700
      
              * fast/events/drag-dropeffect-expected.txt: Added.
              * fast/events/drag-dropeffect.html: Added.
      2009-09-09  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Initialize DataTransfer's effectAllowed and dropEffect properties correctly
              according to HTML5 spec (sec. 7.9.2-7.9.3).
              https://bugs.webkit.org/show_bug.cgi?id=26700
              - At the start of a drag operation, the value of effectAllowed should be
                the string "uninitialized".
              - At end of dragstart handler, if effectAllowed hasn't been set yet, it
                should be set to "copy".
              - on dragenter and dragover event, dropEffect should be initialized to a
                default value based on the value of effectAllow...
      99e6cded
  12. 23 Aug, 2009 1 commit
    • darin@apple.com's avatar
      Make DOM classes start with a reference count of 1, like all other RefCounted · cf9dd0fa
      darin@apple.com authored
              
      Patch by Darin Adler <darin@apple.com> on 2009-08-22
      Reviewed by Oliver Hunt.
      
      Next step: Element, HTMLElement, HTMLAnchorElement, HTMLAppletElement,
      HTMLAreaElement, HTMLEmbedElement, HTMLFrameElement, HTMLIFrameElement,
      HTMLObjectElement, HTMLPlugInElement, HTMLPlugInImageElement.
      
      * DerivedSources.make: Fix error seen every time we build by escaping the $
      in the build rule, since you have to use $$ for that in make.
      
      * WebCore.base.exp: Updated.
      
      * bindings/objc/DOM.mm:
      Added now-needed include of SVGNames.h.
      
      * dom/Document.cpp: Added now-needed include of SVGNames.h.
      (WebCore::Document::createElement): Use create instead of new.
      
      * dom/Element.cpp:
      (WebCore::Element::Element): Added ConstructionType argument so the caller
      can determine whether this starts with a reference count of either 0 or 1.
      Later we will remove this again once they are all 1.
      (WebCore::Element::create): Added.
      
      * dom/Element.h: Added create and made constructor protected.
      
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::StyledElement): Added ConstructionType argument.
      * dom/StyledElement.h: Made many functions protected or private, including
      the constructor.
      
      * dom/make_names.pl: Use create to create the base elements HTMLElement,
      SVGElement, and WMLElement.
      
      * editing/CreateLinkCommand.cpp:
      (WebCore::CreateLinkCommand::doApply): Use create instead of new.
      * editing/UnlinkCommand.cpp:
      (WebCore::UnlinkCommand::doApply): Ditto.
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::create): Added.
      * html/HTMLAnchorElement.h: Made constructor protected and added create.
      Also made m_rootEditableElementForSelectionOnMouseDown a RefPtr.
      
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::create): Added.
      * html/HTMLAppletElement.h: Made constructor private and added create.
      
      * html/HTMLAreaElement.cpp:
      (WebCore::HTMLAreaElement::create): Added.
      * html/HTMLAreaElement.h: Made constructor private and added create.
      
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::create): Added.
      * html/HTMLElement.h: Made constructor protected and added create.
      Made other functions protected and private. Also added inline
      definition of constructor.
      
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::create): Added.
      * html/HTMLEmbedElement.h: Made constructor private and added create.
      Made other functions private.
      
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::create): Added.
      (WebCore::HTMLFrameElement::parseMappedAttribute):
      * html/HTMLFrameElement.h: Made constructor private and added create.
      Made other functions private.
      
      * html/HTMLFrameElementBase.h: Made functions protected and private.
      
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement): Pass
      CreateElement so reference count starts at 1.
      
      * html/HTMLFrameOwnerElement.h: Made functions protected and private.
      
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::create): Added.
      * html/HTMLIFrameElement.h: Made constructor private and added create.
      Made other functions private.
      
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::create): Added.
      (WebCore::HTMLObjectElement::containsJavaApplet): Changed while loop
      into a for loop and tweaked formatting.
      
      * html/HTMLObjectElement.h: Made constructor private and added create.
      Made other functions private.
      
      * html/HTMLPlugInElement.h: Made constructor protected.
      Made other functions protected and private.
      
      * html/HTMLPlugInImageElement.h: Made constructor and another function
      protected.
      
      * html/HTMLTagNames.in: Removed createWithNew from all classes that
      now have create functions. Moved conditional noscript to a separate
      paragraph.
      
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Use create.
      (WebCore::HTMLViewSourceDocument::addLink): Ditto.
      * page/DragController.cpp:
      (WebCore::documentFragmentFromDragData): Ditto.
      
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::SVGElement): Pass CreateElementZeroRefCount
      so reference count still starts at 0. Will change this class later.
      (WebCore::SVGElement::create): Added.
      * svg/SVGElement.h: Added create, made constructor protected, and
      made other functions protected and private. Removed unneeded
      SVGNames.h include.
      
      * svg/SVGExternalResourcesRequired.h: Added now-needed SVGNames.h
      include.
      
      * svg/SVGStopElement.h: Added now-needed SVGNames.h include.
      Made functions private.
      
      * wml/WMLElement.cpp:
      (WebCore::WMLElement::WMLElement): Pass CreateElementZeroRefCount
      so reference count still starts at 0. Will change this class later.
      (WebCore::WMLElement::create): Added.
      * wml/WMLElement.h: Added create and made constructor protected.
      
      * wml/WMLTagNames.in: Removed createWithNew from WMLElement.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf9dd0fa
  13. 05 Aug, 2009 1 commit
    • darin@apple.com's avatar
      2009-08-05 Darin Adler <darin@apple.com> · b6cb2561
      darin@apple.com authored
              Reviewed by David Levin.
      
              Use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Last patch. Makes all the casts of RenderObject use checked
              casts instead of using static_cast directly.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::visibleChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/AccessibilityListBoxOption.cpp:
              (WebCore::AccessibilityListBoxOption::elementRect):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::textUnderElement):
              (WebCore::AccessibilityRenderObject::stringValue):
              (WebCore::AccessibilityRenderObject::titleUIElement):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              * accessibility/AccessibilitySlider.cpp:
              (WebCore::AccessibilitySliderThumb::elementRect):
              * dom/InputElement.cpp:
              (WebCore::InputElement::updatePlaceholderVisibility):
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::scrollToSelection):
              (WebCore::SelectElement::recalcStyle):
              (WebCore::SelectElement::setRecalcListItems):
              (WebCore::SelectElement::menuListDefaultEventHandler):
              (WebCore::SelectElement::listBoxDefaultEventHandler):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::reset):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::updateWidget):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::attach):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::defaultEventHandler):
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::attach):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              (WebCore::HTMLInputElement::addSearchResult):
              (WebCore::HTMLInputElement::onSearch):
              * html/HTMLLIElement.cpp:
              (WebCore::HTMLLIElement::parseMappedAttribute):
              (WebCore::HTMLLIElement::attach):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::setReadyState):
              (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
              (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
              (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
              (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
              (WebCore::HTMLMediaElement::defaultEventHandler):
              (WebCore::HTMLMediaElement::finishParsingChildren):
              * html/HTMLOListElement.cpp:
              (WebCore::HTMLOListElement::parseMappedAttribute):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::updateWidget):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::defaultEventHandler):
              * page/DragController.cpp:
              (WebCore::DragController::concludeEditDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::capsLockStateMayHaveChanged):
              * page/Frame.cpp:
              (WebCore::Frame::ownerRenderer):
              * page/FrameView.cpp:
              (WebCore::FrameView::detachCustomScrollbars):
              * page/wince/FrameWince.cpp:
              (WebCore::computePageRectsForFrame):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlTimelineElement::defaultEventHandler):
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
              * rendering/RenderCounter.cpp:
              (WebCore::planCounter):
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::computeEdgeInfo):
              (WebCore::RenderFrameSet::setIsResizing):
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::contentsBox):
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::updateBacking):
              (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
              * rendering/RenderListItem.cpp:
              (WebCore::previousListItem):
              (WebCore::RenderListItem::explicitValueChanged):
              * rendering/RenderObject.cpp:
              (WebCore::updateListMarkerNumbers):
              * rendering/RenderObjectChildList.cpp:
              (WebCore::updateListMarkerNumbers):
              (WebCore::invalidateCountersInContainer):
              * rendering/RenderScrollbarTheme.cpp:
              (WebCore::RenderScrollbarTheme::minimumThumbLength):
              (WebCore::RenderScrollbarTheme::backButtonRect):
              (WebCore::RenderScrollbarTheme::forwardButtonRect):
              (WebCore::RenderScrollbarTheme::trackRect):
              (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
              (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
              (WebCore::RenderScrollbarTheme::paintTrackBackground):
              (WebCore::RenderScrollbarTheme::paintTrackPiece):
              (WebCore::RenderScrollbarTheme::paintButton):
              (WebCore::RenderScrollbarTheme::paintThumb):
              * rendering/RenderSlider.cpp:
              (WebCore::SliderThumbElement::defaultEventHandler):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::paintSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintSliderThumb):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintSliderThumb):
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::determineSliderThumbState):
              * rendering/SVGCharacterLayoutInfo.cpp:
              (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::findSVGRootObject):
              * rendering/TextControlInnerElements.cpp:
              (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
              (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::attach):
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::canvasResource):
              * svg/SVGTextContentElement.cpp:
              (WebCore::rootInlineBoxForTextContentElement):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::defaultEventHandler):
              Use checked casts.
      
              * rendering/RenderApplet.h:
              * rendering/RenderCounter.h:
              * rendering/RenderFieldset.h:
              * rendering/RenderFileUploadControl.h:
              * rendering/RenderFrame.h:
              * rendering/RenderFrameSet.h:
              * rendering/RenderHTMLCanvas.h:
              * rendering/RenderListBox.h:
              * rendering/RenderListItem.h:
              * rendering/RenderListMarker.h:
              * rendering/RenderMedia.h:
              * rendering/RenderMenuList.h:
              * rendering/RenderPart.h:
              * rendering/RenderPartObject.h:
              * rendering/RenderPath.h:
              * rendering/RenderSVGContainer.h:
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGTextPath.h:
              * rendering/RenderSVGViewportContainer.h:
              * rendering/RenderScrollbar.h:
              * rendering/RenderSlider.h:
              * rendering/RenderTextControlMultiLine.h:
              * rendering/RenderTextControlSingleLine.h:
              * rendering/RenderVideo.h:
              Added a checked cast. Also made most members protected or private.
      
              * rendering/RenderBlock.h:
              * rendering/RenderInline.h:
              * rendering/RenderReplaced.h:
              * rendering/RenderSVGBlock.h:
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGText.h:
              * rendering/RenderTextControl.h:
              Made most members protected or private.
      
              * rendering/RenderInline.cpp:
              * rendering/RenderSVGContainer.cpp:
              * rendering/RenderSVGHiddenContainer.cpp:
              * rendering/RenderSVGImage.cpp:
              * rendering/RenderSVGRoot.cpp:
              Removed unneeded destructor.
      
              * rendering/RenderSVGHiddenContainer.h:
              Removed unneeded virtual function overrides that did the same as
              the default and base class.
      
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport
              directly instead of using a function call.
              (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto.
              (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto.
              (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto.
              (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
      
              * rendering/RenderScrollbar.cpp:
              (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for
              all values instead of using a default case.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<): Removed dependency on casting to types that don't
              have any public members we need to get at. Instead, use function names to
              identify the type rather than doing so much overloading. Changed to use
              checked casts.
              (WebCore::write): Ditto.
      
              * rendering/SVGRenderSupport.cpp:
              (WebCore::renderSubtreeToImage): Changed to use a checked cast and also
              added a comment about the fact that the code does not do sufficient type
              checking before doing the cast.
      
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::writeRenderSVGTextBox): Renamed this from operator<<.
              (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText.
              (WebCore::writeSVGText): Renamed this from write.
              (WebCore::writeSVGInlineText): Ditto.
              (WebCore::writeSVGImage): Ditto.
              * rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed
              unneeded default arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6cb2561
  14. 04 Aug, 2009 1 commit
  15. 24 Jul, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-07-24 Mike Fenton <mike.fenton@torchmobile.com> · 2def5eb9
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
              Style Guidelines as identified by cpplint.py.
              https://bugs.webkit.org/show_bug.cgi?id=27624
      
              * page/DragController.cpp:
              (WebCore::DragController::~DragController):
              (WebCore::documentFragmentFromDragData):
              (WebCore::DragController::dragEnded):
              (WebCore::DragController::dragEntered):
              (WebCore::DragController::dragExited):
              (WebCore::DragController::dragUpdated):
              (WebCore::DragController::performDrag):
              (WebCore::asFileInput):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::DragController::delegateDragSourceAction):
              (WebCore::DragController::concludeEditDrag):
              (WebCore::DragController::canProcessDrag):
              (WebCore::DragController::tryDHTMLDrag):
              (WebCore::DragController::mayStartDragAtEventLocation):
              (WebCore::getCachedImage):
              (WebCore::getImage):
              (WebCore::prepareClipboardForImageDrag):
              (WebCore::dragLocForDHTMLDrag):
              (WebCore::DragController::startDrag):
              (WebCore::DragController::doImageDrag):
              (WebCore::DragController::doSystemDrag):
              (WebCore::DragController::placeDragCaret):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2def5eb9
  16. 24 Jun, 2009 2 commits
    • eric@webkit.org's avatar
      2009-06-24 Eric Seidel <eric@webkit.org> · 8a0f4c21
      eric@webkit.org authored
              No review, build fix only.
      
              The previous checkin had an improper merge.  This fixes the build.
      
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a0f4c21
    • eric@webkit.org's avatar
      2009-06-05 Eric Seidel <eric@webkit.org> · 3c6ea8a1
      eric@webkit.org authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=25922
              Fix dropEffect = "none" to work as expected.
      
              * fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
              * fast/events/drag-to-navigate.html: Added.
              * fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
              * fast/events/prevent-drag-to-navigate.html: Added.
              * fast/events/resources/file-for-drag-to-navigate.html: Added.
              * fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.
      
      2009-06-05  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=25922
              JS setting dropEffect = "none" causes tryDHTMLDrag
              to return DragOperationNone.  Which is also the value
              tryDHTMLDrag previously used to indicate JS did not
              want to handle the drag.
      
              Make it possible for the DragController::try* methods
              to return a bool to indicate if javascript accepted
              or rejected the drag event, separate from the DragOperation.
      
              Tests:
              - fast/events/drag-to-navigate.html
              - fast/events/prevent-drag-to-navigate.html
      
              * page/DragController.cpp:
              (WebCore::DragController::dragEnteredOrUpdated):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::defaultOperationForDrag):
              (WebCore::DragController::tryDHTMLDrag):
              * page/DragController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c6ea8a1
  17. 13 Jun, 2009 1 commit
    • abarth@webkit.org's avatar
      2009-06-13 Victor Wang <victorw@chromium.org> · 15a81fcd
      abarth@webkit.org authored
              Reviewed by Eric Seidel.  Landed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26333
              Alert during a dragenter event handler will crash the renderer
              
              This crash is casued by calling NULL pointer m_documentUnderMouse in
              DragController::tryDocumentDrag()
      
              tryDHTMLDrag fires dragenter event. The event listener that listens
              to this event may create a nested message loop (open a modal dialog),
              which could process dragleave event and reset m_documentUnderMouse in
              dragExited.
      
              Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
              do not continue if the pointer has been set to NULL.
      
              Test: DRT does not show alerts so add a manual test:
                    manual-tests/drag-enter-alert.html
      
              * manual-tests/drag-enter-alert.html: Added.
              * manual-tests/resources/drag-image.png: Added.
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15a81fcd
  18. 27 May, 2009 1 commit
  19. 21 May, 2009 3 commits
    • ggaren@apple.com's avatar
      WebCore: · 1625e181
      ggaren@apple.com authored
      2009-05-21  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
              Incorrect URL returned to the DOM while the user drags a file
      
              * page/DragController.cpp:
              (WebCore::DragController::dragExited):
              (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
              since that only looks at the text of the document's URL. Do base our
              decision on the securityOrigin(), which knows more about the document's
              actual origin.
      
      LayoutTests:
      
      2009-05-21  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Tests for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
              Incorrect URL returned to the DOM while the user drags a file
      
              * http/tests/local/drag-over-remote-content-expected.txt: Added.
              * http/tests/local/drag-over-remote-content.html: Added.
              * http/tests/security/drag-over-remote-content-iframe-expected.txt: Added.
              * http/tests/security/drag-over-remote-content-iframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1625e181
    • eric@webkit.org's avatar
      2009-05-21 Eric Seidel <eric@webkit.org> · 3d81d65f
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Clean up DragController
              https://bugs.webkit.org/show_bug.cgi?id=25926
      
              I renamed m_document to m_documentUnderMouse to better document what it does
              I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
              long enough.
      
              I also saw copy/paste code involving clearing the selection when moving out of
              one document and into another.  I moved that code into a function called
              mouseMovedIntoDocument.
      
              I also got rid of a couple needless null-checks after confirming via source
              inspection they were not ever possible.
              In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
              I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
              It's also not possible to return a document from documentAtPoint that is not
              in a frame (as such a document would not be rendered).
      
              No functional changes, thus no tests.
      
              * page/DragController.cpp:
              (WebCore::DragController::DragController):
              (WebCore::DragController::dragIsMove):
              (WebCore::DragController::dragExited):
              (WebCore::DragController::performDrag):
              (WebCore::DragController::mouseMovedIntoDocument):
              (WebCore::DragController::dragEnteredOrUpdated):
              (WebCore::DragController::tryDocumentDrag):
              (WebCore::DragController::operationForLoad):
              (WebCore::DragController::concludeEditDrag):
              (WebCore::DragController::canProcessDrag):
              (WebCore::DragController::tryDHTMLDrag):
              (WebCore::DragController::placeDragCaret):
              * page/DragController.h:
              (WebCore::DragController::documentUnderMouse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d81d65f
    • eric@webkit.org's avatar
      2009-05-21 Eric Seidel <eric@webkit.org> · 5797165d
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Rename DragController::dragOperation() to sourceDragOperation() for clarity
              Remove unused setDragOperation()
      
              There are two times DragOperation is used.  The source specifies
              what drag operations it supports (in a mask) and the destination
              picks a subset of those as DragOperations it supports if a drop were
              to occur.  I was confused when I first saw this accessor as to which
              it meant.  It turns out that this is only used when WebKit starts a
              drag, and we keep it around so that we can provide this information
              to other Mac OS X applications when they ask.  I've renamed the method
              for clarity so the next person in this code will be less confused.
      
              No functional changes, thus no tests.
      
              * page/DragController.h:
              (WebCore::DragController::sourceDragOperation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5797165d
  20. 07 May, 2009 1 commit
    • zimmermann@webkit.org's avatar
      Reviewed by Dave Hyatt. · b75da289
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
      
      Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
      
      Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
      gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
      
      The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
      This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
      To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
      methods are renamed to clarify where they belong to. (Detailed list in ChangeLog)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b75da289
  21. 20 Feb, 2009 1 commit
    • jchaffraix@webkit.org's avatar
      2009-02-20 Julien Chaffraix <jchaffraix@webkit.org> · 074bcda0
      jchaffraix@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
      
              Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
              or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
              unneeded.
      
              It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
              enables us to use some generated QualifiedName.
      
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::constructHTMLOptionElement):
              * dom/Document.cpp:
              (WebCore::Document::setTitle):
              * dom/XMLTokenizer.cpp:
              (WebCore::createXHTMLParserErrorHeader):
              (WebCore::XMLTokenizer::insertErrorMessageBlock):
              * editing/CompositeEditCommand.cpp:
              (WebCore::createBlockPlaceholderElement):
              * editing/htmlediting.cpp:
              (WebCore::createTabSpanElement):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::setLength):
              * loader/FTPDirectoryDocument.cpp:
              (WebCore::FTPDirectoryTokenizer::appendEntry):
              (WebCore::FTPDirectoryTokenizer::createTDForFilename):
              (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
              (WebCore::FTPDirectoryTokenizer::createBasicDocument):
              * loader/ImageDocument.cpp:
              (WebCore::ImageDocument::createDocumentStructure):
              * loader/MediaDocument.cpp:
              (WebCore::MediaTokenizer::createDocumentStructure):
              * loader/PluginDocument.cpp:
              (WebCore::PluginTokenizer::createDocumentStructure):
              * loader/TextDocument.cpp:
              (WebCore::TextTokenizer::write):
              * page/Frame.cpp:
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::styleForSelectionStart):
              Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
      
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
              * page/DragController.cpp:
              (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      074bcda0
  22. 09 Feb, 2009 1 commit
  23. 06 Feb, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Justin Garcia. · 50d7db0a
      eric@webkit.org authored
              DOMSelection.getRangeAt() returns a different range than the selection
              https://bugs.webkit.org/show_bug.cgi?id=23601
      
              Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range
      
              Test: fast/dom/Selection/getRangeAt.html
      
              * WebCore.base.exp:
              * dom/InputElement.cpp:
              (WebCore::InputElement::handleBeforeTextInsertedEvent):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/Editor.cpp:
              (WebCore::Editor::selectedRange):
              (WebCore::Editor::fontForSelection):
              (WebCore::Editor::applyStyleToSelection):
              (WebCore::Editor::applyParagraphStyleToSelection):
              (WebCore::Editor::insertTextWithoutSendingTextEvent):
              (WebCore::Editor::insertLineBreak):
              (WebCore::Editor::insertParagraphSeparator):
              (WebCore::Editor::ignoreSpelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::markMisspellingsOrBadGrammar):
              (WebCore::Editor::rangeForPoint):
              * editing/EditorCommand.cpp:
              (WebCore::expandSelectionToGranularity):
              (WebCore::executeDeleteToMark):
              (WebCore::executeSelectToMark):
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment):
              * editing/Selection.cpp:
              (WebCore::Selection::firstRange):
              (WebCore::Selection::toNormalizedRange):
              * editing/Selection.h:
              * editing/SelectionController.h:
              (WebCore::SelectionController::toNormalizedRange):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/markup.cpp:
              (WebCore::createMarkup):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::createFromSelection):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::getRangeAt):
              (WebCore::DOMSelection::addRange):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::toString):
              * page/DragController.cpp:
              (WebCore::setSelectionToDragCaret):
              (WebCore::DragController::concludeEditDrag):
              (WebCore::DragController::startDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent):
              * page/Frame.cpp:
              (WebCore::Frame::selectedText):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::shouldDeleteSelection):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::selectionTextRects):
              (WebCore::Frame::findString):
              (WebCore::Frame::respondToChangedSelection):
              * platform/ContextMenu.cpp:
              (WebCore::selectionContainsPossibleWord):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50d7db0a
  24. 04 Feb, 2009 1 commit
    • weinig@apple.com's avatar
      2009-02-04 Sam Weinig <sam@webkit.org> · bcce4080
      weinig@apple.com authored
              Reviewed by David Hyatt.
      
              Add toRenderImage methods for casting RenderObjects to RenderImages.  The methods will assert if the object
              is not a RenderImage.  Also add a toRenderImage method that takes a RenderImage but returns void and that
              is unimplemented.  This method will catch anyone trying to do a cast when the object is already a RenderImage.
      
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::defaultEventHandler):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::attach):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::parseMappedAttribute):
              (WebCore::HTMLImageElement::attach):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::attach):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::attach):
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::attach):
              * loader/ImageLoader.cpp:
              (WebCore::ImageLoader::setImage):
              (WebCore::ImageLoader::updateFromElement):
              (WebCore::ImageLoader::notifyFinished):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              (WebCore::AccessibilityRenderObject::addChildren):
              * page/DragController.cpp:
              (WebCore::getCachedImage):
              (WebCore::getImage):
              * platform/mac/PasteboardMac.mm:
              (WebCore::Pasteboard::writeImage):
              * rendering/RenderImage.h:
              (WebCore::toRenderImage):
              * wml/WMLImageElement.cpp:
              (WebCore::WMLImageElement::parseMappedAttribute):
              (WebCore::WMLImageElement::attach):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcce4080
  25. 02 Feb, 2009 1 commit
    • ggaren@apple.com's avatar
      WebCore: · b6b2bfc9
      ggaren@apple.com authored
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * WebCore.base.exp: Renamed some exports.
              
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::createWindow):
              (windowProtoFuncOpen):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::submit):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::JSLocation::setHref):
              (WebCore::JSLocation::setProtocol):
              (WebCore::JSLocation::setHost):
              (WebCore::JSLocation::setHostname):
              (WebCore::JSLocation::setPort):
              (WebCore::JSLocation::setPathname):
              (WebCore::JSLocation::setSearch):
              (WebCore::JSLocation::setHash):
              (WebCore::JSLocation::assign): Treat any navigation that is not initiated
              by the user as a redirect from the perspective of global history.
      
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect
              chain.
      
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect):
              (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect):
              (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly,
              added yet another way to track redirect state during loading, since none
              of the others did what I wanted, and I didn't want to cause behavior
              changes in existing code.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              Stubbed out a client function to keep things building.
              
              * loader/FrameLoader.cpp:
              (WebCore::isBackForwardLoadType):
              (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect =>
              FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all
              the other meanings of "redirect" in the loading code.
      
              (WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
              redirect as a redirect from the perspective of global history.
      
              (WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
              parameter.
      
              (WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.
      
              (WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
              (WebCore::FrameLoader::loadURL):
              (WebCore::FrameLoader::load): Updated for rename and extra parameter.
      
              (WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
              in the DocumentLoader, so it's accessible to WebKit's global history code.
      
              (WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
              only has meaning to global history, and m_quickRedirectComing pertains
              to other kinds of history.
      
              (WebCore::FrameLoader::loadPostRequest):
              (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
              (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
              (WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.
              
              (WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
              navigations even if they don't create new history items, so we can track
              the redirect in the existing history item.
      
              * loader/FrameLoader.h: See above.
              
              * loader/FrameLoaderClient.h: New client interface used by
              FrameLoader::updateHistory* to record a redirect even if it doesn't create
              a new history item of its own.
      
              * loader/FrameLoaderTypes.h: See above.
              (WebCore::):
      
              * page/DragController.cpp:
              (WebCore::DragController::performDrag):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged): Updated for extra parameter.
      
      WebKit/gtk:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
              
              Track redirects in global history.
      
              Keep GTK building.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::createFrame):
              (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * History/WebHistory.mm:
              (-[WebHistoryPrivate dealloc]):
              (-[WebHistoryPrivate lastVisitedEntry]):
              (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history
              entry in case we're asked to add redirect information to it later.
      
              (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
              (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
              information in global history.
      
              * History/WebHistoryInternal.h:
              * WebCoreSupport/WebFrameLoaderClient.h: See above and below.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect
              information in global history.
      
              * WebView/WebFrame.mm:
              (-[WebFrame loadRequest:]):
              (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
              * WebView/WebFramePrivate.h: Updated for rename and extra parameter.
      
      WebKit/qt:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              Keep Qt building.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem):
              (WebCore::FrameLoaderClientQt::createFrame):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2009-02-02  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Track redirects in global history.
      
              * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::updateGlobalHistory):
              (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
              Store redirect information in global history.
      
              (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
      
              * WebCoreSupport/WebFrameLoaderClient.h: See above.
      
              * WebFrame.cpp:
              (WebFrame::loadRequest):
              (WebFrame::loadData): Updated for extra parameter.
      
              * WebHistory.cpp:
              (WebHistory::visitedURL):
              (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
              information in global history.
      
              * WebHistory.h: See above.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b2bfc9
  26. 12 Jan, 2009 1 commit
    • darin@apple.com's avatar
      2009-01-11 Darin Adler <darin@apple.com> · faced26e
      darin@apple.com authored
              Reviewed by Oliver Hunt.
      
              Bug 23102: turn on unused parameter warnings in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=23102
      
              Fourth step: Remove arguments entirely in the many cases where they are not
              needed at all. This step is a little less mechanical than the earlier ones.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
              the regular expression, since we already specify a-zA-Z in our expression.
      
              * dom/Document.cpp:
              (WebCore::Document::databaseThread): Don't pass in the document when creating
              a DatabaseThread.
      
              * dom/Element.cpp:
              (WebCore::Element::createRareData): Don't pass the element when creating an
              ElementRareData.
              (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
              (WebCore::Element::recalcStyle): Ditto.
      
              * dom/ElementRareData.h: Remove the unused Element* from the constructor and
              the resetComputedStyle function.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
              (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
              (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
              * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
      
              * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
              start and end arguments.
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
              and end to pushDownTextDecorationStyleAroundNode.
      
              * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
              unused start and end arguments from pushDownTextDecorationStyleAroundNode.
      
              * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
      
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute): Removed unused Document* argument.
              (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
      
              * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
      
              * page/DragController.cpp:
              (WebCore::DragController::dragIsMove): Removed unused DragData argument.
              (WebCore::DragController::performDrag): Call concludeEditDrag rather than
              concludeDrag.
              (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
              (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
              should only be called for edit drags. Removed the action mask argument. Also
              changed dragIsMove call sites to not pass dragData.
      
              * page/DragController.h: Updated for above changes and tweaked comment format.
      
              * page/Frame.cpp:
              (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
      
              * page/mac/AccessibilityObjectWrapper.mm:
              (AXAttributeStringSetHeadingLevel): Removed unused object argument.
              (AXAttributedStringAppendText): Ditto.
              (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
      
              * page/mac/FrameMac.mm:
              (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
              when creating regular expressions for clarity. Call match instead of search,
              since both do the same thing except for with negative start offsets, and none
              used here are negative.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * platform/graphics/SegmentedFontData.cpp:
              (WebCore::SegmentedFontData::containsCharacter): Added.
              (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
              instead of just the first one, using containsCharacter.
      
              * platform/graphics/SegmentedFontData.h: Made more members private.
              Added containsCharacter function member.
      
              * platform/mac/DragImageMac.mm:
              (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
              DragImageRef for clarity, since this is platform-specific code.
              (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
              variable warning.
              (WebCore::scaleDragImage): Ditto.
              (WebCore::dissolveDragImageToFraction): Ditto.
              (WebCore::createDragImageFromImage): Ditto.
              (WebCore::createDragImageIconForCachedImage): Ditto.
      
              * platform/mac/WebFontCache.mm:
              (acceptableChoice): Removed the unused weight-related arguments.
              (betterChoice): Ditto.
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
      
              * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
              because we'd rather get a link error rather than a runtime error if we use it
              for anything, and right now it's not used.
      
              * platform/text/RegularExpression.cpp: Removed unused private data,
              including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
              and lastMatchPos. Made the RegularExpression::Private::regex be private
              and use an accessor function to get at it.
              (WebCore::RegularExpression::RegularExpression): Removed the const char* version
              of the constructor because it's not any more efficient. Changed the boolean
              constructor argument to use TextCaseSensitivity instead to make it less likely
              we'll use it wrong.
              (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
              just use plain old assignment on it. The only reason we do this instead of using
              the compiler generated assignment operator is that we want the Private structure
              to be internal to the .cpp file.
              (WebCore::RegularExpression::match): Added a null check so we won't crash if
              we fail to compile the regular expression. Removed the code to handle multiple
              match strings, since that was unused.
      
              * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
              TextCaseSensitivity and not have a default value. Removed the default constructor,
              and the pattern, match, and pos functions.
      
              * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
              Page.h, because we should eventually use it in all the places where we have
              an argument to control case sensitivity, starting with the functions in this
              class.
      
              * platform/text/mac/ShapeArabic.c:
              (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
              this is code borrowed from ICU, this seems like a simple safe change to make.
              (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
      
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::RenderPath): Removed the unused style argument.
              Also removed the type check. The argument already has the correct type,
              so it's not helpful to upcast it and then check its type again, unless
              we have some reason to believe the type is not reliable. And we don't.
      
              * rendering/RenderPath.h: Removed the RenderStyle* argument to the
              constructor. Also removed the explicit declaration of the destructor.
              It's not helpful or needed.
      
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
              make it clear that just returning an empty rect is not a good implementation.
              Removed the argument names to get rid of the warning.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::printBorderStyle): Removed the unused RenderObject argument.
              (WebCore::operator<<): Updated for the change to printBorderStyle function.
      
              * storage/DatabaseThread.cpp:
              (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
              * storage/DatabaseThread.h: Ditto.
      
              * storage/LocalStorage.cpp:
              (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
              * storage/LocalStorage.h: Ditto.
      
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
              code location to dispatchGenericEvent.
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::dispatchEvent): Ditto.
      
              * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
              (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
              the RenderPath constructor.
      
              * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
      
              * xml/XSLTProcessor.cpp:
              (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
              (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faced26e
  27. 11 Jan, 2009 1 commit
  28. 10 Dec, 2008 1 commit
    • alice.liu@apple.com's avatar
      WebCore: · c408431d
      alice.liu@apple.com authored
      2008-12-10  Alice Liu  <alice.liu@apple.com>
      
              fixed https://bugs.webkit.org/show_bug.cgi?id=20685
      
              Reviewed by Darin Adler.
      
              Manual test case is manual-tests/drag-image-to-desktop.html
      
              Added new files to projects
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
      
              * page/DragController.cpp:
              (WebCore::DragController::startDrag):
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedImageMIMETypes):
              (WebCore::initializeSupportedImageMIMETypesForEncoding):
      
              These changes add a method to obtain the extension for an image
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::filenameExtension):
              * platform/graphics/BitmapImage.h:
              * platform/graphics/Image.h:
              (WebCore::Image::filenameExtension):
              * platform/graphics/ImageSource.h:
              * platform/graphics/cairo/ImageSourceCairo.cpp:
              (WebCore::ImageSource::filenameExtension):
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::filenameExtension):
      
              These changes added a utility that returns the preferred extension for a UTI
              * platform/graphics/cg/ImageSourceCG.h: Added.
              * platform/graphics/cg/ImageSourceCGMac.mm: Added.
              (WebCore::MIMETypeForImageSourceType):
              (WebCore::preferredExtensionForImageSourceType):
              * platform/graphics/cg/ImageSourceCGWin.cpp: Added.
              (WebCore::MIMETypeForImageSourceType):
              (WebCore::preferredExtensionForImageSourceType):
      
              * platform/mac/MIMETypeRegistryMac.mm:
              moved getMIMETypeForUTI to ImageSourceCGMac.mm
      
              Ask image for its file extension instead of relying on MIME type and file path
              * platform/win/ClipboardWin.cpp:
              (WebCore::createGlobalImageFileDescriptor):
      
              Remove extraneous code from getPreferredExtensionForMIMEType.
              Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
              * platform/win/MIMETypeRegistryWin.cpp:
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
      
      WebKit/mac:
      
      2008-12-10  Alice Liu  <alice.liu@apple.com>
      
              fixed https://bugs.webkit.org/show_bug.cgi?id=20685
      
              Reviewed by Darin Adler.
      
              * Misc/WebNSPasteboardExtras.mm:
              Ask image for its file extension instead of falling back on MIME type and file path.
              Also moved this code to before setting the pasteboard data so as not to set any if
              no extension can be determined.
              (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
      
              * WebView/WebHTMLView.mm:
              Fixed a separate but related long-standing bug of how the filename for the promised
              drag data is determined by asking the image for a proper file extension. 
              (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@39185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c408431d
  29. 26 Nov, 2008 1 commit
    • darin@chromium.org's avatar
      2008-10-31 Tony Chang <tony@chromium.org> · 89e50aab
      darin@chromium.org authored
              Reviewed by Oliver Hunt.
      
              Add a new platform specific method cleanupAfterSystemDrag
              that platforms can ue to clean up drag state after a
              system drag.  Use this method on PLAFORM(MAC).
              https://bugs.webkit.org/show_bug.cgi?id=21956
      
              * ChangeLog:
              * page/DragController.cpp:
              (WebCore::DragController::doSystemDrag):
              * page/DragController.h:
              * page/gtk/DragControllerGtk.cpp:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/mac/DragControllerMac.mm:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/qt/DragControllerQt.cpp:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/win/DragControllerWin.cpp:
              (WebCore::DragController::cleanupAfterSystemDrag):
              * page/wx/DragControllerWx.cpp:
            (WebCore::DragController::cleanupAfterSystemDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89e50aab
  30. 24 Nov, 2008 1 commit
  31. 24 Oct, 2008 1 commit
    • adele@apple.com's avatar
      WebCore: · 497541bd
      adele@apple.com authored
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
              This is consistent with the direction HTML5 will be going in the future.
      
              The initial implementation here will show "n files" as the text next to the control when multiple files are selected.  You can view
              the individual files in a tooltip for now.  Improvements to this control will come later.  
      
              Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.  
              These FileList Files can also be sent in an XMLHTTPRequest.
      
              * manual-tests/post-multi-file-upload.html: Added.
              * manual-tests/resources/multiFileResources: Added.
              * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
              * manual-tests/resources/multiFileResources/testFile1.html: Added.
              * manual-tests/resources/multiFileResources/testFile2.html: Added.
              * manual-tests/resources/multiFileResources/testFile3.html: Added.
      
              * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
              (WebCore::HTMLInputElement::value): Added comments.  The HTML5 spec says that value shouldn't apply for the file upload control,
              but we don't want to break the behavior for existing websites that may rely on this.
              (WebCore::HTMLInputElement::setValue): ditto.
              (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
              (WebCore::HTMLInputElement::setFileListFromRenderer): Added. 
              * html/HTMLInputElement.h:
      
              * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
      
              * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
      
              * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
              (WebCore::FileChooser::FileChooser):
              (WebCore::FileChooser::create):
              (WebCore::FileChooser::clear):
              (WebCore::FileChooser::chooseFile):
              (WebCore::FileChooser::chooseFiles):
              (WebCore::FileChooser::chooseIcon):
              * platform/FileChooser.h:
              (WebCore::FileChooser::filePaths):
              (WebCore::FileChooser::allowsMultipleFiles):
      
              * platform/graphics/Icon.h:
              * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
              * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
              * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
              * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
      
              * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):  Updated to deal with new filenames vector.
              * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
              * platform/qt/FileChooserQt.cpp:
              (WebCore::FileChooser::openFileChooser):
              (WebCore::FileChooser::basenameForWidth):
              * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
      
              * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
              Removed unnecessary assertion.  This can get hit when connectionDidFinishLoading and cancel
              both get called for the same ResourceHandle.  This getting called twice has no negative effect.
      
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::valueChanged):  Calls setFileListFromRenderer.
              (WebCore::RenderFileUploadControl::allowsMultipleFiles):  Added.
              (WebCore::RenderFileUploadControl::updateFromElement):  Uses the new filenames call from FileChooser.
              (WebCore::RenderFileUploadControl::receiveDroppedFiles):  Updated to support multiple files.
              * rendering/RenderFileUploadControl.h:
      
      WebKit/mac:
      
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
              (-[WebOpenPanelResultListener chooseFilenames:]):
              * WebView/WebUIDelegate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      497541bd
  32. 12 Oct, 2008 1 commit
  33. 07 Jul, 2008 1 commit
  34. 16 Jun, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 60d3e9f9
      darin@apple.com authored
      2008-06-15  Darin Adler  <darin@apple.com>
      
              - give Frame object functions shorter names: scriptProxy() -> script(),
                selectionController() -> selection(), animationController() -> animation()
      
              * WebCore.base.exp:
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              (WebCore::JSCustomSQLStatementCallback::handleEvent):
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              (WebCore::JSCustomSQLTransactionCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::JSCustomVoidCallback::handleEvent):
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebC...
      60d3e9f9
  35. 14 Jun, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 48ac3c40
      darin@apple.com authored
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebCore.base.exp:
              * bindings/js/JSSVGMatrixCustom.cpp:
              (WebCore::JSSVGMatrix::multiply):
              (WebCore::JSSVGMatrix::inverse):
              (WebCore::JSSVGMatrix::translate):
              (WebCore::JSSVGMatrix::scale):
              (WebCore::JSSVGMatrix::scaleNonUniform):
              (WebCore::JSSVGMatrix::rotate):
              (WebCore::JSSVGMatrix::rotateFromVector):
              (WebCore::JSSVGMatrix::flipX):
              (WebCore::JSSVGMatrix::flipY):
              (WebCore::JSSVGMatrix::skewX):
              (WebCore::JSSVGMatrix::skewY):
              * bindings/js/JSSVGPODTypeWrapper.h:
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadWrite::JSSVGPODTypeWrapperCreatorReadWrite):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::create):
              (WebCore::JSSVGPODTypeWrapperCreatorReadOnly::JSSVGPODTypeWrapperCreatorReadOnly):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::create):
              (WebCore::JSSVGPODTypeWrapperCreatorForList::JSSVGPODTypeWrapperCreatorForList):
              (WebCore::JSSVGPODTypeWrapperCache::lookupOrCreateWrapper):
              (WebCore::JSSVGPODTypeWrapperCache::forgetWrapper):
              * bindings/js/JSSVGPointListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGPointList::clear):
              (WebCore::JSSVGPointList::initialize):
              (WebCore::JSSVGPointList::getItem):
              (WebCore::JSSVGPointList::insertItemBefore):
              (WebCore::JSSVGPointList::replaceItem):
              (WebCore::JSSVGPointList::removeItem):
              (WebCore::JSSVGPointList::appendItem):
              * bindings/js/JSSVGTransformListCustom.cpp:
              (WebCore::finishGetter):
              (WebCore::finishSetter):
              (WebCore::finishSetterReadOnlyResult):
              (WebCore::JSSVGTransformList::clear):
              (WebCore::JSSVGTransformList::initialize):
              (WebCore::JSSVGTransformList::getItem):
              (WebCore::JSSVGTransformList::insertItemBefore):
              (WebCore::JSSVGTransformList::replaceItem):
              (WebCore::JSSVGTransformList::removeItem):
              (WebCore::JSSVGTransformList::appendItem):
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::CSSFontSelector):
              (WebCore::CSSFontSelector::~CSSFontSelector):
              * css/CSSFontSelector.h:
              (WebCore::CSSFontSelector::create):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::applyProperty):
              * dom/Attribute.cpp:
              (WebCore::Attribute::clone):
              * dom/Attribute.h:
              (WebCore::Attribute::create):
              (WebCore::Attribute::Attribute):
              * dom/BeforeTextInsertedEvent.h:
              (WebCore::BeforeTextInsertedEvent::create):
              * dom/BeforeUnloadEvent.h:
              (WebCore::BeforeUnloadEvent::create):
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::dispatchModifiedEvent):
              * dom/ClipboardEvent.cpp:
              (WebCore::ClipboardEvent::ClipboardEvent):
              * dom/ClipboardEvent.h:
              (WebCore::ClipboardEvent::create):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::removeChild):
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/Document.cpp:
              (WebCore::Document::createTextNode):
              (WebCore::Document::createComment):
              (WebCore::Document::createCDATASection):
              (WebCore::Document::createProcessingInstruction):
              (WebCore::Document::createEntityReference):
              (WebCore::Document::createEditingTextNode):
              (WebCore::Document::createEvent):
              (WebCore::Document::createAttributeNS):
              (WebCore::Document::finishedParsing):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::createAttribute):
              * dom/Element.h:
              * dom/Event.cpp:
              (WebCore::Event::Event):
              * dom/Event.h:
              (WebCore::Event::create):
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
              (WebCore::EventTargetNode::dispatchWindowEvent):
              (WebCore::EventTargetNode::dispatchUIEvent):
              (WebCore::EventTargetNode::dispatchKeyEvent):
              (WebCore::EventTargetNode::dispatchMouseEvent):
              (WebCore::EventTargetNode::dispatchWheelEvent):
              (WebCore::EventTargetNode::dispatchHTMLEvent):
              (WebCore::EventTargetNode::dispatchProgressEvent):
              (WebCore::EventTargetNode::dispatchStorageEvent):
              * dom/KeyboardEvent.h:
              (WebCore::KeyboardEvent::create):
              * dom/MappedAttribute.cpp:
              (WebCore::MappedAttribute::clone):
              * dom/MappedAttribute.h:
              (WebCore::MappedAttribute::create):
              (WebCore::MappedAttribute::setDecl):
              (WebCore::MappedAttribute::MappedAttribute):
              * dom/MessageEvent.cpp:
              (WebCore::MessageEvent::MessageEvent):
              * dom/MessageEvent.h:
              (WebCore::MessageEvent::create):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              (WebCore::MouseEvent::initMouseEvent):
              * dom/MouseEvent.h:
              (WebCore::MouseEvent::create):
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              * dom/MouseRelatedEvent.h:
              * dom/MutationEvent.cpp:
              (WebCore::MutationEvent::MutationEvent):
              (WebCore::MutationEvent::initMutationEvent):
              * dom/MutationEvent.h:
              (WebCore::MutationEvent::create):
              * dom/OverflowEvent.h:
              (WebCore::OverflowEvent::create):
              * dom/ProgressEvent.h:
              (WebCore::ProgressEvent::create):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::getMappedAttributeDecl):
              (WebCore::StyledElement::setMappedAttributeDecl):
              (WebCore::StyledElement::removeMappedAttributeDecl):
              (WebCore::StyledElement::createAttribute):
              * dom/StyledElement.h:
              * dom/TextEvent.cpp:
              (WebCore::TextEvent::TextEvent):
              (WebCore::TextEvent::initTextEvent):
              * dom/TextEvent.h:
              (WebCore::TextEvent::create):
              * dom/UIEvent.cpp:
              (WebCore::UIEvent::UIEvent):
              (WebCore::UIEvent::initUIEvent):
              * dom/UIEvent.h:
              (WebCore::UIEvent::create):
              * dom/UIEventWithKeyState.h:
              (WebCore::UIEventWithKeyState::ctrlKey):
              (WebCore::UIEventWithKeyState::shiftKey):
              (WebCore::UIEventWithKeyState::altKey):
              (WebCore::UIEventWithKeyState::metaKey):
              (WebCore::UIEventWithKeyState::UIEventWithKeyState):
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
              (WebCore::WheelEvent::initWheelEvent):
              * dom/WheelEvent.h:
              (WebCore::WheelEvent::create):
              * editing/AppendNodeCommand.cpp:
              (WebCore::AppendNodeCommand::AppendNodeCommand):
              * editing/AppendNodeCommand.h:
              (WebCore::AppendNodeCommand::create):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/ApplyStyleCommand.h:
              (WebCore::ApplyStyleCommand::create):
              * editing/BreakBlockquoteCommand.h:
              (WebCore::BreakBlockquoteCommand::create):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::applyStyle):
              (WebCore::CompositeEditCommand::applyStyledElement):
              (WebCore::CompositeEditCommand::removeStyledElement):
              (WebCore::CompositeEditCommand::insertParagraphSeparator):
              (WebCore::CompositeEditCommand::insertLineBreak):
              (WebCore::CompositeEditCommand::insertNodeBefore):
              (WebCore::CompositeEditCommand::appendNode):
              (WebCore::CompositeEditCommand::removeNode):
              (WebCore::CompositeEditCommand::removeNodePreservingChildren):
              (WebCore::CompositeEditCommand::splitTextNode):
              (WebCore::CompositeEditCommand::splitElement):
              (WebCore::CompositeEditCommand::mergeIdenticalElements):
              (WebCore::CompositeEditCommand::wrapContentsInDummySpan):
              (WebCore::CompositeEditCommand::splitTextNodeContainingElement):
              (WebCore::CompositeEditCommand::joinTextNodes):
              (WebCore::CompositeEditCommand::inputText):
              (WebCore::CompositeEditCommand::insertTextIntoNode):
              (WebCore::CompositeEditCommand::deleteTextFromNode):
              (WebCore::CompositeEditCommand::replaceTextInNode):
              (WebCore::CompositeEditCommand::deleteSelection):
              (WebCore::CompositeEditCommand::removeCSSProperty):
              (WebCore::CompositeEditCommand::removeNodeAttribute):
              (WebCore::CompositeEditCommand::setNodeAttribute):
              (WebCore::CompositeEditCommand::appendBlockPlaceholder):
              (WebCore::CompositeEditCommand::insertBlockPlaceholder):
              (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::splitTreeToNode):
              * editing/CompositeEditCommand.h:
              (WebCore::CompositeEditCommand::isFirstCommand):
              * editing/CreateLinkCommand.h:
              (WebCore::CreateLinkCommand::create):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::deleteTarget):
              * editing/DeleteFromTextNodeCommand.cpp:
              (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * editing/DeleteFromTextNodeCommand.h:
              (WebCore::DeleteFromTextNodeCommand::create):
              * editing/DeleteSelectionCommand.h:
              (WebCore::DeleteSelectionCommand::create):
              * editing/EditCommand.h:
              (WebCore::SimpleEditCommand::SimpleEditCommand):
              * editing/Editor.cpp:
              (WebCore::Editor::deleteSelectionWithSmartDelete):
              (WebCore::Editor::replaceSelectionWithFragment):
              (WebCore::Editor::removeFormattingAndStyle):
              (WebCore::Editor::clearLastEditCommand):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              (WebCore::Editor::indent):
              (WebCore::Editor::outdent):
              (WebCore::dispatchEditableContentChangedEvents):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertFragment):
              (WebCore::executeCreateLink):
              (WebCore::executeFormatBlock):
              (WebCore::executeIndent):
              (WebCore::executeInsertOrderedList):
              (WebCore::executeInsertUnorderedList):
              (WebCore::executeOutdent):
              (WebCore::executeUnlink):
              * editing/FormatBlockCommand.h:
              (WebCore::FormatBlockCommand::create):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/IndentOutdentCommand.h:
              (WebCore::IndentOutdentCommand::create):
              * editing/InsertIntoTextNodeCommand.cpp:
              (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * editing/InsertIntoTextNodeCommand.h:
              (WebCore::InsertIntoTextNodeCommand::create):
              * editing/InsertLineBreakCommand.h:
              (WebCore::InsertLineBreakCommand::create):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h:
              (WebCore::InsertListCommand::create):
              * editing/InsertNodeBeforeCommand.cpp:
              (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
              * editing/InsertNodeBeforeCommand.h:
              (WebCore::InsertNodeBeforeCommand::create):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.h:
              (WebCore::InsertParagraphSeparatorCommand::create):
              * editing/InsertTextCommand.h:
              (WebCore::InsertTextCommand::create):
              * editing/JoinTextNodesCommand.cpp:
              (WebCore::JoinTextNodesCommand::JoinTextNodesCommand):
              * editing/JoinTextNodesCommand.h:
              (WebCore::JoinTextNodesCommand::create):
              * editing/MergeIdenticalElementsCommand.cpp:
              (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
              * editing/MergeIdenticalElementsCommand.h:
              (WebCore::MergeIdenticalElementsCommand::create):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/MoveSelectionCommand.h:
              (WebCore::MoveSelectionCommand::create):
              * editing/RemoveCSSPropertyCommand.cpp:
              (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
              * editing/RemoveCSSPropertyCommand.h:
              (WebCore::RemoveCSSPropertyCommand::create):
              * editing/RemoveFormatCommand.h:
              (WebCore::RemoveFormatCommand::create):
              * editing/RemoveNodeAttributeCommand.cpp:
              (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
              * editing/RemoveNodeAttributeCommand.h:
              (WebCore::RemoveNodeAttributeCommand::create):
              * editing/RemoveNodeCommand.cpp:
              (WebCore::RemoveNodeCommand::RemoveNodeCommand):
              * editing/RemoveNodeCommand.h:
              (WebCore::RemoveNodeCommand::create):
              * editing/RemoveNodePreservingChildrenCommand.cpp:
              (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
              (WebCore::RemoveNodePreservingChildrenCommand::doApply):
              * editing/RemoveNodePreservingChildrenCommand.h:
              (WebCore::RemoveNodePreservingChildrenCommand::create):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtStart):
              (WebCore::ReplacementFragment::hasInterchangeNewlineAtEnd):
              (WebCore::ReplacementFragment::ReplacementFragment):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::ReplaceSelectionCommand::create):
              * editing/SetNodeAttributeCommand.cpp:
              (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand):
              * editing/SetNodeAttributeCommand.h:
              (WebCore::SetNodeAttributeCommand::create):
              * editing/SplitElementCommand.cpp:
              (WebCore::SplitElementCommand::SplitElementCommand):
              * editing/SplitElementCommand.h:
              (WebCore::SplitElementCommand::create):
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::SplitTextNodeCommand):
              * editing/SplitTextNodeCommand.h:
              (WebCore::SplitTextNodeCommand::create):
              * editing/SplitTextNodeContainingElementCommand.cpp:
              (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              * editing/SplitTextNodeContainingElementCommand.h:
              (WebCore::SplitTextNodeContainingElementCommand::create):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertLineBreak):
              (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
              (WebCore::TypingCommand::insertParagraphSeparator):
              (WebCore::TypingCommand::insertTextRunWithoutNewlines):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
              (WebCore::TypingCommand::smartDelete):
              * editing/UnlinkCommand.h:
              (WebCore::UnlinkCommand::create):
              * editing/WrapContentsInDummySpanCommand.cpp:
              (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
              * editing/WrapContentsInDummySpanCommand.h:
              (WebCore::WrapContentsInDummySpanCommand::create):
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::additionalAttributeStyleDecls):
              (WebCore::HTMLTableElement::addSharedCellBordersDecl):
              (WebCore::HTMLTableElement::addSharedCellPaddingDecl):
              (WebCore::HTMLTableElement::addSharedGroupDecls):
              * html/HTMLTokenizer.cpp:
              (WebCore::Token::addAttribute):
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createContainingTable):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              (WebCore::HTMLViewSourceDocument::addLine):
              (WebCore::HTMLViewSourceDocument::addLink):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didOpenURL):
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::callListener):
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected):
              * page/DOMWindow.cpp:
              (WebCore::PostMessageTimer::PostMessageTimer):
              (WebCore::PostMessageTimer::fired):
              (WebCore::DOMWindow::postMessage):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::keyEvent):
              (WebCore::EventHandler::handleTextInputEvent):
              * page/Frame.cpp:
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::shouldClose):
              * page/FrameView.cpp:
              (WebCore::FrameView::updateOverflowStatus):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::currentKeyboardEvent):
              * page/mac/FrameMac.mm:
              * platform/DeprecatedValueListImpl.cpp:
              (WebCore::DeprecatedValueListImpl::Private::Private):
              (WebCore::DeprecatedValueListImpl::DeprecatedValueListImpl):
              (WebCore::DeprecatedValueListImpl::copyOnWrite):
              * platform/graphics/FontSelector.h:
              * platform/graphics/GlyphPageTreeNode.cpp:
              (WebCore::GlyphPageTreeNode::initializePage):
              * platform/graphics/GlyphPageTreeNode.h:
              (WebCore::GlyphPage::create):
              (WebCore::GlyphPage::GlyphPage):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::updateOverflowStatus):
              (WebCore::RenderLayer::updateReflectionStyle):
              * rendering/style/RenderStyle.h:
              (WebCore::TransformOperation::~TransformOperation):
              (WebCore::ScaleTransformOperation::create):
              (WebCore::ScaleTransformOperation::ScaleTransformOperation):
              (WebCore::RotateTransformOperation::create):
              (WebCore::RotateTransformOperation::RotateTransformOperation):
              (WebCore::SkewTransformOperation::create):
              (WebCore::SkewTransformOperation::operator==):
              (WebCore::SkewTransformOperation::SkewTransformOperation):
              (WebCore::TranslateTransformOperation::create):
              (WebCore::TranslateTransformOperation::operator==):
              (WebCore::TranslateTransformOperation::TranslateTransformOperation):
              (WebCore::MatrixTransformOperation::create):
              (WebCore::MatrixTransformOperation::MatrixTransformOperation):
              (WebCore::StyleReflection::create):
              (WebCore::StyleReflection::StyleReflection):
              * storage/StorageEvent.cpp:
              (WebCore::StorageEvent::StorageEvent):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.h:
              (WebCore::StorageEvent::create):
              (WebCore::StorageEvent::StorageEvent):
              * svg/SVGAngle.cpp:
              (WebCore::SVGAngle::SVGAngle):
              * svg/SVGAngle.h:
              (WebCore::SVGAngle::create):
              * svg/SVGAnimatedTemplate.h:
              (WebCore::SVGAnimatedTemplate::SVGAnimatedTemplate):
              (WebCore::lookupOrCreateWrapper):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::sendSVGLoadEventIfPossible):
              * svg/SVGElement.h:
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::SVGMarkerElement):
              (WebCore::SVGMarkerElement::parseMappedAttribute):
              (WebCore::SVGMarkerElement::setOrientToAngle):
              * svg/SVGMarkerElement.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::createSVGAngle):
              * svg/SVGSVGElement.h:
              * svg/SVGZoomEvent.h:
              (WebCore::SVGZoomEvent::create):
              * svg/graphics/SVGImage.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::callReadyStateChangeListener):
              (WebCore::XMLHttpRequest::dispatchProgressEvent):
              * xml/XMLHttpRequestProgressEvent.cpp:
              * xml/XMLHttpRequestProgressEvent.h:
              (WebCore::XMLHttpRequestProgressEvent::create):
              (WebCore::XMLHttpRequestProgressEvent::position):
              (WebCore::XMLHttpRequestProgressEvent::totalSize):
              (WebCore::XMLHttpRequestProgressEvent::XMLHttpRequestProgressEvent):
      
      WebKit/mac:
      
      2008-06-14  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam.
      
              - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
                start ref counts at 1 instead of 0 for speed
      
              * WebView/WebFrame.mm:
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ac3c40
  36. 18 Apr, 2008 1 commit
    • eric@webkit.org's avatar
      Reviewed by beth. · 25a1cdf3
      eric@webkit.org authored
              Rename Frame::renderer() to contentRenderer() and fix uses.
      
              * WebCore.base.exp:
              * editing/Editor.cpp:
              (WebCore::Editor::respondToChangedContents):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::gotoAnchor):
              * page/DragController.cpp:
              (WebCore::DragController::canProcessDrag):
              (WebCore::DragController::mayStartDragAtEventLocation):
              (WebCore::DragController::startDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::eventMayStartDrag):
              (WebCore::EventHandler::updateSelectionForMouseDrag):
              (WebCore::EventHandler::hitTestResultAtPoint):
              (WebCore::EventHandler::hoverTimerFired):
              (WebCore::EventHandler::handleDrag):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::contentRenderer):
              (WebCore::Frame::paint):
              (WebCore::Frame::markAllMatchesForText):
              (WebCore::Frame::documentAtPoint):
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::~FrameView):
              (WebCore::FrameView::adjustViewSize):
              (WebCore::FrameView::layout):
              (WebCore::FrameView::scheduleRelayoutOfSubtree):
              (WebCore::FrameView::needsLayout):
              (WebCore::FrameView::setNeedsLayout):
              (WebCore::FrameView::updateControlTints):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::nativeImageForCurrentFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25a1cdf3
  37. 10 Mar, 2008 1 commit
    • hausmann@webkit.org's avatar
      2008-03-07 Simon Hausmann <hausmann@webkit.org> · 9999bb88
      hausmann@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=16815
      
              Reviewed by Darin.
      
              Done with Lars.
      
      WebCore:
      
              Ported the manually written JS bindings of window.navigator,
              window.navigator.plugins and window.navigator.mimeTypes to
              auto-generated bindings.
      
              Moved the globally cached plugin and mimetype information to a
              per WebCore::Page shared PluginData structure.
      
              Implemented window.navigator.plugins.refresh() in a
              platform-independent way.
      
      LayoutTests:
      
              Added a testcase for http://bugs.webkit.org/show_bug.cgi?id=16815
      
      WebKit/qt:
      
              Replaced the QWebObjectPlugin interfaces with QWebPluginFactory.
      
      WebKit/mac:
      
              Simplified WebViewFactory's refreshPlugins method to only refresh the
              plugins and not reload the frames anymore since that's now done in a
              platform independent manner by WebCore::Page.
      
              Also removed the now unused pluginNameForMIMEType and
              pluginSupportsMIMEType methods.
      
      WebKitTools/DumpRenderTree/qt:
      
              Ported the netscape test plugin to QWebPluginFactory.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9999bb88