1. 14 Mar, 2010 2 commits
  2. 13 Mar, 2010 4 commits
    • eric@webkit.org's avatar
      2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com> · d3084ba2
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
              https://bugs.webkit.org/show_bug.cgi?id=36034
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::OpacityAnimationQt::applyFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3084ba2
    • eric@webkit.org's avatar
      2010-03-13 Kim Grönholm <kim.gronholm@nomovok.com> · 4fa02887
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] GraphicsLayer: Opacity transitions end with begin value
              https://bugs.webkit.org/show_bug.cgi?id=36019
      
              * platform/graphics/qt/GraphicsLayerQt.cpp:
              (WebCore::AnimationQt::updateCurrentTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fa02887
    • krit@webkit.org's avatar
      2010-03-13 Dirk Schulze <krit@webkit.org> · 4a4b9e4e
      krit@webkit.org authored
              No review, rolling out r55927.
              http://trac.webkit.org/changeset/55927
              https://bugs.webkit.org/show_bug.cgi?id=35793
      
              Breaks Gtk build bots.
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
              (WebCore::MediaPlayerPrivate::load):
              (WebCore::MediaPlayerPrivate::setPreload):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a4b9e4e
    • krit@webkit.org's avatar
      2010-03-12 Dirk Schulze <krit@webkit.org> · 65316421
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG Glyphs - transform path not context
              https://bugs.webkit.org/show_bug.cgi?id=36070
      
              SVGFont should transform the path of a glyph, not the context. Modifying
              the context causes wrong gradient transformations. This bug doesn't
              influence CG because we generally fill or stroke texts with a mask image.
              All other platforms provide a direct way to make the drawings.
      
              * svg/SVGFont.cpp:
              (WebCore::Font::drawTextUsingSVGFont):
      2010-03-12  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG Glyphs - transform path not context
              https://bugs.webkit.org/show_bug.cgi?id=36070
      
              Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%).
              They just need an update.
              Tests for the changes on other platforms than CG are
                  * svg/batik/text/textEffect.svg
                  * svg/batik/text/textEffect3.svg
                  * svg/W3C-SVG-1.1/pservers-grad-08-b.svg
      
              * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
              * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
              * platform/mac/svg/batik/text/textEffect-expected.checksum:
              * platform/mac/svg/batik/text/textEffect-expected.png:
              * platform/mac/svg/batik/text/textEffect3-expected.checksum:
              * platform/mac/svg/batik/text/textEffect3-expected.png:
              * platform/mac/svg/text/selection-doubleclick-expected.png:
              * platform/mac/svg/text/selection-tripleclick-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65316421
  3. 12 Mar, 2010 24 commits
    • bdakin@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen · e7bfed76
      bdakin@apple.com authored
      API naming is inconsistent
      -and corresponding-
      <rdar://problem/7729165>
      
      Reviewed by Simon Fraser.
      
      WebCore: 
      
      This patch changes all occurrences of "fullScreen" to the more 
      popular "fullscreen." webkitEnterFullScreen and 
      webkitExitFullScreen have been maintained for now for backwards 
      compatibility. 
      
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::webkitEnterFullscreen):
      (WebCore::HTMLVideoElement::webkitExitFullscreen):
      * html/HTMLVideoElement.h:
      (WebCore::HTMLVideoElement::webkitEnterFullScreen):
      (WebCore::HTMLVideoElement::webkitExitFullScreen):
      * html/HTMLVideoElement.idl:
      * platform/graphics/mac/MediaPlayerProxy.h:
      
      WebKit/mac: 
      
      This patch changes all occurrences of "fullScreen" to the more 
      popular "fullscreen."
      
      * Plugins/Hosted/NetscapePluginHostProxy.h:
      (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing):
      * Plugins/Hosted/NetscapePluginHostProxy.mm:
      (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
      (WebKit::NetscapePluginHostProxy::didEnterFullscreen):
      (WebKit::NetscapePluginHostProxy::didExitFullscreen):
      (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing):
      (WKPCSetFullscreenWindowIsShowing):
      * Plugins/Hosted/WebKitPluginClient.defs:
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
      (-[WebNetscapePluginView _createPlugin]):
      (-[WebNetscapePluginView _destroyPlugin]):
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
      
      WebKit/win: 
      
      This patch changes all occurrences of "fullScreen" to the more 
      popular "fullscreen."
      
      * FullscreenVideoController.cpp:
      (FullscreenVideoController::onMouseDown):
      (FullscreenVideoController::onMouseMove):
      (FullscreenVideoController::onMouseUp):
      * FullscreenVideoController.h:
      (FullscreenVideoController::fullscreenToHUDCoordinates):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7bfed76
    • jamesr@google.com's avatar
      2010-03-12 James Robinson <jamesr@chromium.org> · b095f1c0
      jamesr@google.com authored
              Reviewed by Adam Barth.
      
              Add virtual destructor to DOMWrapperWorld
              https://bugs.webkit.org/show_bug.cgi?id=36077
      
              DOMWrapperWorld is RefCounted<DOMWrapperWorld>.  IsolatedWorld
              inherits from DOMWrapperWorld and has member variables
              with destructors, so DOMWrapperWorld needs to have a declared virtual
              d'tor to ensure that its derived class's destructors are called.
      
              No new tests, no change in behavior
      
              * bindings/v8/DOMWrapperWorld.h:
              (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b095f1c0
    • barraclough@apple.com's avatar
      Bug 36075 - Clean up screwyness re static string impls & Identifiers. · c24293a1
      barraclough@apple.com authored
      Reviewed by Oliver Hunt.
      
      JavaScriptCore: 
      
      * API/JSClassRef.cpp:
      (OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer.  This is okay, since the null/empty strings are shared across all threads.
      * JavaScriptCore.exp:
      * runtime/Identifier.cpp:
      (JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor.
      (JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header.
      (JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago).
      * runtime/Identifier.h:
      (JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function.
      * runtime/UStringImpl.cpp:
      (JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting.
      * runtime/UStringImpl.h:
      (JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor.
      (JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor.
      (JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path).
      (JSC::UStringImpl::create): Add missing ASSERT.
      (JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor).
      
      WebCore: 
      
      * platform/text/StringImpl.cpp:
      (WebCore::StringImpl::~StringImpl): Add ASSERT
      (WebCore::StringImpl::sharedBuffer): Add ASSERT
      * platform/text/StringImpl.h:
      (WebCore::StringImpl::setHash): Add ASSERT
      (WebCore::StringImpl::isStatic): added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c24293a1
    • enrica@apple.com's avatar
      Content of 3D tests appears at the bottom right corner sometimes. · 401b2ab7
      enrica@apple.com authored
      <rdar://problem/7556244>
      <https://bugs.webkit.org/show_bug.cgi?id=36027>
      
      Reviewed by Simon Fraser.
      
      WebCore: 
      
      There were two problems to solve here:
      - the incorrect anchoring of the rootChildLayer that was causing the composited
        content to be positioned incorrectly
      - the failure to paint the non composited content into the backing store when
        animating composited content.
                
      The first problem has been solved by leaving the original anchor point for the
      rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers.
      The second problem has been solved leveraging the knowledge that WebView has of the dirty region
      of the backing store to pass this information to the layer renderer. This allows the renderer to force
      a paint into the backing store before moving to the compositing.
              
      Tests: compositing/geometry/horizontal-scroll-composited.html
             compositing/geometry/vertical-scroll-composited.html
      
      * manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test.
      * manual-tests/win/milliondollar.html: Added.
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag.
      (WebCore::WKCACFLayerRenderer::setScrollFrame): 
      (WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers.
      (WebCore::WKCACFLayerRenderer::setRootChildLayer):
      (WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy.
      (WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy.
      (WebCore::WKCACFLayerRenderer::resize):
      (WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store.
      * platform/graphics/win/WKCACFLayerRenderer.h:
      (WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added.
      
      WebKit/win: 
      
      See detailed comments in WebCore/ChangeLog.
      
      * WebView.cpp:
      (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
      (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
      backing store dirty region.
      (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
      (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
      (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
      We are passing width and height of the view content together with the offset for the scrolling.
      It was confusing to pass it all as a rectangle, when it is not a rectangle.
      
      LayoutTests: 
      
      * compositing/geometry/horizontal-scroll-composited.html: Added.
      * compositing/geometry/vertical-scroll-composited.html: Added.
      * compositing/resources/apple.jpg: Added.
      * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
      * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
      * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
      * platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
      * platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added.
      * platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401b2ab7
    • robert@webkit.org's avatar
      2010-03-12 Robert Hogan <robert@webkit.org> · 3fb2faa4
      robert@webkit.org authored
              Not reviewed, build fix.
      
              Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke
              the !ENABLE(DATABASE) build on all platforms when attempting to fix the
              --minimal build on Qt.
      
              Support for SQLite now seems to be non-negotiable for the Qt build but making
              it mandatory requires review, so re-break --minimal Qt build for now.
      
              Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073
      
              * page/GeolocationPositionCache.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb2faa4
    • mitz@apple.com's avatar
      <rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/ · 83571990
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35507
      
      Reviewed by Alexey Proskuryakov.
      
      * css/CSSImportRule.cpp:
      (WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
      <http://trac.webkit.org/changeset/48818> to detect the two variants of
      KHTMLFixes.css in @import rules as well as in <link> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83571990
    • barraclough@apple.com's avatar
      Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash · dc9d96ff
      barraclough@apple.com authored
      Reviewed by Geoff Garen.
      
      r55878 changed UStringImpl::empty()->characters() to be non-null,
      so TextBreakIteratorQt.cpp now should check the length of strings
      (previously was assuming all strings with a non-null data pointer
      had a length of at least 1).
      
      * platform/text/qt/TextBreakIteratorQt.cpp:
      (WebCore::wordBreakIterator):
      (WebCore::characterBreakIterator):
      (WebCore::lineBreakIterator):
      (WebCore::sentenceBreakIterator):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc9d96ff
    • krit@webkit.org's avatar
      2010-03-12 Dirk Schulze <krit@webkit.org> · ad448306
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG fallback color doesn't work for bogus gradients.
              https://bugs.webkit.org/show_bug.cgi?id=35479
      
              Use a given fallback color on ignored gradients if present. Gradients
              must be ignored, if one dimension of the objects boundingBox is zero.
      
              Test: svg/custom/gradient-with-1d-boundingbox.svg
      
              * svg/graphics/SVGPaintServer.cpp:
              (WebCore::SVGPaintServer::strokePaintServer):
              * svg/graphics/SVGPaintServerGradient.cpp:
              (WebCore::SVGPaintServerGradient::setup):
      2010-03-12  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG fallback color doesn't work for bogus gradients.
              https://bugs.webkit.org/show_bug.cgi?id=35479
      
              We now use a fallback color on ignored gradients for one dimensional objects,
              either a given fallback color or black as default.
              This causes a change of one LayoutTest, because it was done manually in the
              gradient PaintServer, without respecting a given fallback color.
      
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
              * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
              * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
              * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
              * svg/custom/gradient-with-1d-boundingbox.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad448306
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=36069 · 9f47d581
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Eliminate InlineRunBox.
      
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::adjustPosition):
      (WebCore::InlineFlowBox::paintFillLayer):
      (WebCore::InlineFlowBox::paintBoxDecorations):
      (WebCore::InlineFlowBox::paintMask):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::InlineFlowBox):
      (WebCore::InlineFlowBox::prevLineBox):
      (WebCore::InlineFlowBox::nextLineBox):
      (WebCore::InlineFlowBox::setNextLineBox):
      (WebCore::InlineFlowBox::setPreviousLineBox):
      * rendering/InlineRunBox.h: Removed.
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::InlineTextBox):
      (WebCore::InlineTextBox::prevTextBox):
      (WebCore::InlineTextBox::nextTextBox):
      (WebCore::InlineTextBox::setNextTextBox):
      (WebCore::InlineTextBox::setPreviousTextBox):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::destroy):
      (WebCore::RenderBlock::rightmostPosition):
      (WebCore::RenderBlock::leftmostPosition):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::destroy):
      (WebCore::RenderInline::absoluteRects):
      (WebCore::RenderInline::absoluteQuads):
      (WebCore::RenderInline::linesBoundingBox):
      (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
      (WebCore::RenderInline::addFocusRingRects):
      (WebCore::RenderInline::paintOutline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::localBoundingBox):
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::deleteLineBoxTree):
      (WebCore::RenderLineBoxList::extractLineBox):
      (WebCore::RenderLineBoxList::attachLineBox):
      (WebCore::RenderLineBoxList::removeLineBox):
      (WebCore::RenderLineBoxList::deleteLineBoxes):
      (WebCore::RenderLineBoxList::dirtyLineBoxes):
      (WebCore::RenderLineBoxList::paint):
      (WebCore::RenderLineBoxList::hitTest):
      (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
      (WebCore::RenderLineBoxList::checkConsistency):
      * rendering/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::absoluteRects):
      (WebCore::RenderSVGInline::absoluteQuads):
      * rendering/RenderSVGText.cpp:
      (WebCore::RenderSVGText::absoluteRects):
      (WebCore::RenderSVGText::absoluteQuads):
      (WebCore::RenderSVGText::objectBoundingBox):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::extractTextBox):
      (WebCore::RenderText::attachTextBox):
      (WebCore::RenderText::removeTextBox):
      (WebCore::RenderText::createInlineTextBox):
      (WebCore::RenderText::positionLineBox):
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox::nextRootBox):
      (WebCore::RootInlineBox::prevRootBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f47d581
    • kov@webkit.org's avatar
      2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · df1a34bb
      kov@webkit.org authored
              Reviewed by Eric Carlson.
      
              media/video-preload.html fails
              https://bugs.webkit.org/show_bug.cgi?id=35793
      
              Only effectively load, and start buffering when playing, or when
              the preload attribute is set.
      
              Test: media/video-preload.html
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
              (WebCore::MediaPlayerPrivate::load):
              (WebCore::MediaPlayerPrivate::commitLoad):
              (WebCore::MediaPlayerPrivate::prepareToPlay):
              (WebCore::MediaPlayerPrivate::setPreload):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df1a34bb
    • dimich@chromium.org's avatar
      Not reviewed, build fix. · 39cfce0a
      dimich@chromium.org authored
      Reverts 55920 and 55921. Landing for Jian Li.
      
      WebCore:
      
      * Android.derived.jscbindings.mk:
      * Android.derived.v8bindings.mk:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMFormDataCustom.cpp: Removed.
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::send):
      * bindings/scripts/CodeGeneratorJS.pm:
      * bindings/v8/V8Index.h:
      * bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::sendCallback):
      * html/DOMFormData.idl: Removed.
      * page/DOMWindow.idl:
      
      LayoutTests:
      
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/Window/window-property-descriptors-expected.txt:
      * fast/dom/constructed-objects-prototypes-expected.txt:
      * fast/dom/prototype-inheritance-2-expected.txt:
      * fast/dom/prototype-inheritance-expected.txt:
      * fast/js/global-constructors-expected.txt:
      * http/tests/local/resources/send-form-data.js: Removed.
      * http/tests/local/send-form-data-expected.txt: Removed.
      * http/tests/local/send-form-data.html: Removed.
      * http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
      * platform/gtk/Skipped:
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/Skipped:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-expected.txt:
      * platform/qt/fast/js/global-constructors-expected.txt:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39cfce0a
    • jpetsovits@rim.com's avatar
      2010-03-12 Jakob Petsovits <jpetsovits@rim.com> · 6c324697
      jpetsovits@rim.com authored
              Reviewed by Dirk Schulze.
      
              [OpenVG] Add support for drawing text to PainterOpenVG
              https://bugs.webkit.org/show_bug.cgi?id=35581
      
              Doesn't come with any actual font classes, as OpenVG
              by itself doesn't provide any access to platform fonts
              but just the means to draw glyphs that have been loaded
              manually before.
      
              * platform/graphics/openvg/PainterOpenVG.cpp:
              (WebCore::PlatformPainterState::PlatformPainterState):
              (WebCore::PlatformPainterState::copyPaintState):
              (WebCore::PainterOpenVG::textDrawingMode):
              (WebCore::PainterOpenVG::setTextDrawingMode):
              (WebCore::PainterOpenVG::drawText):
              * platform/graphics/openvg/PainterOpenVG.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c324697
    • jpetsovits@rim.com's avatar
      2010-03-12 Jakob Petsovits <jpetsovits@rim.com> · 5cfb2d7b
      jpetsovits@rim.com authored
              Reviewed by Dirk Schulze.
      
              [OpenVG] Use masks to implement non-rectilinear clipping
              https://bugs.webkit.org/show_bug.cgi?id=35544
      
              Requires some additional context switching logic to
              make sure the right context is current when dealing
              with the mask, because we don't store it by ourselves.
      
              Initial version of this code was written by
              Eli Fidler <efidler@rim.com>, I did a couple of
              bug fixes and efficiency improvements since then.
      
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::clipPath):
              (WebCore::GraphicsContext::clip):
              (WebCore::GraphicsContext::clipOut):
              (WebCore::GraphicsContext::clipOutEllipseInRect):
              (WebCore::GraphicsContext::addInnerRoundedRectClip):
              * platform/graphics/openvg/PainterOpenVG.cpp:
              (WebCore::PlatformPainterState::PlatformPainterState):
              (WebCore::PlatformPainterState::~PlatformPainterState):
              (WebCore::PlatformPainterState::maskingEnabled):
              (WebCore::PlatformPainterState::applyState):
              (WebCore::PlatformPainterState::saveMaskIfNecessary):
              (WebCore::PainterOpenVG::intersectClipRect):
              (WebCore::PainterOpenVG::clipPath):
              (WebCore::PainterOpenVG::save):
              * platform/graphics/openvg/PainterOpenVG.h:
              (WebCore::PainterOpenVG::):
              * platform/graphics/openvg/SurfaceOpenVG.cpp:
              (WebCore::SurfaceOpenVG::makeCurrent):
              (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
              * platform/graphics/openvg/SurfaceOpenVG.h:
              (WebCore::SurfaceOpenVG::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cfb2d7b
    • jianli@chromium.org's avatar
      [v8] Add V8 bindings for DOMFormData. · 00ffa87a
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36026
      
      Reviewed by Nate Chapin.
      
      Test: http/tests/local/send-form-data.html
      
      * WebCore.gypi:
      * bindings/v8/V8Index.h:
      * bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
      (WebCore::V8DOMFormData::appendCallback):
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::sendCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00ffa87a
    • jianli@chromium.org's avatar
      WebCore: Add DOMFormData.idl to expose FormData interface. · 9f776cb4
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36024
      
      Reviewed by Sam Weinig.
      
      The implementation is based on XMLHttpRequest 2 spec:
      http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
      
      Test: http/tests/local/send-form-data.html
      
      * Android.derived.jscbindings.mk:
      * Android.derived.v8bindings.mk:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.am:
      * WebCore.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMFormDataCustom.cpp: Added.
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::send):
      * bindings/scripts/CodeGeneratorJS.pm:
      * html/DOMFormData.idl: Added.
      * page/DOMWindow.idl:
      
      LayoutTests: Add DOMFormData.idl to expose FormData interface
      https://bugs.webkit.org/show_bug.cgi?id=36024
      
      Reviewed by Sam Weinig.
      
      Add a layout test to test sending FormData via XMLHttpRequest. Also
      changed all test results that are affected by exposing FormData.
      
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/Window/window-property-descriptors-expected.txt:
      * fast/dom/constructed-objects-prototypes-expected.txt:
      * fast/dom/prototype-inheritance-2-expected.txt:
      * fast/dom/prototype-inheritance-expected.txt:
      * fast/js/global-constructors-expected.txt:
      * http/tests/local/resources/send-form-data.js: Added.
      * http/tests/local/send-form-data-expected.txt: Added.
      * http/tests/local/send-form-data.html: Added.
      * http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
      * platform/gtk/Skipped:
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/Skipped:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-expected.txt:
      * platform/qt/fast/js/global-constructors-expected.txt:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f776cb4
    • jpetsovits@rim.com's avatar
      2010-03-12 Jakob Petsovits <jpetsovits@rim.com> · bbc48b80
      jpetsovits@rim.com authored
              Reviewed by Dirk Schulze.
      
              [OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
              https://bugs.webkit.org/show_bug.cgi?id=35538
      
              SurfaceOpenVG can now not only encapsulate pbuffer
              and window surfaces but also VGImage-based ones.
      
              * platform/graphics/openvg/EGLDisplayOpenVG.cpp:
              (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
              * platform/graphics/openvg/EGLDisplayOpenVG.h:
              * platform/graphics/openvg/SurfaceOpenVG.cpp:
              (WebCore::SurfaceOpenVG::SurfaceOpenVG):
              * platform/graphics/openvg/SurfaceOpenVG.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbc48b80
    • eric@webkit.org's avatar
      2010-03-12 Alpha Lam <hclam@chromium.org> · 46d3d32f
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              HTMLMediaElement crash when it is used after resource loading is canceled.
              https://bugs.webkit.org/show_bug.cgi?id=35992
      
              Adding a test to access the duration property of a video element after
              resource loading was canceled.
      
              * http/tests/media/video-cancel-load-expected.txt: Added.
              * http/tests/media/video-cancel-load.html: Added.
      2010-03-12  Alpha Lam  <hclam@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Fix a crash when resource loading of media element is canceled.
              https://bugs.webkit.org/show_bug.cgi?id=35992
      
              Use of HTMLMediaElement::duration() after resource loading was canceled
              will cause a crash. This is because HTMLMediaElement::m_player is used
              when NULL.
              Test: http/tests/media/video-cancel-load.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::duration):
              Avoid calling to m_player when it is null.
              (WebCore::HTMLMediaElement::userCancelledLoad):
              Set m_readyState to HAVE_NOTHING.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46d3d32f
    • mitz@apple.com's avatar
      <rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory · 6cfb0bee
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=20069
      
      Reviewed by Darin Adler.
      
      No test added, since with the CSS variables feature disabled, the pointer
      to the freed memory is never dereferenced.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
      a static table.
      (WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cfb0bee
    • mitz@apple.com's avatar
      Build fix. · 96f79664
      mitz@apple.com authored
      * platform/chromium/PlatformKeyboardEventChromium.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96f79664
    • mitz@apple.com's avatar
      <rdar://problem/7694674> Hover states not updated when overflow section... · b5a56888
      mitz@apple.com authored
      <rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
      https://bugs.webkit.org/show_bug.cgi?id=35949
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/events/overflow-scroll-fake-mouse-move.html
      
      Soon after an overflow section scrolls under the mouse pointer, dispatch
      a fake mouse move event. This is similar to how frame scrolling is handled
      in WebKit, and has the effect of updating hover state, dispatching DOM mouse
      events, and updating the tool tip.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
      (WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
      (WebCore::EventHandler::clear): Stop the timer.
      (WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
      move events.
      (WebCore::EventHandler::handleMouseMoveEvent): Ditto.
      (WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
      is in the passed-in quad, ensure that a fake mouse move event is scheduled
      to fire soon.
      (WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
      (WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
      PlatformMouseEvent with the current mouse location, modifier key state and
      time stamp and calls mouseMoved().
      * page/EventHandler.h:
      * platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
      * platform/android/KeyEventAndroid.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
      * platform/brew/PlatformKeyboardEventBrew.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * platform/chromium/PlatformKeyboardEventChromium.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
      * platform/efl/PlatformKeyboardEventEfl.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
      * platform/gtk/KeyEventGtk.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * platform/haiku/PlatformKeyboardEventHaiku.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
      * platform/mac/KeyEventMac.mm:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * platform/qt/PlatformKeyboardEventQt.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
      * platform/win/KeyEventWin.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
      * platform/wx/KeyboardEventWx.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollToOffset): Call
      EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
      a little to avoid computing the repaint rect twice.
      
      LayoutTests: 
      
      * fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
      * fast/events/overflow-scroll-fake-mouse-move.html: Added.
      * fast/events/touch/basic-multi-touch-events.html:
      * fast/events/touch/basic-single-touch-events.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a56888
    • eric@webkit.org's avatar
      2010-03-12 Kent Hansen <kent.hansen@nokia.com> · b382d0d6
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Webkit doesn't build with workers on and database off
              https://bugs.webkit.org/show_bug.cgi?id=35997
      
              Added missing ENABLE(DATABASE) guards.
      
              * workers/WorkerThread.cpp:
              (WebCore::WorkerThreadShutdownStartTask::performTask):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b382d0d6
    • kov@webkit.org's avatar
      2010-03-12 Dan Winship <danw@gnome.org> · 519d8899
      kov@webkit.org authored
      Reviewed by Gustavo Noronha.
      
              Make the defaultCookieJar use a no-third-party policy. Most
              applications set their own cookie jar, but DumpRenderTree doesn't,
              so it was failing the new third-party-cookie test.
      
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::defaultCookieJar):
      
      LayoutTests
      
      2010-03-12  Dan Winship  <danw@gnome.org>
      
              Reviewed by Gustavo Noronha.
      
              Revert previous; the test passes now.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      519d8899
    • eric@webkit.org's avatar
      2010-03-11 Simon Hausmann <simon.hausmann@nokia.com> · 7ab84469
      eric@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Enable network state notifier when compiling against Qt 4.7
              https://bugs.webkit.org/show_bug.cgi?id=35983
      
              * WebCore.pri:
              * platform/network/qt/NetworkStateNotifierPrivate.h:
              * platform/network/qt/NetworkStateNotifierQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ab84469
    • eric@webkit.org's avatar
      2010-03-11 Benjamin Poulain <benjamin.poulain@nokia.com> · 3754c523
      eric@webkit.org authored
              Reviewed by Adam Treat.
      
              Do not render the full frame when there is some elements with fixed positioning
              https://bugs.webkit.org/show_bug.cgi?id=33150
      
              The frame view take into acount the list of fixed object when scrolling
              the view. If the number of object is lower than a certain threshold, the pixel
              are blitted, and the invalidated area updated.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView):
              (WebCore::FrameView::useSlowRepaints):
              (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):
              (WebCore::FrameView::addFixedObject):
              (WebCore::FrameView::removeFixedObject):
              (WebCore::FrameView::scrollContentsFastPath):
              * page/FrameView.h:
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollContents):
              (WebCore::ScrollView::scrollContentsFastPath):
              * platform/ScrollView.h:
              * rendering/RenderBlock.h:
              (WebCore::RenderBlock::positionedObjects):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleWillChange):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::styleWillChange):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3754c523
  4. 11 Mar, 2010 10 commits
    • eric@webkit.org's avatar
      2010-03-11 Aaron Boodman <aa@chromium.org> · 04ca1559
      eric@webkit.org authored
              Kill WebDocument::applicationID() (part 1).
      
              Modify interface to WebCore::NotificationPresenter::checkPermission()
              and remove implementation of WebDocument::applicationID(). Breaking
              API changes will be in a subsequent change.
              https://bugs.webkit.org/show_bug.cgi?id=35846
      
              * notifications/Notification.cpp:
              (WebCore::Notification::Notification):
              * notifications/NotificationCenter.cpp:
              (WebCore::NotificationCenter::checkPermission):
              * notifications/NotificationPresenter.h:
      2010-03-11  Aaron Boodman  <aa@chromium.org>
      
              Kill WebDocument::applicationID() (part 1).
      
              Modify interface to WebCore::NotificationPresenter::checkPermission()
              and remove implementation of WebDocument::applicationID(). Breaking
              API changes will be in a subsequent change.
              https://bugs.webkit.org/show_bug.cgi?id=35846
      
              * public/WebNotificationPresenter.h:
              * src/NotificationPresenterImpl.cpp:
              (WebKit::NotificationPresenterImpl::checkPermission):
              * src/NotificationPresenterImpl.h:
              * src/WebDocument.cpp:
              (WebKit::WebDocument::applicationID):
      2010-03-11  Aaron Boodman  <aa@chromium.org>
      
              Kill WebDocument::applicationID() (part 1).
      
              Modify interface to WebCore::NotificationPresenter::checkPermission()
              and remove implementation of WebDocument::applicationID(). Breaking
              API changes will be in a subsequent change.
              https://bugs.webkit.org/show_bug.cgi?id=35846
      
              * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
              (WebDesktopNotificationsDelegate::checkPermission):
              * WebCoreSupport/WebDesktopNotificationsDelegate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ca1559
    • dimich@chromium.org's avatar
      [v8] Remove obsolete code for delayed dereferencing of DOM objects for... · 9b5c5136
      dimich@chromium.org authored
      [v8] Remove obsolete code for delayed dereferencing of DOM objects for single-heap, multithread v8 usage.
      https://bugs.webkit.org/show_bug.cgi?id=36043
      
      Reviewed by David Levin.
      
      No new tests, no changes in functionality.
      
      * bindings/v8/DOMData.cpp:
      (WebCore::DOMData::DOMData):
      * bindings/v8/DOMData.h:
      (WebCore::DOMData::handleWeakObject):
      * bindings/v8/DOMDataStore.cpp:
      * bindings/v8/DOMDataStore.h:
      (WebCore::DOMDataStore::domObjectMap):
      (WebCore::DOMDataStore::activeDomObjectMap):
      (WebCore::DOMDataStore::domSvgElementInstanceMap):
      (WebCore::DOMDataStore::domSvgObjectWithContextMap):
      * bindings/v8/ScopedDOMDataStore.cpp:
      (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
      * bindings/v8/StaticDOMDataStore.cpp:
      (WebCore::StaticDOMDataStore::StaticDOMDataStore):
      * bindings/v8/StaticDOMDataStore.h:
      * bindings/v8/V8DOMMap.cpp:
      (WebCore::removeAllDOMObjectsInCurrentThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b5c5136
    • barraclough@apple.com's avatar
      Rubber stamped by Oliver Hunt. · ce9f1049
      barraclough@apple.com authored
      Remove nonsense comments used in development & commited in error.
      
      JavaScriptCore: 
      
      * runtime/UStringImpl.h:
      
      WebCore: 
      
      * platform/text/StringImpl.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce9f1049
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=36041 · 6671f13a
      barraclough@apple.com authored
      Remove unnecessary differences in common code between WebCore::StringImpl & JSC::UStringImpl
      
      Reviewed by Oliver Hunt.
      
      Much of the code in WebCore::StringImpl and JSC::UStringImpl is now very similar,
      but has trivial and unnecessary formatting differences, such as the exact wording
      of comments, missing ASSERTs, functions implemented in the .h vs .cpp etc.
      
      JavaScriptCore: 
      
      * runtime/Identifier.cpp:
      (JSC::Identifier::add): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
      (JSC::Identifier::addSlowCase): UStringImpl::empty() now automatically hashes, uas per WebCore strings.
      * runtime/UStringImpl.cpp:
      (JSC::UStringImpl::~UStringImpl): Only call bufferOwnership() once, add missing ASSERTs.
      (JSC::UStringImpl::createUninitialized): Move from .h, not commonly called, no need to inline.
      (JSC::UStringImpl::create): Move from .h, not commonly called, no need to inline.
      (JSC::UStringImpl::sharedBuffer): Rewritten to more closely match WebCore implementation, remove need for separate baseSharedBuffer() method.
      * runtime/UStringImpl.h:
      (JSC::UStringImpl::UStringImpl): Automatically hash static strings, ASSERT m_data & m_length are non-null/non-zero in non-static strings.
      (JSC::UStringImpl::setHash): Add missing ASSERT.
      (JSC::UStringImpl::create): Moved to .cpp / added missing check for empty string creation.
      (JSC::UStringImpl::adopt): Vector.size() returns size_t, not unsigned.
      (JSC::UStringImpl::cost): Renamed m_bufferSubstring -> m_substringBuffer
      (JSC::UStringImpl::hash): Reordered in file.
      (JSC::UStringImpl::existingHash): Reordered in file.
      (JSC::UStringImpl::computeHash): Reordered in file, renamed parameter.
      (JSC::UStringImpl::checkConsistency): rewrote ASSERT.
      (JSC::UStringImpl::bufferOwnership): Return type should be BufferOwnership.
      (JSC::UStringImpl::): Moved friends to head of class.
      
      WebCore: 
      
      * platform/text/StringImpl.cpp:
      (WebCore::StringImpl::empty): Reordered in file, made empty()->characters() return a non-null value to match JSC.
      (WebCore::StringImpl::createUninitialized): Added overflow check.
      (WebCore::StringImpl::create): Reordered in file.
      (WebCore::StringImpl::sharedBuffer): Reordered in file.
      * platform/text/StringImpl.h:
      (WebCore::StringImpl::): Remove ThreadGlobalData as friend, move SharableUChar & SharedUChar to WebCore namespace.
      (WebCore::StringImpl::StringImpl): Made static constructor method (used to create empty string) take arguments, to match JSC & prevent accidental use.
      (WebCore::StringImpl::setHash): Added missing ASSERT.
      (WebCore::StringImpl::adopt): Make adpot work with Vectors with a non-zero inline capacity.
      (WebCore::StringImpl::characters): Mark as const to match JSC.
      (WebCore::StringImpl::hash): Use !m_hash instead of m_hash == 0.
      (WebCore::StringImpl::computeHash): Remove redundant 'inline'.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6671f13a
    • mrowe@apple.com's avatar
      <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X... · f2b94fad
      mrowe@apple.com authored
      <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
      
      Reviewed by David Kilzer.
      
      Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
      
      JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      
      JavaScriptGlue:
      
      * Configurations/Base.xcconfig:
      
      WebCore:
      
      * Configurations/Base.xcconfig:
      
      WebKit/mac:
      
      * Configurations/Base.xcconfig:
      
      WebKitTools:
      
      * DumpRenderTree/mac/Configurations/Base.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b94fad
    • eric@webkit.org's avatar
      2010-03-11 Jungshik Shin <jshin@chromium.org> · 25a4868c
      eric@webkit.org authored
              [Chromium]: Plane 2 characters are rendered "blank"
               (not even empty boxes) on Windows even when there are fonts to
               cover them.
      
              https://bugs.webkit.org/show_bug.cgi?id=35605
      
              Test:LayoutTests/fast/text/international/plane2.html
      
              * platform/graphics/chromium/FontCacheChromiumWin.cpp:
              (WebCore::LookupAltName): Add two ExtB fonts to the array (namePairs) that are used for Plane 2 character rendering.
              (WebCore::FontCache::getFontDataForCharacters): Add two more fonts to the fallback font list
              * platform/graphics/chromium/FontUtilsChromiumWin.cpp:
              (WebCore::getFallbackFamily): Fix the fallback font lookup to cover Plane 2 (CJK ExtB).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25a4868c
    • eric@webkit.org's avatar
      2010-03-11 Leandro Pereira <leandro@profusion.mobi> · 77b61ae5
      eric@webkit.org authored
              Reviewed by Holger Freyther.
      
              Add EFL port files to platform/efl.
              http://webkit.org/b/35889
      
              * platform/efl/SystemTimeEfl.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77b61ae5
    • mrowe@apple.com's avatar
      <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X... · e04aa11e
      mrowe@apple.com authored
      <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
      
      Reviewed by Tim Hatcher.
      
      Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted.  It defaults to the
      current Mac OS X version unless otherwise specified.
      
      Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
      
      Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
      may not be usable when targetting a different Mac OS X version.
      
      Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
      MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
      
      JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/FeatureDefines.xcconfig:
      * Configurations/JavaScriptCore.xcconfig:
      * Configurations/Version.xcconfig:
      
      JavaScriptGlue:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/Version.xcconfig:
      * JavaScriptGlue.xcodeproj/project.pbxproj:
      
      WebCore:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/FeatureDefines.xcconfig:
      * Configurations/Version.xcconfig:
      * Configurations/WebCore.xcconfig:
      
      WebKit/mac:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/FeatureDefines.xcconfig:
      * Configurations/Version.xcconfig:
      
      WebKitTools:
      
      * DumpRenderTree/mac/Configurations/Base.xcconfig:
      * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
      * DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the
      header in older SDKs do not do this inside the header.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e04aa11e
    • andersca@apple.com's avatar
      Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents. · 470d7e21
      andersca@apple.com authored
      Reviewed by David Hyatt.
      
      WebCore: 
      
      * loader/EmptyClients.h:
      * page/Chrome.cpp:
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/HostWindow.h:
      
      WebKit/chromium: 
      
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      
      WebKit/gtk: 
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/haiku: 
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac: 
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      
      WebKit/qt: 
      
      * WebCoreSupport/ChromeClientQt.cpp:
      * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win: 
      
      * WebCoreSupport/WebChromeClient.cpp:
      * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx: 
      
      * WebKitSupport/ChromeClientWx.cpp:
      * WebKitSupport/ChromeClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      470d7e21
    • japhet@chromium.org's avatar
      2010-03-11 Nate Chapin <japhet@chromium.org> · 553f87df
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Remove DOMObjectsInclude.h and update headers accordingly.
      
              https://bugs.webkit.org/show_bug.cgi?id=36036
      
              * WebCore.gypi:
              * bindings/v8/DOMData.h:
              * bindings/v8/DOMDataStore.h:
              * bindings/v8/DOMObjectsInclude.h: Removed.
              * bindings/v8/V8DOMMap.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/V8DOMWrapper.cpp:
              * bindings/v8/V8GCController.cpp:
              * bindings/v8/V8Proxy.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      553f87df