- 14 Mar, 2010 2 commits
-
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=17113 Reviewed by Sam Weinig. No new tests. * page/DragController.cpp: (WebCore::createMouseEvent): Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonikitoo@webkit.org authored
Not reviewed identation fix. * manual-tests/spatial-navigation/spatial-navigation-test-cases.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 13 Mar, 2010 24 commits
-
-
cjerdonek@webkit.org authored
a version of Python less than 2.5. This will help users understand why webkit-patch is erroring out if they are using Python 2.4, for example. Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=31533 * Scripts/webkit-patch: - Moved most of the file contents to webkitpy/patch/patcher.py so the Python version can be checked before interpreting any code that can cause the script to error out. - Added a configure_logging() method to enable any version warnings to show up. - Added a main() method with calls to configure_logging(), check_version(), and the main webkit patch method. * Scripts/webkitpy/patch/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py. - This file is required to make a folder a package. * Scripts/webkitpy/patch/patcher.py: Added. - Moved code from Scripts/webkit-patch. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cjerdonek@webkit.org authored
of unit-testing code do not get displayed to the screen. These messages clutter up the unit test results if not filtered out. Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=35835 * Scripts/test-webkitpy: - Adjusted the configure_logging() method to filter out any log messages from webkitpy. - Also added an INFO message stating that most console logging is getting suppressed. * Scripts/webkitpy/init/versioning.py: - Added a log parameter to the check_version() method. * Scripts/webkitpy/init/versioning_unittest.py: - Qualified a call to check_version() with the parameter names. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cjerdonek@webkit.org authored
being run using a Python version different from the minimum version the webkitpy package was meant to support. Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=35788 Warning developers if their Python version is too low will help them understand why test-webkitpy is failing. Secondly, warning developers if their Python version is higher than the minimum will help them understand that their changes may not be okay for the minimum supported version, even if test-webkitpy is passing. * Scripts/test-webkitpy: - Moved the "from ..._unittest import *" lines to the new file Scripts/webkitpy/unittests.py. This will allow the version-check warning to be displayed even if an error occurs while interpreting (i.e. importing) the unit test code. - Added configure_logging() to configur logging for test-webkitpy. - Added an init() method to configure logging and check the current Python version. * Scripts/webkitpy/init/unittests.py: Added. - Added a file to import all unit test modules in the webkitpy.init package. * Scripts/webkitpy/init/versioning.py: Added. - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set it equal to 2.5. - Added a compare_version() method to compare the current Python version against a target version. - Added a check_version() method to check the current Python version against the current minimum supported version, and to log a warning message if the check fails. * Scripts/webkitpy/init/versioning_unittest.py: Added. - Added unit tests for the functions in versioning.py. * Scripts/webkitpy/style/unittests.py: - Fixed/updated a code comment. * Scripts/webkitpy/unittests.py: Added. - Moved the "from ..._unittest import *" lines from test-webkitpy. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cjerdonek@webkit.org authored
Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=35828 Keeping webkitpy/__init__.py free of non-trivial code allows calling code to import initialization code from webkitpy before any errors or log messages occur due to code in __init__.py. Such initialization code can include things like version checking code and logging configuration code. This also lets us move the autoinstall initialization code to a location where it only executes if it is needed -- something we have done in this patch. * Scripts/webkitpy/__init__.py: - Moved all executable code to the following location: webkitpy/thirdparty/autoinstalled/__init__.py - Added a code comment to keep this file free of non-trivial code. * Scripts/webkitpy/bugzilla.py: - Updated mechanize import statement. * Scripts/webkitpy/networktransaction.py: - Updated mechanize import statement. * Scripts/webkitpy/networktransaction_unittest.py: - Updated mechanize import statement. * Scripts/webkitpy/statusserver.py: - Updated mechanize import statement. * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Added. - Copied the code from webkitpy/__init__.py and updated it as necessary. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cjerdonek@webkit.org authored
third-party code. Reviewed by Adam Barth. https://bugs.webkit.org/show_bug.cgi?id=35499 Updated the import statement in all of the below except where noted. * Scripts/webkitpy/bugzilla_unittest.py: * Scripts/webkitpy/commands/commandtest.py: * Scripts/webkitpy/commands/download_unittest.py: * Scripts/webkitpy/commands/early_warning_system_unittest.py: * Scripts/webkitpy/commands/queries_unittest.py: * Scripts/webkitpy/commands/queues_unittest.py: * Scripts/webkitpy/commands/queuestest.py: * Scripts/webkitpy/commands/upload.py: * Scripts/webkitpy/commands/upload_unittest.py: * Scripts/webkitpy/commands_references.py: Added. - Added a file containing an absolute import of Mock so that the imports in the commands folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings. * Scripts/webkitpy/credentials_unittest.py: * Scripts/webkitpy/mock.py: Removed. - Moved to Scripts/webkitpy/thirdparty. * Scripts/webkitpy/mock_bugzillatool.py: * Scripts/webkitpy/patchcollection_unittest.py: * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: * Scripts/webkitpy/steps/steps_unittest.py: * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: * Scripts/webkitpy/steps_references.py: Added. - Added a file containing an absolute import of Mock so that the imports in the steps folder can import from this file (similar to style_references.py). This helps limit the number of affected files in future refactorings. * Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py. - Also eliminated trailing white space and carriage returns. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC https://bugs.webkit.org/show_bug.cgi?id=36034 * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::OpacityAnimationQt::applyFrame): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] GraphicsLayer: Opacity transitions end with begin value https://bugs.webkit.org/show_bug.cgi?id=36019 * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::AnimationQt::updateCurrentTime): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add EFL port files to efl/ewk. http://webkit.org/b/35925 * efl/ewk/ewk_history.cpp: Added. * efl/ewk/ewk_history.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add EFL port files to efl/ewk. http://webkit.org/b/35928 * efl/ewk/ewk_main.cpp: Added. * efl/ewk/ewk_main.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=35866 Unreviewed. Roll-out r55955, because it broke 3 tests: - animations/fill-mode-transform.html - animations/play-state.html - animations/simultaneous-start-left.html * Api/qwebsettings.cpp: (QWebSettings::QWebSettings): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
No review, rolling out r55927. http://trac.webkit.org/changeset/55927 https://bugs.webkit.org/show_bug.cgi?id=35793 Breaks Gtk build bots. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreload): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Reviewed by Adam Barth. Amend incorrect typo patch for QtLauncher. https://bugs.webkit.org/show_bug.cgi?id=35877 * QtLauncher/webview.cpp: (WebViewGraphicsBased::setFrameRateMeasurementEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Add appengine app to host and serve webkit layout test results. The app allows you post test result files (json) and serve them up. Chromium flakiness dashboard will first use this app to host results.json and expectations.json, but the files hosted by this app are not limited to chromium results or json files. It can be used to host other files if needed. https://bugs.webkit.org/show_bug.cgi?id=35944 * TestResultServer: Added. * TestResultServer/app.yaml: Added. * TestResultServer/handlers: Added. * TestResultServer/handlers/__init__.py: Added. * TestResultServer/handlers/menu.py: Added. * TestResultServer/handlers/testfilehandler.py: Added. * TestResultServer/index.yaml: Added. * TestResultServer/main.py: Added. * TestResultServer/model: Added. * TestResultServer/model/__init__.py: Added. * TestResultServer/model/testfi...
-
eric@webkit.org authored
Reviewed by David Levin. new-run-webkit-tests fails with --debug option. https://bugs.webkit.org/show_bug.cgi?id=36067 * Scripts/webkitpy/layout_tests/port/mac.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add EFL port files to efl/ewk. http://webkit.org/b/35924 * efl/ewk/ewk_frame.cpp: Added. * efl/ewk/ewk_frame.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add EFL port files to efl/ewk. http://webkit.org/b/35936 * efl/ewk/ewk_view_single.c: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add "Show FPS" menu option to QtLauncher. [Qt] QtLauncher need a menu option to show/hide FPS https://bugs.webkit.org/show_bug.cgi?id=35794 * QtLauncher/main.cpp: (LauncherWindow::showFPS): (LauncherWindow::createChrome): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Enable accelerated compositing by default https://bugs.webkit.org/show_bug.cgi?id=35866 * Api/qwebsettings.cpp: (QWebSettings::QWebSettings): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add EFL port files to efl/ewk. http://webkit.org/b/35929 * efl/ewk/ewk_util.cpp: Added. * efl/ewk/ewk_util.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add EFL port files to efl/ewk. http://webkit.org/b/35934 * efl/ewk/EWebKit.h: Added. * efl/ewk/ewk_eapi.h: Added. * efl/ewk/ewk_logging.h: Added. * efl/ewk/ewk_private.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Adam Barth. Add a firstPartyForCookies() property to WebDocument. https://bugs.webkit.org/show_bug.cgi?id=35592 * public/WebDocument.h: * src/WebDocument.cpp: (WebKit::WebDocument::firstPartyForCookies): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Add a "Toggle FullScreen" option to QtLauncher Menu. [Qt] QtLauncher needs an option to toggle FullScreen Mode https://bugs.webkit.org/show_bug.cgi?id=35755 * QtLauncher/main.cpp: (LauncherWindow::init): (LauncherWindow::eventFilter): (LauncherWindow::initializeView): (LauncherWindow::toggleFullScreenMode): (LauncherWindow::createChrome): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by David Levin. [Qt] Rebaseline the test and remove it from Skipped. https://bugs.webkit.org/show_bug.cgi?id=36057 * platform/qt/Skipped: * platform/qt/fast/canvas/canvas-size-change-after-layout-expected.checksum: Added. * platform/qt/fast/canvas/canvas-size-change-after-layout-expected.png: Added. * platform/qt/fast/canvas/canvas-size-change-after-layout-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Nikolas Zimmermann. SVG Glyphs - transform path not context https://bugs.webkit.org/show_bug.cgi?id=36070 SVGFont should transform the path of a glyph, not the context. Modifying the context causes wrong gradient transformations. This bug doesn't influence CG because we generally fill or stroke texts with a mask image. All other platforms provide a direct way to make the drawings. * svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont): 2010-03-12 Dirk Schulze <krit@webkit.org> Reviewed by Nikolas Zimmermann. SVG Glyphs - transform path not context https://bugs.webkit.org/show_bug.cgi?id=36070 Some tests don't look pixel perfect after the SVGFont changes (difference of 0.1%). They just need an update. Tests for the changes on other platforms than CG are * svg/batik/text/textEffect.svg * svg/batik/text/textEffect3.svg * svg/W3C-SVG-1.1/pservers-grad-08-b.svg * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum: * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png: * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum: * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum: * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: * platform/mac/svg/batik/text/textEffect-expected.checksum: * platform/mac/svg/batik/text/textEffect-expected.png: * platform/mac/svg/batik/text/textEffect3-expected.checksum: * platform/mac/svg/batik/text/textEffect3-expected.png: * platform/mac/svg/text/selection-doubleclick-expected.png: * platform/mac/svg/text/selection-tripleclick-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 12 Mar, 2010 14 commits
-
-
barraclough@apple.com authored
Reviewed by NOBODY (build fix). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enrica@apple.com authored
Added contditional compilation for accelerated compositing. * WebView.cpp: (WebView::deleteBackingStore): (WebView::addToDirtyRegion): (WebView::updateBackingStore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=34942bdakin@apple.com authored
API naming is inconsistent -and corresponding- <rdar://problem/7729165> Reviewed by Simon Fraser. WebCore: This patch changes all occurrences of "fullScreen" to the more popular "fullscreen." webkitEnterFullScreen and webkitExitFullScreen have been maintained for now for backwards compatibility. * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitEnterFullscreen): (WebCore::HTMLVideoElement::webkitExitFullscreen): * html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::webkitEnterFullScreen): (WebCore::HTMLVideoElement::webkitExitFullScreen): * html/HTMLVideoElement.idl: * platform/graphics/mac/MediaPlayerProxy.h: WebKit/mac: This patch changes all occurrences of "fullScreen" to the more popular "fullscreen." * Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isFullscreenWindowShowing): * Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::didEnterFullscreen): (WebKit::NetscapePluginHostProxy::didExitFullscreen): (WebKit::NetscapePluginHostProxy::setFullscreenWindowIsShowing): (WKPCSetFullscreenWindowIsShowing): * Plugins/Hosted/WebKitPluginClient.defs: * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]): (-[WebNetscapePluginView _createPlugin]): (-[WebNetscapePluginView _destroyPlugin]): * WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindowController windowDidLoad]): WebKit/win: This patch changes all occurrences of "fullScreen" to the more popular "fullscreen." * FullscreenVideoController.cpp: (FullscreenVideoController::onMouseDown): (FullscreenVideoController::onMouseMove): (FullscreenVideoController::onMouseUp): * FullscreenVideoController.h: (FullscreenVideoController::fullscreenToHUDCoordinates): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
Reviewed by Adam Barth. Add virtual destructor to DOMWrapperWorld https://bugs.webkit.org/show_bug.cgi?id=36077 DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld inherits from DOMWrapperWorld and has member variables with destructors, so DOMWrapperWorld needs to have a declared virtual d'tor to ensure that its derived class's destructors are called. No new tests, no change in behavior * bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by NOBODY (build fix). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Reviewed by Oliver Hunt. JavaScriptCore: * API/JSClassRef.cpp: (OpaqueJSClass::~OpaqueJSClass): Classname may be null/empty, and these are an identifer. This is okay, since the null/empty strings are shared across all threads. * JavaScriptCore.exp: * runtime/Identifier.cpp: (JSC::Identifier::add): No need to explicitly hash null reps, this is done in the ststic UStringImpl constructor. (JSC::Identifier::addSlowCase): UStringImpl::empty() handled & checkCurrentIdentifierTable now called in the header. (JSC::Identifier::checkCurrentIdentifierTable): Replaces checkSameIdentifierTable (this no longer checked the rep since the identifierTable pointer was removed from UString::Rep long ago). * runtime/Identifier.h: (JSC::Identifier::add): Replace call to checkSameIdentifierTable with call to checkCurrentIdentifierTable at head of function. * runtime/UStringImpl.cpp: (JSC::UStringImpl::~UStringImpl): Remove call to checkConsistency - this function no longer checks anything interesting. * runtime/UStringImpl.h: (JSC::UStringOrRopeImpl::UStringOrRopeImpl): Set s_refCountFlagIsIdentifier in static constructor. (JSC::UStringImpl::UStringImpl): remove calls to checkConsistency (see above), add new ASSERT to substring constructor. (JSC::UStringImpl::setHash): ASSERT not static (static strings set the hash in their constructor, should not reach this code path). (JSC::UStringImpl::create): Add missing ASSERT. (JSC::UStringImpl::setIsIdentifier): ASSERT !isStatic() (static strings hash set in constructor). WebCore: * platform/text/StringImpl.cpp: (WebCore::StringImpl::~StringImpl): Add ASSERT (WebCore::StringImpl::sharedBuffer): Add ASSERT * platform/text/StringImpl.h: (WebCore::StringImpl::setHash): Add ASSERT (WebCore::StringImpl::isStatic): added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=33739bdakin@apple.com authored
video HUD stays on top when switching to another window (e.g. via Alt-Tab) -and corresponding- <rdar://problem/7547574> Reviewed by Adam Roben. The HUD was always on top because it had the WS_EX_TOPMOST style. So I removed the style and made m_videoWindow the owner of m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow is the focused window. * FullscreenVideoController.cpp: (FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud. (FullscreenVideoController::createHUDWindow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
enrica@apple.com authored
<rdar://problem/7556244> <https://bugs.webkit.org/show_bug.cgi?id=36027> Reviewed by Simon Fraser. WebCore: There were two problems to solve here: - the incorrect anchoring of the rootChildLayer that was causing the composited content to be positioned incorrectly - the failure to paint the non composited content into the backing store when animating composited content. The first problem has been solved by leaving the original anchor point for the rootChildLayer and splitting the tasks of clipping and scrolling using two separate layers. The second problem has been solved leveraging the knowledge that WebView has of the dirty region of the backing store to pass this information to the layer renderer. This allows the renderer to force a paint into the backing store before moving to the compositing. Tests: compositing/geometry/horizontal-scroll-composited.html compositing/geometry/vertical-scroll-composited.html * manual-tests/win/horizontal-scroll-composited.html: Removed. This is now a layout test. * manual-tests/win/milliondollar.html: Added. * platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Added initialization of dirty flag. (WebCore::WKCACFLayerRenderer::setScrollFrame): (WebCore::WKCACFLayerRenderer::updateScrollFrame): Updated to resize and position the clip and scroll layers. (WebCore::WKCACFLayerRenderer::setRootChildLayer): (WebCore::WKCACFLayerRenderer::createRenderer): Added new layer hierarchy. (WebCore::WKCACFLayerRenderer::destroyRenderer): Remove clip layer on destroy. (WebCore::WKCACFLayerRenderer::resize): (WebCore::WKCACFLayerRenderer::paint): Forcing paint massage to trigger paint into the backing store. * platform/graphics/win/WKCACFLayerRenderer.h: (WebCore::WKCACFLayerRenderer::setBackingStoreDirty): Added. WebKit/win: See detailed comments in WebCore/ChangeLog. * WebView.cpp: (WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store. (WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the backing store dirty region. (WebView::updateBackingStore): Reset the dirty flag after painting into the backing store. (WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents. (WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame. We are passing width and height of the view content together with the offset for the scrolling. It was confusing to pass it all as a rectangle, when it is not a rectangle. LayoutTests: * compositing/geometry/horizontal-scroll-composited.html: Added. * compositing/geometry/vertical-scroll-composited.html: Added. * compositing/resources/apple.jpg: Added. * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added. * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png: Added. * platform/mac/compositing/geometry/horizontal-scroll-composited-expected.txt: Added. * platform/mac/compositing/geometry/vertical-scroll-composited-expected.checksum: Added. * platform/mac/compositing/geometry/vertical-scroll-composited-expected.png: Added. * platform/mac/compositing/geometry/vertical-scroll-composited-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Reviewed by Dimitri Glazkov. Fix typo in websocket_server (path_from_base instead of path_from_chromium_base). https://bugs.webkit.org/show_bug.cgi?id=36074 * Scripts/webkitpy/layout_tests/port/websocket_server.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
robert@webkit.org authored
Not reviewed, build fix. Revert http://trac.webkit.org/projects/webkit/changeset/55374 which broke the !ENABLE(DATABASE) build on all platforms when attempting to fix the --minimal build on Qt. Support for SQLite now seems to be non-negotiable for the Qt build but making it mandatory requires review, so re-break --minimal Qt build for now. Qt build issue now tracked at https://bugs.webkit.org/show_bug.cgi?id=36073 * page/GeolocationPositionCache.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Reviewed by Adam Barth. new-run-webkit-tests --new-baseline doesn't work at all. It attempts to call a method that isn't defined. To fix it, I removed the unnecessary and unnecessarily confusing 'platform' argument to the test_type constructor and use the Port object that is passed in instead, since we are only ever generating a baseline from the port that is currently executing. https://bugs.webkit.org/show_bug.cgi?id=36046 * Scripts/webkitpy/layout_tests/port/mac.py: * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Reviewed by Adam Barth. Fix new-run-webkit-tests --run-singly This script option is currently broken - the script attempts to dereference methods and variables that don't exist, which causes the Chromium Linux valgrind bot to be quite unhappy. This has been broken since r54449 when I renamed Port.start_test_driver to Port.start_driver. https://bugs.webkit.org/show_bug.cgi?id=36042 * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Unreviewed LayoutTest update. Result was not updated with r55930. * platform/mac/svg/custom/dominant-baseline-hanging-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/7709115http://www.glom.org/mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35507 Reviewed by Alexey Proskuryakov. * css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in <http://trac.webkit.org/changeset/48818> to detect the two variants of KHTMLFixes.css in @import rules as well as in <link> elements. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-