- 12 May, 2011 23 commits
-
-
zimmermann@webkit.org authored
Not reviewed. Revert r86334, it broke the win build. WinCE build is fixed even without this patch. WinCairo remains broken atm, everything else works. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Not reviewed. String operator+ reallocates unnecessarily when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Try to fix WinCE/WinCairo linking by exporting three symbols, not sure whether it's correct though. Win worked just fine before. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Not reviewed. String operator+ reallocates unnecessary when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Attempt to fix the WinCE build. WinCE/WinCairo still won't link because of unresolved symbols, hmm. If we had EWS for those, I would have caught the problem earlier. * platform/wince/FileSystemWinCE.cpp: (WebCore::listDirectory): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Not reviewed. String operator+ reallocates unnecessary when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Fix fast/forms/input-image-submit.html regression, seens on the bots - by removing a last-minute typo: s/!!/!/ * html/ImageInputType.cpp: (WebCore::ImageInputType::appendFormData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
Reviewed by Eric Seidel. REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't https://bugs.webkit.org/show_bug.cgi?id=59941 Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed. Test: svg/custom/fill-opacity-update.svg * rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Reviewed by Darin Adler. String operator+ reallocates unnecessarily when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Provide a faster String append operator. Up until now, "String operator+(const String& a, const String& b)" copied String a into a temporary object, and used a.append(b), which reallocates a new buffer of aLength+bLength. When concatting N strings using operator+, this leads to N-1 reallocations. Replace this with a flexible operator+ implementation, that avoids these reallocations. When concatting a 'String' with any string type (char*, UChar, Vector<char>, String, AtomicString, etc..) a StringAppend<String, T> object is created, which holds the intermediate string objects, and delays creation of the final string, until operator String() is invoked. template<typename T> StringAppend<String, T> operator+(const String& string1, T string2) { return StringAppend<String, T>(string1, string2); } template<typename U, typename V, typename W> StringAppend<U, StringAppend<V, W> > operator+(U string1, const StringAppend<V, W>& string2) { return StringAppend<U, StringAppend<V, W> >(string1, string2); } When concatting three strings - "String a, b, c; String result = a + b + c;" following happens: first a StringAppend<String, String> object is created by operator+(const String& string1, String string2). Then operator+(String string1, const StringAppend<String, String>& string2) is invoked, which returns a StringAppend<String, StringAppend<String, String> > object. Then operator String() is invoked, which allocates a StringImpl object, once, large enough to hold the final string - it uses tryMakeString provided by StringConcatenate.h under the hoods, which guards us against too big string allocations, etc. Note that the second template, defines a recursive way to concat an arbitary number of strings into a single String with just one allocation. * GNUmakefile.list.am: Add StringOperators.h to build. * JavaScriptCore.exp: Export WTF::emptyString(). Remove no longer needed symbols. * JavaScriptCore.gypi: Add StringOperators.h to build. * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto. * JavaScriptCore.xcodeproj/project.pbxproj: Ditto. * wtf/text/AtomicString.h: Pull in StringConcatenate.h at the end of the file. * wtf/text/StringConcatenate.h: Conditionally include AtomicString.h to avoid a cyclic dependency. Pull in StringOperators.h at the end of the file. * wtf/text/StringOperators.h: Added. This is never meant to be included directly, including either WTFString.h or AtomicString.h automatically pulls in this file. (WTF::StringAppend::StringAppend): (WTF::StringAppend::operator String): (WTF::StringAppend::operator AtomicString): (WTF::StringAppend::writeTo): (WTF::StringAppend::length): (WTF::operator+): * wtf/text/WTFString.cpp: Remove operator+ implementations that use String::append(). (WTF::emptyString): Add new shared empty string free function. * wtf/text/WTFString.h: Replace operator+ implementations by StringAppend template solution. Pull in AtomicString.h at the end of the file. 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Darin Adler. String operator+ reallocates unnecessary when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details. * dom/XMLDocumentParserLibxml2.cpp: (WebCore::handleElementAttributes): * editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::shouldAddNamespaceElement): * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hash): (WebCore::HTMLAnchorElement::search): * html/ImageInputType.cpp: (WebCore::ImageInputType::appendFormData): * html/parser/HTMLTreeBuilder.cpp: * loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): * page/Location.cpp: (WebCore::Location::search): (WebCore::Location::hash): * page/NavigatorBase.cpp: (WebCore::NavigatorBase::platform): * platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject): * platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::fillSelectionData): * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization): * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::copyCFStreamDescription): * platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization): * workers/WorkerLocation.cpp: (WebCore::WorkerLocation::search): (WebCore::WorkerLocation::hash): 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Darin Adler. String operator+ reallocates unnecessarily when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details. * src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::keyboardShortcut): Cast to String first, before trying to convert to platform dependant type. * src/WebHTTPLoadInfo.cpp: (WebKit::addHeader): Don't pass WebString to makeString, explicit cast to String first. * tests/IDBLevelDBCodingTest.cpp: Cast to String first, to avoid conflicting with gtests global templatified operator+. (IDBLevelDBCoding::TEST): 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Darin Adler. String operator+ reallocates unnecessarily when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details. * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked. (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): 2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> Reviewed by Darin Adler. String operator+ reallocates unnecessarily when concatting > 2 strings https://bugs.webkit.org/show_bug.cgi?id=58420 Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details. * AccessibleBase.cpp: (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Implement layoutTestController.layerTreeAsText() https://bugs.webkit.org/show_bug.cgi?id=60367 * WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::layerTreeAsText): * WebCoreSupport/DumpRenderTreeSupportQt.h: 2011-05-12 Young Han Lee <joybro@company100.net> Reviewed by Kenneth Rohde Christiansen. [Qt] Implement layoutTestController.layerTreeAsText() https://bugs.webkit.org/show_bug.cgi?id=60367 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::layerTreeAsText): * DumpRenderTree/qt/LayoutTestControllerQt.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: test that eval can access scoped variables in console https://bugs.webkit.org/show_bug.cgi?id=60547 * inspector/console/console-eval-scoped-expected.txt: Added. * inspector/console/console-eval-scoped.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: move agents from InspectorAgent to InspectorController https://bugs.webkit.org/show_bug.cgi?id=60359 All inspector agents are now created and owned by InspectorController which in turned is owned by the inspected Page. InspectorInstrumentation gets access to the instrumenting agents by means of InspectorAgent::instrumentingAgents(). In addition to managing inspector agents lifetime InspectorController sets InspectorFronted on the agents when the front-end is connected. * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::restore): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::clearFrontend): * inspector/InspectorAgent.h: all accessors to other agents were removed along with the agents themselves from InspectorAgent. Every agent that depends on some other agents receives pointers to them explicitely in its constructor. All access to the agents from WebCore should go through InspectorInstrumentation which retrieves corresponding agents using InstrumentingAgents structure which represents the set of active agents. (WebCore::InspectorAgent::instrumentingAgents): * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::highlightedNode): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::resume): * inspector/InspectorController.h: * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): * page/Page.cpp: (WebCore::Page::~Page): we send two notifications when inspected Page is being destroyed: one to the inspector instrumentation and another one to the InspectorController which is owned by the Page. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonyg@chromium.org authored
Build fix: include ExceptionCode.h https://bugs.webkit.org/show_bug.cgi?id=60694 * dom/Range.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonyg@chromium.org authored
Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * accessibility/AccessibilityObject.cpp: * accessibility/AccessibilityRenderObject.cpp: * accessibility/mac/AccessibilityObjectWrapper.mm: * dom/DocumentMarkerController.cpp: * dom/Position.cpp: * dom/PositionIterator.cpp: * dom/Range.cpp: * editing/ApplyBlockElementCommand.cpp: * editing/ApplyStyleCommand.cpp: * editing/Editor.cpp: * editing/EditorCommand.cpp: * editing/FrameSelection.cpp: * editing/HTMLInterchange.cpp: * editing/IndentOutdentCommand.cpp: * editing/ReplaceSelectionCommand.cpp: * editing/SpellChecker.h: * editing/SpellingCorrectionCommand.cpp: * editing/SpellingCorrectionController.h: * editing/TextCheckingHelper.cpp: * editing/TextIterator.h: * editing/htmlediting.h: * editing/markup.cpp: * editing/visible_units.cpp: * editing/visible_units.h: * fileapi/DOMFileSystem.cpp: * fileapi/DirectoryReaderSync.cpp: * fileapi/DirectoryReaderSync.h: * fileapi/FileEntry.h: * fileapi/FileWriter.h: * fileapi/FileWriterBase.h: * fileapi/FileWriterSync.h: * history/CachedFrame.cpp: * history/CachedPage.cpp: * history/HistoryItem.cpp: * history/HistoryItem.h: * history/PageCache.h: * loader/HistoryController.h: * loader/PingLoader.h: * loader/ResourceLoader.h: * loader/appcache/DOMApplicationCache.h: * loader/cache/CachedCSSStyleSheet.h: * loader/cache/CachedFont.cpp: * loader/cache/CachedFont.h: * loader/cache/CachedResourceRequest.cpp: * loader/cache/CachedResourceRequest.h: * loader/cache/MemoryCache.h: * notifications/Notification.cpp: * notifications/Notification.h: * notifications/NotificationCenter.cpp: * notifications/NotificationCenter.h: * page/Chrome.cpp: * page/Chrome.h: * page/DOMSelection.cpp: * page/DOMTimer.h: * page/DOMWindow.cpp: * page/EventHandler.cpp: * page/FocusController.h: * page/Geolocation.cpp: * page/Geolocation.h: * page/History.cpp: * rendering/RenderListBox.cpp: * workers/WorkerContext.cpp: 2011-05-10 Tony Gentilcore <tonyg@chromium.org> Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * src/WebHistoryItem.cpp: * src/WebNotification.cpp: * src/WebTextCheckingCompletionImpl.cpp: * src/mac/WebSubstringUtil.mm: 2011-05-10 Tony Gentilcore <tonyg@chromium.org> Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * Plugins/Hosted/WebHostedNetscapePluginView.mm: * WebView/WebFrame.mm: 2011-05-10 Tony Gentilcore <tonyg@chromium.org> Reviewed by Darin Adler. Perform some forward declarations suggested by include-what-you-use https://bugs.webkit.org/show_bug.cgi?id=60545 * WebProcess/WebPage/mac/WebPageMac.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
* platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Added. * platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Added. * platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Added. * platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Added. * platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Added. * platform/qt-arm/transforms/svg-vs-css-expected.txt: Added. * platform/qt-mac/Skipped: Add plugins/get-targeted-javascript-url.html because of missing plugin.getURLNotify() implementation * platform/qt-mac/fast/transforms/transform-positioned-ancestor-expected.txt: Added. * platform/qt-mac/transforms/2d/transform-borderbox-expected.txt: Added. * platform/qt-mac/transforms/2d/transform-origin-borderbox-expected.txt: Added. * platform/qt-mac/transforms/2d/zoom-menulist-expected.txt: Added. * platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Added. * platform/qt-mac/transforms/svg-vs-css-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, GTK rebaseline after r86307. * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt: * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Unreviewed. Update Qt test expectations affected in r86320. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-expected.txt: * platform/qt/fast/js/global-constructors-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Unreviewed, another attempt of build fix. * websockets/CloseEvent.h: * websockets/CloseEvent.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Unreviewed, trying to fix Qt minimal compile. * websockets/CloseEvent.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Fix build with --disable-video --enable-fullscreen-api https://bugs.webkit.org/show_bug.cgi?id=60542 * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, GTK build fix. * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
Reviewed by Martin Robinson. Fix the build with ENABLE_PLUGIN_PROCESS https://bugs.webkit.org/show_bug.cgi?id=60628 * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize): Move the call to pluginController->isAcceleratedCompositingEnabled() to a #ifdef block. * WebProcess/Plugins/PluginProxy.h: Add include for <WebCore/IntRect.h>. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Csaba Osztrogonác. [Qt] Arm debug build failing on ARMAssembler::debugOffset() https://bugs.webkit.org/show_bug.cgi?id=60688 Related to svn rev 85523 * assembler/ARMAssembler.h: (JSC::ARMAssembler::debugOffset): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yutak@chromium.org authored
Reviewed by Kent Tamura. WebSocket add new event: CloseEvent https://bugs.webkit.org/show_bug.cgi?id=35573 Original patch was written by Fumitoshi Ukai <ukai@chromium.org>. I modified the test close-event.html slightly so that it passes on Chromium. I also updated a few test results that are affected by this change. * fast/dom/Window/window-properties-expected.txt: * fast/dom/Window/window-property-descriptors-expected.txt: * fast/dom/prototype-inheritance-expected.txt: * fast/js/global-constructors-expected.txt: * http/tests/websocket/tests/close-event-expected.txt: Added. * http/tests/websocket/tests/close-event.html: Added. * platform/chromium/fast/dom/prototype-inheritance-expected.txt: 2011-05-12 Yuta Kitamura <yutak@chromium.org> Reviewed by Kent Tamura. WebSocket add new event: CloseEvent https://bugs.webkit.org/show_bug.cgi?id=35573 Original patch was written by Fumitoshi Ukai <ukai@chromium.org>. I added CloseEvent constructor to DOMWindow, so it can be referred in the new test (close-event.html). Test: http/tests/websocket/tests/close-event.html * CMakeLists.txt: * CodeGenerators.pri: * DerivedSources.cpp: * DerivedSources.make: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSEventCustom.cpp: (WebCore::toJS): * bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): * dom/Event.cpp: (WebCore::Event::isCloseEvent): * dom/Event.h: * page/DOMWindow.idl: Add CloseEvent constructor. * websockets/CloseEvent.h: Added. (WebCore::CloseEvent::isCloseEvent): (WebCore::CloseEvent::create): (WebCore::CloseEvent::initCloseEvent): (WebCore::CloseEvent::wasClean): (WebCore::CloseEvent::CloseEvent): * websockets/CloseEvent.idl: Added. * websockets/WebSocket.cpp: (WebCore::WebSocket::didClose): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Simon Fraser. RGBA colors in outlines show overpainting at the corners https://bugs.webkit.org/show_bug.cgi?id=58999 * fast/borders/outline-alpha-block.html: Added. * fast/borders/outline-alpha-inline.html: Added. * platform/chromium/test_expectations.txt: * platform/mac/fast/borders/outline-alpha-block-expected.png: Added. * platform/mac/fast/borders/outline-alpha-block-expected.txt: Added. * platform/mac/fast/borders/outline-alpha-inline-expected.png: Added. * platform/mac/fast/borders/outline-alpha-inline-expected.txt: Added. * platform/mac/fast/box-shadow/box-shadow-radius-expected.png: Rebaselined as this test had rgba outlines. * platform/mac/fast/layers/self-painting-outline-expected.png: Rebaselined as this test had rgba outlines. 2011-05-12 Ben Wells <benwells@chromium.org> Reviewed by Simon Fraser. RGBA colors in outlines show overpainting at the corners https://bugs.webkit.org/show_bug.cgi?id=58999 Tests: fast/borders/outline-alpha-block.html fast/borders/outline-alpha-inline.html Updated baseline images for tests with rgba outlines: fast/box-shadow/box-shadow-radius.html fast/layers/self-painting-outline.html * rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. [Qt] Expected results for 6 new CSS3 transforms tests and the updated skipped list https://bugs.webkit.org/show_bug.cgi?id=60654 * platform/qt/Skipped: * platform/qt/fast/transforms/transform-positioned-ancestor-expected.png: Added. * platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt: Added. * platform/qt/transforms/2d/transform-borderbox-expected.png: Added. * platform/qt/transforms/2d/transform-borderbox-expected.txt: Added. * platform/qt/transforms/2d/transform-origin-borderbox-expected.png: Added. * platform/qt/transforms/2d/transform-origin-borderbox-expected.txt: Added. * platform/qt/transforms/2d/zoom-menulist-expected.png: Added. * platform/qt/transforms/2d/zoom-menulist-expected.txt: Added. * platform/qt/transforms/no_transform_hit_testing-expected.png: Added. * platform/qt/transforms/no_transform_hit_testing-expected.txt: Added. * platform/qt/transforms/svg-vs-css-expected.png: Added. * platform/qt/transforms/svg-vs-css-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 May, 2011 17 commits
-
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Rename Widget::pos() https://bugs.webkit.org/show_bug.cgi?id=60575 Renaming Widget::pos() to the more-descriptive location(). No new tests as this is a simple rename * page/FrameView.cpp: (WebCore::FrameView::create): * platform/Widget.h: (WebCore::Widget::location): (WebCore::Widget::resize): 2011-05-11 Levi Weintraub <leviw@chromium.org> Reviewed by Eric Seidel. Rename Widget::pos() https://bugs.webkit.org/show_bug.cgi?id=60575 Renaming Widget::pos() to the more-descriptive location(). * src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder): (WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. Crashes if the document inside iframe is removed during pasting some text into it. https://bugs.webkit.org/show_bug.cgi?id=60534 * editing/pasteboard/paste-removing-iframe-expected.txt: Added. * editing/pasteboard/paste-removing-iframe.html: Added. * editing/pasteboard/resources/paste-removing-iframe-child.html: Added. 2011-05-10 MORITA Hajime <morrita@google.com> Reviewed by Kent Tamura. Crashes if the document inside iframe is removed during pasting some text into it. https://bugs.webkit.org/show_bug.cgi?id=60534 Added missing null check. Test: editing/pasteboard/paste-removing-iframe.html * editing/Editor.cpp: (WebCore::Editor::shouldChangeSelection): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Handle case when GrContext creation fails https://bugs.webkit.org/show_bug.cgi?id=60410 Exercised by all canvas tests when DRT is run with skia-gpu * platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::grContext): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
psolanki@apple.com authored
Reviewed by Andreas Kling. Remove empty class CallbackGuard https://bugs.webkit.org/show_bug.cgi?id=60610 CallbackGuard was only ever used on Tiger and it is now an empty class. Remove all uses of it. * platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. Implement CSSPropertyMargin and CSSPropertyPadding in CSSStyleApplyProperty. https://bugs.webkit.org/show_bug.cgi?id=60609 No new tests - refactoring only. * css/CSSStyleApplyProperty.cpp: (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Initialise CSSPropertyMargin and CSSPropertyPadding handlers. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove unused implementations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Kent Tamura. Some elements in meter-styles.html are hiding its content part with non-content-area. https://bugs.webkit.org/show_bug.cgi?id=58149 - Resized the border and padding values - Gave "-webkit-appearance: none" to test that is intended to be painted using shadows. * fast/dom/HTMLMeterElement/meter-styles.html: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: * platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
[wx] Implement more clipping functions for wxWebKit. https://bugs.webkit.org/show_bug.cgi?id=60662 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Brady Eidson. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history https://bugs.webkit.org/show_bug.cgi?id=60674 * WebCore.exp.in: Export restoreScrollPositionAndViewState() 2011-05-11 Damian Kaleta <dkaleta@apple.com> Reviewed by Brady Eidson. Need a new API that will try to restore the scrollbars' position, when navigating in the back/forward history https://bugs.webkit.org/show_bug.cgi?id=60674 * UIProcess/API/C/WKPage.cpp: (WKPageTryRestoreScrollPosition): * UIProcess/API/C/WKPage.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::tryRestoreScrollPosition): * UIProcess/WebPageProxy.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryRestoreScrollPosition): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Eric Seidel. WebKit does not build with GCCE https://bugs.webkit.org/show_bug.cgi?id=60667 Allow compile WebKit with GCCE * wtf/Alignment.h: * wtf/Platform.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leviw@chromium.org authored
Reviewed by Eric Seidel. Switch paintFillLayer and its progeny to use IntRect instead of four ints https://bugs.webkit.org/show_bug.cgi?id=60596 Changing integers passed into paintFillLayer and other derivatives to IntRects and IntSizes that reflect their function. No new tests since this is just refactoring. * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayers): (WebCore::InlineFlowBox::paintFillLayer): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask): * rendering/InlineFlowBox.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxFillLayers): (WebCore::RenderBox::paintBoxDecorationsWithSize): (WebCore::RenderBox::paintMaskImages): (WebCore::RenderBox::paintFillLayers): (WebCore::RenderBox::paintFillLayer): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): * rendering/RenderBoxModelObject.h: * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): * rendering/RenderTable.cpp: (WebCore::RenderTable::paintBoxDecorations): * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Enable strict PassOwnPtr on Mac https://bugs.webkit.org/show_bug.cgi?id=60684 This should build cleanly now. * wtf/PassOwnPtr.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by James Robinson. [chromium] Use mapTexSubImage2D for tile uploads if available https://bugs.webkit.org/show_bug.cgi?id=60008 * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::updateFromPixels): * platform/graphics/chromium/LayerTilerChromium.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Darin Adler. Protect JSC from WebCore executing JS during JS wrapper finalization https://bugs.webkit.org/show_bug.cgi?id=60672 <rdar://problem/9350997> Detect when we're trying to execute JS during GC and prevent the execution from happening. We also assert that this isn't happening as it implies incorrect behaviour of an object's destructor. * JavaScriptCore.exp: * heap/Heap.cpp: * heap/Heap.h: (JSC::Heap::isBusy): * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): * runtime/JSGlobalData.h: (JSC::JSGlobalData::isCollectorBusy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alexis.menard@openbossa.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Implements a disable appearance for Media Elements of Qt port. https://bugs.webkit.org/show_bug.cgi?id=60561 Implements a disable appearance for the media controls of the Qt port when the media is not yet available. * platform/qt/RenderThemeQt.cpp: (WebCore::mediaElementCanPlay): (WebCore::RenderThemeQt::getMediaControlForegroundColor): (WebCore::RenderThemeQt::paintMediaSliderThumb): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Dimitri Glazkov. input type=email is too strict https://bugs.webkit.org/show_bug.cgi?id=55988 * fast/forms/resources/ValidityState-typeMismatch-email.js: * fast/forms/ValidityState-typeMismatch-email-expected.txt: 2011-05-11 Kent Tamura <tkent@chromium.org> Reviewed by Dimitri Glazkov. input type=email is too strict https://bugs.webkit.org/show_bug.cgi?id=55988 Follow the updated specification. * html/EmailInputType.cpp: Update the pattern to allow a domain part without periods. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cdn@chromium.org authored
Reviewed by David Levin. Adding Cris Neckar to the Webkit Security Group site. https://bugs.webkit.org/show_bug.cgi?id=60668 * security/security-group-members.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Gavin Barraclough. WebKit2 doesn't build on Mac with strict PassOwnPtr https://bugs.webkit.org/show_bug.cgi?id=60655 * Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessageDelayed): Add explicit adoptPtr to indicate that the constructor is taking ownership. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-