Skip to content

GitLab

Switch branch/tag
  1. 12 May, 2011 23 commits
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · aa696027
      zimmermann@webkit.org authored 
              Not reviewed.

        Revert r86334, it broke the win build. WinCE build is fixed even without this patch. WinCairo remains broken atm, everything else works.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa696027
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · dbca63ef
      zimmermann@webkit.org authored 
              Not reviewed.

        String operator+ reallocates unnecessarily when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Try to fix WinCE/WinCairo linking by exporting three symbols, not sure whether it's correct though. Win worked just fine before.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbca63ef
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · 37643bf4
      zimmermann@webkit.org authored 
              Not reviewed.

        String operator+ reallocates unnecessary when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Attempt to fix the WinCE build. WinCE/WinCairo still won't link because of unresolved symbols, hmm. If we had EWS for those, I would have caught the problem earlier.

        * platform/wince/FileSystemWinCE.cpp:
        (WebCore::listDirectory):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37643bf4
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · 256315ac
      zimmermann@webkit.org authored 
              Not reviewed.

        String operator+ reallocates unnecessary when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Fix fast/forms/input-image-submit.html regression, seens on the bots - by removing a last-minute typo: s/!!/!/

        * html/ImageInputType.cpp:
        (WebCore::ImageInputType::appendFormData):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      256315ac
    • rwlbuis@webkit.org's avatar
      2011-05-12 Rob Buis <rwlbuis@gmail.com> · c823d24d
      rwlbuis@webkit.org authored 
              Reviewed by Eric Seidel.

        REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
        https://bugs.webkit.org/show_bug.cgi?id=59941

        Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.

        Test: svg/custom/fill-opacity-update.svg

        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c823d24d
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · 6da15387
      zimmermann@webkit.org authored 
              Reviewed by Darin Adler.

        String operator+ reallocates unnecessarily when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Provide a faster String append operator.
        Up until now, "String operator+(const String& a, const String& b)" copied String a into a temporary
        object, and used a.append(b), which reallocates a new buffer of aLength+bLength. When concatting
        N strings using operator+, this leads to N-1 reallocations.

        Replace this with a flexible operator+ implementation, that avoids these reallocations.
        When concatting a 'String' with any string type (char*, UChar, Vector<char>, String, AtomicString, etc..)
        a StringAppend<String, T> object is created, which holds the intermediate string objects, and delays
        creation of the final string, until operator String() is invoked.

        template<typename T>
        StringAppend<String, T> operator+(const String& string1, T string2)
        {
            return StringAppend<String, T>(string1, string2);
        }

        template<typename U, typename V, typename W>
        StringAppend<U, StringAppend<V, W> > operator+(U string1, const StringAppend<V, W>& string2)
        {
            return StringAppend<U, StringAppend<V, W> >(string1, string2);
        }

        When concatting three strings - "String a, b, c; String result = a + b + c;" following happens:
        first a StringAppend<String, String> object is created by operator+(const String& string1, String string2).
        Then operator+(String string1, const StringAppend<String, String>& string2) is invoked, which returns
        a StringAppend<String, StringAppend<String, String> > object.
        Then operator String() is invoked, which allocates a StringImpl object, once, large enough to hold the
        final string - it uses tryMakeString provided by StringConcatenate.h under the hoods, which guards us
        against too big string allocations, etc.

        Note that the second template, defines a recursive way to concat an arbitary number of strings
        into a single String with just one allocation.

        * GNUmakefile.list.am: Add StringOperators.h to build.
        * JavaScriptCore.exp: Export WTF::emptyString(). Remove no longer needed symbols.
        * JavaScriptCore.gypi: Add StringOperators.h to build.
        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
        * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
        * wtf/text/AtomicString.h: Pull in StringConcatenate.h at the end of the file.
        * wtf/text/StringConcatenate.h: Conditionally include AtomicString.h to avoid a cyclic dependency. Pull in StringOperators.h at the end of the file.
        * wtf/text/StringOperators.h: Added. This is never meant to be included directly, including either WTFString.h or AtomicString.h automatically pulls in this file.
        (WTF::StringAppend::StringAppend):
        (WTF::StringAppend::operator String):
        (WTF::StringAppend::operator AtomicString):
        (WTF::StringAppend::writeTo):
        (WTF::StringAppend::length):
        (WTF::operator+):
        * wtf/text/WTFString.cpp: Remove operator+ implementations that use String::append(). 
        (WTF::emptyString): Add new shared empty string free function.
        * wtf/text/WTFString.h: Replace operator+ implementations by StringAppend template solution. Pull in AtomicString.h at the end of the file.

2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        String operator+ reallocates unnecessary when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::handleElementAttributes):
        * editing/MarkupAccumulator.cpp:
        (WebCore::MarkupAccumulator::shouldAddNamespaceElement):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::hash):
        (WebCore::HTMLAnchorElement::search):
        * html/ImageInputType.cpp:
        (WebCore::ImageInputType::appendFormData):
        * html/parser/HTMLTreeBuilder.cpp:
        * loader/CrossOriginAccessControl.cpp:
        (WebCore::passesAccessControlCheck):
        * page/Location.cpp:
        (WebCore::Location::search):
        (WebCore::Location::hash):
        * page/NavigatorBase.cpp:
        (WebCore::NavigatorBase::platform):
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::writeImageToDataObject):
        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::PasteboardHelper::fillSelectionData):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::encodeBasicAuthorization):
        * platform/network/cf/SocketStreamHandleCFNet.cpp:
        (WebCore::SocketStreamHandle::copyCFStreamDescription):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::encodeBasicAuthorization):
        * workers/WorkerLocation.cpp:
        (WebCore::WorkerLocation::search):
        (WebCore::WorkerLocation::hash):

2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        String operator+ reallocates unnecessarily when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::keyboardShortcut): Cast to String first, before trying to convert to platform dependant type.
        * src/WebHTTPLoadInfo.cpp:
        (WebKit::addHeader): Don't pass WebString to makeString, explicit cast to String first.
        * tests/IDBLevelDBCodingTest.cpp: Cast to String first, to avoid conflicting with gtests global templatified operator+.
        (IDBLevelDBCoding::TEST):

2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        String operator+ reallocates unnecessarily when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

        * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
        (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):

2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Darin Adler.

        String operator+ reallocates unnecessarily when concatting > 2 strings
        https://bugs.webkit.org/show_bug.cgi?id=58420

        Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6da15387
    • commit-queue@webkit.org's avatar
      2011-05-12 Young Han Lee <joybro@company100.net> · 137c8c08
      commit-queue@webkit.org authored 
              Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement layoutTestController.layerTreeAsText()
        https://bugs.webkit.org/show_bug.cgi?id=60367

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::layerTreeAsText):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-05-12  Young Han Lee  <joybro@company100.net>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement layoutTestController.layerTreeAsText()
        https://bugs.webkit.org/show_bug.cgi?id=60367

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::layerTreeAsText):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      137c8c08
    • yurys@chromium.org's avatar
      2011-05-10 Yury Semikhatsky <yurys@chromium.org> · 8fd974c4
      yurys@chromium.org authored 
              Reviewed by Pavel Feldman.

        Web Inspector: test that eval can access scoped variables in console
        https://bugs.webkit.org/show_bug.cgi?id=60547

        * inspector/console/console-eval-scoped-expected.txt: Added.
        * inspector/console/console-eval-scoped.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fd974c4
    • yurys@chromium.org's avatar
      2011-05-06 Yury Semikhatsky <yurys@chromium.org> · a5236926
      yurys@chromium.org authored 
              Reviewed by Pavel Feldman.

        Web Inspector: move agents from InspectorAgent to InspectorController
        https://bugs.webkit.org/show_bug.cgi?id=60359

        All inspector agents are now created and owned by InspectorController which
        in turned is owned by the inspected Page. InspectorInstrumentation gets access
        to the instrumenting agents by means of InspectorAgent::instrumentingAgents().

        In addition to managing inspector agents lifetime InspectorController sets
        InspectorFronted on the agents when the front-end is connected.

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::~InspectorAgent):
        (WebCore::InspectorAgent::inspectedPageDestroyed):
        (WebCore::InspectorAgent::restore):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::clearFrontend):
        * inspector/InspectorAgent.h: all accessors to other agents were removed along with
        the agents themselves from InspectorAgent. Every agent that depends on some other agents
        receives pointers to them explicitely in its constructor. All access to the agents
        from WebCore should go through InspectorInstrumentation which retrieves corresponding
        agents using InstrumentingAgents structure which represents the set of active agents.
        (WebCore::InspectorAgent::instrumentingAgents):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::startTimelineProfiler):
        (WebCore::InspectorController::stopTimelineProfiler):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::drawNodeHighlight):
        (WebCore::InspectorController::inspect):
        (WebCore::InspectorController::timelineProfilerEnabled):
        (WebCore::InspectorController::hideHighlight):
        (WebCore::InspectorController::highlightedNode):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::profilerEnabled):
        (WebCore::InspectorController::debuggerEnabled):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        (WebCore::InspectorController::isRecordingUserInitiatedProfile):
        (WebCore::InspectorController::resume):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
        (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::consoleCountImpl):
        (WebCore::InspectorInstrumentation::startConsoleTimingImpl):
        (WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
        * page/Page.cpp:
        (WebCore::Page::~Page): we send two notifications when inspected Page is being
        destroyed: one to the inspector instrumentation and another one to the InspectorController
        which is owned by the Page.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5236926
    • tonyg@chromium.org's avatar
      2011-05-12 Tony Gentilcore <tonyg@chromium.org> · d9ed976e
      tonyg@chromium.org authored 
              Build fix: include ExceptionCode.h
        https://bugs.webkit.org/show_bug.cgi?id=60694

        * dom/Range.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9ed976e
    • tonyg@chromium.org's avatar
      2011-05-10 Tony Gentilcore <tonyg@chromium.org> · 4b0a55f4
      tonyg@chromium.org authored 
              Reviewed by Darin Adler.

        Perform some forward declarations suggested by include-what-you-use
        https://bugs.webkit.org/show_bug.cgi?id=60545

        * accessibility/AccessibilityObject.cpp:
        * accessibility/AccessibilityRenderObject.cpp:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        * dom/DocumentMarkerController.cpp:
        * dom/Position.cpp:
        * dom/PositionIterator.cpp:
        * dom/Range.cpp:
        * editing/ApplyBlockElementCommand.cpp:
        * editing/ApplyStyleCommand.cpp:
        * editing/Editor.cpp:
        * editing/EditorCommand.cpp:
        * editing/FrameSelection.cpp:
        * editing/HTMLInterchange.cpp:
        * editing/IndentOutdentCommand.cpp:
        * editing/ReplaceSelectionCommand.cpp:
        * editing/SpellChecker.h:
        * editing/SpellingCorrectionCommand.cpp:
        * editing/SpellingCorrectionController.h:
        * editing/TextCheckingHelper.cpp:
        * editing/TextIterator.h:
        * editing/htmlediting.h:
        * editing/markup.cpp:
        * editing/visible_units.cpp:
        * editing/visible_units.h:
        * fileapi/DOMFileSystem.cpp:
        * fileapi/DirectoryReaderSync.cpp:
        * fileapi/DirectoryReaderSync.h:
        * fileapi/FileEntry.h:
        * fileapi/FileWriter.h:
        * fileapi/FileWriterBase.h:
        * fileapi/FileWriterSync.h:
        * history/CachedFrame.cpp:
        * history/CachedPage.cpp:
        * history/HistoryItem.cpp:
        * history/HistoryItem.h:
        * history/PageCache.h:
        * loader/HistoryController.h:
        * loader/PingLoader.h:
        * loader/ResourceLoader.h:
        * loader/appcache/DOMApplicationCache.h:
        * loader/cache/CachedCSSStyleSheet.h:
        * loader/cache/CachedFont.cpp:
        * loader/cache/CachedFont.h:
        * loader/cache/CachedResourceRequest.cpp:
        * loader/cache/CachedResourceRequest.h:
        * loader/cache/MemoryCache.h:
        * notifications/Notification.cpp:
        * notifications/Notification.h:
        * notifications/NotificationCenter.cpp:
        * notifications/NotificationCenter.h:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/DOMSelection.cpp:
        * page/DOMTimer.h:
        * page/DOMWindow.cpp:
        * page/EventHandler.cpp:
        * page/FocusController.h:
        * page/Geolocation.cpp:
        * page/Geolocation.h:
        * page/History.cpp:
        * rendering/RenderListBox.cpp:
        * workers/WorkerContext.cpp:
2011-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Perform some forward declarations suggested by include-what-you-use
        https://bugs.webkit.org/show_bug.cgi?id=60545

        * src/WebHistoryItem.cpp:
        * src/WebNotification.cpp:
        * src/WebTextCheckingCompletionImpl.cpp:
        * src/mac/WebSubstringUtil.mm:
2011-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Perform some forward declarations suggested by include-what-you-use
        https://bugs.webkit.org/show_bug.cgi?id=60545

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        * WebView/WebFrame.mm:
2011-05-10  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Adler.

        Perform some forward declarations suggested by include-what-you-use
        https://bugs.webkit.org/show_bug.cgi?id=60545

        * WebProcess/WebPage/mac/WebPageMac.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0a55f4
    • ossy@webkit.org's avatar
      Add new expected files after r86313. · 99639868
      ossy@webkit.org authored 
      * platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
* platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Added.
* platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Added.
* platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Added.
* platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Added.
* platform/qt-arm/transforms/svg-vs-css-expected.txt: Added.
* platform/qt-mac/Skipped: Add plugins/get-targeted-javascript-url.html because of missing plugin.getURLNotify() implementation
* platform/qt-mac/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
* platform/qt-mac/transforms/2d/transform-borderbox-expected.txt: Added.
* platform/qt-mac/transforms/2d/transform-origin-borderbox-expected.txt: Added.
* platform/qt-mac/transforms/2d/zoom-menulist-expected.txt: Added.
* platform/qt-mac/transforms/no_transform_hit_testing-expected.txt: Added.
* platform/qt-mac/transforms/svg-vs-css-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99639868
    • philn@webkit.org's avatar
      2011-05-12 Philippe Normand <pnormand@igalia.com> · 3ec0746a
      philn@webkit.org authored 
              Unreviewed, GTK rebaseline after r86307.

        * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
        * platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ec0746a
    • yutak@chromium.org's avatar
      2011-05-12 Yuta Kitamura <yutak@chromium.org> · 5819c99c
      yutak@chromium.org authored 
              Unreviewed. Update Qt test expectations affected in r86320.

        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5819c99c
    • yutak@chromium.org's avatar
      2011-05-12 Yuta Kitamura <yutak@chromium.org> · db59e854
      yutak@chromium.org authored 
              Unreviewed, another attempt of build fix.

        * websockets/CloseEvent.h:
        * websockets/CloseEvent.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db59e854
    • yutak@chromium.org's avatar
      2011-05-12 Yuta Kitamura <yutak@chromium.org> · af32aa65
      yutak@chromium.org authored 
              Unreviewed, trying to fix Qt minimal compile.

        * websockets/CloseEvent.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af32aa65
    • commit-queue@webkit.org's avatar
      2011-05-12 ojab <ojab@ojab.ru> · cc4f3881
      commit-queue@webkit.org authored 
              Reviewed by Eric Seidel.

        Fix build with --disable-video --enable-fullscreen-api
        https://bugs.webkit.org/show_bug.cgi?id=60542

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc4f3881
    • philn@webkit.org's avatar
      2011-05-12 Philippe Normand <pnormand@igalia.com> · 2dd519d7
      philn@webkit.org authored 
              Unreviewed, GTK build fix.

        * wtf/Platform.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd519d7
    • carlosgc@webkit.org's avatar
      2011-05-12 Carlos Garcia Campos <cgarcia@igalia.com> · 189c2d54
      carlosgc@webkit.org authored 
              Reviewed by Martin Robinson.

        Fix the build with ENABLE_PLUGIN_PROCESS
        https://bugs.webkit.org/show_bug.cgi?id=60628

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::initialize): Move the call to
        pluginController->isAcceleratedCompositingEnabled() to a #ifdef block.
        * WebProcess/Plugins/PluginProxy.h: Add include for <WebCore/IntRect.h>.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      189c2d54
    • commit-queue@webkit.org's avatar
      2011-05-12 Keith Kyzivat <keith.kyzivat@nokia.com> · 96624d14
      commit-queue@webkit.org authored 
              Reviewed by Csaba Osztrogonác.

        [Qt] Arm debug build failing on ARMAssembler::debugOffset()
        https://bugs.webkit.org/show_bug.cgi?id=60688

        Related to svn rev 85523

        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::debugOffset):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96624d14
    • yutak@chromium.org's avatar
      2011-05-12 Yuta Kitamura <yutak@chromium.org> · 854c86ea
      yutak@chromium.org authored 
              Reviewed by Kent Tamura.

        WebSocket add new event: CloseEvent
        https://bugs.webkit.org/show_bug.cgi?id=35573

        Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
        I modified the test close-event.html slightly so that it passes on Chromium.
        I also updated a few test results that are affected by this change.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:
        * http/tests/websocket/tests/close-event-expected.txt: Added.
        * http/tests/websocket/tests/close-event.html: Added.
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
2011-05-12  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket add new event: CloseEvent
        https://bugs.webkit.org/show_bug.cgi?id=35573

        Original patch was written by Fumitoshi Ukai <ukai@chromium.org>.
        I added CloseEvent constructor to DOMWindow, so it can be referred
        in the new test (close-event.html).

        Test: http/tests/websocket/tests/close-event.html

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8):
        * dom/Event.cpp:
        (WebCore::Event::isCloseEvent):
        * dom/Event.h:
        * page/DOMWindow.idl: Add CloseEvent constructor.
        * websockets/CloseEvent.h: Added.
        (WebCore::CloseEvent::isCloseEvent):
        (WebCore::CloseEvent::create):
        (WebCore::CloseEvent::initCloseEvent):
        (WebCore::CloseEvent::wasClean):
        (WebCore::CloseEvent::CloseEvent):
        * websockets/CloseEvent.idl: Added.
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::didClose):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      854c86ea
    • commit-queue@webkit.org's avatar
      2011-05-12 Ben Wells <benwells@chromium.org> · 550a18c6
      commit-queue@webkit.org authored 
              Reviewed by Simon Fraser.

        RGBA colors in outlines show overpainting at the corners
        https://bugs.webkit.org/show_bug.cgi?id=58999

        * fast/borders/outline-alpha-block.html: Added.
        * fast/borders/outline-alpha-inline.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/borders/outline-alpha-block-expected.png: Added.
        * platform/mac/fast/borders/outline-alpha-block-expected.txt: Added.
        * platform/mac/fast/borders/outline-alpha-inline-expected.png: Added.
        * platform/mac/fast/borders/outline-alpha-inline-expected.txt: Added.
        * platform/mac/fast/box-shadow/box-shadow-radius-expected.png: Rebaselined as this test had rgba outlines.
        * platform/mac/fast/layers/self-painting-outline-expected.png: Rebaselined as this test had rgba outlines.
2011-05-12  Ben Wells  <benwells@chromium.org>

        Reviewed by Simon Fraser.

        RGBA colors in outlines show overpainting at the corners
        https://bugs.webkit.org/show_bug.cgi?id=58999

        Tests: fast/borders/outline-alpha-block.html
               fast/borders/outline-alpha-inline.html

        Updated baseline images for tests with rgba outlines:
               fast/box-shadow/box-shadow-radius.html
               fast/layers/self-painting-outline.html

         * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paintOutline):
        (WebCore::RenderInline::paintOutlineForLine):
        * rendering/RenderInline.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintOutline):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      550a18c6
    • commit-queue@webkit.org's avatar
      2011-05-11 Srinivasulu Chereddy <Srinivasulu.Chereddy@nokia.com> · aa3fc337
      commit-queue@webkit.org authored 
              Reviewed by Eric Seidel.

        [Qt] Expected results for 6 new CSS3 transforms tests and the updated skipped list
        https://bugs.webkit.org/show_bug.cgi?id=60654

        * platform/qt/Skipped:
        * platform/qt/fast/transforms/transform-positioned-ancestor-expected.png: Added.
        * platform/qt/fast/transforms/transform-positioned-ancestor-expected.txt: Added.
        * platform/qt/transforms/2d/transform-borderbox-expected.png: Added.
        * platform/qt/transforms/2d/transform-borderbox-expected.txt: Added.
        * platform/qt/transforms/2d/transform-origin-borderbox-expected.png: Added.
        * platform/qt/transforms/2d/transform-origin-borderbox-expected.txt: Added.
        * platform/qt/transforms/2d/zoom-menulist-expected.png: Added.
        * platform/qt/transforms/2d/zoom-menulist-expected.txt: Added.
        * platform/qt/transforms/no_transform_hit_testing-expected.png: Added.
        * platform/qt/transforms/no_transform_hit_testing-expected.txt: Added.
        * platform/qt/transforms/svg-vs-css-expected.png: Added.
        * platform/qt/transforms/svg-vs-css-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa3fc337
  3. 11 May, 2011 17 commits