1. 12 Aug, 2009 38 commits
    • xan@webkit.org's avatar
      2009-08-12 Xan Lopez <xlopez@igalia.com> · aa5bf36f
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              [GTK] Remove keyring optional features
              https://bugs.webkit.org/show_bug.cgi?id=28173
      
              Remove keyring support, we now do authentication storage through
              libsoup. We depend on libsoup master now, will bump the dependency
              when there's a new release.
      
              * GNUmakefile.am:
              * configure.ac:
      
      WebKit/gtk:
      
      2009-08-12  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Jan Alonzo.
      
              [GTK] Remove keyring optional features
              https://bugs.webkit.org/show_bug.cgi?id=28173
      
              Remove keyring support from our code and rely on libsoup to store
              the authentication data if the user requests that support in their
              application/library.
      
              * webkit/webkitsoupauthdialog.c:
              (response_callback):
              (show_auth_dialog):
              (session_authenticate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa5bf36f
    • eric@webkit.org's avatar
      2009-08-12 Eric Seidel <eric@webkit.org> · 1a6c9142
      eric@webkit.org authored
              No review, just skipping tests to make the bots green.
      
              REGRESSION (r47110): 4 media regressions on the bots
              https://bugs.webkit.org/show_bug.cgi?id=28221
      
              Skipping these until Eric Carlson has a fix.
      
              * platform/mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a6c9142
    • pkasting@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=27965 · 566436bb
      pkasting@chromium.org authored
      Merge wx/ImageSourceWx.cpp into ImageSource.cpp.  No changes to
      ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.
      
      Reviewed by Adam Treat.
      
      * WebCore.gypi:
      * WebCoreSources.bkl:
      * platform/graphics/wx/ImageSourceWx.cpp: Removed.
      * webcore-wx.bkl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      566436bb
    • pkasting@chromium.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=27933 · b8dd3c63
      pkasting@chromium.org authored
      Build fix after r47099.
      
      Reviewed by Dave Levin.
      
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::getImageData):
      (WebCore::putImageData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8dd3c63
    • kevino@webkit.org's avatar
      wx waf build fix, add new directories to the build. · 3e018ad1
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e018ad1
    • kevino@webkit.org's avatar
      a1cd4485
    • cfleizach@apple.com's avatar
      Bug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard · 593c920d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=28219
      
      Reviewed by Eric Seidel.
      
      * platform/mac-snowleopard/Skipped:
      * platform/mac/accessibility/string-range-contains-listmarker.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      593c920d
    • aroben@apple.com's avatar
      Remove support for a window resizer within the WebView · 3de9b76e
      aroben@apple.com authored
      WebKit/win:
      
      Starting with Safari 4, there is never a window resizer inside the
      WebView, so we no longer need to support that functionality.
      
      Fixes <http://webkit.org/b/28190> Remove support for a window resizer
      within the WebView
      
      Reviewed by Dave Hyatt.
      
      * Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
      functions related to the window resizer with unused*() functions. We
      can't remove them entirely because we need to keep the vtable
      unchanged so new versions of WebKit will work with old versions of
      Safari (e.g., for nightlies and WebKit development).
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::windowResizerRect): Now always returns an empty
      rect.
      
      * WebView.cpp:
      (WebView::paint):
      (WebView::handleMouseEvent):
      * WebView.h:
      Removed window-resizer-related code.
      
      WebKitTools:
      
      Update DumpRenderTree for IWebUIDelegatePrivate changes
      
      Reviewed by Dave Hyatt.
      
      * DumpRenderTree/win/UIDelegate.h: Updated to match
      IWebUIDelegatePrivate.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3de9b76e
    • aroben@apple.com's avatar
      Don't try to seek to the end of stdin on Cygwin · c90c49e1
      aroben@apple.com authored
      Doing so seems to always cause an exception (for unknown reasons).
      
      Fixes <http://webkit.org/b/28159> create-bug throws an exception in
      Cygwin
      
      Reviewed by Dave Kilzer.
      
      * Scripts/bugzilla-tool:
      (CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
      generated by calling sys.stdin.seek, since these seem to be generated
      for no good reason on Cygwin.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c90c49e1
    • aroben@apple.com's avatar
      Don't raise an exception when --cc is not passed to create-bug · 2055b062
      aroben@apple.com authored
      Fixes <http://webkit.org/b/28158> create-bug throws an exception if
      --cc is not specified
      
      Reviewed by Dave Kilzer.
      
      * Scripts/modules/bugzilla.py:
      (Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
      string was specified. Otherwise we'll generate an exception about the
      "cc" variable not being a string.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2055b062
    • bolsinga@apple.com's avatar
      Add delegate methods about focus and blur and state change · 2c9ee0a6
      bolsinga@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=27153
      
      Reviewed by Eric Seidel.
      
      Have ObjC delegate methods match C++ method names in the ChromeClient.
      
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::formDidFocus):
      (WebChromeClient::formDidBlur):
      * WebView/WebUIDelegatePrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9ee0a6
    • treat@webkit.org's avatar
      WINCE PORT: Implement Path for WINCE. Most code can be · cf044eba
      treat@webkit.org authored
      reused for other ports that don't have native path support
      https://bugs.webkit.org/show_bug.cgi?id=28188
      
      Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
      Reviewed by Adam Treat.
      
      Written also by George Staikos (including quadCurve() and bezier())
      
      * platform/graphics/wince/PathWince.cpp: Added.
      * platform/graphics/wince/PlatformPathWince.cpp: Added.
      * platform/graphics/wince/PlatformPathWince.h: Added.
      * platform/graphics/wince/WinceGraphicsExtras.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf044eba
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · f7b25a35
      eric.carlson@apple.com authored
              Windows build fix.
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::localizedMediaTimeDescription):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7b25a35
    • eric@webkit.org's avatar
      2009-08-12 Joseph Pecoraro <joepeck02@gmail.com> · 49ae4a16
      eric@webkit.org authored
              "Double-click to add" new style button does not always show up [quick fix]
              https://bugs.webkit.org/show_bug.cgi?id=28187
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ae4a16
    • eric@webkit.org's avatar
      2009-08-12 Crystal Zhang <crystal.zhang@torchmobile.com> · dbf8a2a6
      eric@webkit.org authored
              Reviewed by George Staikos.
      
              WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
              https://bugs.webkit.org/show_bug.cgi?id=28178
      
              * platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
              * platform/graphics/wince/MediaPlayerProxy.cpp: Added.
              * platform/graphics/wince/MediaPlayerProxy.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbf8a2a6
    • eric@webkit.org's avatar
      2009-08-12 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 0a2a5bb8
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
              https://bugs.webkit.org/show_bug.cgi?id=28175
      
              Call QDir::toNativeSeparators() before the path is passed to the OS.
      
              Based on work by David Leong.
      
              * platform/qt/FileSystemQt.cpp:
              (WebCore::pathByAppendingComponent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a2a5bb8
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · 6a6009e7
      eric.carlson@apple.com authored
              Tiger build fix.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm: 
                  Define NSAccessibilityTimelineSubrole for Tiger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a6009e7
    • krit@webkit.org's avatar
      2009-08-12 Dirk Schulze <krit@webkit.org> · a046f09a
      krit@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
              of getImageData. This changed since r47099.
      
              * platform/graphics/filters/FEColorMatrix.cpp:
              (WebCore::FEColorMatrix::apply):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a046f09a
    • eric@webkit.org's avatar
      2009-08-11 Eric Seidel <eric@webkit.org> · e48267e6
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              bugzilla-tool : various improvements for running the commit-queue
              https://bugs.webkit.org/show_bug.cgi?id=28199
      
              Make run_and_throw_if_fail silence STDERR as well as STDIN.
              I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
              Change a few "print" statements to "log" so they appear in the output.
              Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
              Added a little more logging so that --quiet mode is easier to understand.
              Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
              Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
              Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
              Made curl call (downloading patch files) quieter.
      
              * Scripts/bugzilla-tool:
              * Scripts/modules/bugzilla.py:
              * Scripts/modules/scm.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e48267e6
    • eric.carlson@apple.com's avatar
      2009-08-12 Eric Carlson <eric.carlson@apple.com> · cd791f33
      eric.carlson@apple.com authored
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Test: accessibility/media-element.html
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
                  Add AccessibilityMediaControls.cpp/.h
      
              * accessibility/AXObjectCache.cpp:
              * accessibility/AXObjectCache.h:
              (WebCore::AXObjectCache::getOrCreate):
                  Create AccessibilityMediaControl. Update Copyright
      
              * accessibility/AccessibilityMediaControls.cpp:
              * accessibility/AccessibilityMediaControls.h:
                  Added.
      
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityObject.h:
                  Add isMediaTimeline. Update Copyright.
      
              * accessibility/AccessibilitySlider.h:
                  Make constructor protected instead of private so AccessibilityMediaTimeline can
                  call it.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
                  Add NSAccessibilityValueDescriptionAttribute to range attributes. 
              (-[AccessibilityObjectWrapper subrole]):
                  Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.
      
              * dom/Node.h:
                  add isMediaControlElement.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/LocalizedStrings.h:
              * platform/mac/LocalizedStringsMac.mm:
              (WebCore::localizedMediaControlElementString): 
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription): 
                  New, return localized media controller strings.
      
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlElement::MediaControlElement):
                  Initialize m_displayType.
              (WebCore::MediaControlElement::MediaControlElement):
              (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
                  Fix style.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  Set m_displayType based on pseudo style ID.
              (WebCore::MediaControlInputElement::MediaControlInputElement):
                  rename local "o" to "object".
              (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
              (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
              (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
              (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
              (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
              (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
                  Update for MediaControlInputElement constructor change.
              (WebCore::MediaControlTimeDisplayElement::formatTime):
                  New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
              (WebCore::MediaControlTimeDisplayElement::setCurrentValue):
                  New, set text to current time.
              * rendering/MediaControlElements.h:
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::updateControls):
                  Create controls in tab order.
              (WebCore::RenderMedia::formatTime):
                  Moved to MediaControlTimeDisplayElement::formatTime.
              (WebCore::RenderMedia::updateTimeDisplay):
                  Call MediaControlTimeDisplayElement::setCurrentValue.
              * rendering/RenderMedia.h:
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              Add localized strings for media controller accessiblility.
      
              * English.lproj/Localizable.strings:
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory localizedMediaControlElementString:]):
              (-[WebViewFactory localizedMediaControlElementHelpText:]):
              (-[WebViewFactory localizedMediaTimeDescription:]):
                  New.
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::localizedMediaControlElementString):
              (WebCore::localizedMediaControlElementHelpText):
              (WebCore::localizedMediaTimeDescription):
                  New.
      
      2009-08-12  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Oliver Hunt.
      
              <video> and <audio> controller should be accessible
              https://bugs.webkit.org/show_bug.cgi?id=28081
      
              * accessibility/media-element.html: Added.
              * platform/mac-leopard/accessibility/media-element-expected.txt:
              * platform/mac-leopard/media/controls-strict-expected.txt: 
              * platform/mac/accessibility/media-element-expected.txt:
                  Added.
      
              * platform/mac-leopard/media/controls-after-reload-expected.txt:
              * platform/mac-leopard/media/controls-styling-expected.txt:
              * platform/mac-leopard/media/video-empty-source-expected.txt:
              * platform/mac-leopard/media/video-zoom-controls-expected.txt:
              * media/video-controls-visible-audio-only.html:
              * platform/mac-leopard/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/audio-controls-rendering-expected.txt:
              * platform/mac/media/controls-after-reload-expected.txt:
              * platform/mac/media/controls-styling-expected.txt:
              * platform/mac/media/video-controls-rendering-expected.txt:
              * platform/mac/media/video-display-toggle-expected.txt:
              * platform/mac/media/video-empty-source-expected.txt:
              * platform/mac/media/video-zoom-controls-expected.txt:
                  Update for controller element tab order change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd791f33
    • eric@webkit.org's avatar
      2009-08-11 Eric Seidel <eric@webkit.org> · ccc8de18
      eric@webkit.org authored
              No review, script regression fix only.
      
              run-webkit-tests --quiet hangs
              https://bugs.webkit.org/show_bug.cgi?id=28202
      
              Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
              This was what I came up with after discussions in #perl.
      
              * Scripts/run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc8de18
    • dglazkov@chromium.org's avatar
      2009-08-12 Viet-Trung Luu <viettrungluu@gmail.com> · 57ffe78b
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Explicitly set control tints for Chromium/Mac, since the controls'
              NSCell(s) lack an NSView and hence their tint isn't updated
              automatically when the application is activated/deactivated.
              https://bugs.webkit.org/show_bug.cgi?id=28108
              http://crbug.com/18199
      
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::updateNSCellControlTint):
              (WebCore::RenderThemeChromiumMac::paintCheckbox):
              (WebCore::RenderThemeChromiumMac::paintRadio):
              (WebCore::RenderThemeChromiumMac::paintButton):
              (WebCore::RenderThemeChromiumMac::paintMenuList):
              (WebCore::RenderThemeChromiumMac::paintSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintSearchField):
              (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton):
              (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration):
              (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57ffe78b
    • beidson@apple.com's avatar
      (no review) Disabling a failing test. · e25273c4
      beidson@apple.com authored
      <rdar://problem/7136851> platform/mac/accessibility/string-range-contains-listmarker.html fails.
      
      * platform/mac-snowleopard/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e25273c4
    • dglazkov@chromium.org's avatar
      2009-08-12 Christian Plesner Hansen <christian.plesner.hansen@gmail.com> · 724bff15
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Fix atomic string externalization crash.
              Atomic string externalization assumes that all non-empty strings
              can be externalized which is untrue on 64-bit.  This change fixed
              that.
      
              https://bugs.webkit.org/show_bug.cgi?id=28215
      
              This bug causes loads of test crashes, no need to add new tests
              specifically for this.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::v8StringToAtomicWebCoreString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      724bff15
    • ariya@webkit.org's avatar
      WebCore/ChangeLog: · c7d5cf16
      ariya@webkit.org authored
      2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>
      
              Reviewed by Holger Freyther.
      
              [Qt] Fix box-shadow painting in r47103. The edge should not be blurry.
              Also optimize by not having to save and restore painter state.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::drawRect):
              (WebCore::GraphicsContext::fillRect):
      
      LayoutTests/ChangeLog:
      
      2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>
      
              Reviewed by Holger Hans Peter Freyther.
      
              [Qt] Update the pixel tests for shadow edge fix.
      
              * platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
              * platform/qt/fast/box-shadow/basic-shadows-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7d5cf16
    • ariya@webkit.org's avatar
      2009-08-12 Ariya Hidayat <ariya.hidayat@nokia.com> · 8d43ffa1
      ariya@webkit.org authored
              Reviewed by Adam Treat.
      
              [Qt] Fix coding style in GraphicsContextQt.cpp
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::toQtCompositionMode):
              (WebCore::toQtLineCap):
              (WebCore::toQtLineJoin):
              (WebCore::GraphicsContextPlatformPrivate::p):
              (WebCore::GraphicsContext::drawLine):
              (WebCore::GraphicsContext::strokeArc):
              (WebCore::GraphicsContext::drawConvexPolygon):
              (WebCore::GraphicsContext::pen):
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::clipPath):
              (WebCore::GraphicsContext::drawFocusRing):
              (WebCore::GraphicsContext::beginTransparencyLayer):
              (WebCore::GraphicsContext::endTransparencyLayer):
              (WebCore::GraphicsContext::clearRect):
              (WebCore::GraphicsContext::setLineCap):
              (WebCore::GraphicsContext::setLineJoin):
              (WebCore::GraphicsContext::setMiterLimit):
              (WebCore::GraphicsContext::setAlpha):
              (WebCore::GraphicsContext::clipOut):
              (WebCore::GraphicsContext::clipOutEllipseInRect):
              (WebCore::GraphicsContext::addInnerRoundedRectClip):
              (WebCore::GraphicsContext::setPlatformStrokeColor):
              (WebCore::GraphicsContext::setPlatformStrokeStyle):
              (WebCore::GraphicsContext::setPlatformStrokeThickness):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d43ffa1
    • ariya@webkit.org's avatar
      WebCore/ChangeLog: · 9b69ed48
      ariya@webkit.org authored
      2009-08-12  Szabo Carol  <carol.szabo@nokia.com>
      
              Reviewed by Simon Hausmann and Ariya Hidayat.
      
              https://bugs.webkit.org/show_bug.cgi?id=23291
      
              [Qt] Partial support for -webkit-box-shadow. Blur is not support and
              the shadow still does not go well with border radius.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::drawRect):
              (WebCore::GraphicsContext::fillRect):
      
      LayoutTests/ChangeLog:
      
      2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Pixel tests for (partial) -webkit-box-shadow support.
      
              * platform/qt/Skipped: Include basic-shadows.
              * platform/qt/fast/box-shadow/basic-shadows-expected.checksum: Added.
              * platform/qt/fast/box-shadow/basic-shadows-expected.png: Added.
              * platform/qt/fast/box-shadow/basic-shadows-expected.txt: Adjusted.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b69ed48
    • ariya@webkit.org's avatar
      2009-08-12 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu> · c18664e8
      ariya@webkit.org authored
              Reviewed by Ariya Hidayat.
      
              Build fix: use std::numeric_limits<long long>::min() instead of LLONG_MIN
              since LLONG_MIN is not defined in standard c++.
      
              * runtime/UString.cpp:
              (JSC::UString::from):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c18664e8
    • hausmann@webkit.org's avatar
      QtWebKit compile fix for Windows CE · 8589e7ad
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-08-12
      Reviewed by Simon Hausmann.
      
      There's no getenv on Windows CE, use qgetenv instead.
      
      * Api/qwebpage.cpp:
      (qt_drt_overwritePluginDirectories):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8589e7ad
    • xan@webkit.org's avatar
      2009-08-12 Xan Lopez <xlopez@igalia.com> · 4d584889
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Use AM_V_GEN in a few more places, for less noisy builds.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d584889
    • krit@webkit.org's avatar
      2009-08-12 Dirk Schulze <krit@webkit.org> · acfb1ce8
      krit@webkit.org authored
              Reviewed by Oliver Hunt.
      
              SVG Filter premultiplied color support for getImageDate/putImageData
              [https://bugs.webkit.org/show_bug.cgi?id=27933]
      
              Some SVG Filters need premultiplied ImageData for the calculation. Therefore getImageData
              and putImageData of ImageBuffer need support for premultiplied colors.
      
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::getImageData):
              (WebCore::CanvasRenderingContext2D::putImageData):
              * platform/graphics/ImageBuffer.h:
              (WebCore::):
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/cg/ImageBufferCG.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/qt/ImageBufferQt.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/skia/ImageBufferSkia.cpp:
              (WebCore::getImageData):
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::putImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * platform/graphics/wx/ImageBufferWx.cpp:
              (WebCore::ImageBuffer::getUnmultipliedImageData):
              (WebCore::ImageBuffer::getPremultipliedImageData):
              (WebCore::ImageBuffer::putUnmultipliedImageData):
              (WebCore::ImageBuffer::putPremultipliedImageData):
              * svg/graphics/SVGResourceMasker.cpp:
              (WebCore::SVGResourceMasker::applyMask):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acfb1ce8
    • xan@webkit.org's avatar
      2009-08-12 Benjamin Otte <otte@gnome.org> · 703b6eb5
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Buildfix for Gtk platforms debug builds.
      
              * GNUmakefile.am: Choose MarkStackPosix.cpp or MarkStackWin.cpp
              depending on platform.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      703b6eb5
    • hausmann@webkit.org's avatar
      Prospective build fix for Mac and 32-bit Windows. · 3715dc9f
      hausmann@webkit.org authored
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-12
      * runtime/UString.cpp: Include wtf/StringExtras.h for snprintf.
      (JSC::UString::from): Use %lld instead of %I64d for snprintf
      on non-windows platforms.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3715dc9f
    • hausmann@webkit.org's avatar
      Fix compile error on 64Bit Windows, when UString::from · 06bd2133
      hausmann@webkit.org authored
      is called with an intptr_t.
      
      Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
      Reviewed by Simon Hausmann.
      
      Added new UString::From overload with long long parameter.
      
      Thanks to Holger for the long long idea.
      
      * runtime/UString.cpp:
      (JSC::UString::from):
      * runtime/UString.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06bd2133
    • pfeldman@chromium.org's avatar
      2009-08-12 Mikhail Naganov <mnaganov@chromium.org> · 6edaa93e
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Changed Number.bytesToString to support low-resolution output.
      
              https://bugs.webkit.org/show_bug.cgi?id=28146
      
              * inspector/front-end/utilities.js:
              (Number.bytesToString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6edaa93e
    • hausmann@webkit.org's avatar
      Add support for hooking BeginPaint/EndPaint on 64Bit Windows · 3f1ee5c2
      hausmann@webkit.org authored
      Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
      Reviewed by Simon Hausmann.
      
      Webkit uses the runtime patching trick explained by "Feng Yuan" for
      hooking these paint functions. It currently supports only 32bit assembly
      code. This patch adds support for 64Bit version. Since inline-assemblies
      are not supported for 64Bit, we have use a seperate .asm file.
      
      * WebCore.pro:
      * plugins/win/PaintHooks.asm: Added.
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::hookedBeginPaint):
      (WebCore::PluginView::hookedEndPaint):
      (WebCore::hook):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f1ee5c2
    • oliver@apple.com's avatar
      Minor style fixes in previous patch and changelog correction. · 6c0791ce
      oliver@apple.com authored
      Reviewed by Mark Rowe
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c0791ce
    • oliver@apple.com's avatar
      Make it harder to misuse try* allocation routines · 81284ba6
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=27469
      
      Reviewed by Gavin Barraclough
      
      Jump through a few hoops to make it much harder to accidentally
      miss null-checking of values returned by the try-* allocation
      routines.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81284ba6
  2. 11 Aug, 2009 2 commits