1. 13 May, 2008 25 commits
    • timothy@apple.com's avatar
      Adds an event loop abstraction to platform. This abstraction will be · a9922b67
      timothy@apple.com authored
      used by the JavaScriptDebugServer to implement pausing.
      
      Reviewed by Kevin McCullough.
      
      * platform/EventLoop.h: Added.
      (WebCore::EventLoop::EventLoop):
      (WebCore::EventLoop::ended): Return m_ended.
      * platform/mac/EventLoopMac.mm: Added.
      (WebCore::EventLoop::cycle): Call nextEventMatchingMask and then sendEvent.
      * platform/win/EventLoopWin.cpp: Added.
      (WebCore::EventLoop::cycle): Call GetMessage, TranslateMessage and DispatchMessage.
      * WebCore.xcodeproj/project.pbxproj: Add new files.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9922b67
    • timothy@apple.com's avatar
      Breaks out ObjectPropertiesSection from PropertiesSidebarPane · c6e45715
      timothy@apple.com authored
      so it can be used by the Scripts panel's Scope Chain pane.
      
      Rubber-stamped by Adam Roben.
      
      * page/inspector/ObjectPropertiesSection.js: Added.
      * page/inspector/PropertiesSidebarPane.js: Moved ObjectPropertiesSection
      to ObjectPropertiesSection.js.
      * WebCore.vcproj/WebCore.vcproj: Add the new file.
      * page/inspector/WebKit.qrc: Ditto.
      * page/inspector/inspector.html: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6e45715
    • timothy@apple.com's avatar
      Add a helper function to the Inspector's Array prototype · 0b65c0b6
      timothy@apple.com authored
      that will remove any identical values/objects from the array.
      
      Reviewed by Kevin McCullough.
      
      * page/inspector/utilities.js:
      (Array.prototype.remove): Iterate over the array and strict
      compare to the passed in value. If they match, splice that index
      out of the array. If onlyFirst is true, return after the first splice.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b65c0b6
    • timothy@apple.com's avatar
      Adds a JavaScriptCallFrame object and JavaScript binding with an IDL. · dec8c517
      timothy@apple.com authored
      This object will expose the stack to the Inspector's debugger.
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make: Add JavaScriptCallFrame.
      * bindings/js/JSJavaScriptCallFrameCustom.cpp: Added.
      (WebCore::JSJavaScriptCallFrame::evaluate): Calls impl evaluate and returns the result.
      (WebCore::JSJavaScriptCallFrame::scopeChain): Makes an array of the ScopeChain.
      * page/JavaScriptCallFrame.cpp: Added.
      (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
      (WebCore::JavaScriptCallFrame::caller): Returns m_caller.
      (WebCore::JavaScriptCallFrame::functionName): Returns the function
      name from the ExecState if this is not global code or anonymous.
      (WebCore::JavaScriptCallFrame::evaluate): Evaluates a script string
      in the scope of the call frame.
      * page/JavaScriptCallFrame.h: Added.
      (WebCore::JavaScriptCallFrame::create): Call the ctor can return in a PassRefPtr.
      (WebCore::JavaScriptCallFrame::invalidate): Sets m_mexec to 0. This prevents a
      stale ExecState from being accessed after the lifetime of the ExecState.
      (WebCore::JavaScriptCallFrame::isValid): Checks if m_exec is 0.
      (WebCore::JavaScriptCallFrame::execState): Returns m_exec.
      (WebCore::JavaScriptCallFrame::sourceIdentifier): Returns m_sourceID.
      (WebCore::JavaScriptCallFrame::line): Returns m_line.
      (WebCore::JavaScriptCallFrame::setLine): Sets m_line.
      (WebCore::JavaScriptCallFrame::scopeChain): Returns by reference m_exec->scopeChain().
      * page/JavaScriptCallFrame.idl: Added.
      * WebCore.xcodeproj/project.pbxproj: Add new files.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dec8c517
    • timothy@apple.com's avatar
      Add a new WebInspector.Object base class that will be used for · 9dd70d13
      timothy@apple.com authored
      a few objects in the Web Inspector to support listeners on any
      object. This will help add more abstraction to the Inspector.
      
      Reviewed by Adam Roben.
      
      * page/inspector/Object.js: Added.
      (WebInspector.Object): Does nothing.
      (WebInspector.Object.prototype.addEventListener): Adds the listener to
      the _listeners map by type. Supports a this object argument, for easy
      addition of listeners without the need for bind.
      (WebInspector.Object.prototype.removeEventListener): Remove the listener
      from the _listeners map. If the listener is null and the thisObject was
      passed, remove any listener for that thisObject.
      (WebInspector.Object.prototype.dispatchEventToListeners): Sends an event
      for a type to all listeners for that type. Mimics some of the DOMEvent
      methods and properties for the event object passed to the listeners.
      * WebCore.vcproj/WebCore.vcproj: Add new files.
      * page/inspector/WebKit.qrc: Ditto.
      * page/inspector/inspector.html: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dd70d13
    • timothy@apple.com's avatar
      Update the view source CSS to better match the new Inspector mock-ups. · 66b81bcb
      timothy@apple.com authored
      Reviewed by Kevin McCullough.
      
      * css/view-source.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66b81bcb
    • aroben@apple.com's avatar
      Neuter WebScriptDebugServer · a67a0078
      aroben@apple.com authored
              Some upcoming changes to JavaScriptDebugServer and
              JavaScriptDebugListener will break WebScriptDebugServer. Since Drosera
              is being replaced by the Inspector's debugger, and Drosera is the only
              client of WebScriptDebugServer, it makes more sense to get rid of
              WebScriptDebugServer than to update it to keep it working.
      
              We can't actually remove WebScriptDebugServer entirely yet, so I've
              just made it non-functional. This will completely break Drosera, but
              as stated above, Drosera's days are numbered anyway.
      
              Reviewed by Tim Hatcher and Kevin McCullough.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::dispatchDidLoadMainResource): Removed all code
              in this function.
              * WebKitDLL.cpp:
              (LocalServerDidDie): Ditto.
              * WebScriptDebugServer.cpp: Made all IWebScriptDebugServer functions
              return E_NOTIMPL.
              * WebScriptDebugServer.h: Removed everything but the
              IWebScriptDebugServer functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a67a0078
    • sullivan@apple.com's avatar
      WebCore: · a7365617
      sullivan@apple.com authored
      2008-05-13  John Sullivan  <sullivan@apple.com>
      
              Reviewed by Dan Bernstein and Kevin Decker
              
              - fixed <rdar://problem/5879597> reproducible crash in HTMLSelectElement::typeAheadFind
      
              Test: fast/forms/select-type-ahead-list-box-no-selection.html
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::typeAheadFind):
              When there's no initially-selected element, we were accessing index -1. Check for this
              case and start at 0.
      
      LayoutTests:
      
      2008-05-13  John Sullivan  <sullivan@apple.com>
      
              Reviewed by Justin Garcia and Tim Hatcher
              
              <rdar://problem/5879597> reproducible crash in HTMLSelectElement::typeAheadFind
      
              * fast/forms/select-type-ahead-list-box-no-selection-expected.txt: Added.
              * fast/forms/select-type-ahead-list-box-no-selection.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7365617
    • weinig@apple.com's avatar
      2008-05-13 Sam Weinig <sam@webkit.org> · e7fdd2ce
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              Small cleanup to XMLHttpRequest in preparation for Access Control changes.
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::~XMLHttpRequest):
              (WebCore::XMLHttpRequest::open):
              (WebCore::XMLHttpRequest::send):
              (WebCore::XMLHttpRequest::internalAbort):
              (WebCore::XMLHttpRequest::processSyncLoadResults):
              (WebCore::XMLHttpRequest::didFinishLoading):
              (WebCore::XMLHttpRequest::didReceiveResponse):
              (WebCore::XMLHttpRequest::didReceiveData):
              * xml/XMLHttpRequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7fdd2ce
    • kmccullough@apple.com's avatar
      2008-05-13 Kevin McCullough <kmccullough@apple.com> · ac2d1e41
      kmccullough@apple.com authored
              Giving credit where credit is due.
      
              * ChangeLog:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac2d1e41
    • mrowe@apple.com's avatar
      <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in... · f4ce681e
      mrowe@apple.com authored
      <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
      
      Reviewed by John Sullivan.
      
      * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
      * Carbon/HIWebView.m: Ditto.
      (HIWebViewCreate):
      (HIWebViewConstructor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4ce681e
    • kmccullough@apple.com's avatar
      2008-05-13 Kevin McCullough <kmccullough@apple.com> · 92542b65
      kmccullough@apple.com authored
              Reviewed by Geoff.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              Use PassRefPtrs instead of RefPtrs when appropriate.
      
              * profiler/FunctionCallProfile.cpp:
              (KJS::FunctionCallProfile::addChild):
              * profiler/FunctionCallProfile.h:
              * profiler/Profile.h:
              (KJS::Profile::callTree):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92542b65
    • cfleizach@apple.com's avatar
      <rdar://problem/5701210> VO: If image is missing, VoiceOver does not speak the alternative text. · ae6c4486
      cfleizach@apple.com authored
      If an image has an alt tag, it should not be ignored
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae6c4486
    • cfleizach@apple.com's avatar
      <rdar://problem/5908446> AX: webkit needs to return blockquote information for... · 513e1a3f
      cfleizach@apple.com authored
      <rdar://problem/5908446> AX: webkit needs to return blockquote information for all AX objects, not just in AXTextMarker info
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      513e1a3f
    • ap@webkit.org's avatar
      Reviewed by John Sullivan. · c6c08514
      ap@webkit.org authored
              <rdar://problem/4852077> REGRESSION: The content of the HTML file which is saved as Thai
              (ISO 8859-11) disappear.
      
              <rdar://problem/5842597> Thai ISO-8859-11 should be upgraded to Windows-874
      
              Test: fast/encoding/char-decoding.html
      
              * platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
              Register ISO-8859-11, which doesn't have a standard IANA name, despite following
              the usual 8859 naming scheme. Also, made TIS-620 map to windows-874-2000 explicitly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6c08514
    • kmccullough@apple.com's avatar
      2008-05-13 Kevin McCullough <kmccullough@apple.com> · 1bed34e6
      kmccullough@apple.com authored
              Reviewed by Sam.
      
              <rdar://problem/5770054> JavaScript profiler (10928)
              - Made some functions static (as per Adam) and changed from using raw
              pointers to RefPtr for making these JavaScript Objects.
      
              * profiler/FunctionCallProfile.cpp:
              (KJS::FunctionCallProfile::addChild):
              (KJS::FunctionCallProfile::findChild):
              * profiler/FunctionCallProfile.h:
              (KJS::FunctionCallProfile::create):
              * profiler/Profile.cpp:
              (KJS::Profile::Profile):
              (KJS::Profile::willExecute):
              (KJS::Profile::didExecute):
              (KJS::functionNameCountPairComparator):
              * profiler/Profile.h:
              (KJS::Profile::create):
              (KJS::Profile::title):
              (KJS::Profile::callTree):
              * profiler/Profiler.cpp:
              (KJS::Profiler::startProfiling):
              * profiler/Profiler.h:
              (KJS::Profiler::allProfiles):
              (KJS::Profiler::clearProfiles):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bed34e6
    • cfleizach@apple.com's avatar
    • ap@webkit.org's avatar
      Reviewed by Eric Seidel. · a1b6f102
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=18681
              <rdar://problem/5888130> WebKit should not remove BOM characters from content.
      
              We were only trying to match Firefox, and it doesn't do this any more.
      
              Tests: fast/encoding/bom-in-content.html
                     fast/encoding/bom-in-content-utf16.html
      
              * platform/text/TextDecoder.cpp: (WebCore::TextDecoder::checkForBOM): Skip the BOM if it's
              at the start of input stream.
      
              * platform/text/TextCodec.cpp:
              * platform/text/TextCodec.h:
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::decode):
              * platform/text/TextCodecUTF16.cpp:
              (WebCore::TextCodecUTF16::decode):
              * platform/text/mac/TextCodecMac.cpp:
              (WebCore::TextCodecMac::decode):
              Don't remove the BOM.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1b6f102
    • ap@webkit.org's avatar
      Reviewed by Dan Bernstein. · d45dad02
      ap@webkit.org authored
              Add tests verifying that we don't mix up some similar, but incompatible encodings.
      
              * fast/encoding/char-decoding-expected.txt:
              * fast/encoding/char-decoding.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d45dad02
    • andersca@apple.com's avatar
      WebCore: · ec2dd2c3
      andersca@apple.com authored
      2008-05-13  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin.
      
              Don't crash when a document loader is destroyed while an initial caching attempt
              is in progress.
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
              Stop loading.
              
              (WebCore::ApplicationCacheGroup::stopLoading):
              New method that stops a cache update.
              
              (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
              Delete ourselves here.
              
              * loader/appcache/ApplicationCacheGroup.h:
      
      LayoutTests:
      
      2008-05-13  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Darin.
      
              Add testcase.
              
              * http/tests/appcache/navigating-away-while-cache-attempt-in-progress-expected.txt: Added.
              * http/tests/appcache/navigating-away-while-cache-attempt-in-progress.html: Added.
              * http/tests/appcache/resources/navigating-away-while-cache-attempt-in-progress.manifest: Added.
              * http/tests/appcache/resources/slow-resource.php: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec2dd2c3
    • ap@webkit.org's avatar
      Reviewed by Darin. · 6e8259dd
      ap@webkit.org authored
              <rdar://problem/5841351> Turkish ISO 8859-9 encoding should be treated as windows-1254
      
              Match IE and upgrade ISO-8859-9 to windows-1254, which is its strict superset.
      
              Test: fast/encoding/char-decoding.html
      
              * platform/text/TextCodecICU.cpp:
              (WebCore::TextCodecICU::registerExtendedEncodingNames): Register the standard name
              unconditionally. Previously, we registered windows-949-2000 as a special case that lacked 
              an IANA standard name, and got away with not registering GBK because it happened
              to be reported by ICU normally earlier than any encoding upgraded to it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e8259dd
    • hausmann@webkit.org's avatar
      2008-05-13 Tor Arne Vestbø <tavestbo@trolltech.com> · 94dcef7f
      hausmann@webkit.org authored
              Reviewed by Simon
      
              Fix QtWebKit build on Qt embedded.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94dcef7f
    • hausmann@webkit.org's avatar
      2008-05-13 Ariya Hidayat <ariya.hidayat@trolltech.com> · 1db2afca
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              For Gtk/X11 and Qt/X11, use a more extensive plug-ins scan directories set
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1db2afca
    • ap@webkit.org's avatar
      Reviewed by Geoffrey Garen. · a1251b33
      ap@webkit.org authored
              <rdar://problem/4949018> JavaScriptCore API claims to work with UTF8 strings, but only works
              with ASCII strings
              
              * kjs/ustring.h:
              * kjs/ustring.cpp:
              (KJS::UString::Rep::createFromUTF8):
              Added. Implementation adapted from JSStringCreateWithUTF8CString().
      
              * API/JSStringRef.cpp:
              (JSStringCreateWithUTF8CString):
              * API/JSClassRef.cpp:
              (OpaqueJSClass::OpaqueJSClass):
              Use UString::Rep::createFromUTF8().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1251b33
    • hausmann@webkit.org's avatar
      2008-05-13 Andy Shaw <andy@trolltech.com> · 9b892647
      hausmann@webkit.org authored
              Reviewed by Simon.
      
              Fixes: QWebHistory::forward() should go forwards and not back
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b892647
  2. 12 May, 2008 15 commits
    • mitz@apple.com's avatar
      - build fix · 59d4e7db
      mitz@apple.com authored
              * Interfaces/WebKit.idl: Touched.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59d4e7db
    • aroben@apple.com's avatar
      Turn on warnings as errors in WebCore.vcproj · 4160fcf5
      aroben@apple.com authored
              Rubberstamped by Anders Carlsson.
      
              * WebCore.vcproj/WebCore.vcproj: Also let VS reformat the file as it
              saw fit. The important part is the removal of the WarnAsError="false"
              lines.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4160fcf5
    • aroben@apple.com's avatar
      Fix a MSVC warning in PluginViewWin · d54c7262
      aroben@apple.com authored
      WebCore:
      
              Fix a MSVC warning in PluginViewWin
      
              Reviewed by Anders Carlsson.
      
              Test: http/tests/plugins/post-url-file.html
      
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::handlePostReadFile): Added a missing return
              statement.
      
      WebKitTools:
      
              Support for testing NPN_PostURL
      
              Reviewed by Anders Carlsson.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
              (toCString): Added this helper function.
              (testPostURLFile): Added. Writes the passed-in content to the
              passed-in file and calls NPN_PostURL with the passed-in URL and
              target.
              (pluginInvoke): Added a case for testPostURLFile.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (followShortcuts): Changed to allow paths that don't yet exist.
      
      LayoutTests:
      
              Test that NPN_PostURL works correctly
      
              Reviewed by Anders Carlsson.
      
              * http/tests/plugins/post-url-file-expected.txt: Added.
              * http/tests/plugins/post-url-file.html: Added.
              * http/tests/plugins/resources/dump-post.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d54c7262
    • aroben@apple.com's avatar
      Fix a MSVC warning in GetEOTHeader · 177d18e5
      aroben@apple.com authored
              Reviewed by Dan Bernstein.
      
              * platform/graphics/win/GetEOTHeader.cpp:
              (WebCore::getEOTHeader): MSVC complains that having a 0-sized array in
              a struct is a non-standard extension. I've replaced the 0-sized arrays
              with arrays of 1 element, and replaced sizeof(structType) with
              offsetof(structType, arrayMember).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      177d18e5
    • aroben@apple.com's avatar
      Fix a MSVC warning in TextCodecICU · 94a6a3d4
      aroben@apple.com authored
              Reviewed by John Sullivan and Dan Bernstein.
      
              * platform/text/TextCodecICU.cpp:
              (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
              UCNV_SUB_STOP_ON_ILLEGAL is a string literal, so using == with it
              doesn't really do what we want. Use strcmp instead. It's OK to pass an
              unknown value to strcmp here since 1) UCNV_SUB_STOP_ON_ILLEGAL is only
              a single character long so we're not going to ready more than 2 bytes
              from oldContext, and 2) we're inside an ASSERT which will cause a
              crash anyway if it fails.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94a6a3d4
    • aroben@apple.com's avatar
      Disable a MSVC warning · 043b8d3a
      aroben@apple.com authored
              Reviewed by Darin Adler.
      
              * win/tools/vsprops/common.vsprops: Add warning 4503 to the list of
              disabled warnings. It's a warning about decorated names being longer
              than MSVC's limit of 4096 characters. This warning doesn't indicate a
              correctness problem, but these truncated decorated names will be
              harder to recognize during debugging or when they appear in linker
              errors.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043b8d3a
    • aroben@apple.com's avatar
      Fix a MSVC warning in CSSComputedStyleDeclaration · 66c1c75a
      aroben@apple.com authored
              Reviewed by Geoff Garen.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForRepeatRule): Removed some unreachable code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66c1c75a
    • aroben@apple.com's avatar
      Fix a MSVC warning in InlineTextBox · 9d5ec18a
      aroben@apple.com authored
              Reviewed by Dan Bernstein.
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paint): Initialize some variables that MSVC
              isn't smart enough to figure out will always be initialized in the
              cases where they are used.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d5ec18a
    • aroben@apple.com's avatar
      Fix a MSVC warning in Position · a744d847
      aroben@apple.com authored
              Reviewed by Darin Adler.
      
              * dom/Position.cpp:
              (WebCore::Position::getInlineBoxAndOffset): Use parentheses to make
              the precedence of our expressions explicit.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a744d847
    • aroben@apple.com's avatar
      Fix a MSVC warning in String · 45d9d6d5
      aroben@apple.com authored
              Reviewed by Geoff Garen.
      
              * platform/text/String.cpp:
              (WebCore::toIntegralType): Disable a bogus warning about using unary -
              on an unsigned value. MSVC isn't smart enough to figure out that
              isNegative will always be false when value is unsigned.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d9d6d5
    • aroben@apple.com's avatar
      Fix a MSVC warning in XMLHttpRequest · 5e2f3493
      aroben@apple.com authored
              Reviewed by Geoff Garen.
      
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest): Added static_cast<unsigned
              long>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e2f3493
    • andersca@apple.com's avatar
      WebCore: · 0e6a6ea0
      andersca@apple.com authored
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Handle the case when a resource with the same URL as the manifest is listed in the manifest.
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::addEntry):
      
      LayoutTests:
      
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add test with a manifest file that lists itself.
              
              * http/tests/appcache/manifest-containing-itself-expected.txt: Added.
              * http/tests/appcache/manifest-containing-itself.html: Added.
              * http/tests/appcache/resources/manifest-containing-itself.manifest: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e6a6ea0
    • weinig@apple.com's avatar
      2008-05-12 Sam Weinig <sam@webkit.org> · 7f47ae51
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              Add parsing of AccessControlHeader and AccessItemRule.
      
              * xml/AccessControlList.cpp:
              (WebCore::AccessControlList::parseAccessControlHeader): When multiple http headers are sent
              in the response, the engine will concatenate them with commas separating the rules.  This simply
              reverses that process by splitting on the commas.
              (WebCore::AccessControlList::show):
              * xml/AccessControlList.h:
              * xml/AccessItem.cpp:
              (WebCore::AccessItem::AccessItem):
              (WebCore::AccessItem::show):
              * xml/AccessItem.h:
              (WebCore::AccessItem::isValid):
              * xml/AccessItemRule.cpp:
              (WebCore::skipLWS):
              (WebCore::AccessItemRule::parseAccessItemRule): Parse the rule according to the BNF provided by
              the Access Control spec.
              (WebCore::AccessItemRule::parsePatternList):
              (WebCore::AccessItemRule::invalidate):
              (WebCore::AccessItemRule::show):
              * xml/AccessItemRule.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f47ae51
    • ddkilzer@apple.com's avatar
      Fix logic error in DocLoader::clearPreloads() · 4405f7a1
      ddkilzer@apple.com authored
              Reviewed by Antti.
      
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::clearPreloads): Be sure to decrease the preload count for
              the cached resource before trying to remove it from the cache.  A non-zero
              preload count can prevent the resource from being removed from the cache.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4405f7a1
    • mrowe@apple.com's avatar
      Minor cleanup of the DRT Xcode project. · 04e9ec0f
      mrowe@apple.com authored
      Reviewed by Sam Weinig.
      
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
      OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
      not need to be there.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04e9ec0f