1. 22 Aug, 2013 23 commits
  2. 21 Aug, 2013 17 commits
    • rniwa@webkit.org's avatar
      Update Mac test expectations. · 9bc82be5
      rniwa@webkit.org authored
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bc82be5
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r154416. · 4ef33f9a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/154416
      https://bugs.webkit.org/show_bug.cgi?id=120147
      
      Broke Windows builds (Requested by rniwa on #webkit).
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh:
      * JavaScriptCore.vcxproj/build-generated-files.sh:
      
      Source/WebCore:
      
      * WebCore.vcxproj/WebCoreGenerated.make:
      * WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
      * WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:
      * WebCore.vcxproj/build-generated-files.sh:
      * WebCore.vcxproj/copyForwardingHeaders.cmd:
      * WebCore.vcxproj/copyWebCoreResourceFiles.cmd:
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
      
      Source/WTF:
      
      * WTF.vcxproj/WTFGenerated.make:
      * WTF.vcxproj/build-generated-files.sh:
      
      WebKitLibraries:
      
      * win/tools/vsprops/common.props:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ef33f9a
    • ryuan.choi@samsung.com's avatar
      [EFL] Unreviewed build fix after r154430. · 1403dc33
      ryuan.choi@samsung.com authored
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::hasFilters): Added CSS_FILTERS guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1403dc33
    • barraclough@apple.com's avatar
      Clarify var/const/function declaration · 1d962d08
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120144
      
      Reviewed by Sam Weinig.
      
      Add methods to JSGlobalObject to declare vars, consts, and functions.
      
      * runtime/Executable.cpp:
      (JSC::ProgramExecutable::initializeGlobalProperties):
      * runtime/Executable.h:
          - Moved declaration code to JSGlobalObject
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::addGlobalVar):
          - internal implementation of addVar, addConst, addFunction
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::addVar):
      (JSC::JSGlobalObject::addConst):
      (JSC::JSGlobalObject::addFunction):
          - Added methods to declare vars, consts, and functions
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d962d08
    • timothy_horton@apple.com's avatar
      Another null-deref under WebDragClient::startDrag · af6cc59c
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120145
      <rdar://problem/14650652>
      
      Reviewed by Simon Fraser.
      
      convertImageToBitmap can legitimately return null, so don't dereference it.
      
      * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
      (WebKit::WebDragClient::startDrag):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af6cc59c
    • simon.fraser@apple.com's avatar
      Setting -webkit-filter: in :active selector causes failure to redraw · 3d54f8b4
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120135
      
      Source/WebCore:
      
      Reviewed by Jer Noble.
      
      When removing a filter on an inline child of a compositing layer,
      the inline loses its RenderLayer and compositing layer, but we fail to
      repaint the compositing layer that the inline is now painting into.
      
      This worked correctly for opacity, because opacity toggles cause
      layouts (which then paint the correct layer), so do the same for filters.
      
      Test: css3/filters/remove-filter-repaint.html
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::changeRequiresLayout): Return true if we toggled
      between having filters and not. Drive-by cleanup, making use of new convenience
      function for hasOpacity().
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::hasFilters): Returns true if we have any
      filters.
      * rendering/style/StyleRareNonInheritedData.h:
      (WebCore::StyleRareNonInheritedData::hasOpacity): Convenience function that
      returns true if opacity is < 1.
      
      LayoutTests:
      
      Reviewed by Jer Noble.
      
      Ref test for removing a filter on an inline.
      
      * css3/filters/remove-filter-repaint-expected.html: Added.
      * css3/filters/remove-filter-repaint.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d54f8b4
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=119900 · 40b6cd3c
      commit-queue@webkit.org authored
      Exception in global setter doesn't unwind correctly
      
      Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-08-21
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      Call VM_THROW_EXCEPTION_AT_END in op_put_to_scope if the setter throws exception.
      
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      
      LayoutTests:
      
      Add test for calling global setter which throws exception.
      
      * fast/js/script-tests/throw-exception-in-global-setter.js: Added.
      (g):
      * fast/js/throw-exception-in-global-setter-expected.txt: Added.
      * fast/js/throw-exception-in-global-setter.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40b6cd3c
    • bdakin@apple.com's avatar
      <https://webkit.org/b/120140> Clients expect didFirstLayout-related calls to · 37c1c7fd
      bdakin@apple.com authored
      happen before didLayout
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidLayout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37c1c7fd
    • bfulgham@apple.com's avatar
      [Windows] Clean up project file after %PlatformArchitecture% change landed. · 11d3b857
      bfulgham@apple.com authored
      * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove hard-coded settings covered
      by our configuration files.
      * WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Use the %PlatformArchitecture%
      macro to support 32- and 64-bit builds.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11d3b857
    • mhahnenberg@apple.com's avatar
      Rename/refactor setButterfly/setStructure · ab08d670
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120138
      
      Reviewed by Geoffrey Garen.
      
      setButterfly becomes setStructureAndButterfly.
      
      Also removed the Butterfly* argument from setStructure and just implicitly
      used m_butterfly internally since that's what every single client of setStructure
      was doing already.
      
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * runtime/JSObject.cpp:
      (JSC::JSObject::notifyPresenceOfIndexedAccessors):
      (JSC::JSObject::createInitialUndecided):
      (JSC::JSObject::createInitialInt32):
      (JSC::JSObject::createInitialDouble):
      (JSC::JSObject::createInitialContiguous):
      (JSC::JSObject::createArrayStorage):
      (JSC::JSObject::convertUndecidedToInt32):
      (JSC::JSObject::convertUndecidedToDouble):
      (JSC::JSObject::convertUndecidedToContiguous):
      (JSC::JSObject::convertUndecidedToArrayStorage):
      (JSC::JSObject::convertInt32ToDouble):
      (JSC::JSObject::convertInt32ToContiguous):
      (JSC::JSObject::convertInt32ToArrayStorage):
      (JSC::JSObject::genericConvertDoubleToContiguous):
      (JSC::JSObject::convertDoubleToArrayStorage):
      (JSC::JSObject::convertContiguousToArrayStorage):
      (JSC::JSObject::switchToSlowPutArrayStorage):
      (JSC::JSObject::setPrototype):
      (JSC::JSObject::putDirectAccessor):
      (JSC::JSObject::seal):
      (JSC::JSObject::freeze):
      (JSC::JSObject::preventExtensions):
      (JSC::JSObject::reifyStaticFunctionsForDelete):
      (JSC::JSObject::removeDirect):
      * runtime/JSObject.h:
      (JSC::JSObject::setStructureAndButterfly):
      (JSC::JSObject::setStructure):
      (JSC::JSObject::putDirectInternal):
      (JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
      (JSC::JSObject::putDirectWithoutTransition):
      * runtime/Structure.cpp:
      (JSC::Structure::flattenDictionaryStructure):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab08d670
    • ap@apple.com's avatar
      http/tests/cookies/simple-cookies-expired.html sometimes fails on Lion Intel Release (Tests) · dc3f1794
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=73694
      
      http/tests/cookies/simple-cookies-max-age.html sometimes fails on Lion Intel Release (Tests)
      https://bugs.webkit.org/show_bug.cgi?id=73695
      
      http/tests/cookies/single-quoted-value.html intermittently fails on Mac
      https://bugs.webkit.org/show_bug.cgi?id=105603
      
      Reviewed by Dan Bernstein.
      
      Woark around a CFNetwork issue by using Max-Age=-1 instead of Max-Age=0. Since it's
      WebKit that we are testing and not the lower level networking, this does not change
      test coverage.
      
      * http/tests/cookies/resources/clearCookies.cgi:
      * http/tests/cookies/resources/cookies-test-pre.js:
      * http/tests/cookies/simple-cookies-max-age.html:
      * http/tests/websocket/tests/hybi/httponly-cookie.pl:
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc3f1794
    • bfulgham@apple.com's avatar
      [Windows] Reenable some tests that pass now. · 92247d80
      bfulgham@apple.com authored
      * platform/win/TestExpectations:  Renable some tests
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92247d80
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120127 · f39a4ec4
      barraclough@apple.com authored
      Remove JSObject::propertyIsEnumerable
      
      Unreviewed typo fix
      
      * runtime/JSObject.h:
          - fix typo
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f39a4ec4
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120139 · 61ff98cd
      barraclough@apple.com authored
      PropertyDescriptor argument to define methods should be const
      
      Rubber stamped by Sam Weinig.
      
      This should never be modified, and this way we can use rvalues.
      
      Source/JavaScriptCore: 
      
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::defineOwnProperty):
      * debugger/DebuggerActivation.h:
      * runtime/Arguments.cpp:
      (JSC::Arguments::defineOwnProperty):
      * runtime/Arguments.h:
      * runtime/ClassInfo.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::defineOwnProperty):
      * runtime/JSArray.h:
      * runtime/JSArrayBuffer.cpp:
      (JSC::JSArrayBuffer::defineOwnProperty):
      * runtime/JSArrayBuffer.h:
      * runtime/JSArrayBufferView.cpp:
      (JSC::JSArrayBufferView::defineOwnProperty):
      * runtime/JSArrayBufferView.h:
      * runtime/JSCell.cpp:
      (JSC::JSCell::defineOwnProperty):
      * runtime/JSCell.h:
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::defineOwnProperty):
      * runtime/JSFunction.h:
      * runtime/JSGenericTypedArrayView.h:
      * runtime/JSGenericTypedArrayViewInlines.h:
      (JSC::::defineOwnProperty):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::defineOwnProperty):
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::putIndexedDescriptor):
      (JSC::JSObject::defineOwnIndexedProperty):
      (JSC::putDescriptor):
      (JSC::JSObject::defineOwnNonIndexProperty):
      (JSC::JSObject::defineOwnProperty):
      * runtime/JSObject.h:
      * runtime/JSProxy.cpp:
      (JSC::JSProxy::defineOwnProperty):
      * runtime/JSProxy.h:
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::defineOwnProperty):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::defineOwnProperty):
      * runtime/RegExpObject.h:
      * runtime/StringObject.cpp:
      (JSC::StringObject::defineOwnProperty):
      * runtime/StringObject.h:
          - make PropertyDescriptor const
      
      Source/WebCore: 
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::defineOwnProperty):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::defineOwnProperty):
      (WebCore::JSLocationPrototype::defineOwnProperty):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
          - make PropertyDescriptor const
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ff98cd
    • bfulgham@apple.com's avatar
      <https://webkit.org/b/120125> [Windows] Correct Tooltip Text · efdb53e4
      bfulgham@apple.com authored
      Reviewed by Anders Carlsson.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::runOpenPanel): Make sure valid strings are passed to the File Open
      API call.
      * WebView.cpp:
      (WebView::setToolTip): Correct tooltip text (avoid passing address to temporary
      return value.)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efdb53e4
    • timothy_horton@apple.com's avatar
      Remove a deleted test from the global TestExpectations · e2202029
      timothy_horton@apple.com authored
      It was freaking lint-test-expectations out.
      
      * TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2202029
    • fpizlo@apple.com's avatar
      REGRESSION: Crash under JITCompiler::link while loading Gmail · 5feb4a8f
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119872
      
      Source/JavaScriptCore: 
      
      Reviewed by Mark Hahnenberg.
              
      Apparently, unsigned + signed = unsigned. Work around it with a cast.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      
      LayoutTests: 
      
      Reviewed by Mark Hahnenberg.
      
      * fast/js/dfg-switch-imm-negative-expected.txt: Added.
      * fast/js/dfg-switch-imm-negative.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-switch-imm-negative.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5feb4a8f