1. 07 Apr, 2011 9 commits
    • commit-queue@webkit.org's avatar
      2011-04-07 Alice Boxhall <aboxhall@chromium.org> · a892eb1c
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
              https://bugs.webkit.org/show_bug.cgi?id=57921
      
              Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
              that the same logic can be used for a HitTestResult.
      
              No visible changes, just cleanup, so no tests.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordFromMouseEvent):
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
              (WebCore::EventHandler::handleMousePressEventTripleClick):
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseDraggedEvent):
              (WebCore::EventHandler::handleMouseReleaseEvent):
              (WebCore::EventHandler::subframeForHitTestResult):
              Made public static member, so that it can access targetNode(), and be accessed by
              webkitwebview in gtk.
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::targetNode):
              (WebCore::EventHandler::handleMouseDoubleClickEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::updateDragAndDrop):
              (WebCore::EventHandler::sendContextMenuEvent):
              * page/EventHandler.h:
              * page/MouseEventWithHitTestResults.cpp:
              (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
              * page/MouseEventWithHitTestResults.h:
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/brew/EventHandlerBrew.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/chromium/EventHandlerChromium.cpp:
              (WebCore::EventHandler::passMousePressEventToSubframe):
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/efl/EventHandlerEfl.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/gtk/EventHandlerGtk.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/haiku/EventHandlerHaiku.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
              (WebCore::EventHandler::passSubframeEventToSubframe):
              * page/wx/EventHandlerWx.cpp:
              (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
      2011-04-07  Alice Boxhall  <aboxhall@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
              https://bugs.webkit.org/show_bug.cgi?id=57921
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_forward_context_menu_event):
              Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
              method has moved on to EventHandler.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a892eb1c
    • mjs@apple.com's avatar
      2011-04-07 Maciej Stachowiak <mjs@apple.com> · 718cfbf4
      mjs@apple.com authored
              Reviewed by Adam Barth.
      
              REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
              https://bugs.webkit.org/show_bug.cgi?id=58017
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      718cfbf4
    • podivilov@chromium.org's avatar
      2011-04-07 Pavel Podivilov <podivilov@chromium.org> · dc47c49d
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: build mapping for formatted scripts based on keywords positions.
              https://bugs.webkit.org/show_bug.cgi?id=57936
      
              Mapping based on [\$\.\w]+ was not accurate because string literals representation
              may be different in original and formatted scripts.
      
              * inspector/front-end/ScriptFormatterWorker.js:
              (buildMapping.regexp.b):
              (buildMapping):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc47c49d
    • philn@webkit.org's avatar
      2011-04-07 Philippe Normand <pnormand@igalia.com> · 39a01e4f
      philn@webkit.org authored
              Unreviewed, GTK rebaseline after r83145. Also skip
              fast/forms/input-number-large-padding.html which fails. See bug
              58020.
      
              * platform/gtk/Skipped:
              * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
              * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
              * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39a01e4f
    • philn@webkit.org's avatar
      2011-04-07 Philippe Normand <pnormand@igalia.com> · 285760a1
      philn@webkit.org authored
              Unreviewed, GTK baselines for 4 new tests.
      
              * platform/gtk/fast/history/visited-link-background-color-expected.checksum: Added.
              * platform/gtk/fast/history/visited-link-background-color-expected.png: Added.
              * platform/gtk/fast/history/visited-link-background-color-expected.txt: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
              * platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
              * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
              * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
              * platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
              * platform/gtk/svg/text/text-midpoint-split-bug-expected.checksum: Added.
              * platform/gtk/svg/text/text-midpoint-split-bug-expected.png: Added.
              * platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      285760a1
    • mjs@apple.com's avatar
      2011-04-07 Maciej Stachowiak <mjs@apple.com> · b085bb57
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Remove some no longer needed WebProcess sandbox allowances
              https://bugs.webkit.org/show_bug.cgi?id=58015
              <rdar://problem/9232592>
      
              * WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network
              and launching privileges, since the bugs that required them are fixed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b085bb57
    • philn@webkit.org's avatar
      2011-04-07 Philippe Normand <pnormand@igalia.com> · 6b711dca
      philn@webkit.org authored
              Unreviewed, GTK rebaseline after r83075.
      
              * platform/gtk/fast/blockflow/text-orientation-basic-expected.txt:
              * platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b711dca
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 03d65b3c
      tkent@chromium.org authored
              [Chromium] Fix a duplicated entry.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03d65b3c
    • tkent@chromium.org's avatar
      Spinbuttons become unclickable if right padding is large. · 508868bc
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=56298
      
      Reviewed by NOBODY (OOPS!).
      
      Source/WebCore:
      
      An inner-spin-button is put on the right border and ignores right
      padding in RenderTextControlSingleLine::layout(), but forwardEvent()
      checks if a point is in an area just right of an internal text block.
      This inconsistency caused a bug that an inner-spin-button with large
      padding didn't receive mouse events.
      
      To fix this bug, we render spin buttons as layers, and remove manual
      event forwarding code.
      
      Test: fast/forms/input-number-large-padding.html
      
      * css/html.css: Add "position:relative" to make a spin-button a layer.
      (input::-webkit-inner-spin-button):
      (input::-webkit-outer-spin-button):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::forwardEvent):
        Remove manual event forwarding code.
      
      LayoutTests:
      
      Add a test, and skip on platforms which has no inner-spin-button implementation.
      
      * fast/forms/input-number-large-padding-expected.txt: Added.
      * fast/forms/input-number-large-padding.html: Added.
      * platform/chromium/test_expectations.txt:
      * platform/mac/Skipped:
      * platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
      * platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83145 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      508868bc
  2. 06 Apr, 2011 31 commits
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · 82650111
      tkent@chromium.org authored
              Fixed an error in the previous commit.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83144 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82650111
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · 041c3636
      tkent@chromium.org authored
              [Chromium] Update text expectation.
              fast/repaint/scale-page-shrink.html is expected to fail because of no
              eventSender.scalePageBy().
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      041c3636
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · d2cbee8d
      tkent@chromium.org authored
              [Chromium] Update test expectation.
              xhr-breakpoints.html and detailed-heapshots-summary.html are flaky.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2cbee8d
    • abarth@webkit.org's avatar
      2011-04-06 Adam Barth <abarth@webkit.org> · 15f9e21f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              CSP object-src should block plugin loads
              https://bugs.webkit.org/show_bug.cgi?id=57283
      
              This change is pretty straight-forward.  It's slighly unclear to me
              whether this patch is correct w.r.t. the code in DocumentWriter.  I've
              added a FIXME comment, and I'll investigate that case more in the future.
      
              Test: http/tests/security/contentSecurityPolicy/object-src-none.html
      
              * loader/DocumentWriter.cpp:
              (WebCore::DocumentWriter::begin):
              * loader/SubframeLoader.cpp:
              (WebCore::SubframeLoader::requestPlugin):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowObjectFromSource):
              (WebCore::ContentSecurityPolicy::addDirective):
              * page/ContentSecurityPolicy.h:
      2011-04-06  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              CSP object-src should block plugin loads
              https://bugs.webkit.org/show_bug.cgi?id=57283
      
              * http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
              * http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15f9e21f
    • bdakin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58009 · 04df6373
      bdakin@apple.com authored
      Frame::scalePage() results in visual artifacts with scale factors less than 1
      -and corresponding-
      <rdar://problem/8683230>
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore: 
      
      Fall into the case where we fill with a background base color when there is a page 
      scale factor that is less than 1.
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paintBoxDecorations):
      
      LayoutTests: 
      
      * fast/repaint/scale-page-shrink.html: Added.
      * platform/gtk/Skipped:
      * platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
      * platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
      * platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04df6373
    • commit-queue@webkit.org's avatar
      2011-04-06 Chang Shu <cshu@webkit.org> · 7c82925f
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
              (WKBundlePageSizeAndMarginsInPixels):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              * WebProcess/InjectedBundle/InjectedBundle.cpp:
              (WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
              * WebProcess/InjectedBundle/InjectedBundle.h:
      2011-04-06  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
              https://bugs.webkit.org/show_bug.cgi?id=57984
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c82925f
    • crogers@google.com's avatar
      2011-04-06 Chris Rogers <crogers@google.com> · 8fef0c2b
      crogers@google.com authored
              Reviewed by Tony Chang.
      
              Add web audio support to DumpRenderTree (mac port)
              https://bugs.webkit.org/show_bug.cgi?id=57969
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (setEncodedAudioDataCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::dumpAsAudio):
              (LayoutTestController::setDumpAsAudio):
              (LayoutTestController::encodedAudioData):
              (LayoutTestController::setEncodedAudioData):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dumpAudio):
              (dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fef0c2b
    • benjamin.poulain@nokia.com's avatar
      2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> · 7f2c250c
      benjamin.poulain@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              * platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.
      2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
              from the LayoutTestController.
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56086
      
              Add the missing method.
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f2c250c
    • tkent@chromium.org's avatar
      2011-04-06 Kent Tamura <tkent@chromium.org> · b3076422
      tkent@chromium.org authored
              [Chromium] Update expectations for Geeza Pro and so on.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3076422
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · 2f78a59c
      jer.noble@apple.com authored
              Reviewed by Darin Adler.
      
              AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
              https://bugs.webkit.org/show_bug.cgi?id=57982
      
              Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f78a59c
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · e3b8e30d
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              MediaPlayerPrivateAVFoundation does not change rate due to setRate().
              https://bugs.webkit.org/show_bug.cgi?id=57919
      
              * media/video-set-rate-from-pause-expected.txt: Added.
              * media/video-set-rate-from-pause.html: Added.
      2011-04-06  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
      
              MediaPlayerPrivateAVFoundation does not change rate due to setRate().
              https://bugs.webkit.org/show_bug.cgi?id=57919
      
              Test: media/video-set-rate-from-pause.html
      
              The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
              of the media; instead a subclass must do that work.  So when setRate() is called,
              inform a subclass through a new pure virtual updateRate() function that there's
              work to be done.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              (WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added.  Set the requested rate.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b8e30d
    • kinuko@chromium.org's avatar
      2011-04-06 Dai Mikurube <dmikurube@chromium.org> · 2354b1f6
      kinuko@chromium.org authored
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
              * win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * configure.ac: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
              * GNUmakefile.am: Added QUOTA build flag
              * WebCore.pri: Added QUOTA build flag
      2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
      
              Reviewed by David Levin.
      
              Add QUOTA build flag for unified quota API
              https://bugs.webkit.org/show_bug.cgi?id=57918
      
              * Scripts/build-webkit: Added QUOTA build flag
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2354b1f6
    • mitz@apple.com's avatar
      Correct results for the Geeza Pro metrics change. · ee010b07
      mitz@apple.com authored
      * platform/mac/fast/dom/52776-expected.checksum:
      * platform/mac/fast/dom/52776-expected.png:
      * platform/mac/fast/dom/52776-expected.txt:
      * platform/mac/fast/text/complex-text-opacity-expected.checksum:
      * platform/mac/fast/text/complex-text-opacity-expected.png:
      * platform/mac/fast/text/complex-text-opacity-expected.txt:
      * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.png:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee010b07
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · ac44eccb
      enne@google.com authored
              Unreviewed, update Chromium expectations for failing test from r83075.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac44eccb
    • dpranke@chromium.org's avatar
      2011-04-06 Dirk Pranke <dpranke@chromium.org> · 9f7a24fb
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              Adjust the apple webkit port's default timeout to match
              old-run-webkit-tests at 35 seconds.
      
              https://bugs.webkit.org/show_bug.cgi?id=37738
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f7a24fb
    • commit-queue@webkit.org's avatar
      2011-04-06 Scott Cameron <sccameron@rim.com> · 989d0096
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove global variable $httpdPath and replace with the return value of
              getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
              https://bugs.webkit.org/show_bug.cgi?id=53499
      
              * Scripts/run-iexploder-tests:
              * Scripts/webkitperl/httpd.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      989d0096
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57997 · ea9f2403
      slewis@apple.com authored
      <rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
      Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
      Cancel all enqueued events when detaching the Document the events cannot keep the Document
      alive.
      
      Reviewed by Darin Adler.
      
      No change in functionality so no new tests.  
      
      * dom/Document.cpp:
      (WebCore::Document::detach):
      * dom/EventQueue.cpp:
      (WebCore::EventQueue::cancelQueuedEvents):
      * dom/EventQueue.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea9f2403
    • levin@chromium.org's avatar
      2011-04-06 David Levin <levin@chromium.org> · 007ffaf6
      levin@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Augment style guidelines about meaningless parameters from text the unwritten rules email.
              https://bugs.webkit.org/show_bug.cgi?id=55275
      
              * coding/coding-style.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      007ffaf6
    • mitz@apple.com's avatar
      <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has... · 39d6aca5
      mitz@apple.com authored
      <rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
      https://bugs.webkit.org/show_bug.cgi?id=58002
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
      does not require the vertical metrics tweaks that were needed in Leopard. That the
      tweaks were being applied went mostly unnoticed until r73993, because until then it
      only affected cases where Geeza Pro was specified, not when it occurred as a fallback
      font.
      
      LayoutTests: 
      
      * platform/mac/fast/dom/52776-expected.checksum:
      * platform/mac/fast/dom/52776-expected.png:
      * platform/mac/fast/dom/52776-expected.txt:
      * platform/mac/fast/text/complex-text-opacity-expected.txt:
      * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
      * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
      * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
      * platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.png:
      * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
      * platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39d6aca5
    • commit-queue@webkit.org's avatar
      2011-04-06 Anders Bakken <agbakken@gmail.com> · 031f559d
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] FrameLoaderClientQt.cpp has coding-style errors
              https://bugs.webkit.org/show_bug.cgi?id=40254
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (drtDescriptionSuitableForTestResult):
              (WebCore::FrameLoaderClientQt::hasWebView):
              (WebCore::FrameLoaderClientQt::setCopiesOnScroll):
              (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
              (WebCore::FrameLoaderClientQt::cancelPolicyCheck):
              (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
              (WebCore::FrameLoaderClientQt::postProgressStartedNotification):
              (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
              (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
              (WebCore::FrameLoaderClientQt::willChangeTitle):
              (WebCore::FrameLoaderClientQt::didChangeTitle):
              (WebCore::FrameLoaderClientQt::finishedLoading):
              (WebCore::FrameLoaderClientQt::frameLoadCompleted):
              (WebCore::FrameLoaderClientQt::provisionalLoadStarted):
              (WebCore::FrameLoaderClientQt::didFinishLoad):
              (WebCore::FrameLoaderClientQt::setTitle):
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
              (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
              (WebCore::FrameLoaderClientQt::updateGlobalHistory):
              (WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
              (WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
              (WebCore::FrameLoaderClientQt::committedLoad):
              (WebCore::FrameLoaderClientQt::download):
              (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
              (WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
              (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
              (WebCore::FrameLoaderClientQt::createFrame):
              (WebCore::FrameLoaderClientQt::objectContentType):
              (WebCore::FrameLoaderClientQt::createPlugin):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      031f559d
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 7a69c781
      enne@google.com authored
              Unreviewed, update expectations for Chromium visited link test.
              https://bugs.webkit.org/show_bug.cgi?id=58000
      
              Apparently, this just hasn't been working for a while.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a69c781
    • rolandsteiner@chromium.org's avatar
      2011-04-06 Roland Steiner <rolandsteiner@chromium.org> · dafa6108
      rolandsteiner@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Bug 57994 - Move guardRef functionality back to Document
              https://bugs.webkit.org/show_bug.cgi?id=57994
      
              Move the relevant code parts from TreeScope back into Document.
      
              No new tests. (no new functionality)
      
              * dom/Document.cpp:
              (WebCore::Document::removedLastRef):
              * dom/Document.h:
              * dom/TreeScope.cpp:
              (WebCore::TreeScope::destroyTreeScopeData):
              * dom/TreeScope.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dafa6108
    • simon.fraser@apple.com's avatar
      2011-04-06 Ian Henderson <ianh@apple.com> · dffdbacb
      simon.fraser@apple.com authored
              Reviewed by Simon Fraser, Antti Koivisto.
      
              Fast path for parsing simple CSS values
              https://bugs.webkit.org/show_bug.cgi?id=57964
      
              Add functions to parse simple color or dimension values, skipping the
              overhead of full CSS parsing.
      
              Change parseValue to a static method to avoid unnecessary allocation
              of a CSSParser in the fast case.
      
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              Changed to use the new, static parseValue method.
              * css/CSSParser.cpp:
              (WebCore::isColorPropertyID):
              (WebCore::parseColorValue):
              Parses any color accepted by the existing parseColor() static method.
              We must handle color identifiers separately, since parseColor() will
              change 'red' into 'rgb(255, 0, 0)'.
              (WebCore::isSimpleLengthPropertyID):
              (WebCore::parseSimpleLengthValue):
              Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is
              false, or 'NN' is '0').  Returns false to fall back to the slow path.
              (WebCore::CSSParser::parseValue):
              * css/CSSParser.h:
              * css/WebKitCSSMatrix.cpp:
              (WebCore::WebKitCSSMatrix::setMatrixValue):
              Changed to use the new, static parseValue method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dffdbacb
    • kevino@webkit.org's avatar
      Reviewed by Darin Adler. · 694dcd96
      kevino@webkit.org authored
      Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
      
      https://bugs.webkit.org/show_bug.cgi?id=27551
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      694dcd96
    • tony@chromium.org's avatar
      2011-04-06 Tony Chang <tony@chromium.org> · ba9b198a
      tony@chromium.org authored
              Reviewed by Darin Adler.
      
              teach run-webkit-tests to read checksums from png files
              https://bugs.webkit.org/show_bug.cgi?id=57993
      
              * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
                no .checksum and look for the checksum in there.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba9b198a
    • simon.fraser@apple.com's avatar
      2011-04-06 Simon Fraser <simon.fraser@apple.com> · 48b5ff1d
      simon.fraser@apple.com authored
              Reviewed by Antti Koivisto.
      
              Some minor style resolution optimizations
              https://bugs.webkit.org/show_bug.cgi?id=57996
      
              A couple of minor optimizations to style-related code.
      
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::isCSSPropertyName):
              (WebCore::JSCSSStyleDeclaration::putDelegate):
              Avoid calling cssPropertyName() twice when setting style on an element.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::useSVGZoomRules):
              (WebCore::CSSStyleSelector::applyProperty):
              Avoid calling isSVGElement() for every property, since only a two properties
              care about it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48b5ff1d
    • simon.fraser@apple.com's avatar
      2011-04-06 Ian Henderson <ianh@apple.com> · e7febf6b
      simon.fraser@apple.com authored
              Reviewed by Antti Koivisto.
      
              Unnecessary string allocation in CSSStyleDeclaration::setProperty
              https://bugs.webkit.org/show_bug.cgi?id=57995
      
              Pass the bool representing the property's importance directly instead
              of constructing a string.
      
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::setProperty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7febf6b
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 0ea14c70
      enne@google.com authored
              Unreviewed, rebaseline more Chromium mac tests after r83075.
      
              * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
              * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ea14c70
    • commit-queue@webkit.org's avatar
      2011-04-06 Siddharth Mathur <siddharth.mathur@nokia.com> · 35c8e736
      commit-queue@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt][WK2][Symbian] Remove use of stack arrays with variable size
              https://bugs.webkit.org/show_bug.cgi?id=57877
      
              For better compiler portability, use new/delete for arrays when size
              isn't known at compile time. Also fix one compiler warning about bitshift
              operations on signed integers.
              * Platform/CoreIPC/qt/ConnectionQt.cpp:
              (CoreIPC::Connection::readyReadHandler):
              (CoreIPC::Connection::sendOutgoingMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35c8e736
    • commit-queue@webkit.org's avatar
      2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org> · 54f7f84f
      commit-queue@webkit.org authored
              Reviewed by Steve Block.
      
              Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
              https://bugs.webkit.org/show_bug.cgi?id=57963
      
              No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
      
              * bindings/v8/V8Utilities.h:
              (WebCore::createFunctionOnlyCallback):
              * bindings/v8/custom/V8GeolocationCustom.cpp:
              (WebCore::V8Geolocation::getCurrentPositionCallback):
              (WebCore::V8Geolocation::watchPositionCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54f7f84f
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · a287b62d
      enne@google.com authored
              Unreviewed, try to green Chromium mac tree by marking failing tests as more generally failing.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a287b62d