1. 03 Dec, 2009 18 commits
    • kov@webkit.org's avatar
      Reviewed by Xan Lopez. · a88b9872
      kov@webkit.org authored
      Platform-specific result for test. GIO identifies the file as
      application/javascript, as opposed to other platforms identifying
      it as application/x-javascript.
      
      * platform/gtk/inspector/timeline-network-resource-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a88b9872
    • pfeldman@chromium.org's avatar
      2009-12-03 Pavel Feldman <pfeldman@chromium.org> · eaf2e4ae
      pfeldman@chromium.org authored
              Not reviewed: chromium build fix.
              r51621 changed JS bindings only, broke v8's.
      
              * bindings/v8/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::appendArgument):
              * bindings/v8/ScriptFunctionCall.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaf2e4ae
    • kov@webkit.org's avatar
      Rubber-stamped by Oliver Hunt. · 25b4303f
      kov@webkit.org authored
      Re-baseline required after r51522.
      
      * platform/gtk/editing/deleting/5390681-2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25b4303f
    • kov@webkit.org's avatar
      Skipping new tests, and tests that require new DRT functionality. · d6637684
      kov@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6637684
    • zoltan@webkit.org's avatar
      Unreviewed build fix. · e8c14fc0
      zoltan@webkit.org authored
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
      [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8c14fc0
    • dglazkov@chromium.org's avatar
      2009-12-03 Dimitri Glazkov <dglazkov@chromium.org> · ca341fc0
      dglazkov@chromium.org authored
              Reviewed by Adam Barth.
      
              [V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
              https://bugs.webkit.org/show_bug.cgi?id=32094
      
              Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html
      
              * bindings/v8/DOMObjectsInclude.h:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getTemplate):
              (WebCore::V8DOMWrapper::convertToV8Object):
              (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
              * bindings/v8/V8DOMWrapper.h:
              * bindings/v8/V8GCController.cpp:
              (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
              * bindings/v8/custom/V8CustomBinding.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca341fc0
    • pfeldman@chromium.org's avatar
      2009-12-03 Pavel Feldman <pfeldman@chromium.org> · ad9927f8
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Chromium: Add support for settings containing ":"
      
              https://bugs.webkit.org/show_bug.cgi?id=32118
      
              * src/InspectorClientImpl.cpp:
              (WebKit::InspectorClientImpl::loadSettings):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad9927f8
    • kenneth@webkit.org's avatar
      repaint events from outside the viewport aren't received · 9ba6222a
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32081
      
      Reviewed by Simon Fraser.
      
      When using a tiled backing store for painting, you need to receive
      event from outside the viewport. Setting the viewport to the size
      of the contents is not an option if you want to make use of WebCore's
      infrastructure for drawing scrollbars etc.
      
      A new property, paintsEntireContents, has been introduced for the
      above use-case. It is settable, as tiling will be optional for Qt,
      and for the not yet upstreamed EFL port, there will be two different
      views, where only one of them are tiled.
      
      No change in behavior, so no new tests added.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::repaintContentRectangle):
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::ScrollView):
      (WebCore::ScrollView::setPaintsEntireContents):
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollView.h:
      (WebCore::ScrollView::paintsEntireContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ba6222a
    • ossy@webkit.org's avatar
      [Qt] Skip layoutTestController.notifyDone() related tests which got revealed in r51634 · a9cdf7ca
      ossy@webkit.org authored
      until there is a fix for the issue.
      https://bugs.webkit.org/show_bug.cgi?id=31626
      
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
      Reviewed by Kenneth Rohde Christiansen.
      
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9cdf7ca
    • ossy@webkit.org's avatar
      WebKitTools: [Qt] Refactor DRT to not crash on tests which open child windows from javascript. · 4c25fd88
      ossy@webkit.org authored
      Prevent DRT from showing the main view if these childs get deleted.
      This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
      
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
      Reviewed by Kenneth Rohde Christiansen.
      
      * DumpRenderTree/qt/DumpRenderTree.cpp:
      (WebCore::WebPage::WebPage):
      (WebCore::DumpRenderTree::DumpRenderTree):
      (WebCore::DumpRenderTree::~DumpRenderTree):
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
      (WebCore::DumpRenderTree::open):
      (WebCore::DumpRenderTree::closeRemainingWindows):
      (WebCore::DumpRenderTree::createWindow):
      (WebCore::DumpRenderTree::windowCount):
      * DumpRenderTree/qt/DumpRenderTree.h:
      
      LayoutTests: [Qt] Re-enable previously skipped tests.
      https://bugs.webkit.org/show_bug.cgi?id=31591
      
      Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-03
      Reviewed by Kenneth Rohde Christiansen.
      
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c25fd88
    • jeremy@chromium.org's avatar
      Reviewed by Eric Seidel. · 4c9cc0b9
      jeremy@chromium.org authored
      Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
      https://bugs.webkit.org/show_bug.cgi?id=31802
      
      No test since this is already covered by existing pixel tests.
      
      * platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
      * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations
      of Core Text functions that are public on 10.6 but SPI on 10.5.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c9cc0b9
    • ossy@webkit.org's avatar
      [Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector(). · e58c8436
      ossy@webkit.org authored
      * platform/qt/Skipped:
      - inspector/settings-set-get.html added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e58c8436
    • pfeldman@chromium.org's avatar
      2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com> · 069c51e4
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Simplify the settings support in inspector controller.
      
              https://bugs.webkit.org/show_bug.cgi?id=32076
      
              Test: inspector/settings-set-get.html
      
              * WebCore.Inspector.exp:
              * bindings/js/JSInspectorFrontendHostCustom.cpp:
              * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
              * inspector/InspectorClient.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::setting):
              (WebCore::InspectorController::setSetting):
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::attachWindow):
              (WebCore::InspectorController::setAttachedWindowHeight):
              (WebCore::InspectorController::storeLastActivePanel):
              (WebCore::InspectorController::scriptObjectReady):
              (WebCore::InspectorController::showWindow):
              (WebCore::InspectorController::enableResourceTracking):
              (WebCore::InspectorController::disableResourceTracking):
              (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::enableDebuggerFromFrontend):
              (WebCore::InspectorController::disableDebugger):
              * inspector/InspectorController.h:
              * inspector/InspectorFrontendHost.cpp:
              (WebCore::InspectorFrontendHost::setting):
              (WebCore::InspectorFrontendHost::setSetting):
              * inspector/InspectorFrontendHost.h:
              * inspector/InspectorFrontendHost.idl:
              * loader/EmptyClients.h:
              (WebCore::EmptyInspectorClient::populateSetting):
              (WebCore::EmptyInspectorClient::storeSetting):
      
      WebKit/chromium
              * src/InspectorClientImpl.cpp:
              (WebKit::InspectorClientImpl::hiddenPanels):
              (WebKit::InspectorClientImpl::populateSetting):
              (WebKit::InspectorClientImpl::storeSetting):
              (WebKit::InspectorClientImpl::loadSettings):
              (WebKit::InspectorClientImpl::saveSettings):
              * src/InspectorClientImpl.h:
      
      WebKit/cf
              * WebCoreSupport/WebInspectorClientCF.cpp:
              (WebInspectorClient::populateSetting):
              (WebInspectorClient::storeSetting):
      
      WebKit/gtk
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::populateSetting):
              (WebKit::InspectorClient::storeSetting):
              * WebCoreSupport/InspectorClientGtk.h:
      
      WebKit/haiku
              * WebCoreSupport/InspectorClientHaiku.cpp:
              (WebCore::InspectorClientHaiku::populateSetting):
              (WebCore::InspectorClientHaiku::storeSetting):
              * WebCoreSupport/InspectorClientHaiku.h:
      
      WebKit/mac
              * WebCoreSupport/WebInspectorClient.h:
              * WebCoreSupport/WebInspectorClient.mm:
              (-[WebInspectorWindowController showWindow:]):
              (-[WebInspectorWindowController attach]):
              (-[WebInspectorWindowController detach]):
      
      WebKit/qt
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientQt::populateSetting):
              (WebCore::InspectorClientQt::storeSetting):
              (WebCore::variantToSetting):
              (WebCore::settingToVariant):
              * WebCoreSupport/InspectorClientQt.h:
      
      WebKit/win
              * WebCoreSupport/WebInspectorClient.cpp:
              (WebInspectorClient::attachWindow):
              (WebInspectorClient::detachWindow):
              (WebInspectorClient::showWindowWithoutNotifications):
              * WebCoreSupport/WebInspectorClient.h:
      
      WebKit/wx
              * WebKitSupport/InspectorClientWx.cpp:
              (WebCore::InspectorClientWx::populateSetting):
              (WebCore::InspectorClientWx::storeSetting):
              * WebKitSupport/InspectorClientWx.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      069c51e4
    • benm@google.com's avatar
      [Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed. · 7fa1e046
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=31915
      
      Reviewed by Brady Eidson.
      
      WebCore: 
      
      No change in functionality so no new tests required.
      
      * history/HistoryItem.cpp:
      (WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
      (WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
      (WebCore::HistoryItem::setURLString): ditto.
      (WebCore::HistoryItem::setOriginalURLString): ditto.
      (WebCore::HistoryItem::setReferrer): ditto.
      (WebCore::HistoryItem::setTitle): ditto.
      (WebCore::HistoryItem::setTarget): ditto.
      (WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
      (WebCore::HistoryItem::clearDocumentState): ditto.
      (WebCore::HistoryItem::setIsTargetItem): ditto.
      (WebCore::HistoryItem::addChildItem): ditto.
      (WebCore::HistoryItem::setFormInfoFromRequest): ditto.
      * history/HistoryItem.h: Update signature of notifyHistoryItemChanged.
      
      WebKit/mac: 
      
      * History/WebHistoryItem.mm:
      (WKNotifyHistoryItemChanged): Update WKNotifyHistoryItemChanged() to add the new HistoryItem parameter added in the WebCore portion of this patch.
      * History/WebHistoryItemInternal.h: ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa1e046
    • benm@google.com's avatar
      [Android] The FrameLoaderClient is unaware of BackForwardList changes. · c3a3bc71
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=31914
      
      Reviewed by Brady Eidson.
      
      WebCore: 
      
      This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.
      
      No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.
      
      * history/BackForwardList.cpp:
      (WebCore::BackForwardList::addItem): Execute the callback.
      (WebCore::BackForwardList::goBack): ditto.
      (WebCore::BackForwardList::goForward): ditto.
      (WebCore::BackForwardList::goToItem): ditto.
      (WebCore::BackForwardList::setCapacity): dito.
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
      (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
      (WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
      * loader/FrameLoaderClient.h:
      
      WebKit/chromium: 
      
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebKit::FrameLoaderClientImpl::dispatchDidRemoveBackForwardItem): ditto.
      (WebKit::FrameLoaderClientImpl::dispatchDidChangeBackForwardIndex): dito.
      * src/FrameLoaderClientImpl.h:
      
      WebKit/gtk: 
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
      (WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/haiku: 
      
      * WebCoreSupport/FrameLoaderClientHaiku.cpp:
      (WebCore::FrameLoaderClientHaiku::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebCore::FrameLoaderClientHaiku::dispatchDidRemoveBackForwardItem): ditto.
      (WebCore::FrameLoaderClientHaiku::dispatchDidChangeBackForwardIndex): ditto.
      * WebCoreSupport/FrameLoaderClientHaiku.h:
      
      WebKit/mac: 
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
      (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
      
      WebKit/qt: 
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebCore::FrameLoaderClientQt::dispatchDidRemoveBackForwardItem): ditto.
      (WebCore::FrameLoaderClientQt::dispatchDidChangeBackForwardIndex): ditto.
      * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win: 
      
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
      (WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
      * WebCoreSupport/WebFrameLoaderClient.h:
      
      WebKit/wx: 
      
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
      (WebCore::FrameLoaderClientWx::dispatchDidRemoveBackForwardItem): ditto.
      (WebCore::FrameLoaderClientWx::dispatchDidChangeBackForwardIndex): ditto.
      * WebKitSupport/FrameLoaderClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3a3bc71
    • benm@google.com's avatar
      [Android] Upstream WebCore/history/android: Require some platform specific... · cae1e66f
      benm@google.com authored
      [Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
      https://bugs.webkit.org/show_bug.cgi?id=31913
      
      Reviewed by Brady Eidson.
      
      Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.
      
      No new tests required as this is Android specific code.
      
      * history/HistoryItem.h: Add Android specific member data to HistoryItem.
      * history/android: Added.
      * history/android/AndroidWebHistoryBridge.h: Added.
      * history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.
      (WebCore::HistoryItem::bridge): Added.
      (WebCore::HistoryItem::setBridge): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cae1e66f
    • oliver@apple.com's avatar
      NULL ptr in SVGPathSegList::getPathSegAtLength() · 33ea1761
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30313
      
      Reviewed by Maciej Stachowiak.
      
      Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
      Add null checks to SVGList's content manipulation functions to prevent
      null values from entering the list in the first place.
      
      Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33ea1761
    • eric@webkit.org's avatar
      2009-12-02 Shinichiro Hamaji <hamaji@chromium.org> · 447f2722
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Rewrite two tests with dumpAsText
              https://bugs.webkit.org/show_bug.cgi?id=32014
      
              * fast/block/positioning/complex-percentage-height-expected.txt: Added.
              * fast/block/positioning/complex-percentage-height.html:
              * fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
              * fast/lists/item-not-in-list-line-wrapping.html:
              * platform/mac/fast/block/positioning/complex-percentage-height-expected.checksum: Removed.
              * platform/mac/fast/block/positioning/complex-percentage-height-expected.png: Removed.
              * platform/mac/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
              * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.checksum: Removed.
              * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.png: Removed.
              * platform/mac/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
              * platform/qt/Skipped:
              * platform/qt/fast/block/positioning/complex-percentage-height-expected.txt: Removed.
              * platform/qt/fast/lists/item-not-in-list-line-wrapping-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      447f2722
  2. 02 Dec, 2009 22 commits