- 29 Oct, 2013 19 commits
-
-
simon.fraser@apple.com authored
media bug. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=123448 Reviewed by Carlos Garcia Campos. * bindings/gobject/WebKitDOMCustom.h: Basic documentation for return types. * bindings/scripts/CodeGeneratorGObject.pm: (GenerateFunction): Generate Returns documentation tag for non-void return types and provide basic documentation. * bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h: Reset tests results. * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: * bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h: * bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h: * bindings/scripts/test/GObject/WebKitDOMTestException.h: * bindings/scripts/test/GObject/WebKitDOMTestInterface.h: * bindings/scripts/test/GObject/WebKitDOMTestObj.h: * bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h: * bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h: * bindings/scripts/test/GObject/WebKitDOMattribute.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123436 Reviewed by Dan Bernstein. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues, because this function only resets WebPreferences now. (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults here, because tests never change them, and they only need to be set once, not before each test. Removed long obsolete workaround for HIToolbox preferences. Don't call resetWebPreferencesToConsistentValues, because it will be called before the first test anyway. (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting. (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads and setlocale calls out of resetWebPreferencesToConsistentValues(). Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's also needed in WK1. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults dictionary. * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to use NSArgumentDomain for everything. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=121728 rdar://problem/15046151 Reviewed by Dean Jackson. Tested by: mathml/arbitrary-markup.html * dom/Element.h: Expose childShouldCreateRenderer for MathML as well as SVG builds. * dom/Node.h: (WebCore::Node::isMathMLElement): Added. * mathml/MathMLElement.cpp: (WebCore::MathMLElement::create): Create as MathML Element. (WebCore::MathMLElement::childShouldCreateRenderer): Only allow the child to emit a renderer if it is a MathML element. * mathml/MathMLElement.h: LayoutTests: [MathML] invalid cast in WebCore::toRenderMathMLBlock https://bugs.webkit.org/show_bug.cgi?id=121728 Reviewed by Dean Jackson. * mathml/arbitrary-markup-expected.txt: Added. * mathml/arbitrary-markup.html: Added. * mathml/mfenced-root-layer.html: Modified to avoid invalid use of arbitrary markup inside mfenced element. * mathml/mfenced-root-layer-expected.txt: Rebaselined. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/123447> ..and a RenderStyle& too, for that matter. Reviewed by Anders Carlsson. * rendering/svg/SVGRenderSupport.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Have this take a RenderElement& and RenderStyle& instead of raw pointers. Tweaked a silly-looking loop. * rendering/svg/RenderSVGShape.h: * rendering/svg/RenderSVGShape.cpp: Moved BoundingRectStrokeStyleApplier helper class into the cpp file since it wasn't being used anywhere else. * rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource): * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource): * rendering/svg/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::applyResource): Remove ampersands. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123446 Reviewed by Andreas Kling. By allowing multiple runs per line we can support text flows with consecutive whitespaces in the middle. * rendering/SimpleLineLayout.cpp: (WebCore::SimpleLineLayout::canUseFor): Remove space test. The improved test coverage found a few more cases that we need to disallow. (WebCore::SimpleLineLayout::adjustRunOffsets): Round the run positions and widths so they match line boxes. Adjust for text-align. (WebCore::SimpleLineLayout::create): Split lines with consecutive spaces into runs. * rendering/SimpleLineLayout.h: (WebCore::SimpleLineLayout::Run::Run): * rendering/SimpleLineLayoutFunctions.cpp: (WebCore::SimpleLineLayout::hitTestFlow): (WebCore::SimpleLineLayout::collectFlowOverflow): (WebCore::SimpleLineLayout::computeTextBoundingBox): * rendering/SimpleLineLayoutResolver.h: (WebCore::SimpleLineLayout::RunResolver::Iterator::resolver): (WebCore::SimpleLineLayout::RunResolver::Iterator::lineIndex): (WebCore::SimpleLineLayout::RunResolver::Run::Run): (WebCore::SimpleLineLayout::RunResolver::Run::rect): (WebCore::SimpleLineLayout::RunResolver::Run::baseline): (WebCore::SimpleLineLayout::RunResolver::Run::text): (WebCore::SimpleLineLayout::RunResolver::Run::lineIndex): (WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator): (WebCore::SimpleLineLayout::RunResolver::Iterator::operator++): Removed unnecessary operators. (WebCore::SimpleLineLayout::RunResolver::Iterator::operator==): (WebCore::SimpleLineLayout::RunResolver::Iterator::operator!=): (WebCore::SimpleLineLayout::RunResolver::Iterator::operator*): (WebCore::SimpleLineLayout::RunResolver::Iterator::simpleRun): (WebCore::SimpleLineLayout::RunResolver::RunResolver): (WebCore::SimpleLineLayout::RunResolver::begin): (WebCore::SimpleLineLayout::RunResolver::end): Resolver -> RunResolver (WebCore::SimpleLineLayout::LineResolver::Iterator::Iterator): (WebCore::SimpleLineLayout::LineResolver::Iterator::operator++): (WebCore::SimpleLineLayout::LineResolver::Iterator::operator==): (WebCore::SimpleLineLayout::LineResolver::Iterator::operator!=): (WebCore::SimpleLineLayout::LineResolver::Iterator::operator*): (WebCore::SimpleLineLayout::LineResolver::LineResolver): (WebCore::SimpleLineLayout::LineResolver::begin): (WebCore::SimpleLineLayout::LineResolver::end): Add LineResolver around RunResolver. It resolves the line rectangles. (WebCore::SimpleLineLayout::runResolver): (WebCore::SimpleLineLayout::lineResolver): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
AX: elements with explicit tabindex should expose AXFocused as writable, since mouse clicks can focus it https://bugs.webkit.org/show_bug.cgi?id=121335 Reviewed by Mario Sanchez Prada. Source/WebCore: Re-order logic that determines if a <span> should appear as an accessible element. The change is that if an element canSetFocus() it should always be in the AX tree. Test: accessibility/tabindex-elements-are-accessible.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): LayoutTests: * accessibility/tabindex-elements-are-accessible-expected.txt: Added. * accessibility/tabindex-elements-are-accessible.html: Added. New test to ensure that if tabindex is on an element, it is in the AX tree. * platform/mac/accessibility/table-with-row-col-of-headers-expected.txt: * platform/mac/accessibility/table-with-row-col-of-headers.html: Update to reflect that if an ignored <table> has a tabindex, then it should at least be an AXGroup * platform/mac/accessibility/update-children-when-aria-role-changes.html: Update so that the <span> elements being used don't have tabindex, which forces them to be in the AX tree, which changes the output of the test (basically we'd need to query the child of those elements instead). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=123144 Reviewed by Martin Robinson. Source/WebCore: * GNUmakefile.list.am: Add new MediaStream files to the GTK port build. Tools: * Scripts/webkitperl/FeatureList.pm: Enable media-stream build for the GTK+ port. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123376 Reviewed by Mario Sanchez Prada. Source/WebCore: File upload buttons should expose AXRequired, since they take an input state. * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::supportsRequiredAttribute): (WebCore::AccessibilityNodeObject::alternativeText): LayoutTests: Modify existing test case to test for file upload buttons. * accessibility/html5-required-attribute-expected.txt: * accessibility/html5-required-attribute.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=123435 Reviewed by Csaba Osztrogonác. 32 bit buildbot doesn't work on dashboard because name is different from buildbot list. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Fix the ChangeLog landed in r158185. The RemoteLayerTreeTextStream class is affected, not RemoteLayerTreeTransaction. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
.: * Source/autotools/Versions.m4: Bump version numbers. Source/WebKit/gtk: * NEWS: Added release notes for 2.3.1. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jinwoo7.song@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=123402 Reviewed by Antti Koivisto. Source/WebCore: * rendering/SimpleLineLayout.cpp: (WebCore::SimpleLineLayout::canUseFor): 8-bit TextRun support is now enabled for EFL port, so the port can use the simple line layout. Source/WTF: * wtf/FeatureDefines.h: Enable 8-bit TextRun support for EFL port. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
This should fix the Mac debug build. * WebCore.exp.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=114227 Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-29 Reviewed by Ryosuke Niwa. Source/WebCore: Before this patch when selection is done by double-click (start and base remain same) and DOM is modified then selection gets vanished. This does not happen when selection is done by dragging mouse. This happens because on double-click base and extent remain the same and on DOM modification we update the selection with base and extent, so we loose the selection. Since in double-click case start/end contain the correct selection, same should be used after dom modification to update selection. Test: editing/selection/double-click-selection-with-dom-mutation.html * editing/FrameSelection.cpp: (WebCore::FrameSelection::textWasReplaced): use start/end to update selection in case double click selection. Added a check for base != extent, if base != extent use base/extent to update the selection otherwise use start/end with directionality check. LayoutTests: New Testcase to test that selection remain intact when selection is created by double-click and then dom is modified. * editing/selection/double-click-selection-with-dom-mutation-expected.txt: Added. * editing/selection/double-click-selection-with-dom-mutation.html: Added. Rebaselined the below test cases. * platform/mac/editing/deleting/smart-delete-003-expected.txt: * platform/mac/editing/deleting/smart-delete-004-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Remove the duplicated << overloaded operator from RemoteLayerTreeTransaction for printing out a given FloatSize object. The RemoteLayerTreeTransaction inherits from TextStream, which already provides that overloaded operator. Format of the output is a bit different so hopefully nothing breaks further. * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::RemoteLayerTreeTextStream::operator<<): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihnea@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=122963 Reviewed by Alexandru Chiculita. After https://bugs.webkit.org/show_bug.cgi?id=119135, css regions are modelled using an anonymous RenderNamedFlowFragment object inside the block having a valid -webkit-flow-from. This patch changes the way elements | pseudo-elements with -webkit-flow-from are displayed in test dumps. Source/WebCore: Before: RenderRegion {DIV} at (200,200) size 52x52 [border: (1px solid #000000)] After: RenderBlock (positioned) {DIV} at (200,200) size 52x52 [border: (1px solid #000000)] RenderNamedFlowFragment at (1,1) size 50x50 Before: Flow Threads Thread with flow-name 'article' Regions for flow 'article' RenderRegion {DIV} #region_1 RenderRegion {DIV} #region_2 After: Named flows Named flow 'article' Regions for named flow 'article' RenderNamedFlowFragment (anonymous child of {DIV::before} #region_1) RenderNamedFlowFragment (anonymous child of {DIV} #region_2) Changed existing tests based on the new dumps. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::renderName): * rendering/RenderNamedFlowFragment.h: Add a comment explaining the purpose of the class. * rendering/RenderRegion.h: * rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::writeRenderRegionList): Adjust function to display info for anonymous regions too. (WebCore::writeRenderNamedFlowThreads): Separate dump of valid and invalid regions for a named flow. LayoutTests: Changed expected files for mac port, removed expectations for gtk | efl and added [Missing] in TestExpectations for these platforms. Results need to be generated again for the [Missing] lines. * fast/regions/auto-size/autoheight-regions-mark-expected.txt: Removed. * fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed. * fast/regions/flows-dependency-same-flow-expected.txt: Removed. * platform/efl/TestExpectations: * platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed. * platform/efl/fast/regions/region-dynamic-after-before-expected.txt: Removed. * platform/efl/fast/regions/region-generated-content-before-after-expected.txt: Removed. * platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed. * platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed. * platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed. * platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed. * platform/efl/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed. * platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Removed. * platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed. * platform/gtk/TestExpectations: * platform/gtk/fast/regions/flows-dependency-same-flow-expected.png: Removed. * platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed. * platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Removed. * platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Removed. * platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed. * platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed. * platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed. * platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Removed. * platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Removed. * platform/mac/fast/regions/auto-size/autoheight-regions-mark-expected.png: Copied from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png. * platform/mac/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added. * platform/mac/fast/regions/autoheight-regions-mark-expected.png: Removed. * platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added. * platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Copied from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png. * platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added. * platform/mac/fast/regions/iframe-html-collected-expected.png: Renamed from LayoutTests/fast/regions/flows-dependency-same-flow-expected.png. * platform/mac/fast/regions/iframe-html-collected-expected.txt: Renamed from LayoutTests/fast/regions/iframe-html-collected-expected.txt. * platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: * platform/mac/fast/regions/region-dynamic-after-before-expected.txt: * platform/mac/fast/regions/region-generated-content-before-after-expected.txt: * platform/mac/fast/regions/text-region-split-small-pagination-expected.txt: * platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added. * platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: * platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt: * platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Renamed from LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt. * platform/mac/fast/repaint/region-painting-invalidation-expected.txt: * platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Renamed from LayoutTests/fast/repaint/region-painting-via-layout-expected.txt. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=116012 Reviewed by Simon Fraser. The writeIndent method and overloaded << operators for writing out vectors and points and rectangles of various types are not specific to the render tree nor do they depend on any rendering-specific interface. * page/scrolling/ScrollingStateNode.cpp: * page/scrolling/ScrollingStateNode.h: (ScrollingStateNode): Remove the writeIndent declaration, it's functionally the same as the TextStream method. * platform/graphics/GraphicsLayer.cpp: * platform/graphics/GraphicsLayer.h: (GraphicsLayer): Ditto. * platform/graphics/filters/DistantLightSource.cpp: Remove the RenderTreeAsText.h inclusion or replace it with the inclusion of the TextStream.h header where required. The writeIndent method is now declared there. * platform/graphics/filters/FEBlend.cpp: Ditto. * platform/graphics/filters/FEColorMatrix.cpp: Ditto. * platform/graphics/filters/FEComponentTransfer.cpp: Ditto. * platform/graphics/filters/FEComposite.cpp: Ditto. * platform/graphics/filters/FEConvolveMatrix.cpp: Ditto. * platform/graphics/filters/FECustomFilter.cpp: Ditto. * platform/graphics/filters/FEDiffuseLighting.cpp: Ditto. * platform/graphics/filters/FEDisplacementMap.cpp: Ditto. * platform/graphics/filters/FEDropShadow.cpp: Ditto. * platform/graphics/filters/FEFlood.cpp: Ditto. * platform/graphics/filters/FEGaussianBlur.cpp: Ditto. * platform/graphics/filters/FEMerge.cpp: Ditto. * platform/graphics/filters/FEMorphology.cpp: Ditto. * platform/graphics/filters/FEOffset.cpp: Ditto. * platform/graphics/filters/FESpecularLighting.cpp: Ditto. * platform/graphics/filters/FETurbulence.cpp: Ditto. * platform/graphics/filters/SourceAlpha.cpp: Ditto. * platform/graphics/filters/SourceGraphic.cpp: Ditto. * platform/text/TextStream.cpp: Move the writeIndent and operators' definitions here. (WebCore::operator<<): (WebCore): (WebCore::writeIndent): * platform/text/TextStream.h: Move the writeIndent and operators' declarations here. (WebCore): (TextStream): (WebCore::TextStream::operator<<): * rendering/RenderTreeAsText.cpp: Move the writeIndent and operators' definitions into TextStream. (WebCore): * rendering/RenderTreeAsText.h: Move the writeIndent and operators' declarations into TextStream. (WebCore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=123408 Reviewed by Darin Adler. Clean up the ScopedEventQueue implementation. ScopedEventQueue::instance() should return a reference to a NeverDestroyed<ScopedEventQueue> object. The static ScopedEventQueue::s_instance pointer is removed. The ScopedEventQueue destructor, the dispatchAllEvents method and the scope level incrementation/decrementation methods are made private. NeverDestroyed<ScopedEventQueue> and EventQueueScope are made friends of the ScopedEventQueue class so they can access the constructor and the incrementation/decrementation methods, respectively. ScopedEventQueue method definitions are reordered to follow the order of their declarations in the header file. ScopedEventQueue::dispatchAllEvents() now uses std::move to efficiently dispatch and clear all currently queued events. * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchScopedEvent): * dom/ScopedEventQueue.cpp: (WebCore::ScopedEventQueue::instance): (WebCore::ScopedEventQueue::dispatchAllEvents): * dom/ScopedEventQueue.h: (WebCore::EventQueueScope::EventQueueScope): (WebCore::EventQueueScope::~EventQueueScope): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 28 Oct, 2013 21 commits
-
-
akling@apple.com authored
<https://webkit.org/b/123434> This function is always called with an existing RenderStyle object. Reviewed by Anders Carlsson. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/123433> These functions are always called with an existing RenderStyle object so let them take a const reference instead of a raw pointer. Also sprinkled some missing OVERRIDEs. Reviewed by Anders Carlsson. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/123423> Reviewed by Anders Carlsson. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158178 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
editing/selection/5057506-2.html as image-only failure. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
per-page. * BuildSlaveSupport/build.webkit.org-config/public_html/default.css: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158176 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/public_html/default.css: (td.LastBuild a): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=123430 Reviewed by Darin Adler. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: (WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/public_html/default.css: (body > .header): (td.LastBuild): (td.LastBuild a): (td.LastBuild,td.Activity a,td.Change a,td.Builder a): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/public_html/default.css: (body.interface): (body > hr): (div.content h1): (body > .header): (td.Activity a,td.Change a,td.Builder a): (td.Builder): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158172 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=123160 Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-10-28 Reviewed by Darin Adler. Make the constructors of the InputType subclasses public. This makes it possible to use std::make_unique on these classes and makes the T::create() helpers redundant. New instances of these classes are now managed through std::unique_ptr. InputType::create() now uses a NeverDestroyed InputTypeFactoryMap that maps type names to InputTypeFactoryFunctions and gets populated when the method is first called and the map is still empty. Certain types are not added to the factory map if they're disabled at runtime. The factory is used to create the new InputType object if the requested type was found in the map, and TextInputType is used otherwise. * html/ButtonInputType.cpp: * html/ButtonInputType.h: (WebCore::ButtonInputType::ButtonInputType): * html/CheckboxInputType.cpp: * html/CheckboxInputType.h: (WebCore::CheckboxInputType::CheckboxInputType): * html/ColorInputType.cpp: * html/ColorInputType.h: (WebCore::ColorInputType::ColorInputType): * html/DateInputType.cpp: * html/DateInputType.h: * html/DateTimeInputType.cpp: * html/DateTimeInputType.h: (WebCore::DateTimeInputType::DateTimeInputType): * html/DateTimeLocalInputType.cpp: * html/DateTimeLocalInputType.h: (WebCore::DateTimeLocalInputType::DateTimeLocalInputType): * html/EmailInputType.cpp: * html/EmailInputType.h: (WebCore::EmailInputType::EmailInputType): * html/FileInputType.cpp: * html/FileInputType.h: * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateType): * html/HTMLInputElement.h: * html/HiddenInputType.cpp: * html/HiddenInputType.h: (WebCore::HiddenInputType::HiddenInputType): * html/ImageInputType.cpp: (WebCore::ImageInputType::ImageInputType): * html/ImageInputType.h: * html/InputType.cpp: (WebCore::createInputType): A templated helper that constructs a new InputType subclass object through std::make_unique. (WebCore::populateInputTypeFactoryMap): Populates the passed-in map with type-createInputType<T> pairs. (WebCore::InputType::create): Get the InputTypeFactoryFunction for the specified type, or fall back to TextInputType. (WebCore::InputType::createText): * html/InputType.h: * html/MonthInputType.cpp: * html/MonthInputType.h: (WebCore::MonthInputType::MonthInputType): * html/NumberInputType.cpp: * html/NumberInputType.h: (WebCore::NumberInputType::NumberInputType): * html/PasswordInputType.cpp: * html/PasswordInputType.h: (WebCore::PasswordInputType::PasswordInputType): * html/RadioInputType.cpp: * html/RadioInputType.h: (WebCore::RadioInputType::RadioInputType): * html/RangeInputType.cpp: * html/RangeInputType.h: * html/ResetInputType.cpp: * html/ResetInputType.h: (WebCore::ResetInputType::ResetInputType): * html/SearchInputType.cpp: (WebCore::SearchInputType::SearchInputType): * html/SearchInputType.h: * html/SubmitInputType.cpp: * html/SubmitInputType.h: (WebCore::SubmitInputType::SubmitInputType): * html/TelephoneInputType.cpp: * html/TelephoneInputType.h: (WebCore::TelephoneInputType::TelephoneInputType): * html/TextInputType.cpp: * html/TextInputType.h: (WebCore::TextInputType::TextInputType): * html/TimeInputType.cpp: * html/TimeInputType.h: * html/URLInputType.cpp: * html/URLInputType.h: (WebCore::URLInputType::URLInputType): * html/WeekInputType.cpp: * html/WeekInputType.h: (WebCore::WeekInputType::WeekInputType): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123347 Reviewed by Andreas Kling. - Rework how database directory location is passed around. - Make (some) SecurityOrigin arguments be references instead of pointers. - Add two SecurityOrigin arguments to opening databases for future use. Source/WebCore: * Modules/indexeddb/IDBFactory.cpp: (WebCore::IDBFactory::openInternal): * Modules/indexeddb/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): * Modules/indexeddb/IDBFactoryBackendInterface.h: * Modules/indexeddb/PageGroupIndexedDatabase.cpp: (WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase): (WebCore::PageGroupIndexedDatabase::from): (WebCore::PageGroupIndexedDatabase::factoryBackend): * Modules/indexeddb/PageGroupIndexedDatabase.h: * Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp: (WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase): (WebCore::WorkerGlobalScopeIndexedDatabase::from): (WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB): * Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h: * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp: (WebCore::IDBBackingStoreLevelDB::open): (WebCore::IDBBackingStoreLevelDB::openInMemory): * Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: * Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: (WebCore::computeFileIdentifier): (WebCore::computeUniqueIdentifier): (WebCore::IDBFactoryBackendLevelDB::IDBFactoryBackendLevelDB): (WebCore::IDBFactoryBackendLevelDB::getDatabaseNames): (WebCore::IDBFactoryBackendLevelDB::deleteDatabase): (WebCore::IDBFactoryBackendLevelDB::openBackingStore): (WebCore::IDBFactoryBackendLevelDB::open): * Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: (WebCore::IDBFactoryBackendLevelDB::create): * WebCore.exp.in: * platform/DatabaseStrategy.cpp: (WebCore::DatabaseStrategy::createIDBFactoryBackend): * platform/DatabaseStrategy.h: Source/WebKit2: * Shared/Databases/IndexedDB/IDBUtilities.cpp: (WebKit::uniqueDatabaseIdentifier): * Shared/Databases/IndexedDB/IDBUtilities.h: * WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: (WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend): (WebKit::WebIDBFactoryBackend::open): * WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h: (WebKit::WebIDBFactoryBackend::create): * WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp: (WebKit::WebProcessIDBDatabaseBackend::WebProcessIDBDatabaseBackend): * WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h: * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::createIDBFactoryBackend): * WebProcess/WebCoreSupport/WebPlatformStrategies.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css: (body): (body, td): (a:link,a:visited,a:active): (td.Time): (td.Activity): (.exception, td.offline): * BuildSlaveSupport/build.webkit.org-config/public_html/default.css: (body.interface): (.auth): (td.LastBuild): (td.Time): (td.Activity): (.offline,td.offline,.retry): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css: (body, td): (body.interface): (.auth): (.header): (div.content h1): (a): (a:link,a:active): (a:link,a:visited,a:active): (td.LastBuild): (td.Time): (td.Activity): (.exception, td.offline, .retry): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/123414> Now that renderers always have style, go ahead and make style() return a RenderStyle&. There are countless opportunities for further cleanup enabled by this change. I'm simply passing &style() in many cases where we can really do something nicer instead. Reviewed by Anders Carlsson. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158163 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123418 Reviewed by Simon Fraser. Add PlatformCALayer::createCompatibleLayer, which is overridden in each of the subclasses to create a PlatformCALayer instance of the same subclass. This is used in TileController to make bare PlatformCALayers of the correct type (Mac, Win, or Remote). * platform/graphics/ca/PlatformCALayer.h: * platform/graphics/ca/mac/PlatformCALayerMac.h: * platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayerMac::createCompatibleLayer): * platform/graphics/ca/win/PlatformCALayerWin.cpp: (PlatformCALayerWin::createCompatibleLayer): * platform/graphics/ca/win/PlatformCALayerWin.h: Add createCompatibleLayer and implement it in the subclasses. * platform/graphics/ca/mac/TileController.mm: (WebCore::TileController::TileController): (WebCore::TileController::tiledScrollingIndicatorLayer): (WebCore::TileController::createTileLayer): Make use of createCompatibleLayer when creating PlatformCALayers. * WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: (PlatformCALayerRemote::createCompatibleLayer): * WebProcess/WebPage/mac/PlatformCALayerRemote.h: Add createCompatibleLayer and implement it in the subclasses. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
achicu@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=123424 Reviewed by Timothy Hatcher. Source/WebCore: Test: inspector-protocol/model/content-flow-content-nodes.html Adding two new inspector-protocol APIs to handle the cases when new elements are added or removed from a named flow. These APIs will trigger even though there is no region associated with the named flow. * inspector/Inspector.json: * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement): (WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement): * inspector/InspectorCSSAgent.h: * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElementImpl): (WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElementImpl): * inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElement): (WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElement): * rendering/RenderNamedFlowThread.cpp: (WebCore::RenderNamedFlowThread::registerNamedFlowContentElement): (WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement): Source/WebInspectorUI: Exposed the new CSS Agent events to the ContentFlow class that will now maintain a list of nodes in the "contentNodes" property. * UserInterface/CSSObserver.js: (WebInspector.CSSObserver.prototype.regionOversetChanged): (WebInspector.CSSObserver.prototype.registeredNamedFlowContentElement): (WebInspector.CSSObserver.prototype.unregisteredNamedFlowContentElement): * UserInterface/ContentFlow.js: (WebInspector.ContentFlow): (WebInspector.ContentFlow.prototype.set overset): (WebInspector.ContentFlow.prototype.get contentNodes): (WebInspector.ContentFlow.prototype.insertContentNodeBefore): (WebInspector.ContentFlow.prototype.appendContentNode): (WebInspector.ContentFlow.prototype.removeContentNode): * UserInterface/DOMTreeManager.js: (WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload): (WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload): (WebInspector.DOMTreeManager.prototype.regionOversetChanged): (WebInspector.DOMTreeManager.prototype.registeredNamedFlowContentElement): (WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement): * UserInterface/InspectorBackendCommands.js: LayoutTests: Added test to check that the two new events are triggered correctly and can be used to maintain the flow content nodes list on the inspector side. * inspector-protocol/model/content-flow-content-nodes-expected.txt: Added. * inspector-protocol/model/content-flow-content-nodes.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=123429 Reviewed by Alexey Proskuryakov. Add a human readable name to Buildbot.Platform entries, and use it to show a tooltip on the ring image. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: (documentReady): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
* platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=123425 Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-10-28 Reviewed by Timothy Hatcher. * inspector/inline-javascript-imports.py: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-