1. 17 Nov, 2010 40 commits
    • mrobinson@webkit.org's avatar
      2010-11-17 Martin Robinson <mrobinson@igalia.com> · a83301db
      mrobinson@webkit.org authored
              Update the skipped list to skip a newly failing geolocation test (requires
              geolocation mock support). Organize geolocation test failures a bit better.
              Add results for two new tests.
      
              * platform/gtk/Skipped: Update skipped list.
              * platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
              * platform/gtk/fast/css/negative-leading-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a83301db
    • inferno@chromium.org's avatar
      2010-11-17 Cris Neckar <cdn@chromium.org> · 28ad8d80
      inferno@chromium.org authored
              Reviewed by Adam Barth.
      
              Modified codepath for object fallback content which has failed to load.
              Refactored CachedResource error handling to use more granular statuses instead of a boolean value.
              https://bugs.webkit.org/show_bug.cgi?id=46921
      
              Test: fast/html/object-image-nested-fallback.html
      
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::renderFallbackContent):
              * loader/cache/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::error):
              * loader/cache/CachedCSSStyleSheet.h:
              * loader/cache/CachedFont.cpp:
              (WebCore::CachedFont::ensureCustomFontData):
              (WebCore::CachedFont::error):
              * loader/cache/CachedFont.h:
              * loader/cache/CachedImage.cpp:
              (WebCore::CachedImage::data):
              (WebCore::CachedImage::error):
              * loader/cache/CachedImage.h:
              * loader/cache/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource):
              (WebCore::CachedResource::canUseCacheValidator):
              (WebCore::CachedResource::mustRevalidate):
              * loader/cache/CachedResource.h:
              (WebCore::CachedResource::error):
              (WebCore::CachedResource::httpStatusCodeError):
              (WebCore::CachedResource::errorOccurred):
              * loader/cache/CachedScript.cpp:
              (WebCore::CachedScript::error):
              * loader/cache/CachedScript.h:
              * loader/cache/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::error):
              * loader/cache/CachedXSLStyleSheet.h:
              * loader/loader.cpp:
              (WebCore::Loader::load):
              (WebCore::Loader::didFinishLoading):
              (WebCore::Loader::didFail):
              (WebCore::Loader::didReceiveData):
      2010-11-17  Cris Neckar  <cdn@chromium.org>
      
              Reviewed by Adam Barth.
      
              Added test for multiple image objects which use the same invalid data attribute.
              https://bugs.webkit.org/show_bug.cgi?id=46921
      
              * fast/html/object-image-nested-fallback-expected.txt: Added.
              * fast/html/object-image-nested-fallback.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28ad8d80
    • timothy@apple.com's avatar
      Provide a way to create a WKView (WebPage) that is hidden from · 0a0875bc
      timothy@apple.com authored
      the InjectedBundle. This is needed for the Web Inspector.
      
      https://webkit.org/b/49670
      
      Reviewed by Sam Weinig.
      
      * Shared/WebPageCreationParameters.cpp:
      (WebKit::WebPageCreationParameters::encode): Added visibleToInjectedBundle.
      (WebKit::WebPageCreationParameters::decode): Ditto.
      * Shared/WebPageCreationParameters.h: Ditto.
      * UIProcess/API/C/win/WKView.cpp:
      (WKViewCreate): Pass VisibleToInjectedBundle to the WebView create function.
      * UIProcess/API/C/win/WKViewPrivate.cpp:
      (WKViewCreateForWebInspector): Added. Not used yet. Passes HiddenFromInjectedBundle
      to the WebView create function.
      * UIProcess/API/C/win/WKViewPrivate.h: Added WKViewCreateForWebInspector.
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:]): Added hiddenFromInjectedBundle
      parameter and calls WebPageProxy::setVisibleToInjectedBundle.
      (-[WKView initWithFrame:pageNamespaceRef:]): Calls initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:
      and passes NO for hiddenFromInjectedBundle.
      (-[WKView initWithFrame:]): Cleaned up by removing the local assignment to self and just returns the result.
      * UIProcess/API/mac/WKViewInternal.h: Added initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy): Initialize m_visibleToInjectedBundle from the creation parameters.
      (WebKit::WebPageProxy::creationParameters): Set visibleToInjectedBundle using m_visibleToInjectedBundle.
      * UIProcess/WebPageProxy.h: Added m_visibleToInjectedBundle.
      (WebKit::WebPageProxy::visibleToInjectedBundle): Added. Return m_visibleToInjectedBundle.
      (WebKit::WebPageProxy::setVisibleToInjectedBundle): Added. Set m_visibleToInjectedBundle.
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::WebView): Added InjectedBundleVisibility parameter and calls
      WebPageProxy::setVisibleToInjectedBundle.
      * UIProcess/win/WebView.h: Added InjectedBundleVisibility enum.
      (WebKit::WebView::create): Added InjectedBundleVisibility parameter.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::create): Checks visibleToInjectedBundle before talking to the injected bundle.
      (WebKit::WebPage::WebPage): Initialize m_isVisibleToInjectedBundle from the creation parameters.
      (WebKit::WebPage::close): Checks m_isVisibleToInjectedBundle before talking to the injected bundle.
      * WebProcess/WebPage/WebPage.h: Added m_isVisibleToInjectedBundle.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a0875bc
    • zmo@google.com's avatar
      2010-11-16 Zhenyao Mo <zmo@google.com> · df878173
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              WebGLRenderingContext needs to zero textures and renderbuffers
              https://bugs.webkit.org/show_bug.cgi?id=49355
      
              * src/WebGraphicsContext3DDefaultImpl.cpp: Don't deal with texture initialization at this level.
      2010-11-16  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              WebGLRenderingContext needs to zero textures and renderbuffers
              https://bugs.webkit.org/show_bug.cgi?id=49355
      
              Test: fast/canvas/webgl/uninitialized-test.html
      
              * html/canvas/WebGLFramebuffer.cpp:
              (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed.
              (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
              * html/canvas/WebGLFramebuffer.h: Modify onAccess function signature.
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter.
              (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto.
              (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
              (WebCore::WebGLRenderingContext::drawArrays): Ditto.
              (WebCore::WebGLRenderingContext::drawElements): Ditto.
              (WebCore::WebGLRenderingContext::readPixels): Ditto.
              (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
      2010-11-16  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              WebGLRenderingContext needs to zero textures and renderbuffers
              https://bugs.webkit.org/show_bug.cgi?id=49355
      
              * fast/canvas/webgl/uninitialized-test-expected.txt: Added.
              * fast/canvas/webgl/uninitialized-test.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df878173
    • commit-queue@webkit.org's avatar
      2010-11-17 Commit Queue <commit-queue@webkit.org> · d814f60a
      commit-queue@webkit.org authored
              Unreviewed.  Test commit for commit-queue@webkit.org.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d814f60a
    • kov@webkit.org's avatar
      2010-11-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 1d106786
      kov@webkit.org authored
              Reviewed by Martin Robinson.
      
              Fix a typo that leads to emitting the wrong signal if it is done
              by using the signals array.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_class_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d106786
    • sfalken@apple.com's avatar
      26398ed9
    • abecsi@webkit.org's avatar
      Unreviewed buildfix. · 773961b5
      abecsi@webkit.org authored
      [Qt] D'oh! I screwed up the dependencies.
      
      * DerivedSources.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      773961b5
    • abecsi@webkit.org's avatar
      Unreviewed build fix. · 61e6b656
      abecsi@webkit.org authored
      [Qt] Add missing resource file I forgot in r72220.
      
      * MiniBrowser/MiniBrowser.qrc: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61e6b656
    • rniwa@webkit.org's avatar
      2010-11-17 Ryosuke Niwa <rniwa@webkit.org> · f827848d
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Merge ScriptElement and ScriptElementData
              https://bugs.webkit.org/show_bug.cgi?id=49647
      
              Merged two classes.
      
              * dom/AsyncScriptRunner.cpp:
              (WebCore::AsyncScriptRunner::executeScriptSoon): Takes ScriptElement* instead of ScriptElementData*.
              (WebCore::AsyncScriptRunner::timerFired): Uses ScriptElement* instead of ScriptElementData*.
              * dom/AsyncScriptRunner.h:
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElement::ScriptElement): Merged with ScriptElementData::ScriptElementData.
              (WebCore::ScriptElement::~ScriptElement): Merged with ScriptElementData::~ScriptElementData.
              (WebCore::ScriptElement::insertedIntoDocument): Calls createdByParser, isAsynchronous, requestScript, and scriptContent.
              (WebCore::ScriptElement::removedFromDocument): Calls stopLoadRequest.
              (WebCore::ScriptElement::childrenChanged): Calls createdByParser and accesses m_element.
              (WebCore::ScriptElement::finishParsingChildren): Calls scriptContent.
              (WebCore::ScriptElement::handleSourceAttribute): Calls ignoresLoadRequest and requestScript.
              (WebCore::ScriptElement::requestScript): Moved from ScriptElementData; calls dispatchErrorEvent.
              (WebCore::ScriptElement::evaluateScript): Moved from ScriptElementData.
              (WebCore::ScriptElement::executeScript): Ditto.
              (WebCore::ScriptElement::stopLoadRequest): Ditto.
              (WebCore::ScriptElement::execute): Moved from ScriptElementData; calls dispatchErrorEvent and dispatchLoadEvent.
              (WebCore::ScriptElement::notifyFinished): Moved from ScriptElementData.
              (WebCore::ScriptElement::ignoresLoadRequest): Ditto.
              (WebCore::ScriptElement::shouldExecuteAsJavaScript): Moved from ScriptElementData; calls typeAttributeValue, languageAttributeValue,
              forAttributeValue, and eventAttributeValue.
              (WebCore::ScriptElement::scriptCharset): Moved from ScriptElementData.
              (WebCore::ScriptElement::scriptContent): Ditto.
              (WebCore::ScriptElement::isAsynchronous): Moved from ScriptElementData; calls sourceAttributeValue and asyncAttributeValue.
              (WebCore::ScriptElement::isDeferred): Moved from ScriptElementData; calls sourceAttributeValue, asyncAttributeValue,
              and deferAttributeValue.
              * dom/ScriptElement.h:
              (WebCore::ScriptElement::element):
              (WebCore::ScriptElement::haveFiredLoadEvent):
              (WebCore::ScriptElement::setHaveFiredLoadEvent):
              (WebCore::ScriptElement::createdByParser):
              (WebCore::ScriptElement::isEvaluated):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f827848d
    • andreas.kling@nokia.com's avatar
      2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org> · 16396586
      andreas.kling@nokia.com authored
              Reviewed by Andreas Kling.
      
              [WK2] Set paintsEntireContents for "resizes to contents" mode
      
              Only relevant for the tiled backing store.
      
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::setResizesToContentsUsingLayoutSize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16396586
    • abecsi@webkit.org's avatar
      2010-11-17 Andras Becsi <abecsi@webkit.org> · 7358e59e
      abecsi@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
              https://bugs.webkit.org/show_bug.cgi?id=49627
      
              Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
      
              * MiniBrowser/MiniBrowser.qrc: Added.
              Add it here to prevent qmake from detecting it
              since it needs to be copied to the build directory.
              * MiniBrowser/qt/BrowserWindow.cpp:
              (BrowserWindow::BrowserWindow):
              (BrowserWindow::updateUserAgentList):
              (BrowserWindow::showUserAgentDialog):
              * MiniBrowser/qt/BrowserWindow.h:
              * MiniBrowser/qt/MiniBrowser.pro:
      2010-11-17  Andras Becsi  <abecsi@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser
              https://bugs.webkit.org/show_bug.cgi?id=49627
      
              Copy the MiniBrowser.qrc and QtTestBrowser's useragentlist.txt file
              to the build directory of MiniBrowser because it has to be in a
              subdirectory of the resource file.
              Add a method to QWKPage to retrieve the custom user agent string.
      
              * DerivedSources.pro:
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPage::customUserAgent):
              * UIProcess/API/qt/qwkpage.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7358e59e
    • sfalken@apple.com's avatar
      Update WebKitSystemInterfaceWin. · 987bf560
      sfalken@apple.com authored
      Rubber-stamped by Adam Roben.
      
      * win/lib/WebKitSystemInterface.lib:
      * win/lib/WebKitSystemInterface_debug.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      987bf560
    • aroben@apple.com's avatar
      Make changes to the Mac WebKit2 Skipped file trigger Windows builds · 4861f12d
      aroben@apple.com authored
      We use that file on Windows!
      
      Fixes <http://webkit.org/b/49643> Changes to
      LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
      
      Reviewed by Steve Falkenburg.
      
      * Scripts/webkitpy/common/config/build.py:
      (_should_file_trigger_build): Added the mac-wk2 directory and make it
      trigger builds on SnowLeopard and Windows.
      
      * Scripts/webkitpy/common/config/build_unittest.py:
      (ShouldBuildTest.test_should_build): Added a test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4861f12d
    • aroben@apple.com's avatar
      Update Windows results after r72125 and r72173 · 82d96a12
      aroben@apple.com authored
      * platform/win/css2.1/t1202-counter-04-b-expected.txt:
      * platform/win/css2.1/t1202-counters-04-b-expected.txt:
      * platform/win/fast/blockflow/border-vertical-lr-expected.txt:
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      * platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
      * platform/win/fast/text/international/hebrew-vowels-expected.txt:
      * platform/win/transforms/2d/hindi-rotated-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82d96a12
    • commit-queue@webkit.org's avatar
      2010-11-17 Tenghui Zhu <ztenghui@google.com> · 4ab1de63
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              profileCallback and profileEndCallback  should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
              https://bugs.webkit.org/show_bug.cgi?id=49623
      
              No new tests. Just a compiling error fix.
      
              * bindings/v8/custom/V8ConsoleCustom.cpp:
                Add the guard ENABLE_JAVA_SCRIPT_DEBUGGER to profileCallback and profileEndCallback
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ab1de63
    • weinig@apple.com's avatar
      Update WebKit2 skipped list. · 197b0352
      weinig@apple.com authored
      Rubber-stamped by Jon Honeycutt.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      197b0352
    • mihaip@chromium.org's avatar
      2010-11-17 Satish Sampath <satish@chromium.org> · 213b792a
      mihaip@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Clear the speech input mock explicitly before each test.
              https://bugs.webkit.org/show_bug.cgi?id=49660
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setMockSpeechInputResult):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::speechInputController):
              (WebViewHost::reset): Invoke speech input mock's clearResults method.
              * DumpRenderTree/chromium/WebViewHost.h:
              (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      213b792a
    • commit-queue@webkit.org's avatar
      2010-11-17 John Knottenbelt <jknotten@chromium.org> · 3389c058
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Introduce GeoNotifierVector typedef for increased readability
              https://bugs.webkit.org/show_bug.cgi?id=49597
      
              * page/Geolocation.cpp:
              (WebCore::Geolocation::Watchers::getNotifiersVector):
              (WebCore::Geolocation::sendError):
              (WebCore::Geolocation::sendPosition):
              (WebCore::Geolocation::stopTimer):
              (WebCore::Geolocation::stopTimersForOneShots):
              (WebCore::Geolocation::stopTimersForWatchers):
              (WebCore::Geolocation::cancelRequests):
              (WebCore::Geolocation::cancelAllRequests):
              (WebCore::Geolocation::handleError):
              (WebCore::Geolocation::makeSuccessCallbacks):
              * page/Geolocation.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3389c058
    • simon.fraser@apple.com's avatar
      2010-11-17 Simon Fraser <simon.fraser@apple.com> · 62d4f6c5
      simon.fraser@apple.com authored
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=45567
              Add stubbed-out layer-backed drawing area for Windows.
      
              Add implementations of LayerBackedDrawingArea and
              LayerBackedDrawingAreaProxy for Windows, and add them
              to the vcproj.
      
              * UIProcess/LayerBackedDrawingAreaProxy.cpp:
              * UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Added.
              (WebKit::LayerBackedDrawingAreaProxy::page):
              (WebKit::LayerBackedDrawingAreaProxy::platformSetSize):
              (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
              (WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
              (WebKit::LayerBackedDrawingAreaProxy::paint):
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::pageDidEnterAcceleratedCompositing):
              (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
              (WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
              * UIProcess/win/WebView.h:
              * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
              * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Added.
              (WebKit::LayerBackedDrawingArea::platformInit):
              (WebKit::LayerBackedDrawingArea::platformClear):
              (WebKit::LayerBackedDrawingArea::attachCompositingContext):
              (WebKit::LayerBackedDrawingArea::detachCompositingContext):
              (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
              (WebKit::LayerBackedDrawingArea::scheduleCompositingLayerSync):
              (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62d4f6c5
    • commit-queue@webkit.org's avatar
      2010-11-17 John Knottenbelt <jknotten@chromium.org> · 74d5a6dd
      commit-queue@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Add a layout test to check that Geoposition timestamps are
              well-formed. See https://bugs.webkit.org/show_bug.cgi?id=48518
      
              * fast/dom/Geolocation/script-tests/timestamp.js: Added.
              (checkPosition):
              * fast/dom/Geolocation/timestamp-expected.txt: Added.
              * fast/dom/Geolocation/timestamp.html: Added.
      2010-11-17  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Convert correctly between GeolocationPosition and Geoposition
              timestamp formats.
              https://bugs.webkit.org/show_bug.cgi?id=48518
      
              Test: fast/dom/Geolocation/timestamp.html
      
              * page/Geolocation.cpp:
              (WebCore::createGeoposition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74d5a6dd
    • chang.shu@nokia.com's avatar
      2010-11-17 Chang Shu <chang.shu@nokia.com> · a3c19814
      chang.shu@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Mac] Unskip the test that is passing now.
      
              Test: fast/events/spatial-navigation/snav-single-select.html
      
              * platform/mac/Skipped:
      2010-11-17  Chang Shu  <chang.shu@nokia.com>
      
              Reviewed by Antonio Gomes.
      
              [Mac] Suppress single select popup menu when spatial navigation is enabled on Mac.
              This makes spatial navigation work properly for single select box.
      
              Test: fast/events/spatial-navigation/snav-single-select.html
      
              * dom/SelectElement.cpp:
              (WebCore::nextValidIndex):
              (WebCore::SelectElement::menuListDefaultEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3c19814
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/49634> Make overflow guards in WTF::String::utf8 explicit · fc3ece2f
      ddkilzer@apple.com authored
      Reviewed by Darin Adler.
      
      Add an explicit overflow check prior to allocating our buffer,
      rather than implicitly relying on the guard in convertUTF16ToUTF8.
      
      * wtf/text/WTFString.cpp:
      (WTF::String::utf8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc3ece2f
    • antonm@chromium.org's avatar
      Not reviewed, rebaselining fast/js/regexp-overflow.html · 2772ea74
      antonm@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49665
      
      * platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
      * platform/chromium-win/fast/js/regexp-overflow-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2772ea74
    • commit-queue@webkit.org's avatar
      2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com> · e3504cab
      commit-queue@webkit.org authored
              Unreviewed, rolling out r72197.
              http://trac.webkit.org/changeset/72197
              https://bugs.webkit.org/show_bug.cgi?id=49661
      
              broke fast/regex/test1.html (Requested by stampho on #webkit).
      
              * runtime/JSGlobalData.h:
              * runtime/RegExp.cpp:
              (JSC::RegExpRepresentation::~RegExpRepresentation):
              (JSC::RegExp::compile):
              (JSC::RegExp::match):
              * tests/mozilla/expected.html:
              * wtf/Platform.h:
              * yarr/RegexCompiler.cpp:
              * yarr/RegexCompiler.h:
              * yarr/RegexInterpreter.cpp:
              * yarr/RegexInterpreter.h:
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::jitCompileRegex):
              * yarr/RegexJIT.h:
              (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
              (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
              (JSC::Yarr::RegexCodeBlock::getFallback):
              (JSC::Yarr::RegexCodeBlock::setFallback):
              (JSC::Yarr::executeRegex):
              * yarr/RegexParser.h:
              * yarr/RegexPattern.h:
      2010-11-17  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r72197.
              http://trac.webkit.org/changeset/72197
              https://bugs.webkit.org/show_bug.cgi?id=49661
      
              broke fast/regex/test1.html (Requested by stampho on #webkit).
      
              * fast/js/regexp-look-ahead-empty-expected.txt:
              * fast/js/regexp-overflow-expected.txt:
              * fast/js/script-tests/regexp-overflow.js:
              * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
              * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
              * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3504cab
    • satish@chromium.org's avatar
      2010-11-17 Satish Sampath <satish@chromium.org> · df8dbb36
      satish@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Clear the speech input mock explicitly before each test.
              https://bugs.webkit.org/show_bug.cgi?id=49660
      
              * platform/mock/SpeechInputClientMock.cpp:
              (WebCore::SpeechInputClientMock::clearResults): Added clearResults method.
              * platform/mock/SpeechInputClientMock.h:
      2010-11-17  Satish Sampath  <satish@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Clear the speech input mock explicitly before each test.
              https://bugs.webkit.org/show_bug.cgi?id=49660
      
              * public/WebSpeechInputControllerMock.h:
              * src/WebSpeechInputControllerMockImpl.cpp:
              (WebKit::WebSpeechInputControllerMockImpl::clearResults): Added method to clear results.
              * src/WebSpeechInputControllerMockImpl.h:
      2010-11-17  Satish Sampath  <satish@chromium.org>
      
              Reviewed by Jeremy Orlow.
      
              Clear the speech input mock explicitly before each test.
              https://bugs.webkit.org/show_bug.cgi?id=49660
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::setMockSpeechInputResult):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::speechInputController):
              (WebViewHost::reset): Invoke speech input mock's clearResults method.
              * DumpRenderTree/chromium/WebViewHost.h:
              (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df8dbb36
    • apavlov@chromium.org's avatar
      2010-11-17 Alexander Pavlov <apavlov@chromium.org> · 32c20591
      apavlov@chromium.org authored
              [Chromium] Unreviewed, fix Chromium-Mac build from r72189.
      
              * css/CSSPrimitiveValue.cpp:
              (WebCore::CSSPrimitiveValue::getDoubleValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32c20591
    • hans@chromium.org's avatar
      2010-11-17 Hans Wennborg <hans@chromium.org> · aad3d4a5
      hans@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB: IDBKey::whereSyntax should impose conditions on all columns
              https://bugs.webkit.org/show_bug.cgi?id=49601
      
              The WHERE clause should specifiy a condition for each key column to
              make sure that the ObjectStoreData_composit index can be used when
              querying the object store based on key. Not using the index causes
              severe performance degradation for common IDB operations.
      
              * storage/IDBKey.cpp:
              (WebCore::IDBKey::whereSyntax):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aad3d4a5
    • apavlov@chromium.org's avatar
      2010-11-17 Alexander Pavlov <apavlov@chromium.org> · cc8d18aa
      apavlov@chromium.org authored
              Unreviewed, specify IRC nickname in committers.py.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc8d18aa
    • benjamin.poulain@nokia.com's avatar
      [Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView · 4af22c6a
      benjamin.poulain@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49545
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Implement focus switching with Tab. This is now done asynchronously,
      waiting for webkit to call takeFocus() and switching the widget.
      
      Since the focus can change between the Tab press and the callback,
      QGraphicsWKView::focusNextPrevChildCallback() make sure the view still has
      focus before passing it to the next widget.
      
      * UIProcess/API/qt/qgraphicswkview.cpp:
      (QGraphicsWKView::QGraphicsWKView):
      (QGraphicsWKView::focusNextPrevChildCallback):
      (QGraphicsWKView::focusNextPrevChild):
      * UIProcess/API/qt/qgraphicswkview.h:
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::takeFocus):
      * UIProcess/API/qt/qwkpage.h:
      * UIProcess/API/qt/qwkpage_p.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4af22c6a
    • antonm@chromium.org's avatar
      Not reviewed, disabling fast/css/getFloatValueForUnit.html. · 1ac44bc9
      antonm@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49656
      
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ac44bc9
    • commit-queue@webkit.org's avatar
      2010-11-17 Eric Uhrhane <ericu@chromium.org> · 6687a623
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              [Chromium] implementation of async FileWriter for workers
              https://bugs.webkit.org/show_bug.cgi?id=47681
      
              Tests are in a separate changelist.
      
              * platform/CrossThreadCopier.h: Changed CrossThreadCopier[Base] to support PassRefPtrs
      2010-11-17  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by David Levin.
      
              [Chromium] implementation of async FileWriter for workers
              https://bugs.webkit.org/show_bug.cgi?id=47681
      
              Tests are in a separate changelist.
      
              Added new files.
              * WebKit.gyp:
      
              * src/WorkerAsyncFileSystemChromium.cpp: Added WorkerAsyncFileWriterChromium construction.
              * src/WorkerAsyncFileWriterChromium.cpp: Added.
              * src/WorkerAsyncFileWriterChromium.h: Added.
      
              This class bridges between the context and main threads for the WorkerAsyncFileWriterChromium.
              * src/WorkerFileWriterCallbacksBridge.cpp: Added.
              * src/WorkerFileWriterCallbacksBridge.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6687a623
    • pfeldman@chromium.org's avatar
      2010-11-17 Pavel Feldman <pfeldman@chromium.org> · 870c1150
      pfeldman@chromium.org authored
              Not reviewed. Commenting out failing Qt inspector tests. Need to fix harness.
      
              * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      870c1150
    • antonm@chromium.org's avatar
      430a4edc
    • ossy@webkit.org's avatar
      YARR JIT should fallback to YARR Interpreter instead of PCRE. · 554c3c88
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=46719
      
      Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
      Reviewed by Gavin Barraclough.
      
      Remove the ENABLE_YARR macro and the option of matching regular
      expressions with PCRE from JavaScriptCore.
      
      JavaScriptCore: 
      
      * runtime/JSGlobalData.h:
      * runtime/RegExp.cpp:
      (JSC::RegExp::compile):
      (JSC::RegExp::match):
      * tests/mozilla/expected.html:
      * wtf/Platform.h:
      * yarr/RegexCompiler.cpp:
      * yarr/RegexCompiler.h:
      * yarr/RegexInterpreter.cpp:
      (JSC::Yarr::byteCompileRegex):
      * yarr/RegexInterpreter.h:
      * yarr/RegexJIT.cpp:
      (JSC::Yarr::jitCompileRegex):
      * yarr/RegexJIT.h:
      (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
      (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
      (JSC::Yarr::RegexCodeBlock::getFallback):
      (JSC::Yarr::RegexCodeBlock::isFallback):
      (JSC::Yarr::RegexCodeBlock::setFallback):
      (JSC::Yarr::executeRegex):
      * yarr/RegexParser.h:
      * yarr/RegexPattern.h:
      
      LayoutTests: 
      
      * fast/js/regexp-look-ahead-empty-expected.txt:
      * fast/js/regexp-overflow-expected.txt:
      * fast/js/script-tests/regexp-overflow.js:
      * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
      * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
      * fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554c3c88
    • commit-queue@webkit.org's avatar
      2010-11-17 John Mellor <johnme@chromium.org> · 14ae2e88
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Expose frame flattening setting in WebSettings.
              https://bugs.webkit.org/show_bug.cgi?id=49621
      
              * public/WebSettings.h:
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setFrameFlatteningEnabled):
              * src/WebSettingsImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14ae2e88
    • apavlov@chromium.org's avatar
      2010-11-17 Alexander Pavlov <apavlov@chromium.org> · 5eb1b1af
      apavlov@chromium.org authored
              Unreviewed, remove stale Chromium test expectations to fix build.
      
              * platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
              * platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
              * platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
              * platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eb1b1af
    • ossy@webkit.org's avatar
      [NRWT] Make http locking similar to perl implementation · ce326815
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49187
      
      Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-17
      Reviewed by Tony Chang.
      
      * Scripts/webkitpy/common/system/file_lock.py: Added.
      * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
      * Scripts/webkitpy/layout_tests/port/http_lock.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce326815
    • andreas.kling@nokia.com's avatar
      2010-11-17 Andreas Kling <kling@webkit.org> · 828abebe
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Don't prohibit scrolling in tiled backing store mode.
      
              We delegate scrolling instead.
      
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      828abebe
    • commit-queue@webkit.org's avatar
      2010-11-17 Jonathan Backer <backer@chromium.org> · 6ed6b80e
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              [Chromium] Resize initiated by renderer.
              https://bugs.webkit.org/show_bug.cgi?id=49617
      
              To address synchronization issues with resizing, make resize work like DARWIN.
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ed6b80e