1. 28 Jun, 2006 1 commit
    • beidson's avatar
      WebCore: · a7ae2c3b
      beidson authored
              Reviewed by Maciej
      
              Hookup the new semi-functional SQLite icon database.
              For now, it is living side-by-side with the old DB so one can compare the
              two for debugging purposes.  Also, it is disabled (in WebKit) by default unless you
              compile with ICONDEBUG #defined.
      
              * WebCore.xcodeproj/project.pbxproj:  Added file SiteIcon.cpp
      
              * bridge/mac/WebCoreIconDatabaseBridge.h:
              * bridge/mac/WebCoreIconDatabaseBridge.mm:
              (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
              (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
              (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
              (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
      
              * icon/IconDatabase.cpp:
              (WebCore::IconDatabase::isValidDatabase):
              (WebCore::IconDatabase::recreateDatabase):
              (WebCore::IconDatabase::createPrivateTables):
              (WebCore::IconDatabase::deletePrivateTables):
              (WebCore::IconDatabase::imageDataForIconID):
              (WebCore::IconDatabase::imageDataForIconURL):
              (WebCore::IconDatabase::imageDataForPageURL):
              (WebCore::IconDatabase::setPrivateBrowsingEnabled):
              (WebCore::IconDatabase::iconForPageURL):
              (WebCore::IconDatabase::iconURLForURL):
              (WebCore::IconDatabase::setIconDataForIconURL):
              (WebCore::IconDatabase::establishIconIDForEscapedIconURL):
              (WebCore::IconDatabase::setHaveNoIconForIconURL):
              (WebCore::IconDatabase::setIconURLForPageURL):
              (WebCore::IconDatabase::hasIconForIconURL):
              * icon/IconDatabase.h:
              (WebCore::SiteIcon::getIconURL):
              (WebCore::IconDatabase::getPrivateBrowsingEnabled):
              
              * icon/SiteIcon.cpp: Added.
              (SiteIcon::SiteIcon):
              (SiteIcon::~SiteIcon):
              (SiteIcon::getImage):
              (SiteIcon::resetExpiration):
              (SiteIcon::getExpiration):
      
      WebKit:
      
              Reviewed by Maciej
      
              Hookup the new semi-functional SQLite icon database.
              For now, it is living side-by-side with the old DB so one can compare the
              two for debugging purposes.  Also, it is disabled (in WebKit) by default unless you
              compile with ICONDEBUG #defined.
              Note:  To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)
      
              * Misc/WebIconDatabase.m:
              (-[NSMutableDictionary iconForURL:withSize:cache:]):
              (-[NSMutableDictionary iconURLForURL:]):
              (-[NSMutableDictionary retainIconForURL:]):
              (-[NSMutableDictionary releaseIconForURL:]):
              (-[WebIconDatabase _setHaveNoIconForIconURL:]):
              (-[WebIconDatabase _setIconURL:forURL:]):
              (-[WebIconDatabase _hasIconForIconURL:]):
              (-[WebIconDatabase _resetCachedWebPreferences:]):
              * Misc/WebIconLoader.m:
              (-[WebIconLoader didFinishLoading]):
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7ae2c3b
  2. 27 Jun, 2006 21 commits
    • darin's avatar
      LayoutTests: · 896f671d
      darin authored
              Reviewed by Darin.
      
              Updated test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
      
              * fast/dom/window-xy-properties.html:
              * fast/dom/window-xy-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9605
              REGRESSION: pageX and pageY are both 0 for events created with initMouseEvent
      
              Calculate pageX/pageY and clientX/clientY values when using initMouseEvent.
      
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::initMouseEvent):
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::initCoordinates):
              * dom/MouseRelatedEvent.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      896f671d
    • darin's avatar
      LayoutTests: · 9300d592
      darin authored
              Reviewed by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9317
                REGRESSION: crash in HTML tokenizer at Japanese Apple support page
      
              * fast/tokenizer/write-unclosed-script-expected.txt: Added.
              * fast/tokenizer/write-unclosed-script.html: Added.
      
      WebCore:
      
              Reviewed by Maciej and Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9317
                REGRESSION: crash in HTML tokenizer at Japanese Apple support page
      
              Test: fast/tokenizer/write-unclosed-script.html
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::scriptHandler): Changed to reset the inScript flag
              and scriptCodeSize before possible script execution, but not afterwards.
              This way, if script execution write()s a <script> tag without closing it,
              the tokenizer is left in inScript state. Added code to set the requestingScript
              flag around the request for the cached script, to let notifiyFinished() know
              that it's being called under scriptHandler().
              (WebCore::HTMLTokenizer::scriptExecution): Removed code that saved and restored
              the inScript flag. This function is always entered now with inScript being false.
              (WebCore::HTMLTokenizer::notifyFinished): Changed to use the new requestingScript
              state flag instead of the inScript flag, which is always false now when entering
              this function.
              * html/HTMLTokenizer.h:
              Added the requestingScript state bit, used to tell notifyFinished() that it
              is being called under scriptHandler() (which happens when the script is already
              in cache).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9300d592
    • justing's avatar
      Fixed some typos. · 74ecc801
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74ecc801
    • justing's avatar
      LayoutTests: · cc3bf9b2
      justing authored
              Reviewed by levi
      
              * editing/execCommand/remove-formatting-expected.checksum: Added.
              * editing/execCommand/remove-formatting-expected.png: Added.
              * editing/execCommand/remove-formatting-expected.txt: Added.
              * editing/execCommand/remove-formatting.html: Added.
      
      WebCore:
      
              Reviewed by levi
      
              * editing/JSEditor.cpp: Added RemoveFormat.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc3bf9b2
    • kdecker's avatar
      · 8399390b
      kdecker authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8399390b
    • thatcher's avatar
      Reviewed by Tim O. · fdc01d5e
      thatcher authored
              <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore, WebKit and WebBrowser
      
              Switch to the new ObjC 2 API, ifdefed the old code around OBJC_API_VERSION so it still works on Tiger.
              Removed the use of the old stringWithCString, switched to the new Tiger version that accepts an encoding.
              Lots of code style cleanup.
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bindings/objc/objc_class.h:
              * bindings/objc/objc_class.mm:
              (KJS::Bindings::ObjcClass::~ObjcClass):
              (KJS::Bindings::_createClassesByIsAIfNecessary):
              (KJS::Bindings::ObjcClass::classForIsA):
              (KJS::Bindings::ObjcClass::name):
              (KJS::Bindings::ObjcClass::methodsNamed):
              (KJS::Bindings::ObjcClass::fieldNamed):
              (KJS::Bindings::ObjcClass::fallbackObject):
              * bindings/objc/objc_header.h:
              * bindings/objc/objc_instance.h:
              * bindings/objc/objc_instance.mm:
              (ObjcInstance::ObjcInstance):
              (ObjcInstance::~ObjcInstance):
              (ObjcInstance::operator=):
              (ObjcInstance::begin):
              (ObjcInstance::end):
              (ObjcInstance::getClass):
              (ObjcInstance::invokeMethod):
              (ObjcInstance::invokeDefaultMethod):
              (ObjcInstance::setValueOfField):
              (ObjcInstance::supportsSetValueOfUndefinedField):
              (ObjcInstance::setValueOfUndefinedField):
              (ObjcInstance::getValueOfField):
              (ObjcInstance::getValueOfUndefinedField):
              (ObjcInstance::defaultValue):
              (ObjcInstance::stringValue):
              (ObjcInstance::numberValue):
              (ObjcInstance::booleanValue):
              (ObjcInstance::valueOf):
              * bindings/objc/objc_runtime.h:
              * bindings/objc/objc_runtime.mm:
              (ObjcMethod::ObjcMethod):
              (ObjcMethod::name):
              (ObjcMethod::getMethodSignature):
              (ObjcMethod::setJavaScriptName):
              (ObjcField::name):
              (ObjcField::type):
              (ObjcField::valueFromInstance):
              (convertValueToObjcObject):
              (ObjcField::setValueToInstance):
              (ObjcArray::operator=):
              (ObjcArray::setValueAt):
              (ObjcArray::valueAt):
              (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
              (ObjcFallbackObjectImp::callAsFunction):
              (ObjcFallbackObjectImp::defaultValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdc01d5e
    • andersca's avatar
      2006-06-28 Anders Carlsson <acarlsson@apple.com> · e630e667
      andersca authored
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8636
              REGRESSION: JavaScript access to Java applet causes hang (_webViewURL not implemented)
              
              * bindings/jni/jni_objc.mm:
              (KJS::Bindings::dispatchJNICall):
              Just pass nil as the calling URL. This will cause the Java plugin to use the URL of the page
              containing the applet (which is what we used to do).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e630e667
    • andersca's avatar
      2006-06-28 Anders Carlsson <acarlsson@apple.com> · b12fa148
      andersca authored
              Reviewed by Darin.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              Move FIXME comment here.
              
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::getComputedStyle):
              Don't do a null check on the renderer here. Everything's handled by 
              CSSComputedStyleDeclaration anyway.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b12fa148
    • justing's avatar
      Reviewed by darin · b18807a1
      justing authored
              * rendering/RenderContainer.cpp: Fixed #include formatting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b18807a1
    • justing's avatar
      LayoutTests: · caae5417
      justing authored
              Reviewed by levi
              
              <rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work
              
              Added:
              * editing/selection/click-before-and-after-table-expected.txt: Added.
              * editing/selection/click-before-and-after-table.html: Added.
              Updated to reflect fix:
              * editing/selection/move-by-line-001-expected.checksum:
              * editing/selection/move-by-line-001-expected.png:
      
      WebCore:
      
              Reviewed by levi
              
              <rdar://problem/4599735> Clicking out of a table at the extremes of an editable document doesn't appear to work
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::positionForCoordinates): In the fall through case,
              where we can't find a child block that contains (x, y), pass to RenderFlow
              instead of the last visible child block.
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::positionForCoordinates): Don't pass to the closest 
              child renderer if this is a table and (x, y) is outside the table.  Return
              a VisiblePosition before or after the table.
              Fixed the code that finds the closest child renderer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caae5417
    • hyatt's avatar
      Preserve entity text in view source mode. This patch doesn't highlight the · d1251907
      hyatt authored
              the entities yet, but it at least prevents their resolution and removal.
      
              Reviewed by darin
      
              * WebCore.xcodeproj/project.pbxproj:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseEntity):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1251907
    • andersca's avatar
      WebCore: · 087377a2
      andersca authored
      2006-06-27  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
              REGRESSION: getComputedStyle should do a relayout
              
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::getComputedStyle):
              Do a relayout.
      
      LayoutTests:
      
      2006-06-27  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9623
              REGRESSION: getComputedStyle should do a relayout
      
              * fast/css/getComputedStyle-relayout-expected.txt: Added.
              * fast/css/getComputedStyle-relayout.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      087377a2
    • thatcher's avatar
      Adding symbols for debug builds. · d37fc8a7
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d37fc8a7
    • thatcher's avatar
      Reviewed by Darin. · b203939a
      thatcher authored
              <rdar://problem/4406785> Add an export file to TOT JavaScriptCore like the Safari-2-0-branch
      
              * JavaScriptCore.exp: Added.
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b203939a
    • mjs's avatar
      Reviewed by Adele · 95e2cf40
      mjs authored
              - fixed <rdar://problem/4550473> Reproducible hang on www.digg.com
              
              * dom/NodeList.cpp:
              (WebCore::NodeList::recursiveItem): Make NodeList caching also
              work for backwards iteration - if the requested index is before
              the last cached, but closer to it than to the start of the list,
              then search backwards from there.
              (WebCore::NodeList::itemForwardsFromCurrent): Split this out as a
              helper method.
              (WebCore::NodeList::itemBackwardsFromCurrent): New helper, similar
              to the above.
              * dom/NodeList.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95e2cf40
    • beidson's avatar
      Reviewed by Levi · 037bdb04
      beidson authored
              Some SQLDatabase cleanup (style stuff) and enhancements
      
              * icon/SQLDatabase.cpp:
              (SQLDatabase::open):
              (SQLDatabase::executeCommand):
              (SQLDatabase::returnsAtLeastOneResult):  Accessor to see if this query returns results
              (SQLDatabase::lastInsertRowID):  Accessor for the rowid of the last insert
              * icon/SQLDatabase.h:
              (WebCore::SQLStatement::prepareAndStep):
              * icon/SQLStatement.cpp:
              (WebCore::SQLStatement::bindInt64):
              -All of the following used to require the user to manually prepare and step a statement
              before asking for the result.  Now it will prepare and step itself so you can use a temporary
              object to get a quick result
              (WebCore::SQLStatement::getColumnName):
              (WebCore::SQLStatement::getColumnName16):
              (WebCore::SQLStatement::getColumnText):
              (WebCore::SQLStatement::getColumnText16):
              (WebCore::SQLStatement::getColumnDouble):
              (WebCore::SQLStatement::getColumnInt):
              (WebCore::SQLStatement::getColumnInt64):
              (WebCore::SQLStatement::getColumnBlobAsVector):
              (WebCore::SQLStatement::getColumnBlob):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      037bdb04
    • adachan's avatar
      2006-06-27 Ada Chan <adachan@apple.com> · 0cd61ac7
      adachan authored
              Reviewed by sfalken.
      
              Fixed build.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cd61ac7
    • bdakin's avatar
      Reviewed by Hyatt. · 0b5dc49f
      bdakin authored
              Fix for <rdar://problem/4602635> Media queries must be extended to 
              address CSS pixel scaling factor
      
              * css/MediaFeatureNames.h: Add -webkit-device-pixel-ratio, -webkit-
              min-device-pixel-ratio, and -webkit-max-device-pixel-ratio to the 
              list of feature names.
              * css/MediaQueryEvaluator.cpp:
              (WebCore::cmpvalue): Added a version of cmpvalue that compares 
              floats.
              (WebCore::device_pixel_ratioMediaFeatureEval):
              (WebCore::min_device_pixel_ratioMediaFeatureEval):
              (WebCore::max_device_pixel_ratioMediaFeatureEval):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b5dc49f
    • darin's avatar
      Reviewed by Geoff. · 8d7f073b
      darin authored
              - finish with http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
                REGRESSION: some callers are still using clientX/Y to get pageX/Y
      
              * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
              Change to use pageX/Y, but this really doesn't matter since framesets
              can't be scrolled -- it's the frames that are scrolled. So this change
              has no user-visible effect, but it's still better this way.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d7f073b
    • darin's avatar
      LayoutTests: · ee673905
      darin authored
              Tests for fix for 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
              REGRESSION: some callers are still using clientX/Y to get pageX/Y
      
              * fast/events/anchor-image-scrolled-x-y-expected.txt: Added.
              * fast/events/anchor-image-scrolled-x-y.html: Added.
              * fast/events/input-image-scrolled-x-y-expected.txt: Added.
              * fast/events/input-image-scrolled-x-y.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - fix 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
                REGRESSION: some callers are still using clientX/Y to get pageX/Y
      
              Test: fast/events/anchor-image-scrolled-x-y.html
              Test: fast/events/input-image-scrolled-x-y.html
      
              * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use pageX/Y.
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee673905
    • beidson's avatar
      Reviewed by Maciej · ab9e9e13
      beidson authored
              Added functionality to WebCore::Image to get multiple representations/sizes into TIFF data
      
              * platform/mac/ImageMac.mm:
              (WebCore::Image::getTIFFRepresentation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab9e9e13
  3. 26 Jun, 2006 5 commits
    • hyatt's avatar
      Fix for 9538, support syntax highlighted HTML source. Lots of loose · 3ad24079
      hyatt authored
              ends still (script/style/comments/doctype/entities/accurate whitespace).
      
              Reviewed by darin
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setInViewSourceMode:]):
              (-[WebCoreFrameBridge inViewSourceMode]):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::loadDefaultStyle):
              (WebCore::CSSStyleSelector::matchUARules):
              * css/cssstyleselector.h:
              * css/view-source.css: Added.
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              * dom/xml_tokenizer.h:
              (WebCore::Tokenizer::Tokenizer):
              (WebCore::Tokenizer::~Tokenizer):
              (WebCore::Tokenizer::inViewSourceMode):
              (WebCore::Tokenizer::setInViewSourceMode):
              * html/HTMLAttributeNames.in:
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::init):
              (WebCore::HTMLFrameElement::parseMappedAttribute):
              (WebCore::HTMLFrameElement::attach):
              * html/HTMLFrameElement.h:
              (WebCore::HTMLFrameElement::viewSourceMode):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::HTMLTokenizer):
              (WebCore::HTMLTokenizer::scriptHandler):
              (WebCore::HTMLTokenizer::scriptExecution):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::continueProcessing):
              (WebCore::HTMLTokenizer::write):
              (WebCore::HTMLTokenizer::timerFired):
              (WebCore::HTMLTokenizer::end):
              (WebCore::HTMLTokenizer::processToken):
              (WebCore::HTMLTokenizer::notifyFinished):
              * html/HTMLTokenizer.h:
              * html/HTMLViewSourceDocument.cpp: Added.
              (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
              (WebCore::HTMLViewSourceDocument::createTokenizer):
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addViewSourceAttribute):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              * html/HTMLViewSourceDocument.h: Added.
              * page/Frame.cpp:
              (WebCore::Frame::begin):
              (WebCore::Frame::inViewSourceMode):
              (WebCore::Frame::setInViewSourceMode):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ad24079
    • hyatt's avatar
      Fix for 9538, support syntax highlighting for HTML source. · d45e71de
      hyatt authored
              Reviewed by darin
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebView.m:
              (-[WebView _setInViewSourceMode:]):
              (-[WebView _inViewSourceMode]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d45e71de
    • andersca's avatar
      2006-06-26 Anders Carlsson <acarlsson@apple.com> · 5dc61eae
      andersca authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
              REGRESSION: Crash when closing tabs on newegg.com
              
              * page/Frame.cpp:
              (WebCore::Frame::pageDestroyed):        
              * page/Frame.h:
              Add new method which is invoked when the frame's page has been destroyed.
              Currently this function disassociates the JS Window object with the frame, 
              stopping any running JS timers.
              
              * page/Page.cpp:
              (WebCore::Page::~Page):
              Call pageDestroyed on all frames.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dc61eae
    • darin's avatar
      Reviewed and reworked by Darin. · 8ce13dc1
      darin authored
              Code cleanup, calculate clientX/clientY in one central place.
      
              * dom/EventTargetNode.h:
              * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
              Renamed parameters to pageX/Y since they aren't clientX/Y values.
              Removed code to compute clientX/Y (was a bit confused in naming before),
              because that's now done inside MouseEvent.
      
              * dom/MouseEvent.h:
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters.
              (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed.
              (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML,
              when it was talking about the DOM standard.
      
              * dom/MouseRelatedEvent.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::contentsX): Added helper function.
              (WebCore::contentsY): Ditto.
              (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter,
              and added code to compute clientX/Y based on pageX/Y.
              (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.
      
              * dom/WheelEvent.h:
              * dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y
              parameter.
      
              * page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code
              to compute coordinates, and renamed the confusingly named clientPos (which was
              a page-relative position) to contentsPos.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ce13dc1
    • darin's avatar
      LayoutTests: · 5ff2bf2c
      darin authored
              Reviewed by Darin.
      
              * LayoutTests/fast/events/objc-event-api-expected.txt: Updated to
              reflect flipped coordinates dumped by the layout tests.
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9579
      
              Report screenY values as (height of zero screen - screenY)
      
              * DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ff2bf2c
  4. 25 Jun, 2006 13 commits
    • thatcher's avatar
      Reviewed by Geoff. · c571e06f
      thatcher authored
              Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9591
              
              Makes breakpoints dragable. If dragged off the gutter they are deleted.
      
              * Drosera/debugger.js:
              * Drosera/viewer.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c571e06f
    • darin's avatar
      LayoutTests: · 8c74d768
      darin authored
              Reviewed by Darin.
      
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9185
      
              * fast/forms/input-appearance-height-expected.png: Added.
              * fast/forms/input-appearance-height-expected.txt: Added.
              * fast/forms/input-appearance-height.html: Added.
              Tests the height attribute on all input types
      
              * fast/forms/input-type-change-expected.checksum: Added.
              * fast/forms/input-type-change-expected.png: Added.
              * fast/forms/input-type-change-expected.txt: Added.
              * fast/forms/input-type-change.html: Added.
              Tests changing an input type=TEXT to type=IMAGE with
              a height and width specified on the element.
      
              * fast/forms/input-type-change2-expected.checksum: Added.
              * fast/forms/input-type-change2-expected.png: Added.
              * fast/forms/input-type-change2-expected.txt: Added.
              * fast/forms/input-type-change2.html: Added.
              Tests changing an input type=IMAGE to type=TEXT with
              a height and width specified on the element.
      
      WebCore:
      
              Reviewed and tweaked by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9185
              REGRESSION: UserID field appears with an incorrect height 
              on americanexpresslogin page
              - Height and Width attribute only applies to IMAGE and HIDDEN
              types.
      
              * dom/NamedMappedAttrMap.h:
              (WebCore::NamedMappedAttrMap::getAttributeItem):
              Added to static_cast method.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setInputType):
              Update the style decl if input type has changed.
              (WebCore::HTMLInputElement::mapToEntry):
              Only Cache height and width if it is an IMAGE or HIDDEN
              (WebCore::HTMLInputElement::parseMappedAttribute):
              Check type before adding height and width style.
              (WebCore::HTMLInputElement::attach):
              Remove code for discarding width.
      
              * html/HTMLInputElement.h:
              (WebCore::HTMLInputElement::respectHeightAndWidthAttrs):
              New method added to report if this input type uses height & width.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c74d768
    • ggaren's avatar
      Reviewed by Adele. · dcc6aead
      ggaren authored
              
              - Added JSConstructorMake to match JSFunctionMake, along with test code.
              
              [ I checked in the ChangeLog before without the actual files. ]
      
              * API/JSObjectRef.cpp:
              (JSConstructorMake):
              * API/JSObjectRef.h:
              * API/testapi.c:
              (myConstructor_callAsConstructor):
              (main):
              * API/testapi.js:
              * ChangeLog:
              * JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi
              target -- this was an oversight in my earlier check-in.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcc6aead
    • thatcher's avatar
      Reviewed by Darin. · 7ee5fcbb
      thatcher authored
              
              Bug 9568: assertion failure in Safari after quitting Drosera
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9568
      
              Call switchToServerNamed:nil and not removeLister to make sure
              the server object is set to nil to prevent further removeListener calls.
      
              * Drosera/DebuggerDocument.m:
              (-[DebuggerDocument applicationTerminating:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ee5fcbb
    • ddkilzer's avatar
      LayoutTests: · f7154a32
      ddkilzer authored
              Reviewed by Darin.
      
              * fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
              * fast/forms/textarea-hard-linewrap.html: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7154a32
    • ddkilzer's avatar
      WebCore: · 643dfd0b
      ddkilzer authored
              Reviewed by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9537
                REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()
      
              Test: fast/forms/textarea-hard-linewrap-empty.html
      
              * rendering/RenderTextField.cpp:
              (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for
              m_div->firstChild()->renderer().
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9537
                REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()
      
              * fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
              * fast/forms/textarea-hard-linewrap-empty.html: Added.
              * fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and
              renamed function from foo() to submitForm().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643dfd0b
    • ddkilzer's avatar
      WebKitTools: · 25b4b502
      ddkilzer authored
              Reviewed by Darin.
      
              * Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find
              that the directory is not empty instead of reading in every single file and directory first,
              then checking the count.  Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not
              defined.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25b4b502
    • ddkilzer's avatar
      WebCore: · a4d27ab3
      ddkilzer authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9388
                REGRESSION: outlines don't get erased when removed in some cases
      
              Test: fast/repaint/outline-shrinking.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is
              becoming narrower, even if we are going to relayout.
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9388
                REGRESSION: outlines don't get erased when removed in some cases
      
              * fast/repaint/outline-shrinking-expected.checksum: Added.
              * fast/repaint/outline-shrinking-expected.png: Added.
              * fast/repaint/outline-shrinking-expected.txt: Added.
              * fast/repaint/outline-shrinking.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4d27ab3
    • thatcher's avatar
      Build fix for for GCC 5406 · f1b59e62
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1b59e62
    • thatcher's avatar
      Rolls out a build fix I made on Friday, this was correctly fixed by adding a... · ad846835
      thatcher authored
      Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad846835
    • ddkilzer's avatar
      WebCore: · 32149159
      ddkilzer authored
              Reviewed by Darin.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
              event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              Make sure clientX and clientY take into account the scroll offsets
              of the view.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchMouseEvent):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              * dom/MouseEvent.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              (WebCore::MouseRelatedEvent::initCoordinates):
              * dom/MouseRelatedEvent.h:
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
              * page/FrameView.cpp:
              (WebCore::FrameView::dispatchDragEvent):
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Test cases for
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
              event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              * fast/dom/window-xy-properties-expected.txt: Added.
              * fast/dom/window-xy-properties.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32149159
    • thatcher's avatar
      Leak fix · 5cdc5e0e
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cdc5e0e
    • darin's avatar
      * Scripts/svn-apply: Tweak comments. · 43efeffc
      darin authored
              * Scripts/svn-create-patch: Ditto.
              * Scripts/svn-unapply: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43efeffc