1. 23 Oct, 2008 31 commits
    • jmalonzo@webkit.org's avatar
      2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org> · a721ed5b
      jmalonzo@webkit.org authored
              Fix Gtk build typo introduced in http://trac.webkit.org/changeset/37826.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a721ed5b
    • darin@chromium.org's avatar
      2008-10-23 Darin Fisher <darin@chromium.org> · 65ff24c9
      darin@chromium.org authored
              Reviewed by Eric Seidel.
      
              m_frame null checked but then dereferenced
              https://bugs.webkit.org/show_bug.cgi?id=21845
      
              This error was found using a static analysis tool, and so I do not know
              how to produce a null m_frame on entry to this method.  Hence, I have
              not included a regression test.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::allowDHTMLDrag): Add an early return.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ff24c9
    • kmccullough@apple.com's avatar
      2008-10-23 Kevin McCullough <kmccullough@apple.com> · eb5dc783
      kmccullough@apple.com authored
              Rubber stamped by Mark Rowe.
      
              -Skipping the profiler tests until we know why they fail on tiger:
              <rdar://problem/6316530> Profiler tests fail on tiger
      
              * platform/mac-tiger/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb5dc783
    • ddkilzer@apple.com's avatar
      Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10 · 634df153
      ddkilzer@apple.com authored
      JavaScriptCore:
      
              Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
      
              <https://bugs.webkit.org/show_bug.cgi?id=21832>
      
              Reviewed by Sam Weinig.
      
              * pcre/dftables: Use imported tempfile() from File::Temp instead of
              'new File::Temp' to make the script work with Perl 5.10.
      
      WebKitTools:
      
              Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
      
              <https://bugs.webkit.org/show_bug.cgi?id=21832>
      
              Reviewed by Sam Weinig.
      
              * Scripts/bisect-builds: Use imported tempfile() from File::Temp
              instead of 'new File::Temp' to make the script work with Perl 5.10.
              * Scripts/sort-Xcode-project-file: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      634df153
    • barraclough@apple.com's avatar
      2008-10-23 Gavin Barraclough <barraclough@apple.com> · e9642656
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              Fix hideous pathological case performance when looking up repatch info, bug #21727.
      
              When repatching JIT code to optimize we look up records providing information about
              the generated code (also used to track recsources used in linking to be later released). 
              The lookup was being performed using a linear scan of all such records.
      
              (1) Split up the different types of reptach information.  This means we can search them
                  separately, and in some cases should reduce their size.
              (2) In the case of property accesses, search with a binary chop over the data.
              (3) In the case of calls, pass a pointer to the repatch info into the relink function.
      
              * VM/CTI.cpp:
              (JSC::CTI::CTI):
              (JSC::CTI::compileOpCall):
              (JSC::CTI::privateCompileMainPass):
              (JSC::CTI::privateCompileSlowCases):
              (JSC::CTI::privateCompile):
              (JSC::CTI::unlinkCall):
              (JSC::CTI::linkCall):
              * VM/CTI.h:
              * VM/CodeBlock.cpp:
              (JSC::CodeBlock::dump):
              (JSC::CodeBlock::~CodeBlock):
              (JSC::CodeBlock::unlinkCallers):
              (JSC::CodeBlock::derefStructureIDs):
              * VM/CodeBlock.h:
              (JSC::StructureStubInfo::StructureStubInfo):
              (JSC::CallLinkInfo::CallLinkInfo):
              (JSC::CallLinkInfo::setUnlinked):
              (JSC::CallLinkInfo::isLinked):
              (JSC::getStructureStubInfoReturnLocation):
              (JSC::binaryChop):
              (JSC::CodeBlock::addCaller):
              (JSC::CodeBlock::getStubInfo):
              * VM/CodeGenerator.cpp:
              (JSC::CodeGenerator::emitResolve):
              (JSC::CodeGenerator::emitGetById):
              (JSC::CodeGenerator::emitPutById):
              (JSC::CodeGenerator::emitCall):
              (JSC::CodeGenerator::emitConstruct):
              * VM/Machine.cpp:
              (JSC::Machine::cti_vm_lazyLinkCall):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9642656
    • kmccullough@apple.com's avatar
      2008-10-23 Kevin McCullough <kmccullough@apple.com> · b7fd8c75
      kmccullough@apple.com authored
              Forgot to remove the tests from the skipped lists, this should have been
              apart of the last checkin.
      
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7fd8c75
    • kmccullough@apple.com's avatar
      2008-10-23 Kevin McCullough <kmccullough@apple.com> · 5b0d1ee6
      kmccullough@apple.com authored
              Reviewed by Tim Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=21817
              Bug 21817: Manual profiler tests should be made into layout tests
      
              - Added the expected results for the profiler tests and removed the
              tests from the skipped list.
              - Also removed two tests that were accidentally checked in previously.
              - Also changed the text on the tests to be more apparent how to run them
              manually.
      
              * fast/profiler/anonymous-event-handler-expected.txt: Added.
              * fast/profiler/anonymous-event-handler.html:
              * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Added.
              * fast/profiler/anonymous-function-called-from-different-contexts.html:
              * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Added.
              * fast/profiler/anonymous-function-calls-built-in-functions.html:
              * fast/profiler/anonymous-function-calls-eval-expected.txt: Added.
              * fast/profiler/anonymous-function-calls-eval.html:
              * fast/profiler/apply-expected.txt: Added.
              * fast/profiler/apply.html:
              * fast/profiler/built-in-function-calls-anonymous-expected.txt: Added.
              * fast/profiler/built-in-function-calls-anonymous.html:
              * fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Added.
              * fast/profiler/built-in-function-calls-user-defined-function.html:
              * fast/profiler/call-expected.txt: Added.
              * fast/profiler/call-nodelist-as-function-expected.txt: Added.
              * fast/profiler/call-nodelist-as-function.html:
              * fast/profiler/call.html: Added.
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Added.
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
              * fast/profiler/compare-multiple-profiles-expected.txt: Added.
              * fast/profiler/compare-multiple-profiles.html:
              * fast/profiler/constructor-expected.txt: Added.
              * fast/profiler/constructor.html:
              * fast/profiler/dead-time-expected.txt: Added.
              * fast/profiler/dead-time.html:
              * fast/profiler/deep-recursion.html: Removed.
              * fast/profiler/document-dot-write-expected.txt: Added.
              * fast/profiler/document-dot-write.html:
              * fast/profiler/event-handler-expected.txt: Added.
              * fast/profiler/event-handler.html:
              * fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Added.
              * fast/profiler/execution-context-and-eval-on-same-line.html:
              * fast/profiler/heavy-view-expected.txt: Added.
              * fast/profiler/heavy-view.html:
              * fast/profiler/inline-event-handler-expected.txt: Added.
              * fast/profiler/inline-event-handler.html:
              * fast/profiler/many-calls-in-the-same-scope-expected.txt: Added.
              * fast/profiler/many-calls-in-the-same-scope.html: Added.
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Added.
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
              * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Added.
              * fast/profiler/multiple-and-different-scoped-function-calls.html:
              * fast/profiler/multiple-frames-expected.txt: Added.
              * fast/profiler/multiple-frames.html:
              * fast/profiler/multiple-windows.html: Removed.
              * fast/profiler/nested-anonymous-functon-expected.txt: Added.
              * fast/profiler/nested-anonymous-functon.html:
              * fast/profiler/nested-start-and-stop-profiler-expected.txt: Added.
              * fast/profiler/nested-start-and-stop-profiler.html:
              * fast/profiler/no-execution-context-expected.txt: Added.
              * fast/profiler/no-execution-context.html:
              * fast/profiler/one-execution-context-expected.txt: Added.
              * fast/profiler/one-execution-context.html:
              * fast/profiler/profile-calls-in-included-file-expected.txt: Added.
              * fast/profiler/profile-calls-in-included-file.html:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Added.
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
              * fast/profiler/profiling-from-a-nested-location-expected.txt: Added.
              * fast/profiler/profiling-from-a-nested-location.html:
              * fast/profiler/simple-event-call-expected.txt: Added.
              * fast/profiler/simple-event-call.html:
              * fast/profiler/simple-no-level-change-expected.txt: Added.
              * fast/profiler/simple-no-level-change.html:
              * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Added.
              * fast/profiler/start-and-stop-profiler-multiple-times.html:
              * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Added.
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
              * fast/profiler/start-but-dont-stop-profiling-expected.txt: Added.
              * fast/profiler/start-but-dont-stop-profiling.html:
              * fast/profiler/stop-profiling-after-setTimeout-expected.txt: Added.
              * fast/profiler/stop-profiling-after-setTimeout.html:
              * fast/profiler/stop-then-function-call-expected.txt: Added.
              * fast/profiler/stop-then-function-call.html:
              * fast/profiler/throw-exception-from-eval-expected.txt: Added.
              * fast/profiler/throw-exception-from-eval.html:
              * fast/profiler/two-execution-contexts-expected.txt: Added.
              * fast/profiler/two-execution-contexts.html:
              * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Added.
              * fast/profiler/user-defined-function-calls-built-in-functions.html:
              * fast/profiler/window-dot-eval-expected.txt: Added.
              * fast/profiler/window-dot-eval.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b0d1ee6
    • mitz@apple.com's avatar
      WebCore: · 83d2e872
      mitz@apple.com authored
              Reviewed by Sam Weinig with no hesitation.
      
              - fix the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
                <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
      
              Test: fast/text/bidi-embedding-pop-and-push-same.html
      
              * platform/text/BidiResolver.h:
              (WebCore::BidiResolver::embed): Changed to only add the embedding
              operation to a vector of pending operations.
      
              (WebCore::BidiResolver::lowerExplicitEmbeddingLevel): Added. Moved the
              code that used to be in the PDF case of embed() here, except the part
              that sets the context.
      
              (WebCore::BidiResolver::raiseExplicitEmbeddingLevel): Added. Moved the
              code that used to be in the non-PDF case of embed() here, except the
              part the sets the context.
      
              (WebCore::BidiResolver::commitExplicitEmbedding): Added. Processes the
              explicit embedding operations in the vector by creating an updated
              context and determining the old and new embedding levels. If the levels
              are not the same, calls {lower,raise}ExplicitEmbeddingLevel(). Always
              sets the context to the new one.
      
              (WebCore::BidiResolver::createBidiRunsForLine): Added calls to
              commitExplicitEmbedding() after calling embed() and after calling
              increment().
      
              * rendering/bidi.cpp:
              (WebCore::bidiFirst): Added calls to commitExplicitEmbedding() because
              this function increments the resolver.
      
              (WebCore::RenderBlock::skipLeadingWhitespace): Ditto.
      
      LayoutTests:
      
              Reviewed by Sam Weinig with no hesitation.
      
              - test for the HTML/CSS case of https://bugs.webkit.org/show_bug.cgi?id=19839
                <rdar://problem/6304805> A PDF,RLE sequence that should be a no-op affects bidi reordering
      
              * fast/text/bidi-embedding-pop-and-push-same.html: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83d2e872
    • mrowe@apple.com's avatar
      Build fix. · d4dce5b8
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4dce5b8
    • jmalonzo@webkit.org's avatar
      2008-10-23 Jan Michael Alonzo <jmalonzo@webkit.org> · 2af1d5f9
      jmalonzo@webkit.org authored
              Gtk build fix. Not reviewed.
      
              Add DNSCurl and DNSSoup to the Gtk build
      
              * GNUmakefile.am:
              * platform/gtk/TemporaryLinkStubs.cpp:
              * platform/network/soup/DNSSoup.cpp: Copied from WebCore/platform/network/curl/DNSCurl.cpp.
              (WebCore::prefetchDNS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2af1d5f9
    • eric@webkit.org's avatar
      Reviewed by Sam Weinig. · 378afbe0
      eric@webkit.org authored
              Un-break the Darwin build.
      
              * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
              * platform/graphics/cg/ImageCG.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      378afbe0
    • darin@chromium.org's avatar
      2008-10-23 Darin Fisher <darin@chromium.org> · 9573fd42
      darin@chromium.org authored
              Reviewed by Eric Seidel.
      
              Fix forward decls to be struct instead of class.
              https://bugs.webkit.org/show_bug.cgi?id=21838
      
              * rendering/style/StyleRareInheritedData.h:
              * rendering/style/StyleRareNonInheritedData.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9573fd42
    • weinig@apple.com's avatar
      2008-10-23 Brent Fulgham <bfulgham@gmail.com> · bb96c632
      weinig@apple.com authored
              Reviewed by Oliver Hunt.
      
              * platform/network/curl/ResourceRequest.h:  A better implementation
                of CFURLRequest, rather than void*.  This gives better compatibility 
                with the WebKit.idl interface.
              (WebCore::ResourceRequest::cfURLRequest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb96c632
    • kmccullough@apple.com's avatar
      2008-10-23 Kevin McCullough <kmccullough@apple.com> · 63e67135
      kmccullough@apple.com authored
              Reviewed by Tim Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=21817
              Bug 21817: Manual profiler tests should be made into layout tests
      
              - Here are the changes to the tests.  The most significant part is the
              change to profiler-test-JS-resources.js where endTest will now notify
              the layout test controller if it was waiting and call the print function
              to iterate over all of the profiles and log their structure.
              - Most of these tests changed to include the layoutTestController, use
              endTest() or call the print function directly if there was some reason
              that they could not use endTest().
      
              * fast/profiler/resources/profiler-test-JS-resources.js:
              (endTest): Stop any waits and print the profile information.
              (printHeavyProfilesDataWithoutTime): Print all profile information in 
              heavy view, without time.
              (printProfilesDataWithoutTime): Print all profile information in tree
              view, without time.
              (printProfileNodeWithoutTime): Print a profile node's informmation and
              all of it's children's information.
              * fast/profiler/anonymous-event-handler.html:
              * fast/profiler/anonymous-function-called-from-different-contexts.html:
              * fast/profiler/anonymous-function-calls-built-in-functions.html:
              * fast/profiler/anonymous-function-calls-eval.html:
              * fast/profiler/apply.html:
              * fast/profiler/built-in-function-calls-anonymous.html:
              * fast/profiler/built-in-function-calls-user-defined-function.html:
              * fast/profiler/call-nodelist-as-function.html:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
              * fast/profiler/compare-multiple-profiles.html:
              * fast/profiler/constructor.html:
              * fast/profiler/dead-time.html:
              * fast/profiler/deep-recursion.html:
              * fast/profiler/document-dot-write.html:
              * fast/profiler/event-handler.html:
              * fast/profiler/execution-context-and-eval-on-same-line.html:
              * fast/profiler/heavy-view.html:
              * fast/profiler/inline-event-handler.html:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
              * fast/profiler/multiple-and-different-scoped-function-calls.html:
              * fast/profiler/multiple-frames.html:
              * fast/profiler/nested-anonymous-functon.html:
              * fast/profiler/nested-start-and-stop-profiler.html:
              * fast/profiler/no-execution-context.html:
              * fast/profiler/one-execution-context.html:
              * fast/profiler/profile-calls-in-included-file.html:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
              * fast/profiler/profiling-from-a-nested-location.html:
              * fast/profiler/simple-event-call.html:
              * fast/profiler/simple-no-level-change.html:
              * fast/profiler/start-and-stop-profiler-multiple-times.html:
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
              * fast/profiler/start-but-dont-stop-profiling.html:
              * fast/profiler/stop-profiling-after-setTimeout.html:
              * fast/profiler/stop-then-function-call.html:
              * fast/profiler/throw-exception-from-eval.html:
              * fast/profiler/two-execution-contexts.html:
              * fast/profiler/user-defined-function-calls-built-in-functions.html:
              * fast/profiler/window-dot-eval.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63e67135
    • eric@webkit.org's avatar
      2008-10-23 Mike Pinkerton <pinkerton@chromium.org> · b7074c08
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              PLATFORM(CHROMIUM) uses CG the same way PLATFORM(MAC) does so fix
              ifdefs to reflect that.
      
              * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
              * platform/graphics/cg/ImageCG.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7074c08
    • pkasting@chromium.org's avatar
      JavaScriptCore: · 586415d5
      pkasting@chromium.org authored
      2008-10-23  Peter Kasting  <pkasting@google.com>
      
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=21833
              Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
      
              * wtf/Platform.h:
      
      WebCore:
      
      2008-10-23  Peter Kasting  <pkasting@google.com>
      
              Reviewed by Adam Roben.
      
              https://bugs.webkit.org/show_bug.cgi?id=21833
              Place JavaScript Debugger hooks under #if ENABLE(JAVASCRIPT_DEBUGGER).
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::close):
              * inspector/InspectorController.h:
              * page/Page.cpp:
              (WebCore::Page::Page):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      586415d5
    • ddkilzer@apple.com's avatar
      Bug 21831: Fix create_hash_table for Perl 5.10 · 763c4ef3
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=21831>
      
              Reviewed by Sam Weinig.
      
              * kjs/create_hash_table: Escaped square brackets so that Perl 5.10
              doesn't try to use @nameEntries.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763c4ef3
    • darin@apple.com's avatar
      2008-10-23 Darin Adler <darin@apple.com> · bce3fd68
      darin@apple.com authored
              - try to get buildbot green again
      
              * platform/gtk/Skipped: Added fast/profiler.
              * platform/mac/Skipped: Fixed typo: fast/profiler, not fast/profile.
              * platform/qt/Skipped: Added fast/profiler.
              * platform/win/Skipped: Fixed typo: fast/profiler, not fast/profile.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bce3fd68
    • kmccullough@apple.com's avatar
      2008-10-23 Kevin McCullough <kmccullough@apple.com> · 91e0fc0f
      kmccullough@apple.com authored
              Forgot to actually check these files in from last time :(
      
              * fast/profiler: Added.
              * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
              * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
              * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
              * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
              * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
              * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
              * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
              * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
              * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
              * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
              * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
              * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
              * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
              * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
              * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
              * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
              * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
              * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
              * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
              * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
              * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
              * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
              * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
              * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
              * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
              * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
              * fast/profiler/resources: Added.
              * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
              * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
              * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
              * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
              * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
              * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
              * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
              * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
              * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
              * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
              * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
              * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
              * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91e0fc0f
    • kmccullough@apple.com's avatar
      WebCore: · d7e4bf7f
      kmccullough@apple.com authored
      2008-10-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Tim Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=21817
              Bug 21817: Manual profiler tests should be made into layout tests
      
              -Moving the tests before diffing so that it's clear what changed.
      
              * manual-tests/inspector/profiler-test-anonymous-event-handler.html: Removed.
              * manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html: Removed.
              * manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html: Removed.
              * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html: Removed.
              * manual-tests/inspector/profiler-test-apply.html: Removed.
              * manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html: Removed.
              * manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html: Removed.
              * manual-tests/inspector/profiler-test-call-nodelist-as-function.html: Removed.
              * manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
              * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Removed.
              * manual-tests/inspector/profiler-test-constructor.html: Removed.
              * manual-tests/inspector/profiler-test-dead-time.html: Removed.
              * manual-tests/inspector/profiler-test-deep-recursion.html: Removed.
              * manual-tests/inspector/profiler-test-document-dot-write.html: Removed.
              * manual-tests/inspector/profiler-test-event-handler.html: Removed.
              * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html: Removed.
              * manual-tests/inspector/profiler-test-heavy-view.html: Removed.
              * manual-tests/inspector/profiler-test-inline-event-handler.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-frames.html: Removed.
              * manual-tests/inspector/profiler-test-multiple-windows.html: Removed.
              * manual-tests/inspector/profiler-test-nested-anonymous-functon.html: Removed.
              * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html: Removed.
              * manual-tests/inspector/profiler-test-no-execution-context.html: Removed.
              * manual-tests/inspector/profiler-test-one-execution-context.html: Removed.
              * manual-tests/inspector/profiler-test-profile-calls-in-included-file.html: Removed.
              * manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
              * manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html: Removed.
              * manual-tests/inspector/profiler-test-simple-event-call.html: Removed.
              * manual-tests/inspector/profiler-test-simple-no-level-change.html: Removed.
              * manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html: Removed.
              * manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html: Removed.
              * manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html: Removed.
              * manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html: Removed.
              * manual-tests/inspector/profiler-test-stop-then-function-call.html: Removed.
              * manual-tests/inspector/profiler-test-throw-exception-from-eval.html: Removed.
              * manual-tests/inspector/profiler-test-two-execution-contexts.html: Removed.
              * manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html: Removed.
              * manual-tests/inspector/profiler-test-window-dot-eval.html: Removed.
              * manual-tests/inspector/resources/other-frame.html: Removed.
              * manual-tests/inspector/resources/other-window.html: Removed.
              * manual-tests/inspector/resources/profiler-test-JS-resources.js: Removed.
      
      LayoutTests:
      
      2008-10-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Tim Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=21817
              Bug 21817: Manual profiler tests should be made into layout tests
      
              -Moving the tests before diffing so that it's clear what changed.
      
              * platform/mac/Skipped: Skipping until the new files are in place.
              * platform/win/Skipped:
              * fast/profiler: Added.
              * fast/profiler/anonymous-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-event-handler.html.
              * fast/profiler/anonymous-function-called-from-different-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-called-from-different-contexts.html.
              * fast/profiler/anonymous-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-built-in-functions.html.
              * fast/profiler/anonymous-function-calls-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html.
              * fast/profiler/apply.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-apply.html.
              * fast/profiler/built-in-function-calls-anonymous.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-anonymous.html.
              * fast/profiler/built-in-function-calls-user-defined-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-built-in-function-calls-user-defined-function.html.
              * fast/profiler/call-nodelist-as-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-call-nodelist-as-function.html.
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-calling-the-function-that-started-the-profiler-from-another-scope.html.
              * fast/profiler/compare-multiple-profiles.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-compare-multiple-profiles.html.
              * fast/profiler/constructor.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-constructor.html.
              * fast/profiler/dead-time.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-dead-time.html.
              * fast/profiler/deep-recursion.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-deep-recursion.html.
              * fast/profiler/document-dot-write.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-document-dot-write.html.
              * fast/profiler/event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-event-handler.html.
              * fast/profiler/execution-context-and-eval-on-same-line.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html.
              * fast/profiler/heavy-view.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-heavy-view.html.
              * fast/profiler/inline-event-handler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-inline-event-handler.html.
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-anonymous-function-calls.html.
              * fast/profiler/multiple-and-different-scoped-function-calls.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-and-different-scoped-function-calls.html.
              * fast/profiler/multiple-frames.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-frames.html.
              * fast/profiler/multiple-windows.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-multiple-windows.html.
              * fast/profiler/nested-anonymous-functon.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-anonymous-functon.html.
              * fast/profiler/nested-start-and-stop-profiler.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html.
              * fast/profiler/no-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-no-execution-context.html.
              * fast/profiler/one-execution-context.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-one-execution-context.html.
              * fast/profiler/profile-calls-in-included-file.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profile-calls-in-included-file.html.
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html.
              * fast/profiler/profiling-from-a-nested-location.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-profiling-from-a-nested-location.html.
              * fast/profiler/resources: Added.
              * fast/profiler/resources/other-frame.html: Copied from ../WebCore/manual-tests/inspector/resources/other-frame.html.
              * fast/profiler/resources/other-window.html: Copied from ../WebCore/manual-tests/inspector/resources/other-window.html.
              * fast/profiler/resources/profiler-test-JS-resources.js: Copied from ../WebCore/manual-tests/inspector/resources/profiler-test-JS-resources.js.
              * fast/profiler/simple-event-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-event-call.html.
              * fast/profiler/simple-no-level-change.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-simple-no-level-change.html.
              * fast/profiler/start-and-stop-profiler-multiple-times.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiler-multiple-times.html.
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-and-stop-profiling-in-the-same-function.html.
              * fast/profiler/start-but-dont-stop-profiling.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-start-but-dont-stop-profiling.html.
              * fast/profiler/stop-profiling-after-setTimeout.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-profiling-after-setTimeout.html.
              * fast/profiler/stop-then-function-call.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-stop-then-function-call.html.
              * fast/profiler/throw-exception-from-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-throw-exception-from-eval.html.
              * fast/profiler/two-execution-contexts.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-two-execution-contexts.html.
              * fast/profiler/user-defined-function-calls-built-in-functions.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-user-defined-function-calls-built-in-functions.html.
              * fast/profiler/window-dot-eval.html: Copied from ../WebCore/manual-tests/inspector/profiler-test-window-dot-eval.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7e4bf7f
    • andersca@apple.com's avatar
      2008-10-23 Anders Carlsson <andersca@apple.com> · 590933d6
      andersca@apple.com authored
              Reviewed by John Sullivan.
      
              Fix <rdar://problem/6306513> by adding a workaround for <rdar://problem/6304600>.
      
              * libWebKitSystemInterfaceLeopard.a:
              * libWebKitSystemInterfaceTiger.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      590933d6
    • abarth@webkit.org's avatar
      2008-10-23 Adam Barth <abarth@webkit.org> · 31873301
      abarth@webkit.org authored
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=21826
      
              Add accessor for SecurityOrigin::m_domainWasSetInDOM.
      
              * page/SecurityOrigin.h:
              (WebCore::SecurityOrigin::domainWasSetInDOM):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31873301
    • aroben@apple.com's avatar
      Fix Bug 21401: Comments field on "Review Patch" page should be... · e6216bea
      aroben@apple.com authored
              Fix Bug 21401: Comments field on "Review Patch" page should be initially filled with quoted patch
      
              <https://bugs.webkit.org/show_bug.cgi?id=21401>
      
              Reviewed by Dave Hyatt.
      
              * attachment.cgi:
              (edit): Retrieve the attachment data from the database instead of just
              its length. When the attachment is a patch, create a quotedpatch
              template variable that contains the patch data with each line
              prepended with "> ".
              * template/en/custom/attachment/reviewform.html.tmpl:
                - Changed the comments field to have a monospace font
                - Added an "Enter comments below:" caption above the comments field
                  to make it clearer that this is where comments should go, now that
                  the comments field is not initially empty
                - Fill the comments field with the quoted patch
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6216bea
    • darin@apple.com's avatar
      JavaScriptCore: · 3f537b9b
      darin@apple.com authored
      2008-10-23  Darin Adler  <darin@apple.com>
      
              - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
                to remove the JSValuePtr class, to fix two problems
      
                  1) slowness under MSVC, since it doesn't handle a
                     class with a single pointer in it as efficiently
                     as a pointer
      
                  2) uninitialized pointers in Vector
      
              * JavaScriptCore.exp: Updated.
      
              * API/APICast.h:
              (toRef):
              * VM/CTI.cpp:
              (JSC::CTI::asInteger):
              * VM/CodeGenerator.cpp:
              (JSC::CodeGenerator::addConstant):
              * VM/CodeGenerator.h:
              (JSC::CodeGenerator::JSValueHashTraits::constructDeletedValue):
              (JSC::CodeGenerator::JSValueHashTraits::isDeletedValue):
              * VM/Machine.cpp:
              (JSC::Machine::cti_op_add):
              (JSC::Machine::cti_op_pre_inc):
              (JSC::Machine::cti_op_get_by_id):
              (JSC::Machine::cti_op_get_by_id_second):
              (JSC::Machine::cti_op_get_by_id_generic):
              (JSC::Machine::cti_op_get_by_id_fail):
              (JSC::Machine::cti_op_instanceof):
              (JSC::Machine::cti_op_del_by_id):
              (JSC::Machine::cti_op_mul):
              (JSC::Machine::cti_op_call_NotJSFunction):
              (JSC::Machine::cti_op_resolve):
              (JSC::Machine::cti_op_construct_NotJSConstruct):
              (JSC::Machine::cti_op_get_by_val):
              (JSC::Machine::cti_op_sub):
              (JSC::Machine::cti_op_lesseq):
              (JSC::Machine::cti_op_negate):
              (JSC::Machine::cti_op_resolve_base):
              (JSC::Machine::cti_op_resolve_skip):
              (JSC::Machine::cti_op_resolve_global):
              (JSC::Machine::cti_op_div):
              (JSC::Machine::cti_op_pre_dec):
              (JSC::Machine::cti_op_not):
              (JSC::Machine::cti_op_eq):
              (JSC::Machine::cti_op_lshift):
              (JSC::Machine::cti_op_bitand):
              (JSC::Machine::cti_op_rshift):
              (JSC::Machine::cti_op_bitnot):
              (JSC::Machine::cti_op_mod):
              (JSC::Machine::cti_op_less):
              (JSC::Machine::cti_op_neq):
              (JSC::Machine::cti_op_urshift):
              (JSC::Machine::cti_op_bitxor):
              (JSC::Machine::cti_op_bitor):
              (JSC::Machine::cti_op_call_eval):
              (JSC::Machine::cti_op_throw):
              (JSC::Machine::cti_op_next_pname):
              (JSC::Machine::cti_op_typeof):
              (JSC::Machine::cti_op_is_undefined):
              (JSC::Machine::cti_op_is_boolean):
              (JSC::Machine::cti_op_is_number):
              (JSC::Machine::cti_op_is_string):
              (JSC::Machine::cti_op_is_object):
              (JSC::Machine::cti_op_is_function):
              (JSC::Machine::cti_op_stricteq):
              (JSC::Machine::cti_op_nstricteq):
              (JSC::Machine::cti_op_to_jsnumber):
              (JSC::Machine::cti_op_in):
              (JSC::Machine::cti_op_del_by_val):
              (JSC::Machine::cti_vm_throw):
              Removed calls to payload functions.
      
              * VM/Register.h:
              (JSC::Register::Register): Removed overload for JSCell and call
              to payload function.
      
              * kjs/JSCell.h: Changed JSCell to derive from JSValue again.
              Removed JSValuePtr constructor.
              (JSC::asCell): Changed cast from reinterpret_cast to static_cast.
      
              * kjs/JSImmediate.h: Removed JSValuePtr class. Added typedef back.
      
              * kjs/JSValue.h:
              (JSC::JSValue::JSValue): Added empty protected inline constructor back.
              (JSC::JSValue::~JSValue): Same for destructor.
              Removed == and != operator for JSValuePtr.
      
              * kjs/PropertySlot.h:
              (JSC::PropertySlot::PropertySlot): Chnaged argument to const JSValue*
              and added a const_cast.
      
              * kjs/protect.h: Removed overloads and specialization for JSValuePtr.
      
      JavaScriptGlue:
      
      2008-10-23  Darin Adler  <darin@apple.com>
      
              - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * JSValueWrapper.cpp:
              (JSValueWrapper::GetValue): Added missing call to .get().
              * JSValueWrapper.h: ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
      
      WebCore:
      
      2008-10-23  Darin Adler  <darin@apple.com>
      
              - roll out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * bindings/js/ScheduledAction.h:
              * inspector/InspectorController.cpp:
              ProtectedPtr<JSValue> instead of ProtectedPtr<JSValuePtr>.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f537b9b
    • hausmann@webkit.org's avatar
      2008-10-22 Yael Aharon <yael.aharon@nokia.com> · a317f3c7
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              emit scrollRequested unconditionally when scrolling.
      
              See https://bugs.webkit.org/show_bug.cgi?id=21790
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a317f3c7
    • hausmann@webkit.org's avatar
      41572ec8
    • hausmann@webkit.org's avatar
      2008-10-23 Simon Hausmann <hausmann@webkit.org> · 6f9bfcfb
      hausmann@webkit.org authored
              Reviewed by Tor Arne.
      
              Fix handling of mouse events when embedding QWebView into the
              QGraphicsView.
      
              QWebPage accepts or ignores events to indicate whether the web page
              handled the event. However for QWebView to behave like a good widget
              it should always accept the mouse events to indicate that it handled
              them and that they should not be subject to event propagation.
      
              The graphics view relies on acceptance of the initial mouse click to
              make the embedded widget the focus item.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f9bfcfb
    • hausmann@webkit.org's avatar
      2008-10-23 Simon Hausmann <hausmann@webkit.org> · 7ff09a42
      hausmann@webkit.org authored
              Fix the Qt build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ff09a42
    • ap@webkit.org's avatar
      Reviewed by Maciej Stachowiak. · 63eed842
      ap@webkit.org authored
              Fix fast/events/message-port.html to not be timing-dependent (it was failing on some bots).
      
              * fast/events/message-port.html:
              * fast/events/message-port-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63eed842
    • ap@webkit.org's avatar
      Reviewed by Maciej Stachowiak. · 76544c1b
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21825
              JSDOMBinding should not blindly cast the global object to JSDOMWindow
      
              * bindings/js/JSDOMGlobalObject.cpp:
              * bindings/js/JSDOMGlobalObject.h:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              Added JSDOMGlobalObject, a base class to be used by both Window and worker contexts.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::getCachedDOMStructure):
              (WebCore::cacheDOMStructure):
              (WebCore::getCachedDOMConstructor):
              (WebCore::cacheDOMConstructor):
              Cast to JSDOMGlobalObject, as DOM objects live in DOM global objects.
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::JSDOMWindowBase):
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::mark):
              Moved constructor and structure tracking to JSDOMGlobalObject.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76544c1b
    • abarth@webkit.org's avatar
      WebCore: · 48cade35
      abarth@webkit.org authored
      2008-10-23  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=21787
      
              Update postMessage to send origin = "null" for non-serializable
              origins to match latest spec.  Merge SecurityOrigin::toString and
              SecurityOrigin::toHTTPOrigin because they are now the same.
      
              Test: http/tests/security/postMessage/data-url-sends-null-origin.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::outgoingOrigin):
              (WebCore::FrameLoader::loadURL):
              (WebCore::FrameLoader::addHTTPOriginIfNeeded):
              (WebCore::FrameLoader::loadItem):
              * loader/loader.cpp:
              (WebCore::Loader::Host::servePendingRequests):
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::toString):
              * page/SecurityOrigin.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest):
              (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):
              (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult):
              (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
      
      LayoutTests:
      
      2008-10-23  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=21787
      
              Add test coverage for postMessaging from a data URL.
      
              * http/tests/security/postMessage/data-url-sends-null-origin-expected.txt: Added.
              * http/tests/security/postMessage/data-url-sends-null-origin.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48cade35
  2. 22 Oct, 2008 9 commits
    • oliver@apple.com's avatar
      Really "fix" CTI mode on windows 2k3. · 81903a76
      oliver@apple.com authored
      Reviewed my Maciej Stachowiak
      
      This adds new methods fastMallocExecutable and fastFreeExecutable
      to wrap allocation for cti code.  This still just makes fastMalloc
      return executable memory all the time, which will be fixed in a
      later patch.
      
      However in windows debug builds all executable allocations will be
      allocated on separate executable pages, which should resolve any
      remaining 2k3 issues.  Conveniently the 2k3 bot will now also fail
      if there are any fastFree vs. fastFreeExecutable errors.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81903a76
    • ddkilzer@apple.com's avatar
      Bug 21781: WebCore::Settings should have a maximum decoded image size setting · 5c2a8899
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=21781>
      
              Reviewed by Antti.
      
              No tests since there is no change in behavior.
      
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::maximumDecodedImageSize): Added.  Returns
              WebCore::Settings::maximumDecodedImageSize() or 0 on error.
              (WebCore::CachedImage::data): Flag an error if the image being
              loaded is too big.
              * loader/CachedImage.h:
              (WebCore::CachedImage::maximumDecodedImageSize): Added declaration.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize m_maximumDecodedImageSize
              to the maximum value of size_t.
              * page/Settings.h:
              (WebCore::Settings::setMaximumDecodedImageSize): Added method.
              (WebCore::Settings::maximumDecodedImageSize): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c2a8899
    • cwzwarich@webkit.org's avatar
      2008-10-22 Cameron Zwarich <zwarich@apple.com> · 5b96a794
      cwzwarich@webkit.org authored
              Reviewed by Kevin McCullough.
      
              Check in changed test results for r37792.
      
              * fast/dom/Window/window-properties-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b96a794
    • darin@apple.com's avatar
      2008-10-22 Mike Pinkerton <pinkerton@chromium.org> · 3fb46e47
      darin@apple.com authored
              Reviewed by Dan Bernstein.
              Landed and tweaked a bit by Darin Adler.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=21809
      
              Remove PLATFORM(MAC) wrapping USE(ATSUI). It's redundant and inhibits 
              its use for PLATFORM(CHROMIUM) in the future.
      
              * platform/graphics/SimpleFontData.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb46e47
    • dsmith@webkit.org's avatar
      WebCore: · 102296ef
      dsmith@webkit.org authored
      2008-10-22  David Smith  <catfish.man@gmail.com>
      
              Reviewed by andersca.
                     
              https://bugs.webkit.org/show_bug.cgi?id=19974
              getElementsByClassName not live enough
      
              Test: fast/dom/getElementsByClassName/015.html
      
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::classAttributeChanged): call dispatchSubtreeModifiedEvent()
      
      LayoutTests:
      
      2008-10-22  David Smith  <catfish.man@gmail.com>
      
              Reviewed by andersca.
              
              https://bugs.webkit.org/show_bug.cgi?id=19974
              getElementsByClassName not live enough
      
              * fast/dom/getElementsByClassName/015-expected.txt: Added.
              * fast/dom/getElementsByClassName/015.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      102296ef
    • darin@apple.com's avatar
      JavaScriptCore: · 74e6ed63
      darin@apple.com authored
      2008-10-22  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=21294
                Bug 21294: Devirtualize getOwnPropertySlot()
      
              A bit over 3% faster on V8 tests.
      
              * JavascriptCore.exp: Export leak-related functions..
      
              * API/JSCallbackConstructor.h:
              (JSC::JSCallbackConstructor::createStructureID): Set HasStandardGetOwnPropertySlot
              since this class doesn't override getPropertySlot.
              * API/JSCallbackFunction.h:
              (JSC::JSCallbackFunction::createStructureID): Ditto.
      
              * VM/ExceptionHelpers.cpp:
              (JSC::InterruptedExecutionError::InterruptedExecutionError): Use a structure
              that's created just for this class instead of trying to share a single "null
              prototype" structure.
      
              * VM/Machine.cpp:
              (JSC::Machine::cti_op_create_arguments_no_params): Rename
              Arguments::ArgumentsNoParameters to Arguments::NoParameters.
              
              * kjs/Arguments.h: Rename the enum from Arguments::ArgumentsParameters to
              Arguments::NoParametersType and the value from Arguments::ArgumentsNoParameters
              to Arguments::NoParameters.
              (JSC::Arguments::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
              (JSC::Arguments::Arguments): Added an assertion that there are no parameters.
      
              * kjs/DatePrototype.h:
              (JSC::DatePrototype::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
              * kjs/FunctionPrototype.h:
              (JSC::FunctionPrototype::createStructureID): Set HasStandardGetOwnPropertySlot
              since this class doesn't override getPropertySlot.
              * kjs/InternalFunction.h:
              (JSC::InternalFunction::createStructureID): Ditto.
      
              * kjs/JSArray.h:
              (JSC::JSArray::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
              * kjs/JSCell.h: Added declaration of fastGetOwnPropertySlot; a non-virtual
              version that uses the structure bit to decide whether to call the virtual
              version.
      
              * kjs/JSFunction.h:
              (JSC::JSFunction::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
              * kjs/JSGlobalData.cpp:
              (JSC::JSGlobalData::JSGlobalData): Initialize new structures; removed
              nullProtoStructureID.
              * kjs/JSGlobalData.h: Added new structures. Removed nullProtoStructureID.
      
              * kjs/JSGlobalObject.h:
              (JSC::JSGlobalObject::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
              * kjs/JSNotAnObject.h:
              (JSC::JSNotAnObjectErrorStub::JSNotAnObjectErrorStub): Use a structure
              that's created just for this class instead of trying to share a single "null
              prototype" structure.
              (JSC::JSNotAnObjectErrorStub::isNotAnObjectErrorStub): Marked this function
              virtual for clarity and made it private since no one should call it if they
              already have a pointer to this specific type.
              (JSC::JSNotAnObject::JSNotAnObject): Use a structure that's created just
              for this class instead of trying to share a single "null prototype" structure.
              (JSC::JSNotAnObject::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
              * kjs/JSObject.h:
              (JSC::JSObject::createStructureID): Added HasStandardGetOwnPropertySlot.
              (JSC::JSObject::inlineGetOwnPropertySlot): Added. Used so we can share code
              between getOwnPropertySlot and fastGetOwnPropertySlot.
              (JSC::JSObject::getOwnPropertySlot): Moved so that functions are above the
              functions that call them. Moved the guts of this function into
              inlineGetOwnPropertySlot.
              (JSC::JSCell::fastGetOwnPropertySlot): Added. Checks the
              HasStandardGetOwnPropertySlot bit and if it's set, calls
              inlineGetOwnPropertySlot, otherwise calls getOwnPropertySlot.
              (JSC::JSObject::getPropertySlot): Changed to call fastGetOwnPropertySlot.
              (JSC::JSValue::get): Changed to call fastGetOwnPropertySlot.
      
              * kjs/JSWrapperObject.h: Made constructor protected to emphasize that
              this class is only a base class and never instantiated.
      
              * kjs/MathObject.h:
              (JSC::MathObject::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
              * kjs/NumberConstructor.h:
              (JSC::NumberConstructor::createStructureID): Ditto.
              * kjs/RegExpConstructor.h:
              (JSC::RegExpConstructor::createStructureID): Ditto.
              * kjs/RegExpObject.h:
              (JSC::RegExpObject::createStructureID): Ditto.
              * kjs/StringObject.h:
              (JSC::StringObject::createStructureID): Ditto.
      
              * kjs/TypeInfo.h: Added HasStandardGetOwnPropertySlot flag and
              hasStandardGetOwnPropertySlot accessor function.
      
      JavaScriptGlue:
      
      2008-10-22  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=21294
                Bug 21294: Devirtualize getOwnPropertySlot()
      
              * JSRun.cpp:
              (JSGlueGlobalObject::JSGlueGlobalObject): Moved constructor here.
              Set up flags in its new location in global object data, and set up
              a structure for UserObjectImp too.
              (JSRun::JSRun): Added code to give the JSGlueGlobalObject its own unique
              structure, rather than using the default one from JSGlobalObject.
      
              * JSRun.h: Made JSGlueGlobalObject take a structure ID. Also moved
              the data into a separate data object. And added userObjectStructure,
              a Structure to be used by UserObjectImp.
      
              * JSUtils.cpp: Removed unused sharedGlobalData global.
              (JSObjectKJSValue): Pass Structure in when creating UserObjectImp.
              (unprotectGlobalObject): Use JSGlueGLobalObject type specifically.
              (initializeGlobalObjectKey): Removed code to set up unused sharedGlobalData.
              (getThreadGlobalObject): Added. Shared by JSObjectKJSValue and
              getThreadGlobalExecState. Also now passes in a structure ID when creating
              the global object.
              (getThreadGlobalExecState): Changed to call getThreadGlobalObject.
      
              * UserObjectImp.cpp:
              (UserObjectImp::UserObjectImp): Changed to take a structure.
              * UserObjectImp.h:
              (UserObjectImp::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
      WebCore:
      
      2008-10-22  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=21294
                Bug 21294: Devirtualize getOwnPropertySlot()
      
              * bindings/js/JSDOMWindowShell.h:
              (WebCore::JSDOMWindowShell::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
      
              * bindings/js/JSInspectorCallbackWrapper.cpp:
              (WebCore::JSInspectorCallbackWrapper::wrap): Change to use a unique structure
              for this class rather than sharing nullProtoStructureID, which no longer exists.
      
              * bindings/js/JSNamedNodesCollection.h:
              (WebCore::JSNamedNodesCollection::createStructureID): Added. Returns a structure without
              HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
              * bindings/js/JSRGBColor.h:
              (WebCore::JSRGBColor::createStructureID): Ditto.
      
              * bindings/scripts/CodeGeneratorJS.pm: Added createStructureID functions for the wrappers,
              constructors, and prototypes in any case where they override getOwnPropertySlot, without
              HasStandardGetOwnPropertySlot.
      
              * bridge/objc/objc_runtime.h:
              (JSC::Bindings::ObjcFallbackObjectImp::createStructureID): Added. Returns a structure
              without HasStandardGetOwnPropertySlot since this class overrides getOwnPropertySlot.
              * bridge/qt/qt_runtime.h:
              (JSC::Bindings::QtRuntimeMethod::createStructureID): Ditto.
              * bridge/runtime_array.h:
              (JSC::RuntimeArray::createStructureID): Ditto.
              * bridge/runtime_method.h:
              (JSC::RuntimeMethod::createStructureID): Ditto.
              * bridge/runtime_object.h:
              (JSC::RuntimeObjectImp::createStructureID): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74e6ed63
    • aroben@apple.com's avatar
      Bring Windows Cairo Port's font handling in line with CG. · 21fec10d
      aroben@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=21812.
      
              Reviewed by Adam Roben.
      
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::createGDIFont): Remove unnecessary special-case for Cairo
              TrueType font search. It should match CG in all font selections.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21fec10d
    • aroben@apple.com's avatar
      WebCore: · f4c75616
      aroben@apple.com authored
      2008-10-22  Brent Fulgham  <bfulgham@gmail.com>
      
              Correct build regressions in Cairo port for Windows.
              http://bugs.webkit.org/show_bug.cgi?id=21724
      
              Reviewed by Adam Roben.
      
              * WebCore.vcproj/WebCore.vcproj:  Fixed include paths and post-build event for the Debug_Cairo and Release_Cairo configurations.
              * platform/graphics/win/GraphicsContextCairoWin.cpp:
              (WebCore::GraphicsContext::GraphicsContext): Update to newer constructor signature.
              * platform/network/curl/DNSCurl.cpp: Added.
              (WebCore::prefetchDNS):
              * platform/network/curl/ResourceRequest.h:
              * platform/win/ScrollbarThemeWin.cpp:
              (WebCore::ScrollbarTheme::nativeTheme):
      
      WebKit/win:
      
      2008-10-22  Brent Fulgham  <bfulgham@gmail.com>
      
              Correct build regressions in Cairo port for Windows.
              http://bugs.webkit.org/show_bug.cgi?id=21724
      
              Reviewed by Adam Roben.
      
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Don't try to call
              setShouldPaintNativeControls when SafariTheme support is disabled, as
              that function doesn't exist in that case.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4c75616
    • beidson@apple.com's avatar
      LayoutTests: · 6b85029e
      beidson@apple.com authored
      2008-10-22  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Adam Roben
      
              <rdar://6261773> - autocomplete="off" doesn't work on Windows
      
              Remove a skipped test that can now pass with proper DRT support
              
              * platform/win/Skipped: Remove security/autocomplete-cleared-on-back.html
      
      WebKitTools:
      2008-10-22  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Adam Roben
              
              <rdar://6261773> - autocomplete="off" doesn't work on Windows
      
              Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
              
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              
      WebKit/win:
      2008-10-22  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Adam Roben
              
              Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use
      
              * Interfaces/IWebFramePrivate.idl:
              
              * WebFrame.cpp:
              (WebFrame::elementDoesAutoComplete):
              * WebFrame.h:
              
              * WebHTMLRepresentation.cpp:
              (WebHTMLRepresentation::elementDoesAutoComplete):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b85029e