1. 20 Sep, 2008 21 commits
  2. 19 Sep, 2008 19 commits
    • slewis@apple.com's avatar
      2008-09-19 Stephanie Lewis <slewis@apple.com> · b0cda68e
      slewis@apple.com authored
              Reviewed by Oliver Hunt.
      
              Implement a workaround for an incorrect mime-type on machines with 
              Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
              See radar <rdar://problem/6234318>.     
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (convertMIMEType):
      
              Use correct mime-type for javascript
      
              * svg/webarchive/svg-script-subresouces-expected.webarchive:
              * webarchive/test-duplicate-resources-expected.webarchive:
              * webarchive/test-script-src-expected.webarchive:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0cda68e
    • hyatt@apple.com's avatar
      2008-09-19 David Hyatt <hyatt@apple.com> · 1fe0917a
      hyatt@apple.com authored
              Fix for crash in updateTransitions.  Make sure to test for a style
              being null when comparing two RenderStyles.
      
              Reviewed by Oliver Hunt
      
              * page/animation/AnimationBase.cpp:
              (WebCore::PropertyWrapperGetter::equals):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fe0917a
    • hyatt@apple.com's avatar
      2008-09-19 David Hyatt <hyatt@apple.com> · 02bbc2ca
      hyatt@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=20954
      
              Roll out r36628 since it has caused horrible regressions with
              animated GIF CPU usage.
      
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::cacheFrame):
              (WebCore::BitmapImage::startAnimation):
              * platform/graphics/BitmapImage.h:
              (WebCore::FrameData::FrameData):
              * platform/graphics/cairo/ImageCairo.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/qt/ImageQt.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/wx/ImageWx.cpp:
              (WebCore::FrameData::clear):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02bbc2ca
    • weinig@apple.com's avatar
      2008-09-19 Sam Weinig <sam@webkit.org> · 18b17a64
      weinig@apple.com authored
              Roll r36694 back in.  It did not cause the crash.
      
              * JavaScriptCore.exp:
              * VM/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::invalidate):
              * VM/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::create):
              * kjs/JSObject.cpp:
              (JSC::JSObject::getPropertyNames):
              * kjs/PropertyMap.cpp:
              (JSC::PropertyMap::getEnumerablePropertyNames):
              * kjs/PropertyMap.h:
              * kjs/PropertyNameArray.cpp:
              (JSC::PropertyNameArray::add):
              * kjs/PropertyNameArray.h:
              (JSC::PropertyNameArrayData::create):
              (JSC::PropertyNameArrayData::propertyNameVector):
              (JSC::PropertyNameArrayData::setCachedPrototypeChain):
              (JSC::PropertyNameArrayData::cachedPrototypeChain):
              (JSC::PropertyNameArrayData::begin):
              (JSC::PropertyNameArrayData::end):
              (JSC::PropertyNameArrayData::PropertyNameArrayData):
              (JSC::PropertyNameArray::PropertyNameArray):
              (JSC::PropertyNameArray::addKnownUnique):
              (JSC::PropertyNameArray::size):
              (JSC::PropertyNameArray::operator[]):
              (JSC::PropertyNameArray::begin):
              (JSC::PropertyNameArray::end):
              (JSC::PropertyNameArray::setData):
              (JSC::PropertyNameArray::data):
              (JSC::PropertyNameArray::releaseData):
              * kjs/StructureID.cpp:
              (JSC::structureIDChainsAreEqual):
              (JSC::StructureID::getEnumerablePropertyNames):
              (JSC::StructureID::clearEnumerationCache):
              (JSC::StructureID::createCachedPrototypeChain):
              * kjs/StructureID.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b17a64
    • alp@webkit.org's avatar
      2008-09-20 Alp Toker <alp@nuanti.com> · d1e860e6
      alp@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=20913
              Avoid redudant includes
      
              Document.h is included excessively such that a modification to Document.h (or
              any of the header it includes itself) triggers a rebuild of many files
              including the whole of SVG and a lot of the JS bindings.
      
              Some of these includes can be avoided by only including Document.h where
              necessary.
      
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSElementCustom.cpp:
              * bindings/js/JSEventTargetBase.cpp:
              * bindings/js/JSEventTargetBase.h:
              * bindings/js/JSEventTargetNode.cpp:
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSCursorImageValue.cpp:
              * css/SVGCSSStyleSelector.cpp:
              * dom/make_names.pl:
              * svg/SVGAnimateElement.h:
              * svg/SVGAnimatedProperty.h:
              (WebCore::::baseValue):
              (WebCore::::setBaseValue):
              (WebCore::::startAnimation):
              (WebCore::::stopAnimation):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::accessDocumentSVGExtensions):
              * svg/SVGElement.h:
              * svg/SVGElementInstance.cpp:
              * svg/SVGFitToViewBox.cpp:
              * svg/SVGFontElement.cpp:
              * svg/SVGFontFaceElement.cpp:
              * svg/SVGLinearGradientElement.cpp:
              * svg/SVGMPathElement.cpp:
              * svg/SVGViewSpec.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1e860e6
    • zimmermann@webkit.org's avatar
      Reviewed by Antti & Eric. · 50e33c7a
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372
      
      Finish HTMLScriptElement / SVGScriptElement unification.
      SVG <script> support is complete now, full SVGLoad event
      respecting the influence of the externalResourcesRequired attribute
      as well as SVGError event support. All other features shared with HTML.
      
      Tests: fast/dom/HTMLScriptElement/script-reexecution.html
             svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg
             svg/dom/SVGScriptElement/script-load-and-error-events.svg
             svg/dom/SVGScriptElement/script-reexecution.svg
             svg/dom/SVGScriptElement/script-set-href.svg
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50e33c7a
    • mitz@apple.com's avatar
      Reviewed by John Sullivan. · c7b24eaf
      mitz@apple.com authored
              - fix https://bugs.webkit.org/show_bug.cgi?id=20951
                Typo in Position::getInlineBoxAndOffset()
                and add an assertion
      
              Without the fix, the newly-added assertion fails in platform/mac/editing/input/caret-primary-bidi.html
      
              * dom/Position.cpp:
              (WebCore::Position::getInlineBoxAndOffset):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::positionForOffset):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7b24eaf
    • hyatt@apple.com's avatar
      2008-09-19 David Hyatt <hyatt@apple.com> · d48dbf39
      hyatt@apple.com authored
              Add support for hit testing of all five possible scrollbar button placements. 
      
              Reviewed by Sam Weinig
      
              * platform/ScrollbarThemeComposite.cpp:
              (WebCore::ScrollbarThemeComposite::paint):
              * platform/mac/ScrollbarThemeMac.mm:
              (WebCore::):
              (WebCore::ScrollbarThemeMac::backButtonRect):
              (WebCore::ScrollbarThemeMac::forwardButtonRect):
              (WebCore::ScrollbarThemeMac::trackRect):
              (WebCore::ScrollbarThemeMac::paintButton):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d48dbf39
    • weinig@apple.com's avatar
      2008-09-19 Sam Weinig <sam@webkit.org> · da05197a
      weinig@apple.com authored
              Roll out r36694.
      
              * JavaScriptCore.exp:
              * VM/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::invalidate):
              * VM/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::create):
              * kjs/JSObject.cpp:
              (JSC::JSObject::getPropertyNames):
              * kjs/PropertyMap.cpp:
              (JSC::PropertyMap::getEnumerablePropertyNames):
              * kjs/PropertyMap.h:
              * kjs/PropertyNameArray.cpp:
              (JSC::PropertyNameArray::add):
              * kjs/PropertyNameArray.h:
              (JSC::PropertyNameArray::PropertyNameArray):
              (JSC::PropertyNameArray::addKnownUnique):
              (JSC::PropertyNameArray::begin):
              (JSC::PropertyNameArray::end):
              (JSC::PropertyNameArray::size):
              (JSC::PropertyNameArray::operator[]):
              (JSC::PropertyNameArray::releaseIdentifiers):
              * kjs/StructureID.cpp:
              (JSC::StructureID::getEnumerablePropertyNames):
              * kjs/StructureID.h:
              (JSC::StructureID::clearEnumerationCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da05197a
    • oliver@apple.com's avatar
      Improve peformance of local variable initialisation. · ecfd2241
      oliver@apple.com authored
      Reviewed by Maciej Stachowiak
      
      Pull local and constant initialisation out of slideRegisterWindowForCall
      and into its own opcode.  This allows the JIT to generate the initialisation
      code for a function directly into the instruction stream and so avoids a few
      branches on function entry.
      
      Results a 1% progression in SunSpider, particularly in a number of the bitop
      tests where the called functions are very fast.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecfd2241
    • weinig@apple.com's avatar
      2008-09-19 Sam Weinig <sam@webkit.org> · ba6fae8a
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Patch for https://bugs.webkit.org/show_bug.cgi?id=20928
              Speed up JS property enumeration by caching entire PropertyNameArray
      
              1.3% speedup on Sunspider, 30% on string-fasta.
      
              * JavaScriptCore.exp:
              * VM/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::invalidate):
              * VM/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::create):
              * kjs/JSObject.cpp:
              (JSC::JSObject::getPropertyNames):
              * kjs/PropertyMap.cpp:
              (JSC::PropertyMap::getEnumerablePropertyNames):
              * kjs/PropertyMap.h:
              * kjs/PropertyNameArray.cpp:
              (JSC::PropertyNameArray::add):
              * kjs/PropertyNameArray.h:
              (JSC::PropertyNameArrayData::create):
              (JSC::PropertyNameArrayData::propertyNameVector):
              (JSC::PropertyNameArrayData::setCachedPrototypeChain):
              (JSC::PropertyNameArrayData::cachedPrototypeChain):
              (JSC::PropertyNameArrayData::begin):
              (JSC::PropertyNameArrayData::end):
              (JSC::PropertyNameArrayData::PropertyNameArrayData):
              (JSC::PropertyNameArray::PropertyNameArray):
              (JSC::PropertyNameArray::addKnownUnique):
              (JSC::PropertyNameArray::size):
              (JSC::PropertyNameArray::operator[]):
              (JSC::PropertyNameArray::begin):
              (JSC::PropertyNameArray::end):
              (JSC::PropertyNameArray::setData):
              (JSC::PropertyNameArray::data):
              (JSC::PropertyNameArray::releaseData):
              * kjs/ScopeChain.cpp:
              (JSC::ScopeChainNode::print):
              * kjs/StructureID.cpp:
              (JSC::structureIDChainsAreEqual):
              (JSC::StructureID::getEnumerablePropertyNames):
              (JSC::StructureID::clearEnumerationCache):
              (JSC::StructureID::createCachedPrototypeChain):
              * kjs/StructureID.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba6fae8a
    • zecke@webkit.org's avatar
      7d899efd
    • alice.liu@apple.com's avatar
      2008-09-19 Alice Liu <alice.liu@apple.com> · 919e1e06
      alice.liu@apple.com authored
              Fix crash when submitting form at bugreport.apple.com rdar://6234126
      
              Reviewed by Mark Rowe.
      
              * COMPropertyBag.h:
              (::GetPropertyInfo):
              correct mis-use of comma operator
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      919e1e06
    • hyatt@apple.com's avatar
      Fix build bustage on Win. · a8cc8420
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8cc8420
    • darin@apple.com's avatar
      2008-09-19 Darin Adler <darin@apple.com> · 1c4cd8fe
      darin@apple.com authored
              - try to fix Qt build
      
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtRuntimeObjectImp::QtRuntimeObjectImp): Add structure argument.
              (JSC::Bindings::QtInstance::getRuntimeObject): Ditto.
              * bridge/runtime_object.cpp:
              (JSC::RuntimeObjectImp::RuntimeObjectImp): Add an overload just for Qt.
              * bridge/runtime_object.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c4cd8fe
    • hyatt@apple.com's avatar
      Fix build bustage. · 6ad657c4
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad657c4
    • hyatt@apple.com's avatar
      Fix build bustage. · 5dfa1a76
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dfa1a76
    • dino@apple.com's avatar
      2008-09-19 Chris Marrin <cmarrin@apple.com> · 7c236597
      dino@apple.com authored
              Reviewed by Dave Hyatt.
      
              Transition starts running when it shouldn't
              https://bugs.webkit.org/show_bug.cgi?id=20892
      
              When there is a transition and an animation on the
              same element, make sure the animation wins.
      
              The fix is to save the unanimated style when an animation is started.
              Then, when starting a transition, check to see if there is a current
              animation on the same prop. If so, use the unanimated style as the
              fromStyle rather than the current style.
      
              Test: animations/transition-and-animation-1.html
      
              * page/animation/CompositeAnimation.cpp:
              (WebCore::CompositeAnimation::updateTransitions):
              (WebCore::CompositeAnimation::updateKeyframeAnimations):
              (WebCore::CompositeAnimation::animate):
              (WebCore::CompositeAnimation::getAnimationForProperty):
              * page/animation/CompositeAnimation.h:
              * page/animation/ImplicitAnimation.cpp:
              (WebCore::ImplicitAnimation::reset):
              * page/animation/ImplicitAnimation.h:
              * page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::hasAnimationForProperty):
              * page/animation/KeyframeAnimation.h:
              (WebCore::KeyframeAnimation::KeyframeAnimation):
              (WebCore::KeyframeAnimation::unanimatedStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c236597
    • hyatt@apple.com's avatar
      2008-09-19 David Hyatt <hyatt@apple.com> · ea254e28
      hyatt@apple.com authored
              Add support for painting/hit testing of four possible scrollbar buttons.
              The Windows themes simply ignore the two parts that they will never
              show.  The Mac theme also ignores the other two buttons for now.
      
              The cross-platform base for all three themes, ScrollbarThemeComposite,
              has all the proper support though.
      
              Reviewed by Sam Weinig
      
              * platform/ScrollbarThemeComposite.cpp:
              (WebCore::ScrollbarThemeComposite::hitTest):
              (WebCore::ScrollbarThemeComposite::invalidatePart):
              * platform/ScrollbarThemeComposite.h:
              * platform/mac/ScrollbarThemeMac.h:
              * platform/mac/ScrollbarThemeMac.mm:
              (WebCore::ScrollbarThemeMac::backButtonRect):
              (WebCore::ScrollbarThemeMac::forwardButtonRect):
              (WebCore::ScrollbarThemeMac::paintButton):
              * platform/win/ScrollbarThemeSafari.cpp:
              (WebCore::ScrollbarThemeSafari::backButtonRect):
              (WebCore::ScrollbarThemeSafari::forwardButtonRect):
              (WebCore::ScrollbarThemeSafari::paintButton):
              * platform/win/ScrollbarThemeSafari.h:
              * platform/win/ScrollbarThemeWin.cpp:
              (WebCore::ScrollbarThemeWin::backButtonRect):
              (WebCore::ScrollbarThemeWin::forwardButtonRect):
              (WebCore::ScrollbarThemeWin::paintButton):
              * platform/win/ScrollbarThemeWin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@36686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea254e28