1. 19 Apr, 2007 2 commits
    • beidson's avatar
      LayoutTests: · a5e83332
      beidson authored
              Reviewed by Tim
      
              <rdar://problem/5008925>
              Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate
      
              * http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.
              * http/tests/misc/willCacheResponse-delegate-callback.html: Added.
      
      WebCore:
      
              Reviewed by Tim
      
              <rdar://problem/5008925>
              Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate
      
              * WebCore.xcodeproj/project.pbxproj: Added ResourceLoaderMac.mm
      
              * loader/FrameLoaderClient.h: Add the willCacheResponse SPI for WebKit to implement
      
              * loader/ResourceLoader.h:
              * loader/mac/ResourceLoaderMac.mm: Added.
              (WebCore::ResourceLoader::willCacheResponse): Return the new cachedResponse from the client
      
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::willCacheResponse): Stub
      
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::willCacheResponse):  Return the new cachedResponse from the client
      
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Call to get the new 
                cachedURLResponse before calling for the cache policy
      
      WebKit:
      
              Reviewed by Tim
      
              <rdar://problem/5008925>
              Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::willCacheResponse): Call 
                [WebResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:];
      
              * WebView/WebView.mm:
              (-[WebView _cacheResourceLoadDelegateImplementations]): Pull out the willCacheResponse impl
      
              * WebView/WebViewPrivate.h: Add WebResourceLoadDelegatePrivate category for this new SPI
      
      WebKitTools:
      
              Reviewed by Tim
      
              <rdar://problem/5008925>
              Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate
      
              * DumpRenderTree/ResourceLoadDelegate.m:
              (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]): 
                Add the willCacheResponse delegate call
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5e83332
    • darin's avatar
      Reviewed by Hyatt. · 52c80798
      darin authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=13375
                REGRESSION (r20901): failing fast/overflow/scrollRevealButton.html
      
              * dom/Document.cpp: (WebCore::Document::updateLayout):
              If we have a parent frame, update its layout too.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52c80798
  2. 18 Apr, 2007 11 commits
    • aroben's avatar
      Reviewed by David Kilzer. · 11d7979e
      aroben authored
              * Scripts/webkitdirs.pm:
              (sub setConfiguration): Added an optional argument to set the
              configuration instead of parsing it from ARGV.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11d7979e
    • sullivan's avatar
      Reviewed by Adam · c3973348
      sullivan authored
              - fixed <rdar://problem/5103009> REGRESSION: Activity window shows blank name for untitled pages
      
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation title]):
              return nil for empty string, to match old behavior
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3973348
    • kmccullo's avatar
      Reviewed by AP. · 272aab37
      kmccullo authored
              - Consolidated encoding tests.
      
              * fast/encoding/char-decoding-expected.txt:
              * fast/encoding/char-decoding.html:
              * fast/encoding/charset-x-nextstep-expected.txt: Removed.
              * fast/encoding/charset-x-nextstep.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      272aab37
    • bdash's avatar
      2007-04-18 Alp Toker <alp@atoker.com> · bfdc50b6
      bdash authored
              Gdk build fix.  Reviewed by Mark.
      
              * loader/gdk/FrameLoaderClientGdk.cpp:
              (WebCore::FrameLoaderClientGdk::loadedFromCachedPage):
              (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage):
              (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
              * loader/gdk/FrameLoaderClientGdk.h:
              * platform/gdk/TemporaryLinkStubs.cpp:
              (CachedPage::close): Track PageCache to CachedPage refactoring.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdc50b6
    • bdash's avatar
      2007-04-17 Mitz Pettel <mitz@webkit.org> · a10ca77a
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13369
                REGRESSION (r13366): Invisible table cell background is painted
      
              Test: fast/table/invisible-cell-background.html
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any
              background if the cell is not visible. This behavior matches WinIE and Opera.
      
      2007-04-17  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13369
                REGRESSION (r13366): Invisible table cell background is painted
      
              * fast/table/invisible-cell-background-expected.checksum: Added.
              * fast/table/invisible-cell-background-expected.png: Added.
              * fast/table/invisible-cell-background-expected.txt: Added.
              * fast/table/invisible-cell-background.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a10ca77a
    • justing's avatar
      d0d95afb
    • aroben's avatar
      * Scripts/find-included-framework-headers: Search Obj-C and Obj-C++ · 6e8e42c7
      aroben authored
              files as well.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e8e42c7
    • aroben's avatar
      Added a simple shell script to find all the headers from a specified · 0a96fe5f
      aroben authored
              framework or frameworks that are included by files beneath the working
              directory.
      
              * Scripts/find-included-framework-headers: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a96fe5f
    • justing's avatar
      WebCore: · 41433c9e
      justing authored
              Reviewed by adam
      
              Removed workarounds for compiler bug 4213314.
      
              * platform/mac/CursorMac.mm:
              (WebCore::leakNamedCursor):
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::resizeContents):
              (WebCore::ScrollView::contentsToWindow):
              (WebCore::ScrollView::windowToContents):
      
      WebKit:
      
              Reviewed by adam
              
              Removed workarounds for compiler bug 4213314.
      
              * Misc/WebNSAttributedStringExtras.mm:
              (+[NSAttributedString _web_attributedStringFromRange:]):
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41433c9e
    • justing's avatar
      LayoutTests: · 67027a94
      justing authored
              Reviewed by harrison
      
              <rdar://problem/5119244> 
              Crash when indenting a selected ToDo
              
              * editing/execCommand/5119244-expected.checksum: Added.
              * editing/execCommand/5119244-expected.png: Added.
              * editing/execCommand/5119244-expected.txt: Added.
              * editing/execCommand/5119244.html: Added.
      
      WebCore:
      
              Reviewed by harrison
      
              <rdar://problem/5119244> 
              Crash when indenting a selected ToDo
              
              indentRegion() was using the old (incorrect) editable root 
              getter, which returned null for a valid, editable position, 
              causing the crash.
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion):
              The editable root for a position is editableRootForPosition(p),
              not p.node()->rootEditableElement(), because of VisiblePositions 
              before/after tables, replaced elements and others.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67027a94
    • justing's avatar
      LayoutTests: · 889c96c8
      justing authored
              Reviewed by hyatt
              
              <rdar://problem/5138441> 
              GoogleDocs: Indented text looks like text that's been Quoted
      
              Demonstrates the bug:
              * editing/execCommand/5138441-expected.checksum: Added.
              * editing/execCommand/5138441-expected.png: Added.
              * editing/execCommand/5138441-expected.txt: Added.
              * editing/execCommand/5138441.html: Added.
              
              Added inline style declarations for indent blockquotes
              to match those that the engine creates:
              * editing/execCommand/indent-selection.html:
              * editing/execCommand/outdent-selection.html:
      
      WebCore:
      
              Reviewed by hyatt
      
              <rdar://problem/5138441> 
              GoogleDocs: Indented text looks like text that's been Quoted
              
              GoogleDocs uses FormatBlock, blockquotes and a style rule
              for blockquotes to implement a "Quote Text" feature.  Styles
              intended only for those blockquotes were added to the 
              blockquotes that we use for indenting.
      
              * css/html4.css: Removed the webkit-indent-blockquote class rule.
              * editing/IndentOutdentCommand.cpp:
              (WebCore::createIndentBlockquoteElement): Use custom margins
              and turn off border and padding to override author rules for
              blockquotes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      889c96c8
  3. 17 Apr, 2007 8 commits
    • sullivan's avatar
      Reviewed by Tim Hatcher · 597cb568
      sullivan authored
              - fixed <rdar://problem/5138492> Safari doesn't remember some changes to the PDF scale and display mode 
      
              Some of the user interactions that could change the PDF scale and display mode were not going through
              the proxy mechanism in WebPDFView that updates preferences. Now we also listen to PDFKit notifications
              in order to catch the other cases.
      
              * WebView/WebPDFView.h:
              new _ignoreScaleAndDisplayModeNotifications and _updatePreferencesTimer ivars
      
              * WebView/WebPDFView.mm:
              (-[WebPDFView setPDFDocument:]):
              ignore scale and display mode notifications while we're setting up a fresh document
              (-[WebPDFView dealloc]):
              cancel the new timer (which releases it)
              (-[WebPDFView viewDidMoveToWindow]):
              listen for two PDFKit notifications
              (-[WebPDFView viewWillMoveToWindow:]):
              stop listening to the two PDFKit notifications
              (-[WebPDFView _applyPDFDefaults]):
              white space change
              (-[WebPDFView _cancelUpdatePreferencesTimer]):
              invalidate, release, and nil out the timer
              (-[WebPDFView _scaleOrDisplayModeChanged:]):
              update preferences soon, unless deliberately ignoring these notifications
              (-[WebPDFView _updatePreferencesNow]):
              cancel timer, then save data to preferences (code for saving the data was extracted from
              -[PDFPrefUpdatingProxy forwardInvocation:])
              (-[WebPDFView _updatePreferencesSoon]):
              use timer to consolidate multiple calls into one action; formerly we were setting preferences
              multiple times for some atomic user actions
              (-[PDFPrefUpdatingProxy forwardInvocation:]):
              call _updatePreferencesSoon where we used to immediately set preferences
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      597cb568
    • justing's avatar
      LayoutTests: · e7a1a8fc
      justing authored
              Reviewed by darin
              
              <rdar://problem/5136770> 
              Gmail Editor: Hang when turning a particular multi-line selection into a list
      
              Demonstrates the bug:
              * editing/execCommand/5136770-expected.checksum: Added.
              * editing/execCommand/5136770-expected.png: Added.
              * editing/execCommand/5136770-expected.txt: Added.
              * editing/execCommand/5136770.html: Added.
              
              Added placeholders in empty list items:
              * editing/execCommand/4747450-expected.txt:
              * editing/execCommand/insert-list-empty-div-expected.txt:
              * editing/execCommand/4917055-expected.txt:
              
              A horizontal rule pushed into a list item appears *before*
              the list marker in the render tree, although, the new results 
              look more correct (13376):
              * editing/execCommand/create-list-with-hr-expected.checksum:
              * editing/execCommand/create-list-with-hr-expected.png:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/create-list-with-hr.html:
      
      WebCore:
      
              Reviewed by darin
      
              <rdar://problem/5136770> 
              Gmail Editor: Hang when turning a particular multi-line selection into a list
              
              When InsertListCommand pushes content into list items, 
              it creates an empty list item and then calls moveParagraphs.  
              But moveParagraphs' selection preservation code fails when 
              it encounters empty list items (list items w/o placeholders).
              This causes InsertListCommand to lose track of where it has 
              already been performed, which causes the hang.
      
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply): Use brs to hold open 
              empty list items.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7a1a8fc
    • darin's avatar
      Oops, rolled that last change out. I'll redo it again later after making · 5a1e60e0
      darin authored
              som additional refinments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a1e60e0
    • sullivan's avatar
      Reviewed by Kevin Decker · 7df91513
      sullivan authored
              - fixed <rdar://problem/4184640> "Look Up in Dictionary" item is always disabled for PDF pages
      
              * WebView/WebPDFView.mm:
              (-[WebPDFView validateUserInterfaceItem:]):
              enable "Look Up in Dictionary" only if we're using a version of PDFKit that knows how to do so
              (-[WebPDFView _canLookUpInDictionary]):
              use respondsToSelector to test whether the current version of PDFKit supports this non-API feature
              (-[WebPDFView _lookUpInDictionaryFromMenu:]):
              implement this method, which WebKit includes in the context menu when there's selected text
              (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
              updated comment for this change
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7df91513
    • darin's avatar
      Reviewed by Brady. · a3a3cbd4
      darin authored
              - a few baby steps to try to make lockHistory and userGesture less confusing
      
              * page/FrameLoadRequest.h:
              (WebCore::FrameLoadRequest::FrameLoadRequest): Add initialization of m_isUserGesture
              to true.
              (WebCore::FrameLoadRequest::shouldLockHistory): Renamed from lockHistory to avoid having
              a getter that sounds like a verb phrase.
              (WebCore::FrameLoadRequest::setShouldLockHistory): Ditto.
              (WebCore::FrameLoadRequest::isUserGesture): Added.
              (WebCore::FrameLoadRequest::setIsUserGesture): Ditto.
      
              * loader/FrameLoader.h: Remove userGesture parameter from load that takes
              FrameLoadRequest. Remove default values for lockHistory and userGesture parameters,
              since that just makes it more likely we'll forget to pass them in. Remove one of
              the overloads of urlSelected, since it's only called one place.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::createWindow): Remove userGesture parameter, relying on
              the true default in FrameLoadRequest.
              (WebCore::FrameLoader::urlSelected): Call setShouldLockHistory and setIsUserGesture
              on the FrameLoadRequest, and call load directly; also eliminate the other urlSelected
              overload since this was the only place it was called.
              (WebCore::FrameLoader::load): Remove userGesture parameter, relying on the true
              default in FrameLoadRequest. In the other overload, clean up logic to eliminate the
              argsReferrer variable and get rid of the userGesture parameter, using the value from
              FrameLoadRequest.
              (WebCore::FrameLoader::submitForm): Remove userGesture parameter, relying on the value
              in the FrameLoadRequest. This actually changes behavior.
      
              * bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Pass
              false for userGesture explicitly instead of relying on default argument.
      
              * page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
              Remove userGesture parameter, relying on the true default in FrameLoadRequest.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3a3cbd4
    • thatcher's avatar
      More elegant fix for the 64-bit build failure. · f96fcbdf
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f96fcbdf
    • ddkilzer's avatar
      WebCore: · 4faee3e9
      ddkilzer authored
              Reviewed by NOBODY (fixed misspelling).
      
              * manual-tests/containing-block-position-chage.html: Removed.
              * manual-tests/containing-block-position-change.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4faee3e9
    • thatcher's avatar
      64-bit build fix. · 2a919adf
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a919adf
  4. 16 Apr, 2007 6 commits
    • justing's avatar
      LayoutTests: · ce2db776
      justing authored
              Reviewed by darin
              
              <rdar://problem/5134759> 
              GMail Editor: Hang after pasting underlined text multiple times
      
              Demonstrates the bug:
              * editing/pasteboard/5134759-expected.checksum: Added.
              * editing/pasteboard/5134759-expected.png: Added.
              * editing/pasteboard/5134759-expected.txt: Added.
              * editing/pasteboard/5134759.html: Added.
              
              A unnecessary extra space was added to an element's 
              inline style declaration, because of the way cssText behaves:
              * editing/pasteboard/paste-table-002-expected.txt:
      
      WebCore:
      
              Reviewed by darin
      
              <rdar://problem/5134759> 
              GMail Editor: Hang after pasting underlined text multiple times
              
              The moveParagraphs call that ReplaceSelectionCommand
              performs must receive only inline content from createMarkup, 
              or else it will result in another call to moveParagraphs 
              when it performs the move, resulting in infinite recursion.
      
              * editing/markup.cpp:
              (WebCore::startMarkup): We were only converting a block to
              an inline if it had an inline style declaration or styles 
              coming from matched rules.  Cleaned up this code a bit by 
              handling an element's style separately from its other 
              attributes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce2db776
    • thatcher's avatar
      * Drosera/debugger.css: hide the borders for iframes · 3e7a39b2
      thatcher authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7a39b2
    • darin's avatar
      Rubber stamped by Tim Hatcher. · 84e1fdf6
      darin authored
              * WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message
              for the "version number ending in 4" check so folks from Apple can find the
              original bug that motivated for this. To summarize what's in that bug, it says that
              <http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu,
              and that some other affected sites were not using OpenCube (so the error is presumably
              more widespread).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84e1fdf6
    • darin's avatar
      - get layout tests going again · 2a5e5d32
      darin authored
              * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):
              Replace assertion with a runtime check. We can consider changing it back to
              an assertion some day, but it's not important.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a5e5d32
    • darin's avatar
      WebCore: · 28399bcb
      darin authored
              Reviewed by John Sullivan.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13303
                <rdar://problem/5126341> REGRESSION: controls in a background Safari window
                maintain active appearance if the address bar has focus (13303)
      
              - fix a related problem where elements could look focused in non-active windows
      
              - simplify secure keyboard entry logic in Frame::setIsActive
      
              * WebCore.exp: Add two new symbols for use by WebKit.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive
              rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active.
              (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.
      
              * page/Frame.cpp:
              (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls
              setUseSecureKeyboardEntry only if the frame is active, but also stores away the state,
              so that the setIsActive function doesn't have to recompute it.
              (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code
              to manage control tints, which are not based on the whether the frame is active but rather
              on AppKit's concept of whether the window should have "key appearance". Simplified the
              logic about when to call setUseSecureKeyboardEntry by using the value of
              m_useSecureKeyboardEntryWhenActive.
              (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
              * page/Frame.h: Made setSecureKeyboardEntry private and renamed it to
              setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and
              added a public setUseSecureKeyboardEntryWhenActive.
              * page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
              * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion,
              and removed isSecureKeyboardEntry().
      
              * page/FrameView.h: Added updateControlTints.
              * page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved
              here from setIsActive for two reasons: (1) it makes more sense in the view class, and
              (2) it needs to be called at the appropriate time for AppKit, not when active changes.
      
              * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive
              check here to match the logic in the implementation of the CSS pseudo-state.
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of
              repeating the logic here. Removed the "need to add a key window test here" comment.
              (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell
              SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.
      
      WebKit:
      
              Reviewed by John Sullivan.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13303
                <rdar://problem/5126341> REGRESSION: controls in a background Safari window
                maintain active appearance if the address bar has focus (13303)
      
              * WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]):
              Added. Calls FrameView::updateControlTints.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28399bcb
    • darin's avatar
      Reviewed by John Sullivan. · 68de92f7
      darin authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=13227
                StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0)
      
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::isLower): Based on test application results, changed to use &&
              instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters
              outside the BMP. Improved comments.
              (WebCore::StringImpl::lower): Improved comments.
              (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid
              branches. Improved comments. Added an assertion about the assumption we're
              making that characters in the char* are all ASCII.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68de92f7
  5. 14 Apr, 2007 3 commits
    • kevino's avatar
      Adding wx sources and changes to wxWebKit branch. · 451c0992
      kevino authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      451c0992
    • ddkilzer's avatar
      LayoutTests: · 95d2be07
      ddkilzer authored
              Patch and review by hyatt.  Testing and landing by ddkilzer.
      
              <rdar://problem/5078866>
              tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)
      
              Test tables/mozilla_expected_failures/bugs/bug11384s.html progressed after this fix, so
              it was moved to tables/mozilla/bugs/bug11384s.html.
      
              * fast/css/table-text-align-quirk-expected.checksum: Added.
              * fast/css/table-text-align-quirk-expected.png: Added.
              * fast/css/table-text-align-quirk-expected.txt: Added.
              * fast/css/table-text-align-quirk.html: Added.
              * fast/css/table-text-align-strict-expected.checksum: Added.
              * fast/css/table-text-align-strict-expected.png: Added.
              * fast/css/table-text-align-strict-expected.txt: Added.
              * fast/css/table-text-align-strict.html: Added.
              * fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center"
              style with "text-align: center" style.
              * tables/mozilla/bugs/bug11384s-expected.checksum: Added.
              * tables/mozilla/bugs/bug11384s-expected.png: Added.
              * tables/mozilla/bugs/bug11384s-expected.txt: Added.
              * tables/mozilla/bugs/bug11384s.html: Added.
              * tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
              * tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
              * tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
              * tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.
      
      WebCore:
      
              Patch and review by hyatt.  Testing and landing by ddkilzer.
      
              <rdar://problem/5078866>
              tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)
      
              Test: fast/css/table-text-align-quirk.html
                    fast/css/table-text-align-strict.html
      
              Previous commit (r20731) removed the wrong property from WebCore/css/html4.css.  However,
              when the correct property was removed, it caused tables to inherit alignment properties
              from tags like <center> and <div align="center">.  This is fixed in
              WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
              text-align property.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to
              WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue): Ditto.
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center,
              -webkit-left or -webkit-right values for text-align, so reset them back to auto.
              * css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector.  It
              was previously added to css/quirks.css in r20731.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcHorizontalMargins): Ditto.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::caretRect): Ditto.
              * rendering/RenderStyle.h: Ditto.
              (WebCore::):
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d2be07
    • oliver's avatar
      2007-04-13 Oliver Hunt <oliver@apple.com> · 7c50d652
      oliver authored
              Reviewed by Adam.
      
              Due to rdar://problem/5133910 -- WebArchives should not be constructed 
              using resource from the cache -- We may try to create a potentially 
              incorrect WebArchive when dragging an image multiple times.
      
              This patch retains the assertion for invalid behaviour, but adds a
              branch to make sure we don't try to do anything with the WebArchive
              in release builds.
      
              * Misc/WebNSPasteboardExtras.mm:
              (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c50d652
  6. 13 Apr, 2007 10 commits
    • beidson's avatar
      Reviewed by a sanity check · f859d745
      beidson authored
              My layout test *has* to be http, since dumping history in DRT with hard coded file paths
              will never match up to expected results across machines.
      
              Lame
      
              * history/new-window-redirect-history-expected.txt: Removed.
              * history/new-window-redirect-history.html: Removed.
              * history/resources/redirect-1.html: Removed.
              * history/resources/redirect-2.html: Removed.
              * http/tests/navigation/new-window-redirect-history-expected.txt: Added.
              * http/tests/navigation/new-window-redirect-history.html: Added.
              * http/tests/navigation/resources/redirect-1.html: Added.
              * http/tests/navigation/resources/redirect-2.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f859d745
    • aroben's avatar
      Rubberstamped by Anders. · 0d136e56
      aroben authored
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include
              stdio.h so that snprintf is defined.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d136e56
    • beidson's avatar
      LayoutTests: · ab0e7dcb
      beidson authored
              Reviewed by Geoose
      
              <rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546
      
              Layout test that covers opening an empty new window, then starting to navigate around in it
      
              * history/new-window-redirect-history-expected.txt: Added.
              * history/new-window-redirect-history.html: Added.
              * history/resources/redirect-1.html: Added.
              * history/resources/redirect-2.html: Added.
      
      WebCore:
      
              Reviewed by Black Sheep
      
              <rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546
      
              When you click on a link that opens in a new window from within gmail, they first create a new window 
              with an empty URL, then immediately document.write() into the window to schedule a redirect.
      
              Since the initial page doesn't have a URL associated with it, a history item never gets created.  The 
              reasonable solution?  To actually create the history item after the redirect (in updateHistoryForInternalLoad)
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item
              (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation
              (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already
                a current history item
              * loader/FrameLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab0e7dcb
    • beidson's avatar
      Reviewed by Anders · bf0af0be
      beidson authored
              Add the ability to dump the back/forward history of all windows open at the end of a test
      
              * DumpRenderTree/DumpRenderTree.m:
              (dumpBackForwardListForWebView): Dump B/F list for the given WebView
              (dump): Call dumpBackForwardListForWebView for each WebView open after the test
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf0af0be
    • andersca's avatar
      LayoutTests: · a9fd077f
      andersca authored
              Reviewed by Brady.
      
              * plugins/open-and-close-window-with-plugin.html:
              Manage open windows manually for this test.
      
      WebKitTools:
      
              Reviewed by Brady.
      
              By default, close any windows that have been opened during a test. This can be overridden by
              calling setCloseRemainingWindowsWhenComplete(false).
              
              Change the windows set to an array so we can gurantee the enumeration order.
              
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
              (runTest):
              (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
              (-[DumpRenderTreeWindow dealloc]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9fd077f
    • thatcher's avatar
      Reviewed by Dave Harrison. · 7f5bb514
      thatcher authored
              <rdar://problem/5132727> Soho Mail build fails because of renamed SPI
      
              * WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f5bb514
    • ggaren's avatar
      Build fix. · 58bc7bed
      ggaren authored
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (handleCallback): Explicitly cast the void* returned by malloc.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58bc7bed
    • bdash's avatar
      2007-04-13 Mark Rowe <mrowe@apple.com> · 274bb0e3
      bdash authored
              Reviewed by Oliver.
      
              <rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path
      
              * WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      274bb0e3
    • oliver's avatar
      2007-04-12 Oliver Hunt <oliver@apple.com> · e4dd6af8
      oliver authored
              Reviewed by Adam.
      
              This fixes <rdar://problem/5060766> -- Frameset with 
              an empty frame crashes due to null document.  Debug
              builds hit the frame->document() assertion in 
              EventHandler::prepareMouseEvent
      
              This null check seems necessary now, having run through 
              all the logic on the path to this crash it appears that
              we can't avoid this null check.  
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::updateDragAndDrop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4dd6af8
    • ggaren's avatar
      JavaScriptCore: · 6f017c14
      ggaren authored
              Reviewed by Darin Adler.
      
              http://bugs.webkit.org/show_bug.cgi?id=13029
              rdar://problem/4994849
              Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
              This doesn't actually change JavaScriptCore, but that's where npapi.h is.
      
              * bindings/npapi.h:
              Add headers member to NPStream struct.  Also increase NP_VERSION_MINOR to 18.
              Increasing to >= 17 allows plug-ins to safely detect whether to look for
              NPStream::headers.  Increasing from 17 to 18 reflects presence of NPObject
              enumeration, which was added in a prior patch, and which has been agreed to
              constitute version 18 by the plugin-futures list.  Also add other missing
              bits of npapi.h to catch up from 14 to 18.  This includes features that are
              not implemented in WebKit, but those are safely stubbed.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              http://bugs.webkit.org/show_bug.cgi?id=13029
              rdar://problem/4994849
              Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
      
              * http/tests/plugins/npapi-response-headers-expected.txt: Added.
              * http/tests/plugins/npapi-response-headers.html: Added.
              * http/tests/plugins/resources/load-me-1.txt: Added.
              * http/tests/plugins/resources/load-me-2.txt: Added.
      
      WebKit:
      
              Reviewed by Darin Adler.
      
              http://bugs.webkit.org/show_bug.cgi?id=13029
              rdar://problem/4994849
              Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
      
              * Plugins/WebBaseNetscapePluginStream.h: declarations.
              * Plugins/WebBaseNetscapePluginStream.mm: main implementation.
              (-[WebBaseNetscapePluginStream dealloc]): cleanup.
              (-[WebBaseNetscapePluginStream finalize]): cleanup.
              (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
              Pass headers along.
              (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
              Main work is here.  Extract headers from NSHTTPURLResponse object into a byte sequence.
              See comments here about how it would be nice to have low-level access to the HTTP response.
              (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              Conform to new startStream params.  Not applicable here, pass nil.
      
      WebKitTools:
      
              Reviewed by Darin Adler.
      
              http://bugs.webkit.org/show_bug.cgi?id=13029
              rdar://problem/4994849
              Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
              Changes in WebKitTools are only for the NPAPI test plugin.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic.
              (pluginInvoke): support null window argument for NPStream creation.
              (pluginAllocate): initialization.
              (pluginDeallocate): cleanup.
              (handleCallback): add second JS callback arg: header dump.
              (notifyStream): added; hook from NPP_NewStream to record headers.
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook.
              (NPP_NewStream): call new header hook.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f017c14