1. 05 Aug, 2013 2 commits
    • zandobersek@gmail.com's avatar
      [Automake] Define ENABLE_JIT through the Autoconf header · a56af6cd
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119445
      
      Reviewed by Martin Robinson.
      
      .: 
      
      Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
      set to be either enabled or disabled through the Autoconf header, based on the value
      passed through the configuration flag. The 'auto' value is used as default, meaning
      that the feature is enabled or disabled in the Platform.h header based on the platform
      configuration (OS, architecture etc.).
      
      * Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
      * Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead
      of 'autodetect', as used by other configuration options that take a similar approach to enabling
      a specific feature.
      * Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through
      the Autoconf header if the feature was specifically enabled or disabled.
      
      Source/JavaScriptCore: 
      
      * GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a56af6cd
    • commit-queue@webkit.org's avatar
      Source/WebCore: [CSS Background Blending] Specifying background-image and background-color · 5b54a1ec
      commit-queue@webkit.org authored
      with opaque image doesn't trigger blending. The fix consists of adding a
      check whether blend mode is set in hasOpaqueImage.
      
      https://bugs.webkit.org/show_bug.cgi?id=119434
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
      Reviewed by Dirk Schulze.
      
      Test: css3/compositing/background-blend-mode-separate-layer-declaration.html
      
      * rendering/style/FillLayer.cpp:
      (WebCore::FillLayer::hasOpaqueImage):
      
      LayoutTests: [CSS Background Blending] Specifying background-image and background-color with opaque
      image doesn't trigger blending. Adding ref test to validate the fix.
      
      https://bugs.webkit.org/show_bug.cgi?id=119434i
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-08-05
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-separate-layer-declaration-expected.html: Added.
      * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
      * css3/compositing/resources/gray_square.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b54a1ec
  2. 04 Aug, 2013 6 commits
    • zalan@apple.com's avatar
      Background doesn't fully repaint when body has margins. · f0b7adf7
      zalan@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119033
      
      Reviewed by Simon Fraser.
      
      Ensure that background-color changes do not leave unpainted areas when
      body has margins.
      
      Both <body> and <html> background-color get propagated up to the viewport.
      If <body> has background-color attribute set, while <html> doesn't, the color is
      applied not only on the <body> but on both the <html> and the viewport. However,
      it's not enough to mark the RenderView dirty because with tiles backing on,
      there could be areas outside of the viewport that need repaint. By marking
      the RenderView's graphics layer dirty instead, we ensure that all the related
      tiles get marked dirty too and the new background color covers all areas.
      
      Manual test added. When forcing top-level composition on (even with embedded iframe to
      make sure we don't do paintsIntoWindow rendering), the test case execution changes so much,
      that the repaint rects don't reflect the functionality difference anymore.
      
      .:
      
      Reviewed by Simon Fraser.
      
      * ManualTests/compositing/background-color-change-on-body-with-margin.html: Added.
      
      Source/WebCore:
      
      * page/FrameView.cpp:
      (WebCore::FrameView::reset):
      (WebCore::FrameView::layout):
      * page/FrameView.h:
      (WebCore::FrameView::needsFullRepaint):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::styleWillChange):
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::removeChildNode):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::repaintRootContents):
      (WebCore::RenderView::repaintViewAndCompositedLayers):
      * rendering/RenderView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0b7adf7
    • akling@apple.com's avatar
      Document needn't expose its active element. · dad025bb
      akling@apple.com authored
      <http://webkit.org/b/119466>
      
      Reviewed by Antonio Gomes.
      
      The Document::m_activeElement pointer is only used inside updateHoverActiveState(),
      so we can remove the activeElement()/setActiveElement() accessors.
      
      * dom/Document.h:
      * dom/Document.cpp:
      (WebCore::Document::updateHoverActiveState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dad025bb
    • akling@apple.com's avatar
      Inserting a rule into an empty style sheet shouldn't trigger style recalc unless necessary. · de6fc08c
      akling@apple.com authored
      <http://webkit.org/b/119475>
      <rdar://problem/14643481>
      
      Reviewed by Antti Koivisto.
      
      This is kind of a cheesy optimization, but it turns out that the use case is quite common.
      The pattern goes like this:
      
          (1) Create <style> element.
          (2) Add it to the document's <head>.
          (3) .addRule() one rule through the CSSOM API.
      
      Prior to this patch, (3) would always cause a full (deferred) style recalc.
      
      Now that we exclude empty style sheets from the document's (effective) active set,
      we can piggyback on the style invalidation analysis when transitioning from an empty
      sheet to a single-rule sheet.
      
      In other words, add a special code path for the first rule insertion into an empty,
      in-document style sheet to minimize the amount of invalidation that happens.
      
      * css/CSSStyleSheet.cpp:
      (WebCore::CSSStyleSheet::didMutateRules):
      (WebCore::CSSStyleSheet::insertRule):
      * css/CSSStyleSheet.h:
      (WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
      (WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de6fc08c
    • csaavedra@igalia.com's avatar
      [GTK] Fix a C++11 warning. · 536afa8b
      csaavedra@igalia.com authored
      Rubber-stamped by Martin Robinson.
      
      * platform/gtk/FileSystemGtk.cpp:
      (WebCore::sharedResourcesPath): Fix a C++11 warning.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      536afa8b
    • commit-queue@webkit.org's avatar
      [GTK] Remove legacy hack in CodeGeneratorGObject.pm · fbc7b812
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117545
      
      Patch by Diego Pino Garcia <dpino@igalia.com> on 2013-08-04
      Reviewed by Carlos Garcia Campos.
      
      There's a checking that sets gtype to uint in case it's ushort. gtype
      is a value obtained from GetGValueTypeName(), which never returns
      ushort.
      
      * bindings/scripts/CodeGeneratorGObject.pm:
      (GenerateProperty): remove unnecessary glitch
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbc7b812
    • akling@apple.com's avatar
      [Mac] Disable screen font substitution at WebCore-level in OS X 10.9+ · 35261640
      akling@apple.com authored
      <http://webkit.org/b/119474>
      <rdar://problem/14643349>
      
      Reviewed by Dan Bernstein.
      
      Disable screen font substitution by default in Settings so internal WebCore clients
      such as SVG-as-image will get the right default setting.
      
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault):
      (WebCore::Settings::setScreenFontSubstitutionEnabled):
      * page/Settings.h:
      (WebCore::Settings::screenFontSubstitutionEnabled):
      * page/Settings.in:
      * page/mac/SettingsMac.mm:
      (WebCore::Settings::shouldEnableScreenFontSubstitutionByDefault):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35261640
  3. 03 Aug, 2013 8 commits
    • timothy_horton@apple.com's avatar
      Refine the unavailable plug-in indicator · 1a575c3d
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119400
      <rdar://problem/14616012>
      
      Reviewed by Oliver Hunt.
      
      Add a border, flip the text and background colors, and make the indicator
      much higher contrast, to be more visible on a variety of sites.
      Also, refine the arrow to be less blocky and inlaid inside a circle.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::replacementTextRoundedRectPressedColor):
      (WebCore::replacementTextRoundedRectColor):
      (WebCore::replacementTextColor):
      (WebCore::unavailablePluginBorderColor):
      (WebCore::drawReplacementArrow):
      (WebCore::RenderEmbeddedObject::paintReplaced):
      (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
      (WebCore::RenderEmbeddedObject::unavailablePluginIndicatorBounds):
      (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
      * rendering/RenderEmbeddedObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a575c3d
    • timothy_horton@apple.com's avatar
      Unreviewed, build and style fix for r153693. · 09520713
      timothy_horton@apple.com authored
      * UIProcess/WebProcessProxy.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.h:
      * WebProcess/WebPage/WebPage.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09520713
    • timothy_horton@apple.com's avatar
      Remove SimplePDFPlugin · ad693605
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119437
      
      Reviewed by Alexey Proskuryakov.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::getPlugins):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      Don't add SimplePDFPlugin, nor try to instantiate it.
      
      * WebProcess/Plugins/PDF/PDFPlugin.h:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      Merge previously inherited behavior in from SimplePDFPlugin.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/Plugins/PDF/SimplePDFPlugin.h: Removed.
      * WebProcess/Plugins/PDF/SimplePDFPlugin.mm: Removed.
      Remove SimplePDFPlugin.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad693605
    • timothy_horton@apple.com's avatar
      Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for the Mac port · 8de467bf
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119411
      
      Reviewed by Simon Fraser.
      
      Mac is the only holdout that performs non-composited fades of page
      overlays. We should adopt that mechanism (as a precursor to doing a
      CA-accelerated fade) and remove the now-unnecessary property.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
      (WKBundlePageOverlayFractionFadedIn):
      Always return 1 (fully-faded-in) so that clients who attempt to use this
      to bake the fade opacity into their painting will paint at full opacity,
      allowing us to do the composited fade separately.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
      * WebProcess/WebPage/DrawingArea.h:
      * WebProcess/WebPage/DrawingAreaImpl.cpp:
      * WebProcess/WebPage/DrawingAreaImpl.h:
      * WebProcess/WebPage/LayerTreeHost.h:
      * WebProcess/WebPage/PageOverlay.cpp:
      (WebKit::PageOverlay::PageOverlay):
      (WebKit::PageOverlay::setPage):
      (WebKit::PageOverlay::setNeedsDisplay):
      (WebKit::PageOverlay::fadeAnimationTimerFired):
      * WebProcess/WebPage/PageOverlay.h:
      Remove pageOverlayShouldApplyFadeWhenPainting and fractionFadedIn().
      
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::drawRect):
      Draw the find overlay without taking the PageOverlay's fade into account.
      
      * WebProcess/WebPage/TapHighlightController.cpp:
      (WebKit::TapHighlightController::drawRect):
      Remove pageOverlayShouldApplyFadeWhenPainting. Since it's always
      "false" for all ports now, take the second path here.
      
      * WebProcess/WebPage/mac/LayerTreeHostMac.h:
      * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
      (WebKit::LayerTreeHostMac::setPageOverlayOpacity):
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::setPageOverlayOpacity):
      Implement setPageOverlayOpacity for DrawingAreaImpl
      and TiledCoreAnimationDrawingArea.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8de467bf
    • fpizlo@apple.com's avatar
      hasIndexingHeader() ought really to be a property of an object and its... · 557c3d06
      fpizlo@apple.com authored
      hasIndexingHeader() ought really to be a property of an object and its structure, not just its structure
      https://bugs.webkit.org/show_bug.cgi?id=119470
      
      Reviewed by Oliver Hunt.
              
      Structure can still tell you if the object "could" (in the conservative sense)
      have an indexing header; that's used by the compiler.
              
      Most of the time if you want to know if there's an indexing header, you ask the
      JSObject.
              
      In some cases, the JSObject wants to know if it would have an indexing header if
      it had a different structure; then it uses Structure::hasIndexingHeader(JSCell*).
      
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryCachePutByID):
      (JSC::DFG::tryBuildPutByIdList):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
      * runtime/ButterflyInlines.h:
      (JSC::Butterfly::create):
      (JSC::Butterfly::growPropertyStorage):
      (JSC::Butterfly::growArrayRight):
      (JSC::Butterfly::resizeArray):
      * runtime/JSObject.cpp:
      (JSC::JSObject::copyButterfly):
      (JSC::JSObject::visitButterfly):
      * runtime/JSObject.h:
      (JSC::JSObject::hasIndexingHeader):
      (JSC::JSObject::setButterfly):
      * runtime/Structure.h:
      (JSC::Structure::couldHaveIndexingHeader):
      (JSC::Structure::hasIndexingHeader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      557c3d06
    • simon.fraser@apple.com's avatar
      webaudio/audiobuffersource-loop-points.html always times out · 9c8b9629
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119467
      
      Skip this test.
      
      * platform/mac-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8b9629
    • commit-queue@webkit.org's avatar
      PreloadScanner preloads external CSS with non-matching media attribute · da08655f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106198
      
      Patch by Yoav Weiss <yoav@yoav.ws> on 2013-08-03
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Test: http/tests/loading/preload-css-test.html
      
      * html/parser/HTMLPreloadScanner.cpp:
      Remove m_linkMediaAttributeIsScreen
      Remove MediaQueryEvaluator calls
      Add m_mediaAttribute that gets the value of the "media" attribute
      Pass m_mediaAttribute to PreloadRequest
      (WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
      (WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
      (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
      (WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
      (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
      * html/parser/HTMLResourcePreloader.cpp:
      Add MediaQueryEvaluator calls to see if "media" matches
      Perform preload only to resource with a matching media (if media exists)
      (WebCore::PreloadRequest::isSafeToSendToAnotherThread):
      (WebCore::mediaAttributeMatches):
      (WebCore::HTMLResourcePreloader::preload):
      * html/parser/HTMLResourcePreloader.h:
      Add a constructor with a mediaAttribute value
      Add m_mediaAttribute & its getter.
      (WebCore::PreloadRequest::create):
      (WebCore::PreloadRequest::media):
      (WebCore::PreloadRequest::PreloadRequest):
      
      LayoutTests:
      
      * http/tests/loading/preload-css-test-expected.txt: Added.
      * http/tests/loading/preload-css-test.html: Added.
      * http/tests/loading/resources/big_mq.css: Added.
      * http/tests/loading/resources/small_mq.css: Added.
      * http/tests/local/link-stylesheet-load-order-preload-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da08655f
    • akling@apple.com's avatar
      RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*. · a4df5a15
      akling@apple.com authored
      <http://webkit.org/b/119181>
      
      Reviewed by Sam Weinig.
      
      De-generalize this code a bit since we know that the firstLetterRemainingText() is always
      going to be a RenderTextFragment.
      
      * rendering/RenderBoxModelObject.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::firstLetterRemainingText):
      (WebCore::RenderBoxModelObject::setFirstLetterRemainingText):
      
          Make these two deal in RenderTextFragment*.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateFirstLetterStyle):
      
          Tighten up some pointer types so we don't have to cast as much.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4df5a15
  4. 02 Aug, 2013 24 commits
    • gyuyoung.kim@samsung.com's avatar
      Introduce toSVGMaskElement(), and use it · 197e90b2
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119443
      
      Reviewed by Andreas Kling.
      
      As a step to change static_cast with toSVGXXX, static_cast<SVGMaskElement*> can
      be changed with toSVGMaskElement().
      
      Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155432
      
      * rendering/svg/RenderSVGResourceMasker.cpp:
      (WebCore::RenderSVGResourceMasker::applyResource):
      (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
      * rendering/svg/RenderSVGResourceMasker.h:
      * svg/SVGMaskElement.h:
      (WebCore::toSVGMaskElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      197e90b2
    • benjamin@webkit.org's avatar
      Remove a bunch of redundant checks for empty string in StringImpl · 38e804d1
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118768
      
      Reviewed by Ryosuke Niwa.
      
      The first thing done by createUninitialized() is check if the length passed
      is zero. Internally, there are many cases for which we know the check will never succeed.
      
      Clang is usually really smart for those kind of things, but there are a few cases where
      the condition to avoid returning empty() is not simply a check for the length.
      This patch adds an internal initializer to deal with that.
      
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::createUninitializedInternal):
      (WTF::StringImpl::createUninitializedInternalNonEmpty):
      (WTF::StringImpl::createInternal): Create internal has a special case for null pointer
      for the characters. The test also check length, the second check for length cannot fail.
      (WTF::StringImpl::create8BitIfPossible): ditto.
      (WTF::StringImpl::lower): 3 of the calls cannot be reached for empty length. On an empty length,
      the test for (noUpper && !(ored & ~0x7F)) would have caused the function to return "this".
      
      For the last createUninitialized(), there is no guarantee the realLength is not zero.
      
      (WTF::StringImpl::replace): The first thing we do in replace(UChar,UChar) is check if there is anything
      to replace. The check for length will never succeed as there must be a character to replace at that point.
      * wtf/text/StringImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38e804d1
    • benjamin@webkit.org's avatar
      REGRESSION (r153005): Crash in SpaceSplitString::spaceSplitStringContainsValue on Facebook · 74498efa
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119384
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-08-02
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore: 
      
      When removing the "rel" attribute from HTMLAnchorElement, we parse the attribute for no value.
      Following r153005, we no longer checked for null String, which caused a crash in that case.
      
      Creating a SpaceSplitString from a null string causes the SpaceSplitString to be null. In that case
      SpaceSplitString::contains() would always return false.
      This patch modify SpaceSplitString::spaceSplitStringContainsValue() to follow the exact same
      behavior.
      
      Test: fast/dom/HTMLAnchorElement/remove-rel-attribute.html
      
      * dom/SpaceSplitString.cpp:
      (WebCore::SpaceSplitString::spaceSplitStringContainsValue):
      
      LayoutTests: 
      
      * fast/dom/HTMLAnchorElement/remove-rel-attribute.html: Added.
      * fast/dom/HTMLAnchorElement/remove-rel-attribute-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74498efa
    • dino@apple.com's avatar
      Force elements with perspective or preserve-3d to disallow direct composited backgrounds · b0b80c04
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119462
      <rdar://problem/14607548>
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Bug 119461 (http://wkb.ug/119461) describes how a directly composited
      background color can intersect with its children. It's not clear exactly
      what the best way to fix that is, but for the moment we should disallow
      any element that has perspective or a preserve-3d transform style from
      getting a directly composited background.
      
      Test: compositing/background-color/no-composited-background-color-when-perspective.html
      
      * rendering/RenderLayerBacking.cpp:
      (WebCore::hasPerspectiveOrPreserves3D): New static helper.
      (WebCore::supportsDirectBoxDecorationsComposition): Return false if the above function is true.
      
      LayoutTests:
      
      * compositing/background-color/no-composited-background-color-when-perspective-expected.html: Added.
      * compositing/background-color/no-composited-background-color-when-perspective.html: Added.
      * compositing/geometry/preserve-3d-switching-expected.txt: Rebaselined.
      * compositing/overflow-trumps-transform-style-expected.txt: Rebaselined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b80c04
    • oliver@apple.com's avatar
      Update binding test results · 90da2671
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90da2671
    • commit-queue@webkit.org's avatar
      Give the error object's stack property accessor attributes. · 3c6fb2b8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119404
      
      Source/JavaScriptCore:
      
      Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-02
      Reviewed by Geoffrey Garen.
      
      Changed the attributes of error object's stack property to allow developers to write
      and delete the stack property. This will match the functionality of Chrome. Firefox
      allows developers to write the error's stack, but not delete it.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::addStackTraceIfNecessary):
      * runtime/ErrorInstance.cpp:
      (JSC::ErrorInstance::finishCreation):
      
      LayoutTests:
      
      Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-02
      Reviewed by Geoffrey Garen.
      
      * fast/dom/DOMException/stack-trace-expected.txt:
      
      New tests to show that the error object's stack property is writable and deleteable.
      * fast/js/error-object-write-and-detele-for-stack-property-expected.txt: Added.
      * fast/js/error-object-write-and-detele-for-stack-property.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c6fb2b8
    • roger_fong@apple.com's avatar
      Unreviewed. Skip failing canvas blending tests on AppleWin port. · f1bd6f25
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119463.
      
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1bd6f25
    • barraclough@apple.com's avatar
      Remove no-arguments constructor to PropertySlot · d317512c
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119460
      
      Reviewed by Geoff Garen.
      
      This constructor was unsafe if getValue is subsequently called,
      and the property is a getter. Simplest to just remove it.
      
      Source/WebCore: 
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
      (WebCore::DialogHandler::returnValue):
      * bindings/js/JSHistoryCustom.cpp:
      (WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
      * bindings/js/JSPluginElementFunctions.cpp:
      (WebCore::runtimeObjectCustomGetOwnPropertyDescriptor):
      * bindings/js/JSStorageCustom.cpp:
      (WebCore::JSStorage::deleteProperty):
      (WebCore::JSStorage::putDelegate):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertyDescriptorBody):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::getOwnPropertyDescriptor):
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::getOwnPropertyDescriptor):
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
      
      Source/WebKit2: 
      
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::getOwnPropertyDescriptor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d317512c
    • mark.lam@apple.com's avatar
      Gardening: Touched a line in Platform.h to get all bots to do a clean build. · 3dd7b19e
      mark.lam@apple.com authored
      Not reviewed.
      
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dd7b19e
    • oliver@apple.com's avatar
      Incorrect type speculation reported by ToPrimitive · b06642f9
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119458
      
      Reviewed by Mark Hahnenberg.
      
      Make sure that we report the correct type possibilities for the output
      from ToPrimitive
      
      * dfg/DFGAbstractInterpreterInlines.h:
      (JSC::DFG::::executeEffects):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b06642f9
    • barraclough@apple.com's avatar
      Remove no-arguments constructor to PropertySlot · d4c07a32
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119460
      
      Reviewed by Geoff Garen.
      
      This constructor was unsafe if getValue is subsequently called,
      and the property is a getter. Simplest to just remove it.
      
      * runtime/Arguments.cpp:
      (JSC::Arguments::defineOwnProperty):
      * runtime/JSActivation.cpp:
      (JSC::JSActivation::getOwnPropertyDescriptor):
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::getOwnPropertyDescriptor):
      (JSC::JSFunction::getOwnNonIndexPropertyNames):
      (JSC::JSFunction::put):
      (JSC::JSFunction::defineOwnProperty):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::defineOwnProperty):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::hasOwnPropertyForWrite):
      * runtime/JSNameScope.cpp:
      (JSC::JSNameScope::put):
      * runtime/JSONObject.cpp:
      (JSC::Stringifier::Holder::appendNextProperty):
      (JSC::Walker::walk):
      * runtime/JSObject.cpp:
      (JSC::JSObject::hasProperty):
      (JSC::JSObject::hasOwnProperty):
      (JSC::JSObject::reifyStaticFunctionsForDelete):
      * runtime/Lookup.h:
      (JSC::getStaticPropertyDescriptor):
      (JSC::getStaticFunctionDescriptor):
      (JSC::getStaticValueDescriptor):
      * runtime/ObjectConstructor.cpp:
      (JSC::defineProperties):
      * runtime/PropertySlot.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c07a32
    • akling@apple.com's avatar
      Removing a <link> element with an empty stylesheet shouldn't trigger style recalc. · b702d7d9
      akling@apple.com authored
      <http://webkit.org/b/119442>
      <rdar://problem/14631785>
      
      Reviewed by Antti Koivisto.
      
      Let Document decide whether or not to do a style recalc after a <link> element is removed.
      This avoids unnecessary work when removing a <link> that refers to an empty style sheet.
      
      Some Facebook pages have a <link rel="stylesheet" href="data:text/css;base64,"> that gets
      removed during the initial page load, causing style recalc.
      
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::removedFrom):
      
          Use DeferRecalcStyleIfNeeded. Since the style sheet is being removed, it will either
          cause a recalc (because it's no longer in the set of active sheets) or do nothing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b702d7d9
    • mhahnenberg@apple.com's avatar
      DFG validation can cause assertion failures due to dumping · 0c662a4b
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119456
      
      Reviewed by Geoffrey Garen.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::hasHash):
      (JSC::CodeBlock::isSafeToComputeHash):
      (JSC::CodeBlock::hash):
      (JSC::CodeBlock::dumpAssumingJITType):
      * bytecode/CodeBlock.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c662a4b
    • commit-queue@webkit.org's avatar
      [Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable · fd4af939
      commit-queue@webkit.org authored
      <rdar://problem/14627633> and https://bugs.webkit.org/show_bug.cgi?id=119419
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-08-02
      Reviewed by Tim Horton.
      
      * UIProcess/mac/WebColorPickerMac.mm:
      (WebKit::WebColorPickerMac::~WebColorPickerMac): If the m_colorPickerUI variable
        is not null, then properly destroy it first before destroying WebColorPickerMac object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4af939
    • commit-queue@webkit.org's avatar
      Have vm's exceptionStack match java's vm's exceptionStack. · 0fa61728
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119362
      
      Source/JavaScriptCore:
      
      Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-02
      Reviewed by Geoffrey Garen.
      
      The error object's stack is only updated if it does not exist yet. This matches
      the functionality of other browsers, and Java VMs.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::addStackTraceIfNecessary):
      (JSC::Interpreter::throwException):
      * runtime/VM.cpp:
      (JSC::VM::clearExceptionStack):
      * runtime/VM.h:
      (JSC::VM::lastExceptionStack):
      
      LayoutTests:
      
      Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-02
      Reviewed by Geoffrey Garen.
      
      All modifications to the tests below are column number changes. If the thrown
      object was created by the user the column number references the error object,
      otherwise it references the the throw.
      
      * fast/events/window-onerror5-expected.txt:
      * fast/js/line-column-numbers-expected.txt:
      * fast/js/stack-trace-expected.txt:
      * http/tests/workers/worker-importScriptsOnError-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fa61728
    • paroga@webkit.org's avatar
      Remove WebCore folder from include statements · 9cf610c9
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119438
      
      Reviewed by Darin Adler.
      
      This aligns the style of the changed files with the other WebCore code.
      
      * platform/network/curl/CurlDownload.cpp:
      * platform/network/curl/CurlDownload.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cf610c9
    • commit-queue@webkit.org's avatar
      [Forms: color] The positioning of the popover color well is inverted · 1f9a882d
      commit-queue@webkit.org authored
      <rdar://problem/14635621> and https://bugs.webkit.org/show_bug.cgi?id=119455
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-08-02
      Reviewed by Tim Horton.
      
      This patch converts the coordinates of the <input type='color'> element to
      the window's base coordinate system.
      
      * UIProcess/mac/WebColorPickerMac.mm:
      (-[WKColorPopoverMac initWithFrame:inView:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f9a882d
    • simon.fraser@apple.com's avatar
      9464ae85
    • achristensen@apple.com's avatar
      Soft link ANGLE on Windows. · 9555ca71
      achristensen@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119452
      
      Reviewed by Dean Jackson.
      
      * ANGLE.vcxproj/libEGL.vcxproj:
      * ANGLE.vcxproj/libEGL.vcxproj.filters:
      * ANGLE.vcxproj/libGLESv2.vcxproj:
      * ANGLE.vcxproj/libGLESv2.vcxproj.filters:
      Added soft linking headers.
      * ANGLE.vcxproj/libEGLCommon.props:
      * ANGLE.vcxproj/libGLESv2Common.props:
      * ANGLE.vcxproj/translatorCommon.props:
      Added ANGLE_WEBKIT_WIN macro definition for egl.h and gl2.h.
      * include/EGL/egl.h:
      * include/GLES2/gl2.h:
      Conditionally include soft linking headers based on ANGLE_WEBKIT_WIN macro.
      * include/EGL/eglsoftlinking.h: Added.
      * include/GLES2/gl2softlinking.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9555ca71
    • rniwa@webkit.org's avatar
      FormAssociatedElement shouldn't create out-of-tree FormAttributeTargetObserver · c8954627
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119309
      
      Reviewed by Kent Tamura.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/6fbdcbf311de539107bc28711b3f7a527176e97b.
      
      I'm not merging the test since the attached test case only works when the shadow DOM API is enabled.
      
      * html/FormAssociatedElement.cpp:
      (WebCore::FormAssociatedElement::formAttributeChanged):
      (WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8954627
    • ch.dumez@sisa.samsung.com's avatar
      compareDocumentPosition() should report PRECEDING or FOLLOWING information... · 072d9592
      ch.dumez@sisa.samsung.com authored
      compareDocumentPosition() should report PRECEDING or FOLLOWING information even if nodes are disconnected
      https://bugs.webkit.org/show_bug.cgi?id=119316
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      As per the latest specification, compareDocumentPosition() should report PRECEDING or FOLLOWING
      information even if nodes are disconnected:
      - http://dom.spec.whatwg.org/#dom-node-comparedocumentposition
      
      This behavior is consistent with both IE10, Firefox 22 and since recently Blink.
      
      No new tests, covered by existing tests.
      
      * dom/Node.cpp:
      (WebCore::compareDetachedElementsPosition):
      (WebCore::Node::compareDocumentPosition):
      
      LayoutTests:
      
      Update fast/dom/compare-document-position-disconnected-nodes.html to check that compareDocumentPosition()
      now returns one of the following values for disconnected nodes:
      - DOCUMENT_POSITION_DISCONNECTED | DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC | DOCUMENT_POSITION_PRECEDING
      - DOCUMENT_POSITION_DISCONNECTED | DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC | DOCUMENT_POSITION_FOLLOWING
      
      Several dom/xhtml/level3 are skipped and marked as WonfFix because they are outdated and no longer match
      the DOM4 specification. They expect compareDocumentPosition() not to return PRECEDING / FOLLOWING
      information for disconnected nodes.
      
      * TestExpectations:
      * dom/xhtml/level3/core/nodecomparedocumentposition38-expected.txt:
      * fast/dom/compare-document-position-disconnected-nodes-expected.txt:
      * fast/dom/compare-document-position-disconnected-nodes.html:
      * fast/dom/shadow/compare-document-position-expected.txt:
      * fast/dom/shadow/compare-document-position.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      072d9592
    • commit-queue@webkit.org's avatar
      REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath. · 3a01a348
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119447
      
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-02
      Reviewed by Geoffrey Garen.
      
      Fix .cpload, update call frame and do not restore registers from JIT stack frame in
      mips implementation of ctiVMThrowTrampolineSlowpath. This change is similar to
      r153583 (sh4) and r153648 (ARM).
      
      * jit/JITStubsMIPS.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a01a348
    • commit-queue@webkit.org's avatar
      Implement canvas blending test that should validate the following scenarios: · c5178beb
      commit-queue@webkit.org authored
      Validate that all blending operators work as expected for the following layer combinations:
      
      https://bugs.webkit.org/show_bug.cgi?id=119082
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-08-02
      Reviewed by Dirk Schulze.
      
      * fast/canvas/canvas-blending-clipping-expected.txt: Added.
      * fast/canvas/canvas-blending-clipping.html: Added.
      * fast/canvas/canvas-blending-color-over-color-expected.txt: Added.
      * fast/canvas/canvas-blending-color-over-color.html: Added.
      * fast/canvas/canvas-blending-color-over-gradient-expected.txt: Added.
      * fast/canvas/canvas-blending-color-over-gradient.html: Added.
      * fast/canvas/canvas-blending-color-over-image-expected.txt: Added.
      * fast/canvas/canvas-blending-color-over-image.html: Added.
      * fast/canvas/canvas-blending-color-over-pattern-expected.txt: Added.
      * fast/canvas/canvas-blending-color-over-pattern.html: Added.
      * fast/canvas/canvas-blending-fill-style-expected.txt: Added.
      * fast/canvas/canvas-blending-fill-style.html: Added.
      * fast/canvas/canvas-blending-global-alpha-expected.txt: Added.
      * fast/canvas/canvas-blending-global-alpha.html: Added.
      * fast/canvas/canvas-blending-gradient-over-color-expected.txt: Added.
      * fast/canvas/canvas-blending-gradient-over-color.html: Added.
      * fast/canvas/canvas-blending-gradient-over-gradient-expected.txt: Added.
      * fast/canvas/canvas-blending-gradient-over-gradient.html: Added.
      * fast/canvas/canvas-blending-gradient-over-image-expected.txt: Added.
      * fast/canvas/canvas-blending-gradient-over-image.html: Added.
      * fast/canvas/canvas-blending-gradient-over-pattern-expected.txt: Added.
      * fast/canvas/canvas-blending-gradient-over-pattern.html: Added.
      * fast/canvas/canvas-blending-helpers.js: Added.
      (separateBlendFunctions.normal):
      (separateBlendFunctions.multiply):
      (separateBlendFunctions.screen):
      (separateBlendFunctions.overlay):
      (separateBlendFunctions.darken):
      (separateBlendFunctions.lighten):
      (separateBlendFunctions.colorDodge):
      (separateBlendFunctions.colorBurn):
      (separateBlendFunctions.hardLight):
      (separateBlendFunctions.softLight):
      (separateBlendFunctions.difference):
      (separateBlendFunctions.exclusion):
      (applyBlendMode):
      (luminosity):
      (clipColor):
      (setLuminosity):
      (saturation):
      (setSaturation):
      (nonSeparateBlendFunctions.hue):
      (nonSeparateBlendFunctions.saturation):
      (nonSeparateBlendFunctions.color):
      (nonSeparateBlendFunctions.luminosity):
      (drawColorInContext):
      (drawBackdropColorInContext):
      (drawSourceColorInContext):
      (fillPathWithColorInContext):
      (fillPathWithBackdropInContext):
      (fillPathWithSourceInContext):
      (applyTransformsToContext):
      (drawBackdropColorWithShadowInContext):
      (drawSourceColorRectOverShadow):
      (.backdropImage.onload):
      (drawColorImageInContext):
      (drawBackdropColorImageInContext):
      (drawSourceColorImageInContext):
      (drawColorPatternInContext):
      (drawBackdropColorPatternInContext):
      (drawSourceColorPatternInContext):
      (drawGradientInContext):
      (drawBackdropColorGradientInContext):
      (drawSourceColorGradientInContext):
      (blendColors):
      (separateBlendColors):
      (nonSeparateBlendColors):
      * fast/canvas/canvas-blending-image-over-color-expected.txt: Added.
      * fast/canvas/canvas-blending-image-over-color.html: Added.
      * fast/canvas/canvas-blending-image-over-gradient-expected.txt: Added.
      * fast/canvas/canvas-blending-image-over-gradient.html: Added.
      * fast/canvas/canvas-blending-image-over-image-expected.txt: Added.
      * fast/canvas/canvas-blending-image-over-image.html: Added.
      * fast/canvas/canvas-blending-image-over-pattern-expected.txt: Added.
      * fast/canvas/canvas-blending-image-over-pattern.html: Added.
      * fast/canvas/canvas-blending-pattern-over-color-expected.txt: Added.
      * fast/canvas/canvas-blending-pattern-over-color.html: Added.
      * fast/canvas/canvas-blending-pattern-over-gradient-expected.txt: Added.
      * fast/canvas/canvas-blending-pattern-over-gradient.html: Added.
      * fast/canvas/canvas-blending-pattern-over-image-expected.txt: Added.
      * fast/canvas/canvas-blending-pattern-over-image.html: Added.
      * fast/canvas/canvas-blending-pattern-over-pattern-expected.txt: Added.
      * fast/canvas/canvas-blending-pattern-over-pattern.html: Added.
      * fast/canvas/canvas-blending-shadow-expected.txt: Added.
      * fast/canvas/canvas-blending-shadow.html: Added.
      * fast/canvas/canvas-blending-text-expected.txt: Added.
      * fast/canvas/canvas-blending-text.html: Added.
      * fast/canvas/canvas-blending-transforms-expected.txt: Added.
      * fast/canvas/canvas-blending-transforms.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5178beb
    • fpizlo@apple.com's avatar
      hasIndexingHeader should be a property of the Structure, not just the IndexingType · 80deefc5
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119422
      
      Reviewed by Oliver Hunt.
              
      This simplifies some code and also allows Structure to claim that an object
      has an indexing header even if it doesn't have indexed properties.
              
      I also changed some calls to use hasIndexedProperties() since in some cases,
      that's what we actually meant. Currently the two are synonyms.
      
      * dfg/DFGRepatch.cpp:
      (JSC::DFG::tryCachePutByID):
      (JSC::DFG::tryBuildPutByIdList):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
      * runtime/ButterflyInlines.h:
      (JSC::Butterfly::create):
      (JSC::Butterfly::growPropertyStorage):
      (JSC::Butterfly::growArrayRight):
      (JSC::Butterfly::resizeArray):
      * runtime/IndexingType.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::copyButterfly):
      (JSC::JSObject::visitButterfly):
      (JSC::JSObject::setPrototype):
      * runtime/JSObject.h:
      (JSC::JSObject::setButterfly):
      * runtime/JSPropertyNameIterator.cpp:
      (JSC::JSPropertyNameIterator::create):
      * runtime/Structure.h:
      (JSC::Structure::hasIndexingHeader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80deefc5