1. 26 Aug, 2011 2 commits
    • dglazkov@chromium.org's avatar
      Tweak the use of Open Sans in garden-o-matic summary view to make it look... · a4fd718d
      dglazkov@chromium.org authored
      Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
      https://bugs.webkit.org/show_bug.cgi?id=67066
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4fd718d
    • dglazkov@chromium.org's avatar
      Clean up and line up layout in garden-o-matic summary view. · 112e5c4b
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=67057
      
      1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
      2) Rearranged DOM structure a bit to accommodate recent changes;
      3) Added minimal CSS to line things up.
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      112e5c4b
  2. 25 Aug, 2011 3 commits
  3. 24 Aug, 2011 1 commit
    • abarth@webkit.org's avatar
      Finish writing up details-view in garden-o-matic · b3787d56
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66891
      
      Reviewed by Dimitri Glazkov.
      
      This patch mostly just copies a bunch of CSS from main.css to
      summary.css.  Presumably we'll delete main.css soon.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3787d56
  4. 23 Aug, 2011 1 commit
    • abarth@webkit.org's avatar
      garden-o-matic summary should be able to examine failures · 2a7f2a4e
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66748
      
      Reviewed by Dimitri Glazkov.
      
      This patch refactors a bunch of code from summary.js to independent
      controllers in controllers.js.  This patch also contains the first
      iteration of binding the "examine" event to a the behavior showing the
      details view for the tests.  There's more work to do here to make this
      work properly (and elegantly), but this patch is a start.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a7f2a4e
  5. 20 Aug, 2011 1 commit
    • abarth@webkit.org's avatar
      garden-o-matic summary.html should have UI for examining failures · b10f6b56
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66625
      
      Reviewed by Dimitri Glazkov.
      
      This patch introduces the notion of UI actions and converts our
      existing manual <button> manipulation with this new abstraction.  The
      patch also adds an Examine button to failure notifications.  In a
      future patch, I'll add a controller that wires this button up to
      something useful.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b10f6b56
  6. 17 Aug, 2011 1 commit
    • dglazkov@chromium.org's avatar
      garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories. · 53982382
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66427
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
      ():
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53982382
  7. 16 Aug, 2011 1 commit
    • dglazkov@chromium.org's avatar
      garden-o-matic needs a summary view with actions for each problem. · 07df78e6
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66144
      
      Reviewed by Adam Barth.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@93152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07df78e6
  8. 11 Aug, 2011 1 commit
    • abarth@webkit.org's avatar
      Add unexpected-passes.html to TestFailures for marking tests as passing · 9c454359
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66102
      
      Reviewed by Dimitri Glazkov.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
          - Move some code into the library so it can be shared.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
          - Add round-trip unit tests.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
          - I'm not entirely sure this feature should remain a separate HTML
            file, but it seemed better than cluttering up the main HTML file
            with too much extra stuff.
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
          - The gardening server couldn't handle adding PASS expectations.  Now it can.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c454359
  9. 09 Aug, 2011 1 commit
  10. 04 Aug, 2011 2 commits
    • abarth@webkit.org's avatar
      Add missing license blocks to garden-o-matic · 9cd8333f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65654
      
      Reviewed by Dimitri Glazkov.
      
      This patch is entirely boilerplate.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cd8333f
    • abarth@webkit.org's avatar
      garden-o-matic needs a way to mock out the network · 30f7a612
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65653
      
      Reviewed by Dimitri Glazkov.
      
      This patch introduces the net module, which is a useful mock point for
      abstracting away the network.  Future patches will use this
      infrastructure to test some currently untested code.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
      (NetworkSimulator):
      (NetworkSimulator.prototype.scheduleCallback):
      (NetworkSimulator.prototype.runTest):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30f7a612
  11. 03 Aug, 2011 3 commits
  12. 01 Aug, 2011 2 commits
    • abarth@webkit.org's avatar
      Refactor bugzilla.js for use by garden-o-matic · 1d33f4e3
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65450
      
      Reviewed by Dimitri Glazkov.
      
      This patch refactors bugzilla.js to use the AsynchronousCache and
      updates the style to use a module instead of an object.  This patch
      then fixes all the existing code that uses this class to use the new
      API style.
      
      This main benefit of this patch is we remove the tricky manual caching
      and this code is now available to use in garden-o-matic (since the
      dependency on Utilities.js is now gone).
      
      I ran all the unit tests and poked around in TestFailures a bit to see
      that everything seemed to be working properly.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
      (FailingTestsBugForm):
      (FailingTestsBugForm.prototype._createBugTitle):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
      (FlakyTestBugForm):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
      (NewBugForm):
      (NewBugForm.prototype.domElement):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
      (TestRelatedBugForm):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
      (ViewController.prototype._displayBuilder.start):
      (ViewController.prototype._displayBuilder):
      (ViewController.prototype._domForAuxiliaryUIElements):
      (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
      (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
      (ViewController.prototype._domForPossiblyFlakyTests):
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d33f4e3
    • abarth@webkit.org's avatar
      garden-o-matic shouldn't require local server to determine if compile failed · b675fe53
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65446
      
      Reviewed by Dimitri Glazkov.
      
      This patch adds some basic bindings for the buildbot JSON API.  I
      wanted to use Buildbot.js an Builder.js from the original TestFailures,
      but they make a number of WebKit-specific assumptions.  We'll
      eventually need to reconcile these pieces of code.
      
      I should really add tests for this code, but that will require me to
      build a better mock network.  I'll be happy to do that in a follow-up
      patch.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
          - It's very unclear to me whether didFail is correct.  Supposedly
            the first entry here is the exit code of the step, which is 0 on
            success.  I suspect we'll need to improve this function over time.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b675fe53
  13. 30 Jul, 2011 1 commit
  14. 25 Jul, 2011 1 commit
    • abarth@webkit.org's avatar
      Overhaul garden-o-matic frontend to integrate revision history and failures · 743be9e8
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65089
      
      Reviewed by Dimitri Glazkov.
      
      This is a major overhaul of the garden-o-matic frontend.  The new UI
      integrates the revision history information with failures.  Failures
      appear in context adjacent to the revisions that caused them (which are
      highlighted).  Each buildbot receives a collumn to the left, which
      indicates which revisions that bot has tested and whether that bot
      showed the indicated failures.
      
      Failures are selectable with checkboxes, and can then either be
      examined or rebaselined.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      743be9e8
  15. 24 Jul, 2011 1 commit
    • abarth@webkit.org's avatar
      Rename garden-o-matic "alert" to "infobar" and increase the width to 100%. · cb5f7a63
      abarth@webkit.org authored
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb5f7a63
  16. 22 Jul, 2011 2 commits
    • abarth@webkit.org's avatar
      Fix typo so the tool works on a case-sensitive file system. · 605d29d3
      abarth@webkit.org authored
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      605d29d3
    • abarth@webkit.org's avatar
      garden-o-matic should know what patches are landing · 34e4ce8c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64978
      
      Reviewed by Dimitri Glazkov.
      
      This patch adds a display of the recently committed patches to
      garden-o-matic.  The UI needs iteration, but this patch establishes the
      plumbing.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
          - Teach trac how to extract more information from the commit log.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
          - Add a data attribute for storing the revision.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
          - Add a container for the recent commit history.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
          - CSS for displaying non-ugly commit history.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
          - Wire up trac to the UI container.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
          - A basic, compact display for a list of commits.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34e4ce8c
  17. 21 Jul, 2011 2 commits
    • abarth@webkit.org's avatar
      Rubber-stamped by Adam Roben. · 9d242d78
      abarth@webkit.org authored
      Move garden-o-matic files into the same directory as TestFailures to
      make it easier to integrate the codebases.
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
      * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
      * Scripts/webkitpy/tool/commands/gardenomatic.py:
      * Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d242d78
    • abarth@webkit.org's avatar
      garden-o-matic should be able to rebaseline many tests at once · 07decc5b
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64963
      
      Reviewed by Dimitri Glazkov.
      
      This patch contains some UI for rebaselining tests in bulk.  I don't
      expect this UI to be the final UI, but the underlying infrastructure
      will be useful.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07decc5b
  18. 19 Jul, 2011 1 commit
    • abarth@webkit.org's avatar
      garden-o-matic should have a "Triage Failures" button for iterating over failures · e3b1ada7
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64769
      
      Reviewed by Eric Seidel.
      
      This patch adds some global static state and refactors things a bit so
      that we can iterate over all the failures in the details pane.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
          - Add a generic callback iterator to iterate through a series of
            callbacks. We use this to iterate through the failures we want to
            display the details of.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add a toolbar for the results summary and change the buttons to
            be real buttons.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
          - Make the detail pane 75% of the window.
          - Make the buttons pretty.
          - Allow the failure type badges to apply to the details pane as well.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Restructure how we bring up the details pane so we can iterate
            through a bunch of failures.
          - Remove the transition between results details because it's
            annoying when you want to click through a bunch of failures.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
          - Add some more structure to the title bar for the results details
            so it's clearer which results we're currently displaying.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3b1ada7
  19. 18 Jul, 2011 1 commit
    • abarth@webkit.org's avatar
      garden-o-matic should be able to determine when compile breaks · 1e201086
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64190
      
      Reviewed by Dimitri Glazkov.
      
      This patch adds a red-ish box to the top of the page whenever there is
      a compile error on the bots.  The box automatically opens and closes as
      appropriate and links to the waterfall display.  In the future, we
      might want to compute a regression range.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
          - Add the build-only bots to the config.  We use these to check
            whether the build failed, which is faster than waiting for the
            tester bots to cycle.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add DOM for the alert bar.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
          - CSS to support the alert bar.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Wiring up events to poll the buildbot to see whether compile has
            failed.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
          - Infrastructure for fetching and parsing the buildbot status JSON
            blob.  This code could be better factored for testability.  :(
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
          - UI for displaying compile errors.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e201086
  20. 14 Jul, 2011 1 commit
    • abarth@webkit.org's avatar
      garden-o-matic should have a "rebaseline" button · c6d7a262
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64446
      
      Reviewed by Ojan Vafai.
      
      This patch adds a basic Rebaseline button that copies the baselines
      displayed in the results pane into the appropriate directory in your
      working copy.
      
      There are two main limitations:
      
      1) There is no UI for actually committing the baselines.
      
      2) The baselines are not optimized for redundancy (meaning you can have
         identical baselines in both chromium-mac and chromium-win).
      
      * Scripts/webkitpy/tool/commands/rebaseline.py:
          - Turns out we need to create the directory for the baseline if it doesn't exist yet.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
          - Add an programatic API to call the server.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add the rebaseline button itself.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
          - Change the CSS so that the Rebaseline and Close buttons can
            appear in the normal order in the DOM.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Bind the event and translate the parameters.
          - Hide/show the rebaseline button, as appropriate.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
          - Add some helpful utility functions for manipulating failure types.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6d7a262
  21. 13 Jul, 2011 3 commits
    • abarth@webkit.org's avatar
      Remove "Dismiss" button from garden-o-matic butterbar · 49097b5c
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64443
      
      Reviewed by Dimitri Glazkov.
      
      We don't have any persistent butter bar messages yet, so the dismiss
      button is premature (and fairly heavy, visually).
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49097b5c
    • abarth@webkit.org's avatar
      Refine garden-o-matic status pane · 38a952ee
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64442
      
      Reviewed by Dimitri Glazkov.
      
      This patch makes two improvements to the status pane:
      
      1) We only query the server for failure types that we're expecting.
         This dramatically reduces the number of HTTP requests, making
         loading the status pane faster.
      
      2) The status pane now displays which test and which builder it is
         showing results for.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38a952ee
    • abarth@webkit.org's avatar
      garden-o-matic should show test results · e5211ca0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64440
      
      Reviewed by Adam Roben.
      
      This patch introduces the results detail pane, which appears at the
      bottom of the window and contains test results from the bots.
      Currently, you can activate the pane by mousing over one of the builder
      names associated with a failing test.
      
      This is just a first iteration of the UI.  There's no way to resize or
      zoom in on elements of the details pane, and images likely aren't sized
      correctly, but it's a place to start.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
          - Add constants for our data attributes so we don't typo them!
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
          - Add DOM structure for the details pane.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
          - Bind events for showing and hiding the details pane.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
          - Reduce the number of result types that we query for to avoid
            overfilling the details pane.  We'll probably need another
            solution here in the long-term.  For example, we could use tabs
            to pack more results into the pane.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
          - Now that we're using the config package during testing, we need
            to include it in the testing HTML.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
          - Change the DOM structure of the results detail to make it fit
            nicely in the details pane (rather than flowing freely in the
            body, as it did before).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5211ca0
  22. 12 Jul, 2011 2 commits
    • abarth@webkit.org's avatar
      garden-o-matic should label tests failures of new tests as such · 9d5bda8b
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64421
      
      Reviewed by Ojan Vafai.
      
      Also, we shouldn't dim failures of new tests, even if we've only seen
      them once because they're likely to be real problems that need
      attention.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d5bda8b
    • abarth@webkit.org's avatar
      Re-work garden-o-matic UI to begin to look like the mocks · 8aaefb6b
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64334
      
      Reviewed by Dimitri Glazkov.
      
      This patch changes how we display failures to be more like the mock the
      dglazkov made. We now can display the same information much more
      compactly.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Added.
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
      * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8aaefb6b
  23. 08 Jul, 2011 1 commit
    • abarth@webkit.org's avatar
      Teach garden-o-matic how to display test results · 2c8b8c49
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64141
      
      Reviewed by Ojan Vafai.
      
      This patch includes basic infrastructure for probing build.chromium.org
      for test results.  We only handle text and image tests, not anything
      complicated like reftests.  Also, we're using the revision/build
      independent results store on the server, so we're avoiding that
      complication for now.
      
      It's slightly hacky that we need to probe the server to see what kinds
      of results exist.  A better solution would be to add CORS support to
      the server or to use the local server to help.
      
      * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
      * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c8b8c49
  24. 06 Jul, 2011 2 commits
    • dglazkov@chromium.org's avatar
      2011-07-06 Dimitri Glazkov <dglazkov@chromium.org> · 15ea6f09
      dglazkov@chromium.org authored
              garden-o-matic should use a favicon to indicate current state.
              https://bugs.webkit.org/show_bug.cgi?id=64027
      
              Reviewed by Adam Barth.
      
              * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
              * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15ea6f09
    • abarth@webkit.org's avatar
      2011-07-05 Adam Barth <abarth@webkit.org> · 775a2ac2
      abarth@webkit.org authored
              garden-o-matic should list the failing tests
              https://bugs.webkit.org/show_bug.cgi?id=63978
      
              Reviewed by Eric Seidel.
      
              * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
              * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      775a2ac2
  25. 05 Jul, 2011 3 commits
    • abarth@webkit.org's avatar
      2011-07-05 Adam Barth <abarth@webkit.org> · ca064ba2
      abarth@webkit.org authored
              Add results_unittests.js to garden-o-matic
              https://bugs.webkit.org/show_bug.cgi?id=63971
      
              Reviewed by Eric Seidel.
      
              Adding these unit tests forced me to commit to an API for the results
              module.  I'm not sure if this is the API we'll end up with, but it's
              something not entirely unreasonable.
      
              Also, I've changed results.js over to WebKit style, as discussed previously.
      
              * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca064ba2
    • abarth@webkit.org's avatar
      2011-07-05 Adam Barth <abarth@webkit.org> · c63c57f6
      abarth@webkit.org authored
              garden-o-matic should understand which tests have unexpected failures
              https://bugs.webkit.org/show_bug.cgi?id=63965
      
              Reviewed by Eric Seidel.
      
              Currently, this code just logs the list of unexpected failures to the
              console.  A future patch will do something useful with this
              information.  A testing harness will also come in the next patch.
      
              * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
              * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
              * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c63c57f6
    • abarth@webkit.org's avatar
      2011-07-05 Adam Barth <abarth@webkit.org> · 2a836c3c
      abarth@webkit.org authored
              garden-o-matic should know how to fetch test results from the (NRWT) bots
              https://bugs.webkit.org/show_bug.cgi?id=63959
      
              Reviewed by Eric Seidel.
      
              Currently, this code just fetches the results and expectations JSON
              blob for Linux from the server and logs it to the console.
      
              * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
              * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
              * Scripts/webkitpy/tool/servers/gardeningserver.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a836c3c