GitLab

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        When we create a WebArchive, we walk every node from some starting point, asking each node
        along the way "What are your subresource URLs?"

        That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
        WebCore::Node

        * WebCore.base.exp:
        
        * dom/Node.cpp:
        (WebCore::Node::getSubresourceURLs):
        (WebCore::Node::getSubresourceAttributeStrings):  Virtual and empty.  Subclasses of Node that have 
          subresources will override it.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
        * dom/ProcessingInstruction.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
        * html/HTMLBodyElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
        * html/HTMLEmbedElement.h:
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
        * html/HTMLImageElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
        * html/HTMLInputElement.h:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
        * html/HTMLLinkElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
        * html/HTMLObjectElement.h:
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
        * html/HTMLParamElement.h:
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
        * html/HTMLScriptElement.h:
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
        * html/HTMLTableCellElement.h:
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
        * html/HTMLTableElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
        * svg/SVGCursorElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
        * svg/SVGFEImageElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::getSubresourceAttributeStrings):
        * svg/SVGImageElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
        * svg/SVGScriptElement.h:

WebKit/mac:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        When we create a WebArchive, we walk every node from some starting point, asking each node
        along the way "What are your subresource URLs?"

        That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
        WebCore::Node

        * DOM/WebDOMOperations.mm:
        (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
          calling into individual WebCore::Node implementations
        * DOM/WebDOMOperationsPrivate.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - maintain subpixel-antialiasing when drawing text with a simple shadow

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
        draw the shadow by drawing the text at an offset instead of relying on
        Core Graphics shadows.
        (WebCore::Font::drawGlyphs): Ditto.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Part of the continued push to move WebArchive-related code down to WebCore, this
        moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
          Otherwise, fallback to an ArchiveResource from the current Archive if any.  Otherwise, return null
        * loader/DocumentLoader.h:

        * loader/archive/ArchiveResource.cpp:
        (WebCore::ArchiveResource::create):
        (WebCore::ArchiveResource::ArchiveResource):
        * loader/archive/ArchiveResource.h:

WebKit/mac:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Part of the continued push to move WebArchive-related code down to WebCore, this
        moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 

        * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
          has now been ported down to WebCore
        * WebView/WebFrameInternal.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix Gtk+ build.

        * GNUmakefile.am:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Brady Eidson.

* Configurations/JavaScriptCore.xcconfig:
* Configurations/WebCore.xcconfig:
* Configurations/WebKit.xcconfig:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-03-26  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Add necessary files and build commands to vcproj files to
        build a Curl-based Windows WebKit.  For details, see
        http://bugs.webkit.org/show_bug.cgi?id=17985

        * WebCore.vcproj/WebCore.vcproj:

WebKit/win:

2008-03-26  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Add necessary files and build commands to vcproj files to
        build a Curl-based Windows WebKit.  For details, see
        http://bugs.webkit.org/show_bug.cgi?id=17985

        * WebKit.vcproj/WebKit.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        We now dump all exceptions returned from JavaScriptCore into the
        Inspector's console.

        The HANDLE_EXCEPTION macro records the line on which the exception was
        returned. It calls a new private handleException method on
        InspectorController.

        Reviewed by Kevin McCullough.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::callSimpleFunction): Made this be a
        member of InspectorController so that it can call handleException.
        (WebCore::addSourceToFrame): Pass the exception pointer on to inner
        JSC calls, and check it after those calls return.
        (WebCore::getResourceDocumentNode): Ditto.
        (WebCore::search): Ditto. Also changed the name/type of an existing
        exception variable to ExceptionCode ec.
        (WebCore::databaseTableNames): Ditto.
        (WebCore::moveByUnrestricted): Ditto.
        (WebCore::InspectorController::~InspectorController): Check for and
        record exceptions as we call JSC.
        (WebCore::InspectorController::focusNode): Ditto.
        (WebCore::InspectorController::scriptObjectReady): Ditto.
        (WebCore::addHeaders): Added an exception parameter.
        (WebCore::scriptObjectForRequest): Ditto.
        (WebCore::scriptObjectForResponse): Ditto.
        (WebCore::InspectorController::addScriptResource): Check for and
        record exceptions as we call JSC.
        (WebCore::InspectorController::addAndUpdateScriptResource): Ditto.
        (WebCore::InspectorController::removeScriptResource): Ditto. Also
        moved the call to setScriptObject to before the JSC calls so that it
        will always be called even if we return early if JSC throws an
        exception.
        (WebCore::InspectorController::updateScriptResourceRequest): Check for
        and record exceptions as we call JSC.
        (WebCore::InspectorController::updateScriptResourceResponse): Ditto.
        (WebCore::InspectorController::updateScriptResource): Ditto.
        (WebCore::InspectorController::addDatabaseScriptResource): Ditto.
        (WebCore::InspectorController::removeDatabaseScriptResource): Ditto.
        Also moved the call to setScriptObject to before the JSC calls so that
        it will always be called even if we return early if JSC throws an
        exception.
        (WebCore::InspectorController::addScriptConsoleMessage): Check for and
        record exceptions as we call JSC.
        (WebCore::InspectorController::handleException): Added.
        * page/InspectorController.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <http://bugs.webkit.org/show_bug.cgi?id=18060>

        Reviewed by Geoff Garen.

        Bug fix:

        * API/JSCallbackObjectFunctions.h:
        (KJS::JSCallbackObject<Base>::toString): Make the DropAllLocks
        instance only be in scope while calling convertToType.

        Test:

        * API/testapi.c:
        (MyObject_convertToType): Implement type conversion to string.
        * API/testapi.js: Add a test for type conversion to string.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber stamped by Maciej.

        - removed a couple log messages in error cases that are handled internally

        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decode): Removed the LOG_ERROR.
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h: Updated.
        * win/lib/WebKitSystemInterface.lib: Updated.
        * win/lib/WebKitSystemInterface_debug.lib: Updated.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        * page/Location.idl: Don't enumerate toString.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber-stamped by Adam Roben.

        Update test result.

        * fast/dom/Window/window-special-properties-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Screenshot for blog post.

        * blog-files/acid3-100.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * kjs/array_instance.cpp: Touched this.
        * wtf/HashFunctions.h:
        (WTF::intHash): Added 8- and 16-bit versions of intHash.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt and Adam.

        Coded by me and Darin.
        
        - SVG kerning support (horizontal kerning only for now since we don't do vertical text layout right yet) 
        
        Acid3 100/100

        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth):
        (WebCore::Font::isSVGFont):
        * platform/graphics/Font.h:
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphWidth):
        (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
        * rendering/SVGInlineTextBox.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::cummulatedWidthOrHeightOfTextChunk):
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        * rendering/SVGRootInlineBox.h:
        (WebCore::LastGlyphInfo::LastGlyphInfo):
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        (WebCore::Font::svgFont):
        (WebCore::floatWidthOfSubStringUsingSVGFont):
        (WebCore::Font::floatWidthUsingSVGFont):
        (WebCore::Font::drawTextUsingSVGFont):
        (WebCore::Font::selectionRectForTextUsingSVGFont):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::invalidateGlyphCache):
        (WebCore::SVGFontElement::ensureGlyphCache):
        (WebCore::parseUnicodeRange):
        (WebCore::parseUnicodeRangeList):
        (WebCore::stringMatchesUnicodeRange):
        (WebCore::matches):
        (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
        * svg/SVGFontElement.h:
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::insertedIntoDocument):
        (WebCore::SVGGlyphElement::removedFromDocument):
        * svg/SVGHKernElement.cpp: Added.
        (WebCore::SVGHKernElement::SVGHKernElement):
        (WebCore::SVGHKernElement::~SVGHKernElement):
        (WebCore::SVGHKernElement::insertedIntoDocument):
        (WebCore::SVGHKernElement::removedFromDocument):
        (WebCore::SVGHKernElement::buildHorizontalKerningPair):
        * svg/SVGHKernElement.h: Added.
        (WebCore::SVGHorizontalKerningPair::SVGHorizontalKerningPair):
        (WebCore::SVGHKernElement::rendererIsNeeded):
        * svg/SVGHKernElement.idl: Added.
        * svg/SVGTextContentElement.cpp:
        (WebCore::cummulatedCharacterRangeLength):
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
        * svg/svgtags.in:

LayoutTests:

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Hyatt and Adam.
        
        - new test case and test fixes for SVG text kerning

        * svg/text/kerning.svg: Added.
        * platform/mac/svg/text/kerning-expected.txt: Added.

        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Roben.

        Autogenerate JSLocation.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Add files.

        * DerivedSources.make: Add Location, remove JSLocation.lut.h
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
        (WebCore::JSDOMWindowBase::getValueProperty):
        (WebCore::JSDOMWindowBase::put):
        (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
        (WebCore::JSDOMWindowBase::disconnectFrame):
        * bindings/js/JSDOMWindowBase.h:
        Remove manuel management of the Location object.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark): Add marking of JSLocation.
        (WebCore::JSDOMWindow::setLocation): Add custom setLocation as we only want to do this when
        safe and we need to keep Dashboard quirks.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location):
        Fetch the location object using the normal toJS route.

        * bindings/js/JSLocation.cpp: Removed.
        * bindings/js/JSLocation.h: Removed.
        * bindings/js/JSLocationCustom.cpp: Added.
        (WebCore::JSLocation::customGetOwnPropertySlot):
        (WebCore::JSLocation::customPut):
        (WebCore::JSLocation::deleteProperty):
        (WebCore::JSLocation::customGetPropertyNames):
        (WebCore::navigateIfAllowed):
        (WebCore::JSLocation::setHref):
        (WebCore::JSLocation::setProtocol):
        (WebCore::JSLocation::setHost):
        (WebCore::JSLocation::setHostname):
        (WebCore::JSLocation::setPort):
        (WebCore::JSLocation::setPathname):
        (WebCore::JSLocation::setSearch):
        (WebCore::JSLocation::setHash):
        (WebCore::JSLocation::replace):
        (WebCore::JSLocation::reload):
        (WebCore::JSLocation::assign):
        (WebCore::JSLocation::toString):
        Setter and Functions need custom implementations as they rely on the dynamic
        global object for determining the behavior of the navigation.

        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::restore):
        (WebCore::CachedPage::clear):
        * history/CachedPage.h:
        Removed all the special casing for location as it should be treated like all
        the other objects hanging off the window.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::clear):
        (WebCore::DOMWindow::location):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalLocation):
        * page/DOMWindow.idl:
        Add Location accessor and pointer getter for marking.

        * page/Location.cpp: Added.
        (WebCore::Location::Location):
        (WebCore::Location::disconnectFrame):
        (WebCore::Location::url):
        (WebCore::Location::href):
        (WebCore::Location::protocol):
        (WebCore::Location::host):
        (WebCore::Location::hostname):
        (WebCore::Location::port):
        (WebCore::Location::pathname):
        (WebCore::Location::search):
        (WebCore::Location::hash):
        (WebCore::Location::toString):
        * page/Location.h: Added.
        (WebCore::Location::create):
        (WebCore::Location::frame):
        * page/Location.idl: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Add support for the rendering and measurement of the <altGlyph> element in SVG.  This patch brings
        is half of what's needed to reach 100/100 on Acid3 and pass the test.  Maciej has coded up the other half. :)

        Reviewed by mjs

        Added svg/custom/altGlyph.svg

        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
        (WebCore::SVGAltGlyphElement::glyphElement):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::insertedIntoDocument):
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::insertedIntoDocument):
        (WebCore::SVGGlyphElement::removedFromDocument):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore:

        Force JSC headers to be copied by touching a file

        * kjs/array_instance.cpp:
        (KJS::ArrayInstance::getPropertyNames):

WebCore:

        Turn on SVG animation on Windows

        Also touched some files to force things to rebuild/regenerate.

        * WebCore.vcproj/WebCore.vcproj: Added ENABLE_SVG_ANIMATION.
        * WebCore.vcproj/build-generated-files.sh: Ditto.
        * bindings/scripts/CodeGenerator.pm: Touched.
        * config.h: Touched.
        * svg/svgtags.in: Touched.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Harrison.

        <rdar://problem/5820749> REGRESSION (Safari 3.1): Mail's plain text reply omits blank line following the attribution

        * editing/markup.cpp:
        (WebCore::createFragmentFromText): When asked to create a fragment from "Attribution:\n"
        with a context from [html, 0] to [html, 0], we'd return "<html>Attribution</html><br>".
        Don't enclose paragraphs in clones of the context's enclosing block if that block is the
        html or body element.  Currently no way to test [DOMHTMLElement createFragmentFromText:].



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Written with Darin.

        Added HashTable plumbing to support using wchar_t as a key type.

        * wtf/HashFunctions.h:
        * wtf/HashTraits.h:
        (WTF::):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-03-26  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.

        http://bugs.webkit.org/show_bug.cgi?id=17077
        Bug 17077: SVG SMIL animation is currently broken (and turned off) (affects Acid3 tests 75 and 76)

        - enable SVG animation support.
        - basic implementation of beginElement()/endElement().
        
        Animation definitely will need more work than this, but it is a start!

        * Configurations/WebCore.xcconfig:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
        (WebCore::SVGAnimationElement::beginElement):
        (WebCore::SVGAnimationElement::beginElementAt):
        (WebCore::SVGAnimationElement::endElement):
        (WebCore::SVGAnimationElement::endElementAt):
        * svg/SVGAnimationElement.h:

WebKitTools:

2008-03-26  Antti Koivisto  <antti@apple.com>

        Reviewed by Anders.
        
        Enable SVG animation support by default.

        * Scripts/build-webkit:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Hyatt.

        Make the Ahem font antialias correctly on Acid3 on Tiger.

        * WebCore.Tiger.exp:
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

2008-03-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Hyatt.

        Make the Ahem font antialias correctly on Acid3 on Tiger.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceTiger.a:

2008-03-26  Mark Rowe  <mrowe@apple.com>

        Reviewed by David Hyatt.

        Make the Ahem font antialias correctly on Acid3 on Tiger.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Not Reviewed.

        Move storage tests to Skipped list since they hang 80% of the time.  See <rdar://problem/5787763>.

        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Anders Carlsson.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18104
          REGRESSION: LEAK: 2 InlineBox in editing/inserting/12882.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): When deciding to ditch
        old clean lines (due to changed or newly-added floats), keep the
        reference to those lines so they can be properly deleted in the end,
        and use a separate flag to signal that no matching should be attempted.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Turn on link-time-codegen in html and rendering related files.

        Reviewed by Oliver.

        * WebCore.vcproj/WebCore.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Darin.

        - JSC part of fix for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=18118

        * wtf/HashFunctions.h:
        (WTF::):
        * wtf/HashTraits.h:
        (WTF::):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - fixed "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=18118

        * svg/SVGFont.cpp:
        (WebCore::SVGTextRunWalker::walk):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        (WebCore::SVGFontElement::addGlyphToCache):
        (WebCore::SVGFontElement::removeGlyphFromCache):
        (WebCore::SVGFontElement::ensureGlyphCache):
        (WebCore::SVGFontElement::getGlyphIdentifiersForString):
        * svg/SVGFontElement.h:
        * svg/SVGGlyphElement.h:
        (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier):
        * svg/SVGGlyphMap.h: Added. New radix tree based glyph map.
        (WebCore::GlyphMapNode::GlyphMapNode):
        (WebCore::SVGGlyphMap::SVGGlyphMap):
        (WebCore::SVGGlyphMap::add):
        (WebCore::SVGGlyphMap::compareGlyphPriority):
        (WebCore::SVGGlyphMap::get):
        (WebCore::SVGGlyphMap::clear):

LayoutTests:

2008-03-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - test updates for "SVG multichar glyph matching matches longest instead of first (affects Acid3 test 79)"
        http://bugs.webkit.org/show_bug.cgi?id=18118

        These test cases were already checking for this exact bug and now
        render correctly.
        
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix build bustage on Tiger.  Tiger will not have the bug fix.

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Make the Ahem font antialias correctly on Acid3.

        Reviewed by Dan

        * platform/graphics/SimpleFontData.h:
        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        <http://bugs.webkit.org/show_bug.cgi?id=17768>

        We were throwing an exception from Object.describe because of some
        undefined variables.

        Reviewed by Tim Hatcher.

        * page/inspector/utilities.js:
        (Object.describe): Reinstate the type1 and type2 variables that were
        removed in r30146. They're still used when formatting a function.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Cache C string identifiers by address, not value, assuming that C strings can only
        be literals.

        1% speedup on Acid3 test 26.

        * kjs/identifier.cpp:
        (KJS::literalIdentifierTable):
        (KJS::Identifier::add):
        Added a new table to cache UString::Reps created from C strings by address. Elements are
        never removed from this cache, as only predefined identifiers can get there.

        * kjs/identifier.h:
        (KJS::Identifier::Identifier): Added a warning.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        An assertion was failing in function-toString-object-literals.html when parsing 1e-500.
        The condition existed before, and got uncovered by turning compiled-out dtoa checks into
        ASSERTs.

        The assertion was verifying that the caller wasn't constructing a Bigint from 0.
        This might have had some reason behind it originally, but I couldn't find any,
        and this doesn't look like a reasonable requirement.

        * kjs/dtoa.cpp: (d2b): Removed the assertion (two copies in different code paths).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Forgot to add braces darin asked for during review.

        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::write):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix, makes us pass Test 70
        XML documents should be strict about encoding checks
        http://bugs.webkit.org/show_bug.cgi?id=17079

        Test: fast/encoding/invalid-xml.html

        * WebCore.base.exp:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::write):
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::ensureSVGFontData):
        * loader/TextResourceDecoder.cpp:
        (WebCore::TextResourceDecoder::TextResourceDecoder):
        (WebCore::TextResourceDecoder::decode):
        * loader/TextResourceDecoder.h:
        * platform/text/TextCodec.h:
        (WebCore::TextCodec::decode):
        * platform/text/TextCodecICU.cpp:
        (WebCore::TextCodecICU::decodeToBuffer):
        (WebCore::ErrorCallbackSetter::ErrorCallbackSetter):
        (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
        (WebCore::TextCodecICU::decode):
        * platform/text/TextCodecICU.h:
        * platform/text/TextCodecLatin1.cpp:
        * platform/text/TextCodecLatin1.h:
        * platform/text/TextCodecUTF16.cpp:
        * platform/text/TextCodecUTF16.h:
        * platform/text/TextCodecUserDefined.cpp:
        * platform/text/TextCodecUserDefined.h:
        * platform/text/TextDecoder.cpp:
        (WebCore::TextDecoder::checkForBOM):
        * platform/text/TextDecoder.h:
        (WebCore::TextDecoder::decode):
        * platform/text/TextEncoding.cpp:
        (WebCore::TextEncoding::decode):
        * platform/text/TextEncoding.h:
        (WebCore::TextEncoding::decode):
        * platform/text/mac/TextCodecMac.cpp:
        (WebCore::TextCodecMac::decode):
        * platform/text/mac/TextCodecMac.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31316 268f45cc-cd09-0410-ab3c-d52691b4dbfc