1. 02 May, 2008 5 commits
  2. 01 May, 2008 19 commits
    • kevino@webkit.org's avatar
      Reviewed by Eric Seidel. · 7ddd11b0
      kevino@webkit.org authored
      Make sure we properly set the button for all mouse events, not just mouse down, set the click count to 0 for non-click events, and finally set the timestamp.
              
      https://bugs.webkit.org/show_bug.cgi?id=18464
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ddd11b0
    • weinig@apple.com's avatar
      2008-05-01 Sam Weinig <sam@webkit.org> · 9ee4418c
      weinig@apple.com authored
              Reviewed by Mark Rowe (in his infinite wisdom).
      
              Auto-generate the JSXSLTProcessor binding.
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::getValueProperty):
              * bindings/js/JSDOMWindowBase.h:
              (WebCore::JSDOMWindowBase::):
              * bindings/js/JSXSLTProcessor.cpp: Removed.
              * bindings/js/JSXSLTProcessor.h: Removed.
              * xml/XSLTProcessor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ee4418c
    • weinig@apple.com's avatar
      WebCore: · 796309ca
      weinig@apple.com authored
      2008-05-01  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Geoffrey Garen.
      
              Fixes:
                - https://bugs.webkit.org/show_bug.cgi?id=17249
                  Incorrect lexical scope after navigation leads to UXSS
                  <rdar://problem/5738497>
      
                - https://bugs.webkit.org/show_bug.cgi?id=16824
                  Script authorization should follow lexical (not dynamic) scope
                  <rdar://problem/5683032>
      
              This patch changes us to perform same-origin checks based on the lexical global object) 
              rather than dynamic global object, which is now possible we don't re-use the window on 
              navigations, but rather switch in a new one and re-use the outer shell.  This is both
              more secure and conforms with the HTML5 specification.  Now that all the checks are
              done based on the lexical global object, we can remove the SecurityOrigin::Reason
              concept, as it was only around to work around an ebay.com bug that required the check to
              be done that way.
      
              An important thing to note is that we currently implement a stricter than necessary policy
              and perform the same-origin check based on the currently active global object to avoid leaking
              the document in cases when the target frame is navigated before access.  This will be fixed in
              an upcoming patch.
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::allowsAccessFrom):
              (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
              (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
              (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
              (WebCore::JSDOMWindowBase::printErrorMessage):
              (WebCore::asJSDOMWindow):
              * bindings/js/JSDOMWindowBase.h:
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::checkOrigin):
              (WebCore::CanvasRenderingContext2D::createPattern):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::begin):
              (WebCore::FrameLoader::write):
              (WebCore::FrameLoader::setOpener):
              (WebCore::FrameLoader::shouldAllowNavigation):
              * page/DOMWindow.h:
              (WebCore::DOMWindow::setSecurityOrigin):
              (WebCore::DOMWindow::securityOrigin):
              (WebCore::DOMWindow::setURL):
              (WebCore::DOMWindow::url):
              * platform/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canAccess):
              (WebCore::SecurityOrigin::isSecureTransitionTo):
              * platform/SecurityOrigin.h:
      
      LayoutTests:
      
      2008-05-01  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Geoffrey Garen.
      
              * http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
              * http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
              * http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
              * http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
              * http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
              * http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
              * http/tests/security/xss-eval-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      796309ca
    • andersca@apple.com's avatar
      WebCore: · 3bee2462
      andersca@apple.com authored
      2008-05-01  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Mark.
      
              Enable 64-bit NPAPI plugins.
              
              * WebCore.xcodeproj/project.pbxproj:
              Don't remove NPAPI related symbols from the 64-bit .exp file.
              
              * bridge/npruntime.h:
              Remove now unnecessary #error.
      
      WebKit/mac:
      
      2008-05-01  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Mark.
      
              64-bit NPAPI plugin build fixes.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView updateAndSetWindow]):
              (-[WebBaseNetscapePluginView start]):
              (-[WebBaseNetscapePluginView windowBecameKey:]):
              * Plugins/WebNetscapeDeprecatedFunctions.c:
              * Plugins/WebNetscapeDeprecatedFunctions.h:
              * Plugins/WebNetscapePluginEventHandler.mm:
              (WebNetscapePluginEventHandler::create):
              * Plugins/WebNetscapePluginEventHandlerCarbon.h:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              * Plugins/WebPluginDatabase.m:
              (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bee2462
    • mjs@apple.com's avatar
      2008-05-01 Maciej Stachowiak <mjs@apple.com> · e7c7f73a
      mjs@apple.com authored
              Reviewed by Oliver (a while ago)
      
              - just a wee bit more bindings speedup
              
              Store the per-document Node --> JS wrapper cache in the document
              instead of an external hashtable.
      
              * bindings/js/kjs_binding.cpp:
              (WebCore::ScriptInterpreter::getDOMNodeForDocument):
              (WebCore::ScriptInterpreter::forgetDOMNodeForDocument):
              (WebCore::ScriptInterpreter::putDOMNodeForDocument):
              (WebCore::ScriptInterpreter::forgetAllDOMNodesForDocument):
              (WebCore::ScriptInterpreter::markDOMNodesForDocument):
              * dom/Document.h:
              (WebCore::Document::wrapperCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7c7f73a
    • andersca@apple.com's avatar
      WebCore: · b0ea2a7c
      andersca@apple.com authored
      2008-05-01  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Tim.
      
              Remove duplicate npfunctions.h header from WebKit.
              
              * WebCore.xcodeproj/project.pbxproj:
              Add npfunctions.h and set its role to private.
              
              * plugins/npfunctions.h:
              Merge Mac specific changes.
      
      WebKit:
      
      2008-05-01  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Tim.
      
              Remove npfunctions.h
              
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2008-05-01  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Tim.
      
              Remove duplicate npfunctions.h header from WebKit.
      
              * MigrateHeaders.make:
              Migrate npfunctions.h
              
              * Plugins/npfunctions.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0ea2a7c
    • weinig@apple.com's avatar
      2008-05-01 Sam Weinig <sam@webkit.org> · d90896de
      weinig@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Rename toJSDOMWindow(KJS::JSGlobalObject) to asJSDOMWindow, as all it does is
              cast.
      
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::toVoidCallback):
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::create):
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              (WebCore::JSDOMApplicationCache::add):
              (WebCore::JSDOMApplicationCache::remove):
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::allowPopUp):
              (WebCore::createWindow):
              (WebCore::windowProtoFuncOpen):
              (WebCore::asJSDOMWindow):
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::JSDOMWindow::postMessage):
              * bindings/js/JSDatabaseCustom.cpp:
              (WebCore::JSDatabase::changeVersion):
              (WebCore::JSDatabase::transaction):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::navigateIfAllowed):
              (WebCore::JSLocation::setHref):
              (WebCore::JSLocation::replace):
              (WebCore::JSLocation::reload):
              (WebCore::JSLocation::assign):
              * bindings/js/JSSQLTransactionCustom.cpp:
              (WebCore::JSSQLTransaction::executeSql):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::open):
              * page/JavaScriptDebugServer.cpp:
              (WebCore::toPage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d90896de
    • mitz@apple.com's avatar
      WebCore: · 63ccccdb
      mitz@apple.com authored
      2008-05-01  Anatoli Papirovski  <apapirovski@mac.com>
      
              Reviewed by Dave Hyatt.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=18347
                Absolutely positioned image percentage width does not respect container's padding
      
              Test: fast/replaced/absolute-position-percentage-width.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcReplacedWidthUsing):
      
      LayoutTests:
      
      2008-05-01  Anatoli Papirovski  <apapirovski@mac.com>
      
              Reviewed by Dave Hyatt.
      
              - added a test case for https://bugs.webkit.org/show_bug.cgi?id=18347
                Absolutely positioned image percentage width does not respect container's padding
      
              * fast/replaced/absolute-position-percentage-width.html: Added.
              * platform/mac/fast/replaced/absolute-position-percentage-width-expected.checksum: Added.
              * platform/mac/fast/replaced/absolute-position-percentage-width-expected.png: Added.
              * platform/mac/fast/replaced/absolute-position-percentage-width-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63ccccdb
    • mitz@apple.com's avatar
      - Windows build fix · 62b1949d
      mitz@apple.com authored
              * platform/graphics/win/FontCGWin.cpp:
              (WebCore::Font::drawGlyphs):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b1949d
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · e5a7a74a
      mitz@apple.com authored
              - make synthetic bold and synthetic italics work in GDI text
              - account for synthetic bold in complex text on Windows
      
              * platform/graphics/win/FontCGWin.cpp:
              (WebCore::Font::drawGlyphs): Adjusted the text rectangle's x coordinates
              to fit italics. Added a skew transform for synthetic italics and a
              second paint pass for synthetic bold.
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::widthForGDIGlyph): Added the synthetic bold
              offset.
              * platform/graphics/win/UniscribeController.cpp:
              (WebCore::UniscribeController::shapeAndPlaceItem): Added the synthetic
              bold offset.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a7a74a
    • alp@webkit.org's avatar
      2008-05-01 Alp Toker <alp@nuanti.com> · d516923f
      alp@webkit.org authored
              Qt/Win build fix attempt following plugin changes. Add missing return
              statements.
      
              Also fixes some newly introduced coding style issues in the Qt port.
      
              * platform/qt/FileSystemQt.cpp:
              (WebCore::openTemporaryFile):
              (WebCore::closeFile):
              (WebCore::writeToFile):
              (WebCore::unloadModule):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d516923f
    • ddkilzer@apple.com's avatar
      2008-05-01 Anders Carlsson <andersca@apple.com> · d54081ac
      ddkilzer@apple.com authored
              Reviewed by Adam.
      
              Export methods needed to subclass Widget.  (See r32770.)
      
              * WebCore.base.exp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d54081ac
    • mrowe@apple.com's avatar
      Versioning. · 793799b8
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      793799b8
    • mrowe@apple.com's avatar
      Versioning. · c52a4f75
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c52a4f75
    • alp@webkit.org's avatar
      2008-05-01 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk> · a55698b8
      alp@webkit.org authored
              Reviewed by Alp Toker.
              Qt parts OK'ed by Simon Hausmann.
      
              Based on work by several authors.
      
              https://bugs.webkit.org/show_bug.cgi?id=14750
              Added support for NPAPI plugins on Gtk and Qt-x11 ports.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a55698b8
    • weinig@apple.com's avatar
      JavaScriptCore: · bb55eb3a
      weinig@apple.com authored
      2008-05-01  Sam Weinig  <sam@webkit.org>
      
              Fix build.
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      WebCore:
      
      2008-05-01  Sam Weinig  <sam@webkit.org>
      
              Fix build.
      
              * ForwardingHeaders/wtf/StrHash.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb55eb3a
    • andersca@apple.com's avatar
      2008-05-01 Anders Carlsson <andersca@apple.com> · 10f8ba69
      andersca@apple.com authored
              Reviewed by Darin.
      
              Move management of cache groups to ApplicationCacheStorage. Also,
              application caches now start out with a null group and will have their group set
              when the cache has finished loading. 
      
              * loader/appcache/ApplicationCache.cpp:
              (WebCore::ApplicationCache::ApplicationCache):
              Initialize m_group to 0.
              
              (WebCore::ApplicationCache::~ApplicationCache):
              Null check the group.
              
              (WebCore::ApplicationCache::setGroup):
              New method for setting the group.
              
              * loader/appcache/ApplicationCache.h:        
              (WebCore::ApplicationCache::create):
              Remove the group argument.
              
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup):
              Let the storage know that the cache group has been destroyed.
              
              (WebCore::ApplicationCacheGroup::cacheForMainRequest):
              Call into the storage.
              
              (WebCore::ApplicationCacheGroup::selectCache):
              Call into the storage.
              
              (WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
              When there are no document loaders associated with the cache group,
              set the newest cache to 0.
              
              (WebCore::ApplicationCacheGroup::cacheDestroyed):
              Delete the group if there are no associated caches.
              
              (WebCore::ApplicationCacheGroup::setNewestCache):
              New method that will set the newest cache and associate the group with the cache.
              
              (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
              Call setNewestCache instead.
              
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::urlHostHash):
              Move host hash method here.
              
              (WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
              New method that finds a cache group with a given manifest URL or creates a new one.
      
              (WebCore::ApplicationCacheStorage::cacheGroupForURL):
              New method that returns a cache group for a given URL.
              
              (WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
              When the cache group has been destroyed, remove it from the hash map.
              
              * loader/appcache/ApplicationCacheStorage.h:
              Add new methods.I b
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10f8ba69
    • alp@webkit.org's avatar
      2008-05-01 Dan Winship <danw@gnome.org> · 2b08899d
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=18490
              Add mostly-working file: support and mostly-broken ftp: support to
              the soup backend.
      
              * platform/network/soup/ResourceHandleSoup.cpp (start): after
              doing basic checks, delegate to one of three submethods
              (startData): handles data: URLs
              (startHttp): handles http: and https: URLs, via libsoup
              (startGio, etc): handles file: and ftp: URLs, via gio. Lots of
              FIXMEs detailing the parts that don't fully work yet.
      
              * platform/network/ResourceHandle.h:
              * platform/network/ResourceHandleInternal.h: add new member
              variables for gio-based loading
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b08899d
    • alp@webkit.org's avatar
      2008-05-01 Alp Toker <alp@nuanti.com> · 55996084
      alp@webkit.org authored
              Rubber-stamped by Anders.
      
              GTK+ build fix for changes in r32752. Use int32, not int32_t types in
              npapi.h.
      
              Additional fix to use same signedness in npapi.h and Mac for the
              interval parameter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55996084
  3. 30 Apr, 2008 16 commits
    • andersca@apple.com's avatar
      WebCore: · 31c218a6
      andersca@apple.com authored
      2008-04-30  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add new Cocoa event model type declarations.
              
              * bridge/npapi.h:
      
      WebKit:
      
      2008-04-30  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add Cocoa event handler.
              
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2008-04-30  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adam.
      
              Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
              
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (PluginTimer::PluginTimer):
              (PluginTimer::start):
              (PluginTimer::fired):
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView stopTimers]):
              (-[WebBaseNetscapePluginView restartTimers]):
              (-[WebBaseNetscapePluginView scrollWheel:]):
              (-[WebBaseNetscapePluginView flagsChanged:]):
              (-[WebBaseNetscapePluginView start]):
              (-[WebBaseNetscapePluginView eventModel]):
              (-[WebBaseNetscapePluginView fini]):
              (-[WebBaseNetscapePluginView getVariable:value:]):
              (-[WebBaseNetscapePluginView setVariable:value:]):
              (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
              (-[WebBaseNetscapePluginView unscheduleTimer:]):
              * Plugins/WebBaseNetscapePluginViewInternal.h:
              * Plugins/WebBaseNetscapePluginViewPrivate.h:
              * Plugins/WebNetscapePluginEventHandler.h:
              * Plugins/WebNetscapePluginEventHandler.mm:
              (WebNetscapePluginEventHandler::create):
              * Plugins/WebNetscapePluginEventHandlerCarbon.h:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              (WebNetscapePluginEventHandlerCarbon::scrollWheel):
              (WebNetscapePluginEventHandlerCarbon::flagsChanged):
              (WebNetscapePluginEventHandlerCarbon::platformWindow):
              * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
              (WebNetscapePluginEventHandlerCocoa::startTimers):
              (WebNetscapePluginEventHandlerCocoa::stopTimers):
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
              (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
              (WebNetscapePluginEventHandlerCocoa::drawRect):
              (WebNetscapePluginEventHandlerCocoa::mouseDown):
              (WebNetscapePluginEventHandlerCocoa::mouseDragged):
              (WebNetscapePluginEventHandlerCocoa::mouseEntered):
              (WebNetscapePluginEventHandlerCocoa::mouseExited):
              (WebNetscapePluginEventHandlerCocoa::mouseMoved):
              (WebNetscapePluginEventHandlerCocoa::mouseUp):
              (WebNetscapePluginEventHandlerCocoa::scrollWheel):
              (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
              (WebNetscapePluginEventHandlerCocoa::keyDown):
              (WebNetscapePluginEventHandlerCocoa::keyUp):
              (WebNetscapePluginEventHandlerCocoa::flagsChanged):
              (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
              (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
              (WebNetscapePluginEventHandlerCocoa::focusChanged):
              (WebNetscapePluginEventHandlerCocoa::platformWindow):
              (WebNetscapePluginEventHandlerCocoa::sendEvent):
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
              * Plugins/npapi.m:
              (NPN_ScheduleTimer):
              (NPN_UnscheduleTimer):
              * Plugins/npfunctions.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31c218a6
    • bdakin@apple.com's avatar
      2008-04-30 Beth Dakin <bdakin@apple.com> · 90a00ff8
      bdakin@apple.com authored
              Reviewed by Sam Weinig.
      
              This patch does three things:
              1. Adds support for the "img" ARIA role
              2. Switches over to a HashMap for converting ARIA role attributes 
              to WebCore's AccessibilityRole type. 
              3. Fixes a crash in the new ARIA code that I ran into while 
              browsing with VoiceOver enabled.
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::headingLevel): This is the crash 
              fix. Make sure the node's renderer is not null before looking up 
              its corresponding AccessibilityObject in the cache.
              (WebCore::AccessibilityObject::accessibilityIsIgnored): Account for 
              ARIA images.
              (WebCore::createARIARoleMap): Switch to HashMap, and add "img" to 
              the Map.
              (WebCore::RoleEntry::): Same.
              (WebCore::ariaRoleToWebCoreRole): Same.
              (WebCore::AccessibilityObject::ariaRoleAttribute): Same.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90a00ff8
    • rwlbuis@webkit.org's avatar
      Reviewed by Nikolas. · d7295f7f
      rwlbuis@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=16447
              onload called too many times for <svg:image>
              https://bugs.webkit.org/show_bug.cgi?id=12282
              SVG wastes time in malloc to send loadEvents to non-existent listeners
      
              Postpone load event dispatching for image when externalResourcesRequired        is true, delaying parents but not siblings, and make sure the load event        is sent once for image in all cases.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7295f7f
    • hyatt@apple.com's avatar
      WebCore: · 46ab9613
      hyatt@apple.com authored
      2008-04-30  David Hyatt  <hyatt@apple.com>
      
              Fix crashes when dynamically removing <video> elements with layers that establish stacking contexts.  This
              won't typically crash release builds because of arena recycling.
      
              Reviewed by Dan Bernstein
              
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::~RenderLayer):
              Make sure to remove the reflection's child layer from its parent.
      
              * rendering/RenderMedia.cpp:
              (WebCore::RenderMedia::~RenderMedia):
              (WebCore::RenderMedia::destroy):
              (WebCore::RenderMedia::removeChild):
              * rendering/RenderMedia.h:
              Adjust the teardown of RenderMedia so that it does all of its teardown inside destroy() (this makes it more
              like other renderers and doesn't leave you staring at a trashed layer hierarchy in the RenderMedia
              destructor).
      
      LayoutTests:
      
      2008-04-30  David Hyatt  <hyatt@apple.com>
      
              Add test for video crasher.
      
              Reviewed by Dan Bernstein
      
              * media/video-layer-crash.html: Added.
              * platform/mac/media/video-layer-crash-expected.checksum: Added.
              * platform/mac/media/video-layer-crash-expected.png: Added.
              * platform/mac/media/video-layer-crash-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ab9613
    • rwlbuis@webkit.org's avatar
      Fix the ChangeLogs so it includes the details about r32719. · 0a86c6f8
      rwlbuis@webkit.org authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a86c6f8
    • mitz@apple.com's avatar
      Adding Radar link · a26871c7
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a26871c7
    • mitz@apple.com's avatar
      2008-04-30 Rémi Zara <remi_zara@mac.com> · 7b4c3374
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              fix https://bugs.webkit.org/show_bug.cgi?id=18618
              REGRESSION (r31823-r31847): Patterns are upside down
      
              * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
              (WebCore::patternCallback): flip the y axis when drawing the tile
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b4c3374
    • timothy@apple.com's avatar
      Fixes an undefined type exception that fires when adding a resource to the inspector · 40aae8dc
      timothy@apple.com authored
      that has a MIME type warning.
      
      Reviewed by Adam Roben.
      
      * page/inspector/Resource.js:
      (WebInspector.Resource.prototype._addTip): Call WebInspector.console instead of
      WebInspector.consolePanel.
      (WebInspector.Resource.prototype._checkWarning): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40aae8dc
    • timothy@apple.com's avatar
      Fixes the bug where the selected resource would be deselected after · 1daf52a8
      timothy@apple.com authored
      changing the sort order in the Resources panel.
      
      Reviewed by Dan Bernstein.
      
      * page/inspector/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
      Rememebr if the tree element that we are sorting was selected, so
      the selection can be restored after it is re-inserted. The onSelect
      is suppressed since we don't need to show the resource again.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1daf52a8
    • timothy@apple.com's avatar
      Fixes the regression where error bubbles in source views always show · 9061c9a8
      timothy@apple.com authored
      "undefined" for the content because the message property on
      ConsoleMessage was removed. Adds support for a plain text formated
      message that is stored in the message proeprty.
      
      Reviewed by Adam Roben.
      
      * page/inspector/Console.js:
      (WebInspector.Console.prototype._format): Add a plainText argument that is passed to
      the formatters.
      (WebInspector.Console.prototype._formatvalue): Add a plainText argument, and a comment
      about needing to honor it if the textContent of the output doesn't make sense.
      (WebInspector.Console.prototype._formatvalue): Ditto.
      (WebInspector.Console.prototype._formatstring): Ditto.
      (WebInspector.Console.prototype._formatregexp): Ditto.
      (WebInspector.Console.prototype._formatarray): Ditto.
      (WebInspector.Console.prototype._formatnode): Ditto.
      (WebInspector.Console.prototype._formatobject): Ditto.
      (WebInspector.Console.prototype._formaterror): Ditto.
      (WebInspector.ConsoleMessage): Call _format passing true for plainText. Get the
      textContnet of the result and assign to the message proeprty. This property is
      referenced from the SourceView.
      (WebInspector.ConsoleMessage.prototype._format): Add a plainText argument. Build the
      result element as a local and return it, instead of using formatedMessage directly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9061c9a8
    • timothy@apple.com's avatar
      Adds a helper function to convert a JSValueRef to a String. · 1bcccab5
      timothy@apple.com authored
      Reviewed by Adam Roben.
      
      * page/InspectorController.cpp:
      (WebCore::toString): Converts a JSValueRef to a String.
      (WebCore::search): Use toString.
      (WebCore::InspectorController::handleException): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bcccab5
    • hausmann@webkit.org's avatar
      2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com> · 742aa43e
      hausmann@webkit.org authored
                  Reviewed by Simon.
      
                  Build the Qt port with SVG Foreign Object support.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      742aa43e
    • hausmann@webkit.org's avatar
      2008-04-30 Simon Hausmann <hausmann@webkit.org> · b5fc07f7
      hausmann@webkit.org authored
              Reviewed by Holger.
      
              Fix null pointer deference triggered by
              LayoutTests/fast/loader/cancel-load-during-port-block-timer.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5fc07f7
    • hyatt@apple.com's avatar
      2008-04-29 David Hyatt <hyatt@apple.com> · cee4af67
      hyatt@apple.com authored
              Improve the performance of masks by adding code to set more precise clips on the transparency layers
              used to paint the content under the mask, and then also avoid creating transparency layers for the masks
              themselves in common cases.
      
              Reviewed by Dan Bernstein
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawTiledImage):
              Fix a bug in drawTiledImage where the composite mode got lost in the double stretch case for nine piece
              images.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paintFillLayers):
              (WebCore::InlineFlowBox::paintFillLayer):
              (WebCore::InlineFlowBox::paintMask):
              Optimize to only push a transparency layer for the mask if multiple images are combining.  Add a new
              composite operator argument for use when painting fill layers to do direct destination-in compositing while
              painting images.
      
      
              * rendering/InlineFlowBox.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintMask):
              (WebCore::RenderBox::paintMaskImages):
              Optimize to only push a transparency layer for the mask if multiple images are combining.
      
              (WebCore::RenderBox::maskClipRect):
              A new method that attempts to compute a precise clip rect for the mask images.
      
              (WebCore::RenderBox::paintFillLayers):
              (WebCore::RenderBox::paintFillLayer):
              (WebCore::RenderBox::paintFillLayerExtended):
              * rendering/RenderBox.h:
              Added the composite operator argument to the paintFillLayer methods.
      
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::paintMask):
              Call the new base class paintMaskImages method for optimized mask painting.
      
              * rendering/RenderLayer.cpp:
              (WebCore::transparencyClipBox):
              Fix a coordinate space issue with transparencyClipBox when masks were used.  The border box was in the
              wrong coordinate space.  Moved the code into the layer's boundingBox() method instead.
      
              (WebCore::RenderLayer::paintLayer):
              Removed the code that always pushed a transparency layer before painting masks.
      
              (WebCore::RenderLayer::boundingBox):
              Call maskClipRect to shrink the bounding box of the layer to fit the mask clip.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintNinePieceImage):
              Added a composite operator argument for direct destination-in painting of nine piece images.
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::maskClipRect):
              (WebCore::RenderObject::paintFillLayerExtended):
              Base class stubs for RenderBox-implemented methods.
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::paintMask):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paintMask):
              Modified to call the new paintMaskImages function.
      
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::draw):
              SVG images now respect composite modes by pushing a transparency layer when the composite mode
              is anything other than source-over.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cee4af67
    • hausmann@webkit.org's avatar
      2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com> · e4600cb9
      hausmann@webkit.org authored
              Rubber-stamped by Rob Buis.
      
              Fixed crash or assertion if SVG_FOREIGN_OBJECT is not enabled
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4600cb9
    • hausmann@webkit.org's avatar
      2008-04-30 Ariya Hidayat <ariya.hidayat@trolltech.com> · 605fa04a
      hausmann@webkit.org authored
              Rubber-stamped by Rob Buis.
      
              Fixed compile, due to API change in XMLSerializer
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      605fa04a