1. 30 Aug, 2010 32 commits
    • morrita@google.com's avatar
      2010-08-13 MORITA Hajime <morrita@google.com> · a43d36a5
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              https://bugs.webkit.org/show_bug.cgi?id=43960
              [Chromium] styled scroll bar on the window is painted badly.
      
              * platform/chromium/test_expectations.txt: Skips at this time and will rebaseline shortly.
              * platform/mac/Skipped: Mac doesn't suffer from the problem.
              * scrollbars/custom-scrollbar-with-incomplete-style.html: Added.
      2010-08-13  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Kent Tamura.
      
              https://bugs.webkit.org/show_bug.cgi?id=43960
              [Chromium] styled scroll bar on the window is painted badly.
      
              WebKit assumes outermost scrollbar always painted.
              So force their style to have the  background color if it isn't
              given by the stylesheet.
      
              Test: scrollbars/custom-scrollbar-with-incomplete-style.html
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasBackground): Extracted body to RenderStyle for sharing.
              * rendering/RenderScrollbar.cpp:
              (WebCore::RenderScrollbar::getScrollbarPseudoStyle): Added the workaround as mentioned above.
              * rendering/RenderScrollbar.h:
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::hasBackground): Extracted from RenderObject.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a43d36a5
    • abarth@webkit.org's avatar
      2010-08-30 Adam Barth <abarth@webkit.org> · 9b381bf1
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              WebCore::RenderBlock::addChild* NULL ptrs
              https://bugs.webkit.org/show_bug.cgi?id=43722
      
              * fast/ruby/before-doesnt-crash-expected.txt: Added.
              * fast/ruby/before-doesnt-crash.html: Added.
      2010-08-30  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebCore::RenderBlock::addChild* NULL ptrs
              https://bugs.webkit.org/show_bug.cgi?id=43722
      
              Also includes some cleanup of comments and ASSERTs.
      
              Test: fast/ruby/before-doesnt-crash.html
      
              * rendering/RenderRuby.cpp:
              (WebCore::RenderRubyAsInline::addChild):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b381bf1
    • tkent@chromium.org's avatar
      2010-08-30 Marc-Antoine Ruel <maruel@chromium.org> · dc3b19e7
      tkent@chromium.org authored
              Reviewed by Kent Tamura
      
              Move most dependencies to webcore_prerequisites
              https://bugs.webkit.org/show_bug.cgi?id=44814
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc3b19e7
    • abarth@webkit.org's avatar
      2010-08-30 Adam Barth <abarth@webkit.org> · 0e12eb32
      abarth@webkit.org authored
              Move AsyncImageResizer back to html to fix Chromium build.
      
              * WebCore.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e12eb32
    • abarth@webkit.org's avatar
      2010-08-30 Adam Barth <abarth@webkit.org> · 53100795
      abarth@webkit.org authored
              Fix silly typo that breaks the build.
      
              * WebCore.pro:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53100795
    • abarth@webkit.org's avatar
      2010-08-30 Adam Barth <abarth@webkit.org> · 3ac2bc06
      abarth@webkit.org authored
              Attempt to fix the Qt build.
      
              * WebCore.pri:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ac2bc06
    • abarth@webkit.org's avatar
      2010-08-30 Adam Barth <abarth@webkit.org> · 04c5cdbf
      abarth@webkit.org authored
              Attempt to fix Chromium build.
      
              * WebCore.gyp/WebCore.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04c5cdbf
    • abarth@webkit.org's avatar
      2010-08-29 Adam Barth <abarth@webkit.org> · 8b61a586
      abarth@webkit.org authored
              Rubber-stamped by Maciej Stachowiak.
      
              Move File and Blob related files from WebCore/html to WebCore/fileapi.
      
              * Android.mk:
              * CMakeLists.txt:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcproj/WebCoreCommon.vsprops:
              * WebCore.xcodeproj/project.pbxproj:
              * fileapi: Added.
              * fileapi/AsyncFileWriter.h: Copied from WebCore/html/AsyncFileWriter.h.
              * fileapi/Blob.cpp: Copied from WebCore/html/Blob.cpp.
              * fileapi/Blob.h: Copied from WebCore/html/Blob.h.
              * fileapi/Blob.idl: Copied from WebCore/html/Blob.idl.
              * fileapi/BlobBuilder.cpp: Copied from WebCore/html/BlobBuilder.cpp.
              * fileapi/BlobBuilder.h: Copied from WebCore/html/BlobBuilder.h.
              * fileapi/BlobBuilder.idl: Copied from WebCore/html/BlobBuilder.idl.
              * fileapi/BlobURL.cpp: Copied from WebCore/html/BlobURL.cpp.
              * fileapi/BlobURL.h: Copied from WebCore/html/BlobURL.h.
              * fileapi/File.cpp: Copied from WebCore/html/File.cpp.
              * fileapi/File.h: Copied from WebCore/html/File.h.
              * fileapi/File.idl: Copied from WebCore/html/File.idl.
              * fileapi/FileError.h: Copied from WebCore/html/FileError.h.
              * fileapi/FileError.idl: Copied from WebCore/html/FileError.idl.
              * fileapi/FileList.cpp: Copied from WebCore/html/FileList.cpp.
              * fileapi/FileList.h: Copied from WebCore/html/FileList.h.
              * fileapi/FileList.idl: Copied from WebCore/html/FileList.idl.
              * fileapi/FileReader.cpp: Copied from WebCore/html/FileReader.cpp.
              * fileapi/FileReader.h: Copied from WebCore/html/FileReader.h.
              * fileapi/FileReader.idl: Copied from WebCore/html/FileReader.idl.
              * fileapi/FileStreamProxy.cpp: Copied from WebCore/html/FileStreamProxy.cpp.
              * fileapi/FileStreamProxy.h: Copied from WebCore/html/FileStreamProxy.h.
              * fileapi/FileThread.cpp: Copied from WebCore/html/FileThread.cpp.
              * fileapi/FileThread.h: Copied from WebCore/html/FileThread.h.
              * fileapi/FileThreadTask.h: Copied from WebCore/html/FileThreadTask.h.
              * fileapi/FileWriter.cpp: Copied from WebCore/html/FileWriter.cpp.
              * fileapi/FileWriter.h: Copied from WebCore/html/FileWriter.h.
              * fileapi/FileWriter.idl: Copied from WebCore/html/FileWriter.idl.
              * fileapi/FileWriterClient.h: Copied from WebCore/html/FileWriterClient.h.
              * fileapi/ThreadableBlobRegistry.cpp: Copied from WebCore/html/ThreadableBlobRegistry.cpp.
              * fileapi/ThreadableBlobRegistry.h: Copied from WebCore/html/ThreadableBlobRegistry.h.
              * html/AsyncFileWriter.h: Removed.
              * html/Blob.cpp: Removed.
              * html/Blob.h: Removed.
              * html/Blob.idl: Removed.
              * html/BlobBuilder.cpp: Removed.
              * html/BlobBuilder.h: Removed.
              * html/BlobBuilder.idl: Removed.
              * html/BlobURL.cpp: Removed.
              * html/BlobURL.h: Removed.
              * html/File.cpp: Removed.
              * html/File.h: Removed.
              * html/File.idl: Removed.
              * html/FileError.h: Removed.
              * html/FileError.idl: Removed.
              * html/FileList.cpp: Removed.
              * html/FileList.h: Removed.
              * html/FileList.idl: Removed.
              * html/FileReader.cpp: Removed.
              * html/FileReader.h: Removed.
              * html/FileReader.idl: Removed.
              * html/FileStreamProxy.cpp: Removed.
              * html/FileStreamProxy.h: Removed.
              * html/FileThread.cpp: Removed.
              * html/FileThread.h: Removed.
              * html/FileThreadTask.h: Removed.
              * html/FileWriter.cpp: Removed.
              * html/FileWriter.h: Removed.
              * html/FileWriter.idl: Removed.
              * html/FileWriterClient.h: Removed.
              * html/ThreadableBlobRegistry.cpp: Removed.
              * html/ThreadableBlobRegistry.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b61a586
    • tkent@chromium.org's avatar
      2010-08-29 Marc-Antoine Ruel <maruel@chromium.org> · e6d3cc94
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              Move more common settings to webcore_prerequisites
              https://bugs.webkit.org/show_bug.cgi?id=44812
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6d3cc94
    • darin@apple.com's avatar
      Fix Qt build. · 0842bd42
      darin@apple.com authored
      * wtf/unicode/glib/UnicodeMacrosFromICU.h: Added U_IS_BMP.
      * wtf/unicode/qt4/UnicodeQt4.h: Ditto.
      * wtf/unicode/wince/UnicodeWince.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0842bd42
    • darin@apple.com's avatar
      2010-08-29 Darin Adler <darin@apple.com> · 3cbd5cb5
      darin@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Create SVG and WML elements with create functions instead of direct invocations of new
              https://bugs.webkit.org/show_bug.cgi?id=44851
      
              Added the create functions, made some existing constructors protected and private,
              made some other member functions protected and and private, added some missing virtual
              keywords for clarity to functions that already were overriding virtual functions,
              fixed some inconsistent indentation, and removed some unneeded empty destructors.
      
              In the future, it will be good to have the constructors all be private so we don't
              use them by accident. Then we'll change the reference count rule globally and add
              all the necessary calls to adoptRef.
      
              The SVG changes are compiled and tested. The WML changes are speculative and untested.
      
              * dom/make_names.pl: Removed supportfor the createWithNew keyword.
              * svg/svgtags.in: Removed all the createWithNew keywords.
              * wml/WMLTagNames.in: Ditto.
      
              * svg/SVGAElement.cpp:
              (WebCore::SVGAElement::create): Added.
              * svg/SVGAElement.h:
              * svg/SVGAltGlyphElement.cpp:
              (WebCore::SVGAltGlyphElement::create): Added.
              * svg/SVGAltGlyphElement.h:
              * svg/SVGAnimateColorElement.cpp:
              (WebCore::SVGAnimateColorElement::create): Added.
              * svg/SVGAnimateColorElement.h:
              * svg/SVGAnimateElement.cpp:
              (WebCore::SVGAnimateElement::create): Added.
              * svg/SVGAnimateElement.h:
              * svg/SVGAnimateMotionElement.cpp:
              (WebCore::SVGAnimateMotionElement::create): Added.
              * svg/SVGAnimateMotionElement.h:
              * svg/SVGAnimateTransformElement.cpp:
              (WebCore::SVGAnimateTransformElement::create): Added.
              * svg/SVGAnimateTransformElement.h:
              * svg/SVGCircleElement.cpp:
              (WebCore::SVGCircleElement::create): Added.
              * svg/SVGCircleElement.h:
              * svg/SVGClipPathElement.cpp:
              (WebCore::SVGClipPathElement::create): Added.
              * svg/SVGClipPathElement.h:
              * svg/SVGCursorElement.cpp:
              (WebCore::SVGCursorElement::create): Added.
              * svg/SVGCursorElement.h:
              * svg/SVGDefsElement.cpp:
              (WebCore::SVGDefsElement::create): Added.
              * svg/SVGDefsElement.h:
              * svg/SVGDescElement.cpp:
              (WebCore::SVGDescElement::create): Added.
              * svg/SVGDescElement.h:
              * svg/SVGEllipseElement.cpp:
              (WebCore::SVGEllipseElement::create): Added.
              * svg/SVGEllipseElement.h:
              * svg/SVGFEBlendElement.cpp:
              (WebCore::SVGFEBlendElement::create): Added.
              * svg/SVGFEBlendElement.h:
              * svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::create): Added.
              * svg/SVGFEColorMatrixElement.h:
              * svg/SVGFEComponentTransferElement.cpp:
              (WebCore::SVGFEComponentTransferElement::create): Added.
              * svg/SVGFEComponentTransferElement.h:
              * svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::create): Added.
              * svg/SVGFECompositeElement.h:
              * svg/SVGFEConvolveMatrixElement.cpp:
              (WebCore::SVGFEConvolveMatrixElement::create): Added.
              * svg/SVGFEConvolveMatrixElement.h:
              * svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::create): Added.
              * svg/SVGFEDiffuseLightingElement.h:
              * svg/SVGFEDisplacementMapElement.cpp:
              (WebCore::SVGFEDisplacementMapElement::create): Added.
              * svg/SVGFEDisplacementMapElement.h:
              * svg/SVGFEDistantLightElement.cpp:
              (WebCore::SVGFEDistantLightElement::create): Added.
              * svg/SVGFEDistantLightElement.h:
              * svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::create): Added.
              * svg/SVGFEFloodElement.h:
              * svg/SVGFEFuncAElement.cpp:
              (WebCore::SVGFEFuncAElement::create): Added.
              * svg/SVGFEFuncAElement.h:
              * svg/SVGFEFuncBElement.cpp:
              (WebCore::SVGFEFuncBElement::create): Added.
              * svg/SVGFEFuncBElement.h:
              * svg/SVGFEFuncGElement.cpp:
              (WebCore::SVGFEFuncGElement::create): Added.
              * svg/SVGFEFuncGElement.h:
              * svg/SVGFEFuncRElement.cpp:
              (WebCore::SVGFEFuncRElement::create): Added.
              * svg/SVGFEFuncRElement.h:
              * svg/SVGFEGaussianBlurElement.cpp:
              (WebCore::SVGFEGaussianBlurElement::create): Added.
              * svg/SVGFEGaussianBlurElement.h:
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::create): Added.
              * svg/SVGFEImageElement.h:
              * svg/SVGFEMergeElement.cpp:
              (WebCore::SVGFEMergeElement::create): Added.
              * svg/SVGFEMergeElement.h:
              * svg/SVGFEMergeNodeElement.cpp:
              (WebCore::SVGFEMergeNodeElement::create): Added.
              * svg/SVGFEMergeNodeElement.h:
              * svg/SVGFEMorphologyElement.cpp:
              (WebCore::SVGFEMorphologyElement::create): Added.
              * svg/SVGFEMorphologyElement.h:
              * svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::create): Added.
              * svg/SVGFEOffsetElement.h:
              * svg/SVGFEPointLightElement.cpp:
              (WebCore::SVGFEPointLightElement::create): Added.
              * svg/SVGFEPointLightElement.h:
              * svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::create): Added.
              * svg/SVGFESpecularLightingElement.h:
              * svg/SVGFESpotLightElement.cpp:
              (WebCore::SVGFESpotLightElement::create): Added.
              * svg/SVGFESpotLightElement.h:
              * svg/SVGFETileElement.cpp:
              (WebCore::SVGFETileElement::create): Added.
              * svg/SVGFETileElement.h:
              * svg/SVGFETurbulenceElement.cpp:
              (WebCore::SVGFETurbulenceElement::create): Added.
              * svg/SVGFETurbulenceElement.h:
              * svg/SVGFilterElement.cpp:
              (WebCore::SVGFilterElement::create): Added.
              * svg/SVGFilterElement.h:
              * svg/SVGFontElement.cpp:
              (WebCore::SVGFontElement::create): Added.
              * svg/SVGFontElement.h:
              * svg/SVGFontFaceElement.cpp:
              (WebCore::SVGFontFaceElement::create): Added.
              * svg/SVGFontFaceElement.h:
              * svg/SVGFontFaceFormatElement.cpp:
              (WebCore::SVGFontFaceFormatElement::create): Added.
              * svg/SVGFontFaceFormatElement.h:
              * svg/SVGFontFaceNameElement.cpp:
              (WebCore::SVGFontFaceNameElement::create): Added.
              * svg/SVGFontFaceNameElement.h:
              * svg/SVGFontFaceSrcElement.cpp:
              (WebCore::SVGFontFaceSrcElement::create): Added.
              * svg/SVGFontFaceSrcElement.h:
              * svg/SVGFontFaceUriElement.cpp:
              (WebCore::SVGFontFaceUriElement::create): Added.
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGForeignObjectElement.cpp:
              (WebCore::SVGForeignObjectElement::create): Added.
              * svg/SVGForeignObjectElement.h:
              * svg/SVGGElement.cpp:
              (WebCore::SVGGElement::create): Added.
              * svg/SVGGElement.h:
              * svg/SVGGlyphElement.cpp:
              (WebCore::SVGGlyphElement::create): Added.
              * svg/SVGGlyphElement.h:
              * svg/SVGHKernElement.cpp:
              (WebCore::SVGHKernElement::create): Added.
              * svg/SVGHKernElement.h:
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::create): Added.
              * svg/SVGImageElement.h:
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::create): Added.
              * svg/SVGLineElement.h:
              * svg/SVGLinearGradientElement.cpp:
              (WebCore::SVGLinearGradientElement::create): Added.
              * svg/SVGLinearGradientElement.h:
              * svg/SVGMPathElement.cpp:
              (WebCore::SVGMPathElement::create): Added.
              * svg/SVGMPathElement.h:
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::create): Added.
              * svg/SVGMarkerElement.h:
              * svg/SVGMaskElement.cpp:
              (WebCore::SVGMaskElement::create): Added.
              * svg/SVGMaskElement.h:
              * svg/SVGMetadataElement.cpp:
              (SVGMetadataElement::create): Added.
              * svg/SVGMetadataElement.h:
              * svg/SVGMissingGlyphElement.cpp:
              (WebCore::SVGMissingGlyphElement::create): Added.
              * svg/SVGMissingGlyphElement.h:
              * svg/SVGPathElement.cpp:
              (WebCore::SVGPathElement::create): Added.
              * svg/SVGPathElement.h:
              * svg/SVGPatternElement.cpp:
              (WebCore::SVGPatternElement::create): Added.
              * svg/SVGPatternElement.h:
              * svg/SVGPolygonElement.cpp:
              (WebCore::SVGPolygonElement::create): Added.
              * svg/SVGPolygonElement.h:
              * svg/SVGPolylineElement.cpp:
              (WebCore::SVGPolylineElement::create): Added.
              * svg/SVGPolylineElement.h:
              * svg/SVGRadialGradientElement.cpp:
              (WebCore::SVGRadialGradientElement::create): Added.
              * svg/SVGRadialGradientElement.h:
              * svg/SVGRectElement.cpp:
              (WebCore::SVGRectElement::create): Added.
              * svg/SVGRectElement.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::create): Added.
              * svg/SVGSVGElement.h:
              * svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::create): Added.
              * svg/SVGScriptElement.h:
              * svg/SVGSetElement.cpp:
              (WebCore::SVGSetElement::create): Added.
              * svg/SVGSetElement.h:
              * svg/SVGStopElement.cpp:
              (WebCore::SVGStopElement::create): Added.
              * svg/SVGStopElement.h:
              (WebCore::SVGStyleElement::create): Added.
              * svg/SVGStyleElement.h:
              * svg/SVGSwitchElement.cpp:
              (WebCore::SVGSwitchElement::create): Added.
              * svg/SVGSwitchElement.h:
              * svg/SVGSymbolElement.cpp:
              (WebCore::SVGSymbolElement::create): Added.
              * svg/SVGSymbolElement.h:
              * svg/SVGTRefElement.cpp:
              (WebCore::SVGTRefElement::create): Added.
              * svg/SVGTRefElement.h:
              * svg/SVGTSpanElement.cpp:
              (WebCore::SVGTSpanElement::create): Added.
              * svg/SVGTSpanElement.h:
              * svg/SVGTextContentElement.h:
              * svg/SVGTextElement.cpp:
              (WebCore::SVGTextElement::create): Added.
              * svg/SVGTextElement.h:
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::create): Added.
              * svg/SVGTextPathElement.h:
              * svg/SVGTextPositioningElement.h:
              * svg/SVGTitleElement.cpp:
              (WebCore::SVGTitleElement::create): Added.
              * svg/SVGTitleElement.h:
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::create): Added.
              * svg/SVGUseElement.h:
              * svg/SVGVKernElement.cpp:
              (WebCore::SVGVKernElement::create): Added.
              * svg/SVGVKernElement.h:
              * svg/SVGViewElement.cpp:
              (WebCore::SVGViewElement::create): Added.
              * svg/SVGViewElement.h:
              * wml/WMLAElement.cpp:
              (WebCore::WMLAElement::create): Added.
              * wml/WMLAElement.h:
              * wml/WMLAccessElement.cpp:
              (WebCore::WMLAccessElement::create): Added.
              * wml/WMLAccessElement.h:
              * wml/WMLAnchorElement.cpp:
              (WebCore::WMLAnchorElement::create): Added.
              * wml/WMLAnchorElement.h:
              * wml/WMLBRElement.cpp:
              (WebCore::WMLBRElement::create): Added.
              * wml/WMLBRElement.h:
              * wml/WMLCardElement.cpp:
              (WebCore::WMLCardElement::create): Added.
              * wml/WMLCardElement.h:
              * wml/WMLDoElement.cpp:
              (WebCore::WMLDoElement::create): Added.
              * wml/WMLDoElement.h:
              * wml/WMLFieldSetElement.cpp:
              (WebCore::WMLFieldSetElement::create): Added.
              * wml/WMLFieldSetElement.h:
              * wml/WMLFormControlElement.cpp:
              (WebCore::WMLFormControlElement::create): Added.
              * wml/WMLGoElement.cpp:
              (WebCore::WMLGoElement::create): Added.
              * wml/WMLGoElement.h:
              * wml/WMLImageElement.cpp:
              (WebCore::WMLImageElement::create): Added.
              * wml/WMLImageElement.h:
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::create): Added.
              * wml/WMLInputElement.h:
              * wml/WMLInsertedLegendElement.cpp:
              (WebCore::WMLInsertedLegendElement::create): Added.
              * wml/WMLInsertedLegendElement.h:
              * wml/WMLIntrinsicEvent.cpp:
              (WebCore::WMLIntrinsicEvent::create): Added.
              * wml/WMLMetaElement.cpp:
              (WebCore::WMLMetaElement::create): Added.
              * wml/WMLMetaElement.h:
              * wml/WMLNoopElement.cpp:
              (WebCore::WMLNoopElement::create): Added.
              * wml/WMLNoopElement.h:
              * wml/WMLOnEventElement.cpp:
              (WebCore::WMLOnEventElement::create): Added.
              * wml/WMLOnEventElement.h:
              * wml/WMLOptGroupElement.cpp:
              (WebCore::WMLOptGroupElement::create): Added.
              * wml/WMLOptGroupElement.h:
              * wml/WMLOptionElement.cpp:
              (WebCore::WMLOptionElement::create): Added.
              * wml/WMLOptionElement.h:
              * wml/WMLPElement.cpp:
              (WebCore::WMLPElement::create): Added.
              * wml/WMLPElement.h:
              * wml/WMLPostfieldElement.cpp:
              (WebCore::WMLPostfieldElement::create): Added.
              * wml/WMLPostfieldElement.h:
              * wml/WMLPrevElement.cpp:
              (WebCore::WMLPrevElement::create): Added.
              * wml/WMLPrevElement.h:
              * wml/WMLRefreshElement.cpp:
              (WebCore::WMLRefreshElement::create): Added.
              * wml/WMLRefreshElement.h:
              * wml/WMLSelectElement.cpp:
              (WebCore::WMLSelectElement::create): Added.
              * wml/WMLSelectElement.h:
              * wml/WMLSetvarElement.cpp:
              (WebCore::WMLSetvarElement::create): Added.
              * wml/WMLSetvarElement.h:
              * wml/WMLTableElement.cpp:
              (WebCore::WMLTableElement::create): Added.
              * wml/WMLTableElement.h:
              * wml/WMLTaskElement.cpp:
              (WebCore::WMLTaskElement::create): Added.
              * wml/WMLTaskElement.h:
              * wml/WMLTemplateElement.cpp:
              (WebCore::WMLTemplateElement::create): Added.
              * wml/WMLTemplateElement.h:
              * wml/WMLTimerElement.cpp:
              (WebCore::WMLTimerElement::create): Added.
              * wml/WMLTimerElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cbd5cb5
    • tkent@chromium.org's avatar
      Unreviewed, add missing bug URL for the last my commit. · 90a94dfc
      tkent@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90a94dfc
    • tkent@chromium.org's avatar
      2010-08-29 Marc-Antoine Ruel <maruel@chromium.org> · 83b38661
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              Rename webcore to 'webcore_remaining'.
              Create a meta-target webcore that inherits from every webcore_XXX targets. (Currently 1)
              Move direct_dependent_settings and export_dependent_settings from webcore_remaining to webcore
      
              Obviously, there will be other webcore_XXX targets. Keeping the change as small as possible.
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83b38661
    • abarth@webkit.org's avatar
      2010-08-29 Adam Barth <abarth@webkit.org> · 64ee2fbe
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Move UTF16 LEAD/TRAIL logic into the HTMLEntityParser
              https://bugs.webkit.org/show_bug.cgi?id=44790
      
              We now block this attack.
      
              * http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ee2fbe
    • jeremy@chromium.org's avatar
      2010-08-29 Jeremy Moskovich <jeremy@chromium.org> · 911c44f2
      jeremy@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              First step in unforking Chrome's FontPlatformDataMac.mm.
              Move files from platform/graphics/mac to platform/graphics/cocoa
      
              https://bugs.webkit.org/show_bug.cgi?id=41398
      
              Just moving files around so no new tests.
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/chromium/FontPlatformDataChromiumMac.mm:
              * platform/graphics/cocoa/FontPlatformData.h: Copied from WebCore/platform/graphics/mac/FontPlatformData.h.
              * platform/graphics/cocoa/FontPlatformDataCocoa.mm: Copied from WebCore/platform/graphics/mac/FontPlatformDataMac.mm.
              * platform/graphics/mac/FontPlatformData.h: Removed.
              * platform/graphics/mac/FontPlatformDataMac.mm: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      911c44f2
    • tkent@chromium.org's avatar
      Introduce isValidValue(const String&) of HTMLInputElement and HTMLTextAreaElement · 994e7d38
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=43537
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      isValidValue() is useful for browser implementations to propose
      form field values without breaking form validity.
      No new tests because these functions are not exposed to JavaScript.
      
      * html/HTMLFormControlElement.h:
      (WebCore::HTMLTextFormControlElement::):
       Remove virtual valueMissing(), patternMismatch(), and tooLong().
      * html/HTMLInputElement.cpp:
      (WebCore::isValidColorString): Moved from ValidityState.
      (WebCore::isValidEmailAddress): ditto.
      (WebCore::HTMLInputElement::isValidValue): Added.
      (WebCore::HTMLInputElement::typeMismatch): Add a String parameter.
      (WebCore::HTMLInputElement::valueMissing): Add a String parameter.
      (WebCore::HTMLInputElement::patternMismatch): Add a String parameter.
      (WebCore::HTMLInputElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
      (WebCore::HTMLInputElement::rangeUnderflow): Add a String parameter.
      (WebCore::HTMLInputElement::rangeOverflow): Add a String parameter.
      (WebCore::HTMLInputElement::stepMismatch): Add a String parameter.
      * html/HTMLInputElement.h:
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
      (WebCore::HTMLTextAreaElement::isValidValue): Added.
      * html/HTMLTextAreaElement.h:
      (WebCore::HTMLTextAreaElement::valueMissing):
      * html/ValidityState.cpp:
      (WebCore::ValidityState::valueMissing): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
      (WebCore::ValidityState::typeMismatch): Passes value() to HTMLInputElement::typeMismatch().
      (WebCore::ValidityState::patternMismatch): Calls patternMismatch() of HTMLInputElement.
      (WebCore::ValidityState::tooLong): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
      (WebCore::ValidityState::rangeUnderflow): Passes value() to HTMLInputElement::rangeUnderflow().
      (WebCore::ValidityState::rangeOverflow): Passes value() to HTMLInputElement::rangeUnderflow().
      (WebCore::ValidityState::stepMismatch): Passes value() to HTMLInputElement::stepMismatch().
      * html/ValidityState.h:
      
      WebKit/chromium:
      
      * public/WebInputElement.h:
      * src/WebInputElement.cpp:
      (WebKit::WebInputElement::isValidValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      994e7d38
    • yuzo@google.com's avatar
      2010-08-29 Yuzo Fujishima <yuzo@google.com> · 7829f9f4
      yuzo@google.com authored
              Unreviewed Chromium test expectation change for r66282.
      
              * platform/chromium-win/inspector/console-format-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7829f9f4
    • tkent@chromium.org's avatar
      Change lower and higher limits of date/datetime/datetime-local/month/week types · cff83f5c
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39737
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      According to the latest draft of HTML5, ISO-8601 dates in HTML5
      should support A.D.0001 in Gregorian calendar though Gregorian
      calendar started in 1582. So, we change the lower limits of
      date&time types to 0001-01-01T00:00.
      
      We also introduce the common higher limit, 275760-09-13T00:00. It
      is the higher limit of Date type of ECMAScript.
      
      * html/DateComponents.cpp:
      (WebCore::DateComponents::parseYear):
       Rejects years less than A.D.1 and years greater than 275760.
      (WebCore::withinHTMLDateLimits):
       Helper functions to check lower and higher limits.
      (WebCore::DateComponents::addDay):
       - Remove an overflow check. 'year' can't be so large number because
         parseYear() rejects such numbers.
       - Add withinHTMLDateLimits() calls.
      (WebCore::DateComponents::addMinute):
       - Add an assertion for the base date.
       - Add withinHTMLDateLimits() calls.
      (WebCore::DateComponents::parseMonth):
       Add withinHTMLDateLimits() call.
      (WebCore::DateComponents::parseDate): ditto.
      (WebCore::DateComponents::parseWeek): ditto.
      (WebCore::DateComponents::parseDateTimeLocal): ditto.
      (WebCore::DateComponents::parseDateTime): ditto.
      (WebCore::DateComponents::setMillisecondsSinceEpochForDate): ditto.
      (WebCore::DateComponents::setMillisecondsSinceEpochForDateTime): ditto.
      (WebCore::DateComponents::setMillisecondsSinceEpochForMonth): ditto.
      (WebCore::DateComponents::setMonthsSinceEpoch):
       Add year range check and withinHTMLDateLimits() call.
      (WebCore::DateComponents::setMillisecondsSinceEpochForWeek):
       Add year range check and week range check.
      * html/DateComponents.h:
       Update minimum/maximum constant values.
      (WebCore::DateComponents::minimumDate):
      (WebCore::DateComponents::minimumDateTime):
      (WebCore::DateComponents::minimumMonth):
      (WebCore::DateComponents::minimumWeek):
      (WebCore::DateComponents::maximumDate):
      (WebCore::DateComponents::maximumDateTime):
      (WebCore::DateComponents::maximumMonth):
      (WebCore::DateComponents::maximumWeek):
      
      LayoutTests:
      
      Update tests and test results for the new DateComponents behavior.
      
      * fast/forms/ValidityState-rangeOverflow-expected.txt:
      * fast/forms/ValidityState-stepMismatch-expected.txt:
      * fast/forms/ValidityState-typeMismatch-date-expected.txt:
      * fast/forms/ValidityState-typeMismatch-datetime-expected.txt:
      * fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt:
      * fast/forms/ValidityState-typeMismatch-month-expected.txt:
      * fast/forms/ValidityState-typeMismatch-week-expected.txt:
      * fast/forms/input-valueasdate-date-expected.txt:
      * fast/forms/input-valueasdate-datetime-expected.txt:
      * fast/forms/input-valueasdate-month-expected.txt:
      * fast/forms/input-valueasdate-week-expected.txt:
      * fast/forms/input-valueasnumber-date-expected.txt:
      * fast/forms/input-valueasnumber-datetime-expected.txt:
      * fast/forms/input-valueasnumber-datetimelocal-expected.txt:
      * fast/forms/input-valueasnumber-month-expected.txt:
      * fast/forms/input-valueasnumber-week-expected.txt:
      * fast/forms/script-tests/ValidityState-rangeOverflow.js:
      * fast/forms/script-tests/ValidityState-stepMismatch.js:
      * fast/forms/script-tests/ValidityState-typeMismatch-date.js:
      * fast/forms/script-tests/ValidityState-typeMismatch-datetime.js:
      * fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js:
      * fast/forms/script-tests/ValidityState-typeMismatch-month.js:
      * fast/forms/script-tests/ValidityState-typeMismatch-week.js:
      * fast/forms/script-tests/input-valueasdate-date.js:
      * fast/forms/script-tests/input-valueasdate-datetime.js:
      * fast/forms/script-tests/input-valueasdate-month.js:
      * fast/forms/script-tests/input-valueasdate-week.js:
      * fast/forms/script-tests/input-valueasnumber-date.js:
      * fast/forms/script-tests/input-valueasnumber-datetime.js:
      * fast/forms/script-tests/input-valueasnumber-datetimelocal.js:
      * fast/forms/script-tests/input-valueasnumber-month.js:
      * fast/forms/script-tests/input-valueasnumber-week.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cff83f5c
    • yuzo@google.com's avatar
      2010-08-29 Yuzo Fujishima <yuzo@google.com> · 725b1869
      yuzo@google.com authored
              Unreviewed Chromium test expectation change for r66296.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      725b1869
    • commit-queue@webkit.org's avatar
      2010-08-29 James Robinson <jamesr@chromium.org> · adc95c44
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Make failing the download step fail the build
              https://bugs.webkit.org/show_bug.cgi?id=44298
      
              If the download step fails on a test bot, this ensures that
              the build goes red instead of only the download step going red
              and the overall build staying green.
      
              * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adc95c44
    • yuzo@google.com's avatar
      2010-08-29 Yuzo Fujishima <yuzo@google.com> · 678043f8
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      678043f8
    • tkent@chromium.org's avatar
      2010-08-29 Kent Tamura <tkent@chromium.org> · eb9a413d
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Remove dependency to base/keyboard_codes.h
              https://bugs.webkit.org/show_bug.cgi?id=44847
      
              * DEPS: Roll Chromium revision to 57823 to have a webkit_support change.
      2010-08-29  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Remove dependency to base/keyboard_codes.h
              https://bugs.webkit.org/show_bug.cgi?id=44847
      
              * DumpRenderTree/chromium/EventSender.cpp:
               Use webkit_support::VKEY_* instead of base::VKEY_*.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb9a413d
    • darin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=40589 · 3dd064f1
      darin@apple.com authored
      * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
      function names.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3dd064f1
    • yuzo@google.com's avatar
      2010-08-29 Yuzo Fujishima <yuzo@google.com> · 12345a71
      yuzo@google.com authored
              Unreviewed Chromium test expectation change for r66306.
      
              * platform/chromium-linux/fast/forms/form-added-to-table-expected.txt: Added.
              * platform/chromium-linux/fast/forms/formmove3-expected.checksum:
              * platform/chromium-linux/fast/forms/formmove3-expected.png:
              * platform/chromium-linux/fast/forms/formmove3-expected.txt:
              * platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
              * platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
              * platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.
              * platform/chromium-linux/fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
              * platform/chromium-linux/fast/table/inline-form-assert-expected.txt: Added.
              * platform/chromium-linux/fast/table/insert-cell-before-form-expected.txt: Added.
              * platform/chromium-linux/fast/table/insert-row-before-form-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
              * platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.txt:
              * platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.png: Removed.
              * platform/chromium-linux/tables/mozilla/bugs/bug2516-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.png:
              * platform/chromium-linux/tables/mozilla/bugs/bug30559-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png: Removed.
              * platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png: Removed.
              * platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Removed.
              * platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug78162-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
              * platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.txt:
              * platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
              * platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
              * platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.txt: Added.
              * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
              * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
              * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
              * platform/chromium-mac/fast/forms/formmove3-expected.checksum: Removed.
              * platform/chromium-mac/fast/forms/formmove3-expected.png: Removed.
              * platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Removed.
              * platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum: Added.
              * platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.checksum: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug2516-expected.png: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.checksum: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.checksum: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug32447-expected.png: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.checksum: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug34538-expected.png: Removed.
              * platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum: Added.
              * platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Added.
              * platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Added.
              * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum: Removed.
              * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
              * platform/chromium-win/fast/forms/form-added-to-table-expected.txt:
              * platform/chromium-win/fast/forms/formmove3-expected.checksum:
              * platform/chromium-win/fast/forms/formmove3-expected.png:
              * platform/chromium-win/fast/forms/formmove3-expected.txt:
              * platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.checksum:
              * platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.png:
              * platform/chromium-win/fast/forms/preserveFormDuringResidualStyle-expected.txt:
              * platform/chromium-win/fast/table/fixed-table-non-cell-in-row-expected.txt:
              * platform/chromium-win/fast/table/inline-form-assert-expected.txt:
              * platform/chromium-win/fast/table/insert-cell-before-form-expected.txt:
              * platform/chromium-win/fast/table/insert-row-before-form-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug1318-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug1318-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug1318-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug2516-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug2516-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug2516-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug30559-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug30559-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug30559-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug32447-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug32447-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug32447-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug34538-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug34538-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug34538-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug4527-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug4527-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug78162-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug96334-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug96334-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug96343-expected.checksum:
              * platform/chromium-win/tables/mozilla/bugs/bug96343-expected.png:
              * platform/chromium-win/tables/mozilla/bugs/bug96343-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.checksum:
              * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
              * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12345a71
    • commit-queue@webkit.org's avatar
      2010-08-29 Kwang Yul Seo <skyul@company100.net> · 9bb605b0
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              [BREWMP] Port SharedBuffer::createWithContentsOfFile
              https://bugs.webkit.org/show_bug.cgi?id=34412
      
              Implement SharedBuffer::createWithContentsOfFile with IFile.
      
              * platform/brew/SharedBufferBrew.cpp: Added.
              (WebCore::SharedBuffer::createWithContentsOfFile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bb605b0
    • zecke@webkit.org's avatar
      [iExploder] Add new CSS Properties and HTML Attributes · 007e13d3
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44746
      
      Updated the files with the update-iexploder-cssproperties script
      and manually readded the -webkit-binding CSS Property to the list.
      
      * iExploder/htdocs/cssproperties.in:
      * iExploder/htdocs/htmlattrs.in:
      * iExploder/htdocs/htmltags.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      007e13d3
    • zecke@webkit.org's avatar
      Fix Coverage build after the addition of ANGLE · f3c45570
      zecke@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=44744
      
      ANGLE is using libtool to build a static library and the version of
      libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
      parameters. The easiest way to handle this is to not build ANGLE with
      coverage information.
      
      This is achieved by applying the XCode options for each project
      separately and exclude ANGLE.
      
      * Scripts/build-webkit: Remove -framework AppKit due link errors.
      * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3c45570
    • commit-queue@webkit.org's avatar
      2010-08-29 Kwang Yul Seo <skyul@company100.net> · 01aa7da8
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              [BREWMP] Port vprintf_stderr_common
              https://bugs.webkit.org/show_bug.cgi?id=33568
      
              Use BREW's DBGPRINTF to output debug messages.
      
              * wtf/Assertions.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01aa7da8
    • enrica@apple.com's avatar
      WebCore: Crash when dragging text in Google Docs · 5eea7a83
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=20471
      <rdar://problem/7783629>
              
      Reviewed by Adele Peterson.
      
      This fixes the crash but also fixes the generated markup when
      performing a replacement at the border with an inline, to avoid the 
      new content being merged into the inline.
      The crash is happening when doApply detects the need of merging
      the start and the end of the new paragraph and the destination position
      is moved inside an inline.
              
      I've added new test cases to an existing layout test.
              
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::ReplaceSelectionCommand::doApply): When the situation described above is detected,
      we insert a placeholder to avoid merging into the inline.
      
      LayoutTests: Crash when dragging text in Google Docs
      https://bugs.webkit.org/show_bug.cgi?id=20471
      <rdar://problem/7783629>
      
      Reviewed by Adele Peterson.
      
      Added new test cases to an exisisting file and updated the result to reflect
      the correct behavior.
              
      * editing/selection/replace-selection-crash-expected.txt:
      * editing/selection/replace-selection-crash.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eea7a83
    • abarth@webkit.org's avatar
      2010-08-29 Adam Barth <abarth@webkit.org> · 63038daf
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Implement HTML5's fakepath
              https://bugs.webkit.org/show_bug.cgi?id=29000
      
              Update expectations for this pasteboard test to include our new friend
              fakepath.
      
              * editing/pasteboard/file-input-files-access-expected.txt:
      2010-08-29  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              Implement HTML5's fakepath
              https://bugs.webkit.org/show_bug.cgi?id=29000
      
              The HTML 5 spec says to prepend C:\fakepath\ to the value of an
              <input type="file"> control, so that's what we do now.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::value):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63038daf
    • commit-queue@webkit.org's avatar
      2010-08-29 Sheriff Bot <webkit.review.bot@gmail.com> · 7eda5f55
      commit-queue@webkit.org authored
              Unreviewed, rolling out r66329.
              http://trac.webkit.org/changeset/66329
              https://bugs.webkit.org/show_bug.cgi?id=44845
      
              broke chromium mac (Requested by jamesr on #webkit).
      
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/mac/FontPlatformData.h: Renamed from WebCore/platform/graphics/cocoa/FontPlatformData.h.
              (WebCore::toCTFontRef):
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::FontPlatformData::isHashTableDeletedValue):
              (WebCore::FontPlatformData::size):
              (WebCore::FontPlatformData::syntheticBold):
              (WebCore::FontPlatformData::syntheticOblique):
              (WebCore::FontPlatformData::hash):
              (WebCore::FontPlatformData::operator==):
              (WebCore::FontPlatformData::font):
              (WebCore::FontPlatformData::isColorBitmapFont):
              (WebCore::FontPlatformData::cgFont):
              (WebCore::FontPlatformData::hashTableDeletedFontValue):
              * platform/graphics/mac/FontPlatformDataMac.mm: Renamed from WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm.
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::~FontPlatformData):
              (WebCore::FontPlatformData::operator=):
              (WebCore::FontPlatformData::setFont):
              (WebCore::FontPlatformData::roundsGlyphAdvances):
              (WebCore::FontPlatformData::allowsLigatures):
              (WebCore::FontPlatformData::ctFont):
              (WebCore::FontPlatformData::description):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eda5f55
    • abarth@webkit.org's avatar
      2010-08-29 Adam Barth <abarth@webkit.org> · 7579ac83
      abarth@webkit.org authored
              Attempt to make Sam's life easier by not opening a comment text field
              if there's a selection.  This should make it easier to copy/paste text
              out of the diff without accidentally opening comment boxes.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7579ac83
  2. 29 Aug, 2010 8 commits
    • commit-queue@webkit.org's avatar
      2010-08-29 Mihai Parparita <mihaip@chromium.org> · acc4bb37
      commit-queue@webkit.org authored
              Reviewed by Tony Chang.
      
              fast/loader/input-element-page-cache-crash.html fails on Chromium
              https://bugs.webkit.org/show_bug.cgi?id=44811
      
              Make test not rely on page cache behavior (window.finishTest being
              persisted), instead use sessionStorage.
      
              * fast/loader/input-element-page-cache-crash.html:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acc4bb37
    • simon.fraser@apple.com's avatar
      2010-08-29 Simon Fraser <simon.fraser@apple.com> · 26785dd4
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              When properties are missing from animation keyframes, interpolate between those keyframes that specify them
              https://bugs.webkit.org/show_bug.cgi?id=40794
      
              When a property does not appear in all keyframes of a keyframe animation, we currently use the
              value of that property from the unanimated style. That forces the author to use additional
              keyframes for properties that need to "skip a keyframe", which is laborious.
      
              With this change, properties are interpolated between the keyframes in which they appear.
              This is equivalent to splitting each property out into its own set of keyframes.
      
              Tests: animations/missing-keyframe-properties-repeating.html
                     animations/missing-keyframe-properties-timing-function.html
                     animations/missing-keyframe-properties.html
      
              * css/CSSStyleSelector.h:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::styleForKeyframe): Pass a KeyframeValue in so that we can
              collect which properties are represented per keyframe.
              (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Keyframes are inserted into a
              KeyframeList by object now, rather than by key and style.
      
              * page/animation/AnimationBase.cpp:
              (WebCore::AnimationBase::progress): Use AnimationDirectionAlternate for readability.
      
              * page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): Renamed from getKeyframeAnimationInterval.
              Use fractionalTime etc to match AnimationBase::progress(), and do lookups per-property.
              Simplify the code that finds the relevant keyframe to do less work.
              (WebCore::KeyframeAnimation::animate): Call fetchIntervalEndpointsForProperty() for each property, rather than just once for the
              entire keyframe.
              (WebCore::KeyframeAnimation::getAnimatedStyle): Ditto.
              (WebCore::KeyframeAnimation::hasAnimationForProperty): FIXME comment.
      
              * page/animation/KeyframeAnimation.h: Rename getKeyframeAnimationInterval() to fetchIntervalEndpointsForProperty().
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::startAnimation): For hardware animations, only insert values
              for keyframes which contain the property.
      
              (WebCore::KeyframeList::KeyframeList): insert() takes a KeyframeValue now.
              * rendering/style/KeyframeList.cpp:
              (WebCore::KeyframeList::operator==):
              (WebCore::KeyframeList::insert): Fix insert/replace logic, and ensure we maintain the
              m_properties hash.
      
              * rendering/style/KeyframeList.h:
              (WebCore::KeyframeValue::KeyframeValue): Make members private, with accessors.
              Add a m_properties HashSet for the properties animated in this keyframe.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26785dd4
    • ossy@webkit.org's avatar
      2010-08-29 Csaba Osztrogonác <ossy@webkit.org> · 9ed15db2
      ossy@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION(r66324): Fix warnings in editing/ApplyStyleCommand.cpp
              https://bugs.webkit.org/show_bug.cgi?id=44843
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Suggested parentheses added around && within ||
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ed15db2
    • darin@apple.com's avatar
      Try to fix Mac build. · 91543431
      darin@apple.com authored
      * WebCore.xcodeproj/project.pbxproj: Mark CounterContent.h Private instead of Project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91543431
    • commit-queue@webkit.org's avatar
      2010-08-29 Pawel Hajdan <phajdan.jr@chromium.org> · ec642618
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Fix libxml workarounds to work with recent versions of libxml.
              I was testing locally with libxml2-2.7.6.
              https://bugs.webkit.org/show_bug.cgi?id=30508
      
              Based on patch by Philippe Normand <pnormand@igalia.com>.
      
              This also fixes a Chromium bug:
              http://code.google.com/p/chromium/issues/detail?id=29333
      
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::switchToUTF16):
              (WebCore::XMLParserContext::createStringParser):
              (WebCore::XMLDocumentParser::doWrite):
              (WebCore::startDocumentHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec642618
    • darin@apple.com's avatar
      Try to fix Windows build. · 5355861b
      darin@apple.com authored
      * rendering/style/ContentData.h: Added include of CounterContent.h.
      
      * css/CSSStyleSelector.cpp: Removed include of CounterContent.h.
      * rendering/style/ContentData.cpp: Ditto.
      * rendering/style/RenderStyle.cpp: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5355861b
    • darin@apple.com's avatar
      2010-08-29 Darin Adler <darin@apple.com> · 3b8ced0a
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              Deploy OwnPtr, PassOwnPtr, and adoptPtr in some CSS-related files
              https://bugs.webkit.org/show_bug.cgi?id=44834
      
              * css/CSSFunctionValue.cpp:
              (WebCore::CSSFunctionValue::CSSFunctionValue): Updated since
              CSSParserFunction::args is an OwnPtr.
              (WebCore::CSSFunctionValue::parserValue): Ditto.
      
              * css/CSSGrammar.y: Added leakPtr calls for putting MediaQueryExp*
              into the media query expression list, which is a vector of raw pointers
              that are deleted explicitly.
      
              * css/CSSImportRule.cpp:
              (WebCore::CSSImportRule::setCSSStyleSheet): Updated to use document instead of doc.
              (WebCore::CSSImportRule::insertedIntoParent): Ditto.
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc): Ditto.
      
              * css/CSSNamespace.h: Took the "m_" off the names of the data members of
              this structure. Used OwnPtr for the parent data member. Rewrote the
              namespaceForPrefix function so it's iterative instead of recursive.
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser): Update since m_mediaQuery, m_floatingMediaQuery,
              m_floatingMediaQueryExp, and m_floatingMediaQueryExpList are now all OwnPtr and
              thus don't need to be initialized.
              (WebCore::CSSParser::~CSSParser): Update to not delete the above OwnPtr.
              (WebCore::CSSParser::parseMediaQuery): Replaced the code that sets m_mediaQuery
              to 0 with an assertion. Also use release when passing the media query to
              appendMediaQuery.
              (WebCore::CSSParser::document): Updated to use document instead of doc and to
              use early return instead of a nested if.
              (WebCore::CSSParser::parseContent): Added a get() call needed since
              CSSParserFunction::args is an OwnPtr.
              (WebCore::CSSParser::parseAnimationTimingFunction): Ditto.
              (WebCore::CSSParser::parseDashboardRegions): Ditto.
              (WebCore::CSSParser::parseShape): Ditto.
              (WebCore::isValidFormatFunction): Ditto.
              (WebCore::CSSParser::parseFontFaceSrc): Ditto.
              (WebCore::CSSParser::parseColorParameters): Ditto.
              (WebCore::CSSParser::parseHSLParameters): Ditto.
              (WebCore::parseGradientColorStop): Ditto.
              (WebCore::CSSParser::parseGradient): Ditto.
              (WebCore::CSSParser::parseCanvas): Ditto.
              (WebCore::CSSParser::parseTransform): Ditto.
              (WebCore::CSSParser::createFloatingMediaQueryExp): Updated to use adoptPtr and
              remove the explicit deletion.
              (WebCore::CSSParser::sinkFloatingMediaQueryExp): Updated to use release.
              (WebCore::CSSParser::createFloatingMediaQueryExpList): Ditto.
              (WebCore::CSSParser::sinkFloatingMediaQueryExpList): Ditto.
              (WebCore::CSSParser::createFloatingMediaQuery): Ditto.
              (WebCore::CSSParser::sinkFloatingMediaQuery): Ditto.
              (WebCore::CSSParser::checkForVariables): Use get for CSSParserFunction::args.
      
              * css/CSSParser.h: Made return values for sinkFloatingMediaQueryExp,
              sinkFloatingMediaQueryExpList, and sinkFloatingMediaQuery be PassOwnPtr.
              Made createFloatingMediaQuery take a PassOwnPtr. Made m_mediaQuery,
              m_floatingMediaQuery, m_floatingMediaQueryExp, and m_floatingMediaQueryExpList
              be OwnPtr.
      
              * css/CSSParserValues.h: Made args be an OwnPtr.
      
              * css/CSSStyleSelector.cpp: Made CSSRuleSet m_universalRules and m_pageRules
              be OwnPtr.
              (WebCore::CSSStyleSelector::CSSStyleSelector): Use document instead of doc.
              Got rid of the init function, only called here, because it did nothing that
              wasn't already done. Eliminated unneeded code to set m_userStyle to 0, since
              it's now an OwnPtr and will be 0 automatically. Use adoptPtr when initializing
              m_medium, m_authorStyle, and m_useStyle.
              (WebCore::CSSStyleSelector::~CSSStyleSelector): Got rid of unneeded delete of
              m_medium, m_authorStyle, and m_userStyle, and unneded clear of m_keyframesRuleMap.
              (WebCore::CSSStyleSelector::styleForElement): Use get with m_userStyle and
              m_authorStyle.
              (WebCore::CSSStyleSelector::pseudoStyleForElement): Ditto.
              (WebCore::CSSStyleSelector::styleForPage): Ditto.
              (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Ditto.
              (WebCore::CSSRuleSet::CSSRuleSet): Got rid of unneeded initialization of
              m_universalRules and m_pageRules.
              (WebCore::CSSRuleSet::~CSSRuleSet): Got rid of unneeed deletion of same.
              (WebCore::CSSRuleSet::addRule): Use adoptPtr to initialize m_universalRules.
              (WebCore::CSSRuleSet::addPageRule): Use adoptPtr to initialize m_pageRules.
              (WebCore::CSSStyleSelector::applyProperty): Use adopPtr to create counter
              context object.
      
              * css/CSSStyleSelector.h: Made m_authorStyle, m_userStyle, and m_medium use
              OwnPtr. Got rid of init function.
      
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::CSSStyleSheet): Updatd for name change from m_doc
              and doc to m_document and document. Eliminated unneeded initialization of
              m_namespaces now that it is an OwnPtr.
              (WebCore::CSSStyleSheet::~CSSStyleSheet): Got rid of unneeded deletion of same.
              (WebCore::CSSStyleSheet::cssRules): Updated doc to document.
              (WebCore::CSSStyleSheet::addNamespace): Added adopPtr when setting m_namespaces.
              (WebCore::CSSStyleSheet::determineNamespace): Updated for changes to the
              CSSNamespace class, using uri data member instead of function.
              (WebCore::CSSStyleSheet::styleSheetChanged): Use document instead of doc.
      
              * css/CSSStyleSheet.h: Renamed doc and m_doc to document and m_document.
              Made m_namespaces an OwnPtr.
      
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::CSSValueList): Clean up logic a bit.
              (WebCore::CSSValueList::createParserValueList): Clean up logic a bit and
              return a PassOwnPtr.
      
              * css/CSSValueList.h: Changed createParserValueList to return a PassOwnPtr.
      
              * css/CSSVariablesDeclaration.cpp:
              (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc): Updated to use
              document instead of doc.
      
              * css/MediaList.cpp:
              (WebCore::MediaList::deleteMedium): Use OwnPtr instead of a boolean to
              make sure the newly-created query here is deleted.
              (WebCore::MediaList::appendMediaQuery): Updated to take PassOwnPtr.
      
              * css/MediaList.h: Changed appendMediaQuery to take a PassOwnPtr.
      
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::getStyleSheet): Use document instead of doc.
              (WebCore::InspectorDOMAgent::getRuleRanges): Ditto.
              (WebCore::InspectorDOMAgent::buildObjectForStyleSheet): Ditto.
      
              * rendering/style/ContentData.cpp:
              (WebCore::ContentData::clear): Update since data members are OwnPtr.
              Also, fixed iterative deletion algorithm to be much simpler.
              (WebCore::ContentData::dataEquivalent): Added FIXMEs and tweaked formatting.
              (WebCore::ContentData::deleteContent): Tweaked formatting.
      
              * rendering/style/ContentData.h: Changed m_next to an OwnPtr.
              Added assertions to getters to check that we get the correct type.
              Use leakRef instead of releaseRef. Changed setCounter and setNext functions
              to take PassOwnPtr arguments.
      
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::prepareToSetContent): Refactored common part of the
              into a shared function so the three setContent functions don't have to repeat
              the logic. Used an OwnPtr to avoid confusing logic and leakPtr.
              (WebCore::RenderStyle::setContent): Changed argument to PassOwnPtr.
      
              * rendering/style/RenderStyle.h: Changed setContent argument to a PassOwnPtr.
              Added declaration of prepareToSetContent helper function.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b8ced0a
    • abarth@webkit.org's avatar
      2010-08-29 Adam Barth <abarth@webkit.org> · 46de86f9
      abarth@webkit.org authored
              Turns out we're supposed to use find instead of children here.
      
              * code-review.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46de86f9