1. 15 Aug, 2012 1 commit
    • ojan@chromium.org's avatar
      z-index should work without position on flexitems · a4039c89
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91405
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Require a layer on any RenderBox that has a non-auto z-index.
      Statically positioned, non-flex-item's have their z-index coerced to auto,
      so it's safe to check z-index unconditionally.
      
      Test: css3/flexbox/z-index.html
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::adjustRenderStyle):
      -Don't coerce z-index to auto on statically positioned flex-items.
      -Use the parentStyle to determine if the parent is a flexbox instead of
      looking at the element's parentNode's renderer.
      * rendering/RenderBox.h:
      -Add having a non-auto z-index to the list of things that require a layer.
      
      LayoutTests:
      
      * css3/flexbox/z-index-expected.html: Added.
      * css3/flexbox/z-index.html: Added.
      Use a ref-test since we want to be sure that the elements get painted in the right order.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4039c89
  2. 10 Aug, 2012 2 commits
    • ojan@chromium.org's avatar
      New test introduced in r125262 css3/flexbox/inline-flex-crash2.html fails · a100162e
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93718
      
      Test uses layoutTestController instead of testRunner.
      
      * css3/flexbox/inline-flex-crash2.html:
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a100162e
    • tony@chromium.org's avatar
      implement display: -webkit-inline-flex · bdd6383a
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77772
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      The crashes last time were because we were marking too much of the tree for relayout. During some editing
      operations, this causes a layout when we're in an inconsistent state.
      
      Tests: css3/flexbox/inline-flex-crash.html
             css3/flexbox/inline-flex-crash2.html
             css3/flexbox/inline-flex.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes): Only layout the child.
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Only layout the child.
      (WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Only layout the child.
      * rendering/style/RenderStyle.h: Include INLINE_FLEX as an inline and replaced display type.
      
      LayoutTests:
      
      Include 2 crash tests that caused this to be reverted the last time.
      
      * css3/flexbox/inline-flex-crash-expected.txt: Added.
      * css3/flexbox/inline-flex-crash.html: Added.
      * css3/flexbox/inline-flex-crash2-expected.txt: Added.
      * css3/flexbox/inline-flex-crash2.html: Added.
      * css3/flexbox/inline-flex-expected.html: Added.
      * css3/flexbox/inline-flex.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdd6383a
  3. 08 Aug, 2012 2 commits
    • tony@chromium.org's avatar
      css3/flexbox/content-height-with-scrollbars.html failing on non-fractional pixel layout machines · 6abef185
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93530
      
      Unreviewed, fixing the test to not depend on rounding behavior.
      
      * css3/flexbox/content-height-with-scrollbars-expected.html: Use a fixed width.
      * css3/flexbox/content-height-with-scrollbars.html: Use a fixed width.
      * platform/efl/TestExpectations: Remove failing expectation.
      * platform/gtk/TestExpectations: Remove failing expectation.
      * platform/mac/TestExpectations: Remove failing expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6abef185
    • ojan@chromium.org's avatar
      percentage height/width values in quirks mode are incorrectly resolved in flexbox children · 1c5ee94a
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81809
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      When computing percentage logical heights we need to use the RenderBox helper methods
      to make sure we handle all the edge cases correctly (e.g. walk up the containing block
      ancestor chain in quirks mode until we find a definite size).
      
      For widths, the containing block always has a definite size, so all we need to do
      is call computeContentBoxLogicalWidth(valueForLength(...)), although I'm not sure
      this does the right thing for the intrinsic sizing keywords.
      
      Tests: css3/flexbox/box-sizing-min-max-sizes.html
             css3/flexbox/percentage-sizes-quirks.html
             css3/flexbox/percentage-sizes.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeLogicalClientHeight):
      (WebCore):
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::computeMainAxisSizeForChild):
      (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
      (WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
      * rendering/RenderFlexibleBox.h:
      
      LayoutTests:
      
      * css3/flexbox/box-sizing-min-max-sizes-expected.txt: Added.
      * css3/flexbox/box-sizing-min-max-sizes.html: Added.
      * css3/flexbox/percentage-sizes-expected.txt: Added.
      * css3/flexbox/percentage-sizes-quirks-expected.txt: Added.
      * css3/flexbox/percentage-sizes-quirks.html: Added.
      * css3/flexbox/percentage-sizes.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c5ee94a
  4. 07 Aug, 2012 1 commit
  5. 06 Aug, 2012 1 commit
  6. 03 Aug, 2012 1 commit
    • rniwa@webkit.org's avatar
      Use testRunner instead of layoutTestController in the remaining layout tests · 8abd95ab
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93172
      
      Reviewed by Adam Barth.
      
      One last sweeping patch.
      
      * accessibility/canvas-accessibilitynodeobject.html:
      * compositing/backface-visibility/backface-visibility-webgl.html:
      * compositing/fixed-position-scroll-offset-history-restore.html:
      * compositing/overflow/image-load-overflow-scrollbars.html:
      * css3/flexbox/flexitem.html:
      * dom/html/level1/core/selfhtml.js:
      (startTest):
      * dom/html/level2/core/selfhtml.js:
      (startTest):
      * dom/html/level2/events/selfhtml.js:
      (startTest):
      * dom/html/level2/html/AppletsCollection.html:
      * dom/html/level2/html/HTMLBaseElement01.html:
      * dom/html/level2/html/HTMLBaseElement02.html:
      * dom/html/level2/html/selfhtml.js:
      (startTest):
      * dom/svg/level3/xpath/svgunit.js:
      * dom/xhtml/level1/core/selfxhtml.js:
      (startTest):
      * dom/xhtml/level2/core/selfxhtml.js:
      (startTest):
      * dom/xhtml/level2/events/selfxhtml.js:
      (startTest):
      * dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
      * dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
      * dom/xhtml/level2/html/selfxhtml.js:
      (startTest):
      * dom/xhtml/level3/core/selfxhtml.js:
      (startTest):
      * editing/shadow/adjusting-editing-boundary-with-table-in-shadow.html:
      * editing/shadow/bold-twice-in-shadow.html:
      * editing/shadow/breaking-editing-boundaries-2.html:
      * editing/shadow/contenteditable-propagation-at-shadow-boundary.html:
      * editing/shadow/delete-characters-in-distributed-node-crash.html:
      * editing/shadow/delete-list-in-shadow.html:
      * editing/shadow/insertorderedlist-crash.html:
      * editing/shadow/pressing-enter-on-list.html:
      * editing/spelling/grammar-edit-word-expected.txt:
      * editing/spelling/grammar-edit-word.html:
      * fast/block/percent-height-descendant-not-removed-crash2.html:
      * fast/block/positioning/abspositioned-object-under-split-relpositioned-inline-crash.html:
      * fast/block/positioning/insert-positioned-in-anonymous-crash.html:
      * fast/canvas/fallback-content.html:
      * fast/css/counters/counter-reset-subtree-insert-crash.html:
      * fast/css/crash-on-gradient-with-derived-color.html:
      * fast/dom/NodeList/childNodes-reverse-iteration.html:
      * fast/dom/Window/window-property-shadowing-onclick.html:
      * fast/dom/XMLSerializer-xml-namespace.html:
      * fast/dom/shadow/content-after-style.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8abd95ab
  7. 31 Jul, 2012 4 commits
    • commit-queue@webkit.org's avatar
      -webkit-flex-flow does not work with inherit/initial values · d38a8862
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92709
      
      Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-31
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Add a new handler for flex-flow and move flex to StyleBuilder to mirror the standard pattern for handling initial/inherit in shorthands.
      
      Test: css3/flexbox/flex-flow-initial.html
      
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder): Added handlers for flex and flex-flow.
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList): Removed hand written logic for handling flex.
      
      LayoutTests:
      
      Test that flex-flow handles 'initial' as expected.
      
      * css3/flexbox/flex-flow-initial-expected.txt: Added.
      * css3/flexbox/flex-flow-initial.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d38a8862
    • tony@chromium.org's avatar
      flexbox should avoid floats · b60b7ea6
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92661
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Block types should avoid floats. Deprecated flexbox and grid already avoid floats.
      
      Tests: css3/flexbox/floated-flexbox.html - added a test case.
      
      * rendering/RenderFlexibleBox.h:
      
      LayoutTests:
      
      Add a test case to make sure flexboxen avoid floats.
      
      * css3/flexbox/floated-flexbox.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b60b7ea6
    • tony@chromium.org's avatar
      REGRESSION: flexbox content-size fails to exclude scrollbar · 58dd0fe9
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92667
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      In r123909, we switched to computing the height using computeContentLogicalHeightUsing().
      Unfortunately, this includes the scrollbar when we want the content height. Add a helper
      method for computing the value needed by flexbox.
      
      Test: css3/flexbox/content-height-with-scrollbars.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::mainAxisContentExtent): Use computeLogicalClientHeight
      (WebCore::RenderFlexibleBox::computeLogicalClientHeight): Add new method for taking scrollbar into consideration.
      (WebCore::RenderFlexibleBox::computeAvailableFreeSpace): Use computeLogicalClientHeight
      (WebCore::RenderFlexibleBox::lineBreakLength): Use computeLogicalClientHeight
      * rendering/RenderFlexibleBox.h:
      
      LayoutTests:
      
      Add column flow test cases with scrollbars forced on.
      
      * css3/flexbox/content-height-with-scrollbars-expected.html: Added.
      * css3/flexbox/content-height-with-scrollbars.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58dd0fe9
    • tony@chromium.org's avatar
      -webkit-order should take an integer, not a number · cbad8a2f
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92688
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      The spec changed back from floats to integers:
      http://lists.w3.org/Archives/Public/www-style/2012Jul/0607.html
      
      Tests: css3/flexbox/css-properties.html: Updated.
             css3/flexbox/flex-order.html: Test cases modified.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore):
      (RenderFlexibleBox::OrderHashTraits):
      (WebCore::RenderFlexibleBox::OrderHashTraits::emptyValue):
      (WebCore::RenderFlexibleBox::OrderHashTraits::constructDeletedValue):
      (WebCore::RenderFlexibleBox::OrderHashTraits::isDeletedValue):
      (RenderFlexibleBox::OrderIterator):
      * rendering/RenderFlexibleBox.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleRareNonInheritedData.h:
      (StyleRareNonInheritedData):
      
      LayoutTests:
      
      Update tests.
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/css-properties.html:
      * css3/flexbox/flex-order.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbad8a2f
  8. 30 Jul, 2012 1 commit
  9. 27 Jul, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Source/WebCore: flex-wrap: wrap not wrapping for % sized items in column flow · 5113b27b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92324
      
      Patch by Tony Chang <tony@chromium.org> on 2012-07-27
      Reviewed by Ojan Vafai.
      
      We were using trying to use the value of contentLogicalHeight() before having called computeLogicalHeight()
      in a few places. Fix this in mainAxisContentExtent() rather than at the callers.
      
      Test: css3/flexbox/percentage-heights.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::mainAxisContentExtent):
      (WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild): If we haven't called computeLogicalHeight, we try to compute
      the height based on the fixed flexbox value. min/max don't matter here since percent values are only based on height/width.
      * rendering/RenderFlexibleBox.h: Drop const because computeContentLogicalHeightUsing is not const. I can
      try making computeContentLogicalHeightUsing const in a follow up change (might be non-trivial).
      
      Source/WebKit2: Show the unavailable plug-in indicator for Java applets as well
      https://bugs.webkit.org/show_bug.cgi?id=92521
      
      Patch by Anders Carlsson <andersca@apple.com> on 2012-07-27
      Reviewed by Sam Weinig.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      This can now be called on applet elements as well.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      Get the MIME type from the applet element.
      
      LayoutTests: flex-wrap: wrap not wrapping for % sized items in column flow
      https://bugs.webkit.org/show_bug.cgi?id=92324
      
      Patch by Tony Chang <tony@chromium.org> on 2012-07-27
      Reviewed by Ojan Vafai.
      
      Test cases for column flow with percentage heights. There are three
      test cases for the three callers of mainAxisContentExtent() that were
      broken by this.
      
      * css3/flexbox/percentage-heights-expected.txt: Added.
      * css3/flexbox/percentage-heights.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5113b27b
    • tony@chromium.org's avatar
      changing -webkit-order should change the paint order of flex items · cc6c2674
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92041
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Override paintChildren and use the flex order iterator to determine the order to paint the children.
      
      Test: css3/flexbox/order-painting.html
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutBlock): Save a reference to the order iterator.
      (WebCore::RenderFlexibleBox::paintChildren):
      * rendering/RenderFlexibleBox.h:
      (RenderFlexibleBox): Hold a reference to the order iterator so we don't have to recreate it at paint time.
          Also mark all the virtual methods with OVERRIDE.
      
      LayoutTests:
      
      Use a ref test since this is testing paint behavior.
      
      * css3/flexbox/order-painting-expected.html: Added.
      * css3/flexbox/order-painting.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc6c2674
  10. 25 Jul, 2012 1 commit
  11. 13 Jul, 2012 1 commit
    • tony@chromium.org's avatar
      Move layout checking js script into LayoutTest/resources and generalize · b1541cae
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=91268
      
      Reviewed by Ojan Vafai.
      
      flexbox.js contains helper scripts for verifying the size and position of nodes.
      I will be writing similar tests for grid, so move the js file into a location
      for sharing and generalize the script.
      
      * css3/flexbox/align-absolute-child.html: Change include path and call.
      * css3/flexbox/auto-height-dynamic.html:
      * css3/flexbox/columns-auto-size.html:
      * css3/flexbox/flex-algorithm-min-max.html:
      * css3/flexbox/flex-algorithm-with-margins.html:
      * css3/flexbox/flex-algorithm.html:
      * css3/flexbox/flex-align-column.html:
      * css3/flexbox/flex-align-end.html:
      * css3/flexbox/flex-align-max.html:
      * css3/flexbox/flex-align-percent-height.html:
      * css3/flexbox/flex-align-stretch.html:
      * css3/flexbox/flex-align-vertical-writing-mode.html:
      * css3/flexbox/flex-align.html:
      * css3/flexbox/flex-flow-auto-margins.html:
      * css3/flexbox/flex-flow-border.html:
      * css3/flexbox/flex-flow-margins-auto-size.html:
      * css3/flexbox/flex-flow-margins.html:
      * css3/flexbox/flex-flow-orientations.html:
      * css3/flexbox/flex-flow-overflow.html:
      * css3/flexbox/flex-flow-padding.html:
      * css3/flexbox/flex-flow.html:
      * css3/flexbox/flex-item-child-overflow.html:
      * css3/flexbox/flex-item-min-size.html:
      * css3/flexbox/flex-justify-content.html:
      * css3/flexbox/flex-no-flex.html:
      * css3/flexbox/flexitem.html:
      * css3/flexbox/floated-flexbox.html:
      * css3/flexbox/line-wrapping.html:
      * css3/flexbox/multiline-align-content-horizontal-column.html:
      * css3/flexbox/multiline-align-content.html:
      * css3/flexbox/multiline-align-self.html:
      * css3/flexbox/multiline-column-auto.html:
      * css3/flexbox/multiline-justify-content.html:
      * css3/flexbox/multiline-reverse-wrap-overflow.html:
      * css3/flexbox/multiline.html:
      * css3/flexbox/nested-stretch.html:
      * css3/flexbox/orthogonal-flex-directions.html:
      * css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
      * css3/flexbox/position-absolute-child.html:
      * css3/flexbox/preferred-widths-orthogonal.html:
      * css3/flexbox/preferred-widths.html:
      * css3/flexbox/style-change.html:
      * css3/flexbox/true-centering.html:
      * css3/flexbox/writing-modes.html:
      * resources/check-layout.js: Renamed from LayoutTests/css3/flexbox/resources/flexbox.js.
      (.): Rename checkFlexboxen to checkLayout that takes a CSS selector. Hide functions in a closure.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1541cae
  12. 12 Jul, 2012 1 commit
    • ojan@chromium.org's avatar
      Implied minimum size of flex items is min-content · e1037f55
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87546
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      http://dev.w3.org/csswg/css3-flexbox/#min-size-auto
      In the main axis direction, min-size of auto means min-content.
      
      Test: css3/flexbox/flex-item-min-size.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeLogicalWidthInRegionUsing):
      (WebCore::RenderBox::computeContentLogicalHeightUsing):
      (WebCore::RenderBox::computeReplacedLogicalWidthUsing):
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing):
      (WebCore::RenderBox::computePositionedLogicalWidthUsing):
      (WebCore::RenderBox::computePositionedLogicalHeightUsing):
      It turned out that these FIXMEs are all unnecessary with the changes to RenderFlexibleBox.
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
      (WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
      
      LayoutTests:
      
      Mostly just set min-height/min-width:0 as appropriate to keep the tests testing
      what the used to be testing. I made sure that each rendering was correct before
      making the changes. In a couple cases, I changed expectations where I thought
      the test was still testing was it was intending to test.
      
      * css3/flexbox/child-overflow.html:
      * css3/flexbox/columns-auto-size.html:
      * css3/flexbox/cross-axis-scrollbar.html:
      * css3/flexbox/flex-item-min-size-expected.txt: Added.
      * css3/flexbox/flex-item-min-size.html: Added.
      * css3/flexbox/flexitem.html:
      * css3/flexbox/line-wrapping.html:
      * css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
      * css3/flexbox/repaint-rtl-column.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1037f55
  13. 11 Jul, 2012 1 commit
  14. 02 Jul, 2012 1 commit
  15. 29 Jun, 2012 2 commits
  16. 28 Jun, 2012 1 commit
    • tony@chromium.org's avatar
      Split flex into flex-grow/flex-shrink/flex-basis · 092bb3c7
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86525
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Split flex into 3 separate properties per the spec:
      http://dev.w3.org/csswg/css3-flexbox/#flex-components
      
      Tests: css3/flexbox/flex-longhand-parsing.html
             css3/flexbox/flex-property-parsing.html: Updated test results.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore): -webkit-flex is no longer enumerable.
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add new css property names and use
      getCSSPropertyValuesForShorthandProperties for WebkitFlex. Also sort flex propery names.
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue): Fix indent.
      (WebCore::CSSParser::parseValue): Add parsing for new properties and handle -webkit-flex: none.
      (WebCore::CSSParser::parseFlex): Switch to new names (positive -> grow, negative -> shrink,
      preferred size -> basis) and assign to longhand properties.
      * css/CSSParser.h:
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty): Add new properties.
      * css/CSSPropertyNames.in: Add new properties.
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder): Delete special handling of applying flex and just use shorthand handlers.
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getPropertyValue): Add new shorthand.
      (WebCore::StylePropertySet::asText):
      * css/StylePropertyShorthand.cpp:
      (WebCore::webkitFlexShorthand): Add new shorthand.
      (WebCore::shorthandForProperty):
      * css/StylePropertyShorthand.h:
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList): Add to list of properties applied by StyleBuilder.
      Handle initial and inherit for flex.
      
      LayoutTests:
      
      If -webkit-flex is set to none, when the user reads the value back out, it is
      now 0 0 auto. 'none' is for convenience, not an actual value.
      
      * css3/flexbox/flex-longhand-parsing-expected.txt:
      * css3/flexbox/flex-longhand-parsing.html: Test flex-grow, flex-shrink and flex-basis.
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html: Update results for 'none'.
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/getComputedStyle/resources/property-names.js: Remove -webkit-flex since it's no longer enumerable.
      * svg/css/getComputedStyle-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      092bb3c7
  17. 27 Jun, 2012 2 commits
    • tony@chromium.org's avatar
      Unreviewed, rolling out r121380. · 7fe1d912
      tony@chromium.org authored
      http://trac.webkit.org/changeset/121380
      https://bugs.webkit.org/show_bug.cgi?id=86525
      
      Hits an ASSERT in debug.
      
      Source/WebCore:
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue):
      (WebCore::CSSParser::parseValue):
      (WebCore::CSSParser::parseFlex):
      * css/CSSParser.h:
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/StyleBuilder.cpp:
      (ApplyPropertyFlex):
      (WebCore::ApplyPropertyFlex::applyInheritValue):
      (WebCore::ApplyPropertyFlex::applyInitialValue):
      (WebCore::ApplyPropertyFlex::applyValue):
      (WebCore::ApplyPropertyFlex::createHandler):
      (WebCore::ApplyPropertyFlex::getFlexValue):
      (WebCore):
      (WebCore::StyleBuilder::StyleBuilder):
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getPropertyValue):
      (WebCore::StylePropertySet::asText):
      * css/StylePropertyShorthand.cpp:
      (WebCore::webkitFlexFlowShorthand):
      (WebCore::shorthandForProperty):
      * css/StylePropertyShorthand.h:
      (WebCore):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      
      LayoutTests:
      
      * css3/flexbox/flex-longhand-parsing-expected.txt: Removed.
      * css3/flexbox/flex-longhand-parsing.html: Removed.
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html:
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/getComputedStyle/resources/property-names.js:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fe1d912
    • tony@chromium.org's avatar
      Split flex into flex-grow/flex-shrink/flex-basis · 7514b66a
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86525
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Split flex into 3 separate properties per the spec:
      http://dev.w3.org/csswg/css3-flexbox/#flex-components
      
      Tests: css3/flexbox/flex-longhand-parsing.html
             css3/flexbox/flex-property-parsing.html: Updated test results.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore): -webkit-flex is no longer enumerable.
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add new css property names and use
      getCSSPropertyValuesForShorthandProperties for WebkitFlex. Also sort flex propery names.
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue): Fix indent.
      (WebCore::CSSParser::parseValue): Add parsing for new properties and handle -webkit-flex: none.
      (WebCore::CSSParser::parseFlex): Switch to new names (positive -> grow, negative -> shrink,
      preferred size -> basis) and assign to longhand properties.
      * css/CSSParser.h:
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty): Add new properties.
      * css/CSSPropertyNames.in: Add new properties.
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder): Delete special handling of applying flex and just use shorthand handlers.
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::getPropertyValue): Add new shorthand.
      (WebCore::StylePropertySet::asText):
      * css/StylePropertyShorthand.cpp:
      (WebCore::webkitFlexShorthand): Add new shorthand.
      (WebCore::shorthandForProperty):
      * css/StylePropertyShorthand.h:
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList): Add to list of properties applied by StyleBuilder.
      
      LayoutTests:
      
      If -webkit-flex is set to none, when the user reads the value back out, it is
      now 0 0 auto. 'none' is for convenience, not an actual value.
      
      * css3/flexbox/flex-longhand-parsing-expected.txt:
      * css3/flexbox/flex-longhand-parsing.html: Test flex-grow, flex-shrink and flex-basis.
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html: Update results for 'none'.
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * fast/css/getComputedStyle/resources/property-names.js: Remove -webkit-flex since it's no longer enumerable.
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7514b66a
  18. 22 Jun, 2012 1 commit
  19. 14 Jun, 2012 1 commit
  20. 12 Jun, 2012 2 commits
  21. 11 Jun, 2012 1 commit
    • rniwa@webkit.org's avatar
      Use testRunner instead of layoutTestController in css 1, css 2.1, and css3 tests · 42948af7
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88769
      
      Reviewed by Tony Chang.
      
      * css1/units/zero-duration-without-units.html:
      * css3/calc/:
      * css3/filters/:
      * css3/filters/custom/:
      * css3/filters/resources/:
      * css3/filters/script-tests/:
      * css3/flexbox/:
      * css3/font-feature-settings-rendering.html:
      * css3/images/cross-fade-invalidation.html:
      * css3/images/optimize-contrast-canvas.html:
      * css3/images/optimize-contrast-image.html:
      * css3/khtml-background-size-0x0-bmp.html:
      * css3/parsing-css3-nthchild.html:
      * css3/style-zoomed-image.html:
      * css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
      * css3/zoom-coords.xhtml:
      * platform/win/css2.1/resources/run-webkit-tests-epilogue.html:
      * platform/win/css2.1/resources/run-webkit-tests-prologue.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42948af7
  22. 06 Jun, 2012 2 commits
  23. 05 Jun, 2012 1 commit
    • ojan@chromium.org's avatar
      Nested CSS flexbox renders incorrectly · 86f0e23f
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87679
      
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      If the containing block with a perpendicular writing mode has an overrideHeight,
      then its logical height should be based off that instead of its RenderStyle.
      
      Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
      
      LayoutTests:
      
      * css3/flexbox/perpendicular-writing-modes-inside-flex-item-expected.txt: Added.
      * css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86f0e23f
  24. 04 Jun, 2012 3 commits
    • tony@chromium.org's avatar
      CSS property 'order' should be a number rather than an int · c25b521d
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88111
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      This changed in the spec:
      http://dev.w3.org/csswg/css3-flexbox/#order
      
      I also fixed the compile with CSS3_FLEXBOX disabled.
      
      No new tests, covered by existing tests.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSProperty.cpp: Parse as float, remove clamping for HashMap<int>.
      (WebCore::CSSProperty::isInheritedProperty):
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * rendering/RenderFlexibleBox.cpp: Remove traits for HashMap<int>.
      (RenderFlexibleBox::OrderIterator):
      * rendering/RenderFlexibleBox.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleRareNonInheritedData.h:
      (StyleRareNonInheritedData):
      
      LayoutTests:
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/css-properties.html: Allow decimal values.
      * css3/flexbox/flex-order.html: Fix tests based on float limits.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c25b521d
    • tony@chromium.org's avatar
      Rename CSS flexbox test files to match new property names · 54f967c8
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88174
      
      Reviewed by Ojan Vafai.
      
      flex-pack became justify-content and flex-line-pack became
      align-content. Rename the tests to match the new names.
      
      * css3/flexbox/flex-justify-content-expected.txt: Renamed from LayoutTests/css3/flexbox/flex-pack-expected.txt.
      * css3/flexbox/flex-justify-content.html: Renamed from LayoutTests/css3/flexbox/flex-pack.html.
      * css3/flexbox/multiline-align-content-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-expected.txt.
      * css3/flexbox/multiline-align-content-horizontal-column-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-horizontal-column-expected.txt.
      * css3/flexbox/multiline-align-content-horizontal-column.html: Renamed from LayoutTests/css3/flexbox/multiline-line-pack-horizontal-column.html.
      * css3/flexbox/multiline-align-content.html: Renamed from LayoutTests/css3/flexbox/multiline-line-pack.html.
      * css3/flexbox/multiline-align-self-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-align-expected.txt.
      * css3/flexbox/multiline-align-self.html: Renamed from LayoutTests/css3/flexbox/multiline-align.html.
      * css3/flexbox/multiline-justify-content-expected.txt: Renamed from LayoutTests/css3/flexbox/multiline-pack-expected.txt.
      * css3/flexbox/multiline-justify-content.html: Renamed from LayoutTests/css3/flexbox/multiline-pack.html.
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54f967c8
    • tony@chromium.org's avatar
      Fix a couple flexbox tests to use flex-start and flex-end · 22c716bc
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88170
      
      Reviewed by Ojan Vafai.
      
      This test was still using start/end for align-self, which fallback
      to stretch. The test still passed because it is testing that all
      values of align-self behave the same and stretch produced the same
      behavior as flex-start/flex-end.
      
      * css3/flexbox/cross-axis-scrollbar.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22c716bc
  25. 02 Jun, 2012 1 commit
    • tony@chromium.org's avatar
      Rename the flexbox CSS propery values from start to flex-start and end to flex-end · 354e7e94
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88152
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      The spec changed. This is to differentiate from start/end which will
      depend on writing mode direction, rather than flex direction.
      
      No new tests, just updated the existing values.
      
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator EAlignItems):
      (WebCore::CSSPrimitiveValue::operator EJustifyContent):
      (WebCore::CSSPrimitiveValue::operator EAlignContent):
      * css/CSSValueKeywords.in:
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::initialJustifyContentOffset):
      (WebCore::alignmentForChild):
      (WebCore::initialAlignContentOffset):
      (WebCore::RenderFlexibleBox::alignFlexLines):
      (WebCore::RenderFlexibleBox::alignChildren):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      
      LayoutTests:
      
      Rename start to flex-start and end to flex-end.
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/css-properties.html:
      * css3/flexbox/flex-align-column.html:
      * css3/flexbox/flex-align-end.html:
      * css3/flexbox/flex-align-vertical-writing-mode.html:
      * css3/flexbox/flex-align.html:
      * css3/flexbox/flex-pack.html:
      * css3/flexbox/line-wrapping.html:
      * css3/flexbox/multiline-align.html:
      * css3/flexbox/multiline-column-auto.html:
      * css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
      * css3/flexbox/multiline-line-pack-horizontal-column.html:
      * css3/flexbox/multiline-line-pack.html:
      * css3/flexbox/multiline-pack-expected.txt:
      * css3/flexbox/multiline-pack.html:
      * css3/flexbox/multiline-reverse-wrap-baseline.html:
      * css3/flexbox/multiline-reverse-wrap-overflow.html:
      * css3/flexbox/multiline-shrink-to-fit.html:
      * css3/flexbox/multiline.html:
      * css3/flexbox/nested-stretch.html:
      * css3/flexbox/orthogonal-flex-directions.html:
      * platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/qt/svg/css/getComputedStyle-basic-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      354e7e94
  26. 01 Jun, 2012 2 commits
    • tony@chromium.org's avatar
      rename -webkit-flex-pack and -webkit-flex-line-pack to -webkit-justify-content... · 730973cd
      tony@chromium.org authored
      rename -webkit-flex-pack and -webkit-flex-line-pack to -webkit-justify-content and -webkit-align-content
      https://bugs.webkit.org/show_bug.cgi?id=88113
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      This recently changed in the spec:
      http://dev.w3.org/csswg/css3-flexbox/#justify-content-property
      http://dev.w3.org/csswg/css3-flexbox/#align-content-property
      
      No new tests, updated existing tests.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::isValidKeywordPropertyAndValue):
      (WebCore::isKeywordPropertyID):
      (WebCore::CSSParser::parseValue):
      * css/CSSPrimitiveValueMappings.h:
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator EJustifyContent):
      (WebCore::CSSPrimitiveValue::operator EAlignContent):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
      (WebCore::initialJustifyContentOffset):
      (WebCore::justifyContentSpaceBetweenChildren):
      (WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
      (WebCore::RenderFlexibleBox::layoutColumnReverse):
      (WebCore::initialAlignContentOffset):
      (WebCore::alignContentSpaceBetweenChildren):
      (WebCore::RenderFlexibleBox::alignFlexLines):
      * rendering/RenderFlexibleBox.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/StyleFlexibleBoxData.cpp:
      (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
      (WebCore::StyleFlexibleBoxData::operator==):
      * rendering/style/StyleFlexibleBoxData.h:
      (StyleFlexibleBoxData):
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      (StyleRareNonInheritedData):
      
      LayoutTests:
      
      Find and replace for the CSS keywords.
      
      * css3/flexbox/columns-auto-size.html:
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/css-properties.html:
      * css3/flexbox/flex-pack.html:
      * css3/flexbox/multiline-align.html:
      * css3/flexbox/multiline-column-auto.html:
      * css3/flexbox/multiline-line-pack-expected.txt:
      * css3/flexbox/multiline-line-pack-horizontal-column-expected.txt:
      * css3/flexbox/multiline-line-pack-horizontal-column.html:
      * css3/flexbox/multiline-line-pack.html:
      * css3/flexbox/multiline-pack-expected.txt:
      * css3/flexbox/multiline-pack.html:
      * css3/flexbox/multiline-reverse-wrap-overflow.html:
      * css3/flexbox/multiline-shrink-to-fit.html:
      * css3/flexbox/multiline.html:
      * css3/flexbox/nested-stretch.html:
      * css3/flexbox/position-absolute-child.html:
      * css3/flexbox/true-centering.html:
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/svg/css/getComputedStyle-basic-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      730973cd
    • tony@chromium.org's avatar
      rename -webkit-flex-order to -webkit-order · cf06e0f1
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88104
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      This recently changed in the spec:
      http://dev.w3.org/csswg/css3-flexbox/#order-property
      
      No new tests, just updated existing results.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue):
      * css/CSSProperty.cpp:
      (WebCore::CSSProperty::isInheritedProperty):
      * css/CSSPropertyNames.in:
      * css/StyleBuilder.cpp:
      (WebCore::StyleBuilder::StyleBuilder):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::OrderIterator::OrderIterator):
      (WebCore::RenderFlexibleBox::OrderIterator::next):
      (WebCore::RenderFlexibleBox::layoutBlock):
      (WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
      (WebCore::RenderFlexibleBox::layoutFlexItems):
      (WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
      (WebCore::RenderFlexibleBox::computeNextFlexLine):
      (WebCore::RenderFlexibleBox::packFlexLines):
      (WebCore::RenderFlexibleBox::alignChildren):
      (WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
      (WebCore::RenderFlexibleBox::flipForWrapReverse):
      * rendering/RenderFlexibleBox.h:
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleFlexibleBoxData.cpp:
      (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
      (WebCore::StyleFlexibleBoxData::operator==):
      * rendering/style/StyleFlexibleBoxData.h:
      (StyleFlexibleBoxData):
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      (StyleRareNonInheritedData):
      
      LayoutTests:
      
      Just a find and replace for the new property name.
      
      * css3/flexbox/css-properties-expected.txt:
      * css3/flexbox/css-properties.html:
      * css3/flexbox/flex-order.html:
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/svg/css/getComputedStyle-basic-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf06e0f1
  27. 31 May, 2012 1 commit
    • tony@chromium.org's avatar
      initial flex value should be 1 1 auto · 15e0ad1f
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86526
      
      Source/WebCore:
      
      Reviewed by Ojan Vafai.
      
      Also, if -webkit-flex is used to set the positive flex to 0 and
      the negative flex is omitted, the negative flex is set to 0.
      
      New test cases in: flex-property-parsing.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFlex):
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyFlex::applyValue):
      * rendering/style/RenderStyle.h:
      
      LayoutTests:
      
      In most tests, I added a CSS rule to default -webkit-flex: none.
      In a few tests, -webkit-flex didn't include the negative flex value
      and it was becoming 1, causing negative flexing. I fixed those by
      explicitly stating the negative flex as 0.
      
      Reviewed by Ojan Vafai.
      
      * css3/flexbox/align-absolute-child.html:
      * css3/flexbox/auto-margins.html:
      * css3/flexbox/flex-algorithm-with-margins.html:
      * css3/flexbox/flex-algorithm.html:
      * css3/flexbox/flex-align-end.html:
      * css3/flexbox/flex-flow-auto-margins.html:
      * css3/flexbox/flex-flow-orientations.html:
      * css3/flexbox/flex-flow-overflow.html:
      * css3/flexbox/flex-pack.html:
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html:
      * css3/flexbox/flexbox-overflow-auto-expected.html:
      * css3/flexbox/flexbox-overflow-auto.html:
      * css3/flexbox/multiline-column-auto.html:
      * css3/flexbox/multiline-pack.html:
      * css3/flexbox/multiline-shrink-to-fit.html:
      * css3/flexbox/multiline.html:
      * css3/flexbox/nested-stretch.html:
      * css3/flexbox/orthogonal-flex-directions.html:
      * css3/flexbox/position-absolute-child.html:
      * css3/flexbox/preferred-widths-orthogonal.html:
      * css3/flexbox/true-centering.html:
      * fast/css/getComputedStyle/computed-style-expected.txt:
      * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-linux-x86/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-leopard/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-vista/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win-xp/svg/css/getComputedStyle-basic-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
      * platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/mac/svg/css/getComputedStyle-basic-expected.txt:
      * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * platform/qt/svg/css/getComputedStyle-basic-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
      * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      * svg/css/getComputedStyle-basic-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15e0ad1f