1. 09 Jul, 2008 10 commits
    • kmccullough@apple.com's avatar
      2008-07-09 Kevin McCullough <kmccullough@apple.com> · a400816a
      kmccullough@apple.com authored
              Reviewed by Geoff and Adam.
              <rdar://problem/5951532> JSProfiler: Implement Bottom-Up view (19228)
              - This is the plumbing for bottom-up, but does not include calculating
              time, mostly because I'm still undclear about what the end result should
              look like.
              - This, obviously, does not include the UI to expose this in the
              inspector yet.
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * profiler/CallIdentifier.h:
              (WTF::): Added HashTraits for CallIdentifiers to be used by a HashMap.
              * profiler/HeavyProfile.cpp: Added.
              * profiler/HeavyProfile.h: Added.
              * profiler/Profile.cpp: Removed old commented out includes.
              * profiler/Profile.h: The m_head is needed by the HeavyProfile so it
              is now protected as opposed to private.
              * profiler/ProfileNode.cpp:
              (KJS::ProfileNode::ProfileNode): Created a constructor to copy
              (KJS::ProfileNode::findChild): Added a null check to make HeavyProfile
              children finding easier and avoid a potential crasher.
              * profiler/ProfileNode.h: Mostly moved things around but also added some
              functionality needed by HeavyProfile.
              * profiler/TreeProfile.cpp: Implemented the ability to get a
              * profiler/TreeProfile.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • eric@webkit.org's avatar
      Reviewed by weinig. · d545a160
      eric@webkit.org authored
              Add Content-Type support to DumpRenderTree and run-webkit-tests
              and move expected.txt files to expected.webarchive
              * DumpRenderTree/cg/ImageDiffCG.cpp:
              * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              * Scripts/run-webkit-tests:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele@apple.com's avatar
      Fixing my typo from the last checkin · 9fcac210
      adele@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt@apple.com's avatar
      2008-07-09 David Hyatt <hyatt@apple.com> · d19daf6c
      hyatt@apple.com authored
              Switch transitions back to a "destination" model as far as choosing which transitions should apply on a style
              change.  Preserve the behavior of allowing stale transitions (in the absence of property changes) to run to
              Reviewed by Dean
              * manual-tests/transitions.html:
              * manual-tests/transitions2.html:
              * page/AnimationController.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele@apple.com's avatar
      2008-07-09 Michelangelo De Simone <m.des@mac.com> · f8491e23
      adele@apple.com authored
              Reviewed by Adele.
              Added the virtual function Node::isTextControl() in order to simplify text field and textarea checks.
              * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              Clean up in PseudoReadOnly and PseudoReadWrite cases removing unnecessary checks and casts in favor of the sole isTextControl() check.
              * dom/Node.h: Added base isTextControl().
              * html/HTMLInputElement.h: Added isTextControl() which wraps HTMLInputElement::isTextField().
              * html/HTMLTextAreaElement.h: Added isTextControl().
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rwlbuis@webkit.org's avatar
      Reviewed by Eric. · 32a5f4cf
      rwlbuis@webkit.org authored
              SVGRenderStyle should store pre-modified resource URIs
              Store pre-modified resource URIs to decrease string
              operations during layout/rendering.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca@apple.com's avatar
      2008-07-09 Anders Carlsson <andersca@apple.com> · ec6fda5e
      andersca@apple.com authored
              Reviewed by Darin.
              Make some WebPlugin and WebPluginFactory SPI public.
              * Plugins/WebPlugin.h:
              * Plugins/WebPluginPrivate.h:
              * Plugins/WebPluginViewFactory.h:
              * Plugins/WebPluginViewFactoryPrivate.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca@apple.com's avatar
      2008-07-09 Anders Carlsson <andersca@apple.com> · f04c0e3f
      andersca@apple.com authored
              Reviewed by Mitz.
              Remove an unused instance variable.
              * loader/DocumentLoader.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mitz@apple.com's avatar
      Reviewed by Anders Carlsson. · 71baa392
      mitz@apple.com authored
              - remove unused #includes
              * dom/XMLTokenizer.cpp:
              * html/PreloadScanner.cpp:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedScript.cpp:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXSLStyleSheet.cpp:
              * page/mac/FrameMac.mm:
              * xml/XSLTProcessor.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren@apple.com's avatar
      JavaScriptCore: · dcc2048c
      ggaren@apple.com authored
      2008-07-08  Geoffrey Garen  <ggaren@apple.com>
              Reviewed by Oliver Hunt.
              Added support for checking if an object has custom properties in its
              property map. WebCore uses this to optimize marking DOM wrappers.
      2008-07-08  Geoffrey Garen  <ggaren@apple.com>
              Reviewed by Oliver Hunt.
              Only artificially mark JS DOM wrappers if they have custom properties.
              21X speedup on http://nerget.com/jstests/dom-mandelbrot.html.
              No, that is not a typo.
              * bindings/js/JSDOMBinding.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 08 Jul, 2008 10 commits
    • jhoneycutt@apple.com's avatar
      2008-07-08 Jon Honeycutt <jhoneycutt@apple.com> · be3a861c
      jhoneycutt@apple.com authored
              Reviewed by Anders.
              Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
              * Plugins/WebBaseNetscapePluginStream.h: Added new member,
              * Plugins/WebBaseNetscapePluginStream.mm:
              (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
              (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
              newStreamSuccessful to YES.
              (-[WebBaseNetscapePluginStream _destroyStream]): Only call
              NPP_DestroyStream if newStreamSuccessful is true.
              Port r34988 to Mac: allow tests to define JavaScript to execute when
              NPP_DestroyStream or NPP_URLNotify is called.
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
              (NPP_New): Remove initialization that happens in pluginAllocate. Look
              for new arguments onStreamDestroy and onURLNotify.
              (NPP_Destroy): Free onStreamDestroy and onURLNotify.
              (executeScript): Code moved from onStreamLoad.
              (NPP_NewStream): Call executeScript.
              (NPP_DestroyStream): Same.
              (NPP_URLNotify): Same.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · f62a3e6b
      kevino@webkit.org authored
      Fix to previous patch for handling mouse up events.        
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mitz@apple.com's avatar
      Reviewed by Brady Eidson. · 8e3cd38f
      mitz@apple.com authored
              - initialize the Archives log channel's state
              * platform/mac/LoggingMac.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • dino@apple.com's avatar
      2008-07-08 Simon Fraser <simon.fraser@apple.com> · f7dcd992
      dino@apple.com authored
              Reviewed by Darin.
              Dean forgot to add this file needed for the tests.
              * traversal/resources/node-iterator-009-data.xml: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullough@apple.com's avatar
      2008-07-08 Kevin McCullough <kmccullough@apple.com> · debe8bd0
      kmccullough@apple.com authored
              Added manual test for the new heavy view.
              * manual-tests/inspector/profiler-test-heavy-view.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin@apple.com's avatar
      2008-07-08 Darin Adler <darin@apple.com> · 49d4609c
      darin@apple.com authored
              Reviewed by Mitz.
              - fix <rdar://problem/6043731> REGRESSION (3-4): RedEnvelope.com
                looks wrong due to OpenCube QuickMenu appVersion check
              * page/Navigator.cpp:
              (WebCore::shouldHideFourDot): Add dqm_loader.js as another filename.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mitz@apple.com's avatar
      WebCore: · 9cf92a4f
      mitz@apple.com authored
              Reviewed by John Sullivan.
              - WebCore part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
              Added a setting, updatesWhenOffscreen(), which controls whether an
              offscreen web view gets marked as needing update when its contents
              change (the existing behavior) or not (a new behavior), in which case it
              will be marked as needing update just before it goes on screen. The
              existing behavior (updating while offscreen) remains the default.
              * WebCore.base.exp: Added Settings::setUpdatesWhenOffscreen().
              * page/FrameView.cpp:
              (WebCore::FrameView::shouldUpdateWhenOffscreen): Added. Returns the
              value from settings.
              * page/FrameView.h:
              * page/Settings.cpp:
              (WebCore::Settings::setUpdatesWhenOffscreen): Added.
              * page/Settings.h:
              (WebCore::Settings::updatesWhenOffscreen): Added.
              * platform/ScrollView.h:
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::updateContents): Added code to return early and
              not call -setNeedsDisplayInRect: if the view is not in a visible window
              and the setting is not to update when offscreen.
              Reviewed by John Sullivan.
              - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView addWindowObservers]): Added code to observe when the
              window goes onscreen.
              (-[WebHTMLView removeWindowObservers]): Added.
              (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
              not update when offscreen, calls -setNeedsDisplay: just before it comes
              * WebView/WebPreferenceKeysPrivate.h: Added preference key.
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]): Made updates when offscreen on by
              (-[WebPreferences updatesWhenOffscreen]): Added.
              (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Added code to update the
              updatesWhenOffscreen setting in WebCore.
              Reviewed by John Sullivan.
              - WebKitSystemInterface part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
              * WebKitSystemInterface.h: Added WKWindowWillOrderOnScreenNotification.
              * libWebKitSystemInterfaceLeopard.a: Updated.
              * libWebKitSystemInterfaceTiger.a: Updated.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap@webkit.org's avatar
      Reviewed by Darin. · 1749d209
      ap@webkit.org authored
              <rdar://problem/6058368> REGRESSION: Crash occurs in KJS::Machine after launching
              Apple Installer
              The problem was that JSUserObject::getCallData() was setting call type to native, but
              left callData.native.function uninitialized.
              * JSObject.cpp:
              (JSUserObject::getCallData): Initialize callData.native.function.
              (nativeCallFunction): Call UserObjectImp::callAsFunction().
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hausmann@webkit.org's avatar
    • hausmann@webkit.org's avatar
  3. 07 Jul, 2008 20 commits
    • weinig@apple.com's avatar
      2008-07-07 Sam Weinig <sam@webkit.org> · cde5ee48
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
              Remove extraneous null check.
              * dom/Node.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig@apple.com's avatar
      WebCore: · 903a05c5
      weinig@apple.com authored
      2008-07-07  Sam Weinig  <sam@webkit.org>
              Reviewed by Anders Carlsson.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19928
              Use of CSS3 Namespaces syntax in Selectors API should throw an exception
              - Throw an NAMESPACE_ERR exception if a non-null or "*" namespace is
                used in a selector passed to querySelector or querySelectorAll.
              Test: fast/dom/SelectorAPI/not-supported-namespace-in-selector.html
              * dom/Node.cpp:
      2008-07-07  Sam Weinig  <sam@webkit.org>
              Reviewed by Anders Carlsson.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19928
              Use of CSS3 Namespaces syntax in Selectors API should throw an exception
              * fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt: Added.
              * fast/dom/SelectorAPI/not-supported-namespace-in-selector.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ddkilzer@apple.com's avatar
      releaseFastMallocFreeMemory() should always be defined · 322813f7
      ddkilzer@apple.com authored
              Reviewed by Darin.
              * JavaScriptCore.exp: Changed to export C++ binding for
              WTF::releaseFastMallocFreeMemory() instead of C binding for
              * wtf/FastMalloc.cpp: Moved definitions of
              releaseFastMallocFreeMemory() to be in the WTF namespace
              regardless whether FORCE_SYSTEM_MALLOC is defined.
              * wtf/FastMalloc.h: Moved releaseFastMallocFreeMemory() from
              extern "C" binding to WTF::releaseFastMallocFreeMemory().
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • dino@apple.com's avatar
      2008-07-07 Simon Fraser <simon.fraser@apple.com> · 54b5cc13
      dino@apple.com authored
              Reviewed by Darin.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19933
              nodeIterator with filter fails on documents not in a frame
              Tests: traversal/node-iterator-009.html
              * bindings/js/JSNodeFilterCondition.cpp:
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSNodeIteratorCustom.cpp:
              * bindings/js/JSTreeWalkerCustom.cpp:
              * bindings/objc/DOM.mm:
              * dom/NodeFilter.cpp:
              * dom/NodeFilter.h:
              * dom/NodeFilterCondition.cpp:
              * dom/NodeFilterCondition.h:
              * dom/NodeIterator.cpp:
              * dom/NodeIterator.h:
              * dom/Traversal.cpp:
              * dom/Traversal.h:
              * dom/TreeWalker.cpp:
              * dom/TreeWalker.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • cwzwarich@webkit.org's avatar
      2008-07-07 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 832e37f2
      cwzwarich@webkit.org authored
              Reviewed by Geoff.
              Bug 19926: URL causes crash within a minute
              Add a check that lastGlobalObject is non-null in Machine::execute()
              before copying its globals to the current register file.
              In theory, it is possible to make a test case for this, but it will
              take a while to get it right.
              * VM/Machine.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele@apple.com's avatar
      WebCore: · e6f0b89c
      adele@apple.com authored
      2008-07-07  Adele Peterson  <adele@apple.com>
              Reviewed by Dan Bernstein.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19924
              <rdar://problem/6057160> Disabled file input element updates its displayed file info when a file is dropped from the Finder.
              * page/DragController.cpp: (WebCore::DragController::concludeDrag):
              Check that the file control is enabled before taking dropped files.
      2008-07-07  Adele Peterson  <adele@apple.com>
              Reviewed by Dan Bernstein.
              Test for https://bugs.webkit.org/show_bug.cgi?id=19924
              <rdar://problem/6057160> Disabled file input element updates its displayed file info when a file is dropped from the Finder.
              * fast/forms/dragging-to-disabled-file-input-expected.txt: Added.
              * fast/forms/dragging-to-disabled-file-input.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele@apple.com's avatar
      WebCore: · f930d000
      adele@apple.com authored
      2008-07-07  Adele Peterson  <adele@apple.com>
              Reviewed by Beth.
              Fix for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime
              Change default volume setting to 1.0.
              * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement):
              * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
      2008-07-07  Adele Peterson  <adele@apple.com>
              Reviewed by Beth.
              Test for <rdar://problem/5860507> <AUDIO> playback noticeably more quiet than QuickTime
              * media/video-volume-expected.txt:
              * media/video-volume.html:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin@apple.com's avatar
      2008-07-07 Darin Adler <darin@apple.com> · d006497c
      darin@apple.com authored
              Reviewed by Mark Rowe.
              - fix <rdar://problem/6020441> REGRESSION: Layers on NWA.com render ugly
              The old version of the OpenCube QuickMenu library used on this site still has code
              that detects Netscape 4 by checking appVersion to see if it has the substring "4."
              in it. We decided to special-case the filename of the script and tweak the appVersion
              for files with that name.
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::ScriptController): Replace m_processingInlineCode with
              m_sourceURL. Use false instead of 0 to initialize a boolean.
              (WebCore::ScriptController::evaluate): Call argument sourceURL, not filename.
              Store current sourceURL in m_sourceURL. This fixes a mistake in the code that
              maintained the value of m_processingInlineCode, since the old code set it to
              false rather than restoring it. Renamed a local variable named sourceURL to
              exceptionSourceURL for clarity.
              (WebCore::ScriptController::processingUserGesture): Code that formerly used
              m_processingInlineCode to detect that it was evaluating code with no URL now
              uses m_sourceURL to do the same check.
              * bindings/js/ScriptController.h: Renamed filename argument to sourceURL; it has always
              been a URL, not a file path. Added a public sourceURL function and m_sourceURL and
              removed m_processingInlineCode.
              * page/Navigator.cpp:
              (WebCore::shouldHideFourDot): Added. Returns true if the currently running script has
              a source URL ending in "/dqm_script.js" and if the settings say we should do
              site-specific quirks (really JavaScript-library-specific in this case).
              (WebCore::Navigator::appVersion): Replace "4." with "4_" if shouldHideFourDot is true.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • cwzwarich@webkit.org's avatar
      2008-07-07 Cameron Zwarich <cwzwarich@uwaterloo.ca> · 5aa7aa31
      cwzwarich@webkit.org authored
              Reviewed by Geoff.
              Bug 19907: REGRESSION(r34824-r34941): Reproducible crash trying to log in to MediaTemple.net Account Center
              Clear exceptions set on ExecStates before returning from NPAPI
              callbacks, in order to avoid causing problems for the next script that
              While fixing this bug, the question was raised of whether we are
              correctly propagating exception information back to the caller:
              Bug 19936: Correctly propagate exception information from NPAPI callbacks
              * bridge/NP_jsobject.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdakin@apple.com's avatar
      WebKitTools: · fe260cb4
      bdakin@apple.com authored
      2008-07-07  Beth Dakin  <bdakin@apple.com>
              Reviewed by Anders.
              This patch extends DRT accessibility tests to add the ability to 
              query the intValue, minValue, and maxValue of the focused element.
              * DumpRenderTree/AccessibilityController.cpp:
              * DumpRenderTree/AccessibilityController.h:
              * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      2008-07-07  Beth Dakin  <bdakin@apple.com>
              Reviewed by Anders.
              New test that uses the ability to query int value, min value, and 
              max value in the accessibility tests.
              * accessibility/aria-range-value-expected.txt: Added.
              * accessibility/aria-range-value.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · f6ca06d8
      mitz@apple.com authored
              - fix <rdar://problem/6057650> REGRESSION (r35025): Crash beneath FontCache::invalidate() when activating Safari with no windows open
              * css/CSSFontFaceSource.cpp:
              (WebCore::CSSFontFaceSource::getFontData): Added a null check because
              docLoader() can return 0 now.
              * css/CSSFontSelector.cpp:
              (WebCore::CSSFontSelector::docLoader): Added a null check of m_document.
              (WebCore::CSSFontSelector::addFontFaceRule): Ditto.
              (WebCore::CSSFontSelector::fontLoaded): Ditto.
              (WebCore::CSSFontSelector::fontCacheInvalidated): Ditto.
              (WebCore::fontDataForGenericFamily): Added a null check of document.
              * css/CSSFontSelector.h:
              (WebCore::CSSFontSelector::clearDocument): Added.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::~CSSStyleSelector): Added a call to
              CSSFontSelector::clearDocument(). When the style selector is destroyed,
              there is no guarantee that the document will continue to exist.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin@apple.com's avatar
      2008-07-07 Darin Adler <darin@apple.com> · ad8ccce4
      darin@apple.com authored
              Rubber stamped by Adele.
              * VM/Machine.cpp:
              (KJS::Machine::privateExecute): Fix a typo in a comment.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • jchaffraix@webkit.org's avatar
      WebCore: · 58272ec7
      jchaffraix@webkit.org authored
      2008-07-07  Julien Chaffraix  <jchaffraix@webkit.org>
              Not reviewed.
              No svg build fix.
              * DerivedSources.make: Add JSSVGElementWrapperFactory.cpp target.
              * svg/animation/SMILTimeContainer.cpp: Add ENABLE(SVG) guard.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sfalken@apple.com's avatar
      JavaScriptCore: · 9ea4887c
      sfalken@apple.com authored
      2008-07-07  Steve Falkenburg  <sfalken@apple.com>
              Build fixes.
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/testapi/testapi.vcproj:
      2008-07-07  Steve Falkenburg  <sfalken@apple.com>
              Fix build.
              * DumpRenderTree/win/ImageDiff.vcproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca@apple.com's avatar
      2008-07-07 Anders Carlsson <andersca@apple.com> · 4625933f
      andersca@apple.com authored
              Reviewed by Darin.
              Speculative fix for     
              CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
              Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
              My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
              This is usually protected by _private->closed, but in this case it might still be false.
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView close]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele@apple.com's avatar
      WebCore: · fdf354c6
      adele@apple.com authored
      2008-07-07  Michelangelo De Simone  <m.des@mac.com>
              Reviewed by Adele.
              Support for CSS3 :read-only and :read-write pseudoclasses for readonly text controls.
              URL: http://www.w3.org/TR/web-forms-2/#relation
              Tests: fast/css/readonly-pseudoclass-opera-001.html
              * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
              Added "read-only" and "read-write" values for PseudoType extraction.
              * css/CSSSelector.h: (WebCore::CSSSelector::):
              Added PseudoReadOnly and PseudoReadWrite entries in PseudoType enum.
              * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              Checks to determine whether to match :read-only and :read-write pseudoclasses on
              text controls.
      2008-07-07  Michelangelo De Simone  <m.des@mac.com>
              Reviewed by Adele.
              Test suite for :read-only and :read-write pseudoclasses, imported from
              * fast/css/readonly-pseudoclass-opera-001-expected.txt: Added.
              * fast/css/readonly-pseudoclass-opera-001.html: Added.
              * fast/css/readonly-pseudoclass-opera-002-expected.txt: Added.
              * fast/css/readonly-pseudoclass-opera-002.html: Added.
              * fast/css/readonly-pseudoclass-opera-003-expected.txt: Added.
              * fast/css/readonly-pseudoclass-opera-003.html: Added.
              * fast/css/readonly-pseudoclass-opera-004-expected.txt: Added.
              * fast/css/readonly-pseudoclass-opera-004.html: Added.
              * fast/css/readonly-pseudoclass-opera-005-expected.txt: Added.
              * fast/css/readonly-pseudoclass-opera-005.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig@apple.com's avatar
      WebCore: · 4c74be06
      weinig@apple.com authored
      2008-07-07  Sam Weinig  <sam@webkit.org>
              Reviewed by Geoffrey Garen.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19928
              querySelectorAll should throw an exception if a NSResolver is passed in.
              - Throw an NOT_SUPPORTED_ERR if a non-null or undefined parameter is passed
                as the second argument to querySelector or querySelectorAll.
              Test: fast/dom/SelectorAPI/not-supported-NSResolver.html
              * bindings/js/JSDocumentCustom.cpp:
              * bindings/js/JSElementCustom.cpp:
              * dom/Document.idl:
              * dom/Element.idl:
      2008-07-07  Sam Weinig  <sam@webkit.org>
              Reviewed by Geoffrey Garen.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=19928
              querySelectorAll should throw an exception if a NSResolver is passed in.
              * fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt: Added.
              * fast/dom/SelectorAPI/not-supported-NSResolver.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson@apple.com's avatar
      WebCore: · 687069ee
      beidson@apple.com authored
      2008-07-07  Brady Eidson  <beidson@apple.com>
              Reviewed by Mitz and Geoff
              Test: fast/loader/empty-ref-versus-no-ref.html
              Fix for https://bugs.webkit.org/show_bug.cgi?id=18951 and <rdar://problem/5921760>
              "all DOM operations stop working when location.hash set to '#'"
              The underlying problem is that KURL didn't really know the difference between "empty ref"
              and "no ref at all" when changing the ref.  So changing to the empty ref in JS ended up 
              affecting removal of the ref, which ended up causing an infinite load load, also killing
              * platform/KURL.cpp:
              (WebCore::KURL::setRef):  Changed "isEmpty()" to "isNull()", since NULL has the special 
                meaning of "no ref at all" while empty means "empty ref"
      2008-07-07  Brady Eidson  <beidson@apple.com>
              Reviewed by Mitz and Geoff
              Test the fix for https://bugs.webkit.org/show_bug.cgi?id=18951 and <rdar://problem/5921760>
              * fast/loader/empty-ref-versus-no-ref-expected.txt: Added.
              * fast/loader/empty-ref-versus-no-ref.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullough@apple.com's avatar
      JavaScriptCore: · 1e1baa1f
      kmccullough@apple.com authored
      2008-07-07  Kevin McCullough  <kmccullough@apple.com>
              Reviewed by Darin.
              When the profiler is running it gathers information and creates a
              Profile.  After it finishes the Profile can be sorted and have other
              data refinements run over it.  Both of these were done in the same class
              before.  Now I split the gathering operations into a new class called
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * profiler/Profile.cpp: Removed code related to the gather stage of a
              Profile's creation.  
              * profiler/Profile.h: Ditto.
              * profiler/ProfileGenerator.cpp: Added. This is the class that will
              handle the stage of creating a Profile.  Once the Profile is finished
              being created, this class goes away.
              * profiler/ProfileGenerator.h: Added.
              * profiler/Profiler.cpp: Now operates with the ProfileGenerator instead
              of the Profile.
              (KJS::Profiler::didFinishAllExecution): It is here that the Profile is
              handed off to its client and the Profile Generator is no longer needed.
              * profiler/Profiler.h: Cleaned up the includes and subsequently the
              forward declarations.  Also use the new ProfileGenerator.
              * profiler/TreeProfile.cpp: Use Profile's new interface.
              * profiler/TreeProfile.h:
      2008-07-07  Kevin McCullough  <kmccullough@apple.com>
              Reviewed by Darin.
              Because profiler.h no longer #includes profile.h we need to explicitly
              include it in console.cpp.
              * page/Console.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • zimmermann@webkit.org's avatar
      Not reviewed. Build fix. · 632fe153
      zimmermann@webkit.org authored
      Fix --svg-filters build (affects Qt build, mac/win don't have it on by default)
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@35038 268f45cc-cd09-0410-ab3c-d52691b4dbfc