1. 04 Mar, 2008 29 commits
    • weinig@apple.com's avatar
      WebCore: · a37bbd4d
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Add ClassInfo to custom constructors so that they toString properly
      
              - Take this chance to remove the "Imp" from the end of JSXMLHttpRequestConstructorImp,
                and XSLTProcessorConstructorImp and prefix all the classes with JS. 
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::): Added ClassInfo definition.
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              (WebCore::JSAudioConstructor::construct): Cleanup.
              * bindings/js/JSAudioConstructor.h: Rename m_doc to m_document.
              (WebCore::JSAudioConstructor::classInfo): Added.
      
              * bindings/js/JSHTMLInputElementBase.cpp: Rename HTMLInputElementBasePrototype 
              to JSHTMLInputElementBasePrototype as seen if toString'ed.
              (WebCore::):
      
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              (WebCore::): Added ClassInfo definition.
              * bindings/js/JSHTMLOptionElementConstructor.h:
              (WebCore::JSHTMLOptionElementConstructor::classInfo): Added.
      
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::): Added ClassInfo definition.
              (WebCore::JSImageConstructor::implementsConstruct): Moved here from header.
              * bindings/js/JSImageConstructor.h:
              (WebCore::JSImageConstructor::classInfo): Added.
      
              * bindings/js/JSXMLHttpRequest.cpp:
              (WebCore::): Rename XMLHttpRequestPrototype  to JSXMLHttpRequestPrototype 
              as seen if toString'ed.
              (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
              (WebCore::JSXMLHttpRequestConstructor::implementsConstruct):
              (WebCore::JSXMLHttpRequestConstructor::construct):
              * bindings/js/JSXMLHttpRequest.h: Renamed JSXMLHttpRequestConstructorImp to
              JSXMLHttpRequestConstructor and doc to m_document and 
              (WebCore::JSXMLHttpRequestConstructor::classInfo): Added.
      
              * bindings/js/JSXSLTProcessor.cpp:
              (WebCore::): Renamed XSLTProcessorPrototype to JSXSLTProcessorPrototype and 
              XSLTProcessorConstructorImp to JSXSLTProcessorConstructor.
              (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
              (WebCore::JSXSLTProcessorConstructor::implementsConstruct):
              (WebCore::JSXSLTProcessorConstructor::construct):
              * bindings/js/JSXSLTProcessor.h:
              (WebCore::JSXSLTProcessorConstructor::classInfo): Added.
      
              * bindings/js/kjs_window.cpp:
              (WebCore::JSDOMWindowBase::getValueProperty): Fixed to work with the new class names.
      
      WebKitTools:
      
              Reviewed by Darin Adler.
      
              * Scripts/do-webcore-rename: Update renaming plan.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              Update results for fixed class names.
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/xmlhttprequest-get-expected.txt:
              * http/tests/xmlhttprequest/event-target-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a37bbd4d
    • mitz@apple.com's avatar
      WebCore: · 12085ebf
      mitz@apple.com authored
              Reviewed by Oliver Hunt and Geoffrey Garen.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=17667
                <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)
      
              * loader/loader.cpp:
              (WebCore::Loader::didFinishLoading): Changed to call
              setLoadInProgress(false) even for 4xx errors, because that triggers
              load completion check.
      
      LayoutTests:
      
              Reviewed by Oliver Hunt and Geoffrey Garen.
      
              - extended test to cover http://bugs.webkit.org/show_bug.cgi?id=17667
                <rdar://problem/5779658> REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit)
      
              * http/tests/misc/missing-style-sheet-expected.txt:
              * http/tests/misc/missing-style-sheet.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12085ebf
    • adele@apple.com's avatar
      WebCore: · aee865c5
      adele@apple.com authored
              Reviewed by Beth.
      
              Fix for <rdar://problem/5779718> focus() does not work for anchor elements with no content
      
              If an anchor has zero size, don't exclude it from being focusable from JS, just exclude it
              from being keyboard focusable (using the tab key).
      
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isFocusable):
              (WebCore::HTMLAnchorElement::isKeyboardFocusable):
      
      LayoutTests:
      
              Reviewed by Beth.
      
              Test for <rdar://problem/5779718> focus() does not work for anchor elements with no content
      
              * fast/events/anchor-empty-focus-expected.txt: Added.
              * fast/events/anchor-empty-focus.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aee865c5
    • cfleizach@apple.com's avatar
      <rdar://problem/5119360> ER - Seed: Google results do not have AXHeading information · 6c7794b0
      cfleizach@apple.com authored
      Make headers appear in AX regardless of whether they have BlockFlow renderers or not
      
      Reviewed by Darin Adler.
      
      * page/mac/WebCoreAXObject.mm:
      (headingLevel): no longer ignores BlockFlow rendered headers
      (-[WebCoreAXObject accessibilityIsIgnored]): does not ignore headers
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c7794b0
    • aroben@apple.com's avatar
      * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to... · fc1e790e
      aroben@apple.com authored
              * PrettyPatch/PrettyPatch.rb: Allow the extent of the previous file to be omitted from the hunk header.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc1e790e
    • aroben@apple.com's avatar
      Change WebView's string-finding methods to call through to Page · f8c25d9b
      aroben@apple.com authored
               These methods were added to Page back in r28878 (and the
               implementation was copied from WebView!) but we never switched over to
               using them.
      
               Reviewed by Sam.
      
               * WebView.cpp:
               (WebView::searchFor): Call through to Page::findString.
               (WebView::markAllMatchesForText): Call through to Page.
               (WebView::unmarkAllTextMatches): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8c25d9b
    • weinig@apple.com's avatar
      GTK+ build fix. · 2cb34108
      weinig@apple.com authored
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cb34108
    • weinig@apple.com's avatar
      Reviewed by Darin Adler. · a27dbabc
      weinig@apple.com authored
              Remame ImageConstructorImp to JSImageConstructor and move it into its
              own file.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSImageConstructor.cpp: Copied from bindings/js/kjs_html.cpp.
              (WebCore::JSImageConstructor::JSImageConstructor):
              (WebCore::JSImageConstructor::construct):
              * bindings/js/JSImageConstructor.h: Copied from bindings/js/kjs_html.h.
              * bindings/js/kjs_html.cpp:
              (WebCore::getRuntimeObject): Make this function static since it is only used
              in this file.
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_window.cpp:
              (WebCore::JSDOMWindowBase::getValueProperty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a27dbabc
    • darin@apple.com's avatar
      Reviewed by Adam. · 2a4f79fb
      darin@apple.com authored
              - fix 200+ failing regression tests
              - fix http://bugs.webkit.org/show_bug.cgi?id=17668
                Vertical scrollbar at slashdot.org is randomly not shown
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
              code here to exactly match the way it was before it was moved from WebCore. I had
              introduced a storage leak and that was causing problems with scroll bars!
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a4f79fb
    • aroben@apple.com's avatar
      Fix an uninitialized value warning in CodeGeneratorJS.pm · e3f5b373
      aroben@apple.com authored
              * bindings/scripts/CodeGeneratorJS.pm: Remove reference to
              non-existent $maybeOkParam (this was removed in r30753).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3f5b373
    • weinig@apple.com's avatar
      Reviewed by Darin Adler. · 116c68e4
      weinig@apple.com authored
              Remove kjs_dom.{h,cpp}.
      
              - Removed custom toAttr, which took a boolean ok, and teach CodeGeneratorJS.pm
                to us a null return value as an indication of failure. (This new logic is used
                for toVoidCallback as well.)
              - Move getRuntimeObject to kjs_html where a bunch of other runtime object related
                functions currently live.
              - Move checkNodeSecurity to kjs_binding, where other frame security functions 
                currently live.
              - Remove getNodeConstructor.  It had no implementation.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::toVoidCallback):
              * bindings/js/JSCustomVoidCallback.h:
              * bindings/js/JSDatabaseCustom.cpp:
              (WebCore::JSDatabase::changeVersion):
              (WebCore::JSDatabase::transaction):
              * bindings/js/JSElementCustom.cpp:
              (WebCore::JSElement::setAttributeNode):
              (WebCore::JSElement::setAttributeNodeNS):
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::toJS):
              * bindings/js/JSEventTargetBase.h:
              * bindings/js/JSHTMLAppletElementCustom.cpp:
              * bindings/js/JSHTMLElementCustom.cpp:
              * bindings/js/JSHTMLEmbedElementCustom.cpp:
              * bindings/js/JSHTMLFormElementCustom.cpp:
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              * bindings/js/JSHTMLObjectElementCustom.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp:
              * bindings/js/JSNamedNodesCollection.cpp:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSXSLTProcessor.cpp:
              * bindings/js/kjs_binding.cpp:
              (WebCore::checkNodeSecurity):
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_css.cpp:
              * bindings/js/kjs_dom.cpp: Removed.
              * bindings/js/kjs_dom.h: Removed.
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_html.cpp:
              (WebCore::getRuntimeObject):
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_window.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Attr.idl:
              * html/HTMLPlugInElement.cpp:
              * page/InspectorController.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      116c68e4
    • aroben@apple.com's avatar
      Actually pause the process while Drosera is at a breakpoint · a7bf179f
      aroben@apple.com authored
               WebScriptDebugServer::suspendProcessIfPaused is supposed to pause the
               process while Drosera is at a breakpoint. Previously we were just
               starting a message pump that would deliver messages to all windows in
               the process, allowing mouse events, JS timers, etc. to execute.
      
               Now we only deliver messages to COM's message window, which is all we
               need to allow RPC to function.
      
               Reviewed by Anders.
      
               * WebScriptDebugServer.cpp:
               (comMessageWindow): Added. Finds COM's message window.
               (WebScriptDebugServer::suspendProcessIfPaused): Only deliver messages
               to COM's message window so that mouse events, JS timers, etc., won't
               execute.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7bf179f
    • aroben@apple.com's avatar
      Generate WebScriptCallFrame instances dynamically · ba9b161a
      aroben@apple.com authored
              WebScriptDebugger no longer holds a reference to the topmost call
              frame, and WebScriptCallFrame no longer holds a reference to its
              caller. We now generate WebScriptCallFrame instances as needed by
              walking the callingExecState chain.
      
              By making WebKit no longer responsible for keeping track of the call
              stack, we get one step closer to moving most JS debugging code out of
              WebKit entirely.
      
              This incidentally fixes a bug in Drosera where we'd never show the
              global scope in the call stack.
      
              Reviewed by Sam and Kevin M.
      
              * WebScriptCallFrame.cpp:
              (callingFunctionOrGlobalExecState): Finds the nearest calling
              ExecState that is a FunctionExecState or GlobalExecState, if any, and
              returns it.
              (WebScriptCallFrame::WebScriptCallFrame):
                - No longer takes a caller parameter.
                - Sets m_state to the callingFunctionOrGlobalExecState of the
                  ExecState passed in.
              (WebScriptCallFrame::createInstance): Removed the caller parameter.
              (WebScriptCallFrame::caller): Generate a new WebScriptCallFrame on the
              fly from our ExecState.
              * WebScriptCallFrame.h: No longer holds a reference to the caller.
              * WebScriptDebugger.cpp:
              (WebScriptDebugger::WebScriptDebugger): Removed the call to callEvent
              that was supposed to set up the global scope call frame, but never
              worked because m_callingServer was set to true, which would cause
              callEvent to return early without doing anything. Also removed the
              m_callingServer guards since we're not calling callEvent anymore.
              (WebScriptDebugger::callEvent): Create a WebScriptCallFrame on the
              fly from the passed-in ExecState.
              (WebScriptDebugger::atStatement): Ditto.
              (WebScriptDebugger::returnEvent): Ditto, but use the callingExecState.
              This is equivalent to what calling leaveFrame() did before.
              (WebScriptDebugger::exception): Ditto, using the passed-in ExecState.
              * WebScriptDebugger.h: Removed m_topStackFrame member and
              enterFrame/leaveFrame methods.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba9b161a
    • aroben@apple.com's avatar
      Win/Qt/GTK+/wx build fix after r30740 · ece3c0e2
      aroben@apple.com authored
              * editing/Editor.cpp: Added missing #include.
              * page/qt/FrameQt.cpp: Removed Frame::dashboardRegionsChanged.
              * page/win/FrameWin.cpp: Ditto.
              * platform/wx/TemporaryLinkStubs.cpp: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ece3c0e2
    • alp@webkit.org's avatar
      2008-03-04 Alp Toker <alp@atoker.com> · a2c57f42
      alp@webkit.org authored
              GTK+ build fix for breakage introduced in r30740.
      
              Remove Frame::dashboardRegionsChanged(). There's now a default
              implementation at ChromeClient::dashboardRegionsChanged().
      
              * page/gtk/FrameGtk.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2c57f42
    • alp@webkit.org's avatar
      2008-03-04 Alp Toker <alp@atoker.com> · 50e1aa18
      alp@webkit.org authored
              GTK+ build fix suggested by aroben. Remove an unused Mac-specific
              included introduced in r30740.
      
              * page/ChromeClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50e1aa18
    • mitz@apple.com's avatar
      WebCore: · 5b4aa39f
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - fix <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html
      
              Test: platform/win/fast/text/uniscribe-missing-glyph.html
      
              Note that default installations of Windows do not have Myanmar fonts.
              What this patch does is ensure that the Myanmar and other complex
              scripts are rendered as missing glyphs rather than not rendered at all.
              The particular page in the bug measures the relative widths of two
              rendered strings and, if they are rendered as missing glyphs, detects
              that a Myanmar fonts is not available and substitutes the text with
              images. By not rendering (and measuring) missing glyphs, WebKit was
              throwing the page's detection code off.
      
              * platform/graphics/win/UniscribeController.cpp:
              (WebCore::UniscribeController::shape): Removed an early return in case
              shaping resulted in missing glyphs. This is now expected if font
              fallback failed to produce a font containing glyphs for the character.
              Also changed two resize()s to shrink()s.
      
      LayoutTests:
      
              - test for <rdar://problem/5622336> Burmese text does not render on http://www.myanmarbible.com/bible/Judson/html/index.html
      
              * platform/win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
              * platform/win/fast/text/uniscribe-missing-glyph.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b4aa39f
    • darin@apple.com's avatar
      WebCore: · e649bd8b
      darin@apple.com authored
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge reapplyStyles method
      
              * WebCore.base.exp: Added exports.
              * page/mac/WebCoreFrameBridge.h: Removed WebCoreDeviceType and
              reapplyStylesForDeviceType: method.
              * page/mac/WebCoreFrameBridge.mm: Ditto.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge reapplyStyles method
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e649bd8b
    • darin@apple.com's avatar
      WebCore: · 21f645b5
      darin@apple.com authored
              Reviewed by Adam.
      
              - eliminate WebCoreFrameBridge createFrameViewWithNSView
      
              * WebCore.base.exp: Added some more exports.
              * page/mac/WebCoreFrameBridge.h: Deleted createFrameViewWithNSView.
              * page/mac/WebCoreFrameBridge.mm: Ditto.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - eliminate WebCoreFrameBridge createFrameViewWithNSView
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage):
              Moved code here from createFrameViewWithNSView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21f645b5
    • darin@apple.com's avatar
      WebCore: · d1b3d66f
      darin@apple.com authored
              Reviewed by Adam.
      
              - removed WebCoreFrameBridge scrollOverflowInDirection
      
              * WebCore.base.exp: Export function needed by WebKit.
              * page/mac/WebCoreFrameBridge.h: Removed WebScrollDirection, WebScrollGranularity,
              and scrollOverflowInDirection.
              * page/mac/WebCoreFrameBridge.mm: Removed method.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - removed WebCoreFrameBridge scrollOverflowInDirection
      
              * WebView/WebFrameView.mm:
              (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
              EventHandler directly instead of using the bridge.
              (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
              of the ones from the bridge.
              (-[WebFrameView scrollToEndOfDocument:]): Ditto.
              (-[WebFrameView _pageVertically:]): Ditto.
              (-[WebFrameView _pageHorizontally:]): Ditto.
              (-[WebFrameView _scrollLineVertically:]): Ditto.
              (-[WebFrameView _scrollLineHorizontally:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1b3d66f
    • darin@apple.com's avatar
      WebCore: · 800e6e22
      darin@apple.com authored
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge installInFrame: method
      
              * WebCore.base.exp: Export a few symbols.
              * WebCore.xcodeproj/project.pbxproj: Export a few files.
              * page/mac/WebCoreFrameBridge.h: Remove installInFrame:.
              * page/mac/WebCoreFrameBridge.mm: Ditto.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge installInFrame: method
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
              -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
              * WebView/WebFrameView.mm:
              (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
              (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
              method isn't nested inside an if statement. Call
              -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
              * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
              used in WebFrameLoaderClient.mm.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      800e6e22
    • darin@apple.com's avatar
      WebCore: · 06ab6e95
      darin@apple.com authored
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge window method
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Get the window by calling
              window on the NSView instead of using the bridge. The WebKit side wasn't doing anything
              special, so a call to -[NSView window] is fine.
      
              * page/mac/WebCoreFrameBridge.h: Removed the window method.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge window method
      
              * WebCoreSupport/WebFrameBridge.mm: Removed window method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06ab6e95
    • darin@apple.com's avatar
      Reviewed by Adam. · 3498595a
      darin@apple.com authored
              - move code from WebFrameBridge into WebFrameLoaderClient
      
              * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
              to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
              removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
              redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
              Changed to use WebCore::String.
              (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
              (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
              and added a FIXME.
              (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
              (WebFrameLoaderClient::objectContentType): Ditto.
              (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
              (pluginView): Ditto.
              (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3498595a
    • darin@apple.com's avatar
      WebCore: · fdf769aa
      darin@apple.com authored
              Reviewed by Adam.
      
              - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
      
              * WebCore.base.exp: Updated.
              * page/Chrome.cpp:
              (WebCore::ChromeClient::dashboardRegionsChanged): Added.
              * page/ChromeClient.h: Added virtual function for dashboardRegionsChanged.
              * page/Frame.h: Removed dashboardRegionsChanged function.
              * page/FrameView.cpp:
              (WebCore::FrameView::updateDashboardRegions): Changed to call dashboardRegionsChanged
              on ChromeClient and to only call it when the regions actually changed.
              * page/mac/FrameMac.mm: Removed dashboardRegionsChanged function.
              * page/mac/WebCoreFrameBridge.h: Removed dashboardRegionsChanged: method.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
              The WebCore side now calls this only when there's an actual change.
              * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
              Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdf769aa
    • darin@apple.com's avatar
      WebCore: · 6c6a2805
      darin@apple.com authored
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge issuePasteComand method
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste): Moved the Mac-specific part of this to EditorMac.
              * editing/mac/EditorMac.mm:
              (WebCore::Editor::paste): Added. Calls paste: on the document view (normally a
              WebHTMLView). We should get rid of this eventually.
              * page/Frame.h: Removed issuePasteCommand.
              * page/mac/FrameMac.mm: Ditto.
              * page/mac/WebCoreFrameBridge.h: Ditto.
      
      WebKit/mac:
      
              Reviewed by Adam.
      
              - remove WebCoreFrameBridge issuePasteComand method
      
              * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
              * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c6a2805
    • ap@webkit.org's avatar
      Suggested by Darin, rubber-stamped by Mark. · a17471b3
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=17569
              REGRESSION (r30571): Buzzword.com doesn't load
      
              Rolling out r30571, as determining what is wrong with it proved tricky.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::tokenizerProcessedData):
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a17471b3
    • mrowe@apple.com's avatar
      2008-03-04 Mark Rowe <mrowe@apple.com> · e8d1ec8d
      mrowe@apple.com authored
              Reviewed by Sam Weinig.
      
              Add a note about preferring if over else if when the previous if is terminated by a return statement.
      
              * coding/coding-style.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8d1ec8d
    • weinig@apple.com's avatar
      Build fix. · 09175807
      weinig@apple.com authored
              * bindings/js/kjs_events.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09175807
    • weinig@apple.com's avatar
      WebCore: · 6d270f6f
      weinig@apple.com authored
              Reviewed by Mark Rowe.
      
              Move JSClipboard into its own file.
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSClipboardCustom.cpp: Added.
              (WebCore::JSClipboard::types):
              (WebCore::JSClipboard::clearData):
              (WebCore::JSClipboard::getData):
              (WebCore::JSClipboard::setData):
              (WebCore::JSClipboard::setDragImage):
              * bindings/js/JSElementCustom.cpp:
              * bindings/js/JSEventCustom.cpp:
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              * bindings/js/kjs_events.cpp:
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_window.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Clipboard.cpp:
              (WebCore::Clipboard::setDropEffect):
              (WebCore::Clipboard::setEffectAllowed):
              * dom/Clipboard.idl: Added.
      
      LayoutTests:
      
              Reviewed by Mark Rowe.
      
              Update test results.
      
              * fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d270f6f
  2. 03 Mar, 2008 11 commits
    • weinig@apple.com's avatar
      GTK+ build fix. · b1f7256e
      weinig@apple.com authored
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::windowObjectCleared):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1f7256e
    • weinig@apple.com's avatar
      Windows build fix. · a14bdae4
      weinig@apple.com authored
              * WebFrame.cpp:
              (WebFrame::windowObjectCleared):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a14bdae4
    • weinig@apple.com's avatar
      Windows build-fix. · ab48efbb
      weinig@apple.com authored
              * page/Chrome.cpp:
              * plugins/win/PluginViewWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab48efbb
    • weinig@apple.com's avatar
      Reviewed by Darin Adler. · 5f38e1a6
      weinig@apple.com authored
              Cleanup and plumbing in preparation for the great Window split.
      
              - Rename KJS::Window to WebCore::JSDOMWindowBase.
              - Remove KJS::Window::retrieve() and KJS::Window::retrieveWindow() and replace
                with the new toJSDOMWindow().
              - Remove KJS::Window::retrieveActive() and replace with explicit call to 
                exec->dynamicGlobalObject() and toJSDOMWindow().
      
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::toVoidCallback):.
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::create):
              * bindings/js/JSDatabaseCustom.cpp:
              (WebCore::JSDatabase::changeVersion):
              (WebCore::JSDatabase::transaction):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::location):
              (WebCore::toJS):
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::jsEventTargetAddEventListener):
              (WebCore::jsEventTargetRemoveEventListener):
              * bindings/js/JSEventTargetNode.cpp:
              (WebCore::JSEventTargetNode::setListener):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::open):
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              (WebCore::JSHTMLFrameSetElement::nameGetter):
              * bindings/js/JSLocation.cpp:
              (WebCore::JSLocation::put):
              (WebCore::jsLocationProtoFuncReplace):
              (WebCore::jsLocationProtoFuncReload):
              (WebCore::jsLocationProtoFuncAssign):
              * bindings/js/JSLocation.h:
              * bindings/js/JSSQLTransactionCustom.cpp:
              (WebCore::JSSQLTransaction::executeSql):
              * bindings/js/JSSVGLazyEventListener.cpp:
              (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener):
              (WebCore::JSSVGLazyEventListener::eventParameterName):
              * bindings/js/JSSVGLazyEventListener.h:
              * bindings/js/JSXMLHttpRequest.cpp:
              (WebCore::JSXMLHttpRequest::putValueProperty):
              (WebCore::jsXMLHttpRequestPrototypeFunctionOpen):
              (WebCore::jsXMLHttpRequestPrototypeFunctionAddEventListener):
              (WebCore::jsXMLHttpRequestPrototypeFunctionRemoveEventListener):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/kjs_binding.cpp:
              (WebCore::allowsAccessFromFrame):
              (WebCore::printErrorMessageForFrame):
              * bindings/js/kjs_events.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::windowObj):
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::~JSEventListener):
              (WebCore::JSEventListener::windowObj):
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_navigator.cpp:
              (WebCore::MimeType::getValueProperty):
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::evaluate):
              (WebCore::KJSProxy::createHTMLEventHandler):
              (WebCore::KJSProxy::createSVGEventHandler):
              * bindings/js/kjs_window.cpp:
              (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
              (WebCore::DOMWindowTimer::DOMWindowTimer):
              (WebCore::DOMWindowTimer::action):
              (WebCore::DOMWindowTimer::takeAction):
              (WebCore::):
              (WebCore::JSDOMWindowBase::JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::location):
              (WebCore::JSDOMWindowBase::mark):
              (WebCore::allowPopUp):
              (WebCore::createWindow):
              (WebCore::showModalDialog):
              (WebCore::JSDOMWindowBase::getValueProperty):
              (WebCore::JSDOMWindowBase::childFrameGetter):
              (WebCore::JSDOMWindowBase::indexGetter):
              (WebCore::JSDOMWindowBase::namedItemGetter):
              (WebCore::JSDOMWindowBase::getOwnPropertySlot):
              (WebCore::JSDOMWindowBase::put):
              (WebCore::JSDOMWindowBase::allowsAccessFrom):
              (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage):
              (WebCore::JSDOMWindowBase::allowsAccessFromPrivate):
              (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
              (WebCore::JSDOMWindowBase::printErrorMessage):
              (WebCore::JSDOMWindowBase::globalExec):
              (WebCore::JSDOMWindowBase::shouldInterruptScript):
              (WebCore::JSDOMWindowBase::setListener):
              (WebCore::JSDOMWindowBase::getListener):
              (WebCore::JSDOMWindowBase::findJSEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
              (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
              (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
              (WebCore::JSDOMWindowBase::clear):
              (WebCore::JSDOMWindowBase::setCurrentEvent):
              (WebCore::JSDOMWindowBase::currentEvent):
              (WebCore::windowProtoFuncAToB):
              (WebCore::windowProtoFuncBToA):
              (WebCore::windowProtoFuncOpen):
              (WebCore::windowProtoFuncSetTimeout):
              (WebCore::windowProtoFuncClearTimeout):
              (WebCore::windowProtoFuncSetInterval):
              (WebCore::windowProtoFuncAddEventListener):
              (WebCore::windowProtoFuncRemoveEventListener):
              (WebCore::windowProtoFuncShowModalDialog):
              (WebCore::windowProtoFuncNotImplemented):
              (WebCore::JSDOMWindowBase::setReturnValueSlot):
              (WebCore::JSDOMWindowBase::clearAllTimeouts):
              (WebCore::JSDOMWindowBase::installTimeout):
              (WebCore::JSDOMWindowBase::pauseTimeouts):
              (WebCore::JSDOMWindowBase::resumeTimeouts):
              (WebCore::JSDOMWindowBase::clearTimeout):
              (WebCore::JSDOMWindowBase::timerFired):
              (WebCore::JSDOMWindowBase::disconnectFrame):
              (WebCore::JSDOMWindowBase::jsEventListeners):
              (WebCore::JSDOMWindowBase::jsHTMLEventListeners):
              (WebCore::JSDOMWindowBase::jsUnprotectedEventListeners):
              (WebCore::JSDOMWindowBase::jsUnprotectedHTMLEventListeners):
              (WebCore::toJS):
              (WebCore::toJSDOMWindow):
              (WebCore::toJSDOMWindow):
              * bindings/js/kjs_window.h:
              (WebCore::JSDOMWindowBase::impl):
              (WebCore::JSDOMWindowBase::classInfo):
              (WebCore::JSDOMWindowBase::):
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              * page/Chrome.cpp:
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
              * page/DOMWindow.idl:
              * page/Frame.cpp:
              (WebCore::Frame::~Frame):
              (WebCore::Frame::windowScriptNPObject):
              (WebCore::Frame::pageDestroyed):
              * page/InspectorController.cpp:
              (WebCore::inspectedWindow):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::windowScriptObject):
              * page/mac/WebCoreFrameBridge.mm:
              (updateRenderingForBindings):
              * platform/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::canAccess):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f38e1a6
    • oliver@apple.com's avatar
      Make ForInNode check for the timeout interrupt · 71d3a95e
      oliver@apple.com authored
      Reviewed by Anders
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d3a95e
    • kevino@webkit.org's avatar
      wx build fixes after recent Frame-related changes. · 0840d06b
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0840d06b
    • mitz@apple.com's avatar
      WebCore: · c76605ad
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - make :first-letter apply to the first letter in normal flow, skipping
                floats and positioned objects
      
              Test: fast/css/first-letter-skip-out-of-flow.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::updateFirstLetter):
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test that :first-letter applies to the first letter in normal flow,
                skipping floats and positioned objects
      
              * fast/css/first-letter-skip-out-of-flow.html: Added.
              * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum: Added.
              * platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png: Added.
              * platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c76605ad
    • adachan@apple.com's avatar
      Fix build. · 31f4ae60
      adachan@apple.com authored
              * plugins/win/PluginViewWin.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f4ae60
    • mrowe@apple.com's avatar
      2008-03-03 Mark Rowe <mrowe@apple.com> · 45e6a3fa
      mrowe@apple.com authored
              Reviewed by Dan Bernstein.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=17313
              Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper
      
              Node::querySelector and SelectorNodeList were not sufficiently initializing the CSSStyleSelector
              before using it to resolve styles, which lead to it having a stale m_style member in some situations.
              This stale m_style member resulted in a wild store that would write over whatever object now resided
              at the location m_style pointed to.
      
              Test: fast/dom/SelectorAPI/bug-17313.html
      
              * dom/Node.cpp:
              (WebCore::Node::querySelector): Call initForStyleResolve to further initialize the CSSStyleSelector.
              * dom/SelectorNodeList.cpp:
              (WebCore::SelectorNodeList::SelectorNodeList): Ditto.
      
      2008-03-03  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=17313
              Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper
      
              * fast/dom/SelectorAPI/bug-17313-expected.txt: Added.
              * fast/dom/SelectorAPI/bug-17313.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45e6a3fa
    • alp@webkit.org's avatar
      2008-03-03 Brent Fulgham <bfulgham@gmail.com> · c1c99561
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=17644
              Build GTK on Mac OS X using native ICU library
      
              Use Apple native ICU libraries when building GTK
              webkit on Mac OS.
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1c99561
    • andersca@apple.com's avatar
      Reviewed by Darin and Sam. · ae3f8c23
      andersca@apple.com authored
              Include fixes, in preparation of using the headers in WebCore/bridge.
              
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_dom.cpp:
              * bindings/objc/DOMInternal.mm:
              * bindings/objc/DOMUtility.mm:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bridge/objc/objc_class.h:
              * bridge/objc/objc_instance.h:
              * bridge/objc/objc_runtime.h:
              * bridge/objc/objc_utility.h:
              * bridge/runtime.h:
              * bridge/runtime_object.h:
              * bridge/runtime_root.h:
              * html/HTMLAppletElement.cpp:
              * html/HTMLAppletElement.h:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLEmbedElement.h:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/HTMLPlugInElement.h:
              * page/mac/FrameMac.mm:
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
              * page/mac/WebCoreScriptDebugger.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae3f8c23