1. 28 Apr, 2010 19 commits
  2. 27 Apr, 2010 21 commits
    • dbates@webkit.org's avatar
      2010-04-27 Daniel Bates <dbates@rim.com> · 8ef22da0
      dbates@webkit.org authored
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=37686
      
              Fixes an issue where the canvas method strokeRect will stroke a
              rectangle whose dimensions are 0 when lineWidth > 1.
      
              As per the definition of strokeRect in the HTML Canvas 2D Context
              spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>,
              this method should have no effect when both the height and width
              are zero.
      
              Tests: fast/canvas/canvas-clearRect.html
                     fast/canvas/canvas-fillRect.html
      
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::validateRectForCanvas): Return false if height, width == 0.
      2010-04-27  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Oliver Hunt.
      
              https://bugs.webkit.org/show_bug.cgi?id=37686
      
              Tests that strokeRect does not paint any artifacts when the
              specified rectangle has height, width = 0 and lineWidth > 1.
      
              Also tests that clearRect, fillRect, and rect are ignored when
              height, width = 0.
      
              * fast/canvas/canvas-clearRect-expected.txt: Added.
              * fast/canvas/canvas-clearRect.html: Added.
              * fast/canvas/canvas-fillRect-expected.txt: Added.
              * fast/canvas/canvas-fillRect.html: Added.
              * fast/canvas/canvas-modify-emptyPath-expected.txt:
              * fast/canvas/canvas-strokeRect-expected.txt: Updated results.
              * fast/canvas/script-tests/canvas-clearRect.js: Added.
              * fast/canvas/script-tests/canvas-fillRect.js: Added.
              * fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case.
              * fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added
              debug statements so as to distinguish the results for each test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ef22da0
    • eric@webkit.org's avatar
      2010-04-27 Michael Nordman <michaeln@google.com> · 0a1d68fc
      eric@webkit.org authored
              Reviewed by Dmitry Titov.
      
              [Chromium] Add two things to the webkit API to support appcaches in workers.
              1) WebURLRequest TargetTypes for worker and shared worker main resources.
              2) Factory method on class WebCommonWorkerClient to
                 createApplicationCacheHost() for the associated worker.
      
              https://bugs.webkit.org/show_bug.cgi?id=38147
      
              * public/WebCommonWorkerClient.h: add the factory method
              * public/WebURLRequest.h: add the TargetTypes
              * src/WebWorkerBase.cpp: call the embedder's factory when needed
              (WebKit::WebWorkerBase::didCreateDataSource)
              (WebKit::WebWorkerBase::createApplicationCacheHost)
              * src/WebWorkerBase.h: ditto
              * src/WebWorkerClientImpl.h: add a stub impl of the factory method
              (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
      2010-04-27  Michael Nordman  <michaeln@google.com>
      
              Reviewed by Dmitry Titov.
      
              [Chromium] Add two things to the webkit API to support appcaches in workers.
              1) WebURLRequest TargetTypes for worker and shared worker main resources.
              2) Factory method on class WebCommonWorkerClient to
                 createApplicationCacheHost() for the associated worker.
      
              https://bugs.webkit.org/show_bug.cgi?id=38147
      
              * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method
              (TestWebWorker::createApplicationCacheHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a1d68fc
    • eric@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · 8d9ea0cd
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove obsolete custom bindings file
              https://bugs.webkit.org/show_bug.cgi?id=38223
      
              We don't need these files anymore because they are empty.
      
              * Android.jscbindings.mk:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSAbstractWorkerCustom.cpp: Removed.
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSDocumentFragmentCustom.cpp: Removed.
              * bindings/js/JSEventSourceCustom.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d9ea0cd
    • eric@webkit.org's avatar
      2010-04-27 Daniel Cheng <dcheng@chromium.org> · 8a8b11d5
      eric@webkit.org authored
              Reviewed by Jian Li.
      
              [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging.
              https://bugs.webkit.org/show_bug.cgi?id=38227
      
              Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work
              since the default drop handling uses the drag data URL to navigate to dropped files/URLs.
              For now, we hack around the problem in the Chromium platform, but the proper long term
              solution is to change DragController::performDrag to check dragData::asFilenames().
      
              No new tests.
      
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::ClipboardChromium::getData):
              (WebCore::ClipboardChromium::types):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a8b11d5
    • tkent@chromium.org's avatar
      2010-04-27 Kent Tamura <tkent@chromium.org> · 6d26e81d
      tkent@chromium.org authored
              Reviewed by Shinichiro Hamaji.
      
              [DRT/Chromium] Enable Windows project generation
              https://bugs.webkit.org/show_bug.cgi?id=38103
      
              - Avoid platform.system(), which causes a crash with python.exe in
                depot_tools. Use sys.platform instead.
              - Process DumpRenderTree.gyp on all platforms.
      
              * gyp_webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d26e81d
    • eric@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · 2c4ea47d
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              run-bindings-tests doesn't work in an SVN checkout
              https://bugs.webkit.org/show_bug.cgi?id=38225
      
              Previously detect_scm_system needed an absolute path for SVN.  Now we
              accept a relative path.
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c4ea47d
    • simon.fraser@apple.com's avatar
      2010-04-27 Simon Fraser <simon.fraser@apple.com> · b30d73b5
      simon.fraser@apple.com authored
              Reviewed by the inimitable Dan Bernstein.
      
              SVG as background image renders incorrectly after zooming
              https://bugs.webkit.org/show_bug.cgi?id=38215
      
              When doing a partial redraw of an SVGImage used as a CSS background
              image, we're limited to drawing the entire Frame, clipped to the dirty rect.
              Because of this, we need to fix up the CTM so that the origin is at the
              top left of the unclipped image, rather than the top left of the
              portion being redrawn.
      
              Test: fast/images/svg-background-partial-redraw.html
      
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b30d73b5
    • yuzo@google.com's avatar
      2010-04-27 Yuzo Fujishima <yuzo@google.com> · 1fcfaa52
      yuzo@google.com authored
              Reviewed by David Hyatt.
      
              Retry of: Enhance CSS parser for Paged Media (Iteration 1)
      
              In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
              The contents of the methods should be implemented by other changes.
      
              https://bugs.webkit.org/show_bug.cgi?id=35329
      
              * fast/css/parsing-page-rule-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
              * fast/css/parsing-page-rule.html: Added.
      2010-04-27  Yuzo Fujishima  <yuzo@google.com>
      
              Reviewed by David Hyatt.
      
              Retry of: Enhance CSS parser for Paged Media (Iteration 1)
      
              In this change, the grammar is extended and skeletal methods for creating page rules and margin at-rules are defined.
              The contents of the methods should be implemented by other changes.
      
              https://bugs.webkit.org/show_bug.cgi?id=35329
      
              Test: fast/css/parsing-page-rule.html
      
              * css/CSSGrammar.y:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::CSSParser):
              (WebCore::CSSParser::clearProperties):
              (WebCore::CSSParser::createPageRule):
              (WebCore::CSSParser::createMarginAtRule):
              (WebCore::CSSParser::startDeclarationsForMarginBox):
              (WebCore::CSSParser::endDeclarationsForMarginBox):
              * css/CSSParser.h:
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::pseudoId):
              (WebCore::nameToPseudoTypeMap):
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              (WebCore::CSSSelector::):
              * css/tokenizer.flex:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fcfaa52
    • jchaffraix@webkit.org's avatar
      Unreviewed, rolling out my changes as it rendered the Qt bot unreliable. · 5cc9ccfc
      jchaffraix@webkit.org authored
      WebCore:
      
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
      (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
      (WebCore::DocumentThreadableLoader::loadRequest):
      
      LayoutTests:
      
      * http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Removed.
      * http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Removed.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Removed.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Removed.
      * http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Removed.
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cc9ccfc
    • jchaffraix@webkit.org's avatar
      Unreviewed. · e741bf14
      jchaffraix@webkit.org authored
      * platform/qt/Skipped: Add the 2 newly added test cases to the list
      as they involve preflight requests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e741bf14
    • jchaffraix@webkit.org's avatar
      [XHR] Cross-Origin synchronous request with credential raises NETWORK_ERR · 9c946e8d
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37781
      <rdar://problem/7905150>
      
      Reviewed by Alexey Proskuryakov.
      
      WebCore:
      
      Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html
             http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
      
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the
      credential from the request here to avoid forgetting to do so in the different code path.
      (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the
      "Origin" header.
      (WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have
      been removed so that we don't leak them. Also tweaked a comment to make it clear that
      the URL check has issue when credential is involved.
      
      LayoutTests:
      
      Test that doing a cross-origin request with a preflight check does
      not raise a NETWORK_ERR exception and does not send the credentials.
      
      * http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added.
      * http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added.
      * http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c946e8d
    • eric@webkit.org's avatar
      2010-04-27 Jay Civelli <jcivelli@chromium.org> · 851ec1e4
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Makes clicking a select element close its associated popup if
              it is open.
              https://bugs.webkit.org/show_bug.cgi?id=38105
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::mouseDown):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      851ec1e4
    • eric@webkit.org's avatar
      2010-04-27 Jay Civelli <jcivelli@chromium.org> · 0094033c
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Merged the WebView public method to close suggestion popups
              into a single method to close all popups (select and suggestions).
              That ensures select popups are closed when the browser window is moved
              or resized.
              https://bugs.webkit.org/show_bug.cgi?id=37837
      
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::hidePopups):
              (WebKit::WebViewImpl::hideSuggestionsPopup):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0094033c
    • weinig@apple.com's avatar
      Always build WebKit2 when building on SnowLeopard and later. · fb6885b2
      weinig@apple.com authored
      Reviewed by Stephanie Lewis.
      
      * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb6885b2
    • weinig@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=38238 · 6eef403f
      weinig@apple.com authored
      Allow both WebKit and WebKit2 to link to the same WebCore.framework
      
      Reviewed by Maciej Stachowiak.
      
      WebCore: 
      
      * Configurations/WebCore.xcconfig: Use -allowable_client WebKit2 to add
      WebKit2 to the list of frameworks that can link directly to WebCore. It
      is not necessary for it to be an umbrella since we don't need to reexport
      any symbols.
      
      WebKit2: 
      
      * Configurations/WebKit2.xcconfig: Remove the OTHER_LDFLAGS. We don't
      need to set WebCore as a sub_umbrella of WebKit2, since we are not
      reexporting any of its symbols.
      
      WebKitTools: 
      
      * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
      WebCore for WebKit2, it is no longer necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6eef403f
    • dumi@chromium.org's avatar
      WebCore: Turn on AUTO_VACUUM = INCREMENTAL for all HTML5 databases. · f5e8310e
      dumi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=38191
      
      Reviewed by David Levin.
      
      Vacuum all databases when the number of free pages is at least 10%
      of the number of total pages. Also, add a guard against a bug that
      was fixed in SQLite only starting with version 3.6.16.
      
      * platform/sql/SQLiteDatabase.cpp:
      (WebCore::SQLiteDatabase::maximumSize):
      (WebCore::SQLiteDatabase::freeSpaceSize):
      (WebCore::SQLiteDatabase::totalSize):
      (WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
      (WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):
      * platform/sql/SQLiteDatabase.h:
      (WebCore::SQLiteDatabase::):
      * platform/sql/SQLiteStatement.cpp:
      (WebCore::SQLiteStatement::prepare):
      (WebCore::SQLiteStatement::step):
      * storage/Database.cpp:
      (WebCore::Database::performOpenAndVerify):
      (WebCore::Database::incrementalVacuumIfNeeded):
      * storage/Database.h:
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::postflightAndCommit):
      
      LayoutTests: Adjusting the expected amount of space used by quota-tracking.html.
      https://bugs.webkit.org/show_bug.cgi?id=38191
      
      Reviewed by David Levin.
      
      The expectations changed because of AUTO_VACUUM's overhead.
      
      * platform/chromium/test_expectations.txt:
      * storage/quota-tracking-expected.txt:
      * storage/quota-tracking.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5e8310e
    • jam@chromium.org's avatar
      2010-04-27 John Abd-El-Malek <jam@chromium.org> · f0d72f45
      jam@chromium.org authored
              Reviewed by Darin Adler.
      
              Remove unnecessary header now that Chrome is updated
              https://bugs.webkit.org/show_bug.cgi?id=38211
      
              * public/win/WebThemeEngine.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0d72f45
    • jamesr@google.com's avatar
      2010-04-27 James Robinson <jamesr@chromium.org> · 92d1cf8e
      jamesr@google.com authored
              Reviewed by David Levin.
      
              Fix a typo in chromium.py that causes NRWT to fail in --verbose
              mode in a Chromium checkout.
              https://bugs.webkit.org/show_bug.cgi?id=38234
      
              * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92d1cf8e
    • eric@webkit.org's avatar
      2010-04-27 Garret Kelly <gdk@chromium.org> · fb485b06
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Turn all of the touch event handlers into RuntimeEnabledFeatures, and
              modify the createEvent methond on Document so that it won't create a
              TouchEvent if the feature is disabled.
              https://bugs.webkit.org/show_bug.cgi?id=37485
      
              * bindings/generic/RuntimeEnabledFeatures.cpp:
              * bindings/generic/RuntimeEnabledFeatures.h:
              (WebCore::RuntimeEnabledFeatures::touchEnabled):
              (WebCore::RuntimeEnabledFeatures::setTouchEnabled):
              (WebCore::RuntimeEnabledFeatures::ontouchstartEnabled):
              (WebCore::RuntimeEnabledFeatures::ontouchmoveEnabled):
              (WebCore::RuntimeEnabledFeatures::ontouchendEnabled):
              (WebCore::RuntimeEnabledFeatures::ontouchcancelEnabled):
              * dom/Document.cpp:
              (WebCore::Document::createEvent):
              * dom/Document.idl:
              * dom/Element.idl:
              * page/DOMWindow.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb485b06
    • eric@webkit.org's avatar
      2010-04-27 Jens Alfke <snej@chromium.org> · 811b43c4
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Add some notifications and an accessor to WebKit API
              https://bugs.webkit.org/show_bug.cgi?id=37625
      
              * dom/Node.cpp:
              (WebCore::Node::hasNonEmptyBoundingBox): New method.
              * dom/Node.h:
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isKeyboardFocusable): Moved part of method into new Node method
      2010-04-27  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] Add some notifications and an accessor to WebKit API
              https://bugs.webkit.org/show_bug.cgi?id=37625
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::didFirstLayout):
              (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
              * public/WebNode.h:
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout):
              (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
              * src/WebElement.cpp:
              * src/WebNode.cpp:
              (WebKit::WebNode::hasNonEmptyBoundingBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      811b43c4
    • evan@chromium.org's avatar
      2010-04-27 Evan Martin <evan@chromium.org> · 854fd269
      evan@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] update test expectations for ancient linux bug
              https://bugs.webkit.org/show_bug.cgi?id=38229
      
              According to
              http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
              this hasn't crashed in a long time, so the CRASH annotation is superfluous.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      854fd269