1. 18 Apr, 2012 5 commits
    • commit-queue@webkit.org's avatar
      [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE · a2d33a01
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84229
      
      CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
      subsequent builds, stopping WebCore from being built ever again.
      
      Instead of trying to emulate a build target using command line options,
      just build the existing jsc target directly.
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
      Reviewed by Rob Buis.
      
      .:
      
      * CMakeLists.txt:
      
      Tools:
      
      * Scripts/build-jsc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2d33a01
    • commit-queue@webkit.org's avatar
      [GTK] r114021 triggered media flakyness · 49ee4cd4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83874
      
      Patch by Simon Pena <spena@igalia.com> on 2012-04-18
      Reviewed by Philippe Normand.
      
      Source/WebKit/gtk:
      
      When the MediaPlaybackRequiresUserGesture setting was added, no gtk
      API was implemented to access it.
      
      This adds a property to gtk WebKit WebSettings, and connects it to
      WebKit WebView, thus allowing clients to programmatically modify it.
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_class_init):
      (webkit_web_settings_set_property):
      (webkit_web_settings_get_property):
      * webkit/webkitwebsettingsprivate.h:
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings):
      (webkit_web_view_settings_notify):
      
      Tools:
      
      Now that there is gtk API to update the
      MediaPlaybackRequiresUserGesture property, set it to false from the
      DumpRenderTree tool when resetting defaults to consistent values.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (resetDefaultsToConsistentValues):
      
      LayoutTests:
      
      media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html where enabling
      MediaPlaybackRequiresUserGesture when run, so tests running
      concurrently would fail -they would pass when run independently.
      
      Since new API is added to ensure DumpRenderTree is able to reset
      that setting, having media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html no longer causes
      flakiness.
      
      * platform/gtk/test_expectations.txt: Unskip
      media/video-load-require-user-gesture.html and
      media/video-play-require-user-gesture.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ee4cd4
    • commit-queue@webkit.org's avatar
      Web Inspector: Disabling Inspector causes build failure on Windows · cd728636
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83557
      
      Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
      Reviewed by Pavel Feldman.
      
      The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
      This change brings all such API calls under the guard.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebInspectorClient.cpp:
      * WebInspector.cpp:
      * WebNodeHighlight.cpp:
      (WebNodeHighlight::WebNodeHighlight):
      (WebNodeHighlight::update):
      * WebNodeHighlight.h:
      (WebNodeHighlight):
      * WebView.cpp:
      (WebView::WebView):
      (WebView::close):
      (WebView::initWithFrame):
      (WebView::inspector):
      * WebView.h:
      (WebView):
      
      Tools:
      
      * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
      (WTR::LayoutTestController::showWebInspector):
      (WTR::LayoutTestController::closeWebInspector):
      (WTR::LayoutTestController::evaluateInWebInspector):
      (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
      * WebKitTestRunner/TestInvocation.cpp:
      (WTR::TestInvocation::invoke):
      
      gi...
      cd728636
    • mario@webkit.org's avatar
      [GTK] atk/textChangedNotifications API test fails · 34bbd7a4
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84010
      
      Unreviewed, unskipping test after bug being fixed by r114311.
      
      * Scripts/run-gtk-tests:
      (TestRunner): Unskip now passing test.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34bbd7a4
    • commit-queue@webkit.org's avatar
      [BlackBerry] Viewport metatag doesn't disable double-tap zoom · a4014236
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84199
      
      Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
      Reviewed by George Staikos.
      
      Source/WebKit/blackberry:
      
      PR: 148279
      When we set "user-scalable=no" in viewport meta-tag and change any
      other WebSettings, the WebPage can turn to be scalable.
      This is a regression of the change master_32/SHA:fa0f8ee9. In that
      change, we used setUserScalable(webSettings->isUserScalable())
      in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
      case, as webSettings->isUserScalable() would always return true by
      default.
      Create a new API WebPage::setUserScalable which will be used in
      DumpRenderTree.cpp.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPage::setUserScalable):
      (WebKit):
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      * Api/WebPage.h:
      
      Tools:
      
      Revert a part of the change master_32/SHA:fa0f8ee9 and use
      WebPage::setUserScalable instead.
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4014236
  2. 17 Apr, 2012 13 commits
    • dpranke@chromium.org's avatar
      build-webkit: make ninja work with chromium linux · 9348191f
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84213
      
      Reviewed by Eric Seidel.
      
      Fix typos so that build-webkit will use ninja to
      build chromium if a build.ninja file exists and is up-to-date.
      
      * Scripts/webkitdirs.pm:
      (determineIsChromiumNinja):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9348191f
    • ojan@chromium.org's avatar
      Add caching to the flakiness dashboard json files · c5768351
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84198
      
      Reviewed by Dirk Pranke.
      
      * TestResultServer/handlers/testfilehandler.py:
      (GetFile._get_file_list):
      (GetFile._get_file_content):
      (GetFile._get_file_content_from_key):
      (GetFile._get_test_list_json):
      (GetFile._serve_json):
      Add a Last-Modified header and handle If-Modified-Since headers.
      (GetFile.get):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5768351
    • andersca@apple.com's avatar
      Source/WebKit2: Need a client callback for when the user tires to interact... · 6d741a97
      andersca@apple.com authored
      Source/WebKit2: Need a client callback for when the user tires to interact with an already unresponsive page
      https://bugs.webkit.org/show_bug.cgi?id=84201
      <rdar://problem/11140862>
      
      Reviewed by Andreas Kling.
      
      Add a interactionOccurredWhileProcessUnresponsive callback that's called when the unresponsiveness timer
      fires while it's already unresponsive.
      
      * UIProcess/API/C/WKPage.h:
      * UIProcess/ResponsivenessTimer.cpp:
      (WebKit):
      (WebKit::ResponsivenessTimer::timerFired):
      (WebKit::ResponsivenessTimer::start):
      * UIProcess/ResponsivenessTimer.h:
      (Client):
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::processDidBecomeUnresponsive):
      (WebKit):
      (WebKit::WebLoaderClient::interactionOccurredWhileProcessUnresponsive):
      * UIProcess/WebLoaderClient.h:
      (WebLoaderClient):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::interactionOccurredWhileProcessUnresponsive):
      (WebKit):
      * UIProcess/WebPageProxy.h:
      (WebPageProxy):
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
      (WebKit):
      * UIProcess/WebProcessProxy.h:
      (WebProcessProxy):
      
      Tools: Need a client callback for when the user tries to interact with an already unresponsive page
      https://bugs.webkit.org/show_bug.cgi?id=84201
      <rdar://problem/11140862>
      
      Reviewed by Andreas Kling.
      
      Add new client functions.
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d741a97
    • dpranke@chromium.org's avatar
      nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port · 76bd9a7e
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84190
      
      Reviewed by Ojan Vafai.
      
      LayoutTestHelper would exit when the user typed ctrl-c, but we
      would attempt to write to it to shut it down, generating an
      IOError.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      (ChromiumPort.stop_helper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76bd9a7e
    • dpranke@chromium.org's avatar
      rename --experimental-fully-parallel · 2b496844
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84188
      
      Reviewed by Ojan Vafai.
      
      I thought this was done long ago; rename
      --experimental-fully-parallel to just --fully-parallel and
      remove the --no- switch that AFAIK no one uses.
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager._run_tests):
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      (parse_args):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b496844
    • commit-queue@webkit.org's avatar
      EFL's LayoutTestController does not implement callShouldCloseOnWebView · a9c1869d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82301
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
      Reviewed by Martin Robinson.
      
      Source/WebKit/efl:
      
      Implement callShouldCloseOnWebView in EFL's LayoutTestController by
      calling shouldClose() on the FrameLoader, allowing the related
      test to be removed from the skip list.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      * WebCoreSupport/DumpRenderTreeSupportEfl.h:
      
      Tools:
      
      Implement callShouldCloseOnWebView in EFL's LayoutTestController by
      calling shouldClose() on the FrameLoader, allowing the related test
      to be removed from the skip list.
      
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      (LayoutTestController::callShouldCloseOnWebView):
      
      LayoutTests:
      
      Implement callShouldCloseOnWebView in EFL's LayoutTestController by
      calling shouldClose() on the FrameLoader, allowing the related test
      to be removed from the skip list.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9c1869d
    • commit-queue@webkit.org's avatar
      [EFL] Add setting API to enable/disable XSSAuditor · f0330aae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83281
      
      Source/WebKit/efl:
      
      Add setting API to enable or disable WebKit's XSSAuditor to protect
      from reflective cross-site scripting attacks. Also, emit the signal
      'xss,detected' and provide addition information received from
      XSSAuditor when reflected XSS is encountered in the page.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::didDetectXSS):
      * ewk/ewk_frame.cpp:
      (ewk_frame_xss_detected):
      * ewk/ewk_frame.h:
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (_ewk_view_priv_new):
      (ewk_view_setting_enable_xss_auditor_get):
      (ewk_view_setting_enable_xss_auditor_set):
      * ewk/ewk_view.h:
      
      Tools:
      
      Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
      in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
      'xss,detected' in DRT to enable a test, which is expecting a line containing
      'didDetectXSS' in the output when reflected XSS is encountered in the page.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::onFrameCreated):
      (DumpRenderTreeChrome::onDidDetectXSS):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
      (LayoutTestController::setXSSAuditorEnabled):
      
      LayoutTests:
      
      Unskip tests in http/tests/security/xssAuditor
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0330aae
    • commit-queue@webkit.org's avatar
      [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds · d3c233be
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=77533
      
      Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-04-17
      Reviewed by Simon Hausmann.
      
      Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
      the corresponding parameter to the buildQMakeProjects function.
      
      * Scripts/build-jsc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3c233be
    • commit-queue@webkit.org's avatar
      [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks() · 91cbe8fe
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83030
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      Source/WebKit/efl:
      
      Emit "load,started" and "onload,event" signals needed to support
      LayoutTestController's dumpFrameLoadCallbacks() in EFL's DumpRenderTree.
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
      (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
      * ewk/ewk_frame.cpp:
      (ewk_frame_load_committed):
      (ewk_frame_load_started):
      * ewk/ewk_frame.h:
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (ewk_view_load_started):
      (ewk_view_onload_event):
      * ewk/ewk_view.h:
      
      Tools:
      
      Implement support for LayoutTestController's dumpFrameLoadCallbacks()
      in EFL's DumpRenderTree. Make use of the new frame argument passed to
      the "load,started" and "load,finished" signals.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::onLoadStarted):
      (DumpRenderTreeChrome::processWork):
      (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
      (DumpRenderTreeChrome::onWebViewOnloadEvent):
      (DumpRenderTreeChrome::onInsecureContentRun):
      (DumpRenderTreeChrome::onInsecureContentDisplayed):
      (DumpRenderTreeChrome::onFrameCreated):
      (DumpRenderTreeChrome::onFrameProvisionalLoad):
      (DumpRenderTreeChrome::onFrameLoadCommitted):
      (DumpRenderTreeChrome::onFrameLoadFinished):
      (DumpRenderTreeChrome::onFrameLoadError):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      
      LayoutTests:
      
      Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
      support in the DumpRenderTree now that it is implemented.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91cbe8fe
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r114376. · 5a0990bf
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/114376
      https://bugs.webkit.org/show_bug.cgi?id=84155
      
      Wrong patch version committed, asked by the patch author.
      (Requested by rakuco on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-17
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
      (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
      (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      (FrameLoaderClientEfl):
      * ewk/ewk_frame.cpp:
      * ewk/ewk_frame.h:
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      * ewk/ewk_view.h:
      
      Tools:
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::processWork):
      (DumpRenderTreeChrome::onLoadFinished):
      (DumpRenderTreeChrome::onWillSendRequest):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      
      LayoutTests:
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a0990bf
    • commit-queue@webkit.org's avatar
      [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks() · d25d40ba
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83030
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-17
      Reviewed by Antonio Gomes.
      
      Source/WebKit/efl:
      
      Implement support for LayoutTestController's dumpFrameLoadCallbacks()
      in EFL's DumpRenderTree. We no longer emit the "load,finished" signal
      from postProgressFinishedNotification() since it is already emitted
      from dispatchDidFinishLoad(). This avoids unwanted extra signals we
      prevent some tests from passing (e.g.
      http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html).
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::postProgressFinishedNotification):
      (WebCore::FrameLoaderClientEfl::dispatchDidFinishLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidHandleOnloadEvents):
      (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      (FrameLoaderClientEfl):
      * ewk/ewk_frame.cpp:
      (ewk_frame_load_committed):
      * ewk/ewk_frame.h:
      * ewk/ewk_private.h:
      * ewk/ewk_view.cpp:
      (_Ewk_View_Private_Data):
      (ewk_view_onload_event):
      * ewk/ewk_view.h:
      
      Tools:
      
      Implement support for LayoutTestController's dumpFrameLoadCallbacks()
      in EFL's DumpRenderTree.
      
      * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
      (DumpRenderTreeChrome::createView):
      (DumpRenderTreeChrome::processWork):
      (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
      (DumpRenderTreeChrome::onWebViewOnloadEvent):
      (DumpRenderTreeChrome::onInsecureContentRun):
      (DumpRenderTreeChrome::onInsecureContentDisplayed):
      (DumpRenderTreeChrome::onFrameCreated):
      (DumpRenderTreeChrome::onFrameProvisionalLoad):
      (DumpRenderTreeChrome::onFrameLoadCommitted):
      (DumpRenderTreeChrome::onFrameLoadFinished):
      (DumpRenderTreeChrome::onFrameLoadError):
      * DumpRenderTree/efl/DumpRenderTreeChrome.h:
      (DumpRenderTreeChrome):
      
      LayoutTests:
      
      Unskip the test cases in EFL which needed dumpFrameLoadCallbacks()
      support in the DumpRenderTree now that it is implemented.
      
      * platform/efl/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d25d40ba
    • commit-queue@webkit.org's avatar
      [Qt] Fix builds with force_static_libs_as_shared for non-linux builds. · e61e3b5c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83035
      
      Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-04-17
      Reviewed by Simon Hausmann.
      
      The force_static_libs_as_shared feature for the Qt port will remove
      hide_symbols from Qt's CONFIG in order to make them visible to other
      libraries again.
      
      Due to an evaluation order problem in qmake, the flags for the C++ compiler
      that are set by adding hide_symbols to the CONFIG variables get applied
      to qmake's C++ compiler flags directly and hence trying to remove these
      later will not work and cause build failures when using the force_static_libs_as_shared
      feature of the Qt port.
      
      This is fixed by removing the flags that hide the exports from the compiler flags directly.
      
      * qmake/mkspecs/features/force_static_libs_as_shared.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e61e3b5c
    • rniwa@webkit.org's avatar
      Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot · cb0ee099
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84068
      
      Reviewed by Eric Seidel.
      
      Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
      automatically creates the build directory if needed.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (DownloadAndPerfTestFactory.__init__):
      (DownloadAndPerfTestWebKit2Factory.__init__):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb0ee099
  3. 16 Apr, 2012 13 commits
  4. 15 Apr, 2012 1 commit
  5. 14 Apr, 2012 1 commit
  6. 13 Apr, 2012 7 commits
    • jamesr@google.com's avatar
      [chromium] Remove unused compositeToTexture / compositeOffscreen setting · c4b51d2e
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83733
      
      Reviewed by Adrienne Walker.
      
      Source/Platform:
      
      Remove compositeOffscreen setting. This was an experiment that is no longer needed.
      
      * chromium/public/WebLayerTreeView.h:
      (WebKit::WebLayerTreeView::Settings::Settings):
      (Settings):
      
      Source/WebCore:
      
      Remove compositeOffscreen setting and implementation. This was an experiment that is no longer needed.
      
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::finishDrawingFrame):
      (WebCore::LayerRendererChromium::useRenderSurface):
      (WebCore::LayerRendererChromium::setScissorToRect):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (LayerRendererChromium):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCSettings::CCSettings):
      (CCSettings):
      
      Source/WebKit/chromium:
      
      Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
      
      * public/WebSettings.h:
      * src/WebLayerTreeView.cpp:
      (WebKit::WebLayerTreeView::Settings::operator CCSettings):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::WebSettingsImpl):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      Tools:
      
      Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
      
      * DumpRenderTree/chromium/DumpRenderTree.cpp:
      (main):
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::TestShell):
      (TestShell::resetWebSettings):
      * DumpRenderTree/chromium/TestShell.h:
      (TestShell):
      * DumpRenderTree/chromium/WebPreferences.cpp:
      (WebPreferences::reset):
      (WebPreferences::applyTo):
      * DumpRenderTree/chromium/WebPreferences.h:
      (WebPreferences):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114166 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4b51d2e
    • rniwa@webkit.org's avatar
      webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20), · 71c36b7e
      rniwa@webkit.org authored
      and also rebaseline the test results since we ignore the first run now.
      
      * Scripts/webkitpy/performance_tests/perftest.py:
      (PageLoadingPerfTest.run):
      * Scripts/webkitpy/performance_tests/perftest_unittest.py:
      (TestPageLoadingPerfTest.test_run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71c36b7e
    • rniwa@webkit.org's avatar
      Enable SVG page loading performance tests · a51c0b73
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83861
      
      Reviewed by Adam Barth.
      
      PerformanceTests: 
      
      Unskip PageLoad directory and skip tests that load too fast (less than 100ms) and are unstable,
      and the ones that take too long to load (more than 20s).
      
      * Skipped:
      
      Tools: 
      
      Add support for page loading tests. These are tests without any test running harnesses, and we use
      DriverOutput's test_timeout to measure the loading time.
      
      Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
      
      * Scripts/webkitpy/performance_tests/perftest.py:
      (PerfTest.run):
      (PerfTest):
      (PerfTest.run_failed):
      (PerfTest.parse_output):
      (PerfTest.output_statistics):
      (ChromiumStylePerfTest.parse_output):
      (PageLoadingPerfTest): Added.
      (PageLoadingPerfTest.__init__):
      (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
      * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
      (MockPrinter):
      (MockPrinter.__init__):
      (MockPrinter.write):
      (MainTest):
      (MainTest.test_parse_output):
      (MainTest.test_parse_output_with_failing_line):
      (TestPageLoadingPerfTest):
      (TestPageLoadingPerfTest.assertWritten):
      (TestPageLoadingPerfTest.MockDriver):
      (TestPageLoadingPerfTest.MockDriver.__init__):
      (TestPageLoadingPerfTest.MockDriver.run_test):
      (TestPageLoadingPerfTest.test_run):
      (TestPageLoadingPerfTest.test_run_with_bad_output):
      * Scripts/webkitpy/performance_tests/perftestsrunner.py:
      (PerfTestsRunner):
      (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
      (PerfTestsRunner._collect_tests):
      (PerfTestsRunner._run_tests_set):
      (PerfTestsRunner._run_single_test):
      * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
      (test_collect_tests_with_page_load_svg):
      (test_collect_tests_with_page_load_svg.add_file):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a51c0b73
    • beidson@apple.com's avatar
      <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600... · 325a6089
      beidson@apple.com authored
      <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600 Need WebKit2 API to notify whether history loads are in the page cache
      
      Source/WebKit2:
      
      - Add a new WKBundlePageLoaderClient callback allowing the bundle to be notified
        of back/forward navigations (and deny them if it chooses)
      - Add a new API to WKBundleBackForwardListItem to probe if the item is in the page cache.
      
      Reviewed by Darin Adler.
      
      Add the new WKBundleBackForwardListItem API:
      * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
      (WKBundleBackForwardListItemIsInPageCache):
      * WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
      * WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
      (WebKit::InjectedBundleBackForwardListItem::isInPageCache):
      
      Update the UI page loader client to allow for a user data object to be passed from the bundle:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      (WebKit::WebLoaderClient::shouldGoToBackForwardListItem): Update a comment typo.
      (WebKit::WebLoaderClient::willGoToBackForwardListItem): Update for the user data field.
      * UIProcess/WebLoaderClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::willGoToBackForwardListItem):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      Add the new callback to the bundle loader client:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
      (InjectedBundlePageLoaderClient):
      
      Call the bundle client before doing anything else, possibly canceling the navigation:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
      
      * WebProcess/qt/QtBuiltinBundlePage.cpp:
      (WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage) Adopt new bundle client interface.
      
      Tools:
      
      Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
      callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
      
      Reviewed by Darin Adler.
      
      * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
      (TestWebKitAPI::didFinishLoadForFrame):
      (TestWebKitAPI::willGoToBackForwardListItem):
      (TestWebKitAPI::setPageLoaderClient):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
      (ShouldGoToBackForwardListItemTest):
      (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
      (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
      (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114143 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      325a6089
    • commit-queue@webkit.org's avatar
      Group EFL bots into a category on the buildbot master · bb0dd520
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82712
      
      Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-13
      Reviewed by Adam Roben.
      
      Creating a new category definition on the buildbot frontend.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (loadBuilderConfig): Determine category for EFL bots
      * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb0dd520
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r113714. · 42d47fbe
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/113714
      https://bugs.webkit.org/show_bug.cgi?id=83887
      
      It is behaving strange on the bots and needs more
      investigation. (Requested by jeez_ on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
      
      Source/WebKit2:
      
      * UIProcess/qt/QtPageClient.cpp:
      (QtPageClient::isViewWindowActive):
      
      Tools:
      
      * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
      (WTR::PlatformWebView::PlatformWebView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42d47fbe
    • jocelyn.turcotte@nokia.com's avatar
      webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc · 762fb74f
      jocelyn.turcotte@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83690
      
      Reviewed by Tor Arne Vestbø.
      
      Typing part of an email and pressing <TAB> will bash-complete it using the list in
      Tools/Scripts/webkitpy/common/config/committers.py
      
      * Scripts/webkit-tools-completion.sh:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      762fb74f