1. 14 Feb, 2010 3 commits
  2. 13 Feb, 2010 5 commits
  3. 12 Feb, 2010 32 commits
    • ojan@chromium.org's avatar
      2010-02-12 Ojan Vafai <ojan@chromium.org> · 3d766a2f
      ojan@chromium.org authored
              Reviewed by Dan Bernstein.
      
              text-control-intrinsic-widths.html failing on tiger bot
              https://bugs.webkit.org/show_bug.cgi?id=34917
      
              Final cleanup for http://trac.webkit.org/changeset/54748.
              Some MS fonts don't come with a default install of Tiger, but do
              come with a default Leopard/SnowLeopard install. As a result we naturally
              get different metrics a page uses these fonts.
      
              * platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d766a2f
    • ojan@chromium.org's avatar
      2010-02-12 Ojan Vafai <ojan@chromium.org> · f42755cd
      ojan@chromium.org authored
              Reviewed by Maciej Stachowiak.
      
              Four textcontrol tests fail after http://trac.webkit.org/changeset/54748
              https://bugs.webkit.org/show_bug.cgi?id=34916
      
              -Put the baseline for text-control-intrinsic-widths in the right place!
              -I missed perspective-non-layer.html because we don't run it on Leopard.
              -Accidentally deleted drag-text-delay-expected.txt and text-control-intrinsic-widths-expected.txt
              instead of updating their results.
      
              * platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
              * platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
              * platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
              * platform/win/editing/selection/drag-text-delay-expected.txt: Added.
              * platform/win/fast/forms/text-control-intrinsic-widths-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f42755cd
    • ojan@chromium.org's avatar
      2010-01-05 Ojan Vafai <ojan@chromium.org> · 68b773d5
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              Improve text control instrinsic widths.
              https://bugs.webkit.org/show_bug.cgi?id=25566
              https://bugs.webkit.org/show_bug.cgi?id=25581
              https://bugs.webkit.org/show_bug.cgi?id=25958
      
              Excluding list of updated results as the list is so long.
      2010-01-05  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Dan Bernstein.
      
              Improve text control intrinsic widths.
              https://bugs.webkit.org/show_bug.cgi?id=25566
              https://bugs.webkit.org/show_bug.cgi?id=25581
              https://bugs.webkit.org/show_bug.cgi?id=25958
      
              For Mac fonts that have invalid avgCharWidth entries in the OS/2 table,
              fallback to the Safari 4- behavior of using the width of a zero. For other
              fonts, make Mac match Windows (and thus IE) metrics.
      
              Lucida Grande is hard-coded to match MS Shell Dlg for inputs and
              Courier New for textareas in order to match Safari Win, Firefox and, in
              some cases IE (IE uses different default fonts depending on encoding).
      
              The only case where we still don't match Windows is if no font-size is
              set. The default font-size for form controls on the Mac is smaller and
              thus text-control widths will be slightly smaller.
      
              No new tests. Covered by existing tests.
      
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::):
              (WebCore::RenderTextControl::hasValidAvgCharWidth):
              (WebCore::RenderTextControl::getAvgCharWidth):
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControl.h:
              (WebCore::RenderTextControl::scaleEmToUnits):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::getAvgCharWidth):
              * rendering/RenderTextControlMultiLine.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
              * rendering/RenderTextControlSingleLine.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68b773d5
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=33731 · 229936d0
      barraclough@apple.com authored
      Remove uses of PtrAndFlags from JIT data stuctures.
      
      Reviewed by Oliver Hunt.
      
      These break the OS X Leaks tool.  Free up a bit in CallLinkInfo, and invalid
      permutation of pointer states in MethodCallLinkInfo to represent the removed bits.
      
      * bytecode/CodeBlock.h:
      (JSC::CallLinkInfo::seenOnce):
      (JSC::CallLinkInfo::setSeen):
      (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
      (JSC::MethodCallLinkInfo::seenOnce):
      (JSC::MethodCallLinkInfo::setSeen):
      * jit/JIT.cpp:
      (JSC::JIT::unlinkCall):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::patchMethodCallProto):
      * runtime/UString.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      229936d0
    • ariya@webkit.org's avatar
      2010-02-11 Ariya Hidayat <ariya.hidayat@gmail.com> · f0ceea86
      ariya@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Unnecessary QBrush construction for doing a solid color stroke
              https://bugs.webkit.org/show_bug.cgi?id=34874
      
              Use the similar trick like in r54347, i.e. use the special brush for
              solid color to avoid expensive QBrush constructor.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::setPlatformStrokeColor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0ceea86
    • darin@apple.com's avatar
      Ignore compiled Python in more of webkitpy. · 32baf317
      darin@apple.com authored
      * Scripts/webkitpy/style/processors: Added property svn:ignore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32baf317
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=33731 · fcf25f7a
      barraclough@apple.com authored
      Many false leaks in release builds due to PtrAndFlags
      
      Reviewed by Darin Adler.
      
      Remove UntypedPtrAndBitfield (similar to PtrAndFlags) in UStringImpl,
      and steal bits from the refCount instead.
      
      * runtime/UStringImpl.cpp:
      (JSC::UStringImpl::baseSharedBuffer):
      (JSC::UStringImpl::~UStringImpl):
      * runtime/UStringImpl.h:
      (JSC::UStringImpl::cost):
      (JSC::UStringImpl::isIdentifier):
      (JSC::UStringImpl::setIsIdentifier):
      (JSC::UStringImpl::ref):
      (JSC::UStringImpl::deref):
      (JSC::UStringImpl::UStringImpl):
      (JSC::UStringImpl::bufferOwnerString):
      (JSC::UStringImpl::bufferOwnership):
      (JSC::UStringImpl::isStatic):
      (JSC::UStringImpl::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fcf25f7a
    • darin@chromium.org's avatar
      2010-02-11 Darin Fisher <darin@chromium.org> · a31ceb70
      darin@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Introduce WebCookieJar, and provide for a frame specific cookie jar.
      
              https://bugs.webkit.org/show_bug.cgi?id=34878
      
              * WebKit.gyp:
              * public/WebCookieJar.h: Added.
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::cookieJar):
              * public/WebKitClient.h:
              (WebKit::WebKitClient::cookieJar):
              (WebKit::WebKitClient::setCookies):
              (WebKit::WebKitClient::cookies):
              (WebKit::WebKitClient::rawCookies):
              (WebKit::WebKitClient::deleteCookie):
              (WebKit::WebKitClient::cookiesEnabled):
              * src/ChromiumBridge.cpp:
              (WebCore::getCookieJar):
              (WebCore::ChromiumBridge::setCookies):
              (WebCore::ChromiumBridge::cookies):
              (WebCore::ChromiumBridge::rawCookies):
              (WebCore::ChromiumBridge::deleteCookie):
              (WebCore::ChromiumBridge::cookiesEnabled):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a31ceb70
    • eric@webkit.org's avatar
      2010-02-12 Eric Seidel <eric@webkit.org> · 157a018b
      eric@webkit.org authored
              No review, rolling out r54694.
              http://trac.webkit.org/changeset/54694
              https://bugs.webkit.org/show_bug.cgi?id=34633
      
              This appears to have caused crashes on the Leopard bot.  See
              bug 34898.
      
              * websocket/tests/bufferedAmount-after-close-expected.txt: Removed.
              * websocket/tests/bufferedAmount-after-close.html: Removed.
              * websocket/tests/script-tests/bufferedAmount-after-close.js: Removed.
      2010-02-12  Eric Seidel  <eric@webkit.org>
      
              No review, rolling out r54694.
              http://trac.webkit.org/changeset/54694
              https://bugs.webkit.org/show_bug.cgi?id=34633
      
              This appears to have caused crashes on the Leopard bot.  See
              bug 34898.
      
              * websockets/ThreadableWebSocketChannelClientWrapper.h:
              (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
              * websockets/WebSocket.cpp:
              (WebCore::WebSocket::WebSocket):
              (WebCore::WebSocket::send):
              (WebCore::WebSocket::close):
              (WebCore::WebSocket::bufferedAmount):
              (WebCore::WebSocket::didConnect):
              (WebCore::WebSocket::didClose):
              * websockets/WebSocket.h:
              * websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::WebSocketChannel):
              (WebCore::WebSocketChannel::send):
              (WebCore::WebSocketChannel::bufferedAmount):
              (WebCore::WebSocketChannel::didClose):
              * websockets/WebSocketChannel.h:
              * websockets/WebSocketChannelClient.h:
              (WebCore::WebSocketChannelClient::didClose):
              * websockets/WorkerThreadableWebSocketChannel.cpp:
              (WebCore::workerContextDidClose):
              (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
              * websockets/WorkerThreadableWebSocketChannel.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      157a018b
    • barraclough@apple.com's avatar
      Workers' EventListeners should be removed before JSGlobalData is destroyed · 60fc15e7
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34903
      
      Reviewed by Sam Weinig.
      
      (Patch co-developed with Alexey Proskuryakov).
      
      Since http://trac.webkit.org/changeset/54460 the EventListeners registered by a
      worker thread are not removed until after the thread's JSGlobalData has been
      destroyed.  This is slightly worrisome since the JSEventListener contains
      JSObject*s, which will be dangling once the heap is destroyed.  The
      JSEventListeners may also reference the worker thread's normal world, which
      again it makes no sense to keep around after the JSGlobalData is freed.
      
      Remove all event listeners immediately prior to tearing down the JSGlobalData.
      
      https://bugs.webkit.org/show_bug.cgi?id=34728 addressed the symptoms of this
      problem, and it is probably cleaner to make the client data's normal world no
      longer be a member (since it is a ref-counted object), however they should be
      no requirement to 'detatch' – it makes no sense for anyone to be referencing
      the world after the JSGlobalData has gone away (the world's purpose is to hold
      wrapper objects in the JSGlobalData's heap).  Keep the restructuring that makes
      the normal world no longer be a member, but remove the detach mechanism this
      patch added & replace with stronger ASSERTs.
      
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
      * bindings/js/JSDOMBinding.h:
      (WebCore::WebCoreJSClientData::~WebCoreJSClientData):
      * workers/WorkerThread.cpp:
      (WebCore::WorkerThreadShutdownStartTask::performTask):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60fc15e7
    • eric@webkit.org's avatar
      2010-02-12 Pavel Feldman <pfeldman@chromium.org> · 143d1fb5
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Chromium: provide theme overrides for Chromium devtools on Mac.
      
              https://bugs.webkit.org/show_bug.cgi?id=34856
      
              * src/js/devTools.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      143d1fb5
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=33731 · 5fd99b7a
      barraclough@apple.com authored
      Remove uses of PtrAndFlags from WebCore::StringImpl.
      
      Reviewed by Sam Weinig.
      
      These break the OS X Leaks tool.  Use a bits stolen from the refCount to hold the
      'InTable' and 'HasTerminatingNullCharacter' flags, along with the string type
      (fixes a leak where the string data is allocated at the address (this + 1), and is
      misinterpreted as being an internal buffer).
      
      * WebCore.base.exp:
      * platform/text/StringImpl.cpp:
      (WebCore::StringImpl::StringImpl):
      (WebCore::StringImpl::~StringImpl):
      (WebCore::StringImpl::create):
      (WebCore::StringImpl::createWithTerminatingNullCharacter):
      (WebCore::StringImpl::crossThreadString):
      (WebCore::StringImpl::sharedBuffer):
      * platform/text/StringImpl.h:
      (WebCore::StringImpl::):
      (WebCore::StringImpl::hasTerminatingNullCharacter):
      (WebCore::StringImpl::inTable):
      (WebCore::StringImpl::setInTable):
      (WebCore::StringImpl::ref):
      (WebCore::StringImpl::deref):
      (WebCore::StringImpl::hasOneRef):
      (WebCore::StringImpl::operator new):
      (WebCore::StringImpl::bufferOwnership):
      * storage/OriginUsageRecord.cpp:
      (WebCore::OriginUsageRecord::addDatabase):
      (WebCore::OriginUsageRecord::markDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fd99b7a
    • zimmermann@webkit.org's avatar
      2010-02-12 Nikolas Zimmermann <nzimmermann@rim.com> · 1ab7403b
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Repaint bug on Text selection in foreignObject
              https://bugs.webkit.org/show_bug.cgi?id=16939
      
              Tests: svg/overflow/overflow-on-foreignObject.svg
                     svg/text/foreignObject-text-clipping-bug.xml
      
              Selecting text contained in <foreignObject> leads to artefacts. Same for zooming/panning.
              RenderForeignObject contained old legacy code returning FloatRect() for repaintRectInLocalCoordinates,
              which is obviously wrong. Fixing that leads to even more problems, as the underlying RenderBlock
              did not reflect the x/y translation set on the <foreignObject>. This is problematic, as laying out
              positioned objects in the XHTML subtree depends on proper size/location values of the frameRect.
      
              Correctly clip on overflow="hidden". overflow="scroll" & friends are not yet supported, see lengthy
              comment in RenderSVGBlock why we either need RenderLayer for RenderForeignObject or need to rework
              overflow handling to avoid RenderLayer.
      
              SVGForeignObjectElement uses a hacky custom solution to synchronize CSS width/height properties with
              the SVG width/height attributes. Remove all of that code and just implement calcWidth/calcHeight in
              RenderForeignObject, grabbing the right values from SVGForeignObjectElement::width/height upon layout.
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::paint): Clip properly to the actual bounds of the foreignObject, respecting that x/y translation is handled by RenderBlock now.
              (WebCore::RenderForeignObject::clippedOverflowRectForRepaint): Added missing function, forward to SVGRenderBase just like all other SVG renderers.
              (WebCore::RenderForeignObject::computeRectForRepaint): Remove manual implementation, forward to SVGRenderBase.
              (WebCore::RenderForeignObject::localToParentTransform): Respect x/y translation here _after_ applying localTransform().
              (WebCore::RenderForeignObject::calcWidth): Override RenderBlock::calcWidth to grab width() from SVGForeignObjectElement.
              (WebCore::RenderForeignObject::calcHeight): Override RenderBlock::calcHeight to grab height() from SVGForeignObjectElement.
              (WebCore::RenderForeignObject::layout): Calculate viewport once and cache it. Push x/y location down to RenderBlock - analogous to RenderSVGText.
              (WebCore::RenderForeignObject::nodeAtFloatPoint): Adapt to x/y translation changes (map through localTransform, not localToParentTransform). Respect overflow clipping.
              (WebCore::RenderForeignObject::mapLocalToContainer): Set useTransforms=true, to avoid assertions when selecting text in foreign objects.
              * rendering/RenderForeignObject.h:
              (WebCore::RenderForeignObject::objectBoundingBox): Return cached m_viewport.
              (WebCore::RenderForeignObject::strokeBoundingBox): Ditto.
              (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): Ditto.
              * rendering/RenderSVGBlock.cpp:
              (WebCore::RenderSVGBlock::setStyle): Cleanup code, move setHasOverflowClip() overrides in updateBoxModelInfoFromStyle where it belongs.
              (WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle): Added to force setting setHasOverflowClip(false).
              * rendering/RenderSVGBlock.h:
              * svg/SVGForeignObjectElement.cpp: Kill a lot of custom code - it was just plain wrong to utilize CSS to push width/height information down to RenderBlock.
              (WebCore::SVGForeignObjectElement::svgAttributeChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ab7403b
    • bweinstein@apple.com's avatar
      onmouseout fired when moving over tooltip on Windows · 550ca96d
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=16794
      <rdar://5762038>.
              
      Reviewed by Adam Roben.
      
      Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
      you mouse over the tooltip, it doesn't send a mouseout to the web content.
      
      * WebView.cpp:
      (WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      550ca96d
    • darin@apple.com's avatar
      Removed unneeded custom implementation of isDescendantOf. · 329af6c7
      darin@apple.com authored
      Reviewed by Sam Weinig.
      
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Use the
      -[NSView isDescendantOf:] method instead of our own method
      named superviewsHaveSuperviews.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      329af6c7
    • ggaren@apple.com's avatar
      Removed an unnecessary data dependency from my last patch. · 25ed4b99
      ggaren@apple.com authored
      Reviewed by Darin Adler.
      
      * runtime/SmallStrings.cpp:
      (JSC::SmallStrings::markChildren): Since isAnyStringMarked being false
      is a condition of entering the loop, we can just use '=' instead of '|='.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25ed4b99
    • jorlow@chromium.org's avatar
      2010-02-12 Jeremy Orlow <jorlow@chromium.org> · c39cde9c
      jorlow@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Add a blockedByPolicy output to WebStorageArea::setItem.
              https://bugs.webkit.org/show_bug.cgi?id=34897
      
              * public/WebStorageArea.h:
              (WebKit::WebStorageArea::setItem):
              * src/WebStorageAreaImpl.cpp:
              (WebKit::WebStorageAreaImpl::setItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c39cde9c
    • mitz@apple.com's avatar
      <rdar://problem/7615234> REGRESSION (r48586): Loading an HTML page causes · 0e83fb73
      mitz@apple.com authored
      PDFKit to be loaded
      
      Reviewed by Darin Adler.
      
      * WebView/WebPDFDocumentExtras.h: Removed the category declaration and
      addWebPDFDocumentExtras(). Declare allScriptsInPDFDocument().
      * WebView/WebPDFDocumentExtras.mm:
      (allScriptsInPDFDocument): Changed the -_web_allScripts method into this function.
      * WebView/WebPDFRepresentation.mm: Removed +initialize.
      (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use
      allScriptsInPDFDocument() instead of -_web_allScripts.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e83fb73
    • mitz@apple.com's avatar
      <rdar://problem/7609268> REGRESSION (r50301): Problem selecting text in a Devanagari website · 82a53f65
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34865
      
      Reviewed by Simon Fraser.
      
      WebCore: 
      
      Test: fast/text/glyph-reordering.html
      
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
      (WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): Added. Sets m_isMonotonic
      and populates m_glyphEndOffsets with the end offsets of each glyph’s corresponding character range.
      (WebCore::ComplexTextController::advance): For non-monotonic runs, use endOffsetAt() to get
      glyphs’ end offsets.
      (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Check for monotonicity and call
      setIsNonMonotonic() if needed.
      * platform/graphics/mac/ComplexTextController.h:
      (WebCore::ComplexTextController::ComplexTextRun::lastIndexAt): Added this getter.
      (WebCore::ComplexTextController::ComplexTextRun::isMonotonic): Ditto.
      * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
      (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isMonotonic.
      * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
      (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
      
      LayoutTests: 
      
      * fast/text/glyph-reordering-expected.txt: Added.
      * fast/text/glyph-reordering.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82a53f65
    • ukai@chromium.org's avatar
      Unreviewed trivial fix. · fe1dee14
      ukai@chromium.org authored
      Set Content-Type header, required for chromium test_shell.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe1dee14
    • ap@apple.com's avatar
      Reviewed by David Levin. · a9e9a2c6
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=34866
              Leopard Debug Bot crashed on fast/forms/old-names.html
      
              * html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Removed
              a misplaced checkConsistency() call. We are not looking at cache content at this point, and
              caches will be reset on next access.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9e9a2c6
    • jorlow@chromium.org's avatar
      2010-02-11 Jeremy Orlow <jorlow@chromium.org> · f862ea0f
      jorlow@chromium.org authored
              Reviewed by David Levin.
      
              [Chromium] Add ENABLE_RUBY to the feature defines gypi
              https://bugs.webkit.org/show_bug.cgi?id=34841
      
              * features.gypi:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f862ea0f
    • eric@webkit.org's avatar
      2010-02-12 Yury Semikhatsky <yurys@chromium.org> · 33ffb569
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Chromium: Web Inspector on an element in a page where JS is blocked crashes the renderer
      
              https://bugs.webkit.org/show_bug.cgi?id=34890
      
              * src/DebuggerAgentImpl.cpp:
              (WebKit::DebuggerAgentImpl::createUtilityContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33ffb569
    • vestbo@webkit.org's avatar
      Additional refptr/passrefptr workarounds for WINSCW compiler · 6b8ce242
      vestbo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28054
      
      Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
      
      Reviewed by Tor Arne Vestbø.
      
      * wtf/PassRefPtr.h:
      (WTF::refIfNotNull):
      (WTF::PassRefPtr::PassRefPtr):
      (WTF::PassRefPtr::~PassRefPtr):
      (WTF::PassRefPtr::clear):
      (WTF::::operator):
      * wtf/RefPtr.h:
      (WTF::RefPtr::RefPtr):
      (WTF::::operator):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b8ce242
    • eric@webkit.org's avatar
      2010-02-12 Diego Gonzalez <diego.gonzalez@openbossa.org> · 0d11af6f
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT now dump the frame loader callbacks when LayoutTestController()
              method is called.
      
              LayoutTests:
                  http/tests/security/mixedContent/data-url-script-in-iframe.html
                  http/tests/security/mixedContent/empty-url-plugin-in-frame.html
                  http/tests/security/mixedContent/insecure-css-in-iframe.html
                  http/tests/security/mixedContent/insecure-iframe-in-iframe.html
                  http/tests/security/mixedContent/insecure-image-in-iframe.html
                  http/tests/security/mixedContent/insecure-plugin-in-iframe.html
                  http/tests/security/mixedContent/insecure-script-in-iframe.html
                  http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
                  http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
      
              [Qt] Make possible Qt DRT dump frame load callbacks
              https://bugs.webkit.org/show_bug.cgi?id=34702
      
              * platform/qt/Skipped:
      2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT now dump the frame loader callbacks when LayoutTestController()
              method is called.
      
              LayoutTests:
                  http/tests/security/mixedContent/data-url-script-in-iframe.html
                  http/tests/security/mixedContent/empty-url-plugin-in-frame.html
                  http/tests/security/mixedContent/insecure-css-in-iframe.html
                  http/tests/security/mixedContent/insecure-iframe-in-iframe.html
                  http/tests/security/mixedContent/insecure-image-in-iframe.html
                  http/tests/security/mixedContent/insecure-plugin-in-iframe.html
                  http/tests/security/mixedContent/insecure-script-in-iframe.html
                  http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
                  http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
      
              [Qt] Make possible Qt DRT dump frame load callbacks
              https://bugs.webkit.org/show_bug.cgi?id=34702
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::didDisplayInsecureContent):
              (WebCore::FrameLoaderClientQt::didRunInsecureContent):
      2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt DRT now dump the frame loader callbacks when LayoutTestController()
              method is called.
      
              LayoutTests:
                  http/tests/security/mixedContent/data-url-script-in-iframe.html
                  http/tests/security/mixedContent/empty-url-plugin-in-frame.html
                  http/tests/security/mixedContent/insecure-css-in-iframe.html
                  http/tests/security/mixedContent/insecure-iframe-in-iframe.html
                  http/tests/security/mixedContent/insecure-image-in-iframe.html
                  http/tests/security/mixedContent/insecure-plugin-in-iframe.html
                  http/tests/security/mixedContent/insecure-script-in-iframe.html
                  http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
                  http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
      
              [Qt] Make possible Qt DRT dump frame load callbacks
              https://bugs.webkit.org/show_bug.cgi?id=34702
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              (LayoutTestController::dumpFrameLoadCallbacks):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d11af6f
    • hausmann@webkit.org's avatar
      Don't import the cmath functions from std:: for WINSCW. · 4ed81fe2
      hausmann@webkit.org authored
      Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12
      Reviewed by Simon Hausmann.
      
      * wtf/MathExtras.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ed81fe2
    • hausmann@webkit.org's avatar
      Make QtLauncher somewhat useable on S60. · f47f4ae5
      hausmann@webkit.org authored
      Reviewed by Antti Koivisto.
      
      Show the window fullscreen to make scrollbars appear, resize
      the toolbar buttons to 16x16 to give more screen space to
      web content and moved the location lineedit into a separate
      line.
      
      * QtLauncher/main.cpp:
      (LauncherWindow::LauncherWindow):
      * QtLauncher/mainwindow.cpp:
      (MainWindow::buildUI):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f47f4ae5
    • pfeldman@chromium.org's avatar
      2010-02-12 Pavel Feldman <pfeldman@chromium.org> · 6e899155
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: restore highlighting animation, bring back
              keyboard navigation, beautify search results.
      
              https://bugs.webkit.org/show_bug.cgi?id=34853
      
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer):
              (WebInspector.TextViewer.prototype.highlightLine):
              * inspector/front-end/textViewer.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e899155
    • eric@webkit.org's avatar
      2010-02-12 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> · 32246d3e
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Support frameset flattening
              https://bugs.webkit.org/show_bug.cgi?id=32717
      
              Add expected results of the FrameSet Flattening tests.
      
              * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: Added.
              * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
              * platform/mac/Skipped:
      2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Support frameset flattening
              https://bugs.webkit.org/show_bug.cgi?id=32717
      
              Add FrameSet Flattening support to Mac DRT.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setFrameSetFlatteningEnabled):
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setXSSAuditorEnabled):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setFrameSetFlatteningEnabled):
              * DumpRenderTree/LayoutTestController.cpp:
              (setFrameSetFlatteningEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setFrameSetFlatteningEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32246d3e
    • eric@webkit.org's avatar
      2010-02-12 Anton Muhin <antonm@chromium.org> · 30c5e9d5
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              [v8] handle to the document can only own Objects, not Values
              https://bugs.webkit.org/show_bug.cgi?id=34854
      
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::V8DOMWindowShell::updateDocumentWrapper):
              (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
              * bindings/v8/V8DOMWindowShell.h:
              * bindings/v8/custom/V8DocumentCustom.cpp:
              (WebCore::toV8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30c5e9d5
    • eric@webkit.org's avatar
      2010-02-12 Kwang Yul Seo <skyul@company100.net> · d5574b49
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Typedef both JSChar and UChar to wchar_t in RVCT.
              https://bugs.webkit.org/show_bug.cgi?id=34560
      
              Define both JSChar and UChar to wchar_t as the size
              of wchar_t is 2 bytes in RVCT.
      
              * API/JSStringRef.h:
              * wtf/unicode/qt4/UnicodeQt4.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5574b49
    • hausmann@webkit.org's avatar
      .: Removed WMLInputElement.* from .gitattributes as the file is · a793c0d2
      hausmann@webkit.org authored
      now CRLF clean.
      
      Reviewed by Holger Freyther.
      
      * .gitattributes:
      
      WebCore: Replaced stray CRLF with LF.
      
      Reviewed by Holger Freyther.
      
      * wml/WMLInputElement.cpp:
      (WebCore::WMLInputElement::suggestedValue):
      * wml/WMLInputElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a793c0d2