1. 08 Jul, 2006 8 commits
  2. 07 Jul, 2006 22 commits
    • ggaren's avatar
      - build fix · b2a04bbe
      ggaren authored
              * JSUtils.cpp:
              * JSValueWrapper.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · acef81d1
      justing authored
              Reviewed by levi
              * editing/selection/editable-non-editable-crash-expected.checksum: Added.
              * editing/selection/editable-non-editable-crash-expected.png: Added.
              * editing/selection/editable-non-editable-crash-expected.txt: Added.
              * editing/selection/editable-non-editable-crash.html: Added.
              * editing/selection/skip-non-editable-1-expected.txt:
              * editing/selection/skip-non-editable-1.html:
              Reviewed by levi
              Fix Mail ToDo crashers.
              * dom/Range.cpp:
              (WebCore::Range::compareBoundaryPoints): Added an ASSERT that both
              containers are non-null and an early return.
              * editing/Selection.cpp:
              (WebCore::Selection::validate): Fix a dangling start/end.
              (WebCore::Selection::adjustForEditableContent): Added an early return if
              m_start or m_end are null.
              (WebCore::Selection::isContentEditable): Use isRichlyEditablePosition.
    • ggaren's avatar
      Reviewed by Maciej. · 2564df29
      ggaren authored
              - Standardized which functions take a JSContext as an argument. The rule is:
              if you might execute JavaScript, you take a JSContext, otherwise you don't.
              The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
              but not API changes, so I'm putting it off until later.
              * API/JSCallbackObject.cpp:
              * API/JSCallbackObject.h:
              * API/JSContextRef.cpp:
              * API/JSContextRef.h:
              * API/JSObjectRef.cpp:
              * API/JSObjectRef.h:
              * API/testapi.c:
              * JavaScriptCore.exp:
              * kjs/array_object.cpp:
              * kjs/nodes.cpp:
    • ggaren's avatar
      Reviewed by Maciej. · 554ad6fb
      ggaren authored
              More API action.
              - Headerdoc finished
              Semantic Changes:
              - Added a JSContextRef argument to many functions, because you need a 
              JSContextRef for doing virtually anything. I expect to add this argument
              to even more functions in a future patch.
              - Removed the globalObjectPrototype argument to JSContextCreate because
              you can't create an object until you have a context, so it's impossible
              to pass a prototype object to JSContextCreate. That's OK because (1) there's
              no reason to give the global object a prototype and (2) if you really want
              to, you can just use a separate call to JSObjectSetPrototype.
              - Removed the JSClassRef argument to JSClassCreate because it was unnecessary,
              and you need to be able to make the global object's class before you've
              created a JSContext.
              - Added an optional exception parameter to JSFunctionMakeWithBody because anything
              less would be uncivilized.
              - Made the return value parameter to JSObjectGetProperty optional to match
              all other return value parameters in the API.
              - Made JSObjectSetPrivate/JSObjectGetPrivate work on JSCallbackFunctions
              and JSCallbackConstructors. You could use an abstract base class or strategic
              placement of m_privateData in the class structure to implement this, but 
              the former seemed like overkill, and the latter seemed too dangerous.
              - Fixed a bug where JSPropertyEnumeratorGetNext would skip the first property.
              Cosmetic Changes:
              - Reversed the logic of the JSChar #ifdef to avoid confusing headerdoc
              - Removed function names from @function declarations because headeroc
              can parse them automatically, and I wanted to rule out manual mismatch.
              - Changed Error::create to take a const UString& instead of a UString*
              because it was looking at me funny.
              - Renamed JSStringBufferCreateWithCFString to JSStringBufferCreateCF
              because the latter is more concise and it matches JSStringBufferCreateUTF8.
              * API/JSCallbackObject.cpp:
              * API/JSClassRef.cpp:
              * API/JSContextRef.cpp:
              * API/JSContextRef.h:
              * API/JSNode.c:
              * API/JSNodeList.c:
              * API/JSObjectRef.cpp:
              * API/JSObjectRef.h:
              * API/JSStringBufferRef.cpp:
              * API/JSStringBufferRef.h:
              * API/JSValueRef.cpp:
              * API/JSValueRef.h:
              * API/minidom.c:
              * API/minidom.js:
              * API/testapi.c:
              * JavaScriptCore.exp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lweintraub's avatar
      Reviewed by NOBODY · bec59b8c
      lweintraub authored
              Missed a few in the last update...
              * fast/forms/input-delete-expected.txt:
              * fast/repaint/inline-outline-repaint-expected.txt:
              * fast/repaint/selection-after-delete-expected.txt:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lweintraub's avatar
      LayoutTests: · 1bb7d0bf
      lweintraub authored
              Reviewed by justin
              Deletion editing deligates now show up!
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608445-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4083333-fix-expected.txt:
              * editing/deleting/delete-after-span-ws-001-expected.txt:
              * editing/deleting/delete-after-span-ws-002-expected.txt:
              * editing/deleting/delete-after-span-ws-003-expected.txt:...
    • beidson's avatar
      Reviewed by Anders and Tim Hatcher · f39c2c2e
      beidson authored
              Added an accessor to a SQLite config option to change its disk-syncing behavior.
              Used this accessor to significantly speed up writes to the Icon DB.
              * icon/IconDatabase.cpp:
              (WebCore::IconDatabase::open):  Disable full syncing to the SQLite db to speed up writes to the icondb
              * icon/SQLDatabase.cpp:
              * icon/SQLDatabase.h:
              (WebCore::SQLDatabase::):  Added accessor to the SQLite config pragma "synchronous"
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Maciej. · f6420c4e
      darin authored
              - fixed a storage leak noticed by the buildbot
              * dom/Document.cpp: (WebCore::Document::removedLastRef):
              Call delete on the markers before clearing the map containing them.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      2006-07-08 Anders Carlsson <acarlsson@apple.com> · ee9cb8ce
      andersca authored
              Reviewed by Brady.
              Reproducible crash in Loading/Frames in ToT.
              The problem was that the renderpart destructor resets the frame's 
              owner element. For iframes, this should only be done when the element is 
              going to be removed from the document.
              * html/HTMLIFrameElement.cpp:
              * html/HTMLIFrameElement.h:
              Remove the frame in willRemove instead.
              * rendering/RenderPart.cpp:
              * rendering/RenderPart.h:
              Don't call setFrame(0) in the destructor when the element is an iframe element.
    • darin's avatar
      Reviewed by Anders. · ffcfdbfc
      darin authored
              - fixed a storage leak noticed by the buildbot
              * page/FrameView.cpp: (WebCore::FrameViewPrivate::~FrameViewPrivate):
              Delete m_scheduledEvents.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      Added a bug number to an existing entry. · 022d8cc6
      sullivan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Adele. · 3e71c118
      darin authored
              - fixed a couple of storage leaks noticed by the buildbot
              * html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach):
              Call deref on the style after calling setRenderStyle, since styleForRenderer
              returns us a "ref'd" RenderStyle object.
              * html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Adele. · 22a690e4
      darin authored
              - fix some license mistakes
              * LICENSE-APPLE: Added more years of publication to the copyright here.
              * html/CanvasGradient.idl: Corrected license on this file. It had the wrong one.
              * html/CanvasPattern.idl: Ditto.
              * html/CanvasRenderingContext2D.idl: Ditto.
              * html/HTMLCanvasElement.idl: Ditto.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by John · cc1903cb
      beidson authored
              Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
              whose assertion was reproducibly causing a build bot failure
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase _releaseIconForIconURLString:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by John. · a7735565
      ggaren authored
              - Fixed a few crashes resulting from NULL parameters to JSClassCreate.
              * API/JSClassRef.cpp:
              * API/testapi.c: Added test for NULL parameters.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by John, mocked by Darin. · 80b420ae
      ggaren authored
              - Changed JSEvaluate to take a JSObjectRef instead of a JSValueRef as
              "this," since "this" must be an object.
              * API/JSContextRef.cpp:
              * API/JSContextRef.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ggaren's avatar
      Reviewed by John. · ab28d0b7
      ggaren authored
              - More headerdoc
              * API/JSBase.h:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lweintraub's avatar
      LayoutTests: · 6d377800
      lweintraub authored
              Reviewed by justin
              Improved table editing
              * editing/deleting/delete-to-select-table-expected.checksum: Added.
              * editing/deleting/delete-to-select-table-expected.png: Added.
              * editing/deleting/delete-to-select-table-expected.txt: Added.
              * editing/deleting/delete-to-select-table.html: Added.
              * editing/input/text-input-controller-expected.txt:
              Reviewed by justin
              Improved table editing: pressing delete directly before or after a table will now select
              the table first, then delete it, instead of just deleting it. Useful for when the table's
              existence is non-obvious.
              * bridge/mac/FrameMac.h: Added shouldDeleteSelection, which allows WebCore to trigger
              deletion editing deligates
              * bridge/mac/FrameMac.mm: ditto
              * bridge/mac/WebCoreFrameBridge.h: ditto
              * editing/TypingCommand.cpp: Implemented check for a caret position next to a table, and
              subsequent selection (as opposed to removal)
              * page/Frame.cpp: shouldDeleteSelection added
              * page/Frame.h: ditto
              Reviewed by justin
              Improved table editing
              * WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger
              deletion editing delegate
              (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
              * WebView/WebHTMLView.m: Moved code that expanded a selection when the delete
              key is pressed over to WebCore so we can be more intelligent about how to handle it
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by Eric. · 22601712
      weinig authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9768
                Split XSLImportRule out of XSLStyleSheet.* into separate 
                files (one class per file).
              * WebCore.xcodeproj/project.pbxproj:
              * xml/XSLImportRule.cpp: Added.
              * xml/XSLImportRule.h: Added.
              * xml/XSLStyleSheet.cpp:
              * xml/XSLStyleSheet.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      WebCore: · 10c1e341
      andersca authored
      2006-07-07  Anders Carlsson  <acarlsson@apple.com>
              Reviewed by Darin.
              REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons
              * css/html4.css:
              Set "-webkit-user-select: ignore" on radio buttons and check boxes .
      2006-07-07  Anders Carlsson  <acarlsson@apple.com>
              Reviewed by Darin.
              REGRESSION: First mouse click is randomly ignored when clicking on checkbox and radio buttons
              * fast/forms/radio-check-click-and-drag-expected.txt: Added.
              * fast/forms/radio-check-click-and-drag.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      Reviewed by Tim Hatcher · dc734562
      sullivan authored
              * WebKit.exp:
              added surprisingly missing _WebPreferencesChangedNotification, defined in
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Reviewed by Tim Hatcher. · 1e8c96ae
      mjs authored
              - fix 20 Node leaks on fast/events tests - these should be the last ones
              * bindings/objc/DOMEvents.mm:
              (-[DOMEvent dealloc]): implement - deref the event!
              (-[DOMEvent finalize]): ditto
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 06 Jul, 2006 10 commits
    • mjs's avatar
      Reviewed by Tim Hatcher. · e2d9abc1
      mjs authored
              - fix 26 Node leaks on fast/dom tests
              * dom/Document.cpp:
              (WebCore::Document::removedLastRef): delete tokenizer - if we are still parsing at this point, we don't
              want nodes held by the parser to keep the document alive.
              * html/HTMLParser.cpp:
              (WebCore::RefNonDocNodePtr::RefNonDocNodePtr): Smart pointer that acts like RefPtr for Node,
              but avoids refing document nodes to avoid cycles.
              (WebCore::RefNonDocNodePtr::operator UnspecifiedBoolType):
              (WebCore::HTMLStackElem): Use a RefNonDocNodePtr instead of RefPtr<Node>
              (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Use a RefPtr here to avoid crashing
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Maciej. · c1577332
      adele authored
              Fixed new popup control to open up when the spacebar and the up and down arrows are pressed.
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9762
              [Native pop up] Highlighted item text is black instead of white
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::isKeyboardFocusable): Added.
              (WebCore::HTMLSelectElement::isMouseFocusable): Added.
              (WebCore::HTMLSelectElement::defaultEventHandler): Updated to showPopup for up and down arrow keys and spacebar.
              * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Made this const.
              * rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Added FIXME.
              * rendering/RenderPopupMenuMac.mm:
              (WebCore::RenderPopupMenuMac::showPopup): Updated to save the NSEvent that triggers the popup, so we can send
              fake mouseUp and keyUp events when the NSMenu returns.
              (WebCore::RenderPopupMenuMac::addGroupLabel): Only set the NSForegroundColorAttributeName attribute if the text isn't black.
              Follow-up bug about other colors: http://bugzilla.opendarwin.org/show_bug.cgi?id=9769
              (WebCore::RenderPopupMenuMac::addOption): ditto.
              * bridge/mac/FrameMac.h: (WebCore::FrameMac::currentEvent): Returns the current NSEvent.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 61525d3d
      justing authored
              Reviewed by levi
              Mail crashes at WebCore::Selection::adjustForEditableContent
              Crash at WebCore::Range::compareBoundaryPoints
              * editing/selection/mixed-editability-1-expected.checksum: Added.
              * editing/selection/mixed-editability-1-expected.png: Added.
              * editing/selection/mixed-editability-1-expected.txt: Added.
              * editing/selection/mixed-editability-1.html: Added.
              * editing/selection/mixed-editability-2-expected.checksum: Added.
              * editing/selection/mixed-editability-2-expected.png: Added.
              * editing/selection/mixed-editability-2-expected.txt: Added.
              * editing/selection/mixed-editability-2.html: Added.
              Reviewed by levi
              Mail crashes at WebCore::Selection::adjustForEditableContent
              Crash at WebCore::Range::compareBoundaryPoints
              * editing/Selection.cpp:
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::next): Moved code into a helper function.
              (WebCore::VisiblePosition::previous): Ditto.
              * editing/htmlediting.cpp:
              (WebCore::comparePositions): Moved from Selection.cpp.
              (WebCore::lowestEditableAncestor): Added.  Returns rootEditableElement
              for a node in editable content and the rootEditableElement for the first
              ancestor that's editable for a node in non-editable content.
              * editing/htmlediting.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      WebCore: · c1c14c9b
      andersca authored
      2006-07-06  Anders Carlsson  <acarlsson@apple.com>
              Reviewed by Adele.
              REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes
              Patch by Darin, tweaked by Anders.
              * html/HTMLElement.cpp:
              Convert newline characters to <br> elements. I've verified that what's done here is what WinIE does when setting innerText.
              Fix comment.
              * rendering/RenderTextField.cpp:
              Remove assert. m_div->firstChild() can be null now because setInnerText doesn't create
              text nodes for empty strings anymore.
      2006-07-06  Anders Carlsson  <acarlsson@apple.com>
              Reviewed by Adele.
              REGRESSION: arrow key skips '>' in Bugzilla replies due to '\n' in text nodes
              * fast/dom/css-selectorText-expected.txt:
              * fast/dom/css-shortHands-expected.txt:
              Update tests.
              * fast/dom/set-inner-text-newlines-expected.txt: Added.
              * fast/dom/set-inner-text-newlines.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Tim Hatcher. · 0c114c5c
      adele authored
              - Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with 10.4.6 too)
              * page/FrameView.cpp: (WebCore::FrameView::layout): Ref's the view during layout, since a recalcStyle could cause the view to be deleted.
              If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exit layout.
              * page/FrameView.h: (WebCore::FrameView::hasOneRef): Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      WebCore: · 0afc15f0
      andersca authored
      2006-07-06  Anders Carlsson  <acarlsson@apple.com>
              Reviewed by Maciej.
              <rdar://problem/4610891> Support overflow events
              * DerivedSources.make:
              Add generated sources.
              * WebCore.xcodeproj/project.pbxproj:
              Add new files.
              * bindings/js/kjs_events.cpp:
              Support creating wrappers for overflow events..
              * bindings/objc/DOMEvents.h:
              * bindings/objc/DOMEvents.mm:
              (+[DOMEvent _eventWith:]):
              (-[DOMOverflowEvent _overflowEvent]):
              (-[DOMOverflowEvent orient]):
              (-[DOMOverflowEvent horizontalOverflow]):
              (-[DOMOverflowEvent verticalOverflow]):
              Add Objective-C wrapper for overflow events.
              * dom/Event.cpp:
              * dom/Event.h:
              * dom/EventNames.h:
              * dom/OverflowEvent.cpp: Added.
              * dom/OverflowEvent.h: Added.
              * dom/OverflowEvent.idl: Added.
              Add overflow events.
              * page/FrameView.cpp:
              Dispatch any scheduled events when layout is done.
              New function which schedules an event.
              Update overflow status for the viewport.
              New function which dispatches all scheduled events.
              * page/FrameView.h:
              Add declarations.
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayer.h:
              Schedule overflow events when overflow status changes.
      2006-07-06  Anders Carlsson  <acarlsson@apple.com>
              Reviewed by Maciej.
              <rdar://problem/4610891> Support overflow events
              * fast/events/overflow-events-expected.txt: Added.
              * fast/events/overflow-events.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Geoff. · ee502950
      thatcher authored
              <rdar://problem/4610881> Expose scroll-related JS properties to ObjC DOM interface
              <rdar://problem/4519675> offsetLeft, offsetTop, offsetHeight, and offsetWidth
              properties are not exposed to ObjC
              * bindings/objc/DOMPrivate.h:
              * bindings/objc/DOMHTML.mm:
              (-[DOMHTMLElement offsetLeft]):
              (-[DOMHTMLElement offsetTop]):
              (-[DOMHTMLElement offsetWidth]):
              (-[DOMHTMLElement offsetHeight]):
              (-[DOMHTMLElement offsetParent]):
              (-[DOMHTMLElement clientWidth]):
              (-[DOMHTMLElement clientHeight]):
              (-[DOMHTMLElement scrollLeft]):
              (-[DOMHTMLElement setScrollLeft:]):
              (-[DOMHTMLElement scrollTop]):
              (-[DOMHTMLElement setScrollTop:]):
              (-[DOMHTMLElement scrollWidth]):
              (-[DOMHTMLElement scrollHeight]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Reviewed by Adele. · c3a451d1
      mjs authored
              - fix 435 more layout tests Node leaks
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): fix more instances of leaked DOM ranges
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by John. · 1ab88e8e
      beidson authored
              Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
              is closing
              * Misc/WebIconDatabase.m:
              (-[WebIconDatabase _releaseIconForIconURLString:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • harrison's avatar
      LayoutTests: · 31177985
      harrison authored
              Reviewed by Geoff.
              <rdar://problem/4565031> innerHTML of XMP tag returns special characters like '&gt;' instead of '>'
              * fast/innerHTML/006-expected.checksum: Added.
              * fast/innerHTML/006-expected.png: Added.
              * fast/innerHTML/006-expected.txt: Added.
              * fast/innerHTML/006.html: Added.
              Reviewed by Geoff
              <rdar://problem/4565031> innerHTML of XMP tag returns special characters like '&gt;' instead of '>'
              Test: fast/innerHTML/006.html
              * editing/markup.cpp:
              Do not special quote content of XMP nodes.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15185 268f45cc-cd09-0410-ab3c-d52691b4dbfc