1. 07 Feb, 2011 6 commits
  2. 06 Feb, 2011 28 commits
    • mjs@apple.com's avatar
      2011-02-06 Maciej Stachowiak <mjs@apple.com> · 5a5324d8
      mjs@apple.com authored
              Reviewed by Ryosuke Niwa.
      
              Update test expectations for new core builder
              https://bugs.webkit.org/show_bug.cgi?id=53904
      
              * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a5324d8
    • mjs@apple.com's avatar
      2011-02-06 Maciej Stachowiak <mjs@apple.com> · 92e50584
      mjs@apple.com authored
              Reviewed by David Levin.
      
              Add WebKit2 test bot to core builders
              https://bugs.webkit.org/show_bug.cgi?id=53901
      
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92e50584
    • rniwa@webkit.org's avatar
      2011-02-06 Ryosuke Niwa <rniwa@webkit.org> · 124a44cd
      rniwa@webkit.org authored
              Another unreviewed Chromium build fix.
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::pathToLocalResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      124a44cd
    • rniwa@webkit.org's avatar
      2011-02-06 Ryosuke Niwa <rniwa@webkit.org> · 65b7d282
      rniwa@webkit.org authored
              Unreviewed Chromium build fix.
      
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::pathToLocalResource):
      2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Unreviewed; speculative Qt build fix.
      
              * WebKit2.pro:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65b7d282
    • rniwa@webkit.org's avatar
      2011-02-06 Ryosuke Niwa <rniwa@webkit.org> · 41862b00
      rniwa@webkit.org authored
              Unreviewed; speculative Qt build fix.
      
              * JavaScriptCore.pro:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41862b00
    • rniwa@webkit.org's avatar
      2011-02-06 Ryosuke Niwa <rniwa@webkit.org> · a7dd30af
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
              https://bugs.webkit.org/show_bug.cgi?id=52867
      
              * DumpRenderTree/chromium/ImageDiff.cpp:
              (Image::craeteFromStdin): Call adoptArrayPtr.
      2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
              https://bugs.webkit.org/show_bug.cgi?id=52867
      
              Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
              and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
              OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
              no point in putting deleteOwnedArrayPtr into a separate header.
              
              Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
              without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.
      
              No tests are added since this is a refactoring.
      
              * API/JSStringRefCF.cpp:
              (JSStringCreateWithCFString): Calls adoptArrayPtr.
              * GNUmakefile.am: Removed OwnArrayPtrCommon.h
              * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
              * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
              * runtime/Arguments.cpp:
              (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
              * runtime/Arguments.h:
              (JSC::Arguments::copyRegisters): Ditto.
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
              * runtime/JSVariableObject.h:
              (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
              * runtime/StructureChain.cpp:
              (JSC::StructureChain::StructureChain): Ditto.
              * wtf/CMakeLists.txt:
              * wtf/DateMath.h:
              (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr
              with a null pointer.
              * wtf/OwnArrayPtr.h:
              * wtf/OwnArrayPtrCommon.h: Removed.
              * wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h
              (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h
      2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
              https://bugs.webkit.org/show_bug.cgi?id=52867
      
              * ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
      2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
              https://bugs.webkit.org/show_bug.cgi?id=52867
      
              * WebHistory.cpp:
              (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
              * WebPreferences.cpp:
              (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
      2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
              https://bugs.webkit.org/show_bug.cgi?id=52867
      
              * ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
              * bindings/v8/NPV8Object.cpp:
              (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of
              v8::Handle<v8::Value>*.
              (_NPN_Invoke): Calls createValueListFromVariantArgs.
              (_NPN_InvokeDefault): createValueListFromVariantArgs.
              (_NPN_Construct): createValueListFromVariantArgs.
              * bindings/v8/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr.
              (WebCore::ScriptFunctionCall::construct): Ditto.
              (WebCore::ScriptCallback::call):
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::V8DOMWindowShell::createNewContext): Ditto.
              * bindings/v8/V8NPObject.cpp:
              (WebCore::npObjectInvokeImpl): Ditto
              * bindings/v8/V8NodeFilterCondition.cpp:
              (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
              * html/HTMLAreaElement.cpp:
              (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr.
              (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto.
              (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
              * platform/Length.cpp:
              (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*.
              (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
              * platform/Length.h: Prototype changes.
              * platform/graphics/ANGLEWebKitBridge.cpp:
              (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
              * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
              (WebCore::getDirtyRects): Ditto.
              * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
              (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
              * platform/graphics/chromium/HarfbuzzSkia.cpp:
              (WebCore::glyphsToAdvances): Ditto.
              (WebCore::canRender): Ditto.
              * platform/graphics/gpu/Texture.cpp:
              (WebCore::Texture::updateSubRect): Ditto.
              * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
              (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
              * platform/graphics/wince/SharedBitmap.cpp:
              (WebCore::SharedBitmap::to16bit): Ditto.
              * platform/win/ContextMenuWin.cpp:
              (WebCore::ContextMenu::getContextMenuItems): Ditto.
              * platform/win/LoggingWin.cpp:
              (WebCore::initializeWithUserDefault): Ditto.
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackage::fetchInfo): Ditto.
      2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
              https://bugs.webkit.org/show_bug.cgi?id=52867
      
              * Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
              (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7dd30af
    • tkent@chromium.org's avatar
      2011-02-06 Kent Tamura <tkent@chromium.org> · d1a6608e
      tkent@chromium.org authored
              Unreviewed.
      
              * WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1a6608e
    • paroga@webkit.org's avatar
      2011-02-06 Patrick Gansterer <paroga@webkit.org> · fd5970f8
      paroga@webkit.org authored
              Reviewed by Martin Robinson.
      
              [WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
              https://bugs.webkit.org/show_bug.cgi?id=53896
      
              * WebView.cpp:
              (WebView::createFrame): Use coreFrame instead of childFrame.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd5970f8
    • morrita@google.com's avatar
      2011-02-06 MORITA Hajime <morrita@google.com> · 4c99e4fb
      morrita@google.com authored
              Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c99e4fb
    • morrita@google.com's avatar
      2011-02-06 Dominic Cooney <dominicc@google.com> · 9a756812
      morrita@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Convert <keygen> option elements to a shadow DOM
              https://bugs.webkit.org/show_bug.cgi?id=51379
      
              * html5lib/runner-expected.txt: Two more tests pass.
              * platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
              * platform/mac/fast/invalid/residual-style-expected.txt:
      2011-02-03  Dominic Cooney  <dominicc@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Convert <keygen> option elements to a shadow DOM
              https://bugs.webkit.org/show_bug.cgi?id=51379
      
              Covered by existing tests e.g. fast/html/keygen.html,
              html5lib/runner.html, etc.
      
              * css/html.css:
              (form): Cleanup.
              (keygen, select): Border radii should match so focus ring looks good.
              (keygen::-webkit-keygen-select): No margin on the shadow element.
              (select): Hoisting border radius to keygen, select rule.
              * dom/SelectElement.cpp:
              (WebCore::toSelectElement): keygen is no longer a select element.
              * html/HTMLKeygenElement.cpp: Implements keygen shadow.
              (WebCore::KeygenSelectElement::create):
              (WebCore::KeygenSelectElement::shadowPseudoId):
              (WebCore::KeygenSelectElement::KeygenSelectElement):
              (WebCore::HTMLKeygenElement::HTMLKeygenElement):
              (WebCore::HTMLKeygenElement::parseMappedAttribute):
              (WebCore::HTMLKeygenElement::appendFormData):
              (WebCore::HTMLKeygenElement::formControlType):
              (WebCore::HTMLKeygenElement::reset):
              (WebCore::HTMLKeygenElement::selectShadow):
              * html/HTMLKeygenElement.h: keygen is no longer a select on C++ side.
              (WebCore::HTMLKeygenElement::canStartSelection):
              (WebCore::HTMLKeygenElement::isEnumeratable):
              (WebCore::HTMLKeygenElement::isResettable):
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a756812
    • commit-queue@webkit.org's avatar
      2011-02-06 James Kozianski <koz@chromium.org> · bb4014cd
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Add classes for representing test outputs.
              https://bugs.webkit.org/show_bug.cgi?id=52136
      
              These classes will make it easier to write scripts that deal with test
              outputs such as rebaselining and deduping scripts. The intent is that
              eventually we will be have buildbot return TestOutputs for a
              particular build which can be compared with TestOutputs derived from a
              local LayoutTests directory.
      
              * Scripts/webkitpy/common/net/testoutput.py: Added.
              * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
              * Scripts/webkitpy/common/net/testoutputset.py: Added.
              * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
              * Scripts/webkitpy/common/system/zip_mock.py: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb4014cd
    • commit-queue@webkit.org's avatar
      2011-02-06 Benjamin Poulain <ikipou@gmail.com> · c19e1776
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Fix coding style errors in ClipboardQt.h
              https://bugs.webkit.org/show_bug.cgi?id=43520
      
              Fix coding style: order of header and indentation.
      
              * platform/qt/ClipboardQt.h:
              (WebCore::ClipboardQt::create):
              (WebCore::ClipboardQt::clipboardData):
              (WebCore::ClipboardQt::invalidateWritableData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c19e1776
    • paroga@webkit.org's avatar
      2011-02-06 Patrick Gansterer <paroga@webkit.org> · cd9284a2
      paroga@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Remove empty svg test
              https://bugs.webkit.org/show_bug.cgi?id=53887
      
              This files are empty.  Empty tests are pretty useless.
      
              * platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
              * platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
              * platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
              * platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
              * platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
              * svg/custom/use-infinite-recursion.svg: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd9284a2
    • antti@apple.com's avatar
      Use bloom filter for descendant selector filtering · e7457c48
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53880
              
      Reviewed by Maciej Stachowiak.
      
      Source/JavaScriptCore: 
      
      Implement a bloom filter with k=2 and 8 bit counting.
      
      * GNUmakefile.am:
      * JavaScriptCore.gypi:
      * JavaScriptCore.vcproj/WTF/WTF.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * wtf/BloomFilter.h: Added.
      (WTF::BloomFilter::maximumCount):
      (WTF::BloomFilter::BloomFilter):
      (WTF::BloomFilter::mayContain):
      (WTF::BloomFilter::add):
      (WTF::BloomFilter::remove):
      (WTF::BloomFilter::firstSlot):
      (WTF::BloomFilter::secondSlot):
      (WTF::::add):
      (WTF::::remove):
      (WTF::::clear):
      (WTF::::likelyEmpty):
      (WTF::::isClear):
      
      Source/WebCore: 
      
      Bloom filter is faster than a hash set in this kind of use.
              
      Shark thinks this speeds up style matching by ~30% on sites
      with lots of descendant selectors.
      
      * ForwardingHeaders/wtf/BloomFilter.h: Added.
      * css/CSSStyleSelector.cpp:
      (WebCore::collectElementIdentifierHashes):
      (WebCore::CSSStyleSelector::pushParent):
      (WebCore::CSSStyleSelector::popParent):
      (WebCore::CSSStyleSelector::fastRejectSelector):
      (WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
      * css/CSSStyleSelector.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7457c48
    • mjs@apple.com's avatar
      2011-02-06 Maciej Stachowiak <mjs@apple.com> · eac0efe7
      mjs@apple.com authored
              Reviewed by Antti Koivisto.
      
              media/video-document-types.html sometimes crashes the WebProcess
              https://bugs.webkit.org/show_bug.cgi?id=53884
      
              No new tests. Already covered by media/video-document-types.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer
              when cancelling the load.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eac0efe7
    • paroga@webkit.org's avatar
      2011-02-06 Patrick Gansterer <paroga@webkit.org> · 7f7d4331
      paroga@webkit.org authored
              Reviewed by Adam Roben.
      
              [WIN] Use WCHAR instead of TCHAR
              https://bugs.webkit.org/show_bug.cgi?id=53863
      
              We always use the UNICODE versions of windows functions, so
              the usage of TCHAR makes no sense and mixing them is bad style.
      
              * platform/graphics/win/IconWin.cpp:
              (WebCore::Icon::createIconForFiles):
              * platform/graphics/win/QTMovie.cpp:
              * platform/graphics/win/QTMovieGWorld.cpp:
              (QTMovieGWorld::fullscreenWndProc):
              (QTMovieGWorld::enterFullscreen):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              * platform/graphics/win/SimpleFontDataWin.cpp:
              * platform/graphics/wince/SimpleFontDataWinCE.cpp:
              * platform/win/BString.cpp:
              * platform/win/ClipboardWin.cpp:
              (WebCore::filesystemPathFromUrlOrTitle):
              (WebCore::createGlobalHDropContent):
              (WebCore::createGlobalImageFileDescriptor):
              * platform/win/ContextMenuWin.cpp:
              * platform/win/CursorWin.cpp:
              (WebCore::loadSharedCursor):
              * platform/win/FileChooserWin.cpp:
              (WebCore::FileChooser::basenameForWidth):
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              * platform/win/PopupMenuWin.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f7d4331
    • paroga@webkit.org's avatar
      2011-02-06 Patrick Gansterer <paroga@webkit.org> · da57356f
      paroga@webkit.org authored
              Reviewed by Andreas Kling.
      
              Replace FLT_MAX with std::numeric_limits
              https://bugs.webkit.org/show_bug.cgi?id=53861
      
              Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.
      
              * html/NumberInputType.cpp:
              * html/parser/HTMLParserIdioms.cpp:
              (WebCore::parseToDoubleForNumberType):
              * platform/brew/SystemTimeBrew.cpp:
              (WebCore::userIdleTime):
              * platform/efl/SystemTimeEfl.cpp:
              (WebCore::userIdleTime):
              * platform/efl/TemporaryLinkStubs.cpp:
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::setupAnimation):
              * platform/win/SystemTimeWin.cpp:
              (WebCore::userIdleTime):
              * platform/wx/SystemTimeWx.cpp:
              (WebCore::userIdleTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da57356f
    • robert@webkit.org's avatar
      2011-02-06 Robert Hogan <robert@webkit.org> · a60bb1c0
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Remove unnecessary QRect assignment
              https://bugs.webkit.org/show_bug.cgi?id=53873
      
              * Api/qwebframe.cpp:
              (QWebFramePrivate::renderRelativeCoords):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a60bb1c0
    • robert@webkit.org's avatar
      2011-02-06 Robert Hogan <robert@webkit.org> · 407bc442
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Clear page's groupName even when not in DRT
              https://bugs.webkit.org/show_bug.cgi?id=53874
      
              Matches behaviour of other ports.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::closeWindowSoon):
      2011-02-06  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Clear page's groupName even when not in DRT
              https://bugs.webkit.org/show_bug.cgi?id=53874
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::windowCloseRequested):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      407bc442
    • paroga@webkit.org's avatar
      2011-02-06 Patrick Gansterer <paroga@webkit.org> · e4e9c52a
      paroga@webkit.org authored
              Reviewed by Andreas Kling.
      
              [CMake] Add dependencies for Visual Studio projects
              https://bugs.webkit.org/show_bug.cgi?id=53773
      
              Add a JavaScriptCore dependecy to WebCore, so CMake can
              generate the correct build order for the solution.
      
              * CMakeLists.txt:
      2011-02-06  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [CMake] Add dependencies for Visual Studio projects
              https://bugs.webkit.org/show_bug.cgi?id=53773
      
              Add a WebCore dependecy to WebKit, so CMake can
              generate the correct build order for the solution.
      
              Remove JavaScriptCore dependecy, since WebCore already depends on it.
      
              * CMakeLists.txt:
      2011-02-06  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [CMake] Add dependencies for Visual Studio projects
              https://bugs.webkit.org/show_bug.cgi?id=53773
      
              Add a WebKit dependecy to WinCELauncher, so CMake can
              generate the correct build order for the solution.
      
              * CMakeListsWinCE.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4e9c52a
    • paroga@webkit.org's avatar
      2011-02-06 Patrick Gansterer <paroga@webkit.org> · 40cab8fe
      paroga@webkit.org authored
              Reviewed by Andreas Kling.
      
              [CMake] Unify ENABLE_SVG sections
              https://bugs.webkit.org/show_bug.cgi?id=53778
      
              * CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40cab8fe
    • mrobinson@webkit.org's avatar
      2011-02-06 Martin Robinson <mrobinson@igalia.com> · 88d8500f
      mrobinson@webkit.org authored
              Reclassify a failing test and unskip another which should be passing now.
      
              * platform/gtk/Skipped: Update the skipped list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88d8500f
    • andreas.kling@nokia.com's avatar
      2011-02-06 Andreas Kling <kling@webkit.org> · 5a5e46a6
      andreas.kling@nokia.com authored
              Reviewed by Dirk Schulze.
      
              Refactor Font::normalizeSpaces() to avoid an extra String copy.
              https://bugs.webkit.org/show_bug.cgi?id=53871
      
              Have normalizeSpaces() take UChar*,length arguments instead of a
              String, since all call sites were creating temporaries from these
              components anyway.
      
              Font::normalizeSpaces() now always makes 1 String copy,
              instead of 1 in the best case and 2 in the worst case.
      
              * platform/graphics/Font.cpp:
              (WebCore::Font::normalizeSpaces):
              * platform/graphics/Font.h:
              * platform/graphics/qt/FontQt.cpp:
              (WebCore::drawTextCommon):
              (WebCore::Font::floatWidthForSimpleText):
              (WebCore::Font::floatWidthForComplexText):
              (WebCore::Font::offsetForPositionForSimpleText):
              (WebCore::Font::offsetForPositionForComplexText):
              (WebCore::Font::selectionRectForSimpleText):
              (WebCore::Font::selectionRectForComplexText):
              * svg/SVGFont.cpp:
              (WebCore::SVGTextRunWalker::walk):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a5e46a6
    • andreas.kling@nokia.com's avatar
      2011-02-06 Andreas Kling <kling@webkit.org> · 6cae2a7c
      andreas.kling@nokia.com authored
              Reviewed by Antonio Gomes.
      
              [Qt] MiniBrowser: Clean up handling of titleChanged() signal
              https://bugs.webkit.org/show_bug.cgi?id=53869
      
              * MiniBrowser/qt/BrowserView.cpp:
              (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
              * MiniBrowser/qt/BrowserWindow.cpp:
              (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
              * MiniBrowser/qt/BrowserWindow.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cae2a7c
    • andreas.kling@nokia.com's avatar
      2011-02-06 Andreas Kling <kling@webkit.org> · 2112db6e
      andreas.kling@nokia.com authored
              Reviewed by Dirk Schulze.
      
              Fix potential buffer overrun in SVGTextRunWalker::walk()
              https://bugs.webkit.org/show_bug.cgi?id=53870
      
              A new String was created from a UChar* with a 'length' argument
              that could be greater than the number of UChars available.
      
              * svg/SVGFont.cpp:
              (WebCore::SVGTextRunWalker::walk):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2112db6e
    • commit-queue@webkit.org's avatar
      2011-02-06 Benjamin Poulain <ikipou@gmail.com> · b5a78b99
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] WebKit does not build on Mac with WebKit 2
              https://bugs.webkit.org/show_bug.cgi?id=53380
      
              * Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so
              we do not rely on recent kernel.
              (CoreIPC::Connection::readyReadHandler):
              * Platform/qt/SharedMemoryQt.cpp: ditto
              (WebKit::SharedMemory::create):
              (WebKit::SharedMemory::createHandle):
              * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is
              a Linux specific function.
              (WebKit::QtWebProcess::setupChildProcess):
              * UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac
              and the Mac port.
              * UIProcess/DrawingAreaProxyImpl.cpp: ditto
              * UIProcess/WebPageProxy.cpp: ditto
              (WebKit::WebPageProxy::didReceiveMessage):
              * WebProcess/WebPage/DrawingArea.cpp: ditto
              (WebKit::DrawingArea::create):
              * WebProcess/WebPage/DrawingArea.h:
              * WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
              * WebProcess/WebPage/WebPage.cpp: ditto
              (WebKit::WebPage::didReceiveMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a78b99
    • robert@webkit.org's avatar
      2011-02-06 Robert Hogan <robert@webkit.org> · f2792e17
      robert@webkit.org authored
              Unreviewed, skip failing test on Qt bot.
      
              [Qt]  fast/notifications/notifications-document-close-crash.html fails after r77738
              https://bugs.webkit.org/show_bug.cgi?id=53868
      
              * platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2792e17
    • mjs@apple.com's avatar
      2011-02-06 Maciej Stachowiak <mjs@apple.com> · 14862b6a
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
              https://bugs.webkit.org/show_bug.cgi?id=42690
              <rdar://problem/8213851>
      
              * platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that
              mysteriously fail.
      2011-02-06  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
              https://bugs.webkit.org/show_bug.cgi?id=42690
              <rdar://problem/8213851>
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::willSendRequestForFrame):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::LayoutTestController):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
              (WTR::LayoutTestController::willSendRequestReturnsNull):
              (WTR::LayoutTestController::setWillSendRequestReturnsNull):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14862b6a
  3. 05 Feb, 2011 6 commits