1. 02 Jan, 2003 5 commits
    • hyatt's avatar
      Fix for bug #3137935. When a float causes a line to get · a14d1741
      hyatt authored
      	moved down past the float, the line would incorrectly break
      	rather than expanding to use the newly-available width.
      
              Reviewed by darin.
      
              * khtml/rendering/bidi.cpp:
              (RenderFlow::findNextLineBreak):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a14d1741
    • darin's avatar
      Reviewed by John. · 5be0ed74
      darin authored
      	- fixed 3131190 -- <textarea wrap="hard"> eats text on blur
      
              * kwq/KWQTextArea.mm: (-[KWQTextArea paragraphs]): Add missing parentheses so we don't
      	always return 0 or 1 for the number of paragraphs.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5be0ed74
    • darin's avatar
      Reviewed by Don. · 55effb60
      darin authored
              - at Scott and Don's request, roll out small text anti-aliasing cutoff
      
              Turns out this makes small text look worse, not better. We're not going to respect
              this setting, and in Panther AppKit will almost certainly be changed not to either.
      
              * WebCoreSupport.subproj/WebTextRenderer.m: Rolled out yesterday's change using CVS.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55effb60
    • darin's avatar
      Reviewed by John and Don. · 23b9ad79
      darin authored
      	- fixed 3137661 -- REGRESSION: autoscroll selection is broken
      
      	The new logic in WebCore is slightly pickier, and can't abide a mouse-moved event
      	coming in during a drag. Unfortunately, we were sending a fake mouse-moved event
      	during a drag, so lets not do that.
      
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDown:]): Cancel any scheduled fake mouse-moved event.
              (-[WebHTMLView mouseUp:]): Send a fake mouse-moved event because we didn't update during the drag.
      
              * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]):
      	Don't schedule a fake mouse-moved event if the mouse is down, because that means we are in the
              middle of a drag.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23b9ad79
    • darin's avatar
      Reviewed by John and Ken. · bbd1f7da
      darin authored
      	- fixed 3135548 -- exception in Internet Explorer bookmark import code at first startup
      
              * Bookmarks.subproj/WebBookmarkImporter.m:
              (_breakStringIntoLines): Break lines before a <DT> or </DL>.
              (_HREFTextFromSpec): Rewrite to simplify, search in a case-insensitive manner.
              (-[WebBookmarkImporter initWithPath:]): Change prefix checks to be case-insensitive.
      	Don't discard folders altogether if the name can't be parsed as that would mess up
      	nesting w.r.t the next </DL>. Make the </DL> handling robust so we misparse, but don't
      	crash the whole application by raising an exception.
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for this change and recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbd1f7da
  2. 01 Jan, 2003 8 commits
    • rjw's avatar
      Obey the font smoothing size preference (3137618). · 92f3789b
      rjw authored
              Reviewed by Don and Darin.
      
              * WebCoreSupport.subproj/WebTextRenderer.m:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92f3789b
    • mjs's avatar
      WebCore: · 51e8fadc
      mjs authored
              Reviewed by Darin.
      
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
      
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
      	(KWQKHTMLPart::KWQKHTMLPart): Initialize new mouseDownMayStartDrag
      	and mouseDownMayStartSelect methods.
              (KWQKHTMLPart::khtmlMousePressEvent): Make sure a mouse down
      	won't be used to start a drag or selection if the default action
      	is prevented on the mouse down event.
      	(KWQKHTMLPart::mouseDown): Since the default action wasn't
      	prevented, decide if this might be the start of a drag or
      	selection.
              (KWQKHTMLPart::khtmlMouseMoveEvent): On a drag or selection, call
      	back to the bridge to handle selection or autoscrolling
      	appropriately.
      	* kwq/WebCoreBridge.h: Prototype new methods.
      
      WebKit:
      
      	Reviewed by Darin.
      
      	- fixed 3130831 - HOMEPAGE: JavaScript that tries to intercept onmousedown fails, image gets dragged instead
      	- fixed 3125554 - while dragging to select text in a nested frame, you can start dragging a link or image
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge handleMouseDragged:]): New method; call through the WebHTMLView.
              (-[WebBridge mayStartDragWithMouseDown:]): Likewise.
              (-[WebBridge handleAutoscrollForMouseDragged:]): Likewise.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView mouseDragged:]): Instead of doing drag handling
      	here, just pass the event to WebCore.
      	(-[WebHTMLView draggedImage:endedAt:operation:]): Send a fake
      	mousemove event instead of sending the current event (likely a
      	mouse up as if it were a mouse move).
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLViewPrivate dealloc]): Release drag element if any.
              (-[WebHTMLView _dragImageForElement:]): New method. Split out the
      	code to make the special drag image for links.
      	(-[WebHTMLView _handleMouseDragged:]): Move all the drag handling
      	here. This method will get called only if WebCore hasn't blocked
      	default drag handling.
              (-[WebHTMLView _handleAutoscrollForMouseDragged:]): Do
      	autoscroll. Autoscroll is still lame, we need a timer.
              (-[WebHTMLView _mayStartDragWithMouseDown:]): Determine if the element
      	is a link or image and so may be dragged; remember the drag element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51e8fadc
    • darin's avatar
      Reviewed by Don. · 9b33efdb
      darin authored
      	- fixed 3137566 -- non-reproducible nil-dereference in KHTMLView::clearPart
      	deallocating KWQPageState
      
              * kwq/KWQPageState.mm: (-[KWQPageState dealloc]): Add nil check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b33efdb
    • rjw's avatar
      Correct fix for 3137430 that doesn't always effectively disable · afb789f4
      rjw authored
              the cache.
      
              Reviewed by kocienda.
      
              * History.subproj/WebHistoryItem.m:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afb789f4
    • hyatt's avatar
      Fix tables so that malformations inside them are properly pulled · a176a20d
      hyatt authored
      	out of the table without being flattened.
      
      	Fixes 3131480.
      
              Reviewed by gramps
      
              * khtml/html/dtd.cpp:
              (DOM::checkChild):
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::insertNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a176a20d
    • rjw's avatar
      Don't reset the cookie policy URL if it has already been set. Fixes to 3109590. · f146ac5e
      rjw authored
              Reviewed by Maciej.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f146ac5e
    • rjw's avatar
      Don't attempt to restore page from page cache if the cache · a8df9fbf
      rjw authored
              doesn't contain valid page state.  This may happen after a
              redirect.  Fixes 3137430.
      
              Reviewed by kocienda.
      
              * History.subproj/WebHistoryItem.m:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8df9fbf
    • darin's avatar
      WebKit: · c594b671
      darin authored
              Reviewed by Trey.
      
      	- fixed 3137287 -- REGRESSION: Java applets don't work when you go back to them (Java 1.4.1 plug-in)
      
      	By attaching the plug-in controller to the frame, we run into trouble.
      	It really needs to be attached to the data source, which has the right lifetime
      	and is kept around in the page cache.
      
              * Plugins.subproj/WebPluginController.h: Keep a reference to a data source, not a frame.
      	Add a new _started variable. Rename addPluginView: to addPlugin:, get rid of didAddPluginView:,
      	replace destroyAllPlugins with dataSourceWillBeDeallocated, add startAllPlugins and stopAllPlugins.
              * Plugins.subproj/WebPluginController.m:
              (-[WebPluginController initWithDataSource:]): Store a data source reference, not a frame reference.
      	Don't bother registering for the window will close notification, WebHTMLView handles that fine.
              (-[WebPluginController startAllPlugins]): Do nothing if they are already started, call pluginStart on each otherwise.
              (-[WebPluginController stopAllPlugins]): Do nothing if they are not started, call pluginStop on each otherwise.
              (-[WebPluginController addPlugin:]): Initialize the plugin if it's not already in our list. Also start
      	it if we are in "started" mode.
              (-[WebPluginController dataSourceWillBeDeallocated]): Stop all the plugins, then destroy them.
      	Also nil out the fields of the object. This is always called before the controller is released so we
      	don't need to override dealloc.
              (-[WebPluginController showURL:inFrame:]): Added error checking and changed now that we start with a data source.
              (-[WebPluginController showStatus:]): Ditto.
      
              * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]):
      	Use the data source, not the view. Don't add the plugin here, wait until we are ready to start.
      
              * WebView.subproj/WebDataSourcePrivate.h: Store a pointer to the plug-in controller here.
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSourcePrivate dealloc]): Tell the plug-in controller to go away.
      	(-[WebDataSource _makeHandleDelegates:deferCallbacks:]): Remove unused empty method.
              (-[WebDataSource _pluginController]): Create a plug-in controller if needed.
      
              * WebView.subproj/WebFramePrivate.h: Remove plug-in controller code.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFramePrivate dealloc]): Remove plug-in controller code.
              (-[WebFrame _detachFromParent]): Remove plug-in controller code.
              (-[WebFrame _transitionToCommitted:]): Remove plug-in controller code.
      
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView viewWillMoveToWindow:]): Stop plug-ins when view moves out of a window.
      	This includes the case when the window is being destroyed.
              (-[WebHTMLView viewDidMoveToWindow]): Start plug-ins when view moves into a window.
              (-[WebHTMLView addSubview:]): Add plug-ins to the controller as they are added to us.
      
              * WebView.subproj/WebController.m: Added now-needed include due to header change.
              * WebView.subproj/WebDefaultContextMenuDelegate.m: Ditto.
      
      WebBrowser:
      
              Reviewed by Don and Ken.
      
      	- worked around 3137387 -- Using Java 1.4.1 plug-in causes world leak (NSDocument close never called)
      
              * BrowserWindow.m:
              (-[BrowserWindow setDelegate:]): If someone tries to set the delegate to something other than the
      	BrowserWindowController, don't let them.
              (-[BrowserWindow setWindowController:]): Same thing for the controller.
      
      	- fixed 3137494 -- loading bad URL with PLT window in "world leak check mode" indicates leak, prevents quit
      
              Filed bug 3137567 about the AppKit part of this.
      
              * Test/PageLoadTestRunner.m: (-[NSWindow closeIfBrowserWindow]): Close the sheet, if any, before
      	closing the window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c594b671
  3. 31 Dec, 2002 4 commits
    • kocienda's avatar
      Moving version to 48u. · 01a4cc72
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01a4cc72
    • kocienda's avatar
      Building Safari-47 · 9baeec4e
      kocienda authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9baeec4e
    • darin's avatar
      WebFoundation: · 95c1cbb1
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95c1cbb1
    • darin's avatar
      Reviewed by Trey. · c67613fa
      darin authored
      	- fixed 3132141 -- enter key does not work with input type=image
      
      	Made the logic handle image and submit type inputs in the same way.
      
              * khtml/html/html_formimpl.h: Remove unused m_clicked flags.
              * khtml/html/html_formimpl.cpp:
              (HTMLButtonElementImpl::HTMLButtonElementImpl): Remove code to set the m_clicked flag.
      	The only place this flag was looked at is better handled by the m_activeSubmit flag.
              (HTMLButtonElementImpl::defaultEventHandler): Remove more m_clicked flag code.
              (HTMLInputElementImpl::HTMLInputElementImpl): Remove more m_clicked flag code.
              (HTMLInputElementImpl::isSuccessfulSubmitButton): An image is also a successful submit
      	button, and unlike a submit element, it doesn't require a name because it will just submit
              x and y with no name in that case. I suppose we could rename this function, but I think it's
              still a pretty clear name even if not 100% accurate.
              (HTMLInputElementImpl::encoding): Remove use of m_clicked and use m_activeSubmit instead.
      	This was the only place using m_clicked at all. Also remove bogus check for a -1 coordinate.
      	The coordinate defaults to 0, not -1, and it was never happening.
              (HTMLInputElementImpl::defaultEventHandler): Remove more m_clicked flag code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c67613fa
  4. 30 Dec, 2002 10 commits
    • trey's avatar
      3137110 - REGRESSION: calls from 2nd and subsequent instances of Java 1.4.1... · 872e16f0
      trey authored
      	3137110 - REGRESSION: calls from 2nd and subsequent instances of Java 1.4.1 plug-in seem to be ignored
      
      	We had previously made changes to "numb" a plugin controller after its frame
      	was tossed or changed content.  We now finish the job by making sure a new
      	controller is created when we go to a new page with plugins.  To so this we
      	release the old controller whenever we flush the plugins from a page.
      
              Reviewed by Maciej.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _detachFromParent]):  Call newly factored code.
              (-[WebFrame _transitionToCommitted:]):  Call newly factored code.
              (-[WebFrame _destroyPluginController]):  New method to tear down plugins.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      872e16f0
    • trey's avatar
      3135025 - Assertion failure in _transitionToCommitted on espn nba scoreboard · 3296b190
      trey authored
      	For blank pages we decided that there would be no b/f entry.  This means that
      	subframes within such pages (created via doc.write()), should not try to make
      	WebHistoryItems, since they have no parent items to attach them to.
      
              Reviewed by Darin.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted:]):  Don't make a history item for a subframe
      	it the parent frame has no item.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3296b190
    • darin's avatar
      Reviewed by Don and Maciej. · 8e8091f7
      darin authored
      	- follow-on to my fix for 3134693 that fixes one more case of recursion and simplifies further
      
              * kjs/grammar.y: Remove SourceElementNode and just use a StatementNode instead.
      	Reverse SourceElements rule so the recursive rule comes first as in the original
      	KJS code (avoids actual parser recursion).
      
              * kjs/grammar.cpp: Regenerated.
              * kjs/grammar.cpp.h: Regenerated.
              * kjs/grammar.h: Regenerated.
      
              * kjs/nodes.h: Make processFuncDecl a virtual function in StatementNode so that we can
      	use a StatementNode instead of a SourceElementNode. Add a call to reverseList in BlockNode
      	to correct the order of the linked list in SourceElementsNode, to replace the technique
      	where we reversed it in the parser. Remove SourceElementNode class, and make the element in
      	SourceElementsNode be a StatementNode instead.
              * kjs/nodes.cpp: Remove SourceElementNode code.
              (StatementNode::processFuncDecl): Added empty function.
              (BlockNode::reverseList): Added. Used to make the SourceElements list ordered correctly.
              * kjs/nodes2string.cpp: Remove SourceElementNode code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e8091f7
    • hyatt's avatar
      Fix for 3129016, make sure that zero-height tables and lists · 5873ea08
      hyatt authored
      	will be skipped in a search for floats that occur before
      	them.  Makes usatoday work.
      
              Reviewed by gramps
      
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::clearFloats):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5873ea08
    • darin's avatar
      Reviewed by Maciej. · 58521793
      darin authored
      	- fixed 3135642 -- ad frames are missing at channels.netscape.com
      
              * khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Updated to use the
      	same rule as Mozilla: Empty URL for an iframe means "about:blank".
      
              * khtml/ecma/kjs_window.cpp: (Window::isSafeScript): Loosen things so that it's safe for
      	a frame to manipulate an empty child frame, as well as an empty opened window. Also remove
      	the useless check for an empty document -- it never happens in practice.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58521793
    • trey's avatar
      3135779 - REGRESSION: reproducible assertion failure, going back from ~orubin... · c4784143
      trey authored
      	3135779 - REGRESSION: reproducible assertion failure, going back from ~orubin to the main spies.com page	
      	3136218 - REGRESSION: Assertion failure in _restoreScrollPosition running browser buster
      
      	Both were caused by subtle interactions between new code for short-circuiting loading of
      	blank pages, and the WebHistoryItem manipulations we do for b/f and reload of child frames.
      
              Reviewed by Maciej
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:intoChild:]):  Setup provisional or current item before jumping into
      	the real work of loading the URL.
              (-[WebFrame _restoreScrollPosition]):  Tweaked to make the assertion message clearer.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4784143
    • kocienda's avatar
      Tests: · 40efe749
      kocienda authored
              Reviewed by Darin and Gramps
      
      	Added some more test cases as part of the work to fix this bug:
      
      	Radar 3136795 (type URL with ../ in it, get assertion)
      
      	I also notice an unrelated change in ifnsurlextensions-test.chk where
      	leading whitespace in a URL is now getting removed correctly. Bonus.
      
              * TestURLs.h
              * WebFoundation-Misc/ifnsurlextensions-test.chk
              * WebFoundation-Misc/ifnsurlextensions-test.m:
              (main)
      
      WebFoundation:
      
              Reviewed by Darin and Gramps
      
              Radar 3136795 (type URL with ../ in it, get assertion)
      
              The code to remove relative portions from URLs was eating leading slashes on
              URL paths. This caused absolute paths with relative portions to get mangled,
              resulting in a URL that the engine could not use. Now, leading slashes are no
              longer removed from URL paths, resulting in usuable URLs.
      
              * Misc.subproj/WebNSURLExtras.m:
              (pathRemovingDots)
              (-[NSURL _web_URLComponents])
      
      WebCore:
      
              Reviewed by Darin and Gramps
      
      	Fix for this bug:
      
      	Radar 3136795 (type URL with ../ in it, get assertion)
      
      	The code to remove relative portions from URLs was eating leading slashes on
      	URL paths. This caused absolute paths with relative portions to get mangled,
      	resulting in a URL that the engine could not use. Now, leading slashes are no
      	longer removed from URL paths, resulting in usuable URLs.
      
              * kwq/KWQKURL.mm:
              (copyPathRemovingDots)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40efe749
    • darin's avatar
      Reviewed by Don and Ken. · 0a3771cb
      darin authored
      	- fixed 3136797 -- crash when Adobe SVG Viewer plug-in puts up modal dialog
      
              * Plugins.subproj/WebBaseNetscapePluginView.h: Add inSetWindow boolean.
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView sendEvent:]): Don't send any events to a plug-in while it's
      	inside NPP_SetWindow. We don't want to implement more general reentrancy protection, because
      	it could cause trouble for plugins that can handle it correctly, but it's unlikely that any
      	legitimate use would require reentrant calls while inside NPP_SetWindow, and that's the case
      	that crashes for the SVG viewer plug-in when it presents its registration dialog.
              (-[WebBaseNetscapePluginView setWindow]): Set boolean.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a3771cb
    • darin's avatar
      WebCore: · 477551a4
      darin authored
              Reviewed by Don.
      
      	- fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
      
      	Our self-reference protection prevented this page from working.
      	To fix the bug, I did three things:
      
         	    1) fixed the hole in the WebCore self-reference protection, so we could remove the WebKit one
                     (the hole was that it didn't ignore #xxx suffixes)
       	    2) moved the self-reference protection into a single function so it wasn't copied and pasted all over
      	    3) allowed one level of self-reference; still enough to prevent infinite recursion
      
      	Then I tested with the site from bug 3103287 and the one from bug 3083732 to make sure that was still OK.
      
              * khtml/html/html_baseimpl.h: Added isURLAllowed().
              * khtml/html/html_baseimpl.cpp:
              (HTMLFrameElementImpl::isURLAllowed): Added. Does the self-reference check and the "local only" check.
      	This logic was repeated in three different places before. Note that since we don't use the "local only"
              feature, it's not too risky to slightly change how it works.
              (HTMLFrameElementImpl::updateForNewURL): Use isURLAllowed.
              (HTMLFrameElementImpl::attach): Ditto.
              (HTMLIFrameElementImpl::attach): Ditto.
      
      WebKit:
      
              Reviewed by Don.
      
      	- fixed 3103287 -- body of page not rendered (page uses JavaScript trick to be both a frameset and a frame)
      
      	Our self-reference checks prevented this page from working.
      	I just removed the WebKit one, since it was really just working around a problem with the WebCore
      	one that I fixed (didn't ignore #xxx suffixes).
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
      	Remove self-reference check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      477551a4
    • darin's avatar
      Reviewed by Don. · c5764f8d
      darin authored
      	- fixed 3130566 -- REGRESSION: list item numbers are overlapping the text of the list items
      
      	Moved the hack that handles list items that are not in lists out of the parser and into
      	the DOM and Render tree code itself. This fixes the issue where the parser doesn't know which
      	will be the parent node of the list item, and other problems with the old hack.
      
              * khtml/html/html_listimpl.cpp: (HTMLLIElementImpl::attach): Find the parent list (OL or UL).
      	If there is no parent list, set a "not in list" flag on the render object so it knows to render
      	"inside" no matter what the style says. Also use this parent and a safer check to make the
      	start attribute work even when there is an intervening DOM element in the hierarchy.
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Remove the code that tries to set
      	the style of an LI based on the current node at the time it's parsed, because the current node
      	is now often not the OL or the UL due to our DTD fix to allow other nodes in lists.
      
              * khtml/rendering/render_list.h: Add isInside() to RenderListMarker, setNotInList(), notInList(),
      	and _notInList to RenderListItem.
      
              * khtml/rendering/render_list.cpp:
              (RenderListItem::RenderListItem): Initialize _notInList to false.
              (RenderListMarker::paintObject): Use isInside() instead of checking listStylePosition().
              (RenderListMarker::calcMinMaxWidth): Ditto.
              (RenderListMarker::baselinePosition): Ditto.
              (RenderListMarker::isInside): Return true if we are not in a list, or if "inside" style is requested.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5764f8d
  5. 29 Dec, 2002 8 commits
    • darin's avatar
      Reviewed by Don. · bd2f5f11
      darin authored
      	- fixed 3134346 -- country menu at www.apple.com does not work when you go back to that page
      
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Add call to checkCompleted().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd2f5f11
    • darin's avatar
      Reviewed by Don. · 0c35e090
      darin authored
      	- fixed 3136801 -- scrolling a page that contains a QuickTime movie leaves garbage behind
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView tellQuickTimeToChill]): Added. Calls a QuickDraw SPI
      	CallDrawingNotifications to let QuickTime know it should take a nature break.
              (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Call tellQuickTimeToChill.
              (-[WebBaseNetscapePluginView viewHasMoved:]): Call tellQuickTimeToChill.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c35e090
    • darin's avatar
      Reviewed by Maciej. · 45f34810
      darin authored
      	- fixed 3136391 -- PianoNanny.com screens turn to garbage when resized
      
      	Turns out browsers pass open calls to the window object if they show up at the document
      	with parameters. We now emulate that too.
      
              * khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::tryCall): If we get an open call with
      	parameters, pass it on to the window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45f34810
    • darin's avatar
      Reviewed by Don. · 73bc007f
      darin authored
      	- follow-on to my fix for 3125877 that fixes a crash I observed when a plug-in fails to NPP_New
      
              I filed bug 3136870 about the fact that we don't do a good job reporting the error.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView sendEvent:]): Return quietly if this is called when
      	the plug-in is not started rather than asserting (and doing bad things on Deployment).
              (-[WebBaseNetscapePluginView setWindow]): Ditto.
              (-[WebBaseNetscapePluginView viewHasMoved:]): Just call setWindow since it now checks isStarted.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73bc007f
    • darin's avatar
      Reviewed by Don. · c5135a70
      darin authored
      	- follow-on to my fix for 3125877 that fixes a crash I observed when a plug-in fails to NPP_New
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView sendEvent:]): Return quietly if this is called when
      	the plug-in is not started rather than asserting (and doing bad things on Deployment).
              (-[WebBaseNetscapePluginView setWindow]): Ditto.
              (-[WebBaseNetscapePluginView viewHasMoved:]): Just call setWindow since it now checks isStarted.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5135a70
    • darin's avatar
      Reviewed by Don. · f1002bfe
      darin authored
      	- fixed 3120630 -- spacebar scrolls the page as well as pausing the QuickTime movie
      
      	Imitate Mozilla and OmniWeb by not propagating keyboard events after passing them to
      	plug-ins regardless of what the plug-in returns, rather than imitating MacIE, which
              looks at the return value from NPP_HandleEvent.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView keyUp:]): Remove call to super, add comment.
              (-[WebBaseNetscapePluginView keyDown:]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1002bfe
    • darin's avatar
      Reviewed by Ken and Don. · 05df9e7f
      darin authored
      	- fixed 3136120 -- much content missing at www.olympic.org
      
      	This site gives modern CSS to "Internet Explorer" or "Netscape 6". Since we are neither of
      	those, we need to pretend to be one or the other. So we add olympic.org to our MacIE spoofing list.
      
              * WebView.subproj/WebUserAgentSpoofTable.gperf: Add olympic.org to the list of pages that give us better
      	CSS if we claim to be Internet Explorer.
              * WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05df9e7f
    • darin's avatar
      Reviewed by Ken. · 65e464a5
      darin authored
      	- fixed 3134560 -- Lord of the Rings desktops don't load
      
              * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Removed the APPLE_CHANGES here.
      	The comment claims that we don't need the code because "JavaScript will do the work
      	below on demand", but that's not true for setting the base URL. Also, the comment
      	claims that this "adds an extra entry to the back/forward list", but testing does not
      	bear that out.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65e464a5
  6. 28 Dec, 2002 5 commits