1. 21 Jan, 2014 8 commits
  2. 20 Jan, 2014 27 commits
    • ryuan.choi@samsung.com's avatar
      [CMAKE] Remove Nix from CMake scripts · 050410ab
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127264
      
      Reviewed by Anders Carlsson.
      
      .:
      
      * CMakeLists.txt:
      * Source/CMakeLists.txt:
      * Source/cmake/FindEGL.cmake:
      * Source/cmake/OptionsCommon.cmake:
      
      Source/Platform:
      
      * CMakeLists.txt: Removed.
      
      Source/WebCore:
      
      * CMakeLists.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      050410ab
    • andersca@apple.com's avatar
      Remove an unused PageGroup function · 22ec5d1b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127327
      
      Reviewed by Andreas Kling.
      
      * WebCore.exp.in:
      * page/PageGroup.cpp:
      * page/PageGroup.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22ec5d1b
    • andersca@apple.com's avatar
      Move user style sheet handling to UserContentController · c005d5bc
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127322
      <rdar://problem/15861296>
      
      Reviewed by Andreas Kling.
      
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserStyleSheetToWorld):
      (WebCore::PageGroup::removeUserStyleSheetFromWorld):
      (WebCore::PageGroup::removeUserStyleSheetsFromWorld):
      (WebCore::PageGroup::removeAllUserContent):
      * page/PageGroup.h:
      * page/UserContentController.cpp:
      (WebCore::UserContentController::addUserStyleSheet):
      (WebCore::UserContentController::removeUserStyleSheet):
      (WebCore::UserContentController::removeUserStyleSheets):
      (WebCore::UserContentController::removeAllUserContent):
      (WebCore::UserContentController::invalidateInjectedStyleSheetCacheInAllFrames):
      * page/UserContentController.h:
      (WebCore::UserContentController::userStyleSheets):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c005d5bc
    • benjamin@webkit.org's avatar
      Add a nicer way to iterate over all the attributes of an element · 64c95337
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127266
      
      Reviewed by Geoffrey Garen.
      
      When using Element::attributeAt() in a loop, the compiler had to generate two kinds of
      accessor:
      -If the element data is unique, the length and data comes from the attribute Vector.
      -If the element data is shared, the data comes from the tail of elementData itself.
      
      The choice was done for every access, which caused the assembly to be a little
      hard to follow.
      This patch unify the data access by doing everything as a array pointer with offset (getting
      that data from Vector when necessary).
      
      To make it easier to do the right thing, a new iterator was added so that range-based loops
      can replace all the faulty cases.
      
      * css/SelectorChecker.cpp:
      (WebCore::anyAttributeMatches):
      * css/SelectorChecker.h:
      (WebCore::SelectorChecker::checkExactAttribute):
      * dom/DatasetDOMStringMap.cpp:
      (WebCore::DatasetDOMStringMap::getNames):
      (WebCore::DatasetDOMStringMap::item):
      (WebCore::DatasetDOMStringMap::contains):
      * dom/Element.cpp:
      (WebCore::Element::normalizeAttributes):
      (WebCore::Element::detachAllAttrNodesFromElement):
      (WebCore::Element::cloneAttributesFromElement):
      * dom/Element.h:
      (WebCore::Element::attributesIterator):
      * dom/ElementData.cpp:
      (WebCore::ElementData::isEquivalent):
      (WebCore::ElementData::findAttributeIndexByNameSlowCase):
      * dom/ElementData.h:
      (WebCore::AttributeConstIterator::AttributeConstIterator):
      (WebCore::AttributeConstIterator::operator*):
      (WebCore::AttributeConstIterator::operator->):
      (WebCore::AttributeConstIterator::operator++):
      (WebCore::AttributeConstIterator::operator==):
      (WebCore::AttributeConstIterator::operator!=):
      (WebCore::AttributeIteratorAccessor::AttributeIteratorAccessor):
      (WebCore::AttributeIteratorAccessor::begin):
      (WebCore::AttributeIteratorAccessor::end):
      (WebCore::ElementData::attributesIterator):
      * dom/Node.cpp:
      (WebCore::Node::isDefaultNamespace):
      (WebCore::Node::lookupNamespaceURI):
      (WebCore::Node::lookupNamespacePrefix):
      (WebCore::Node::compareDocumentPosition):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::makePresentationAttributeCacheKey):
      (WebCore::StyledElement::rebuildPresentationAttributeStyle):
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::appendElement):
      * editing/markup.cpp:
      (WebCore::completeURLs):
      (WebCore::StyledMarkupAccumulator::appendElement):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::parametersForPlugin):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::innerPatchNode):
      (WebCore::DOMPatchSupport::createDigest):
      * inspector/InspectorDOMAgent.cpp:
      (WebCore::InspectorDOMAgent::setAttributesAsText):
      (WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
      * inspector/InspectorNodeFinder.cpp:
      (WebCore::InspectorNodeFinder::matchesElement):
      * page/PageSerializer.cpp:
      (WebCore::isCharsetSpecifyingNode):
      * xml/XPathNodeSet.cpp:
      (WebCore::XPath::NodeSet::traversalSort):
      * xml/XPathStep.cpp:
      (WebCore::XPath::Step::nodesInAxis):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::XMLDocumentParser::XMLDocumentParser):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c95337
    • gyuyoung.kim@samsung.com's avatar
      Do refactor in collectGradientAttributes() and renderStyleForLengthResolve() · 9fbfea1a
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=126869
      
      Reviewed by Dirk Schulze.
      
      Some SVG functions have done a first iteration by using a boolean flag. This is
      one of poor implementations. This patch fix it by extracting a logic into a new method.
      Additionally it would be good to use do-while() loop instead of using while() in
      renderStyleForLengthResolving() because a first condition is always true.
      
      Merge r165358 from blink.
      
      * svg/SVGLengthContext.cpp:
      (WebCore::renderStyleForLengthResolving):
      * svg/SVGLinearGradientElement.cpp:
      (WebCore::setGradientAttributes):
      (WebCore::SVGLinearGradientElement::collectGradientAttributes):
      * svg/SVGRadialGradientElement.cpp:
      (WebCore::setGradientAttributes):
      (WebCore::SVGRadialGradientElement::collectGradientAttributes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fbfea1a
    • andersca@apple.com's avatar
      UserContentController should keep track of user scripts · 70128916
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127317
      <rdar://problem/15861296>
      
      Reviewed by Andreas Kling.
      
      Move handling of user scripts from PageGroup to UserContentController.
      
      * page/Frame.cpp:
      (WebCore::Frame::injectUserScripts):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::addUserScriptToWorld):
      (WebCore::PageGroup::removeUserScriptFromWorld):
      (WebCore::PageGroup::removeUserScriptsFromWorld):
      (WebCore::PageGroup::removeAllUserContent):
      * page/PageGroup.h:
      * page/UserContentController.cpp:
      (WebCore::UserContentController::addUserScript):
      (WebCore::UserContentController::removeUserScript):
      (WebCore::UserContentController::removeUserScripts):
      (WebCore::UserContentController::removeAllUserContent):
      * page/UserContentController.h:
      (WebCore::UserContentController::userScripts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70128916
    • andersca@apple.com's avatar
      Give each page a UserContentController · 2e7006b1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127315
      
      Reviewed by Andreas Kling.
      
      Add a UserContentController object to PageGroup and have the page group set it on any
      pages that are added to the page group.
      
      This is another step towards moving handling of user content away from PageGroup and make it
      possible for each page to have different user content.
      
      * page/Page.cpp:
      (WebCore::Page::~Page):
      (WebCore::Page::setUserContentController):
      * page/Page.h:
      (WebCore::Page::userContentController):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::PageGroup):
      (WebCore::PageGroup::addPage):
      (WebCore::PageGroup::removePage):
      * page/PageGroup.h:
      * page/UserContentController.cpp:
      (WebCore::UserContentController::addPage):
      (WebCore::UserContentController::removePage):
      * page/UserContentController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e7006b1
    • commit-queue@webkit.org's avatar
      Add AVKit fullscreen video interface. · 631001b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=126818
      
      Patch by Jeremy Jones <jeremyj@apple.com> on 2014-01-20
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      No new tests, no observable change in functionality.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute):
      * html/HTMLMediaElement.h:
      Add ability for fullscreen to borrow the AVPlayerLayer.
      * page/Settings.cpp:
      * page/Settings.h:
      (WebCore::Settings::setMediaPlaybackFullscreenAVKit):
      (WebCore::Settings::mediaPlaybackFullscreenAVKit):
      Add a disabled setting.
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      (WebCore::MediaPlayerPrivateAVFoundation::supportsFullscreen):
      Enabled fullscreen for iOS.
      * platform/ios/WebVideoFullscreenControllerAVKit.h: Added.
      * platform/ios/WebVideoFullscreenControllerAVKit.mm: Added.
      (-[WebAVPlayerController init]):
      (-[WebAVPlayerController dealloc]):
      (-[WebAVPlayerController forwardingTargetForSelector:]):
      (-[WebAVPlayerController shouldDismissForDone]):
      (-[WebAVPlayerController play:]):
      (-[WebAVPlayerController pause:]):
      (-[WebAVPlayerController togglePlayback:]):
      (-[WebAVPlayerController isPlaying]):
      (-[WebAVPlayerController setPlaying:]):
      (+[WebAVPlayerController keyPathsForValuesAffectingPlaying]):
      (-[WebAVPlayerController seekToTime:]):
      (-[WebAVPlayerController updateTimingWithCurrentTime:]):
      (-[WebAVPlayerController effectiveRate]):
      (-[WebAVPlayerController setMediaElement:]):
      (-[WebAVPlayerController handleEvent:]):
      (-[WebVideoFullscreenController init]):
      (-[WebVideoFullscreenController dealloc]):
      (-[WebVideoFullscreenController setMediaElement:]):
      (-[WebVideoFullscreenController mediaElement]):
      (-[WebVideoFullscreenController enterFullscreen:]):
      (-[WebVideoFullscreenController exitFullscreen]):
      Add WebAVPlayerController for HTMLMediaElememt to interface with AVPlayerViewController.
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::supportsFullscreenForNode):
      Enable *FullscreenForNode for HTMLMediaElement for iOS
      
      * WebView/WebPreferenceKeysPrivate.h:
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]):
      (-[WebPreferences mediaPlaybackFullscreenAVKit]):
      (-[WebPreferences setMediaPlaybackFullscreenAVKit:]):
      * WebView/WebPreferencesPrivate.h:
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      (-[WebView _enterFullscreenForNode:WebCore::]):
      * WebView/WebViewInternal.h:
      Add a disabled pref mediaPlaybackFullscreenAVKit.
      Use WebVideoFullscreenControllerAVKit on iOS
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      631001b6
    • zandobersek@gmail.com's avatar
      Replace uses of std::forward<T>(), std::unique_ptr<T>::clear() that landed in r162368 · 217aa287
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127306
      
      Reviewed by Darin Adler.
      
      Address the post-landing reviews of the r162368 commit that moved WebAudio source code to using std::unique_ptr.
      std::move() should be used instead of std::forward<T>() in HRTFKernel::create().
      Instead of calling std::unique_ptr<T>::reset(), nullptr should be assigned to that smart pointer to reset it.
      
      * Modules/webaudio/ConvolverNode.cpp:
      (WebCore::ConvolverNode::uninitialize):
      * Modules/webaudio/DynamicsCompressorNode.cpp:
      (WebCore::DynamicsCompressorNode::uninitialize):
      * Modules/webaudio/MediaElementAudioSourceNode.cpp:
      (WebCore::MediaElementAudioSourceNode::setFormat):
      * Modules/webaudio/PannerNode.cpp:
      (WebCore::PannerNode::uninitialize):
      * platform/audio/AudioChannel.h:
      (WebCore::AudioChannel::set):
      * platform/audio/HRTFDatabaseLoader.cpp:
      (WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
      * platform/audio/HRTFKernel.h:
      (WebCore::HRTFKernel::create):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      217aa287
    • joepeck@webkit.org's avatar
      Modernize WebCore/inspector with nullptr · ed8058ee
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127303
      
      Reviewed by Anders Carlsson.
      
      Ran clang-modernize -use-nullptr over WebCore/inspector.
      
      * inspector/ConsoleMessage.cpp:
      (WebCore::ConsoleMessage::ConsoleMessage):
      * inspector/ConsoleMessage.h:
      * inspector/ContentSearchUtils.cpp:
      (WebCore::ContentSearchUtils::findMagicComment):
      * inspector/DOMEditor.cpp:
      (WebCore::DOMEditor::SetOuterHTMLAction::SetOuterHTMLAction):
      * inspector/DOMPatchSupport.cpp:
      (WebCore::DOMPatchSupport::patchDocument):
      (WebCore::DOMPatchSupport::patchNode):
      (WebCore::DOMPatchSupport::diff):
      (WebCore::DOMPatchSupport::innerPatchChildren):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::willDestroyFrontendAndBackend):
      (WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::disable):
      (WebCore::InspectorCanvasAgent::notifyRenderingContextWasWrapped):
      (WebCore::InspectorCanvasAgent::frameNavigated):
      * inspector/InspectorConsoleAgent.cpp:
      (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
      (WebCore::InspectorConsoleAgent::clearMessages):
      (WebCore::InspectorConsoleAgent::didFinishXHRLoading):
      (WebCore::InspectorConsoleAgent::didReceiveResponse):
      (WebCore::InspectorConsoleAgent::didFailLoading):
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorController.cpp:
      (WebCore::InspectorController::inspectedPageDestroyed):
      * inspector/InspectorDOMDebuggerAgent.cpp:
      (WebCore::InspectorDOMDebuggerAgent::disable):
      (WebCore::InspectorDOMDebuggerAgent::discardAgent):
      * inspector/InspectorDOMStorageAgent.cpp:
      (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
      (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
      (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
      (WebCore::InspectorDOMStorageAgent::findStorageArea):
      * inspector/InspectorDatabaseAgent.cpp:
      (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
      (WebCore::InspectorDatabaseAgent::findByFileName):
      (WebCore::InspectorDatabaseAgent::databaseForId):
      * inspector/InspectorDebuggerAgent.cpp:
      (WebCore::InspectorDebuggerAgent::addMessageToConsole):
      (WebCore::InspectorDebuggerAgent::resolveBreakpoint):
      (WebCore::InspectorDebuggerAgent::didParseSource):
      (WebCore::InspectorDebuggerAgent::didContinue):
      (WebCore::InspectorDebuggerAgent::clearBreakDetails):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::FrontendMenuProvider::disconnect):
      (WebCore::InspectorFrontendHost::InspectorFrontendHost):
      (WebCore::InspectorFrontendHost::disconnectClient):
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::~InspectorHeapProfilerAgent):
      * inspector/InspectorIndexedDBAgent.cpp:
      (WebCore::assertDocument):
      (WebCore::assertIDBFactory):
      (WebCore::InspectorIndexedDBAgent::requestData):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::frameForScriptExecutionContext):
      (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
      (WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
      (WebCore::InspectorInstrumentation::consoleAgentEnabled):
      (WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
      (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
      (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
      (WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope):
      (WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
      (WebCore::InspectorInstrumentation::instrumentingAgentsForFrame):
      (WebCore::InspectorInstrumentation::instrumentingAgentsForDocument):
      * inspector/InspectorLayerTreeAgent.cpp:
      (WebCore::InspectorLayerTreeAgent::disable):
      * inspector/InspectorNodeFinder.cpp:
      (WebCore::InspectorNodeFinder::searchUsingXPath):
      * inspector/InspectorOverlay.cpp:
      (WebCore::buildObjectForElementInfo):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::cachedResourceContent):
      (WebCore::InspectorPageAgent::sharedBufferContent):
      (WebCore::InspectorPageAgent::disable):
      (WebCore::InspectorPageAgent::frameForId):
      (WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::InspectorProfilerAgent::~InspectorProfilerAgent):
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::buildObjectForResourceResponse):
      (WebCore::InspectorResourceAgent::willSendRequest):
      (WebCore::InspectorResourceAgent::didReceiveResponse):
      (WebCore::InspectorResourceAgent::didFinishLoading):
      (WebCore::InspectorResourceAgent::didFailLoading):
      (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
      (WebCore::InspectorResourceAgent::disable):
      * inspector/InspectorRuntimeAgent.cpp:
      (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
      * inspector/InspectorStyleSheet.cpp:
      (ParsedStyleSheet::ruleSourceDataAt):
      (WebCore::buildSourceRangeObject):
      (WebCore::asCSSRuleList):
      (WebCore::fillMediaListChain):
      (WebCore::InspectorStyle::setPropertyText):
      (WebCore::InspectorStyle::populateAllProperties):
      (WebCore::InspectorStyle::extractSourceData):
      (WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
      (WebCore::InspectorStyleSheet::addRule):
      (WebCore::InspectorStyleSheet::ruleForId):
      (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
      (WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
      (WebCore::InspectorStyleSheet::buildObjectForRule):
      (WebCore::InspectorStyleSheet::styleForId):
      (WebCore::InspectorStyleSheet::inspectorStyleForId):
      (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
      * inspector/InspectorStyleSheet.h:
      (WebCore::InspectorCSSId::asProtocolValue):
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::stop):
      (WebCore::InspectorTimelineAgent::willComposite):
      (WebCore::InspectorTimelineAgent::page):
      * inspector/InspectorWorkerAgent.cpp:
      (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
      * inspector/InstrumentingAgents.cpp:
      (WebCore::InstrumentingAgents::InstrumentingAgents):
      (WebCore::InstrumentingAgents::reset):
      * inspector/NetworkResourcesData.cpp:
      (WebCore::NetworkResourcesData::ResourceData::ResourceData):
      (WebCore::NetworkResourcesData::xhrReplayData):
      (WebCore::NetworkResourcesData::removeCachedResource):
      (WebCore::NetworkResourcesData::resourceDataForRequestId):
      * inspector/PageConsoleAgent.cpp:
      (WebCore::PageConsoleAgent::~PageConsoleAgent):
      * inspector/PageDebuggerAgent.cpp:
      (WebCore::PageDebuggerAgent::disable):
      * inspector/PageRuntimeAgent.cpp:
      (WebCore::PageRuntimeAgent::~PageRuntimeAgent):
      (WebCore::PageRuntimeAgent::didCreateMainWorldContext):
      (WebCore::PageRuntimeAgent::reportExecutionContextCreation):
      * inspector/ScriptArguments.cpp:
      (WebCore::ScriptArguments::globalState):
      * inspector/WorkerRuntimeAgent.cpp:
      (WebCore::WorkerRuntimeAgent::~WorkerRuntimeAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed8058ee
    • andersca@apple.com's avatar
      Add empty UserContentController class · a5e72936
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127300
      <rdar://problem/15861296>
      
      Reviewed by Dan Bernstein.
      
      This is the first step towards moving handling of user scripts and style sheets from
      the page group to a separate objects and ultimately make them be settable per page instead of per page group.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * page/UserContentController.cpp: Added.
      (WebCore::UserContentController::create):
      (WebCore::UserContentController::UserContentController):
      (WebCore::UserContentController::~UserContentController):
      * page/UserContentController.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5e72936
    • joepeck@webkit.org's avatar
      Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector · 585b903f
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127206
      
      Reviewed by Anders Carlsson.
      
      Let clang-modernize add overrides.
      
      * inspector/DOMEditor.cpp:
      * inspector/InspectorApplicationCacheAgent.h:
      * inspector/InspectorCSSAgent.h:
      * inspector/InspectorCanvasAgent.h:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDOMAgent.h:
      * inspector/InspectorDOMDebuggerAgent.h:
      * inspector/InspectorDOMStorageAgent.h:
      * inspector/InspectorDatabaseAgent.cpp:
      * inspector/InspectorDatabaseAgent.h:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorHeapProfilerAgent.cpp:
      (WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
      (WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
      * inspector/InspectorHeapProfilerAgent.h:
      * inspector/InspectorHistory.cpp:
      * inspector/InspectorIndexedDBAgent.cpp:
      * inspector/InspectorIndexedDBAgent.h:
      * inspector/InspectorInputAgent.h:
      * inspector/InspectorLayerTreeAgent.h:
      * inspector/InspectorMemoryAgent.h:
      * inspector/InspectorPageAgent.h:
      * inspector/InspectorProfilerAgent.cpp:
      * inspector/InspectorProfilerAgent.h:
      * inspector/InspectorResourceAgent.h:
      * inspector/InspectorRuntimeAgent.h:
      * inspector/InspectorStyleSheet.h:
      * inspector/InspectorTimelineAgent.h:
      * inspector/InspectorWorkerAgent.cpp:
      * inspector/InspectorWorkerAgent.h:
      * inspector/PageConsoleAgent.h:
      * inspector/PageDebuggerAgent.h:
      * inspector/PageRuntimeAgent.h:
      * inspector/WorkerConsoleAgent.h:
      * inspector/WorkerDebuggerAgent.cpp:
      * inspector/WorkerInspectorController.cpp:
      * inspector/WorkerRuntimeAgent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      585b903f
    • zandobersek@gmail.com's avatar
      Move WebAudio source code to std::unique_ptr · 56c23bd4
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127274
      
      Reviewed by Eric Carlson.
      
      Move from using OwnPtr and PassOwnPtr to using std::unique_ptr and move semantics
      in the WebAudio module and the WebAudio code in the platform layer.
      
      * Modules/webaudio/AsyncAudioDecoder.cpp:
      * Modules/webaudio/AsyncAudioDecoder.h:
      * Modules/webaudio/AudioBasicInspectorNode.cpp:
      (WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
      * Modules/webaudio/AudioBasicProcessorNode.cpp:
      (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
      * Modules/webaudio/AudioBasicProcessorNode.h:
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
      * Modules/webaudio/AudioContext.cpp:
      * Modules/webaudio/AudioContext.h:
      * Modules/webaudio/AudioDestinationNode.cpp:
      (WebCore::AudioDestinationNode::AudioDestinationNode):
      * Modules/webaudio/AudioNode.cpp:
      (WebCore::AudioNode::addInput):
      (WebCore::AudioNode::addOutput):
      (WebCore::AudioNode::checkNumberOfChannelsForInput):
      * Modules/webaudio/AudioNode.h:
      * Modules/webaudio/BiquadFilterNode.cpp:
      (WebCore::BiquadFilterNode::BiquadFilterNode):
      * Modules/webaudio/BiquadProcessor.cpp:
      (WebCore::BiquadProcessor::createKernel):
      (WebCore::BiquadProcessor::getFrequencyResponse):
      * Modules/webaudio/BiquadProcessor.h:
      * Modules/webaudio/ChannelMergerNode.cpp:
      (WebCore::ChannelMergerNode::ChannelMergerNode):
      * Modules/webaudio/ChannelSplitterNode.cpp:
      (WebCore::ChannelSplitterNode::ChannelSplitterNode):
      * Modules/webaudio/ConvolverNode.cpp:
      (WebCore::ConvolverNode::ConvolverNode):
      (WebCore::ConvolverNode::uninitialize):
      (WebCore::ConvolverNode::setBuffer):
      * Modules/webaudio/ConvolverNode.h:
      * Modules/webaudio/DefaultAudioDestinationNode.h:
      * Modules/webaudio/DelayNode.cpp:
      (WebCore::DelayNode::DelayNode):
      * Modules/webaudio/DelayProcessor.cpp:
      (WebCore::DelayProcessor::createKernel):
      * Modules/webaudio/DelayProcessor.h:
      * Modules/webaudio/DynamicsCompressorNode.cpp:
      (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
      (WebCore::DynamicsCompressorNode::initialize):
      (WebCore::DynamicsCompressorNode::uninitialize):
      * Modules/webaudio/DynamicsCompressorNode.h:
      * Modules/webaudio/GainNode.cpp:
      (WebCore::GainNode::GainNode):
      * Modules/webaudio/MediaElementAudioSourceNode.cpp:
      (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
      (WebCore::MediaElementAudioSourceNode::setFormat):
      * Modules/webaudio/MediaElementAudioSourceNode.h:
      * Modules/webaudio/MediaStreamAudioDestinationNode.h:
      * Modules/webaudio/MediaStreamAudioSource.cpp:
      * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
      (WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
      * Modules/webaudio/MediaStreamAudioSourceNode.h:
      * Modules/webaudio/OscillatorNode.cpp:
      (WebCore::OscillatorNode::OscillatorNode):
      * Modules/webaudio/PannerNode.cpp:
      (WebCore::PannerNode::PannerNode):
      (WebCore::PannerNode::uninitialize):
      (WebCore::PannerNode::setPanningModel):
      * Modules/webaudio/PannerNode.h:
      * Modules/webaudio/PeriodicWave.cpp:
      (WebCore::PeriodicWave::createBandLimitedTables):
      * Modules/webaudio/PeriodicWave.h:
      * Modules/webaudio/RealtimeAnalyser.cpp:
      (WebCore::RealtimeAnalyser::RealtimeAnalyser):
      (WebCore::RealtimeAnalyser::setFftSize):
      * Modules/webaudio/RealtimeAnalyser.h:
      * Modules/webaudio/ScriptProcessorNode.cpp:
      (WebCore::ScriptProcessorNode::ScriptProcessorNode):
      * Modules/webaudio/WaveShaperDSPKernel.cpp:
      (WebCore::WaveShaperDSPKernel::lazyInitializeOversampling):
      * Modules/webaudio/WaveShaperDSPKernel.h:
      * Modules/webaudio/WaveShaperNode.cpp:
      (WebCore::WaveShaperNode::WaveShaperNode):
      * Modules/webaudio/WaveShaperProcessor.cpp:
      (WebCore::WaveShaperProcessor::createKernel):
      * Modules/webaudio/WaveShaperProcessor.h:
      * platform/audio/AudioBus.cpp:
      (WebCore::AudioBus::AudioBus):
      (WebCore::AudioBus::copyWithGainFrom):
      * platform/audio/AudioBus.h:
      * platform/audio/AudioChannel.cpp:
      * platform/audio/AudioChannel.h:
      (WebCore::AudioChannel::AudioChannel):
      (WebCore::AudioChannel::set):
      * platform/audio/AudioDSPKernelProcessor.h:
      * platform/audio/AudioDestination.h:
      * platform/audio/AudioResampler.cpp:
      (WebCore::AudioResampler::AudioResampler):
      (WebCore::AudioResampler::configureChannels):
      * platform/audio/AudioResampler.h:
      * platform/audio/AudioSession.h:
      * platform/audio/DynamicsCompressor.cpp:
      (WebCore::DynamicsCompressor::setNumberOfChannels):
      * platform/audio/DynamicsCompressor.h:
      * platform/audio/DynamicsCompressorKernel.cpp:
      (WebCore::DynamicsCompressorKernel::setNumberOfChannels):
      * platform/audio/DynamicsCompressorKernel.h:
      * platform/audio/FFTFrame.cpp:
      (WebCore::FFTFrame::createInterpolatedFrame):
      * platform/audio/FFTFrame.h:
      * platform/audio/HRTFDatabase.cpp:
      (WebCore::HRTFDatabase::HRTFDatabase):
      * platform/audio/HRTFDatabase.h:
      * platform/audio/HRTFDatabaseLoader.cpp:
      (WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
      (WebCore::HRTFDatabaseLoader::load):
      * platform/audio/HRTFDatabaseLoader.h:
      * platform/audio/HRTFElevation.cpp:
      (WebCore::HRTFElevation::createForSubject):
      (WebCore::HRTFElevation::createByInterpolatingSlices):
      * platform/audio/HRTFElevation.h:
      (WebCore::HRTFElevation::HRTFElevation):
      * platform/audio/HRTFKernel.cpp:
      (WebCore::HRTFKernel::HRTFKernel):
      (WebCore::HRTFKernel::createImpulseResponse):
      (WebCore::HRTFKernel::createInterpolatedKernel):
      * platform/audio/HRTFKernel.h:
      (WebCore::HRTFKernel::create):
      (WebCore::HRTFKernel::HRTFKernel):
      * platform/audio/MultiChannelResampler.cpp:
      (WebCore::MultiChannelResampler::MultiChannelResampler):
      * platform/audio/MultiChannelResampler.h:
      * platform/audio/Panner.cpp:
      (WebCore::Panner::create):
      * platform/audio/Panner.h:
      * platform/audio/Reverb.cpp:
      (WebCore::Reverb::initialize):
      * platform/audio/Reverb.h:
      * platform/audio/ReverbConvolver.h:
      * platform/audio/ReverbConvolverStage.cpp:
      (WebCore::ReverbConvolverStage::ReverbConvolverStage):
      * platform/audio/ReverbConvolverStage.h:
      * platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
      (WebCore::AudioDestination::create):
      * platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
      * platform/audio/ios/AudioDestinationIOS.cpp:
      (WebCore::AudioDestination::create):
      * platform/audio/ios/AudioSessionIOS.mm:
      (WebCore::AudioSession::AudioSession):
      * platform/audio/mac/AudioDestinationMac.cpp:
      (WebCore::AudioDestination::create):
      * platform/audio/mac/AudioDestinationMac.h:
      * platform/audio/mac/AudioSessionMac.cpp:
      (WebCore::AudioSession::AudioSession):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56c23bd4
    • commit-queue@webkit.org's avatar
      Region based multicol: support explicit column breaks · fd8f1a2d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123993
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Merely supporting insertion of explicit (forced) column breaks in
      the region based multicol implementation is really simple: just
      hook up with what the CSS regions code is already doing.
      
      However, there is one complication: column balancing. In order to
      balance columns as nicely as possible when there are explicit
      breaks, we need to figure out between which explicit breaks the
      implicit breaks will occur (if there's room for any at all).
      
      Tests: fast/multicol/newmulticol/break-after.html
             fast/multicol/newmulticol/break-before.html
             fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html
             fast/multicol/newmulticol/breaks-2-columns-3.html
             fast/multicol/newmulticol/breaks-3-columns-3.html
             fast/multicol/newmulticol/fixed-height-fill-balance-2.html
      
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::applyBeforeBreak):
      (WebCore::RenderBlockFlow::applyAfterBreak): Use the already
      existing region breaking code when inserting breaks in region
      based multicol.
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnBlock.cpp:
      (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
      (WebCore::RenderMultiColumnBlock::relayoutForPagination): Avoid
      re-balancing if the multicol's contents were not laid out. Apart
      from being good for performance, this is now necessary because of
      how explicit breaks are implemented.
      (WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
      Detect if the contents are going to be laid out, or skipped, so
      that we can tell if we need to (re-)balance the columns
      afterwards.
      * rendering/RenderMultiColumnBlock.h:
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::addForcedRegionBreak):
      Locate the appropriate multi-column set and call its
      addForcedBreak().
      * rendering/RenderMultiColumnFlowThread.h:
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
      (WebCore::RenderMultiColumnSet::findRunWithTallestColumns):
      (WebCore::RenderMultiColumnSet::distributeImplicitBreaks): Figure
      out how many implicit breaks each single "content run" should
      contain. The taller the content run, the more implicit breaks.
      (WebCore::RenderMultiColumnSet::calculateBalancedHeight): This is
      now a const method that only does half of what the old
      calculateBalancedHeight() did. The rest (such as actually storing
      the new column height) is done by recalculateBalancedHeight().
      (WebCore::RenderMultiColumnSet::clearForcedBreaks): Needs to be
      called between each layout pass, to clear the list of "content
      runs".
      (WebCore::RenderMultiColumnSet::addForcedBreak): Only useful when
      columns are to be balanced. It receives explicit (forced) breaks
      and stores them as "content runs". When layout is done, we'll go
      through the list of content runs, and see where implicit breaks
      should be inserted (if there's room for any). The goal is to
      insert implicit breaks in such a way that the final columns become
      as short as possible.
      (WebCore::RenderMultiColumnSet::recalculateBalancedHeight):
      Calculates and sets a new balanced column height. This used to be
      done directly in calculateBalancedHeight(), but that method is now
      const and it now only calculates the new height and returns it.
      (WebCore::RenderMultiColumnSet::prepareForLayout):
      * rendering/RenderMultiColumnSet.h: Remove old data members
      intended for forced breaks (they were unused), and introduce a
      "content run" vector instead. A new content run is triggered by an
      explicit break. This is only used when column balancing is
      enabled. When not balanced, RenderMultiColumnSet doesn't need to
      do anything when explicit breaks are inserted.
      
      LayoutTests:
      
      * fast/multicol/newmulticol/break-after-expected.html: Added.
      * fast/multicol/newmulticol/break-after.html: Added.
      * fast/multicol/newmulticol/break-before-expected.html: Added.
      * fast/multicol/newmulticol/break-before.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-expected.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-no-balancing-expected.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3-no-balancing.html: Added.
      * fast/multicol/newmulticol/breaks-2-columns-3.html: Added.
      * fast/multicol/newmulticol/breaks-3-columns-3-expected.html: Added.
      * fast/multicol/newmulticol/breaks-3-columns-3.html: Added.
      * fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html: Added.
      * fast/multicol/newmulticol/fixed-height-fill-balance-2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd8f1a2d
    • eric.carlson@apple.com's avatar
      Allow MediaSessionManager to restrict 'preload' behavior · 7cadf18b
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127297
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      Tests: media/video-restricted-no-preload-auto.html
             media/video-restricted-no-preload-metadata.html
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::parseAttribute): Apply restrictions to preload attribute before
          passing to media engine.
      (WebCore::HTMLMediaElement::loadResource): Ditto.
      
      * html/HTMLMediaSession.cpp:
      (WebCore::HTMLMediaSession::effectivePreloadForElement): New, limit preload according to restrictions.
      * html/HTMLMediaSession.h:
      
      * platform/audio/MediaSessionManager.h:
      * platform/audio/ios/MediaSessionManagerIOS.mm:
      (WebCore::MediaSessionManageriOS::resetRestrictions): Limit preload to metadata only. Drive-by
          static deviceClass initialization cleanup.
      
      * testing/Internals.cpp:
      (WebCore::Internals::setMediaSessionRestrictions): Support MetadataPreloadingNotPermitted and
          AutoPreloadingNotPermitted.
      
      LayoutTests: 
      
      * media/video-restricted-no-preload-auto-expected.txt: Added.
      * media/video-restricted-no-preload-auto.html: Added.
      * media/video-restricted-no-preload-metadata-expected.txt: Added.
      * media/video-restricted-no-preload-metadata.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cadf18b
    • akling@apple.com's avatar
      Let RenderImage construct its RenderImageResource. · dcf6c8f9
      akling@apple.com authored
      <https://webkit.org/b/127290>
      
      Everyone who creates a RenderImage immediately follows up with
      creating a RenderImageResource and assigning it to the image.
      
      Let the RenderImage constructor do this instead, and make the
      imageResource() accessors return references. This exposed a
      number of unnecessary null checks.
      
      Also modernized the touched code with std::unique_ptr.
      
      Reviewed by Antti Koivisto.
      
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::createElementRenderer):
      (WebCore::HTMLImageElement::didAttachRenderers):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::createElementRenderer):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::didAttachRenderers):
      (WebCore::HTMLVideoElement::parseAttribute):
      * html/ImageInputType.cpp:
      (WebCore::ImageInputType::createInputRenderer):
      (WebCore::ImageInputType::attach):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::renderImageResource):
      * rendering/RenderElement.cpp:
      (WebCore::RenderElement::createFor):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::RenderImage):
      (WebCore::RenderImage::~RenderImage):
      (WebCore::RenderImage::styleDidChange):
      (WebCore::RenderImage::imageChanged):
      (WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
      (WebCore::RenderImage::updateInnerContentRect):
      (WebCore::RenderImage::imageDimensionsChanged):
      (WebCore::RenderImage::notifyFinished):
      (WebCore::RenderImage::paintReplaced):
      (WebCore::RenderImage::paintIntoRect):
      (WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
      (WebCore::RenderImage::minimumReplacedHeight):
      (WebCore::RenderImage::computeIntrinsicRatioInformation):
      (WebCore::RenderImage::embeddedContentBox):
      * rendering/RenderImage.h:
      (WebCore::RenderImage::imageResource):
      (WebCore::RenderImage::cachedImage):
      * rendering/RenderImageResource.h:
      * rendering/RenderImageResourceStyleImage.h:
      * rendering/RenderMedia.cpp:
      (WebCore::RenderMedia::RenderMedia):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
      * rendering/RenderSnapshottedPlugIn.h:
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::calculateIntrinsicSize):
      * rendering/style/ContentData.cpp:
      (WebCore::ImageContentData::createContentRenderer):
      * rendering/svg/RenderSVGImage.cpp:
      (WebCore::RenderSVGImage::RenderSVGImage):
      (WebCore::RenderSVGImage::~RenderSVGImage):
      (WebCore::RenderSVGImage::updateImageViewport):
      (WebCore::RenderSVGImage::paint):
      (WebCore::RenderSVGImage::paintForeground):
      * rendering/svg/RenderSVGImage.h:
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::didAttachRenderers):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcf6c8f9
    • antti@apple.com's avatar
      Update overlay scrollbars in single pass · a9fcb2cf
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127289
      
      Reviewed by Anders Carlsson.
      
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::updateScrollbars):
              
          Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9fcb2cf
    • jochen@chromium.org's avatar
      Never send a non-http(s) referrer header even with a referrer policy · b1560682
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127172
      
      Reviewed by Alexey Proskuryakov.
      
      This mirrors the code SecurityPolicy::shouldHideReferrer which is used
      for ReferrerPolicyDefault.
      
      No new tests, only affects an embedder that registers other schemes,
      e.g. chrome://
      
      * page/SecurityPolicy.cpp:
      (WebCore::SecurityPolicy::generateReferrerHeader):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1560682
    • commit-queue@webkit.org's avatar
      Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend · 5553eb78
      commit-queue@webkit.org authored
      when having -webkit-background-blending applied. Turns out the problem was
      the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw
      
      https://bugs.webkit.org/show_bug.cgi?id=126887
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      Test: css3/compositing/background-blend-mode-crossfade-image.html
      
      * platform/graphics/CrossfadeGeneratedImage.cpp:
      (WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.
      
      LayoutTests: Reapply:
      [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
      when having -webkit-background-blending applied. Tests now use SVG rects, instead
      of circles.
      
      https://bugs.webkit.org/show_bug.cgi?id=126887
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-crossfade-image-expected.html:
      * css3/compositing/background-blend-mode-crossfade-image.html:
      * platform/efl/TestExpectations: Pass efl as blendMode is not implemented.
      * platform/mac/TestExpectations: Mark added test as ImageOnlyFailure due to slight differences between the result and the blending formula.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5553eb78
    • svillar@igalia.com's avatar
      Null-pointer dereference in WebCore::CSSValue::isPrimitiveValue · 93a7060d
      svillar@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124769
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Test: fast/gradients/crash-on-no-position-separator.html
      
      The function parseFillPosition() may not return valid values for
      centerX and centerY if the input data is malformed. We need to
      check that we get a valid pair of positions before checking that
      they're actually valid primitive values in the assertions.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseRadialGradient):
      
      LayoutTests:
      
      Checks that invalid position declarations (like skiping the comma
      separator) do not make the engine crash.
      
      * fast/gradients/crash-on-no-position-separator-expected.txt: Added.
      * fast/gradients/crash-on-no-position-separator.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93a7060d
    • commit-queue@webkit.org's avatar
      Source/WebCore: Background-blend-mode doesn't work for an element with an · 567d6a9c
      commit-queue@webkit.org authored
      SVG image as background and border-style or padding set.
      The problem consisted in the drawing path using the default
      blending parameter at all times.
      https://bugs.webkit.org/show_bug.cgi?id=118894
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
      
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
      * svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
      * svg/graphics/SVGImageForContainer.cpp:
      (WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
      
      LayoutTests: Background-blend-mode doesn't work for an element with an
      SVG image as background and border-style or padding set.
      Tests now use rectangles instead of circles for SVGs.
      https://bugs.webkit.org/show_bug.cgi?id=118894
      
      Patch by Mihai Tica <mitica@adobe.com> on 2014-01-20
      Reviewed by Dirk Schulze.
      
      * css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
      * css3/compositing/background-blend-mode-data-uri-svg-image.html:
      * platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
      * platform/mac/TestExpectations: marking test as ImageOnlyFailure due to slight pixel inconsistencies between the result and the formula.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      567d6a9c
    • zalan@apple.com's avatar
      Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when... · 6a3975c1
      zalan@apple.com authored
      Subpixel layout: setSimpleLineLayoutEnabled() produces different layout when line position has CSS px fractions.
      https://bugs.webkit.org/show_bug.cgi?id=126892
      
      Reviewed by Antti Koivisto.
      
      SimpleLineLayout needs to copy normal linebox layout's subpixel rounding strategy to produce
      the same layout.
      
      Source/WebCore:
      
      Covered by existing tests.
      
      * rendering/SimpleLineLayoutFunctions.cpp:
      (WebCore::SimpleLineLayout::paintFlow):
      
      LayoutTests:
      
      * platform/mac/TestExpectations: Unskipping some SimpleLineLayout tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a3975c1
    • commit-queue@webkit.org's avatar
      Col width is not honored when dynamically updated and it would make table narrower · 23564e41
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104711
      
      Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-01-20
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Increasing the table width by increasing the colgroup width
      was working but decreasing the table width by decreasing the
      colgroup width is not working.
      
      Test: fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html
      
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::styleDidChange):
      When colgroup width is defined table cell should adjust according to
      that. On decreasing colgroup width the cells maxPreferredLogicalWidth
      was still set to the earlier value. Setting the
      setPreferredLogicalWidthsDirty to true so that cells pref width is
      calculated again.
      
      LayoutTests:
      
      * fast/dom/HTMLTableColElement/resize-table-width-using-col-width-expected.txt: Added.
      * fast/dom/HTMLTableColElement/resize-table-width-using-col-width.html: Added.
      Added new test case to verify that table cell width decreases by
      decreasing the colgroup width.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23564e41
    • commit-queue@webkit.org's avatar
      [CoordinatedGraphics] Segmentation fault at CoordinatedGraphicsScene::clearImageBackingContents · 8897def0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125776
      
      Patch by Edit Balint <edbalint@inf.u-szeged.hu> on 2014-01-20
      Reviewed by Csaba Osztrogonác.
      
      Unexpected behavior occurs in some test cases which leads to segmentation fault.
      
      * platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
      (WebCore::CompositingCoordinator::removeImageBacking):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8897def0
    • commit-queue@webkit.org's avatar
      Region based multicol: tall line causes taller multicol container than necessary · 883b01c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=122550
      
      Source/WebCore:
      
      Detect and report all column breaks, also when there's no pagination strut involved.
      
      This may end up becoming the overall smallest space shortage in some cases,
      so we need to report it, to avoid column height over-stretching.
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      Test: fast/multicol/newmulticol/balance10.html
      
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::adjustLinePositionForPagination):
      
      LayoutTests:
      
      Patch by Morten Stenshorne <mstensho@opera.com> on 2014-01-20
      Reviewed by David Hyatt.
      
      * fast/multicol/newmulticol/balance10-expected.txt: Added.
      * fast/multicol/newmulticol/balance10.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      883b01c5
    • carlosgc@webkit.org's avatar
      [GLIB] GVariant floating references are not correctly handled by GRefPtr · ef8bd2da
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=127246
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Do not adopt GVariant floating references, they will be converted
      to a full reference by GRefPtr.
      
      * platform/gtk/PasteboardHelper.cpp:
      (WebCore::PasteboardHelper::fillSelectionData):
      (WebCore::PasteboardHelper::fillDataObjectFromDropData):
      
      Source/WTF:
      
      GRefPtr should always use g_variant_ref_sink to deal with GVariant
      floating references. In case of full references,
      g_variant_ref_sink calls g_variant_ref, so it's safe to use it always.
      
      * wtf/gobject/GRefPtr.cpp:
      (WTF::refGPtr): Use g_variant_ref_sink().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef8bd2da
    • jinwoo7.song@samsung.com's avatar
      Use unsigned type for the size of CSSParserValueList · 4a1cd09f
      jinwoo7.song@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127211
      
      Reviewed by Andreas Kling.
      
      * css/CSSParser.cpp: Changed variable type from int to unsigned.
      (WebCore::CSSParser::parseValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a1cd09f
  3. 19 Jan, 2014 5 commits
    • ljaehun.lim@samsung.com's avatar
      Unreviewed build fix after r162293 · fedbdbdb
      ljaehun.lim@samsung.com authored
      Fix debug build.
      
      [ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp: In member function ‘void WebCore::HTMLTreeBuilder::processStartTagForInTable(WebCore::AtomicHTMLToken*)’:
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: error: no match for ‘operator!’ in ‘!(WebCore::HTMLTreeBuilder::InsertionMode)12’
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: candidate is:
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: operator!(bool) <built-in>
      /source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note:   no known conversion for argument 1 from ‘WebCore::HTMLTreeBuilder::InsertionMode’ to ‘bool’
      make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o] Error 1
      make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
      make: *** [all] Error 2
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processStartTagForInTable): Fix ASSERT.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fedbdbdb
    • andersca@apple.com's avatar
      Stop using MutexTryLocker in WebCore · e6098d32
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127254
      
      Reviewed by Andreas Kling.
      
      Instead use std::mutex and std::unique_lock with the std::try_to_lock constructor.
      
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::process):
      (WebCore::AudioBufferSourceNode::setBuffer):
      * Modules/webaudio/AudioBufferSourceNode.h:
      * Modules/webaudio/AudioParamTimeline.cpp:
      (WebCore::AudioParamTimeline::insertEvent):
      (WebCore::AudioParamTimeline::cancelScheduledValues):
      (WebCore::AudioParamTimeline::valueForContextTime):
      (WebCore::AudioParamTimeline::valuesForTimeRange):
      (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
      * Modules/webaudio/AudioParamTimeline.h:
      * Modules/webaudio/ConvolverNode.cpp:
      (WebCore::ConvolverNode::process):
      (WebCore::ConvolverNode::reset):
      (WebCore::ConvolverNode::setBuffer):
      * Modules/webaudio/ConvolverNode.h:
      * Modules/webaudio/MediaElementAudioSourceNode.cpp:
      (WebCore::MediaElementAudioSourceNode::setFormat):
      (WebCore::MediaElementAudioSourceNode::process):
      (WebCore::MediaElementAudioSourceNode::lock):
      (WebCore::MediaElementAudioSourceNode::unlock):
      * Modules/webaudio/MediaElementAudioSourceNode.h:
      * Modules/webaudio/MediaStreamAudioSourceNode.cpp:
      (WebCore::MediaStreamAudioSourceNode::setFormat):
      (WebCore::MediaStreamAudioSourceNode::process):
      * Modules/webaudio/MediaStreamAudioSourceNode.h:
      * Modules/webaudio/OscillatorNode.cpp:
      (WebCore::OscillatorNode::process):
      (WebCore::OscillatorNode::setPeriodicWave):
      * Modules/webaudio/OscillatorNode.h:
      * Modules/webaudio/PannerNode.cpp:
      (WebCore::PannerNode::process):
      (WebCore::PannerNode::setPanningModel):
      * Modules/webaudio/PannerNode.h:
      * Modules/webaudio/WaveShaperProcessor.cpp:
      (WebCore::WaveShaperProcessor::setCurve):
      (WebCore::WaveShaperProcessor::setOversample):
      (WebCore::WaveShaperProcessor::process):
      * Modules/webaudio/WaveShaperProcessor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6098d32
    • berto@igalia.com's avatar
      Does not build with SVG disabled · 0ce8cf93
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127248
      
      Reviewed by Sam Weinig.
      
      Add missing #if ENABLE(SVG) guard.
      
      * dom/ElementData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce8cf93
    • andersca@apple.com's avatar
      Use a strong enum for HTMLTreeBuilder::InsertionMode · 09ce1d50
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127252
      
      Reviewed by Antti Koivisto.
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
      (WebCore::HTMLTreeBuilder::constructTree):
      (WebCore::HTMLTreeBuilder::processDoctypeToken):
      (WebCore::HTMLTreeBuilder::processStartTagForInBody):
      (WebCore::HTMLTreeBuilder::processTemplateStartTag):
      (WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
      (WebCore::HTMLTreeBuilder::closeTheCell):
      (WebCore::HTMLTreeBuilder::processStartTagForInTable):
      (WebCore::HTMLTreeBuilder::processStartTag):
      (WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
      (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
      (WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
      (WebCore::HTMLTreeBuilder::processEndTagForInRow):
      (WebCore::HTMLTreeBuilder::processEndTagForInCell):
      (WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
      (WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
      (WebCore::HTMLTreeBuilder::processEndTag):
      (WebCore::HTMLTreeBuilder::processComment):
      (WebCore::HTMLTreeBuilder::processCharacterBuffer):
      (WebCore::HTMLTreeBuilder::processEndOfFile):
      (WebCore::HTMLTreeBuilder::defaultForInitial):
      (WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
      (WebCore::HTMLTreeBuilder::processStartTagForInHead):
      (WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
      (WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
      (WebCore::HTMLTreeBuilder::processScriptStartTag):
      * html/parser/HTMLTreeBuilder.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162293 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09ce1d50
    • andersca@apple.com's avatar
      Convert LoaderRunLoopCF.cpp and WebCoreThreadRun.cpp over to modern threading primitives · 859fc577
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=127251
      
      Reviewed by Antti Koivisto.
      
      Also add a condition to the loaderRunLoop() function to protect against spurious wake-ups.
      
      * platform/ios/wak/WebCoreThreadRun.cpp:
      * platform/network/cf/LoaderRunLoopCF.cpp:
      (WebCore::loaderRunLoopMutex):
      (WebCore::loaderRunLoopConditionVariable):
      (WebCore::runLoaderThread):
      (WebCore::loaderRunLoop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      859fc577