1. 09 Oct, 2012 40 commits
    • commit-queue@webkit.org's avatar
      [chromium] Add drop event for plugins. · 9f69b20a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98827
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-10-09
      Reviewed by Adam Barth.
      
      Source/WebKit/chromium:
      
      Add conversion for drop events.
      
      * public/WebDragStatus.h:
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::handleDragEvent):
      
      Tools:
      
      Update the test plugin to receive drop events.
      
      * DumpRenderTree/chromium/TestWebPlugin.cpp:
      (TestWebPlugin::handleDragStatusUpdate):
      
      LayoutTests:
      
      Updated the test to verify that a plugin can receive drop events. Note
      that the plugin needs contentEditable set to true.
      
      * platform/chromium/plugins/drag-events-expected.txt:
      * platform/chromium/plugins/drag-events.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f69b20a
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r130811 and r130821. · a2a40f8f
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/130811
      http://trac.webkit.org/changeset/130821
      https://bugs.webkit.org/show_bug.cgi?id=98831
      
      Broke date-suggestion-picker-appearance-with-scroll-bar.html
      (Requested by abarth|gardening on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::getUpperLeftCorner):
      (WebCore::ContainerNode::getLowerRightCorner):
      * dom/MouseRelatedEvent.cpp:
      (WebCore::MouseRelatedEvent::computeRelativePosition):
      * dom/Node.cpp:
      (WebCore::Node::convertToPage):
      (WebCore::Node::convertFromPage):
      * editing/FrameSelection.cpp:
      (WebCore::CaretBase::absoluteBoundsForLocalRect):
      * editing/RenderedPosition.cpp:
      (WebCore::RenderedPosition::absoluteRect):
      * editing/VisiblePosition.cpp:
      (WebCore::VisiblePosition::absoluteCaretBounds):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::setPositionFromPoint):
      * html/shadow/SpinButtonElement.cpp:
      (WebCore::SpinButtonElement::defaultEventHandler):
      * page/FrameView.cpp:
      (WebCore::FrameView::convertFromRenderer):
      (WebCore::FrameView::convertToRenderer):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintDocumentMarker):
      (WebCore::InlineTextBox::paintTextMatchMarker):
      (WebCore::InlineTextBox::computeRectForReplacementMarker):
      * rendering/LayoutState.cpp:
      (WebCore::LayoutState::LayoutState):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::absoluteQuads):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::absoluteQuads):
      (WebCore::RenderBox::absoluteContentBox):
      (WebCore::RenderBox::mapLocalToContainer):
      (WebCore::RenderBox::mapAbsoluteToLocalPoint):
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
      (WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
      * rendering/RenderBoxModelObject.h:
      (RenderBoxModelObject):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::userResize):
      * rendering/RenderGeometryMap.cpp:
      (WebCore::RenderGeometryMap::absolutePoint):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::mapLocalToContainer):
      * rendering/RenderInline.h:
      (RenderInline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::absoluteToContents):
      (WebCore::RenderLayer::convertToLayerCoords):
      (WebCore::RenderLayer::scrollTo):
      (WebCore::RenderLayer::calculateClipRects):
      (WebCore::RenderLayer::childrenClipRect):
      (WebCore::RenderLayer::selfClipRect):
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::contentsVisible):
      * rendering/RenderMediaControls.cpp:
      (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::showPopup):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::absoluteFocusRingQuads):
      (WebCore::RenderObject::localToAbsolute):
      (WebCore::RenderObject::absoluteToLocal):
      (WebCore::RenderObject::mapLocalToContainer):
      (WebCore::RenderObject::mapAbsoluteToLocalPoint):
      (WebCore::RenderObject::localToContainerQuad):
      (WebCore::RenderObject::localToContainerPoint):
      * rendering/RenderObject.h:
      (RenderObject):
      (WebCore::RenderObject::localToAbsoluteQuad):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::absoluteRectsForRange):
      (WebCore::RenderText::absoluteQuads):
      (WebCore::RenderText::absoluteQuadsForRange):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::mapLocalToContainer):
      (WebCore::RenderView::mapAbsoluteToLocalPoint):
      (WebCore::RenderView::selectionBounds):
      * rendering/RenderView.h:
      (RenderView):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::updateWidgetGeometry):
      * rendering/svg/RenderSVGForeignObject.cpp:
      (WebCore::RenderSVGForeignObject::mapLocalToContainer):
      * rendering/svg/RenderSVGForeignObject.h:
      (RenderSVGForeignObject):
      * rendering/svg/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::mapLocalToContainer):
      * rendering/svg/RenderSVGInline.h:
      (RenderSVGInline):
      * rendering/svg/RenderSVGModelObject.cpp:
      (WebCore::RenderSVGModelObject::mapLocalToContainer):
      (WebCore::RenderSVGModelObject::absoluteQuads):
      * rendering/svg/RenderSVGModelObject.h:
      (RenderSVGModelObject):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::mapLocalToContainer):
      * rendering/svg/RenderSVGRoot.h:
      (RenderSVGRoot):
      * rendering/svg/RenderSVGText.cpp:
      (WebCore::RenderSVGText::mapLocalToContainer):
      (WebCore::RenderSVGText::absoluteQuads):
      * rendering/svg/RenderSVGText.h:
      (RenderSVGText):
      * rendering/svg/SVGRenderSupport.cpp:
      (WebCore::SVGRenderSupport::mapLocalToContainer):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
      
      Source/WebKit/chromium:
      
      * src/FindInPageCoordinates.cpp:
      (WebKit::toNormalizedRect):
      * src/LinkHighlight.cpp:
      (WebKit::convertTargetSpaceQuadToCompositedLayer):
      * src/WebInputEventConversion.cpp:
      (WebKit::convertLocationForRenderObject):
      
      Source/WebKit/mac:
      
      * WebView/WebFullScreenController.mm:
      (screenRectOfContents):
      * WebView/WebRenderNode.mm:
      (copyRenderNode):
      
      Source/WebKit2:
      
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::WebRenderObject):
      * WebProcess/FullScreen/WebFullScreenManager.cpp:
      (WebKit::screenRectOfContents):
      
      LayoutTests:
      
      * fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Removed.
      * platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
      * platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
      * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Removed.
      * platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Removed.
      * platform/mac-lion/TestExpectations:
      * platform/mac-snowleopard/TestExpectations:
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-4.8/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win-wk2/TestExpectations:
      * platform/win-xp/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2a40f8f
    • dmazzoni@google.com's avatar
      AX: 5 accessibility tests just need minor tweaks to pass on chromium · 4b5ba0ae
      dmazzoni@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98311
      
      Reviewed by Chris Fleizach.
      
      Tools:
      
      Update roleToString on Chromium to include all missing roles,
      which enables some layout tests to pass.
      
      * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
      (roleToString):
      
      LayoutTests:
      
      Modifies tests so that they log data that tends to vary between
      platforms using debug(), rather than asserting a platform-specific
      value. Gets rid of "forks" of tests in the gtk directory. Adds
      expectations and unskips 5 tests on Chromium.
      
      * accessibility/aria-list-and-listitem.html:
      * accessibility/aria-option-role.html:
      * accessibility/aria-tab-roles.html:
      * platform/chromium/TestExpectations:
      * platform/chromium/accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-fallback-roles-expected.txt.
      * platform/chromium/accessibility/aria-list-and-listitem-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-list-and-listitem-expected.txt.
      * platform/chromium/accessibility/aria-option-role-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt.
      * platform/chromium/accessibility/aria-tab-roles-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-tab-roles-expected.txt.
      * platform/gtk/accessibility/aria-list-and-listitem-expected.txt:
      * platform/gtk/accessibility/aria-list-and-listitem.html: Removed.
      * platform/gtk/accessibility/aria-option-role-expected.txt:
      * platform/gtk/accessibility/aria-option-role.html: Removed.
      * platform/mac/accessibility/aria-list-and-listitem-expected.txt:
      * platform/mac/accessibility/aria-option-role-expected.txt:
      * platform/mac/accessibility/aria-tab-roles-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b5ba0ae
    • leviw@chromium.org's avatar
      Rolling back unintended change to iframe-copy-on-scroll.html from previous commit. · 3732b6ce
      leviw@chromium.org authored
      * compositing/iframes/iframe-copy-on-scroll.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3732b6ce
    • leviw@chromium.org's avatar
      Unreviewed gardening. Updating test expectations after r130811. · 55412ed1
      leviw@chromium.org authored
      * compositing/iframes/iframe-copy-on-scroll.html:
      * platform/chromium-mac-snowleopard/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
      * platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
      * platform/chromium-mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55412ed1
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r130812. · b293e95b
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/130812
      https://bugs.webkit.org/show_bug.cgi?id=98826
      
      Caused fast/text/shaping/shaping-selection-rect to fail
      (Requested by abarth|gardening on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-09
      
      * platform/graphics/Font.cpp:
      (WebCore::Font::width):
      * platform/graphics/Font.h:
      (Font):
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::TextLayout::width):
      (WebCore::Font::width):
      (WebCore::ComplexTextController::advance):
      * platform/graphics/mac/ComplexTextController.h:
      (ComplexTextController):
      * rendering/RenderBlock.h:
      (WebCore):
      (LineBreaker):
      (RenderBlock):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::setLogicalWidthForTextRun):
      (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
      (WebCore::RenderBlock::createLineBoxesFromBidiRuns):
      (WebCore::RenderBlock::layoutRunsAndFloatsInRange):
      (WebCore::textWidth):
      (WebCore::RenderBlock::LineBreaker::nextLineBreak):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b293e95b
    • dpranke@chromium.org's avatar
      webkit-patch rebaseline-expectations doesn't work w/o failures specified · 9e98408d
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98810
      
      Reviewed by Ojan Vafai.
      
      If you try to mark a test as foo.html [ Rebaseline ] it wasn't
      getting picked up for rebaselining; we needed to think the test
      was failing.
      
      * Scripts/webkitpy/layout_tests/models/test_expectations.py:
      (TestExpectations.get_rebaselining_failures):
      * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
      (RebaseliningTest.test_get_rebaselining_failures):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e98408d
    • rniwa@webkit.org's avatar
      DOM/textarea-edit.html spends 35% of time in numGraphemeClusters · a066297c
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98711
      
      Reviewed by Kent Tamura.
      
      Since the number of characters is always greater than the number of grapheme clusters,
      we can avoid calling computeLengthForSubmission when the number of characters is less
      than maxlength. We still have to count the number of LFs since they all need to be
      converted into CRLFs. This improves WebKit's score on DOM/textarea-edit.html by 45%.
      
      * html/HTMLTextAreaElement.cpp:
      (WebCore::computeLengthForSubmission):
      (WebCore::numberOfLineBreaks):
      (WebCore::upperBoundForLengthForSubmission): Added.
      (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):
      (WebCore::HTMLTextAreaElement::tooLong):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a066297c
    • japhet@chromium.org's avatar
      Make CachedResourceLoader RefCounted and have both Document · 97fe905c
      japhet@chromium.org authored
      and DocumentLoader hold RefPtrs. This is in preparation for
      caching main resources.
      https://bugs.webkit.org/show_bug.cgi?id=86787
      
      Reviewed by Adam Barth.
      
      No new tests, no functionality changes at this time.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/Document.cpp:
      (WebCore::Document::Document): Only create our own CachedResourceLoader
          if we were given a null frame.
      (WebCore::Document::~Document):
      (WebCore::Document::cachedResourceLoader):
      (WebCore):
      * dom/Document.h:
      (Document):
      * loader/DocumentLoader.cpp: Throughout, use our m_cachedResourceLoader instead
          of the Document's pointer.
      (WebCore::DocumentLoader::DocumentLoader): Create a CachedResourceLoader.
      (WebCore::DocumentLoader::~DocumentLoader):
      (WebCore::DocumentLoader::isLoadingInAPISense):
      (WebCore::DocumentLoader::subresource):
      (WebCore::DocumentLoader::getSubresources):
      * loader/DocumentLoader.h:
      (WebCore::DocumentLoader::cachedResourceLoader):
      (DocumentLoader):
      * loader/SubresourceLoader.cpp: Remove m_document, since it only existed to keep alive and access the CachedResourceLoader.
          It can now be accessed from m_documentLoader.
      (WebCore::SubresourceLoader::SubresourceLoader):
      (WebCore::SubresourceLoader::~SubresourceLoader):
      (WebCore::SubresourceLoader::willSendRequest):
      (WebCore::SubresourceLoader::releaseResources):
      * loader/SubresourceLoader.h:
      (SubresourceLoader):
      * loader/cache/CachedResourceLoader.cpp: Handle the possibility of a null Document in several places.
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::~CachedResourceLoader):
      (WebCore::CachedResourceLoader::frame):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      (WebCore::CachedResourceLoader::loadDone):
      * loader/cache/CachedResourceLoader.h:
      (WebCore):
      (WebCore::CachedResourceLoader::create): Add create(), make constructor private.
      (CachedResourceLoader):
      (WebCore::CachedResourceLoader::document):
      (WebCore::CachedResourceLoader::setDocument):
      (WebCore::CachedResourceLoader::clearDocumentLoader):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97fe905c
    • commit-queue@webkit.org's avatar
      CSS Style is not recalculated when media attribute of style element is changed · 209c8cca
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96752
      
      Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-10-09
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      When "media" attribute of style element is changed, style should be recalculated.
      This patch modifies HTMLStyleElement::parseAttribute, so that when the media attribute
      is updated, new MediaQuerySet is created and applied to the style element then, document
      style is recalculated. Since media query set is updated for CSSStyleSheet, CSSOM wrapper
      for media query should be updated as well in order to sync with new media query set value.
      
      Test: fast/media/mq-js-update-media.html
      
      * css/CSSStyleSheet.cpp:
      (WebCore::CSSStyleSheet::setMediaQueries):
      * html/HTMLStyleElement.cpp:
      (WebCore::HTMLStyleElement::parseAttribute):
      
      LayoutTests:
      
      Added test to verify that when "media" attribute for style element is updated,
      style is recalculated.
      
      * fast/media/mq-js-update-media.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      209c8cca
    • benm@google.com's avatar
      [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources() · e66d413b
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97689
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      In addition to the WebKit/chromium side of the change, remove the
      ASSERT in SecurityOrigin::grantLoadLocalResources(). Android WebView
      is a legitimate user of this API in cases where neither of the
      ASSERT'd conditions hold.
      
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::grantLoadLocalResources): Remove ASSERT.
      
      Source/WebKit/chromium:
      
      This change exposes the WebCore::SecurityOrigin::grantLoadLocalResources()
      function to the Chromium WebKit API layer. This is needed in Chromium
      to implement the Android WebView.loadDataWithBaseUrl function in a
      compatible manner.
      
      Please see crbug.com/152223 for further information and the chromium
      side patch.
      
      * public/WebSecurityOrigin.h:
      (WebSecurityOrigin): Add grantLoadLocalResources() API.
      * src/WebSecurityOrigin.cpp:
      (WebKit::WebSecurityOrigin::grantLoadLocalResources):
          Implement the API by calling through to the WebCore function
          of the same name.
      (WebKit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e66d413b
    • jonlee@apple.com's avatar
      Build fix for Qt Windows. · 6d48f5b1
      jonlee@apple.com authored
      * html/HTMLPlugInElement.h: Include Image.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d48f5b1
    • jchaffraix@webkit.org's avatar
      [Chromium] Chromium DEPS has a stray directory, turning our Win bots red · 9bc44472
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98817
      
      Reviewed by Dirk Pranke.
      
      * DEPS: Removed the stray directory which solved the redness on several of our bots.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bc44472
    • enrica@apple.com's avatar
      Only measure text once instead of twice when performing line layout. · 85c777dd
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98317
      <rdar://problem/12080821>
      
      Reviewed by Dan Bernstein.
      
      Since we are measuring each word to find out where the line break should occur,
      we should cache that information to avoid measuring the run again when
      creating the line box. The bulk of the change is in nextLineBreak, where
      the measurements are collected and placed in a vector so that they can
      be consumed in setLogicalWidthForTextRun where we used to measure the
      text one more time.
      Each entry in the vector is a WordMeasurement object that contains information
      about the start and end offset in the run, the renderer, the measured width
      and, possibly, a list of fallback fonts.
      When we need to compute the width of the run to create the line box, we add
      all the measurements for the given renderer in the run to get the total width.
      
      * platform/graphics/Font.cpp:
      (WebCore::Font::width): Added fallback fonts parameter.
      * platform/graphics/Font.h:
      (Font): Added fallback fonts parameter to the width static member function.
      This method is called when we compute the width using TextLayout.
      * platform/graphics/mac/ComplexTextController.cpp:
      (WebCore::TextLayout::width): Added fallback fonts parameter.
      (WebCore::Font::width):
      (WebCore::ComplexTextController::advance):
      * platform/graphics/mac/ComplexTextController.h:
      (ComplexTextController): Added fallback fonts parameter to advance method.
      * rendering/RenderBlock.h: Added WordMeasures parameter to few methods.
      * rendering/RenderBlockLineLayout.cpp:
      (WordMeasurement): Added new class to hold measurement information.
      (WebCore::setLogicalWidthForTextRun): This is where we compute the run width using the
      cached information.
      (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Added wordMeasures parameter.
      (WebCore::RenderBlock::createLineBoxesFromBidiRuns): Added wordMeasures parameter.
      (WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added declaration of the WordMeasures
      vector and its use.
      (WebCore::textWidth): Added fallbackFonts parameter, since now we only measure once.
      (WebCore::RenderBlock::LineBreaker::nextLineBreak): This method has been modified to collect
      the measurements of the individual words and add them to the vector.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85c777dd
    • leviw@chromium.org's avatar
      [Sub pixel layout] Fast-path iframe scrolling can picks up an extra pixel · 56cde565
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98571
      
      Reviewed by Emil A Eklund.
      
      Source/WebCore:
      
      Refactoring all coordinate-switching functionality to use a single "mode" flag
      as opposed to having a bunch of boolean values. This enables the same set of
      options across the board, and a consistent interface. This was previously
      done for mapLocalToContainer.
      
      The imptetus for this for this stems from the one logical change in this patch
      which only effects sub-pixel layout. FrameView::convertToRenderer and
      convertFromRenderer return IntPoint coordinates, and need to also snap transform
      offsets to determine proper rects for scrolling.
      
      Unlabeled functions below are simply being updated to these new interfaces.
      
      Test: fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html
      
      * WebCore.exp.in:
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::getUpperLeftCorner):
      (WebCore::ContainerNode::getLowerRightCorner):
      * dom/Element.cpp:
      (WebCore::Element::boundsInRootViewSpace):
      * dom/MouseRelatedEvent.cpp:
      (WebCore::MouseRelatedEvent::computeRelativePosition):
      * dom/Node.cpp:
      (WebCore::Node::convertToPage):
      (WebCore::Node::convertFromPage):
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::setPositionFromPoint):
      * html/shadow/SpinButtonElement.cpp:
      (WebCore::SpinButtonElement::defaultEventHandler):
      * page/FrameView.cpp:
      (WebCore::FrameView::convertToRenderer): Now pixel-snaps offsets before passing
      them to TransformState, which transforms the coordinates.
      (WebCore::FrameView::convertFromRenderer): Ditto.
      * rendering/LayoutState.cpp:
      (WebCore::LayoutState::LayoutState):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::absoluteQuads):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::absoluteQuads):
      (WebCore::RenderBox::mapLocalToContainer):
      (WebCore::RenderBox::mapAbsoluteToLocalPoint):
      * rendering/RenderBox.h:
      (RenderBox):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
      * rendering/RenderBoxModelObject.h:
      (RenderBoxModelObject):
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::userResize):
      * rendering/RenderGeometryMap.cpp:
      (WebCore::RenderGeometryMap::absolutePoint):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::mapLocalToContainer):
      * rendering/RenderInline.h:
      (RenderInline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::absoluteToContents):
      (WebCore::RenderLayer::calculateClipRects):
      * rendering/RenderMediaControls.cpp:
      (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::showPopup):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::localToAbsolute):
      (WebCore::RenderObject::absoluteToLocal):
      (WebCore::RenderObject::mapLocalToContainer):
      (WebCore::RenderObject::mapAbsoluteToLocalPoint):
      (WebCore::RenderObject::localToContainerQuad):
      (WebCore::RenderObject::localToContainerPoint):
      * rendering/RenderObject.h:
      (RenderObject): MapLocalToContainerFlags is now MapCoordinatesFlags since it's
      now used for other conversion methods.
      (WebCore::RenderObject::localToAbsoluteQuad):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::mapLocalToContainer):
      (WebCore::RenderView::mapAbsoluteToLocalPoint):
      * rendering/RenderView.h:
      (RenderView):
      * rendering/svg/RenderSVGForeignObject.cpp:
      (WebCore::RenderSVGForeignObject::mapLocalToContainer):
      * rendering/svg/RenderSVGForeignObject.h:
      (RenderSVGForeignObject):
      * rendering/svg/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::mapLocalToContainer):
      * rendering/svg/RenderSVGInline.h:
      (RenderSVGInline):
      * rendering/svg/RenderSVGModelObject.cpp:
      (WebCore::RenderSVGModelObject::mapLocalToContainer):
      * rendering/svg/RenderSVGModelObject.h:
      (RenderSVGModelObject):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::mapLocalToContainer):
      * rendering/svg/RenderSVGRoot.h:
      (RenderSVGRoot):
      * rendering/svg/RenderSVGText.cpp:
      (WebCore::RenderSVGText::mapLocalToContainer):
      * rendering/svg/RenderSVGText.h:
      (RenderSVGText):
      * rendering/svg/SVGRenderSupport.cpp:
      (WebCore::SVGRenderSupport::mapLocalToContainer):
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
      
      LayoutTests:
      
      Tests scrolling of sub-pixel layers on sub-pixel platforms (Chromium).
      
      * fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Added.
      * platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
      * platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
      * platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      The repaint rect shrinks safely by one pixel.
      * platform/chromium/TestExpectations:
      * platform/mac-lion/TestExpectations:
      * platform/mac-snowleopard/TestExpectations:
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt-4.8/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win-wk2/TestExpectations:
      * platform/win-xp/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      * platform/wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56cde565
    • jonlee@apple.com's avatar
      [WK2] Have plugins render offscreen to capture snapshot · f5ace973
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98326
      <rdar://problem/12426658>
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Change updateSnapshot() to use a PassRefPtr<Image> instead of Image*. WebKit2 ultimately
      hands the image off to RenderSnapshottedPlugin. A CachedImage instance then manages the
      lifetime of the Image.
      
      * html/HTMLPlugInElement.h:
      (WebCore::HTMLPlugInElement::updateSnapshot):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::updateSnapshot):
      * html/HTMLPlugInImageElement.h:
      (HTMLPlugInImageElement):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::updateSnapshot): Updated to use the PassRefPtr<Image>
      pointer.
      * rendering/RenderSnapshottedPlugIn.h:
      (RenderSnapshottedPlugIn):
      
      Source/WebKit2:
      
      Keep the plugin rendering without compositing to easily grab the snapshot.
      
      PluginView now has two variables referring to snapshots, but are unrelated. The timer
      is used to capture a snapshot that acts as a poster for a plugin. The ShareableBitmap
      variable m_snapshot is used whenever the plugin paints in software, to avoid side effects
      should the plugin run JS during painting.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit): Add a named constant for the time delay before a snapshot is taken.
      (WebKit::PluginView::PluginView): Initialize a 3-second timer to get the snapshot.
      (WebKit::PluginView::~PluginView): Refactor part of the destructor code out into
      destroyPluginAndReset() for reuse.
      (WebKit::PluginView::destroyPluginAndReset): Contains part of the destructor code.
      In addition to destroying the plugin, the destructor cancels pending loads and streams.
      (WebKit::PluginView::didInitializePlugin): If the plugin is in a state where it needs
      to generate or display a poster, don't setup the compositing layer and start the timer.
      (WebKit::PluginView::paint): Avoid painting if the plugin is not running.
      (WebKit::PluginView::invalidateRect): Avoid painting if the plugin is not running.
      (WebKit::PluginView::isAcceleratedCompositingEnabled): Don't enable accelerated compositing
      until the plugin is running.
      (WebKit::PluginView::pluginSnapshotTimerFired): When the timer fires, get a snapshot, generate
      an Image that WebCore can render, and destroy the plugin.
      
      Rename m_snapshot to m_transientPaintingSnapshot.
      * WebProcess/Plugins/PluginView.h:
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::paint):
      (WebKit::PluginView::notifyWidget):
      (WebKit::PluginView::pluginSnapshotTimerFired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5ace973
    • abarth@webkit.org's avatar
      These tests also fail with ImageOnlyFailures. · c57b69d9
      abarth@webkit.org authored
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c57b69d9
    • abarth@webkit.org's avatar
      This test now appears to fail on the bots because · 77778fd6
      abarth@webkit.org authored
      http://trac.webkit.org/changeset/130799 removed the ImageOnlyFailure
      attribute.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77778fd6
    • abarth@webkit.org's avatar
      Unreviewed. Move this file to where the build systems think it should · c18813e7
      abarth@webkit.org authored
      be. See https://bugs.webkit.org/show_bug.cgi?id=94755
      
      * platform/graphics/CustomFilterConstants.h: Removed.
      * platform/graphics/filters/CustomFilterConstants.h: Copied from Source/WebCore/platform/graphics/CustomFilterConstants.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c18813e7
    • tony@chromium.org's avatar
      Use computeLogical* methods instead of updateLogical* methods in RenderImage · a2131ece
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98802
      
      Reviewed by Eric Seidel.
      
      We were storing the old values of width/height, calling updateLogical{Width,Height}, then restoring
      the old values.  Instead, use the computeLogical{Width,Height} methods so we don't have to overwrite
      the current values.
      
      No new tests, this is just a refactoring.
      
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::imageDimensionsChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2131ece
    • dbates@webkit.org's avatar
      VCSUtils.pm doesn't support SVN 1.7 diff files · fda2c518
      dbates@webkit.org authored
      <https://bugs.webkit.org/show_bug.cgi?id=80762>
      
      Reviewed by Eric Seidel.
      
      Implement support for the SVN 1.7 diff format.
      
      * Scripts/VCSUtils.pm:
      (parseChunkRange): Modified to support parsing an SVN 1.7 chunk range
      that begins and ends with "##" (e.g. ## -0,0 +1,7 ##). For comparison,
      earlier versions of SVN parsed chunk ranges of the form "@@ -0,0 +1,7 @@".
      
      (parseSvnDiffHeader): Modified to parse an SVN 1.7 binary diff; SVN 1.7
      has an unusual display format for a binary diff. It repeats the first
      two lines of the diff header.
      
      (parseSvnProperty): Modified to ignore both an SVN 1.7 chunk range and
      lines of the form "\ No newline at end of property". SVN 1.7 emits the latter
      message after a property value that doesn't end in a newline.
      
      (parseSvnPropertyValue): Stop parsing an SVN property value when we encounter
      a line of the form "\ No newline at end of property" (emitted by svn diff as of
      SVN 1.7).
      
      * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
        - Added the following unit tests:
        "Line count is 0"
        "New line count is 1"
      
      * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
        - Added the following unit tests:
        "svn:executable followed by custom property using SVN 1.7 syntax"
        "svn:executable followed by custom property without newline using SVN 1.7 syntax"
      
      * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
        - Updated test results for test "binary file".
        - Added unit test "binary file using SVN 1.7 syntax".
      
      * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
        - Added the following unit tests:
        "simple: add svn:executable using SVN 1.7 syntax"
        "simple: delete svn:executable using SVN 1.7 syntax"
        "add svn:mime-type and add svn:executable using SVN 1.7 syntax"
      
      * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
        - Added the following unit tests:
        "singe-line '+' change using SVN 1.7 syntax"
        "single-line '-' change using SVN 1.7 syntax"
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fda2c518
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Cleanup FatFingers.cpp · 1d798eed
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98806
      
      Reviewed by Antonio Gomes.
      
      Cleanup namespace usage and sync up FatFingers.cpp.
      
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::compareDistanceBetweenPoints):
      (BlackBerry::WebKit::FatFingers::findBestPoint):
      (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
      (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
      (BlackBerry::WebKit::FatFingers::checkForClickableElement):
      (BlackBerry::WebKit::FatFingers::checkForText):
      (BlackBerry::WebKit::FatFingers::getNodesFromRect):
      (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d798eed
    • enrica@apple.com's avatar
      [chromium] fast/text/international/text-spliced-font.html and fast/writing-mode/Kusa-Makura- · dd57984f
      enrica@apple.com authored
      background-canvas.html failing on the Mac after r130443
      https://bugs.webkit.org/show_bug.cgi?id=98545
      
      Reviewed by Tony Chang.
      
      Adding back the ! removed by mistake before submitting r130779. 
      
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::glyphDataAndPageForCharacter):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd57984f
    • jamesr@google.com's avatar
      Unreviewed, rolling out r128488. · 60b9a37d
      jamesr@google.com authored
      http://trac.webkit.org/changeset/128488
      https://bugs.webkit.org/show_bug.cgi?id=96678
      
      The bot is fixed now
      
      * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
      (.):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60b9a37d
    • commit-queue@webkit.org's avatar
      [BlackBerry] EGL Context deleted prematurely in GraphicsContext3D destructor · ecd98beb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98796
      
      Patch by Artem Simonov <asimonov@rim.com> on 2012-10-09
      Reviewed by George Staikos.
      
      Reordered destruction of GraphicsContext3D so that the compositing layer is
      destroyed first.
      
      * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
      (WebCore::GraphicsContext3D::~GraphicsContext3D):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecd98beb
    • commit-queue@webkit.org's avatar
      Disable hinting when webkit-font-smoothing:antialiased is used on Mac. · cff69576
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98061
      
      Patch by Ben Wagner <bungeman@chromium.org> on 2012-10-09
      Reviewed by Stephen White.
      
      Normal anti-aliased text matches subpixel anti-aliased text.
      However, text marked with webkit-font-smoothing:antialiased should be drawn without hinting to match Safari.
      See crbug.com/152304 .
      
      Test is fast/css/font-smoothing.html, but DRT runs with font smoothing disabled, so no change visible.
      
      * platform/graphics/skia/FontSkia.cpp:
      (WebCore::setupPaint):
      Set kNo_Hinting when webkit-font-smoothing is antialiased.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cff69576
    • peter@chromium.org's avatar
      [Chromium] More TestExpectation updates for Android · b103a393
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98818
      
      Unreviewed test expectation updates.
      
      List more failures (all with bugs assigned) in the TestExpectation file for
      Android. Move an older block around, considering we may want to re-triage it.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b103a393
    • jchaffraix@webkit.org's avatar
      Unreviewed Chromium gardening. · bde8967f
      jchaffraix@webkit.org authored
      * platform/chromium/TestExpectations:
      Removed this entry: there was no need for new baselines.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bde8967f
    • commit-queue@webkit.org's avatar
      [CSS Shaders] Create constants for vertex attribute sizes and offsets · a24b9462
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94755
      
      Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-09
      Reviewed by Dean Jackson.
      
      Factor out the vertex attribute size and offset constants into a new file,
      CustomFilterConstants.h. Replace literals in CustomFilterMeshGenerator with the constants.
      
      I could have added the constants to CustomFilterMeshGenerator.h, but this would make
      FECustomFilter depend on CustomFilterMeshGenerator.
      
      I also could have added the constants to CustomFilterMesh.h, but this would make
      CustomFilterMeshGenerator depend on CustomFilterMesh.
      
      No new tests. No change in behavior.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * platform/graphics/CustomFilterConstants.h: Added.
      (WebCore):
      * platform/graphics/filters/CustomFilterMeshGenerator.h:
      (WebCore::CustomFilterMeshGenerator::floatsPerVertex):
          Use the new constants instead of literal values.
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::bindProgramAndBuffers):
          Pull the constant definitions out of here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a24b9462
    • abarth@webkit.org's avatar
      dfg-cross-global tests are flaky because they misuse js-test-pre.js · 1ff9d56d
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98813
      
      Reviewed by Daniel Bates.
      
      These tests have a race between js-test-pre's "done" message and the
      timeout. This patch change then to use jsTestIsAsync and finishJSTest()
      appropriately.
      
      * fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js:
      * fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js:
      * fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js:
      * fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js:
      * fast/js/script-tests/dfg-cross-global-object-inline-new-array.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ff9d56d
    • msaboff@apple.com's avatar
      MarkupAccumulator should optimally handle 8 bit Strings · 20127fc7
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98224
      
      Reviewed by Ryosuke Niwa.
      
      Updated appendCharactersReplacingEntities to take a string, offset and length and process 8 or 16 bit
      data as appropriate.  Also made it a member function of MarkupAccumulator.
      
      No new tests, behavior covered by existing tests.
      
      * editing/MarkupAccumulator.cpp:
      (WebCore::MarkupAccumulator::appendCharactersReplacingEntities):
      (WebCore::MarkupAccumulator::appendAttributeValue):
      (WebCore::MarkupAccumulator::appendNodeValue):
      * editing/MarkupAccumulator.h:
      (MarkupAccumulator):
      * editing/markup.cpp:
      (WebCore::StyledMarkupAccumulator::appendText):
      (WebCore::urlToMarkup):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20127fc7
    • jsbell@chromium.org's avatar
      IndexedDB: Overflowing key generator should throw ConstraintError · 14afbbeb
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98807
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      After the WebKit implementation landed throwing DataError, public-webapps
      consensus was that the exception thrown should be ConstraintError. Trivial
      change, and we pass one more W3C test submission.
      
      Test: storage/indexeddb/key-generator.html
      
      * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
      (WebCore::IDBObjectStoreBackendImpl::putInternal):
      
      LayoutTests:
      
      Verify that overflowing key generator throws ConstraintError.
      
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/resources/key-generator.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14afbbeb
    • dpranke@chromium.org's avatar
      [chromium] Don't run perf/mouse-event on debug builds · 3c66506a
      dpranke@chromium.org authored
      Unreviewed, expectations change.
      
      We don't normally run any perf tests on a debug build, but this
      one was getting run due to an improperly scoped expectation
      overriding the wontfix rule.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c66506a
    • zandobersek@gmail.com's avatar
      XvfbDriver unit test is flaky on Linux builders · e51c88f2
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98346
      
      Reviewed by Adam Barth.
      
      Temporarily skip the XvfbDriver test case that tests
      the display number of the next free display. The test
      is flaky on Linux builders.
      
      * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
      (XvfbDriverTest.disabled_test_next_free_display):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e51c88f2
    • dgrogan@chromium.org's avatar
      IndexedDB: open-in-upgradeneeded layout test · ae98ca0c
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95912
      
      Reviewed by Tony Chang.
      
      * storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt: Added.
      * storage/indexeddb/intversion-open-in-upgradeneeded.html: Added.
      * storage/indexeddb/resources/intversion-open-in-upgradeneeded.js: Added.
      (test):
      (deleteSuccess):
      (upgradeNeeded1.transaction.oncomplete):
      (upgradeNeeded1):
      (openSuccess1):
      (onVersionChange):
      (onBlocked):
      (upgradeNeeded2):
      (openSuccess2):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae98ca0c
    • ojan@chromium.org's avatar
      Don't duplicated build numbers when merging flakiness dashboard JSON · ff4e7dc9
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98812
      
      Reviewed by Dirk Pranke.
      
      In general, build numbers are not unique, but we should basically never
      get the same build number uploaded twice in a row. This is a workaround
      for https://bugs.webkit.org/show_bug.cgi?id=97643, which frequently hits this
      because we update results_small.json and timeout updating results.json and then
      we retry the whole request.
      
      * TestResultServer/model/jsonresults.py:
      (JsonResults.merge):
      * TestResultServer/model/jsonresults_unittest.py:
      (JsonResultsTest.test_merge_duplicate_build_number):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff4e7dc9
    • mrobinson@webkit.org's avatar
      Fix the order of the statements in my previous build fix. · 7794192f
      mrobinson@webkit.org authored
      Reviewed by Gustavo Noronha Silva.
      
      My previous build build fix for ResourceHandleSoup ordered the assignment
      of the local ResourceHandleInternal incorrectly. Instead of being before
      both assertions, it should be interspersed among them.
      
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::createSoupMessageForHandleAndRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7794192f
    • commit-queue@webkit.org's avatar
      Need implement isWordTextBreak for QT, and WinCE for visual word movement functionality · 8b363a09
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=81136
      
      Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
      Reviewed by Caio Marcelo de Oliveira Filho.
      
      Uskipping tests that are passing after the merge https://gitorious.org/qtwebkit/testfonts/merge_requests/1
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b363a09
    • commit-queue@webkit.org's avatar
      RTL: selection.modify("move", "forward", "line") when cursor is at start of a... · 272a62ca
      commit-queue@webkit.org authored
      RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
      https://bugs.webkit.org/show_bug.cgi?id=51517
      
      Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2012-10-09
      Reviewed by Caio Marcelo de Oliveira Filho.
      
      Unskipping a test that is passing, with testfonts change in https://gitorious.org/qtwebkit/testfonts/merge_requests/1
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      272a62ca
    • abarth@webkit.org's avatar
      Note that this test is flaky. · d3df9d99
      abarth@webkit.org authored
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3df9d99