1. 18 May, 2009 1 commit
  2. 13 May, 2009 1 commit
  3. 07 May, 2009 1 commit
    • zimmermann@webkit.org's avatar
      Reviewed by Dave Hyatt. · b75da289
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=25617
      
      Fix memory/performance regression because of too much form control related abstraction just for WMLs sake.
      
      Remove FormControlElement and FormControlElementWithState base classes, as the overhead is too high for the
      gain. HTML has no benefit of that kind of abstraction, so we're going to move the functionality to Element directly.
      
      The functions now living in FormControlElement(WithState) lived in Node/Element/HTMLFormControlElement before.
      This patches moves all of them in a central place in Element.h, as virtual functions with an inline default implementation.
      To avoid confusion like isEnabled() living on Node, before the creation of the FormControlElement abstraction layer, all
      methods are renamed to clarify where they belong to. (Detailed list in ChangeLog)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b75da289
  4. 04 May, 2009 1 commit
    • darin@apple.com's avatar
      WebCore: · 9a925fa1
      darin@apple.com authored
      2009-05-04  Darin Adler  <darin@apple.com>
      
              Reviewed by Eric Seidel.
      
              Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
              and NamedMappedAttrMap.h include of MappedAttribute.h
              https://bugs.webkit.org/show_bug.cgi?id=24924
      
              Make compiles faster, and debugging info smaller.
      
              * GNUmakefile.am: Added new source files.
              * WebCore.pro: Ditto.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
      
              * bindings/js/JSHTMLCollectionCustom.cpp:
              (WebCore::toJS): Updated for new collection type names.
      
              * dom/Document.cpp:
              (WebCore::Document::createAttribute): Added. No longer inline.
              (WebCore::Document::images): Updated for new collection type names.
              (WebCore::Document::applets): Ditto.
              (WebCore::Document::embeds): Ditto.
              (WebCore::Document::plugins): Ditto.
              (WebCore::Document::objects): Ditto.
              (WebCore::Document::scripts): Ditto.
              (WebCore::Document::links): Ditto.
              (WebCore::Document::forms): Ditto.
              (WebCore::Document::anchors): Ditto.
              (WebCore::Document::all): Ditto.
              (WebCore::Document::windowNamedItems): Ditto.
              (WebCore::Document::documentNamedItems): Ditto.
              (WebCore::Document::nameCollectionInfo): Ditto.
      
              * dom/Document.h: Changed around includes and forward declarations.
              Updated for changes to collection types.
      
              * dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
      
              * html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp.
              Contains the class that used to be HTMLCollection::CollectionInfo.
              * html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h.
              Ditto.
      
              * html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h.
              Has the enum that used to be HTMLCollection::Type.
      
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::HTMLCollection): Update for collection type change.
              (WebCore::HTMLCollection::create): Ditto.
              (WebCore::HTMLCollection::resetCollectionInfo): Ditto.
              (WebCore::HTMLCollection::itemAfter): Ditto.
              * html/HTMLCollection.h: Ditto.
      
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::children): Updated for new collection type names.
              * html/HTMLFormCollection.cpp:
              (WebCore::HTMLFormCollection::formCollectionInfo): Ditto.
              (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
              * html/HTMLFormCollection.h: Ditto.
              * html/HTMLFormElement.h: Ditto.
              * html/HTMLMapElement.cpp:
              (WebCore::HTMLMapElement::areas): Ditto.
              * html/HTMLNameCollection.cpp:
              (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
              * html/HTMLNameCollection.h:
              (WebCore::HTMLNameCollection::create): Ditto.
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::collectionInfo): Ditto.
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::tBodies):Ditto.
              * html/HTMLTableRowElement.cpp:
              (WebCore::HTMLTableRowElement::cells):Ditto.
              * html/HTMLTableRowsCollection.cpp:
              (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::rows): Ditto.
      
              * bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
              * bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
              * css/CSSStyleSelector.cpp: Ditto.
              * dom/Element.cpp: Ditto.
              * dom/InputElement.cpp: Ditto.
              * dom/NamedAttrMap.cpp: Ditto.
              * dom/NamedMappedAttrMap.cpp: Ditto.
              * dom/Node.cpp: Ditto.
              * dom/StyledElement.cpp: Ditto.
              * dom/StyledElement.h: Ditto.
              * editing/ApplyStyleCommand.cpp: Ditto.
              * editing/DeleteSelectionCommand.cpp: Ditto.
              * editing/Editor.cpp: Ditto.
              * editing/EditorCommand.cpp: Ditto.
              * editing/InsertParagraphSeparatorCommand.cpp: Ditto.
              * editing/ReplaceSelectionCommand.cpp: Ditto.
              * editing/markup.cpp: Ditto.
              * html/CanvasRenderingContext2D.cpp: Ditto.
              * html/HTMLAnchorElement.cpp: Ditto.
              * html/HTMLAppletElement.cpp: Ditto.
              * html/HTMLAreaElement.cpp: Ditto.
              * html/HTMLBRElement.cpp: Ditto.
              * html/HTMLBaseElement.cpp: Ditto.
              * html/HTMLBodyElement.cpp: Ditto.
              * html/HTMLButtonElement.cpp: Ditto.
              * html/HTMLCanvasElement.cpp: Ditto.
              * html/HTMLDivElement.cpp: Ditto.
              * html/HTMLEmbedElement.cpp: Ditto.
              * html/HTMLFontElement.cpp: Ditto.
              * html/HTMLFormControlElement.cpp: Ditto.
              * html/HTMLFormElement.cpp: Ditto.
              * html/HTMLFrameElement.cpp: Ditto.
              * html/HTMLFrameElementBase.cpp: Ditto.
              * html/HTMLFrameSetElement.cpp: Ditto.
              * html/HTMLHRElement.cpp: Ditto.
              * html/HTMLIFrameElement.cpp: Ditto.
              * html/HTMLImageElement.cpp: Ditto.
              * html/HTMLInputElement.cpp: Ditto.
              * html/HTMLIsIndexElement.cpp: Ditto.
              * html/HTMLKeygenElement.cpp: Ditto.
              * html/HTMLLIElement.cpp: Ditto.
              * html/HTMLLinkElement.cpp: Ditto.
              * html/HTMLMarqueeElement.cpp: Ditto.
              * html/HTMLMetaElement.cpp: Ditto.
              * html/HTMLOListElement.cpp: Ditto.
              * html/HTMLObjectElement.cpp: Ditto.
              * html/HTMLOptionElement.cpp: Ditto.
              * html/HTMLParagraphElement.cpp: Ditto.
              * html/HTMLParamElement.cpp: Ditto.
              * html/HTMLPlugInElement.cpp: Ditto.
              * html/HTMLPreElement.cpp: Ditto.
              * html/HTMLScriptElement.cpp: Ditto.
              * html/HTMLSelectElement.cpp: Ditto.
              * html/HTMLStyleElement.cpp: Ditto.
              * html/HTMLTableCaptionElement.cpp: Ditto.
              * html/HTMLTableCellElement.cpp: Ditto.
              * html/HTMLTableColElement.cpp: Ditto.
              * html/HTMLTablePartElement.cpp: Ditto.
              * html/HTMLTextAreaElement.cpp: Ditto.
              * html/HTMLTokenizer.cpp: Ditto.
              * html/HTMLUListElement.cpp: Ditto.
              * html/HTMLVideoElement.cpp: Ditto.
              * html/HTMLViewSourceDocument.cpp: Ditto.
              * loader/ImageDocument.cpp: Ditto.
              * page/Frame.cpp: Ditto.
              * rendering/RenderTreeAsText.cpp: Ditto.
              * svg/SVGAElement.cpp: Ditto.
              * svg/SVGAnimateMotionElement.cpp: Ditto.
              * svg/SVGAnimateTransformElement.cpp: Ditto.
              * svg/SVGAnimationElement.cpp: Ditto.
              * svg/SVGCircleElement.cpp: Ditto.
              * svg/SVGClipPathElement.cpp: Ditto.
              * svg/SVGCursorElement.cpp: Ditto.
              * svg/SVGElement.cpp: Ditto.
              * svg/SVGEllipseElement.cpp: Ditto.
              * svg/SVGExternalResourcesRequired.cpp: Ditto.
              * svg/SVGFitToViewBox.cpp: Ditto.
              * svg/SVGFontFaceElement.cpp: Ditto.
              * svg/SVGFontFaceUriElement.cpp: Ditto.
              * svg/SVGForeignObjectElement.cpp: Ditto.
              * svg/SVGGlyphElement.cpp: Ditto.
              * svg/SVGGradientElement.cpp: Ditto.
              * svg/SVGImageElement.cpp: Ditto.
              * svg/SVGLangSpace.cpp: Ditto.
              * svg/SVGLineElement.cpp: Ditto.
              * svg/SVGLinearGradientElement.cpp: Ditto.
              * svg/SVGMarkerElement.cpp: Ditto.
              * svg/SVGMaskElement.cpp: Ditto.
              * svg/SVGPathElement.cpp: Ditto.
              * svg/SVGPatternElement.cpp: Ditto.
              * svg/SVGPolyElement.cpp: Ditto.
              * svg/SVGRadialGradientElement.cpp: Ditto.
              * svg/SVGRectElement.cpp: Ditto.
              * svg/SVGSVGElement.cpp: Ditto.
              * svg/SVGScriptElement.cpp: Ditto.
              * svg/SVGStopElement.cpp: Ditto.
              * svg/SVGStyleElement.cpp: Ditto.
              * svg/SVGStyledElement.cpp: Ditto.
              * svg/SVGStyledTransformableElement.cpp: Ditto.
              * svg/SVGTests.cpp: Ditto.
              * svg/SVGTextContentElement.cpp: Ditto.
              * svg/SVGTextElement.cpp: Ditto.
              * svg/SVGTextPathElement.cpp: Ditto.
              * svg/SVGTextPositioningElement.cpp: Ditto.
              * svg/SVGURIReference.cpp: Ditto.
              * svg/SVGUseElement.cpp: Ditto.
              * svg/SVGViewElement.cpp: Ditto.
              * svg/animation/SVGSMILElement.cpp: Ditto.
              * xml/XPathStep.cpp: Ditto.
      
      WebKit/mac:
      
      2009-05-04  Darin Adler  <darin@apple.com>
      
              Reviewed by Eric Seidel.
      
              Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
              and NamedMappedAttrMap.h include of MappedAttribute.h
              https://bugs.webkit.org/show_bug.cgi?id=24924
      
              * WebView/WebFrame.mm: Added include of CSSMutableStyleDeclaration.h
              and ScriptValue.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a925fa1
  5. 29 Apr, 2009 1 commit
    • eric@webkit.org's avatar
      2009-04-29 Pavel Feldman <pfeldman@chromium.org> · 8142c31c
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Extract PageGroupLoadDeferrer from Chrome.cpp
      
              * GNUmakefile.am: added PageGroupLoadDeferrer
              * WebCore.pro: ditto
              * WebCore.scons: ditto
              * WebCore.vcproj/WebCore.vcproj: ditto
              * WebCore.xcodeproj/project.pbxproj: ditto
              * WebCoreSources.bkl: ditto
              * page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
              * page/PageGroupLoadDeferrer.cpp: Added.
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
              * page/PageGroupLoadDeferrer.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8142c31c
  6. 24 Apr, 2009 2 commits
    • kevino@webkit.org's avatar
      wx build fix. Adding ScriptEventListener.cpp. · 58caacb1
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58caacb1
    • hyatt@apple.com's avatar
      2009-04-24 David Hyatt <hyatt@apple.com> · 09e05653
      hyatt@apple.com authored
              Reviewed by Simon Fraser, Dan Bernstein.
      
              Speed up the PLT by devirtualizing the height() function on InlineBox.  virtualizing it in order to make the height() computation dynamic caused
              a ~0.5% slowdown.  This patch does the following to get the speed back:
              
              (a) Devirtualizes isText and forces inline box creators to set the bit as needed.  This actually resulted in simplified code, since ListMarkerBox could
              then be removed.
              (b) Reduces the height() call count.  In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
              member variable access.  The call sites have been patched to cut down on extra height() calls now that it is more expensive.
              (c) Devirtualize height() except on SVG boxes.  For all non-SVG, the height() function on InlineBox handles the computation.  For SVG boxes, a new bit has
              been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::height):
              * rendering/InlineBox.h:
              (WebCore::InlineBox::InlineBox):
              (WebCore::InlineBox::isSVG):
              (WebCore::InlineBox::setIsSVG):
              (WebCore::InlineBox::isText):
              (WebCore::InlineBox::setIsText):
              (WebCore::InlineBox::svgBoxHeight):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesVertically):
              (WebCore::InlineFlowBox::paintBoxDecorations):
              (WebCore::InlineFlowBox::paintMask):
              * rendering/InlineFlowBox.h:
              * rendering/InlineTextBox.cpp:
              * rendering/InlineTextBox.h:
              * rendering/ListMarkerBox.cpp: Removed.
              * rendering/ListMarkerBox.h: Removed.
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::createInlineBox):
              * rendering/RenderSVGInline.cpp:
              (WebCore::RenderSVGInline::createFlowBox):
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::createTextBox):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::createRootBox):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::createInlineTextBox):
              * rendering/RootInlineBox.cpp:
              * rendering/RootInlineBox.h:
              * rendering/SVGInlineFlowBox.h:
              (WebCore::SVGInlineFlowBox::svgBoxHeight):
              * rendering/SVGInlineTextBox.h:
              (WebCore::SVGInlineTextBox::svgBoxHeight):
              * rendering/SVGRootInlineBox.h:
              (WebCore::SVGRootInlineBox::svgBoxHeight):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09e05653
  7. 23 Apr, 2009 1 commit
  8. 13 Apr, 2009 1 commit
    • bolsinga@apple.com's avatar
      2009-04-13 Greg Bolsinga <bolsinga@apple.com> · ded19195
      bolsinga@apple.com authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=24770
              
              Add custom code for Coordinates that returns null when required by the
              Geolocation spec.
              
              http://dev.w3.org/geo/api/spec-source.html#coordinates
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSCoordinatesCustom.cpp: Added.
              (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided.
              (WebCore::JSCoordinates::altitudeAccuracy): Ditto
              (WebCore::JSCoordinates::heading): Ditto
              (WebCore::JSCoordinates::speed): Ditto
              * page/Coordinates.h:
              (WebCore::Coordinates::create): Add 'canProvide' parameters and values
              (WebCore::Coordinates::canProvideAltitude):
              (WebCore::Coordinates::canProvideAltitudeAccuracy):
              (WebCore::Coordinates::canProvideHeading):
              (WebCore::Coordinates::canProvideSpeed):
              (WebCore::Coordinates::Coordinates):
              * page/Coordinates.idl: specify custom getters
              * platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided.
              (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ded19195
  9. 07 Apr, 2009 1 commit
    • dglazkov@chromium.org's avatar
      2009-04-07 Dimitri Glazkov <dglazkov@chromium.org> · 421f4aeb
      dglazkov@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=25063
              Refactor InspectorController to use ScriptObject/State.
      
              * GNUmakefile.am: Added ScriptState.cpp.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * bindings/js/JSInspectorControllerCustom.cpp:
              (WebCore::JSInspectorController::addSourceToFrame): Fixed argument index typo.
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call): Added reportExceptions parameter.
              (WebCore::ScriptFunctionCall::construct): Ditto.
              * bindings/js/ScriptFunctionCall.h: Ditto.
              * bindings/js/ScriptObject.cpp:
              (WebCore::handleException): Added exception-reporting heloper.
              (WebCore::ScriptObject::set): Changed to use handleException.
              (WebCore::ScriptGlobalObject::set): Ditto,
              * bindings/js/ScriptObject.cpp: Added ScriptGlobalObject.
              (WebCore::ScriptGlobalObject::set): Added.
              (WebCore::ScriptGlobalObject::getObject): Added.
              * bindings/js/ScriptObject.h: Added ScriptGlobalObject decls.
              (WebCore::ScriptGlobalObject::ScriptGlobalObject): Added.
              * bindings/js/ScriptState.cpp: Added.
              * bindings/js/ScriptState.h: Added scriptStateFromPage decl.
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::addToConsole): Changed to not report exceptions
                  to avoid re-entrancy.
              * inspector/InspectorController.cpp: Refactored to use ScriptState/Object.
              * inspector/InspectorController.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42295 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      421f4aeb
  10. 29 Mar, 2009 1 commit
    • darin@apple.com's avatar
      WebCore: · 930f4381
      darin@apple.com authored
      2009-03-29  Darin Adler  <darin@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              Bug 24921: remove include of HTMLFormElement.h from Document.h
              https://bugs.webkit.org/show_bug.cgi?id=24921
      
              * GNUmakefile.am: Added CheckedRadioButtons source files.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
      
              * bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
      
              * dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp.
              Removed all the code except for CheckedRadioButtons, and moved that out to be
              a namespace-level class instead of a member of HTMLFormElement.
      
              * dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h.
              Removed all the code except for CheckedRadioButtons, and moved that out to be
              a namespace-level class instead of a member of HTMLFormElement.
      
              * dom/Document.h: Removed unneeded includes, including HTMLFormElement.h.
              Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons
              class to use a namespace-level class instead of a member of HTMLFormElement.
      
              * dom/Node.idl: Changed the type of parentElement from Node to Element for
              two reasons. 1) Node was incorrect, since parentElement returns an Element.
              2) The bindings won't compile any more unless they know parentElement's
              return value is an Element due to include changes.
      
              * html/HTMLFormElement.cpp: Moved definitions of the functions in the
              CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
      
              * html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons
              class to the new CheckedRadioButtons.h.
      
              * html/HTMLInputElement.cpp:
              (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons
              class to use a namespace-level class instead of a member of HTMLFormElement.
      
              * page/Chrome.cpp:
              (WebCore::Chrome::createWindow): Tweaked formatting.
      
              * css/CSSGrammar.y: Added newly-needed include.
              * dom/Range.cpp: Ditto.
              * editing/BreakBlockquoteCommand.cpp: Ditto.
              * editing/CompositeEditCommand.cpp: Ditto.
              * editing/InsertLineBreakCommand.cpp: Ditto.
              * editing/ModifySelectionListLevel.cpp: Ditto.
              * editing/RemoveFormatCommand.cpp: Ditto.
              * editing/TextIterator.cpp: Ditto.
              * editing/VisiblePosition.cpp: Ditto.
              * loader/DocLoader.cpp: Ditto.
              * page/AccessibilityRenderObject.cpp: Ditto.
              * page/Page.cpp: Ditto.
              * rendering/RenderBlock.cpp: Ditto.
              * rendering/RenderLayer.cpp: Ditto.
              * rendering/RenderObject.h: Ditto.
              * storage/LocalStorageArea.cpp: Ditto.
              * storage/SessionStorageArea.cpp: Ditto.
      
      WebKit/mac:
      
      2009-03-29  Darin Adler  <darin@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              * Plugins/WebNullPluginView.mm: Added now-needed includes.
              * WebView/WebHTMLRepresentation.mm: Ditto.
              * WebView/WebHTMLView.mm: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      930f4381
  11. 26 Mar, 2009 2 commits
    • eric@webkit.org's avatar
      2009-03-26 Jungshik Shin <jshin@chromium.org> · b59b8a57
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Add an encoding detector 'hook' to TextResourceDecoder.
               - add |usesEncodingDetector| to Settings. It's off by default.
               - add a new encoding source type |EncodingFromParent|
                 to distinguish cases when the encoding is inherited from
                 the parent frame from cases when it's actually auto-detected.
               - add TextEncodingDetector* to platform/text. Currently,
                 the only implementation uses ICU. Stub is added for
                 ports that do not use ICU and a build on Tiger. Mac OS
                 Tiger comes with ICU 3.2 that does not support encoding detector.
               - add ucsdet.h to icu/unicode for ports using ICU.
      
              Layout tests will be added once bug 20534 is fixed and a WebPreference
              can be controlled in test_shell. With UsesEncodingDetector off, there
              is no change to test.
      
              http://bugs.webkit.org/show_bug.cgi?id=16482
      
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCore/GNUmakefile.am
              * WebCore/WebCore.pro
              * WebCore/WebCore.scons
              * WebCore/WebCoreSources.bkl
              * WebCore.base.exp
              * icu/unicode/ucsdet.h
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::write): turn on/off encoding detector depending on Settings and set hintEncoding of TextResourceDecoder to the parent frame encoding if necessary and the security policy allows refering to the parent frame encoding.
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::TextResourceDecoder):
              (WebCore::TextResourceDecoder::checkForCSSCharset): add check for EncodingFromParentFrame
              (WebCore::TextResourceDecoder::checkForHeadCharset): ditto
              (WebCore::TextResourceDecoder::shouldAutoDetect):
              (WebCore::TextResourceDecoder::decode): call encoding detector if shouldAutoDetect returns true.
              (WebCore::TextResourceDecoder::flush): if encoding is not determined by now, call encoding detector if shouldAutoDetect returns true.
              * loader/TextResourceDecoder.h:
              (WebCore::TextResourceDecoder::):
              (WebCore::TextResourceDecoder::create):
              (WebCore::TextResourceDecoder::setHintEncoding):
              (WebCore::TextResourceDecoder::source):
              * page/Settings.cpp: add m_usesEncodingDetector
              (WebCore::Settings::Settings):
              (WebCore::Settings::setUsesEncodingDetector):
              * page/Settings.h:
              (WebCore::Settings::usesEncodingDetector):
              * platform/text/TextEncodingDetector.h: Added.
              * platform/text/TextEncodingDetectorICU.cpp: Added.
              (WebCore::detectTextEncoding):
              * platform/text/TextEncodingDetectorNone.cpp: Added.
              (WebCore::detectTextEncoding):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b59b8a57
    • darin@apple.com's avatar
      2009-03-26 Darin Adler <darin@apple.com> · be23b272
      darin@apple.com authored
              Reviewed by Geoff Garen.
      
              Split JSLazyEventListener out into its own separate source file.
              We'll be removing JSAbstractEventListener and JSProtectedEventListener soon,
              so leave those in the same file with JSEventListener.
      
              * GNUmakefile.am: Added JSLazyEventListener.
              * WebCore.pro: Ditto.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
      
              * bindings/js/JSEventListener.cpp: Removed the JSLazyEventListener part.
              Removed unneeded includes. Removed incorrect ASSERT_CLASS_FITS_IN_CELL, since
              JSAbstractEventListener is not derived from JSCell.
      
              * bindings/js/JSEventListener.h: Removed the JSLazyEventListener part
              and the now-unneeded include of PlatformString.h.
      
              * bindings/js/JSLazyEventListener.cpp: Copied from bindings/js/JSEventListener.cpp.
              Kept only the JSLazyEventListener part.
              (WebCore::eventParameterName): Made this have internal linkage by adding "static".
              Also moved the default case out of the switch statement so we will get a warning
              if we omit any cases in the future.
      
              * bindings/js/JSLazyEventListener.h: Copied from bindings/js/JSEventListener.h.
              Kept only the JSLazyEventListener part.
      
              * bindings/js/ScriptController.cpp: Removed unneeded includes and sorted the
              remanining ones. Include JSLazyEventListener.h instead of JSEventListener.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be23b272
  12. 13 Mar, 2009 1 commit
    • dglazkov@chromium.org's avatar
      2009-03-13 Dimitri Glazkov <dglazkov@chromium.org> · e144f898
      dglazkov@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24524
              Introduce ScriptObject and ScriptFunctionCall abstractions.
      
              * GNUmakefile.am: Added ScriptObject and ScriptFunctionCall to project.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * bindings/js/ScriptFunctionCall.cpp: Added.
              * bindings/js/ScriptFunctionCall.h: Added.
              * bindings/js/ScriptObject.cpp: Added.
              * bindings/js/ScriptObject.h: Added.
              * bindings/js/ScriptObjectQuarantine.cpp: Added.
              * bindings/js/ScriptObjectQuarantine.h: Added.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::populateScriptObjects): Changed to use InspectorDatabaseResource::bind.
              (WebCore::InspectorController::resetScriptObjects): Changed to use InspectorDatabaseResource::unbind.
              (WebCore::InspectorController::didOpenDatabase): Changed to use InspectorDatabaseResource::unbind.
              * inspector/InspectorController.h: Removed addScriptDatabaseResource and
              removeScriptDatabaseResource declarations.
              * inspector/InspectorDatabaseResource.cpp:
              (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
              (WebCore::InspectorDatabaseResource::bind): Added.
              (WebCore::InspectorDatabaseResource::unbind): Added.
              * inspector/InspectorDatabaseResource.h: Added bind and unbind declarations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e144f898
  13. 12 Mar, 2009 1 commit
    • bolsinga@apple.com's avatar
      2009-03-12 Greg Bolsinga <bolsinga@apple.com> · d35658cd
      bolsinga@apple.com authored
              Reviewed by Antti Koivisto.
      
              https://bugs.webkit.org/show_bug.cgi?id=24506
              Geolocation in Safari differs from the spec, no Coordinates attribute on Position
              
              Get up to date.
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSGeolocationCustom.cpp:
              (WebCore::createPositionOptions):
              * page/Coordinates.cpp: Added.
              (WebCore::Coordinates::toString):
              * page/Coordinates.h: Added.
              (WebCore::Coordinates::create):
              (WebCore::Coordinates::latitude):
              (WebCore::Coordinates::longitude):
              (WebCore::Coordinates::altitude):
              (WebCore::Coordinates::accuracy):
              (WebCore::Coordinates::altitudeAccuracy):
              (WebCore::Coordinates::heading):
              (WebCore::Coordinates::speed):
              (WebCore::Coordinates::Coordinates):
              * page/Coordinates.idl: Added.
              * page/Geoposition.cpp:
              (WebCore::Geoposition::toString):
              * page/Geoposition.h:
              (WebCore::Geoposition::create):
              (WebCore::Geoposition::coords):
              (WebCore::Geoposition::Geoposition):
              * page/Geoposition.idl:
              * page/PositionOptions.h:
              (WebCore::PositionOptions::create):
              (WebCore::PositionOptions::maximumAge):
              (WebCore::PositionOptions::setMaximumAge):
              (WebCore::PositionOptions::PositionOptions):
              * platform/mac/GeolocationServiceMac.mm:
              (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d35658cd
  14. 10 Mar, 2009 2 commits
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · cf824184
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=24285
              Text resource loading checks for BOM twice
      
              This removes TextDecoder class, since its only purpose was to check for BOM, which is
              already done in TextResourceDecoder. Callers that use TextEncoding::decode() won't get
              BOM checked, but I didn't find any cases where it would significantly change behavior.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              Remove TextDecoder.{h,cpp}.
      
              * platform/text/TextDecoder.cpp: Removed.
              * platform/text/TextDecoder.h: Removed.
      
              * loader/TextResourceDecoder.h: Instead of a TextDecoder object, keep TextEncoding and
              TextCodec separately.
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::TextResourceDecoder): Updated for m_encoding being a member.
              (WebCore::TextResourceDecoder::setEncoding): Ditto.
              (WebCore::TextResourceDecoder::checkForBOM): Removed a FIXME saying that a BOM could override
              even a user-chosen encoding - this is how it already worked due to TextDecoder checking for
              BOM again. Made this function return the detected BOM length.
              (WebCore::TextResourceDecoder::decode): Skip the BOM if it was found at the beginning of
              a text resource.
              (WebCore::TextResourceDecoder::flush): Reset m_checkedForBOM, so that re-decoding the same
              resource again (as frequently done by CachedResource subclasses) will skip the BOM correctly.
      
              * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::decode):
              Use TextCodec directly without a TextDecoder wrapper. This means that this method no longer
              checks for BOM, which was a counter-intuitive feature.
      
              * loader/CachedScript.cpp:
              (WebCore::CachedScript::CachedScript):
              (WebCore::CachedScript::setEncoding):
              (WebCore::CachedScript::encoding):
              (WebCore::CachedScript::script):
              * loader/CachedScript.h:
              * loader/appcache/ManifestParser.cpp:
              (WebCore::parseManifest):
              Use TextResourceDecoder, as TextEncoding::decode() no longer checks for BOM.
              A side effect of this is that these resources will now be subject to encoding auto-detection.
      
              * loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
              * page/Page.cpp: (WebCore::Page::userStyleSheet):
              Be sure to flush TextResourceDecoder, pushing any remaining bytes out, and making the decoder
              re-usable (for repeated decoding of the same resource).
      
              * platform/text/TextEncodingRegistry.h: Updated comments for newTextCodec().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf824184
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 213b4b02
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=24462
              Move cross-origin access control code out of XMLHttpRequest
      
              Step 1: move preflight result cache and access control helper functions.
      
              No change in behavior, so no test.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * loader/CrossOriginAccessControl.cpp: Added.
              (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
              (WebCore::isSimpleCrossOriginAccessRequest):
              (WebCore::createAllowedCrossOriginResponseHeadersSet):
              (WebCore::isOnAccessControlResponseHeaderWhitelist):
              (WebCore::passesAccessControlCheck):
              * loader/CrossOriginAccessControl.h: Added.
              * loader/CrossOriginPreflightResultCache.cpp: Added.
              (WebCore::parseAccessControlMaxAge):
              (WebCore::addToAccessControlAllowList):
              (WebCore::parseAccessControlAllowList):
              (WebCore::CrossOriginPreflightResultCacheItem::parse):
              (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod):
              (WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
              (WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
              (WebCore::CrossOriginPreflightResultCache::shared):
              (WebCore::CrossOriginPreflightResultCache::appendEntry):
              (WebCore::CrossOriginPreflightResultCache::canSkipPreflight):
              * loader/CrossOriginPreflightResultCache.h: Added.
              (WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):
              (WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
              (WebCore::XMLHttpRequest::createRequest):
              (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest):
              (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest):
              (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight):
              (WebCore::XMLHttpRequest::didReceiveResponse):
              (WebCore::XMLHttpRequest::didReceiveResponsePreflight):
              * xml/XMLHttpRequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      213b4b02
  15. 08 Mar, 2009 1 commit
    • mrowe@apple.com's avatar
      Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that · 1179cd66
      mrowe@apple.com authored
      Frame.h no longer needs to include it.  This cuts the size of the symbols
      for a debug build by around 3%.
      
      Reviewed by Oliver Hunt.
      
      * dom/Element.cpp:
      (WebCore::Element::scrollIntoView):
      (WebCore::Element::scrollIntoViewIfNeeded):
      * editing/Editor.cpp:
      (WebCore::Editor::insertTextWithoutSendingTextEvent):
      (WebCore::Editor::revealSelectionAfterEditingOperation):
      * editing/SelectionController.cpp:
      (WebCore::SelectionController::setSelection):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::gotoAnchor):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      * page/Frame.cpp:
      (WebCore::Frame::revealSelection):
      (WebCore::Frame::revealCaret):
      * page/Frame.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::getRectToExpose):
      (WebCore::RenderLayer::autoscroll):
      * rendering/RenderLayer.h:
      * rendering/ScrollBehavior.cpp: Added.
      (WebCore::):
      * rendering/ScrollBehavior.h: Added.
      (WebCore::):
      (WebCore::ScrollAlignment::getVisibleBehavior):
      (WebCore::ScrollAlignment::getPartialBehavior):
      (WebCore::ScrollAlignment::getHiddenBehavior):
      
      Add the new files to the build systems:
      * GNUmakefile.am:
      * WebCore.base.exp:
      * WebCore.pro:
      * WebCore.scons:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * WebCoreSources.bkl:
      
      Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
      * dom/Clipboard.cpp:
      * editing/EditorCommand.cpp:
      * editing/InsertLineBreakCommand.cpp:
      * editing/TypingCommand.cpp:
      * html/HTMLFormControlElement.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/icon/IconLoader.cpp:
      * page/animation/AnimationController.cpp:
      * rendering/RenderSlider.cpp:
      * rendering/RenderTextControl.cpp:
      
      WebKit/mac:
      * Plugins/WebNetscapePluginView.mm:
      * WebView/WebFrame.mm:
      (-[WebFrame _scrollDOMRangeToVisible:]):
      (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
      (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView jumpToSelection:]):
      (-[WebHTMLView centerSelectionInVisibleArea:]):
      
      WebKit/win:
      * WebView.cpp:
      (WebView::centerSelectionInVisibleArea):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1179cd66
  16. 05 Mar, 2009 2 commits
    • dglazkov@chromium.org's avatar
      2009-03-05 Dimitri Glazkov <dglazkov@chromium.org> · 5ccc4d77
      dglazkov@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24355
              Add InspectorController.idl and convert InspectorController.cpp to use
              JSC bindings.
      
              * DerivedSources.make: Added InspectorController.idl
              * WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
              * bindings/js/JSInspectorControllerCustom.cpp: Added.
              * bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
              * inspector/InspectorController.cpp: Removed hand-rolled bindings.
              * inspector/InspectorController.h: Added platform and addSourceToFrame methods.
              * inspector/InspectorController.idl: Added.
              * page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ccc4d77
    • dglazkov@chromium.org's avatar
      2009-03-05 Dimitri Glazkov <dglazkov@chromium.org> · e875a8e3
      dglazkov@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24376
              Split InspectorController.cpp file into separate classes.
      
              * GNUmakefile.am: Modified to include new files.
              * WebCore.pro: Ditto.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * inspector/ConsoleMessage.cpp: Added.
              * inspector/ConsoleMessage.h: Added.
              * inspector/InspectorController.cpp:
              * inspector/InspectorDOMStorageResource.cpp: Added.
              * inspector/InspectorDOMStorageResource.h: Added.
              * inspector/InspectorDatabaseResource.cpp: Added.
              * inspector/InspectorDatabaseResource.h: Added.
              * inspector/InspectorResource.cpp: Added.
              * inspector/InspectorResource.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e875a8e3
  17. 26 Feb, 2009 1 commit
  18. 25 Feb, 2009 1 commit
  19. 24 Feb, 2009 2 commits
  20. 20 Feb, 2009 1 commit
    • dglazkov@chromium.org's avatar
      2009-02-18 Dimitri Glazkov <dglazkov@chromium.org> · 5ffebd4e
      dglazkov@chromium.org authored
              Reviewed by Antti Koivisto.
      
              https://bugs.webkit.org/show_bug.cgi?id=23999
              Split off MIME type parsing into its own class.
      
              * GNUmakefile.am: Added ContentType sources.
              * WebCore.pro: Ditto.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * html/HTMLMediaElement.cpp: Changed to use ContentType.
              (WebCore::HTMLMediaElement::selectMediaURL):
              * platform/ContentType.cpp: Added.
              (WebCore::ContentType::ContentType):
              (WebCore::ContentType::parameter):
              (WebCore::ContentType::type):
              * platform/ContentType.h: Added.
              (WebCore::ContentType::raw):
              * platform/MIMETypeRegistry.cpp:
              * platform/MIMETypeRegistry.h:
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::load):
              * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
              * rendering/style/RenderStyleConstants.h: Ditto.
              (WebCore::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffebd4e
  21. 17 Feb, 2009 1 commit
    • hyatt@apple.com's avatar
      WebCore: · 7bead9ef
      hyatt@apple.com authored
      2009-02-17  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Eric Seidel
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=23985
      
              Don't allow legends to be anything but display:block.
      
              Added fast/forms/inline-ignored-on-legend.html
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * css/html4.css:
              * html/HTMLLegendElement.cpp:
              * html/HTMLLegendElement.h:
              * rendering/RenderLegend.cpp: Removed.
              * rendering/RenderLegend.h: Removed.
              * wml/WMLInsertedLegendElement.cpp:
              * wml/WMLInsertedLegendElement.h:
      
      LayoutTests:
      
      2009-02-17  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Eric Seidel
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=23985
      
              Don't allow legends to be anything but display:block.
      
              * fast/forms/inline-ignored-on-legend.html: Added.
              * platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
              * platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
              * platform/mac/fast/forms/006-expected.txt:
              * platform/mac/fast/forms/007-expected.txt:
              * platform/mac/fast/forms/fieldset-align-expected.txt:
              * platform/mac/fast/forms/float-before-fieldset-expected.txt:
              * platform/mac/fast/forms/inline-ignored-on-legend-expected.checksum: Added.
              * platform/mac/fast/forms/inline-ignored-on-legend-expected.png: Added.
              * platform/mac/fast/forms/inline-ignored-on-legend-expected.txt: Added.
              * platform/mac/fast/invalid/residual-style-expected.txt:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bead9ef
  22. 12 Feb, 2009 1 commit
  23. 11 Feb, 2009 1 commit
  24. 10 Feb, 2009 2 commits
    • kevino@webkit.org's avatar
      8c630eff
    • weinig@apple.com's avatar
      WebCore: · 39103093
      weinig@apple.com authored
      2009-02-10  Sam Weinig  <sam@webkit.org>
      
              Reviewed by David Hyatt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=15897
              Please implement getBoundingClientRect and getClientRects
              <rdar://problem/6139669>
      
              Cursory implementation of Element.getBoundingClientRect and
              Element.getClientRects. Adds necessary infrastructure classes
              ClientRect and ClientRectList.
      
              Tests: fast/dom/getBoundingClientRect.html
                     fast/dom/getClientRects.html
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * dom/ClientRect.cpp: Added.
              (WebCore::ClientRect::ClientRect):
              * dom/ClientRect.h: Added.
              (WebCore::ClientRect::create):
              (WebCore::ClientRect::top):
              (WebCore::ClientRect::right):
              (WebCore::ClientRect::bottom):
              (WebCore::ClientRect::left):
              (WebCore::ClientRect::width):
              (WebCore::ClientRect::height):
              * dom/ClientRect.idl: Added.
              * dom/ClientRectList.cpp: Added.
              (WebCore::ClientRectList::ClientRectList):
              (WebCore::ClientRectList::~ClientRectList):
              (WebCore::ClientRectList::length):
              (WebCore::ClientRectList::item):
              * dom/ClientRectList.h: Added.
              (WebCore::ClientRectList::create):
              * dom/ClientRectList.idl: Added.
              * dom/Element.cpp:
              (WebCore::Element::getClientRects):
              (WebCore::Element::getBoundingClientRect):
              * dom/Element.h:
              * dom/Element.idl:
              * page/DOMWindow.idl:
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::absoluteRects):
              (WebCore::RenderInline::absoluteQuads):
      
      LayoutTests:
      
      2009-02-08  Sam Weinig  <sam@webkit.org>
      
              Reviewed by David Hyatt.
      
              Tests for https://bugs.webkit.org/show_bug.cgi?id=15897
              Please implement getBoundingClientRect and getClientRects
              <rdar://problem/6139669>
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/domListEnumeration-expected.txt:
              * fast/dom/getBoundingClientRect-expected.txt: Added.
              * fast/dom/getBoundingClientRect.html: Added.
              * fast/dom/getClientRects-expected.txt: Added.
              * fast/dom/getClientRects.html: Added.
              * fast/dom/resources/domListEnumeration.js:
              * fast/js/global-constructors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39103093
  25. 09 Feb, 2009 1 commit
  26. 05 Feb, 2009 2 commits
    • weinig@apple.com's avatar
      2009-02-05 Sam Weinig <sam@webkit.org> · b9d2ac2f
      weinig@apple.com authored
              Reviewed by Darin Adler.
      
              Finish merging EventTargetNode up into Node.
      
              This also fixes a small recently introduced issue where EventListeners
              would not be removed from the document if they were attached to comment
              nodes outside of the documentElement.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSEventTargetNodeCustom.cpp: Removed.
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::addEventListener):
              (WebCore::JSNode::removeEventListener):
              (WebCore::JSNode::pushEventHandlerScope):
              * bindings/scripts/CodeGenerator.pm:
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::CharacterData):
              (WebCore::CharacterData::rendererIsNeeded):
              * dom/CharacterData.h:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::willRemove):
              (WebCore::ContainerNode::attach):
              (WebCore::ContainerNode::detach):
              (WebCore::ContainerNode::insertedIntoDocument):
              (WebCore::ContainerNode::removedFromDocument):
              (WebCore::ContainerNode::setFocus):
              (WebCore::ContainerNode::setActive):
              (WebCore::ContainerNode::setHovered):
              (WebCore::dispatchChildInsertionEvents):
              (WebCore::dispatchChildRemovalEvents):
              * dom/ContainerNode.h:
              (WebCore::ContainerNode::ContainerNode):
              * dom/Document.cpp:
              (WebCore::Document::removeAllEventListenersFromAllNodes):
              (WebCore::Document::removeAllDisconnectedNodeEventListeners):
              (WebCore::Document::setFocusedNode):
              * dom/EventTargetNode.cpp: Removed.
              * dom/EventTargetNode.h: Removed.
              * dom/Node.cpp:
              (WebCore::Node::scriptExecutionContext):
              (WebCore::Node::eventListeners):
              (WebCore::Node::insertedIntoDocument):
              (WebCore::Node::removedFromDocument):
              (WebCore::Node::willMoveToNewOwnerDocument):
              (WebCore::Node::didMoveToNewOwnerDocument):
              (WebCore::updateSVGElementInstancesAfterEventListenerChange):
              (WebCore::Node::addEventListener):
              (WebCore::Node::removeEventListener):
              (WebCore::Node::removeAllEventListenersSlowCase):
              (WebCore::Node::handleLocalEvents):
              (WebCore::eventTargetAsSVGElementInstance):
              (WebCore::eventTargetRespectingSVGTargetRules):
              (WebCore::Node::dispatchEvent):
              (WebCore::Node::dispatchGenericEvent):
              (WebCore::Node::dispatchSubtreeModifiedEvent):
              (WebCore::Node::dispatchWindowEvent):
              (WebCore::Node::dispatchUIEvent):
              (WebCore::Node::dispatchKeyEvent):
              (WebCore::Node::dispatchMouseEvent):
              (WebCore::Node::dispatchSimulatedMouseEvent):
              (WebCore::Node::dispatchSimulatedClick):
              (WebCore::Node::dispatchWheelEvent):
              (WebCore::Node::dispatchWebKitAnimationEvent):
              (WebCore::Node::dispatchWebKitTransitionEvent):
              (WebCore::Node::dispatchFocusEvent):
              (WebCore::Node::dispatchBlurEvent):
              (WebCore::Node::dispatchEventForType):
              (WebCore::Node::dispatchProgressEvent):
              (WebCore::Node::dispatchStorageEvent):
              (WebCore::Node::removeInlineEventListenerForType):
              (WebCore::Node::setInlineEventListenerForType):
              (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
              (WebCore::Node::inlineEventListenerForType):
              (WebCore::Node::disabled):
              (WebCore::Node::defaultEventHandler):
              (WebCore::Node::onabort):
              (WebCore::Node::setOnabort):
              (WebCore::Node::onblur):
              (WebCore::Node::setOnblur):
              (WebCore::Node::onchange):
              (WebCore::Node::setOnchange):
              (WebCore::Node::onclick):
              (WebCore::Node::setOnclick):
              (WebCore::Node::oncontextmenu):
              (WebCore::Node::setOncontextmenu):
              (WebCore::Node::ondblclick):
              (WebCore::Node::setOndblclick):
              (WebCore::Node::onerror):
              (WebCore::Node::setOnerror):
              (WebCore::Node::onfocus):
              (WebCore::Node::setOnfocus):
              (WebCore::Node::oninput):
              (WebCore::Node::setOninput):
              (WebCore::Node::onkeydown):
              (WebCore::Node::setOnkeydown):
              (WebCore::Node::onkeypress):
              (WebCore::Node::setOnkeypress):
              (WebCore::Node::onkeyup):
              (WebCore::Node::setOnkeyup):
              (WebCore::Node::onload):
              (WebCore::Node::setOnload):
              (WebCore::Node::onmousedown):
              (WebCore::Node::setOnmousedown):
              (WebCore::Node::onmousemove):
              (WebCore::Node::setOnmousemove):
              (WebCore::Node::onmouseout):
              (WebCore::Node::setOnmouseout):
              (WebCore::Node::onmouseover):
              (WebCore::Node::setOnmouseover):
              (WebCore::Node::onmouseup):
              (WebCore::Node::setOnmouseup):
              (WebCore::Node::onmousewheel):
              (WebCore::Node::setOnmousewheel):
              (WebCore::Node::onbeforecut):
              (WebCore::Node::setOnbeforecut):
              (WebCore::Node::oncut):
              (WebCore::Node::setOncut):
              (WebCore::Node::onbeforecopy):
              (WebCore::Node::setOnbeforecopy):
              (WebCore::Node::oncopy):
              (WebCore::Node::setOncopy):
              (WebCore::Node::onbeforepaste):
              (WebCore::Node::setOnbeforepaste):
              (WebCore::Node::onpaste):
              (WebCore::Node::setOnpaste):
              (WebCore::Node::ondragenter):
              (WebCore::Node::setOndragenter):
              (WebCore::Node::ondragover):
              (WebCore::Node::setOndragover):
              (WebCore::Node::ondragleave):
              (WebCore::Node::setOndragleave):
              (WebCore::Node::ondrop):
              (WebCore::Node::setOndrop):
              (WebCore::Node::ondragstart):
              (WebCore::Node::setOndragstart):
              (WebCore::Node::ondrag):
              (WebCore::Node::setOndrag):
              (WebCore::Node::ondragend):
              (WebCore::Node::setOndragend):
              (WebCore::Node::onreset):
              (WebCore::Node::setOnreset):
              (WebCore::Node::onresize):
              (WebCore::Node::setOnresize):
              (WebCore::Node::onscroll):
              (WebCore::Node::setOnscroll):
              (WebCore::Node::onsearch):
              (WebCore::Node::setOnsearch):
              (WebCore::Node::onselect):
              (WebCore::Node::setOnselect):
              (WebCore::Node::onselectstart):
              (WebCore::Node::setOnselectstart):
              (WebCore::Node::onsubmit):
              (WebCore::Node::setOnsubmit):
              (WebCore::Node::onunload):
              (WebCore::Node::setOnunload):
              * dom/Node.h:
              * editing/Editor.cpp:
              (WebCore::Editor::dispatchCPPEvent):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::handleLocalEvents):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::notifyFinished):
              * loader/MediaDocument.cpp:
              (WebCore::MediaDocument::defaultEventHandler):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::mouseButtonListener):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::updateMouseEventTargetNode):
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::handleWheelEvent):
              (WebCore::EventHandler::canMouseDownStartSelect):
              (WebCore::EventHandler::canMouseDragExtendSelect):
              (WebCore::eventTargetNodeForDocument):
              (WebCore::EventHandler::keyEvent):
              * page/FrameView.cpp:
              (WebCore::FrameView::scheduleEvent):
              (WebCore::FrameView::updateOverflowStatus):
              * page/FrameView.h:
              * page/Page.cpp:
              (WebCore::networkStateChanged):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::updateOverflowStatus):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::valueChanged):
              * rendering/RenderMedia.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionChanged):
              * svg/SVGElementInstance.h:
              (WebCore::SVGElementInstance::toNode):
              * xml/XPathExpression.cpp:
              (WebCore::XPathExpression::evaluate):
              * xml/XPathResult.cpp:
              (WebCore::XPathResult::XPathResult):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9d2ac2f
    • weinig@apple.com's avatar
      WebCore: · 5bd5cc90
      weinig@apple.com authored
      2009-02-04  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Adler.
      
              First stage of merging EventTargetNode up into Node. The intent of this change
              is to both simplify the inheritance hierarchy (at the same time making it more
              closely match the spec which states that all Nodes are EventTargets) and save
              4 bytes per Node that the polymorphic multiple-inheritance was costing us.
      
              This does the bare minimum to get things compiling, the next patch will clean 
      
              * DerivedSources.make:
              * WebCore.base.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::mark):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/JSEventTarget.cpp:
              (WebCore::toEventTarget):
              * bindings/js/JSEventTarget.h:
              * bindings/js/JSEventTargetNodeCustom.cpp:
              (WebCore::JSNode::addEventListener):
              (WebCore::JSNode::removeEventListener):
              (WebCore::JSNode::pushEventHandlerScope):
              * bindings/js/JSStyleSheetCustom.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * dom/Attr.idl:
              * dom/CharacterData.h:
              * dom/CharacterData.idl:
              * dom/Document.idl:
              * dom/DocumentFragment.idl:
              * dom/Element.idl:
              * dom/EventTarget.cpp:
              (WebCore::EventTarget::toNode):
              * dom/EventTarget.h:
              * dom/EventTarget.idl:
              * dom/EventTargetNode.cpp:
              (WebCore::Node::scriptExecutionContext):
              (WebCore::Node::eventListeners):
              (WebCore::Node::insertedIntoDocument):
              (WebCore::Node::removedFromDocument):
              (WebCore::Node::willMoveToNewOwnerDocument):
              (WebCore::Node::didMoveToNewOwnerDocument):
              (WebCore::Node::addEventListener):
              (WebCore::Node::removeEventListener):
              (WebCore::Node::removeAllEventListenersSlowCase):
              (WebCore::Node::handleLocalEvents):
              (WebCore::Node::dispatchEvent):
              (WebCore::Node::dispatchGenericEvent):
              (WebCore::Node::dispatchSubtreeModifiedEvent):
              (WebCore::Node::dispatchWindowEvent):
              (WebCore::Node::dispatchUIEvent):
              (WebCore::Node::dispatchKeyEvent):
              (WebCore::Node::dispatchMouseEvent):
              (WebCore::Node::dispatchSimulatedMouseEvent):
              (WebCore::Node::dispatchSimulatedClick):
              (WebCore::Node::dispatchWheelEvent):
              (WebCore::Node::dispatchWebKitAnimationEvent):
              (WebCore::Node::dispatchWebKitTransitionEvent):
              (WebCore::Node::dispatchFocusEvent):
              (WebCore::Node::dispatchBlurEvent):
              (WebCore::Node::dispatchEventForType):
              (WebCore::Node::dispatchProgressEvent):
              (WebCore::Node::dispatchStorageEvent):
              (WebCore::Node::removeInlineEventListenerForType):
              (WebCore::Node::setInlineEventListenerForType):
              (WebCore::Node::setInlineEventListenerForTypeAndAttribute):
              (WebCore::Node::inlineEventListenerForType):
              (WebCore::Node::disabled):
              (WebCore::Node::defaultEventHandler):
              (WebCore::Node::onabort):
              (WebCore::Node::setOnabort):
              (WebCore::Node::onblur):
              (WebCore::Node::setOnblur):
              (WebCore::Node::onchange):
              (WebCore::Node::setOnchange):
              (WebCore::Node::onclick):
              (WebCore::Node::setOnclick):
              (WebCore::Node::oncontextmenu):
              (WebCore::Node::setOncontextmenu):
              (WebCore::Node::ondblclick):
              (WebCore::Node::setOndblclick):
              (WebCore::Node::onerror):
              (WebCore::Node::setOnerror):
              (WebCore::Node::onfocus):
              (WebCore::Node::setOnfocus):
              (WebCore::Node::oninput):
              (WebCore::Node::setOninput):
              (WebCore::Node::onkeydown):
              (WebCore::Node::setOnkeydown):
              (WebCore::Node::onkeypress):
              (WebCore::Node::setOnkeypress):
              (WebCore::Node::onkeyup):
              (WebCore::Node::setOnkeyup):
              (WebCore::Node::onload):
              (WebCore::Node::setOnload):
              (WebCore::Node::onmousedown):
              (WebCore::Node::setOnmousedown):
              (WebCore::Node::onmousemove):
              (WebCore::Node::setOnmousemove):
              (WebCore::Node::onmouseout):
              (WebCore::Node::setOnmouseout):
              (WebCore::Node::onmouseover):
              (WebCore::Node::setOnmouseover):
              (WebCore::Node::onmouseup):
              (WebCore::Node::setOnmouseup):
              (WebCore::Node::onmousewheel):
              (WebCore::Node::setOnmousewheel):
              (WebCore::Node::onbeforecut):
              (WebCore::Node::setOnbeforecut):
              (WebCore::Node::oncut):
              (WebCore::Node::setOncut):
              (WebCore::Node::onbeforecopy):
              (WebCore::Node::setOnbeforecopy):
              (WebCore::Node::oncopy):
              (WebCore::Node::setOncopy):
              (WebCore::Node::onbeforepaste):
              (WebCore::Node::setOnbeforepaste):
              (WebCore::Node::onpaste):
              (WebCore::Node::setOnpaste):
              (WebCore::Node::ondragenter):
              (WebCore::Node::setOndragenter):
              (WebCore::Node::ondragover):
              (WebCore::Node::setOndragover):
              (WebCore::Node::ondragleave):
              (WebCore::Node::setOndragleave):
              (WebCore::Node::ondrop):
              (WebCore::Node::setOndrop):
              (WebCore::Node::ondragstart):
              (WebCore::Node::setOndragstart):
              (WebCore::Node::ondrag):
              (WebCore::Node::setOndrag):
              (WebCore::Node::ondragend):
              (WebCore::Node::setOndragend):
              (WebCore::Node::onreset):
              (WebCore::Node::setOnreset):
              (WebCore::Node::onresize):
              (WebCore::Node::setOnresize):
              (WebCore::Node::onscroll):
              (WebCore::Node::setOnscroll):
              (WebCore::Node::onsearch):
              (WebCore::Node::setOnsearch):
              (WebCore::Node::onselect):
              (WebCore::Node::setOnselect):
              (WebCore::Node::onselectstart):
              (WebCore::Node::setOnselectstart):
              (WebCore::Node::onsubmit):
              (WebCore::Node::setOnsubmit):
              (WebCore::Node::onunload):
              (WebCore::Node::setOnunload):
              * dom/EventTargetNode.h:
              (WebCore::toEventTargetNode):
              (WebCore::EventTargetNodeCast):
              * dom/EventTargetNode.idl: Removed.
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              (WebCore::MouseEvent::initMouseEvent):
              (WebCore::MouseEvent::toElement):
              (WebCore::MouseEvent::fromElement):
              * dom/MouseEvent.h:
              (WebCore::MouseEvent::create):
              (WebCore::MouseEvent::relatedTarget):
              * dom/Node.cpp:
              (WebCore::Node::~Node):
              * dom/Node.h:
              (WebCore::Node::isEventTargetNode):
              (WebCore::Node::toNode):
              (WebCore::Node::removeAllEventListeners):
              (WebCore::Node::refEventTarget):
              (WebCore::Node::derefEventTarget):
              * dom/Node.idl:
              * page/EventHandler.h:
              * page/FrameView.h:
              * xml/XPathResult.h:
              (WebCore::XPathResult::create):
      
      LayoutTests:
      
      2009-02-05  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Darin Layer.
      
              Fix after merging EventTargetNode up into Node.
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/prototype-chain-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bd5cc90
  27. 04 Feb, 2009 2 commits
    • hyatt@apple.com's avatar
      2009-02-04 David Hyatt <hyatt@apple.com> · c7def066
      hyatt@apple.com authored
              Add a new RenderBoxModelObject class that will eventually act as the direct base class for RenderInlines.  For
              now just adding the class and putting it in between RenderObject and RenderBox in the hierarchy.  RenderInline remains
              derived from RenderBox for now.
      
              Reviewed by Sam Weinig
      
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::RenderBox):
              (WebCore::RenderBox::destroy):
              (WebCore::RenderBox::styleWillChange):
              (WebCore::RenderBox::styleDidChange):
              (WebCore::RenderBox::computeRectForRepaint):
              * rendering/RenderBox.h:
              * rendering/RenderBoxModelObject.cpp: Added.
              (WebCore::RenderBoxModelObject::RenderBoxModelObject):
              (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
              * rendering/RenderBoxModelObject.h: Added.
              * rendering/RenderObject.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7def066
    • hyatt@apple.com's avatar
      2009-02-04 David Hyatt <hyatt@apple.com> · f073d9bd
      hyatt@apple.com authored
              Eliminate RenderContainer.
      
              Reviewed by Sam and Anders
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::RenderBlock):
              (WebCore::RenderBlock::destroy):
              (WebCore::RenderBlock::styleWillChange):
              (WebCore::RenderBlock::styleDidChange):
              (WebCore::RenderBlock::addChild):
              (WebCore::RenderBlock::dirtyLineBoxes):
              (WebCore::RenderBlock::createInlineBox):
              (WebCore::RenderBlock::removeChild):
              (WebCore::RenderBlock::setSelectionState):
              (WebCore::RenderBlock::avoidsFloats):
              (WebCore::RenderBlock::positionForCoordinates):
              (WebCore::RenderBlock::calcInlinePrefWidths):
              (WebCore::RenderBlock::baselinePosition):
              (WebCore::RenderBlock::getBaselineOfFirstLineBox):
              (WebCore::RenderBlock::getBaselineOfLastLineBox):
              (WebCore::RenderBlock::rectWithOutlineForRepaint):
              (WebCore::RenderBlock::hoverAncestor):
              (WebCore::RenderBlock::updateDragState):
              (WebCore::RenderBlock::localCaretRect):
              * rendering/RenderBlock.h:
              (WebCore::RenderBlock::virtualChildren):
              (WebCore::RenderBlock::children):
              * rendering/RenderContainer.cpp: Removed.
              * rendering/RenderContainer.h: Removed.
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::RenderFrameSet):
              (WebCore::RenderFrameSet::nodeAtPoint):
              (WebCore::RenderFrameSet::layout):
              * rendering/RenderFrameSet.h:
              (WebCore::RenderFrameSet::virtualChildren):
              (WebCore::RenderFrameSet::children):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::RenderInline):
              (WebCore::RenderInline::destroy):
              (WebCore::RenderInline::styleDidChange):
              (WebCore::nextContinuation):
              (WebCore::RenderInline::continuationBefore):
              (WebCore::RenderInline::addChildIgnoringContinuation):
              (WebCore::RenderInline::splitInlines):
              (WebCore::RenderInline::splitFlow):
              (WebCore::RenderInline::addChildToContinuation):
              (WebCore::RenderInline::offsetLeft):
              (WebCore::RenderInline::offsetTop):
              (WebCore::RenderInline::positionForCoordinates):
              (WebCore::RenderInline::clippedOverflowRectForRepaint):
              (WebCore::RenderInline::rectWithOutlineForRepaint):
              (WebCore::RenderInline::updateDragState):
              (WebCore::RenderInline::childBecameNonInline):
              * rendering/RenderInline.h:
              (WebCore::RenderInline::virtualChildren):
              (WebCore::RenderInline::children):
              (WebCore::RenderInline::continuation):
              (WebCore::RenderInline::setContinuation):
              * rendering/RenderLineBoxList.h:
              * rendering/RenderObject.h:
              * rendering/RenderObjectChildList.h:
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::RenderSVGRoot):
              (WebCore::RenderSVGRoot::applyContentTransforms):
              (WebCore::RenderSVGRoot::paint):
              (WebCore::RenderSVGRoot::absoluteTransform):
              (WebCore::RenderSVGRoot::nodeAtPoint):
              (WebCore::RenderSVGRoot::position):
              * rendering/RenderSVGRoot.h:
              (WebCore::RenderSVGRoot::virtualChildren):
              (WebCore::RenderSVGRoot::children):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::absoluteRects):
              (WebCore::RenderSVGText::absoluteQuads):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::addChild):
              (WebCore::RenderTable::removeChild):
              * rendering/RenderTableCol.cpp:
              (WebCore::RenderTableCol::RenderTableCol):
              * rendering/RenderTableCol.h:
              (WebCore::RenderTableCol::virtualChildren):
              (WebCore::RenderTableCol::children):
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::RenderTableRow):
              (WebCore::RenderTableRow::destroy):
              (WebCore::RenderTableRow::styleWillChange):
              (WebCore::RenderTableRow::addChild):
              * rendering/RenderTableRow.h:
              (WebCore::RenderTableRow::virtualChildren):
              (WebCore::RenderTableRow::children):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::RenderTableSection):
              (WebCore::RenderTableSection::destroy):
              (WebCore::RenderTableSection::addChild):
              (WebCore::RenderTableSection::removeChild):
              (WebCore::RenderTableSection::lowestPosition):
              (WebCore::RenderTableSection::rightmostPosition):
              (WebCore::RenderTableSection::leftmostPosition):
              * rendering/RenderTableSection.h:
              (WebCore::RenderTableSection::virtualChildren):
              (WebCore::RenderTableSection::children):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f073d9bd
  28. 03 Feb, 2009 2 commits
    • ap@webkit.org's avatar
      Reviewed by Alexey Proskuryakov. · aed1ef63
      ap@webkit.org authored
              Part 2 of
              Bug 23636: Make the async api of ThreadableLoader functional for the worker context.
              <https://bugs.webkit.org/show_bug.cgi?id=23636>
      
              Enable the async portion of ThreadableLoader for workers.
      
              No observable change in behavior, so no test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed1ef63
    • ap@webkit.org's avatar
      2009-02-02 David Levin <levin@chromium.org> · cde075eb
      ap@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Bug 23618: Templated worker tasks should be more error proof to use.
              <https://bugs.webkit.org/show_bug.cgi?id=23618>
      
              Add the generic worker tasks templates needed for the WorkerThreadableLoader.
      
              No observable change in behavior, so no test.
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * dom/CrossThreadCopier.cpp: Added.
              * dom/CrossThreadCopier.h: Added.
              (WebCore::CrossThreadCopierPassThrough::copy):
              * dom/GenericWorkerTask.h:
              Stop doing the WorkerMessagingProxy::askedToTerminate call automatically
              in performTask because was not obvious that it would be done and not always needed.
      
              (WebCore::GenericWorkerTask1::create):
              (WebCore::GenericWorkerTask1::GenericWorkerTask1):
              (WebCore::GenericWorkerTask1::performTask):
              (WebCore::GenericWorkerTask2::create):
              (WebCore::GenericWorkerTask2::GenericWorkerTask2):
              (WebCore::GenericWorkerTask2::performTask):
              (WebCore::GenericWorkerTask3::create):
              (WebCore::GenericWorkerTask3::GenericWorkerTask3):
              (WebCore::GenericWorkerTask3::performTask):
              (WebCore::GenericWorkerTask4::create):
              (WebCore::GenericWorkerTask4::GenericWorkerTask4):
              (WebCore::GenericWorkerTask4::performTask):
              (WebCore::GenericWorkerTask5::create):
              (WebCore::GenericWorkerTask5::GenericWorkerTask5):
              (WebCore::GenericWorkerTask5::performTask):
              (WebCore::GenericWorkerTask6::create):
              (WebCore::GenericWorkerTask6::GenericWorkerTask6):
              (WebCore::GenericWorkerTask6::performTask):
              (WebCore::GenericWorkerTask7::create):
              (WebCore::GenericWorkerTask7::GenericWorkerTask7):
              (WebCore::GenericWorkerTask7::performTask):
              (WebCore::createCallbackTask):
              * dom/WorkerContext.cpp:
              (WebCore::addMessageTask):
              (WebCore::WorkerContext::addMessage):
              * dom/WorkerMessagingProxy.h:
              (WebCore::WorkerMessagingProxy::askedToTerminate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cde075eb
  29. 02 Feb, 2009 1 commit
  30. 31 Jan, 2009 1 commit
  31. 30 Jan, 2009 1 commit