1. 29 Jan, 2011 24 commits
    • weinig@apple.com's avatar
      Fix 32-bit build on the Mac. · 9e84c4e3
      weinig@apple.com authored
      Reviewed by Jon Honeycutt.
      
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::roundTowardZero):
      (WebCore::roundToDevicePixelTowardZero):
      Use floats instead of doubles to avoid double-to-float conversion
      issues.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e84c4e3
    • dbates@webkit.org's avatar
      2011-01-29 Daniel Bates <dbates@rim.com> · f1fdad31
      dbates@webkit.org authored
              Reviewed by Eric Seidel.
      
              Move wince/mt19937ar.c to ThirdParty and make it a policy choice
              https://bugs.webkit.org/show_bug.cgi?id=53253
      
              Move implementation of Mersenne Twister pseudorandom number generator to
              ThirdParty since it is a third party library.
      
              * Source/ThirdParty/mt19937ar.c: Copied from Source/JavaScriptCore/wtf/wince/mt19937ar.c.
      2011-01-29  Daniel Bates  <dbates@rim.com>
      
              Reviewed by Eric Seidel.
      
              Move wince/mt19937ar.c to ThirdParty and make it a policy choice
              https://bugs.webkit.org/show_bug.cgi?id=53253
      
              Make inclusion of MT19937 a policy decision.
      
              Currently, we hardcoded to  use MT19937 when building for
              Windows CE. Instead, we should make this a policy decision
              with the Windows CE port using this by default.
      
              * JavaScriptCore.pri: Append Source/ThirdParty to the end
              of the list include directories.
              * wtf/CMakeLists.txt: Ditto.
              * wtf/Platform.h: Defined WTF_USE_MERSENNE_TWISTER_19937 when
              building for Windows CE.
              * wtf/RandomNumber.cpp:
              (WTF::randomNumber): Substituted USE(MERSENNE_TWISTER_19937) for OS(WINCE).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1fdad31
    • kov@webkit.org's avatar
      2011-01-29 Gustavo Noronha Silva <gns@gnome.org> · b189a770
      kov@webkit.org authored
              [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
              https://bugs.webkit.org/show_bug.cgi?id=53379
      
              Skip tests failing likely by the usage of a newer version of soup.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b189a770
    • rniwa@webkit.org's avatar
      2011-01-29 Ryosuke Niwa <rniwa@webkit.org> · e400b14a
      rniwa@webkit.org authored
              Unreviewed Chromium rebaselines.
      
              * platform/chromium-linux/fast/block/positioning/001-expected.checksum: Added.
              * platform/chromium-linux/fast/block/positioning/001-expected.png: Added.
              * platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
              * platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
              * platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
              * platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
              * platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
              * platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
              * platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
              * platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
              * platform/chromium-win/svg/custom/missing-xlink-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e400b14a
    • cwzwarich@webkit.org's avatar
      Bug 53374 - Remove uses of unsafe string functions in debugging code · 317e7818
      cwzwarich@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53374
      
      Reviewed by David Kilzer.
      
      * runtime/RegExp.cpp:
      (JSC::RegExp::printTraceData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      317e7818
    • cwzwarich@webkit.org's avatar
      Fix ChangeLog date. · 4067ce37
      cwzwarich@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4067ce37
    • cwzwarich@webkit.org's avatar
      JavaScriptCoreUseJIT environment variable broken · 9521c3da
      cwzwarich@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53372
      
      Reviewed by Oliver Hunt.
      
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData): Check the actual value in the string returned
      by getenv() rather than just doing a NULL check on the return value.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9521c3da
    • simon.fraser@apple.com's avatar
      2011-01-28 Simon Fraser <simon.fraser@apple.com> · 79042471
      simon.fraser@apple.com authored
              Reviewed by Adam Barth.
      
              Use clampToInteger() functions in a few places
              https://bugs.webkit.org/show_bug.cgi?id=53363
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Use clampToInteger() for z-index.
              (WebCore::CSSStyleSelector::createTransformOperations): Use clampToPositiveInteger().
              * platform/graphics/transforms/PerspectiveTransformOperation.cpp: Ditto.
              (WebCore::PerspectiveTransformOperation::blend): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79042471
    • rniwa@webkit.org's avatar
      2011-01-29 Ryosuke Niwa <rniwa@webkit.org> · 59e5ec1a
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update; removed http/tests/appcache/online-whitelist.html
              from the test expectation, because it has been passing on Chromium Windows.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59e5ec1a
    • paroga@webkit.org's avatar
      2011-01-29 Patrick Gansterer <paroga@webkit.org> · 10c9e1b0
      paroga@webkit.org authored
              Reviewed by David Kilzer.
      
              Move CharacterNames.h into WTF directory
              https://bugs.webkit.org/show_bug.cgi?id=49618
      
              * GNUmakefile.am:
              * JavaScriptCore.gypi:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * wtf/CMakeLists.txt:
              * wtf/unicode/CharacterNames.h: Renamed from WebCore/platform/text/CharacterNames.h.
              * wtf/unicode/UTF8.cpp:
      2011-01-29  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by David Kilzer.
      
              Move CharacterNames.h into WTF directory
              https://bugs.webkit.org/show_bug.cgi?id=49618
      
              * ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * accessibility/AccessibilityObject.cpp:
              * accessibility/AccessibilityRenderObject.cpp:
              * bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * dom/Position.cpp:
              * dom/SelectElement.cpp:
              * editing/CompositeEditCommand.cpp:
              * editing/Editor.cpp:
              * editing/HTMLInterchange.cpp:
              * editing/InsertTextCommand.cpp:
              * editing/MarkupAccumulator.cpp:
              * editing/TextIterator.cpp:
              * editing/VisibleSelection.cpp:
              * editing/htmlediting.cpp:
              * editing/htmlediting.h:
              * editing/markup.cpp:
              * html/FTPDirectoryDocument.cpp:
              * html/HTMLFormControlElement.cpp:
              * html/parser/HTMLTreeBuilder.cpp:
              * loader/appcache/ManifestParser.cpp:
              * platform/chromium/PopupMenuChromium.cpp:
              * platform/graphics/Font.h:
              * platform/graphics/FontFastPath.cpp:
              * platform/graphics/GlyphPageTreeNode.cpp:
              * platform/graphics/StringTruncator.cpp:
              * platform/graphics/mac/ComplexTextController.cpp:
              * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              * platform/mac/PasteboardMac.mm:
              * platform/text/TextCodecICU.cpp:
              * platform/text/mac/TextCodecMac.cpp:
              * platform/text/transcoder/FontTranscoder.cpp:
              * rendering/RenderBlockLineLayout.cpp:
              * rendering/RenderFlexibleBox.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderText.cpp:
              * rendering/RenderTextControl.cpp:
              * rendering/RenderTreeAsText.cpp:
              * rendering/break_lines.cpp:
              * rendering/mathml/RenderMathMLOperator.h:
              * websockets/WebSocketHandshake.cpp:
              * wml/WMLTableElement.cpp:
      2011-01-29  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by David Kilzer.
      
              Move CharacterNames.h into WTF directory
              https://bugs.webkit.org/show_bug.cgi?id=49618
      
              * src/ChromeClientImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10c9e1b0
    • commit-queue@webkit.org's avatar
      2011-01-29 Dan Winship <danw@gnome.org> · ff9e75c1
      commit-queue@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Require the latest glib and libsoup, and remove conditional
              support for older versions
              https://bugs.webkit.org/show_bug.cgi?id=50675
      
              * autotools/webkit.m4: use AM_PATH_GLIB_2_0 rather than doing
              basically the same work by hand
              * configure.ac:
      2011-01-29  Dan Winship  <danw@gnome.org>
      
              Reviewed by Xan Lopez.
      
              [GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
              libsoup 2.33.1 now.
              https://bugs.webkit.org/show_bug.cgi?id=50675
      
              * platform/network/soup/CookieJarSoup.cpp:
              (WebCore::defaultCookieJar):
              (WebCore::setCookies):
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::ResourceHandle::prepareForURL):
              (WebCore::restartedCallback):
              (WebCore::startHttp):
              * platform/network/soup/ResourceRequestSoup.cpp:
              (WebCore::ResourceRequest::updateSoupMessage):
              (WebCore...
      ff9e75c1
    • abarth@webkit.org's avatar
      2011-01-29 Adam Barth <abarth@webkit.org> · 115b6bb5
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              XSSFilter should replace URLs with about:blank instead of the empty string
              https://bugs.webkit.org/show_bug.cgi?id=53370
      
              Using the empty string will make the URL complete to the current
              document's URL, which isn't really what we want.  Instead, we want to
              use about:blank, which is safe.
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::filterObjectToken):
              (WebCore::XSSFilter::filterEmbedToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      115b6bb5
    • abarth@webkit.org's avatar
      2011-01-29 Adam Barth <abarth@webkit.org> · 18c14eef
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              XSSFilter should pass xssAuditor/script-tag-addslashes*
              https://bugs.webkit.org/show_bug.cgi?id=53365
      
              We need to canonicalize strings to avoid being tricked by addslashes.
      
              * html/parser/XSSFilter.cpp:
              (WebCore::HTMLNames::isNonCanonicalCharacter):
                  - This function is copied from the XSSAuditor (with some tweaks).
                    We'll eventually remove the XSSAuditor once we've got XSSFilter
                    working properly.
              (WebCore::HTMLNames::canonicalize):
              (WebCore::HTMLNames::decodeURL):
              (WebCore::XSSFilter::isContainedInRequest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18c14eef
    • abarth@webkit.org's avatar
      2011-01-29 Adam Barth <abarth@webkit.org> · d8984fa2
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              XSSFilter should pass xssAuditor/script-tag-with-source-same-host.html
              and xssAuditor/script-tag-post-*
              https://bugs.webkit.org/show_bug.cgi?id=53364
      
              We're supposed to allow loading same-origin resources even if they
              appear as part of the request.
      
              Also, we're supposed to look at the POST data too.  :)
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::eraseAttributeIfInjected):
              (WebCore::XSSFilter::isSameOriginResource):
                  - Copy/paste from XSSAuditor::isSameOriginResource.  We'll
                    eventually remove the XSSAuditor version when XSSFilter is done.
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8984fa2
    • abarth@webkit.org's avatar
      2011-01-29 Adam Barth <abarth@webkit.org> · 62d3c6c1
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              XSSFilter should pass 16 of the xssAuditor/script-tag* tests
              https://bugs.webkit.org/show_bug.cgi?id=53362
      
              Turns out we need to replace the src attribute of script tags with
              about:blank to avoid loading the main document URL as a script.  Also,
              move misplaced return statement that was triggering the console message
              too often.
      
              * html/parser/HTMLToken.h:
              (WebCore::HTMLToken::appendToAttributeValue):
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::filterScriptToken):
              (WebCore::XSSFilter::eraseAttributeIfInjected):
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62d3c6c1
    • rniwa@webkit.org's avatar
      2011-01-29 Ryosuke Niwa <rniwa@webkit.org> · 4ca8e41b
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ca8e41b
    • jhoneycutt@apple.com's avatar
      Downloads in WK2 on Windows should write resume data to bundle · e22c1afe
      jhoneycutt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53282
      <rdar://problem/8753077>
      
      Reviewed by Alice Liu.
      
      Source/WebCore:
      
      * WebCore.vcproj/WebCore.vcproj:
      Added new files to project.
      
      * platform/network/cf/DownloadBundle.h: Added.
      * platform/network/win/DownloadBundleWin.cpp: Added.
      (WebCore::DownloadBundle::magicNumber):
      Moved from WebKit's WebDownload so that WebKit and WebKit2 can share
      it.
      (WebCore::DownloadBundle::fileExtension):
      Ditto.
      (WebCore::DownloadBundle::appendResumeData):
      Ditto - but modified to return bool rather than HRESULT and to clean up
      whitespace.
      (WebCore::DownloadBundle::extractResumeData):
      Ditto - modified to clean up whitespace.
      
      Source/WebKit/win:
      
      * WebDownload.cpp:
      (WebDownload::bundlePathForTargetPath):
      Use the new WebCore::DownloadBundle function.
      (WebDownload::request):
      
      * WebDownload.h:
      Removed declarations for functions that were moved to a new location.
      
      * WebDownloadCFNet.cpp:
      (WebDownload::initToResumeWithBundle):
      Use the new WebCore::DownloadBundle function.
      (WebDownload::cancelForResume):
      Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
      WebCore::DownloadBundle function.
      
      Source/WebKit2:
      
      * WebProcess/Downloads/Download.cpp:
      (WebKit::Download::decideDestinationWithSuggestedFilename):
      Call didDecideDestination(), now that the destination is decided.
      
      * WebProcess/Downloads/Download.h:
      Declare didDecideDestination(). Added member variables to hold the
      destination file path and the download bundle path.
      (WebKit::Download::destination):
      Return the path to the final destination for this download.
      
      * WebProcess/Downloads/cf/DownloadCFNet.cpp:
      (WebKit::Download::start):
      Remove the name of an unused param.
      (WebKit::Download::startWithHandle):
      Ditto.
      (WebKit::Download::cancel):
      Tell CFNetwork not to delete the file upon failure, and tell it to
      cancel the download. Copy the resume data for the download, and append
      it to the download bundle. Call didCancel() with an empty
      DataReference, since we have written our own resume data.
      (WebKit::decideDestinationWithSuggestedObjectNameCallback):
      Remove some unused param names. Removed the call to
      CFURLDownloadSetDestination() - this is now handled in
      Download::didDecideDestination().
      (WebKit::didCreateDestinationCallback):
      Report that the final destination was created, rather than the download
      bundle, matching old WebKit.
      (WebKit::Download::didDecideDestination):
      Store the final destination and the download bundle paths, and call
      CFURLDownloadSetDestination(), passing the path to the download bundle.
      
      * WebProcess/Downloads/curl/DownloadCurl.cpp:
      (WebKit::Download::didDecideDestination):
      Stubbed.
      
      * WebProcess/Downloads/mac/DownloadMac.mm:
      (WebKit::Download::didDecideDestination):
      Stubbed - unneeded on the Mac.
      
      * WebProcess/Downloads/qt/DownloadQt.cpp:
      (WebKit::Download::didDecideDestination):
      Stubbed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e22c1afe
    • commit-queue@webkit.org's avatar
      2011-01-29 Jeff Miller <jeffm@apple.com> · 07c79cca
      commit-queue@webkit.org authored
              Reviewed by Anders Carlsson.
      
              Support find bouncy in WebKit2 on Windows
              https://bugs.webkit.org/show_bug.cgi?id=53329
              <rdar://problem/8565843>
              The Mac implements the find bouncy inside of WebKit in the UI process for WebKit2, but we need to do this inside Safari for WebKit2 on Windows.
              Add infrastructure to call back into the app when the find indicator changes.
      
              * UIProcess/API/C/win/WKView.cpp: Cleanup some code style violations.
              (WKViewSetFindIndicatorCallback): Added.
              (WKViewGetFindIndicatorCallback): Added.
              * UIProcess/API/C/win/WKView.h: Cleanup some code style violations.
              * UIProcess/FindIndicator.cpp:
              (WebKit::FindIndicator::create):
              (WebKit::FindIndicator::FindIndicator):
              (WebKit::FindIndicator::frameRect):
              (WebKit::FindIndicator::draw):
              Rename m_selectionRect to m_selectionRectInWindowCoordinates and m_textRects to m_textRectsInSelectionRectCoordinates (along with similarly named local variables) to be more explict about the coordinate system.
              * UIProcess/FindIndicator.h:
              (WebKit::FindIndicator::selectionRectInWindowCoordinates): Added.
              (WebKit::FindIndicator::textRects): Rename m_textRects to m_textRectsInSelectionRectCoordinates.
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::setFindIndicator): Rename selectionRect to selectionRectInWindowCoordinates and textRects to textRectsInSelectionRectCoordinates to be more explict about the coordinate system.
              * UIProcess/WebPageProxy.h: Ditto.
              * UIProcess/win/WebView.cpp:
              (WebKit::WebView::WebView):
              (WebKit::WebView::setFindIndicator): Added.
              (WebKit::WebView::setFindIndicatorCallback): Added.
              (WebKit::WebView::getFindIndicatorCallback): Added.
              * UIProcess/win/WebView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07c79cca
    • rniwa@webkit.org's avatar
      2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com> · dc5de698
      rniwa@webkit.org authored
              Unreviewed, rolling out r77050.
              http://trac.webkit.org/changeset/77050
              https://bugs.webkit.org/show_bug.cgi?id=53371
      
              Caused a crash in Chromium's test_shell_tests (Requested by
              rniwa on #webkit).
      
              * resources/performance-test.js: Removed.
              * tiny-innerHTML.html: Removed.
      2011-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77050.
              http://trac.webkit.org/changeset/77050
              https://bugs.webkit.org/show_bug.cgi?id=53371
      
              Caused a crash in Chromium's test_shell_tests (Requested by
              rniwa on #webkit).
      
              * html/parser/HTMLTreeBuilder.cpp:
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
              * html/parser/HTMLTreeBuilder.h:
      
      
      git-svn-id: http://svn.webkit.org...
      dc5de698
    • rniwa@webkit.org's avatar
      2011-01-29 Ryosuke Niwa <rniwa@webkit.org> · 5b8914b3
      rniwa@webkit.org authored
              Unreviewed rebaselines and test expectation updates for Chromium Linux.
      
              * platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum: Added.
              * platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
              * platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b8914b3
    • ap@apple.com's avatar
      2011-01-28 Alexey Proskuryakov <ap@apple.com> · 1984e12c
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=53367
              <rdar://problem/8926460> Remove dysfunctional code from -[WKPrintingView _isPrintingPreview].
      
              * UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _isPrintingPreview]): The common
              branch works fine for now, no need to make platforms different.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1984e12c
    • eric@webkit.org's avatar
      2011-01-28 Eric Seidel <eric@webkit.org> · 61acd1c1
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
              https://bugs.webkit.org/show_bug.cgi?id=48719
      
              It's unclear exactly what the Peacekeeper benchmark is testing,
              because I haven't found a way to run it myself.
      
              However, I constructed a benchmark which shows at least one possible slow point.
              The HTML5 spec talks about creating a new document for every time we use
              the fragment parsing algorithm.  Document() it turns out, it a huge bloated
              mess, and the constructor and destructor do a huge amount of work.
              To avoid constructing (or destructing) documents for each innerHTML call,
              this patch adds a shared dummy document used by all innerHTML calls.
      
              * benchmarks/parser/tiny-innerHTML.html: Added.
      2011-01-28  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Darin Adler.
      
              HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
              https://bugs.webkit.org/show_bug.cgi?id=48719
      
              It's unclear exactly what the Peacekeeper benchmark is testing,
              because I haven't found a way to run it myself.
      
              However, I constructed a benchmark which shows at least one possible slow point.
              The HTML5 spec talks about creating a new document for every time we use
              the fragment parsing algorithm.  Document() it turns out, it a huge bloated
              mess, and the constructor and destructor do a huge amount of work.
              To avoid constructing (or destructing) documents for each innerHTML call,
              this patch adds a shared dummy document used by all innerHTML calls.
      
              This patch brings us from 7x slower than Safari 5 on tiny-innerHTML
              to only 1.5x slower than Safari 5.  I'm sure there is more work to do here.
      
              Saving a shared Document like this is error prone.  Currently
              DummyDocumentFactory::releaseDocument() calls removeAllChildren()
              in an attempt to clear the Document's state. However it's possible
              that that call is not sufficient and we'll have future bugs here.
      
              * html/parser/HTMLTreeBuilder.cpp:
              (WebCore::DummyDocumentFactory::createDummyDocument):
              (WebCore::DummyDocumentFactory::releaseDocument):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::document):
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
              * html/parser/HTMLTreeBuilder.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61acd1c1
    • jnd@chromium.org's avatar
      2011-01-28 Johnny Ding <jnd@chromium.org> · df0c4676
      jnd@chromium.org authored
              Reviewed by Adam Barth.
      
              Gesture API, disallow popup bypass with using iframe src.
              https://bugs.webkit.org/show_bug.cgi?id=53244
      
              * fast/events/popup-blocked-from-iframe-src-expected.txt: Added.
              * fast/events/popup-blocked-from-iframe-src.html: Added.
      2011-01-28  Johnny Ding  <jnd@chromium.org>
      
              Reviewed by Adam Barth.
      
              Gesture API: Don't use current gesture status to set "forceUserGesture" parameter when calling ScriptController::executeScript.
              The "forceUserGesture" parameter should be only set when you are definitely sure that the running script is from a hyper-link.
              https://bugs.webkit.org/show_bug.cgi?id=53244
      
              Test: fast/events/popup-blocked-from-iframe-src.html
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df0c4676
    • rniwa@webkit.org's avatar
      2011-01-28 Ryosuke Niwa <rniwa@webkit.org> · 39917629
      rniwa@webkit.org authored
              Unreviewed; removed Chromium test expectations for tests that have been steadily passing.
      
              In particular, many ietestcenter tests have been passing since V8 is updated to
              version 3.0.12 in Chromium r72940.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39917629
  2. 28 Jan, 2011 16 commits
    • rniwa@webkit.org's avatar
      2011-01-28 Ryosuke Niwa <rniwa@webkit.org> · 628faee7
      rniwa@webkit.org authored
              Unreviewed; roll WebKit Chromium revision from 72894 to 73048.
      
              * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      628faee7
    • mitz@apple.com's avatar
      Updated test results after r76983. · 1a23039b
      mitz@apple.com authored
      Rubber-stamped by Maciej Stachowiak.
      
      * platform/mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-writing-direction-natural-expected.txt.
      * platform/mac-leopard/fast/text/international/bidi-menulist-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-menulist-expected.txt.
      * platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
      * platform/mac/fast/forms/select-writing-direction-natural-expected.png:
      * platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
      * platform/mac/fast/text/international/bidi-menulist-expected.checksum:
      * platform/mac/fast/text/international/bidi-menulist-expected.png:
      * platform/mac/fast/text/international/bidi-menulist-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a23039b
    • simon.fraser@apple.com's avatar
      2011-01-28 Simon Fraser <simon.fraser@apple.com> · 991ac213
      simon.fraser@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Add various clampToInt() methods to MathExtras.h
              https://bugs.webkit.org/show_bug.cgi?id=52910
      
              Use clampToInteger() from MathExtras.h
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseCounter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      991ac213
    • rniwa@webkit.org's avatar
      2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com> · 3857b1ea
      rniwa@webkit.org authored
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * API/JSCallbackObject.h:
              (JSC::JSCallbackObjectData::setPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren):
              (JSC::JSCallbackObject::setPrivateProperty):
              * API/JSCallbackObjectFunctions.h:
              (JSC::::put):
              (JSC::::staticFunctionGetter):
              * API/JSObjectRef.cpp:
              (JSObjectMakeConstructor):
              (JSObjectSetPrivateProperty):
              * API/JSWeakObjectMapRefInternal.h:
              * JavaScriptCore.exp:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::markAggregate):
              * bytecode/CodeBlock.h:
              (JSC::CodeBlock::globalObject):
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::BytecodeGenerator):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
              (JSC::BytecodeGenerator::findScopedProperty):
              * debugger/Debugger.cpp:
              (JSC::evaluateInGlobalCallFrame):
              * debugger/DebuggerActivation.cpp:
              (JSC::DebuggerActivation::DebuggerActivation):
              (JSC::DebuggerActivation::markChildren):
              * debugger/DebuggerActivation.h:
              * debugger/DebuggerCallFrame.cpp:
              (JSC::DebuggerCallFrame::evaluate):
              * interpreter/CallFrame.h:
              (JSC::ExecState::exception):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::resolve):
              (JSC::Interpreter::resolveSkip):
              (JSC::Interpreter::resolveGlobal):
              (JSC::Interpreter::resolveGlobalDynamic):
              (JSC::Interpreter::resolveBaseAndProperty):
              (JSC::Interpreter::unwindCallFrame):
              (JSC::appendSourceToError):
              (JSC::Interpreter::execute):
              (JSC::Interpreter::tryCacheGetByID):
              (JSC::Interpreter::privateExecute):
              * jit/JITStubs.cpp:
              (JSC::JITThunks::tryCacheGetByID):
              (JSC::DEFINE_STUB_FUNCTION):
              * jsc.cpp:
              (GlobalObject::GlobalObject):
              * runtime/ArgList.cpp:
              (JSC::MarkedArgumentBuffer::markLists):
              * runtime/Arguments.cpp:
              (JSC::Arguments::markChildren):
              (JSC::Arguments::getOwnPropertySlot):
              (JSC::Arguments::getOwnPropertyDescriptor):
              (JSC::Arguments::put):
              * runtime/Arguments.h:
              (JSC::Arguments::setActivation):
              (JSC::Arguments::Arguments):
              * runtime/ArrayConstructor.cpp:
              (JSC::ArrayConstructor::ArrayConstructor):
              (JSC::constructArrayWithSizeQuirk):
              * runtime/ArrayPrototype.cpp:
              (JSC::arrayProtoFuncSplice):
              * runtime/BatchedTransitionOptimizer.h:
              (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
              (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
              * runtime/BooleanConstructor.cpp:
              (JSC::BooleanConstructor::BooleanConstructor):
              (JSC::constructBoolean):
              (JSC::constructBooleanFromImmediateBoolean):
              * runtime/BooleanPrototype.cpp:
              (JSC::BooleanPrototype::BooleanPrototype):
              * runtime/ConservativeSet.cpp:
              (JSC::ConservativeSet::grow):
              * runtime/ConservativeSet.h:
              (JSC::ConservativeSet::~ConservativeSet):
              (JSC::ConservativeSet::mark):
              * runtime/DateConstructor.cpp:
              (JSC::DateConstructor::DateConstructor):
              * runtime/DateInstance.cpp:
              (JSC::DateInstance::DateInstance):
              * runtime/DatePrototype.cpp:
              (JSC::dateProtoFuncSetTime):
              (JSC::setNewValueFromTimeArgs):
              (JSC::setNewValueFromDateArgs):
              (JSC::dateProtoFuncSetYear):
              * runtime/ErrorConstructor.cpp:
              (JSC::ErrorConstructor::ErrorConstructor):
              * runtime/ErrorInstance.cpp:
              (JSC::ErrorInstance::ErrorInstance):
              * runtime/ErrorPrototype.cpp:
              (JSC::ErrorPrototype::ErrorPrototype):
              * runtime/FunctionConstructor.cpp:
              (JSC::FunctionConstructor::FunctionConstructor):
              * runtime/FunctionPrototype.cpp:
              (JSC::FunctionPrototype::FunctionPrototype):
              * runtime/GetterSetter.cpp:
              (JSC::GetterSetter::markChildren):
              * runtime/GetterSetter.h:
              (JSC::GetterSetter::GetterSetter):
              (JSC::GetterSetter::getter):
              (JSC::GetterSetter::setGetter):
              (JSC::GetterSetter::setter):
              (JSC::GetterSetter::setSetter):
              * runtime/GlobalEvalFunction.cpp:
              (JSC::GlobalEvalFunction::GlobalEvalFunction):
              (JSC::GlobalEvalFunction::markChildren):
              * runtime/GlobalEvalFunction.h:
              (JSC::GlobalEvalFunction::cachedGlobalObject):
              * runtime/Heap.cpp:
              (JSC::Heap::markProtectedObjects):
              (JSC::Heap::markTempSortVectors):
              (JSC::Heap::markRoots):
              * runtime/InternalFunction.cpp:
              (JSC::InternalFunction::InternalFunction):
              * runtime/JSAPIValueWrapper.h:
              (JSC::JSAPIValueWrapper::value):
              (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::markChildren):
              (JSC::JSActivation::put):
              * runtime/JSArray.cpp:
              (JSC::JSArray::JSArray):
              (JSC::JSArray::getOwnPropertySlot):
              (JSC::JSArray::getOwnPropertyDescriptor):
              (JSC::JSArray::put):
              (JSC::JSArray::putSlowCase):
              (JSC::JSArray::deleteProperty):
              (JSC::JSArray::increaseVectorLength):
              (JSC::JSArray::setLength):
              (JSC::JSArray::pop):
              (JSC::JSArray::push):
              (JSC::JSArray::unshiftCount):
              (JSC::JSArray::sort):
              (JSC::JSArray::fillArgList):
              (JSC::JSArray::copyToRegisters):
              (JSC::JSArray::compactForSorting):
              * runtime/JSArray.h:
              (JSC::JSArray::getIndex):
              (JSC::JSArray::setIndex):
              (JSC::JSArray::uncheckedSetIndex):
              (JSC::JSArray::markChildrenDirect):
              * runtime/JSByteArray.cpp:
              (JSC::JSByteArray::JSByteArray):
              * runtime/JSCell.h:
              (JSC::JSCell::JSValue::toThisObject):
              (JSC::JSCell::MarkStack::append):
              * runtime/JSFunction.cpp:
              (JSC::JSFunction::JSFunction):
              (JSC::JSFunction::getOwnPropertySlot):
              * runtime/JSGlobalData.h:
              * runtime/JSGlobalObject.cpp:
              (JSC::markIfNeeded):
              (JSC::JSGlobalObject::reset):
              (JSC::JSGlobalObject::resetPrototype):
              (JSC::JSGlobalObject::markChildren):
              * runtime/JSGlobalObject.h:
              (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
              (JSC::JSGlobalObject::regExpConstructor):
              (JSC::JSGlobalObject::errorConstructor):
              (JSC::JSGlobalObject::evalErrorConstructor):
              (JSC::JSGlobalObject::rangeErrorConstructor):
              (JSC::JSGlobalObject::referenceErrorConstructor):
              (JSC::JSGlobalObject::syntaxErrorConstructor):
              (JSC::JSGlobalObject::typeErrorConstructor):
              (JSC::JSGlobalObject::URIErrorConstructor):
              (JSC::JSGlobalObject::evalFunction):
              (JSC::JSGlobalObject::objectPrototype):
              (JSC::JSGlobalObject::functionPrototype):
              (JSC::JSGlobalObject::arrayPrototype):
              (JSC::JSGlobalObject::booleanPrototype):
              (JSC::JSGlobalObject::stringPrototype):
              (JSC::JSGlobalObject::numberPrototype):
              (JSC::JSGlobalObject::datePrototype):
              (JSC::JSGlobalObject::regExpPrototype):
              (JSC::JSGlobalObject::methodCallDummy):
              (JSC::Structure::prototypeForLookup):
              (JSC::constructArray):
              * runtime/JSONObject.cpp:
              (JSC::Stringifier::Holder::object):
              (JSC::Stringifier::markAggregate):
              (JSC::Stringifier::stringify):
              (JSC::Stringifier::Holder::appendNextProperty):
              (JSC::Walker::callReviver):
              (JSC::Walker::walk):
              * runtime/JSObject.cpp:
              (JSC::JSObject::defineGetter):
              (JSC::JSObject::defineSetter):
              (JSC::JSObject::removeDirect):
              (JSC::JSObject::putDirectFunction):
              (JSC::JSObject::putDirectFunctionWithoutTransition):
              (JSC::putDescriptor):
              (JSC::JSObject::defineOwnProperty):
              * runtime/JSObject.h:
              (JSC::JSObject::getDirectOffset):
              (JSC::JSObject::putDirectOffset):
              (JSC::JSObject::flattenDictionaryObject):
              (JSC::JSObject::putDirectInternal):
              (JSC::JSObject::putDirect):
              (JSC::JSObject::putDirectFunction):
              (JSC::JSObject::putDirectWithoutTransition):
              (JSC::JSObject::putDirectFunctionWithoutTransition):
              (JSC::JSValue::putDirect):
              (JSC::JSObject::allocatePropertyStorageInline):
              (JSC::JSObject::markChildrenDirect):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::get):
              * runtime/JSPropertyNameIterator.h:
              * runtime/JSStaticScopeObject.cpp:
              (JSC::JSStaticScopeObject::markChildren):
              * runtime/JSString.cpp:
              (JSC::StringObject::create):
              * runtime/JSValue.h:
              * runtime/JSWrapperObject.cpp:
              (JSC::JSWrapperObject::markChildren):
              * runtime/JSWrapperObject.h:
              (JSC::JSWrapperObject::internalValue):
              (JSC::JSWrapperObject::setInternalValue):
              * runtime/LiteralParser.cpp:
              (JSC::LiteralParser::parse):
              * runtime/Lookup.cpp:
              (JSC::setUpStaticFunctionSlot):
              * runtime/Lookup.h:
              (JSC::lookupPut):
              * runtime/MarkStack.h:
              (JSC::MarkStack::appendValues):
              * runtime/MathObject.cpp:
              (JSC::MathObject::MathObject):
              * runtime/NativeErrorConstructor.cpp:
              (JSC::NativeErrorConstructor::NativeErrorConstructor):
              * runtime/NativeErrorPrototype.cpp:
              (JSC::NativeErrorPrototype::NativeErrorPrototype):
              * runtime/NumberConstructor.cpp:
              (JSC::NumberConstructor::NumberConstructor):
              (JSC::constructWithNumberConstructor):
              * runtime/NumberObject.cpp:
              (JSC::constructNumber):
              * runtime/NumberPrototype.cpp:
              (JSC::NumberPrototype::NumberPrototype):
              * runtime/ObjectConstructor.cpp:
              (JSC::ObjectConstructor::ObjectConstructor):
              (JSC::objectConstructorGetOwnPropertyDescriptor):
              * runtime/Operations.h:
              (JSC::normalizePrototypeChain):
              (JSC::resolveBase):
              * runtime/PrototypeFunction.cpp:
              (JSC::PrototypeFunction::PrototypeFunction):
              * runtime/PutPropertySlot.h:
              (JSC::PutPropertySlot::setExistingProperty):
              (JSC::PutPropertySlot::setNewProperty):
              (JSC::PutPropertySlot::base):
              * runtime/RegExpConstructor.cpp:
              (JSC::RegExpConstructor::RegExpConstructor):
              * runtime/ScopeChain.cpp:
              (JSC::ScopeChainNode::print):
              * runtime/ScopeChain.h:
              (JSC::ScopeChainNode::~ScopeChainNode):
              (JSC::ScopeChainIterator::operator*):
              (JSC::ScopeChainIterator::operator->):
              (JSC::ScopeChain::top):
              * runtime/ScopeChainMark.h:
              (JSC::ScopeChain::markAggregate):
              * runtime/SmallStrings.cpp:
              (JSC::isMarked):
              (JSC::SmallStrings::markChildren):
              * runtime/SmallStrings.h:
              (JSC::SmallStrings::emptyString):
              (JSC::SmallStrings::singleCharacterString):
              (JSC::SmallStrings::singleCharacterStrings):
              * runtime/StringConstructor.cpp:
              (JSC::StringConstructor::StringConstructor):
              * runtime/StringObject.cpp:
              (JSC::StringObject::StringObject):
              * runtime/StringObject.h:
              * runtime/StringPrototype.cpp:
              (JSC::StringPrototype::StringPrototype):
              * runtime/Structure.cpp:
              (JSC::Structure::Structure):
              (JSC::Structure::addPropertyTransition):
              (JSC::Structure::toDictionaryTransition):
              (JSC::Structure::flattenDictionaryStructure):
              * runtime/Structure.h:
              (JSC::Structure::storedPrototype):
              * runtime/WeakGCMap.h:
              (JSC::WeakGCMap::uncheckedGet):
              (JSC::WeakGCMap::isValid):
              (JSC::::get):
              (JSC::::take):
              (JSC::::set):
              (JSC::::uncheckedRemove):
              * runtime/WriteBarrier.h: Removed.
      2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSObjectMark):
      2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * WebView/WebScriptDebugDelegate.mm:
              (-[WebScriptCallFrame scopeChain]):
      2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * ForwardingHeaders/runtime/WriteBarrier.h: Removed.
              * WebCore.exp.in:
              * bindings/js/DOMWrapperWorld.h:
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::markDOMNodesForDocument):
              (WebCore::markDOMObjectWrapper):
              (WebCore::markDOMNodeWrapper):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::markChildren):
              (WebCore::JSDOMGlobalObject::setInjectedScript):
              (WebCore::JSDOMGlobalObject::injectedScript):
              * bindings/js/JSDOMGlobalObject.h:
              (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
              (WebCore::getDOMConstructor):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::DialogHandler::dialogCreated):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::JSDOMWindowShell::JSDOMWindowShell):
              (WebCore::JSDOMWindowShell::setWindow):
              (WebCore::JSDOMWindowShell::markChildren):
              (WebCore::JSDOMWindowShell::unwrappedObject):
              * bindings/js/JSDOMWindowShell.h:
              (WebCore::JSDOMWindowShell::window):
              (WebCore::JSDOMWindowShell::setWindow):
              * bindings/js/JSDeviceMotionEventCustom.cpp:
              (WebCore::createAccelerationObject):
              (WebCore::createRotationRateObject):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::markJSFunction):
              * bindings/js/JSEventListener.h:
              (WebCore::JSEventListener::jsFunction):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::setAll):
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor):
              * bindings/js/JSImageDataCustom.cpp:
              (WebCore::toJS):
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              (WebCore::JSJavaScriptCallFrame::scopeChain):
              (WebCore::JSJavaScriptCallFrame::scopeType):
              * bindings/js/JSNodeFilterCondition.cpp:
              (WebCore::JSNodeFilterCondition::markAggregate):
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor):
              * bindings/js/JSSQLResultSetRowListCustom.cpp:
              (WebCore::JSSQLResultSetRowList::item):
              * bindings/js/ScriptCachedFrameData.cpp:
              (WebCore::ScriptCachedFrameData::restore):
              * bindings/js/ScriptObject.cpp:
              (WebCore::ScriptGlobalObject::set):
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::CloneDeserializer::putProperty):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
              (JSC::Bindings::QtRuntimeMetaMethod::markChildren):
              (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
              (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
              * bridge/qt/qt_runtime.h:
              * bridge/runtime_root.cpp:
              (JSC::Bindings::RootObject::invalidate):
              * bridge/runtime_root.h:
              * dom/Document.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3857b1ea
    • mjs@apple.com's avatar
      2011-01-28 Maciej Stachowiak <mjs@apple.com> · e687428e
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              WKPageGetEstimatedProgress returns wrong value after a mainframe provisional load has started
              https://bugs.webkit.org/show_bug.cgi?id=53358
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::didStartProgress): Start progress at the magic initial value, not 0.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e687428e
    • mjs@apple.com's avatar
      2011-01-28 Maciej Stachowiak <mjs@apple.com> · 62b20f46
      mjs@apple.com authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.setPOSIXLocale
              https://bugs.webkit.org/show_bug.cgi?id=42682
      
              * platform/mac-wk2/Skipped:
      2011-01-28  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.setPOSIXLocale
              https://bugs.webkit.org/show_bug.cgi?id=42682
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
              (WTR::InjectedBundle::resetLocalSettings):
              (WTR::InjectedBundle::didReceiveMessage):
              * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::setPOSIXLocale):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62b20f46
    • abarth@webkit.org's avatar
      2011-01-28 Adam Barth <abarth@webkit.org> · bfc7fcf5
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              XSSFilter should log to the console when it blocks something
              https://bugs.webkit.org/show_bug.cgi?id=53354
      
              This patch refactors a bunch of methods in XSSFilter to return a bool
              indicating whether they blocked anything.  Using this bool, we decide
              whether to log to the console.  We're using the same log message as the
              XSSAuditor, but it seems likely we can improve this message in the
              future (especially by piping in the correct line number, which is now
              accessible via the parser).
      
              * html/parser/XSSFilter.cpp:
              (WebCore::HTMLNames::isNameOfInlineEventHandler):
              (WebCore::XSSFilter::filterToken):
              (WebCore::XSSFilter::filterTokenInitial):
              (WebCore::XSSFilter::filterTokenAfterScriptStartTag):
              (WebCore::XSSFilter::filterScriptToken):
              (WebCore::XSSFilter::filterObjectToken):
              (WebCore::XSSFilter::filterEmbedToken):
              (WebCore::XSSFilter::filterAppletToken):
              (WebCore::XSSFilter::filterMetaToken):
              (WebCore::XSSFilter::filterBaseToken):
              (WebCore::XSSFilter::eraseInlineEventHandlersIfInjected):
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfc7fcf5
    • dpranke@chromium.org's avatar
      2011-01-28 Dirk Pranke <dpranke@chromium.org> · a6ec07c1
      dpranke@chromium.org authored
               Reviewed by Mihai Parparita.
      
               test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
      
               This patch re-enables this test and changes it to
               handle all of the mac platform versions, not just the one
               it is running on.
      
               https://bugs.webkit.org/show_bug.cgi?id=53356
      
               * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6ec07c1
    • dpranke@chromium.org's avatar
      2011-01-28 Dirk Pranke <dpranke@chromium.org> · db2fcd17
      dpranke@chromium.org authored
              Unreviewed, build fix.
      
              Take two. The fix in 77023 didn't work, because we were
              still calling path.abspath_to_uri, which calls _cygpath under
              the covers, and it appears the cygpath on the bots does
              something different than it does on my machine. This patch
              removes the calls to path.abspath_to_uri, so it should be safe.
              If it doesn't work, I'll roll it out along with r76982 and 77023.
      
              https://bugs.webkit.org/show_bug.cgi?id=53126
      
              * Scripts/webkitpy/layout_tests/port/test.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db2fcd17
    • abarth@webkit.org's avatar
      2011-01-28 Adam Barth <abarth@webkit.org> · 015fdee4
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              Wire up settings->xssAuditorEnabled to XSSFilter
              https://bugs.webkit.org/show_bug.cgi?id=53345
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::XSSFilter):
              (WebCore::XSSFilter::filterToken):
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      015fdee4
    • abarth@webkit.org's avatar
      2011-01-28 Adam Barth <abarth@webkit.org> · 0fbacc01
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              Teach XSSFilter about <meta> and <base> tags
              https://bugs.webkit.org/show_bug.cgi?id=53339
      
              I'm not 100% sure we need to block <meta http-equiv>, but it seems
              prudent given how powerful that attribute is.  We definitely need to
              block injection of <base href> because that can redirect script tags
              that use relative URLs.
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::filterToken):
              (WebCore::XSSFilter::filterMetaToken):
              (WebCore::XSSFilter::filterBaseToken):
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fbacc01
    • abarth@webkit.org's avatar
      2011-01-28 Adam Barth <abarth@webkit.org> · 87e8410e
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              Teach XSSFilter about <applet>
              https://bugs.webkit.org/show_bug.cgi?id=53338
      
              HTML5 is pretty light on information about how the <applet> tag works.
              According to this site:
      
              http://download.oracle.com/javase/1.4.2/docs/guide/misc/applet.html
      
              The "code" and "object" attributes are the essential attributes for
              determining which piece of Java to run.  We might need to expand to the
              codebase and archive attributes at some point, but hopefully code and
              object will be sufficient.
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::filterToken):
              (WebCore::XSSFilter::filterAppletToken):
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87e8410e
    • abarth@webkit.org's avatar
      2011-01-28 Adam Barth <abarth@webkit.org> · f47ab540
      abarth@webkit.org authored
              Reviewed by Daniel Bates.
      
              Teach the XSSFilter about object and embed tags
              https://bugs.webkit.org/show_bug.cgi?id=53336
      
              For <object> and <embed>, we filter out attribute values that either
              indicate which piece of media to load or which plugin to load.  In a
              perfect world, we'd only need to filter out the URLs of the media, but
              some plug-ins (like Flash) have lots of fun places you can hide the
              URL (e.g., the "movie" <param>).
      
              * html/parser/XSSFilter.cpp:
              (WebCore::XSSFilter::filterToken):
              (WebCore::XSSFilter::filterScriptToken):
              (WebCore::XSSFilter::filterObjectToken):
              (WebCore::XSSFilter::filterEmbedToken):
              (WebCore::XSSFilter::eraseAttributeIfInjected):
              * html/parser/XSSFilter.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f47ab540
    • ddkilzer@apple.com's avatar
      Added link to bug in ChangeLog. · 464d7466
      ddkilzer@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      464d7466
    • andersca@apple.com's avatar
      Yet another build fix (What was I thinking?) · 7efcf1c7
      andersca@apple.com authored
      * WebProcess/Downloads/Download.h:
      * WebProcess/Plugins/PluginProxy.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7efcf1c7
    • ddkilzer@apple.com's avatar
      <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode · f0a9ae48
      ddkilzer@apple.com authored
      Reviewed by Mark Rowe.
      
      * Scripts/webkitdirs.pm:
      (checkRequiredSystemConfig): Check the Xcode marketing version
      in addition to the DevCoreTools build version before complaining
      about an old version of Xcode.  Also make the Mac OS X version
      check use Perl's built-in version string comparitor.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0a9ae48