1. 13 Jan, 2011 4 commits
    • enrica@apple.com's avatar
      Source/WebCore: WebKit2: Add support for drag and drop · 9d9813d0
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52343
      <rdar://problem/7660558>
                     
      Reviewed by Darin Adler.
      
      This patch contains the changes required to support dropping content
      in WebKit on the Mac. The DragData class has been extended to provide
      additional context from the application (keyboard state, modal windows, etc.)
      as well as information of the drag pasteboard being used.
      The support for WebKit as drag source will be added with a separate patch.
      
      * WebCore.exp.in:
      * page/DragController.cpp:
      (WebCore::DragController::dragIsMove): Added DragData parameter.
      (WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
      (WebCore::DragController::concludeEditDrag): Same as above.
      * page/DragController.h: Added parameter to isCopyKeyDown.
      * page/mac/DragControllerMac.mm:
      The following methods have been modified to use the information stored
      in the DragData class.
      (WebCore::DragController::isCopyKeyDown):
      (WebCore::DragController::dragOperation):
      * platform/DragData.h:
      (WebCore::DragData::flags):
      * platform/DragData.cpp: Added default flags parameter to the constructor.
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
      (WebCore::DragData::canSmartReplace):
      (WebCore::DragData::containsColor):
      (WebCore::DragData::containsFiles):
      (WebCore::DragData::asFilenames):
      (WebCore::DragData::containsPlainText):
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      All the following files have been modified to add the DragData
      parameter to isCopyKeyDown. I plan to improve this in the future
      and make isCopyKeyDown not platform specific.
      * page/android/DragControllerAndroid.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/brew/DragControllerBrew.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/chromium/DragControllerChromium.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/efl/DragControllerEfl.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/gtk/DragControllerGtk.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/haiku/DragControllerHaiku.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/mac/DragControllerMac.mm:
      (WebCore::DragController::isCopyKeyDown):
      (WebCore::DragController::dragOperation):
      * page/qt/DragControllerQt.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/win/DragControllerWin.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/wx/DragControllerWx.cpp:
      (WebCore::DragController::isCopyKeyDown):
      
      WebKit/mac: WebKit2: Add support for drag and drop
      https://bugs.webkit.org/show_bug.cgi?id=52343
      <rdar://problem/7660558>
              
      Reviewed by Darin Adler.
      
      The DragData class has been extended to provide
      additional context from the application (keyboard state, modal windows, etc.)
      as well as information of the drag pasteboard being used.
      These are the changes to align the behavior for WebKit.
      
      * WebView/WebView.mm:
      (-[WebView applicationFlags:]): Added.
      (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
      (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
      (-[WebView draggingExited:]): Added parameter to the DragData constructor.
      (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
      
      WebKit2: WebKit2: Add support for drag and drop
      https://bugs.webkit.org/show_bug.cgi?id=52343
      <rdar://problem/7660558>
                     
      Reviewed by Darin Adler.
      
      This patch contains the changes required to support dropping content
      in WebKit on the Mac. The DragData class has been extended to provide
      additional context from the application (keyboard state, modal windows, etc.)
      as well as information of the drag pasteboard being used.
      The support for WebKit as drag source will be added with a separate patch.
      
      * Shared/DragControllerAction.h: Added.
      * UIProcess/API/mac/WKView.mm:
      Added implemention of the methods required to add suport for a drop target.
      To maintain asynchronous communication with the WebProcess, we always return
      the previous calculated value for the drag operation.
      (-[WKView _registerDraggedTypes]):
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView applicationFlags:]):
      (-[WKView draggingEntered:]):
      (-[WKView draggingUpdated:]):
      (-[WKView draggingExited:]):
      (-[WKView prepareForDragOperation:]):
      (-[WKView performDragOperation:]):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::performDragControllerAction):
      (WebKit::WebPageProxy::didPerformDragControllerAction):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::dragOperation):
      (WebKit::WebPageProxy::resetDragOperation):
      * UIProcess/WebPageProxy.messages.in:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebDragClient.cpp:
      (WebKit::WebDragClient::willPerformDragDestinationAction):
      (WebKit::WebDragClient::willPerformDragSourceAction):
      (WebKit::WebDragClient::actionMaskForDrag):
      (WebKit::WebDragClient::dragSourceActionMaskForPoint):
      (WebKit::WebDragClient::startDrag):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::performDragControllerAction):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d9813d0
    • ddkilzer@apple.com's avatar
      Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project · de794561
      ddkilzer@apple.com authored
      Not reviewed.
      
      * WebCore.xcodeproj/project.pbxproj: Add missing headers.  Note
      that the corresponding source files were originally added to the
      project in r48559.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de794561
    • jianli@chromium.org's avatar
      Change createObjectURL and revokeObjectURL to put under webkitURL. · 1c19f401
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52257
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      Note that we add "webkit" vendor prefix to URL that is introduced in
      the latest File API spec.
      
      For the time being, we implement webkitURL as a readonly attribute
      instead of a constructor so that we will not expose prototype property,
      as required by the spec.
      
      * Android.derived.jscbindings.mk:
      * Android.derived.v8bindings.mk:
      * Android.mk:
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pri:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * html/DOMURL.cpp: Added.
      * html/DOMURL.h: Added.
      * html/DOMURL.idl: Added.
      * inspector/front-end/NetworkPanel.js:
      * inspector/front-end/utilities.js:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::webkitURL):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::webkitURL):
      * workers/WorkerContext.h:
      * workers/WorkerContext.idl:
      
      LayoutTests:
      
      Change all related test scripts and results to account for this change.
      
      * fast/dom/Window/script-tests/window-property-descriptors.js:
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/Window/window-properties.html:
      * fast/dom/script-tests/prototype-inheritance-2.js:
      * fast/dom/script-tests/prototype-inheritance.js:
      * fast/files/apply-blob-url-to-img.html:
      * fast/files/apply-blob-url-to-xhr.html:
      * fast/files/create-blob-url-crash.html:
      * fast/files/revoke-blob-url.html:
      * fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
      (onmessage):
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c19f401
    • pfeldman@chromium.org's avatar
      2011-01-12 Pavel Feldman <pfeldman@chromium.org> · 417eb939
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: embed injected script into the backend.
              https://bugs.webkit.org/show_bug.cgi?id=52312
      
              InjectedScript belongs to the backend of the system and
              should be exposed by means of protocol, not InjectedScriptAccess.
              This patch makes injected script a part of the backend.
              It introduces single manual generation step (xxd -i) that should be
              automated by the build scripts for all the platforms.
      
              * CMakeLists.txt:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::injectedScriptSource):
              * inspector/InjectedScriptHost.h:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/InjectedScript.js: Removed.
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.doLoadedDone.propertyNamesCallback):
              (WebInspector.doLoadedDone):
              * inspector/xxd.pl: Added.
      
      2011-01-12  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: embed injected script into the backend.
              https://bugs.webkit.org/show_bug.cgi?id=52312
      
              * WebKit.grd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      417eb939
  2. 10 Jan, 2011 1 commit
  3. 09 Jan, 2011 5 commits
    • mrowe@apple.com's avatar
      Fix the build. · 87458563
      mrowe@apple.com authored
      * WebCore.xcodeproj/project.pbxproj: Copy SVGResourcesCache.h in to PrivateHeaders
      once more.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87458563
    • krit@webkit.org's avatar
      2011-01-09 Dirk Schulze <krit@webkit.org> · af2011cb
      krit@webkit.org authored
              Reviewed by Rob Buis.
      
              Move MathML renderer to rendering/mathml
              https://bugs.webkit.org/show_bug.cgi?id=52131
      
              Move all renderer of MathML to WebCore/rendering/mathml
      
              No change of functionality, no new tests added.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * mathml/RenderMathMLBlock.cpp: Removed.
              * mathml/RenderMathMLBlock.h: Removed.
              * mathml/RenderMathMLFenced.cpp: Removed.
              * mathml/RenderMathMLFenced.h: Removed.
              * mathml/RenderMathMLFraction.cpp: Removed.
              * mathml/RenderMathMLFraction.h: Removed.
              * mathml/RenderMathMLMath.cpp: Removed.
              * mathml/RenderMathMLMath.h: Removed.
              * mathml/RenderMathMLOperator.cpp: Removed.
              * mathml/RenderMathMLOperator.h: Removed.
              * mathml/RenderMathMLRoot.cpp: Removed.
              * mathml/RenderMathMLRoot.h: Removed.
              * mathml/RenderMathMLRow.cpp: Removed.
              * mathml/RenderMathMLRow.h: Removed.
              * mathml/RenderMathMLSquareRoot.cpp: Removed.
              * mathml/RenderMathMLSquareRoot.h: Removed.
              * mathml/RenderMathMLSubSup.cpp: Removed.
              * mathml/RenderMathMLSubSup.h: Removed.
              * mathml/RenderMathMLUnderOver.cpp: Removed.
              * mathml/RenderMathMLUnderOver.h: Removed.
              * rendering/mathml: Added.
              * rendering/mathml/RenderMathMLBlock.cpp: Copied from Source/WebCore/mathml/RenderMathMLBlock.cpp.
              * rendering/mathml/RenderMathMLBlock.h: Copied from Source/WebCore/mathml/RenderMathMLBlock.h.
              * rendering/mathml/RenderMathMLFenced.cpp: Copied from Source/WebCore/mathml/RenderMathMLFenced.cpp.
              * rendering/mathml/RenderMathMLFenced.h: Copied from Source/WebCore/mathml/RenderMathMLFenced.h.
              * rendering/mathml/RenderMathMLFraction.cpp: Copied from Source/WebCore/mathml/RenderMathMLFraction.cpp.
              * rendering/mathml/RenderMathMLFraction.h: Copied from Source/WebCore/mathml/RenderMathMLFraction.h.
              * rendering/mathml/RenderMathMLMath.cpp: Copied from Source/WebCore/mathml/RenderMathMLMath.cpp.
              * rendering/mathml/RenderMathMLMath.h: Copied from Source/WebCore/mathml/RenderMathMLMath.h.
              * rendering/mathml/RenderMathMLOperator.cpp: Copied from Source/WebCore/mathml/RenderMathMLOperator.cpp.
              * rendering/mathml/RenderMathMLOperator.h: Copied from Source/WebCore/mathml/RenderMathMLOperator.h.
              * rendering/mathml/RenderMathMLRoot.cpp: Copied from Source/WebCore/mathml/RenderMathMLRoot.cpp.
              * rendering/mathml/RenderMathMLRoot.h: Copied from Source/WebCore/mathml/RenderMathMLRoot.h.
              * rendering/mathml/RenderMathMLRow.cpp: Copied from Source/WebCore/mathml/RenderMathMLRow.cpp.
              * rendering/mathml/RenderMathMLRow.h: Copied from Source/WebCore/mathml/RenderMathMLRow.h.
              * rendering/mathml/RenderMathMLSquareRoot.cpp: Copied from Source/WebCore/mathml/RenderMathMLSquareRoot.cpp.
              * rendering/mathml/RenderMathMLSquareRoot.h: Copied from Source/WebCore/mathml/RenderMathMLSquareRoot.h.
              * rendering/mathml/RenderMathMLSubSup.cpp: Copied from Source/WebCore/mathml/RenderMathMLSubSup.cpp.
              * rendering/mathml/RenderMathMLSubSup.h: Copied from Source/WebCore/mathml/RenderMathMLSubSup.h.
              * rendering/mathml/RenderMathMLUnderOver.cpp: Copied from Source/WebCore/mathml/RenderMathMLUnderOver.cpp.
              * rendering/mathml/RenderMathMLUnderOver.h: Copied from Source/WebCore/mathml/RenderMathMLUnderOver.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af2011cb
    • krit@webkit.org's avatar
      2011-01-09 Dirk Schulze <krit@webkit.org> · daf7d4da
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Rename RenderForeignObject to RenderSVGForeignObject
              https://bugs.webkit.org/show_bug.cgi?id=52129
      
              Rename RenderForeignObject to RenderSVGForeignObject to match the naming schema in render/svg.
      
              No change of functionality, no new tests.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderingAllInOne.cpp:
              * rendering/svg/RenderForeignObject.cpp: Removed.
              * rendering/svg/RenderForeignObject.h: Removed.
              * rendering/svg/RenderSVGAllInOne.cpp:
              * rendering/svg/RenderSVGBlock.cpp:
              (WebCore::RenderSVGBlock::updateBoxModelInfoFromStyle):
              * rendering/svg/RenderSVGForeignObject.cpp: Copied from Source/WebCore/rendering/svg/RenderForeignObject.cpp.
              (WebCore::RenderSVGForeignObject::RenderSVGForeignObject):
              (WebCore::RenderSVGForeignObject::~RenderSVGForeignObject):
              (WebCore::RenderSVGForeignObject::paint):
              (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
              (WebCore::RenderSVGForeignObject::computeRectForRepaint):
              (WebCore::RenderSVGForeignObject::localToParentTransform):
              (WebCore::RenderSVGForeignObject::computeLogicalWidth):
              (WebCore::RenderSVGForeignObject::computeLogicalHeight):
              (WebCore::RenderSVGForeignObject::layout):
              (WebCore::RenderSVGForeignObject::nodeAtFloatPoint):
              (WebCore::RenderSVGForeignObject::nodeAtPoint):
              (WebCore::RenderSVGForeignObject::mapLocalToContainer):
              * rendering/svg/RenderSVGForeignObject.h: Copied from Source/WebCore/rendering/svg/RenderForeignObject.h.
              (WebCore::RenderSVGForeignObject::renderName):
              * svg/SVGForeignObjectElement.cpp:
              (WebCore::SVGForeignObjectElement::createRenderer):
      2011-01-09  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Rename RenderForeignObject to RenderSVGForeignObject
              https://bugs.webkit.org/show_bug.cgi?id=52129
      
              Renamed RenderForeignObject to RenderSVGForeignObject
      
              * platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.txt:
              * platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
              * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt:
              * platform/chromium-win/svg/custom/dynamic-svg-document-creation-expected.txt:
              * platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
              * platform/chromium-win/svg/custom/foreignObject-crash-on-hover-expected.txt:
              * platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
              * platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
              * platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
              * platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
              * platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
              * platform/chromium-win/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
              * platform/chromium-win/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
              * platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
              * platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt:
              * platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt:
              * platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt:
              * platform/chromium-win/svg/hixie/mixed/006-expected.txt:
              * platform/chromium-win/svg/hixie/mixed/007-expected.txt:
              * platform/chromium-win/svg/hixie/mixed/008-expected.txt:
              * platform/chromium-win/svg/hixie/mixed/009-expected.txt:
              * platform/chromium-win/svg/hixie/mixed/011-expected.txt:
              * platform/chromium-win/svg/text/foreignObject-repaint-expected.txt:
              * platform/chromium-win/svg/text/foreignObject-text-clipping-bug-expected.txt:
              * platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
              * platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
              * platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
              * platform/chromium-win/svg/zoom/text/zoom-foreignObject-expected.txt:
              * platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
              * platform/chromium-win/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
              * platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
              * platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
              * platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
              * platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
              * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
              * platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt:
              * platform/gtk/svg/text/foreignObject-repaint-expected.txt:
              * platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
              * platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
              * platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
              * platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
              * platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
              * platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
              * platform/mac-leopard/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
              * platform/mac-leopard/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
              * platform/mac/svg/custom/baseval-animval-equality-expected.txt:
              * platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
              * platform/mac/svg/custom/dynamic-svg-document-creation-expected.txt:
              * platform/mac/svg/custom/fill-SVGPaint-interface-expected.txt:
              * platform/mac/svg/custom/foreign-object-skew-expected.txt:
              * platform/mac/svg/custom/foreignObject-crash-on-hover-expected.txt:
              * platform/mac/svg/custom/getPresentationAttribute-expected.txt:
              * platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.txt:
              * platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.txt:
              * platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
              * platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
              * platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
              * platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.txt:
              * platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.txt:
              * platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.txt:
              * platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
              * platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
              * platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt:
              * platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt:
              * platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
              * platform/mac/svg/hixie/mixed/006-expected.txt:
              * platform/mac/svg/hixie/mixed/007-expected.txt:
              * platform/mac/svg/hixie/mixed/008-expected.txt:
              * platform/mac/svg/hixie/mixed/009-expected.txt:
              * platform/mac/svg/hixie/mixed/011-expected.txt:
              * platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt:
              * platform/mac/svg/text/foreignObject-repaint-expected.txt:
              * platform/mac/svg/text/foreignObject-text-clipping-bug-expected.txt:
              * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
              * platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
              * platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
              * platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
              * platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
              * platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
              * platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt:
              * platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
              * platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt:
              * platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt:
              * platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
              * platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt:
              * platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
              * platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
              * platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
              * platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
              * platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt:
              * platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
              * platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daf7d4da
    • krit@webkit.org's avatar
      2011-01-09 Dirk Schulze <krit@webkit.org> · b524c2a4
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Move all SVG renderer to WebCore/rendering/svg
              https://bugs.webkit.org/show_bug.cgi?id=52087
      
              No change of functionality. Just moved all SVG renderer to WebCore/rendering/svg.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vjproj/project.vjproj:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderForeignObject.cpp: Removed.
              * rendering/RenderForeignObject.h: Removed.
              * rendering/RenderSVGAllInOne.cpp: Removed.
              * rendering/RenderSVGBlock.cpp: Removed.
              * rendering/RenderSVGBlock.h: Removed.
              * rendering/RenderSVGContainer.cpp: Removed.
              * rendering/RenderSVGContainer.h: Removed.
              * rendering/RenderSVGGradientStop.cpp: Removed.
              * rendering/RenderSVGGradientStop.h: Removed.
              * rendering/RenderSVGHiddenContainer.cpp: Removed.
              * rendering/RenderSVGHiddenContainer.h: Removed.
              * rendering/RenderSVGImage.cpp: Removed.
              * rendering/RenderSVGImage.h: Removed.
              * rendering/RenderSVGModelObject.cpp: Removed.
              * rendering/RenderSVGModelObject.h: Removed.
              * rendering/RenderSVGResource.cpp: Removed.
              * rendering/RenderSVGResource.h: Removed.
              * rendering/RenderSVGResourceClipper.cpp: Removed.
              * rendering/RenderSVGResourceClipper.h: Removed.
              * rendering/RenderSVGResourceContainer.cpp: Removed.
              * rendering/RenderSVGResourceContainer.h: Removed.
              * rendering/RenderSVGResourceFilter.cpp: Removed.
              * rendering/RenderSVGResourceFilter.h: Removed.
              * rendering/RenderSVGResourceFilterPrimitive.cpp: Removed.
              * rendering/RenderSVGResourceFilterPrimitive.h: Removed.
              * rendering/RenderSVGResourceGradient.cpp: Removed.
              * rendering/RenderSVGResourceGradient.h: Removed.
              * rendering/RenderSVGResourceLinearGradient.cpp: Removed.
              * rendering/RenderSVGResourceLinearGradient.h: Removed.
              * rendering/RenderSVGResourceMarker.cpp: Removed.
              * rendering/RenderSVGResourceMarker.h: Removed.
              * rendering/RenderSVGResourceMasker.cpp: Removed.
              * rendering/RenderSVGResourceMasker.h: Removed.
              * rendering/RenderSVGResourcePattern.cpp: Removed.
              * rendering/RenderSVGResourcePattern.h: Removed.
              * rendering/RenderSVGResourceRadialGradient.cpp: Removed.
              * rendering/RenderSVGResourceRadialGradient.h: Removed.
              * rendering/RenderSVGResourceSolidColor.cpp: Removed.
              * rendering/RenderSVGResourceSolidColor.h: Removed.
              * rendering/RenderSVGRoot.cpp: Removed.
              * rendering/RenderSVGRoot.h: Removed.
              * rendering/RenderSVGShadowTreeRootContainer.cpp: Removed.
              * rendering/RenderSVGShadowTreeRootContainer.h: Removed.
              * rendering/RenderSVGTransformableContainer.cpp: Removed.
              * rendering/RenderSVGTransformableContainer.h: Removed.
              * rendering/RenderSVGViewportContainer.cpp: Removed.
              * rendering/RenderSVGViewportContainer.h: Removed.
              * rendering/SVGImageBufferTools.cpp: Removed.
              * rendering/SVGImageBufferTools.h: Removed.
              * rendering/SVGMarkerData.h: Removed.
              * rendering/SVGMarkerLayoutInfo.cpp: Removed.
              * rendering/SVGMarkerLayoutInfo.h: Removed.
              * rendering/SVGRenderSupport.cpp: Removed.
              * rendering/SVGRenderSupport.h: Removed.
              * rendering/SVGRenderTreeAsText.cpp: Removed.
              * rendering/SVGRenderTreeAsText.h: Removed.
              * rendering/SVGResources.cpp: Removed.
              * rendering/SVGResources.h: Removed.
              * rendering/SVGResourcesCache.cpp: Removed.
              * rendering/SVGResourcesCache.h: Removed.
              * rendering/SVGResourcesCycleSolver.cpp: Removed.
              * rendering/SVGResourcesCycleSolver.h: Removed.
              * rendering/SVGShadowTreeElements.cpp: Removed.
              * rendering/SVGShadowTreeElements.h: Removed.
              * rendering/svg/RenderForeignObject.cpp: Copied from Source/WebCore/rendering/RenderForeignObject.cpp.
              * rendering/svg/RenderForeignObject.h: Copied from Source/WebCore/rendering/RenderForeignObject.h.
              * rendering/svg/RenderSVGAllInOne.cpp: Copied from Source/WebCore/rendering/RenderSVGAllInOne.cpp.
              * rendering/svg/RenderSVGBlock.cpp: Copied from Source/WebCore/rendering/RenderSVGBlock.cpp.
              * rendering/svg/RenderSVGBlock.h: Copied from Source/WebCore/rendering/RenderSVGBlock.h.
              * rendering/svg/RenderSVGContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGContainer.cpp.
              * rendering/svg/RenderSVGContainer.h: Copied from Source/WebCore/rendering/RenderSVGContainer.h.
              * rendering/svg/RenderSVGGradientStop.cpp: Copied from Source/WebCore/rendering/RenderSVGGradientStop.cpp.
              * rendering/svg/RenderSVGGradientStop.h: Copied from Source/WebCore/rendering/RenderSVGGradientStop.h.
              * rendering/svg/RenderSVGHiddenContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGHiddenContainer.cpp.
              * rendering/svg/RenderSVGHiddenContainer.h: Copied from Source/WebCore/rendering/RenderSVGHiddenContainer.h.
              * rendering/svg/RenderSVGImage.cpp: Copied from Source/WebCore/rendering/RenderSVGImage.cpp.
              * rendering/svg/RenderSVGImage.h: Copied from Source/WebCore/rendering/RenderSVGImage.h.
              * rendering/svg/RenderSVGModelObject.cpp: Copied from Source/WebCore/rendering/RenderSVGModelObject.cpp.
              * rendering/svg/RenderSVGModelObject.h: Copied from Source/WebCore/rendering/RenderSVGModelObject.h.
              * rendering/svg/RenderSVGResource.cpp: Copied from Source/WebCore/rendering/RenderSVGResource.cpp.
              * rendering/svg/RenderSVGResource.h: Copied from Source/WebCore/rendering/RenderSVGResource.h.
              * rendering/svg/RenderSVGResourceClipper.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceClipper.cpp.
              * rendering/svg/RenderSVGResourceClipper.h: Copied from Source/WebCore/rendering/RenderSVGResourceClipper.h.
              * rendering/svg/RenderSVGResourceContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceContainer.cpp.
              * rendering/svg/RenderSVGResourceContainer.h: Copied from Source/WebCore/rendering/RenderSVGResourceContainer.h.
              * rendering/svg/RenderSVGResourceFilter.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceFilter.cpp.
              * rendering/svg/RenderSVGResourceFilter.h: Copied from Source/WebCore/rendering/RenderSVGResourceFilter.h.
              * rendering/svg/RenderSVGResourceFilterPrimitive.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceFilterPrimitive.cpp.
              * rendering/svg/RenderSVGResourceFilterPrimitive.h: Copied from Source/WebCore/rendering/RenderSVGResourceFilterPrimitive.h.
              * rendering/svg/RenderSVGResourceGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceGradient.cpp.
              * rendering/svg/RenderSVGResourceGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceGradient.h.
              * rendering/svg/RenderSVGResourceLinearGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceLinearGradient.cpp.
              * rendering/svg/RenderSVGResourceLinearGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceLinearGradient.h.
              * rendering/svg/RenderSVGResourceMarker.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceMarker.cpp.
              * rendering/svg/RenderSVGResourceMarker.h: Copied from Source/WebCore/rendering/RenderSVGResourceMarker.h.
              * rendering/svg/RenderSVGResourceMasker.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceMasker.cpp.
              * rendering/svg/RenderSVGResourceMasker.h: Copied from Source/WebCore/rendering/RenderSVGResourceMasker.h.
              * rendering/svg/RenderSVGResourcePattern.cpp: Copied from Source/WebCore/rendering/RenderSVGResourcePattern.cpp.
              * rendering/svg/RenderSVGResourcePattern.h: Copied from Source/WebCore/rendering/RenderSVGResourcePattern.h.
              * rendering/svg/RenderSVGResourceRadialGradient.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceRadialGradient.cpp.
              * rendering/svg/RenderSVGResourceRadialGradient.h: Copied from Source/WebCore/rendering/RenderSVGResourceRadialGradient.h.
              * rendering/svg/RenderSVGResourceSolidColor.cpp: Copied from Source/WebCore/rendering/RenderSVGResourceSolidColor.cpp.
              * rendering/svg/RenderSVGResourceSolidColor.h: Copied from Source/WebCore/rendering/RenderSVGResourceSolidColor.h.
              * rendering/svg/RenderSVGRoot.cpp: Copied from Source/WebCore/rendering/RenderSVGRoot.cpp.
              * rendering/svg/RenderSVGRoot.h: Copied from Source/WebCore/rendering/RenderSVGRoot.h.
              * rendering/svg/RenderSVGShadowTreeRootContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGShadowTreeRootContainer.cpp.
              * rendering/svg/RenderSVGShadowTreeRootContainer.h: Copied from Source/WebCore/rendering/RenderSVGShadowTreeRootContainer.h.
              * rendering/svg/RenderSVGTransformableContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGTransformableContainer.cpp.
              * rendering/svg/RenderSVGTransformableContainer.h: Copied from Source/WebCore/rendering/RenderSVGTransformableContainer.h.
              * rendering/svg/RenderSVGViewportContainer.cpp: Copied from Source/WebCore/rendering/RenderSVGViewportContainer.cpp.
              * rendering/svg/RenderSVGViewportContainer.h: Copied from Source/WebCore/rendering/RenderSVGViewportContainer.h.
              * rendering/svg/SVGImageBufferTools.cpp: Copied from Source/WebCore/rendering/SVGImageBufferTools.cpp.
              * rendering/svg/SVGImageBufferTools.h: Copied from Source/WebCore/rendering/SVGImageBufferTools.h.
              * rendering/svg/SVGMarkerData.h: Copied from Source/WebCore/rendering/SVGMarkerData.h.
              * rendering/svg/SVGMarkerLayoutInfo.cpp: Copied from Source/WebCore/rendering/SVGMarkerLayoutInfo.cpp.
              * rendering/svg/SVGMarkerLayoutInfo.h: Copied from Source/WebCore/rendering/SVGMarkerLayoutInfo.h.
              * rendering/svg/SVGRenderSupport.cpp: Copied from Source/WebCore/rendering/SVGRenderSupport.cpp.
              * rendering/svg/SVGRenderSupport.h: Copied from Source/WebCore/rendering/SVGRenderSupport.h.
              * rendering/svg/SVGRenderTreeAsText.cpp: Copied from Source/WebCore/rendering/SVGRenderTreeAsText.cpp.
              * rendering/svg/SVGRenderTreeAsText.h: Copied from Source/WebCore/rendering/SVGRenderTreeAsText.h.
              * rendering/svg/SVGResources.cpp: Copied from Source/WebCore/rendering/SVGResources.cpp.
              * rendering/svg/SVGResources.h: Copied from Source/WebCore/rendering/SVGResources.h.
              * rendering/svg/SVGResourcesCache.cpp: Copied from Source/WebCore/rendering/SVGResourcesCache.cpp.
              * rendering/svg/SVGResourcesCache.h: Copied from Source/WebCore/rendering/SVGResourcesCache.h.
              * rendering/svg/SVGResourcesCycleSolver.cpp: Copied from Source/WebCore/rendering/SVGResourcesCycleSolver.cpp.
              * rendering/svg/SVGResourcesCycleSolver.h: Copied from Source/WebCore/rendering/SVGResourcesCycleSolver.h.
              * rendering/svg/SVGShadowTreeElements.cpp: Copied from Source/WebCore/rendering/SVGShadowTreeElements.cpp.
              * rendering/svg/SVGShadowTreeElements.h: Copied from Source/WebCore/rendering/SVGShadowTreeElements.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b524c2a4
    • krit@webkit.org's avatar
      2011-01-09 Dirk Schulze <krit@webkit.org> · f30ce1b3
      krit@webkit.org authored
              Unreviewed sort of Xcode project file.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f30ce1b3
  4. 08 Jan, 2011 1 commit
  5. 07 Jan, 2011 5 commits
    • rniwa@webkit.org's avatar
      2011-01-06 Ryosuke Niwa <rniwa@webkit.org> · cf46007a
      rniwa@webkit.org authored
              Reviewed by Adam Barth.
      
              onbeforeunload is broken for framesets
              https://bugs.webkit.org/show_bug.cgi?id=19418
      
              Added beforeunload event support for sub frames. WebKit's implementation tries to match
              that of Internet Explorer as much as possible. beforeunload event is fired for each and
              every descendent of a frame that is about to navigate.
      
              When a value other than null is returned by a beforeunload handler, a confirmation dialog
              is shown for each handler (calls chrome's runBeforeUnloadConfirmPanel) just like it is done
              for main frames.
      
              In addition, navigation is forbidden while beforeunload handlers are being called.
              Setting values to location.href, location.reload, and other means of navigations are thus
              ignored while beforeunload event handler is being ran, matching Internet Explorer's behavior.
      
              Because navigation needs to prevented globally, NavigationDisablerForBeforeUnload is added to
              NavigationScheduler.h, which is instantiated as a RAII object in FrameLoader::shouldClose.
      
              Tests: fast/events/before-unload-adopt-subframe-to-outside.html
                     fast/events/before-unload-adopt-within-subframes.html
                     fast/events/before-unload-forbidden-navigation.html
                     fast/events/before-unload-in-multiple-subframes.html
                     fast/events/before-unload-in-subframe.html
                     fast/events/before-unload-javascript-navigation.html
                     fast/events/before-unload-remove-and-add-subframe.html
                     fact/events/before-unload-remove-itself.html
                     fast/events/before-unload-with-subframes.html
      
             * loader/FrameLoader.cpp:
             (WebCore::FrameLoader::shouldClose): Calls fireBeforeUnloadEvent on m_frame and m_frame's
             descendents. Returns true only if every call to fireBeforeUnloadEvent returned true.
             (WebCore::FrameLoader::fireBeforeUnloadEvent): Fires a beforeunload event and calls
             chrome's runBeforeUnloadConfirmPanel as needed.
             (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Calls shouldClose for all frames.
             * loader/FrameLoader.h:
             * loader/NavigationScheduler.cpp:
             (WebCore::NavigationScheduler::shouldScheduleNavigation): Checks the nullity of Page and calls
             NavigationDisablerForBeforeUnload::isNavigationAllowed when url is not javascript scheme.
             (WebCore::NavigationScheduler::scheduleRedirect): Calls shouldScheduleNavigation.
             (WebCore::NavigationScheduler::scheduleLocationChange): Ditto.
             (WebCore::NavigationScheduler::scheduleRefresh): Ditto.
             (WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
             * loader/NavigationScheduler.h:
             (WebCore::NavigationDisablerForBeforeUnload::NavigationDisablerForBeforeUnload): Disables navigation.
             (WebCore::NavigationDisablerForBeforeUnload::~NavigationDisablerForBeforeUnload): Enables navigation
             when called on the last instance of NavigationDisablerForBeforeUnload.
             (WebCore::NavigationDisablerForBeforeUnload::isNavigationAllowed): Returns true if there are no instance
             of NavigationDisablerForBeforeUnload left on the stack.
      2011-01-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Adam Barth.
      
              onbeforeunload is broken for framesets
              https://bugs.webkit.org/show_bug.cgi?id=19418
      
              Added tests to ensure WebKit fires beforeunload events for subframes,
              and disallows navigation except that of javascript scheme while beforeunload event
              handlers are being called.
      
              Also added a test to ensure WebKit fires beforeunload event for subframes exactly
              once even if a subframe was moved around within a beforeunload event handler.
      
              A test that ensures beforeunload event is not fired for an iframe if the iframe
              was added or removed within a beforeunload event handler is also added.
      
              Furthermore, a test to ensure WebKit does not fire a beforeunload event to an iframe
              that has been adopted by a document outside of the unloading document is added.
      
              * fast/events/before-unload-adopt-subframe-to-outside-expected.txt: Added.
              * fast/events/before-unload-adopt-subframe-to-outside.html: Added.
              * fast/events/before-unload-adopt-within-subframes-expected.txt: Added.
              * fast/events/before-unload-adopt-within-subframes.html: Added.
              * fast/events/before-unload-forbidden-navigation-expected.txt: Added.
              * fast/events/before-unload-forbidden-navigation.html: Added.
              * fast/events/before-unload-in-multiple-subframes-expected.txt: Added.
              * fast/events/before-unload-in-multiple-subframes.html: Added.
              * fast/events/before-unload-in-subframe-expected.txt: Added.
              * fast/events/before-unload-in-subframe.html: Added.
              * fast/events/before-unload-javascript-navigation-expected.txt: Added.
              * fast/events/before-unload-javascript-navigation.html: Added.
              * fast/events/before-unload-remove-and-add-subframe-expected.txt: Added.
              * fast/events/before-unload-remove-and-add-subframe.html: Added.
              * fact/events/before-unload-remove-itself-expected.txt: Added.
              * fact/events/before-unload-remove-itself.html: Added.
              * fast/events/before-unload-with-subframes-expected.txt: Added.
              * fast/events/before-unload-with-subframes.html: Added.
              * fast/events/resources/before-unload-in-subframe-child.html: Added.
              * fast/events/resources/before-unload-in-subframe-destination.html: Added.
              * fast/events/resources/before-unload-in-subframe-fail.html: Added.
              * fast/events/resources/before-unload-with-subframes-parent.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf46007a
    • jer.noble@apple.com's avatar
      WebCore: Implement WebKit Full Screen support. · d9d59ff9
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
      Reviewed by Simon Fraser.
      
      Mark for export all those WebCore functions needed by WebFullscreenController.
      
      * WebCore.exp.in:
      
      WebCore: Implement WebKit Full Screen support.
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
      Reviewed by Simon Fraser.
      
      screenRect is useful for more than just HTMLMediaElements.  Promote it into
      Element.
      
      * dom/Element.cpp: Moved into Element from HTMLMediaElement.
      * dom/Element.h: Ditto.
      * dom/Node.cpp:
      * html/HTMLMediaElement.cpp: Moved screenRect into Element.
      * html/HTMLMediaElement.h: Ditto.
      * WebCore.exp.in: Modify the exports list to reflect the new symbol name.
      
      WebCore: Implement WebKit Full Screen support.
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
      Reviewed by Simon Fraser.
      
      The RenderFullScreen is intended to be used by clients of that API to allow a DOM subtree to
      be rendered outside its original Frame. Because of this, there are a few areas of the
      rendering code which need to be special cased: RenderFullScreen layers should not be clipped
      to the viewport, as they will almost always be rendering outside the viewport area;
      RenderFullScreen graphics layers should not be reparented by the RenderLayerCompositor, as
      the client will likely want to reparent the platformLayer into their own fullscreen platform
      window; the FrameView must update the RenderFullScreen graphics layer tree separately from
      the root layer, as the two trees are disconnected.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::updateCompositingLayers):  Special treatment for fullscreen renderer.
      (WebCore::FrameView::syncCompositingStateRecursive): Ditto.
      (WebCore::FrameView::paintContents): Ditto.
      * rendering/RenderLayer.h: Add a new ContentChangeType enum entry for FullScreen.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::contentChanged): Add support for above.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::layerOrAncestorIsFullScreen): New function.
      (WebCore::RenderLayerBacking::updateCompositedBounds): Do not clip if the layerOrAncestorIsFullScreen.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Special treatment for fullscreen renderer.
      (WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
      (WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.
      * rendering/RenderLayerCompositor.h:
      
      WebCore: Implement WebKit Full Screen support.
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
      Reviewed by Simon Fraser.
      
      Implemented non-accelerated fullscreen support.  The Document will now vend a RenderFullScreen object for clients to
      use to relocate the fullscreen element subtree.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::loadFullScreenRulesIfNeeded): Change webkitFullScreen -> webkitIsFullScreen.
      (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
      * dom/Document.cpp:
      (WebCore::Document::Document): Initialize m_fullScreenRenderer.
      (WebCore::Document::detach): Call setFullScreenRenderer(0).
      (WebCore::Document::nodeWillBeRemoved): Replicate the logic in webkitWillEnterFullScreenForElement.
      (WebCore::Document::webkitWillEnterFullScreenForElement):  Detach the fullscreen element to cause
          a new RenderFullScreen renderer to be created with the new fullscreen element.
      (WebCore::Document::webkitDidEnterFullScreenForElement):  Notify clients of a fullscreen change
          here, rather in "willEnter", to avoid reentrancy problems when clients remove nodes in response
          to webkitfullscreenchange events.
      (WebCore::Document::webkitWillExitFullScreenForElement): Recalculate the fullscreen element's style.
      (WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
      (WebCore::Document::setFullScreenRenderer): Accessor for m_fullScreenRenderer.
      (WebCore::Document::setFullScreenRendererSize): Set the style on the m_fullScreenRenderer with a new
          size; this keeps clients from having to access the renderer's style directly.
      (WebCore::Document::setFullScreenRendererBackgroundColor): Ditto.
      * dom/Document.h:
      (WebCore::Document::webkitIsFullScreen): Change webkitFullScreen -> webkitIsFullScreen.
      (WebCore::Document::fullScreenRenderer): Accessor.
      * dom/Document.idl:
      * dom/Node.cpp:
      (WebCore::Node::createRendererIfNeeded): If the document is in fullscreen mode, create a RenderFullScreen
          object to insert between the fullscreen element and its parent.
      * page/ChromeClient.h:
      (WebCore::ChromeClient::fullScreenRendererChanged): Added.
      * rendering/MediaControlElements.cpp:
      (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Change webkitFullScreen -> webkitIsFullScreen.
      
      WebCore: Implement WebKit Full Screen support.
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
      Reviewed by Simon Fraser.
      
      This patch introduces a new RenderObject type: RenderFullScreen.  The RenderFullScreen renderer
      will be used to implement new FullScreen APIs.  Because the RenderFullScreen object will be the
      parent of the current fullscreen element, the style rules for fullscreen objects must change to
      match.
      
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/RenderFullScreen.cpp: Added.
      (RenderFullScreen::setAnimating): Sets the m_isAnimating flag.
      (RenderFullScreen::createFullScreenStyle): Returns a new RenderStyle containing the default stye
          for RenderFullScreen objects.
      * rendering/RenderFullScreen.h: Added.
      (WebCore::RenderFullScreen::isRenderFullScreen): Added.  Overrides the RenderObject version.
      * rendering/RenderObject.h:
      (WebCore::RenderObject::isRenderFullScreen): Added.  Used for type-checking RenderFullScreen objects.
      * css/fullscreen.css:  Modified the contained fullscreen styles.
      
      WebKit/mac: Implement WebKit Full Screen support.
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
      Reviewed by Simon Fraser.
      
      Support the new fullscreen Chrome client requests.  WebView will pass
      through these requests to a WebFullscreenController.
      
      * WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
      * WebView/WebView.mm:
      (-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
      (-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
      (-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
      (-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.
      * WebView/WebViewData.h: Add ivar newFullscreenController.
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
      Reviewed by Simon Fraser.
      
      This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
      Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
      window, and a custom CAAnimation animates that layer between the initial screen rect of the
      full screen element, to its final value. WebFullscreenController will swap the WebView out of
      its original window, and into the fullscreen window. The controller will replace the WebView
      with a placeholder view, so that if the placeholder moves or resized while the WebView is
      absent, the WebView will move back to the correct location when exiting fullscreen.
      
      * WebView/WebFullscreenController.h: Added.
      * WebView/WebFullscreenController.mm: Added.
      (-[WebFullscreenController windowDidExitFullscreen:]):  Close the fullscreen window.
      (-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
      (-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
      (-[WebFullscreenController applicationDidResignActive:]):
      (-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match
          the new screen parameters.
      (-[WebFullscreenController enterFullscreen:]):  Set up the animation that will take the fullscreen element
          from its original screen rect into fullscreen.
      (-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.
          Set up the animation that will take the fullscreen element back into its original screen
          rect.
      (-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine
          whether to disable screensaver and sleep.
      (-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element
          looking for HTMLVideoElements; returns whether any are found to be playing.
      (-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control
          and shift keys.
      (-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
      (-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
      (-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
      (-[WebFullscreenWindow rendererLayer]): Convenience accessor.
      (-[WebFullscreenWindow setRendererLayer:]): Ditto.
      (-[WebFullscreenWindow backgroundLayer]): Ditto.
      (-[WebFullscreenWindow animationView]): Ditto.
      (MediaEventListener::MediaEventListener): Implements the EventListener protocol.
      (MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.
      
      LayoutTests: Implement WebKit Full Screen support.
      https://bugs.webkit.org/show_bug.cgi?id=49481
      rdar://problem/8247444
      
      Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
      Reviewed by Simon Fraser.
      
      Update the tests with new API names and spec values.
      
      * fullscreen/full-screen-api-expected.txt:
      * fullscreen/full-screen-api.html:
      * fullscreen/full-screen-css.html:
      * fullscreen/full-screen-request-expected.txt:
      * fullscreen/full-screen-request.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9d59ff9
    • jamesr@google.com's avatar
      2011-01-07 James Robinson <jamesr@chromium.org> · f894f68c
      jamesr@google.com authored
              Revert "Implement mozilla's animationTime property"
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              This approach isn't quite right.
      
              * animations/animation-time-expected.txt: Removed.
              * animations/animation-time.html: Removed.
              * animations/script-tests/animation-time.js: Removed.
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/Window/window-property-descriptors-expected.txt:
              * platform/gtk/fast/dom/Window/window-properties-expected.txt:
              * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
              * platform/qt/fast/dom/Window/window-properties-expected.txt:
              * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
              * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      2011-01-07  James Robinson  <jamesr@chromium.org>
      
              Revert "Implement mozilla's animationTime property"
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              This approach isn't quite right.
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::paintInvalidatedRegion):
      2011-01-07  James Robinson  <jamesr@chromium.org>
      
              Revert "Implement mozilla's animationTime property"
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              This approach isn't quite right.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * page/DOMWindow.cpp:
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * page/Frame.cpp:
              * page/Frame.h:
              * page/Page.cpp:
              (WebCore::Page::Page):
              * page/Page.h:
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
              * page/animation/AnimationTimeController.cpp: Removed.
              * page/animation/AnimationTimeController.h: Removed.
      2011-01-07  James Robinson  <jamesr@chromium.org>
      
              Revert "Implement mozilla's animationTime property"
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              This approach isn't quite right.
      
              * public/WebWidget.h:
              * src/WebPopupMenuImpl.cpp:
              * src/WebPopupMenuImpl.h:
              * src/WebViewImpl.cpp:
              * src/WebViewImpl.h:
      2011-01-07  James Robinson  <jamesr@chromium.org>
      
              Revert "Implement mozilla's animationTime property"
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              This approach isn't quite right.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView drawRect:]):
              * WebView/WebView.mm:
              (layerSyncRunLoopObserverCallBack):
      2011-01-07  James Robinson  <jamesr@chromium.org>
      
              Revert "Implement mozilla's animationTime property"
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              This approach isn't quite right.
      
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
              (WebKit::ChunkedUpdateDrawingArea::display):
              (WebKit::ChunkedUpdateDrawingArea::setSize):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::drawRect):
              * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
              (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f894f68c
    • enne@google.com's avatar
      2011-01-05 Adrienne Walker <enne@google.com> · a3de32ec
      enne@google.com authored
              Reviewed by Kenneth Russell.
      
              Add tests for WebGL's lost context events.
              https://bugs.webkit.org/show_bug.cgi?id=51492
      
              * fast/canvas/webgl/context-lost-expected.txt: Added.
              * fast/canvas/webgl/context-lost-restored-expected.txt: Added.
              * fast/canvas/webgl/context-lost-restored.html: Added.
              * fast/canvas/webgl/context-lost.html: Added.
      2011-01-05  Adrienne Walker  <enne@google.com>
      
              Reviewed by Kenneth Russell.
      
              Add WEBKIT_lose_context WebGL extension.
              https://bugs.webkit.org/show_bug.cgi?id=51492
      
              Tests: fast/canvas/webgl/context-lost-restored.html
                     fast/canvas/webgl/context-lost.html
      
              * CMakeLists.txt:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSWebGLRenderingContextCustom.cpp:
              (WebCore::toJS):
              (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::toV8Object):
              (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
              * html/canvas/WebGLExtension.h:
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired):
              (WebCore::WebGLRenderingContext::getExtension):
              (WebCore::WebGLRenderingContext::getSupportedExtensions):
              (WebCore::WebGLRenderingContext::forceLostContext):
              (WebCore::WebGLRenderingContext::onLostContext):
              (WebCore::WebGLRenderingContext::getNumberOfExtensions):
              (WebCore::WebGLRenderingContext::getExtensionNumber):
              * html/canvas/WebGLRenderingContext.h:
              * html/canvas/WebKitLoseContext.cpp: Copied from WebCore/html/canvas/WebGLExtension.h.
              (WebCore::WebKitLoseContext::WebKitLoseContext):
              (WebCore::WebKitLoseContext::~WebKitLoseContext):
              (WebCore::WebKitLoseContext::getName):
              (WebCore::WebKitLoseContext::create):
              (WebCore::WebKitLoseContext::loseContext):
              * html/canvas/WebKitLoseContext.h: Copied from WebCore/html/canvas/WebGLExtension.h.
              * html/canvas/WebKitLoseContext.idl: Copied from WebCore/html/canvas/WebGLExtension.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3de32ec
    • cmarrin@apple.com's avatar
      2011-01-07 Chris Marrin <cmarrin@apple.com> · 14a3dcfb
      cmarrin@apple.com authored
              Rubber-stamped by Simon Fraser.
      
              Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
              https://bugs.webkit.org/show_bug.cgi?id=49388
      
              Final step in unifying GraphicsLayer logic across Win and Mac. This 
              implements the Windows side classes for PlatformCALayer and supporting
              classes. Also changed MediaPlayer to use new PlatformCALayerClient
              so it can use PlatformCALayer directly rather than a dummy GraphicsLayer.
              WKCACFLayerRenderer now does the task of notifying animations of their
              start time. Also commented out an assert in AnimationBase because
              AnimationController's frame time is not in sync with the new 
              AnimationTimeController. I've opened a new bug for that issue:
      
                  https://bugs.webkit.org/show_bug.cgi?id=52037
                  
              This also includes the Mac side changes backed out in 
              http://trac.webkit.org/changeset/75227.
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14a3dcfb
  6. 06 Jan, 2011 3 commits
    • cmarrin@apple.com's avatar
      2011-01-06 Chris Marrin <cmarrin@apple.com> · 06a44e06
      cmarrin@apple.com authored
              Unreviewed.
      
              Back out changes in http://trac.webkit.org/changeset/75199
              This breaks the Windows build. Fixing it on that side. Until
              then I'll back this out.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06a44e06
    • cmarrin@apple.com's avatar
      2011-01-06 Chris Marrin <cmarrin@apple.com> · aadf23f4
      cmarrin@apple.com authored
              Reviewed by Simon Fraser.
      
              Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
              https://bugs.webkit.org/show_bug.cgi?id=49388
      
              Changed PlatformCALayer API. Added PlatformCALayerClient abstract class which is
              used to communicate from PlatformCALayer to the owner. This replaces passing
              GraphicsLayerCA pointer when creating PlatformCALayer. It also includes the
              API that used to be in PlatformCALayerLayout. GraphicsLayerCA now implements
              the PlatformCALayerClient API.
      
              This change has little impact on the Mac side but makes the Windows
              interface simpler, especially when handling video layers on Windows.
      
              * WebCore.xcodeproj/project.pbxproj:
              * config.h:
              * platform/graphics/GraphicsLayer.h:
              (WebCore::GraphicsLayer::layerDidDisplay):
              (WebCore::GraphicsLayer::showDebugBorders):
              (WebCore::GraphicsLayer::showRepaintCounter):
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
              (WebCore::GraphicsLayerCA::setContentsToImage):
              (WebCore::GraphicsLayerCA::setContentsToMedia):
              (WebCore::GraphicsLayerCA::layerDidDisplay):
              (WebCore::GraphicsLayerCA::updateSublayerList):
              * platform/graphics/ca/GraphicsLayerCA.h:
              (WebCore::GraphicsLayerCA::platformCALayerLayoutSublayersOfLayer):
              (WebCore::GraphicsLayerCA::platformCALayerRespondsToLayoutChanges):
              (WebCore::GraphicsLayerCA::platformCALayerContentsOrientation):
              (WebCore::GraphicsLayerCA::platformCALayerPaintContents):
              (WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders):
              (WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
              (WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount):
              (WebCore::GraphicsLayerCA::platformCALayerContentsOpaque):
              (WebCore::GraphicsLayerCA::platformCALayerDrawsContent):
              (WebCore::GraphicsLayerCA::platformCALayerLayerDidDisplay):
              (WebCore::GraphicsLayerCA::platformCALayer):
              * platform/graphics/ca/PlatformCALayer.h:
              (WebCore::PlatformCALayer::owner):
              (WebCore::PlatformCALayer::animationStarted):
              * platform/graphics/ca/PlatformCALayerClient.h: Added.
              (WebCore::PlatformCALayerClient::~PlatformCALayerClient):
              * platform/graphics/ca/mac/PlatformCALayerMac.mm:
              (PlatformCALayer::setOwner):
              (PlatformCALayer::create):
              (PlatformCALayer::PlatformCALayer):
              (PlatformCALayer::contents):
              (PlatformCALayer::setContents):
              * platform/graphics/mac/WebGLLayer.mm:
              (-[WebGLLayer display]):
              * platform/graphics/mac/WebLayer.h:
              * platform/graphics/mac/WebLayer.mm:
              (drawLayerContents):
              (setLayerNeedsDisplayInRect):
              (-[WebLayer setNeedsDisplay]):
              (-[WebLayer display]):
              * platform/graphics/mac/WebTiledLayer.mm:
              (-[WebTiledLayer setNeedsDisplay]):
              (-[WebTiledLayer display]):
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::showDebugBorders):
              (WebCore::RenderLayerBacking::showRepaintCounter):
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
              * rendering/RenderLayerCompositor.h:
              (WebCore::RenderLayerCompositor::compositorShowDebugBorders):
              (WebCore::RenderLayerCompositor::compositorShowRepaintCounter):
              (WebCore::RenderLayerCompositor::notifyAnimationStarted):
              (WebCore::RenderLayerCompositor::notifySyncRequired):
              (WebCore::RenderLayerCompositor::paintContents):
              (WebCore::RenderLayerCompositor::showDebugBorders):
              (WebCore::RenderLayerCompositor::showRepaintCounter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aadf23f4
    • jamesr@google.com's avatar
      2011-01-06 James Robinson <jamesr@chromium.org> · c0dca2a1
      jamesr@google.com authored
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Tests for window.webkitAnimationTime.
      
              * animations/animation-time-expected.txt: Added.
              * animations/animation-time.html: Added.
              * animations/script-tests/animation-time.js: Added.
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Chromium DRT support for webkitAnimationTime.
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (WebViewHost::paintInvalidatedRegion):
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Implements mozilla's animationTime property as described here:
              https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
              and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
              The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
              This property exposes a notion of a 'current' time to use for declarative animations and allows
              scripts to synchronize imperative animations with declarative ones if they choose to.  Once queried
              this time is saved and used for all declarative animation updates until the embedder paints/composites
              the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
              if the page is in a background tab).
      
              This patch also ensures that all declarative animations started in the same script execution block
              are synchronized even if some time elapses while script is running.
      
              Test: fast/animation/animation-time.html
      
              * WebCore.gypi:
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::webkitAnimationTime):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * page/Frame.cpp:
              (WebCore::Frame::currentAnimationTime):
              * page/Frame.h:
              * page/Page.cpp:
              (WebCore::Page::Page):
              * page/Page.h:
              (WebCore::Page::animationTime):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
              * page/animation/AnimationTimeController.cpp: Added.
              (WebCore::AnimationTimeController::AnimationTimeController):
              (WebCore::AnimationTimeController::~AnimationTimeController):
              (WebCore::AnimationTimeController::currentAnimationTime):
              (WebCore::AnimationTimeController::clearCurrentAnimationTime):
              (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
              * page/animation/AnimationTimeController.h: Added.
              (WebCore::AnimationTimeController::create):
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              WebKit API support for webkitAnimationTime.
      
              * public/WebWidget.h:
              * src/WebPopupMenuImpl.cpp:
              (WebKit::WebPopupMenuImpl::clearCurrentAnimationTime):
              * src/WebPopupMenuImpl.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::clearCurrentAnimationTime):
              * src/WebViewImpl.h:
      2011-01-06  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Implement mozilla's animationTime property
              https://bugs.webkit.org/show_bug.cgi?id=51952
      
              Tells the page to clear the current animation time after producing a frame.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::drawRect):
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
              (WebKit::ChunkedUpdateDrawingArea::display):
              (WebKit::ChunkedUpdateDrawingArea::setSize):
              * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
              (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0dca2a1
  7. 05 Jan, 2011 1 commit
    • psolanki@apple.com's avatar
      2011-01-05 Pratik Solanki <psolanki@apple.com> · a6928aa1
      psolanki@apple.com authored
              Reviewed by Darin Adler.
      
              Merge cf and mac header files with same name
              https://bugs.webkit.org/show_bug.cgi?id=51916
      
              Since most of the code in the header files is identical, we can merge them and have #if
              USE(CFNETWORK) to separate out the network specific parts.
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/cf/AuthenticationChallenge.h:
              (WebCore::AuthenticationChallenge::sender):
              (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
              * platform/network/cf/ResourceError.h:
              (WebCore::ResourceError::ResourceError):
              * platform/network/cf/ResourceRequest.h:
              (WebCore::ResourceRequest::ResourceRequest):
              * platform/network/cf/ResourceResponse.h:
              (WebCore::ResourceResponse::ResourceResponse):
              * platform/network/mac/AuthenticationChallenge.h: Removed.
              * platform/network/mac/ResourceError.h: Removed.
              * platform/network/mac/ResourceRequest.h: Removed.
              * platform/network/mac/ResourceResponse.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6928aa1
  8. 04 Jan, 2011 2 commits
    • cfleizach@apple.com's avatar
      WK2: Support Accessibility · aa50410b
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=51859
      
      Reviewed by Sam Weinig.
      
      Tools: 
      
      Use rootObject() method to get top of accessibility tree.
      
      * DumpRenderTree/mac/AccessibilityControllerMac.mm:
      (AccessibilityController::focusedElement):
      (AccessibilityController::rootElement):
      
      WebCore: 
      
      WK2 doesn't use platform scroll views anymore. Accessibility code
      needs to have its own scroll views. 
      
      Test: platform/mac/accessibility/webkit-scrollarea.html
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::AXObjectCache):
      (WebCore::AXObjectCache::get):
      (WebCore::AXObjectCache::getOrCreate):
      (WebCore::AXObjectCache::rootObject):
      (WebCore::AXObjectCache::remove):
      (WebCore::AXObjectCache::handleScrollbarUpdate):
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::handleScrollbarUpdate):
      * accessibility/AccessibilityARIAGrid.h:
      * accessibility/AccessibilityAllInOne.cpp:
      * accessibility/AccessibilityImageMapLink.cpp:
      * accessibility/AccessibilityImageMapLink.h:
      * accessibility/AccessibilityListBoxOption.cpp:
      * accessibility/AccessibilityListBoxOption.h:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityObject::elementAccessibilityHitTest):
      (WebCore::AccessibilityObject::axObjectCache):
      (WebCore::AccessibilityObject::focusedUIElement):
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::isAccessibilityScrollView):
      (WebCore::AccessibilityObject::isScrollView):
      (WebCore::AccessibilityObject::canSetNumericValue):
      (WebCore::AccessibilityObject::scrollBar):
      (WebCore::AccessibilityObject::size):
      (WebCore::AccessibilityObject::setValue):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::parentObject):
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      (WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
      (WebCore::AccessibilityRenderObject::addChildren):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/AccessibilityScrollView.cpp: Added.
      (WebCore::AccessibilityScrollView::AccessibilityScrollView):
      (WebCore::AccessibilityScrollView::create):
      (WebCore::AccessibilityScrollView::scrollBar):
      (WebCore::AccessibilityScrollView::children):
      (WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
      (WebCore::AccessibilityScrollView::removeChildScrollbar):
      (WebCore::AccessibilityScrollView::addChildScrollbar):
      (WebCore::AccessibilityScrollView::addChildren):
      (WebCore::AccessibilityScrollView::webAreaObject):
      (WebCore::AccessibilityScrollView::accessibilityHitTest):
      (WebCore::AccessibilityScrollView::document):
      (WebCore::AccessibilityScrollView::elementRect):
      (WebCore::AccessibilityScrollView::parentObject):
      * accessibility/AccessibilityScrollView.h: Added.
      (WebCore::AccessibilityScrollView::roleValue):
      (WebCore::AccessibilityScrollView::scrollView):
      (WebCore::AccessibilityScrollView::accessibilityIsIgnored):
      (WebCore::AccessibilityScrollView::isAccessibilityScrollView):
      (WebCore::toAccessibilityScrollView):
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
      (WebCore::AccessibilityScrollbar::create):
      (WebCore::AccessibilityScrollbar::elementRect):
      (WebCore::AccessibilityScrollbar::document):
      (WebCore::AccessibilityScrollbar::orientation):
      (WebCore::AccessibilityScrollbar::isEnabled):
      (WebCore::AccessibilityScrollbar::valueForRange):
      (WebCore::AccessibilityScrollbar::setValue):
      * accessibility/AccessibilityScrollbar.h:
      (WebCore::AccessibilityScrollbar::setParent):
      (WebCore::AccessibilityScrollbar::canSetValueAttribute):
      (WebCore::AccessibilityScrollbar::canSetNumericValue):
      (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
      (WebCore::AccessibilityScrollbar::parentObject):
      (WebCore::AccessibilityScrollbar::roleValue):
      * accessibility/mac/AccessibilityObjectMac.mm:
      (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
      (-[AccessibilityObjectWrapper position]):
      (-[AccessibilityObjectWrapper scrollViewParent]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilityHitTest:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      * dom/Document.cpp:
      (WebCore::Document::axObjectCache):
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):
      * loader/FrameLoaderClient.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::~FrameView):
      (WebCore::FrameView::axObjectCache):
      * page/FrameView.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::setHasHorizontalScrollbar):
      (WebCore::ScrollView::setHasVerticalScrollbar):
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::~Scrollbar):
      (WebCore::Scrollbar::scroll):
      (WebCore::Scrollbar::axObjectCache):
      * platform/Scrollbar.h:
      * platform/Widget.h:
      (WebCore::Widget::axObjectCache):
      
      WebKit/gtk: 
      
      Use rootObject() method to get top of ax tree.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_get_accessible):
      
      WebKit/mac: 
      
      Use rootObject() method to get top of AX tree.
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient::accessibilityRemoteObject):
      * WebView/WebFrame.mm:
      (-[WebFrame setAccessibleName:]):
      (-[WebFrame accessibilityRoot]):
      * WebView/WebFrameInternal.h:
      * WebView/WebFramePrivate.h:
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView accessibilityAttributeValue:]):
      (-[WebHTMLView accessibilityFocusedUIElement]):
      (-[WebHTMLView accessibilityHitTest:]):
      (-[WebHTMLView _accessibilityParentForSubview:]):
      
      WebKit/win: 
      
      Use rootObject() method to get the top of the AX tree.
      
      * AccessibleDocument.cpp:
      (AccessibleDocument::AccessibleDocument):
      
      WebKit2: 
      
      Implement remote accessibility API to support cross process accessibility
      on the Mac platform.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::accessibilityChildTokenReceived):
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView _updateWindowAndViewFrames]):
      (-[WKView _setAccessibilityChildToken:]):
      (-[WKView accessibilityIsIgnored]):
      (-[WKView accessibilityHitTest:]):
      (-[WKView accessibilityAttributeValue:]):
      * UIProcess/API/mac/WKViewInternal.h:
      * UIProcess/PageClient.h:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::ensureWebProcess):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::windowAndViewFramesChanged):
      (WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
      (WebKit::WebPageProxy::sendAccessibilityPresenterToken):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::accessibilityRemoteObject):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::windowAndViewFramesChanged):
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::accessibilityPosition):
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
      * WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.
      (-[AccessibilityWebPageObject setWebPage:]):
      (-[AccessibilityWebPageObject setRemoteParent:]):
      (-[AccessibilityWebPageObject dealloc]):
      (-[AccessibilityWebPageObject accessibilityIsIgnored]):
      (-[AccessibilityWebPageObject accessibilityAttributeNames]):
      (-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
      (-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
      (-[AccessibilityWebPageObject accessibilityActionNames]):
      (-[AccessibilityWebPageObject accessibilityChildren]):
      (-[AccessibilityWebPageObject accessibilityAttributeValue:]):
      (-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
      (-[AccessibilityWebPageObject accessibilityHitTest:]):
      (-[AccessibilityWebPageObject accessibilityFocusedUIElement]):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformInitialize):
      (WebKit::WebPage::sendAccessibilityPresenterToken):
      (WebKit::WebPage::accessibilityRemoteObject):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      * WebProcess/WebProcess.h:
      (WebKit::WebProcess::presenterApplicationPid):
      * WebProcess/mac/WebProcessMainMac.mm:
      (WebKit::WebProcessMain):
      
      LayoutTests: 
      
      * platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
      * platform/mac/accessibility/webkit-scrollarea.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa50410b
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network · 48297651
      ddkilzer@apple.com authored
      Reviewed by Antti Koivisto.
      
      This is needed to prevent a WebCore/platform policy violation in
      my next patch.
      
      * WebCore.gypi: Updated for moved header.
      * WebCore.pro: Ditto.
      * WebCore.vcproj/WebCore.vcproj: Ditto.
      * WebCore.xcodeproj/project.pbxproj: Ditto.
      * platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48297651
  9. 03 Jan, 2011 1 commit
    • psolanki@apple.com's avatar
      2011-01-03 Pratik Solanki <psolanki@apple.com> · 8ca237bb
      psolanki@apple.com authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=51850
              Put CFNetwork loader code inside USE(CFNETWORK)
      
              Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
              files to the WebCore Xcode project.
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/cf/ResourceLoaderCFNet.cpp:
              * loader/mac/ResourceLoaderMac.mm:
              * platform/network/cf/AuthenticationCF.cpp:
              * platform/network/cf/AuthenticationCF.h:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/CookieStorageCFNet.cpp:
              * platform/network/cf/CookieStorageCFNet.h:
              * platform/network/cf/CredentialStorageCFNet.cpp:
              * platform/network/cf/FormDataStreamCFNet.cpp:
              * platform/network/cf/FormDataStreamCFNet.h:
              * platform/network/cf/LoaderRunLoopCF.cpp:
              * platform/network/cf/LoaderRunLoopCF.h:
              * platform/network/cf/ResourceError.h:
              * platform/network/cf/ResourceHandleCFNet.cpp:
              * platform/network/cf/ResourceRequest.h:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.h:
              * platform/network/cf/ResourceResponse.h:
              * platform/network/cf/ResourceResponseCFNet.cpp:
              * platform/network/mac/AuthenticationMac.h:
              * platform/network/mac/AuthenticationMac.mm:
              * platform/network/mac/FormDataStreamMac.h:
              * platform/network/mac/FormDataStreamMac.mm:
              * platform/network/mac/ResourceError.h:
              * platform/network/mac/ResourceHandleMac.mm:
              * platform/network/mac/ResourceRequest.h:
              * platform/network/mac/ResourceRequestMac.mm:
              * platform/network/mac/ResourceResponse.h:
              * platform/network/mac/ResourceResponseMac.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ca237bb
  10. 01 Jan, 2011 3 commits
  11. 31 Dec, 2010 1 commit
  12. 30 Dec, 2010 4 commits
    • antti@apple.com's avatar
      Not reviewed. · 2a97615d
      antti@apple.com authored
      Revert accidental project file change.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a97615d
    • antti@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=51134 · f73108e2
      antti@apple.com authored
      Move loading related code from MemoryCache to CachedResourceLoader
      
      Reviewed by Darin Adler.
      
      - Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
      - Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
      - Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
      - Add MemoryCache::add
      - Refactor the decision on whether to reload, revalidate or use the existing resource to 
        a single function, CachedResourceLoader::determineRevalidationPolicy
      
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::cachedImage):
                  
          Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
          if ever taken (since it passes null CachedResourceLoader pointer).
                  
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::updateFromElement):
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::CachedResource):
      (WebCore::CachedResource::~CachedResource):
      (WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
              
          Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.
              
      (WebCore::CachedResource::setLoadPriority):
              
          Check for Unresolved value before setting.
              
      * loader/cache/CachedResource.h:
      (WebCore::CachedResource::setOwningCachedResourceLoader):
              
          Rename to be bit less mysterious.
              
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::createResource):
              
          This was moved from MemoryCache.
              
      (WebCore::CachedResourceLoader::~CachedResourceLoader):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
              
          This was moved/merged from MemoryCache.
              
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::requestResource):
              
          This combines MemoryCache::requestResource and the existing method.
              
      (WebCore::CachedResourceLoader::revalidateResource):
              
          This was moved from MemoryCache.
              
      (WebCore::CachedResourceLoader::loadResource):
              
          New method for initiating loading.
              
      (WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):
              
          Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus
              
      * loader/cache/CachedResourceLoader.h:
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::add):
      * loader/cache/MemoryCache.h:
      (WebCore::MemoryCache::remove):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f73108e2
    • darin@apple.com's avatar
      2010-12-30 Darin Adler <darin@apple.com> · 7fa6b382
      darin@apple.com authored
              Reviewed by Adam Barth.
      
              Move security logic out of the JavaScript binding for location into the DOM class
              https://bugs.webkit.org/show_bug.cgi?id=51714
      
              * WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h,
              and JSBinding.h. Later, we'll remove them from other project files and delete
              the source files.
      
              * bindings/js/JSBinding.h: Emptied out, marked for later deletion.
      
              * bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull
              function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL
              function, unused toLexicalFrame function, unused completeURL function, unused
              getCachedDOMStructure and cacheDOMStructure overloads, and unused
              getCachedDOMConstructor and cacheDOMConstruction functions.
              (WebCore::activeDOMWindow): Added.
              (WebCore::firstDOMWindow): Added.
              (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through
              JSBindingState, since the latter is an unneeded abstraction.
              (WebCore::processingUserGesture): Changed to call ScriptController's function
              rather than calling through JSBindingState, which is an unneeded abstraction
      
              * bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added
              activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly
              named allowsAccessFromFrame functions, which answer the question of whether
              script is allowed access *to* a frame.
      
              * bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes.
              (WebCore::JSDOMWindow::setLocation): Streamlined by using the new
              activeDOMWindow and firstDOMWindow functions.
              (WebCore::JSDOMWindow::open): Ditto.
              (WebCore::JSDOMWindow::showModalDialog): Ditto.
              (WebCore::JSDOMWindow::postMessage): Ditto.
      
              * bindings/js/JSLocationCustom.cpp:
              (WebCore::JSLocation::setHref): Changed to pass the active and first windows through
              to the Location::setHref function, with it doing the rest of the work. This moves
              work out of the DOM binding that belongs in the DOM itself. Eventually such functions
              could even be automatically generated by the bindings script.
              (WebCore::JSLocation::setProtocol): Ditto.
              (WebCore::JSLocation::setHost): Ditto.
              (WebCore::JSLocation::setHostname): Ditto.
              (WebCore::JSLocation::setPort): Ditto.
              (WebCore::JSLocation::setPathname): Ditto.
              (WebCore::JSLocation::setSearch): Ditto.
              (WebCore::JSLocation::setHash): Ditto.
              (WebCore::JSLocation::replace): Ditto.
              (WebCore::JSLocation::reload): Ditto.
              (WebCore::JSLocation::assign): Ditto.
      
              * bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
              * bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us
              to use this function for Location::replace, which is the same as setLocation except that
              it locks both history and the back/forward list.
              * page/DOMWindow.h: Ditto.
      
              * page/Location.cpp:
              (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security
              logic there does not have to be repeated or even refactored.
              (WebCore::Location::setProtocol): Ditto.
              (WebCore::Location::setHost): Ditto.
              (WebCore::Location::setHostname): Ditto.
              (WebCore::Location::setPort): Ditto.
              (WebCore::Location::setPathname): Ditto.
              (WebCore::Location::setSearch): Ditto.
              (WebCore::Location::setHash): Ditto.
              (WebCore::Location::assign): Ditto.
              (WebCore::Location::replace): Ditto.
              (WebCore::Location::reload): Added. Security logic was refactored from the code in
              JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems
              possibly unneeded.
      
              * page/Location.h: Fixed indentation on the whole file. Added the new functions above.
              (WebCore::Location::create):
              (WebCore::Location::frame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa6b382
    • pfeldman@chromium.org's avatar
      2010-12-29 Pavel Feldman <pfeldman@chromium.org> · 075ed242
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
              https://bugs.webkit.org/show_bug.cgi?id=51707
      
              This change brushes up storage agents + removes redundant InspectorBackend class.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::databaseForId):
              (WebCore::InjectedScriptHost::selectDatabase):
              (WebCore::InjectedScriptHost::selectDOMStorage):
              (WebCore::InjectedScriptHost::inspectorDOMAgent):
              * inspector/Inspector.idl:
              * inspector/InspectorBackend.cpp: Removed.
              * inspector/InspectorBackend.h: Removed.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::releaseFrontendLifetimeAgents):
              (WebCore::InspectorController::didUseDOMStorage):
              (WebCore::InspectorController::setInjectedScriptSource):
              (WebCore::InspectorController::dispatchOnInjectedScript):
              (WebCore::InspectorController::releaseWrapperObjectGroup):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMStorageAgent.cpp: Added.
              (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
              (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
              (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
              * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
              (WebCore::InspectorDOMStorageAgent::create):
              (WebCore::InspectorDOMStorageAgent::frontend):
              * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
              (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
              (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
              (WebCore::InspectorDatabaseAgent::executeSQL):
              (WebCore::InspectorDatabaseAgent::databaseForId):
              (WebCore::InspectorDatabaseAgent::selectDatabase):
              (WebCore::InspectorDatabaseAgent::clearFrontend):
              (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
              * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
              (WebCore::InspectorDatabaseAgent::create):
              (WebCore::InspectorDatabaseAgent::frontend):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.show):
              (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075ed242
  13. 29 Dec, 2010 3 commits
    • eric@webkit.org's avatar
      2010-12-29 Eric Seidel <eric@webkit.org> · 798e1d30
      eric@webkit.org authored
              Unreviewed.
      
              Simplify make-hash-tools.pl
              https://bugs.webkit.org/show_bug.cgi?id=49922
      
              Added HashTools.h to the project file now that its not autogenerated.
              I also sorted the project file using sort-xcode-project-file
      
              * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798e1d30
    • pfeldman@chromium.org's avatar
      2010-12-29 Pavel Feldman <pfeldman@chromium.org> · 72ec867e
      pfeldman@chromium.org authored
              Not reviewed: revert r74755 and 74757.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72ec867e
    • pfeldman@chromium.org's avatar
      2010-12-29 Pavel Feldman <pfeldman@chromium.org> · 1c50cf22
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: extract Database & DOM Storage
              agents; remove InspectorBackend.
              https://bugs.webkit.org/show_bug.cgi?id=51707
      
              This change brushes up storage agents + removes redundant
              InspectorBackend class.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::databaseForId):
              (WebCore::InjectedScriptHost::selectDatabase):
              (WebCore::InjectedScriptHost::selectDOMStorage):
              (WebCore::InjectedScriptHost::inspectorDOMAgent):
              * inspector/Inspector.idl:
              * inspector/InspectorBackend.cpp: Removed.
              * inspector/InspectorBackend.h: Removed.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::~InspectorController):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::releaseFrontendLifetimeAgents):
              (WebCore::InspectorController::didUseDOMStorage):
              (WebCore::InspectorController::setInjectedScriptSource):
              (WebCore::InspectorController::dispatchOnInjectedScript):
              (WebCore::InspectorController::releaseWrapperObjectGroup):
              * inspector/InspectorController.h:
              * inspector/InspectorDOMStorageAgent.cpp: Added.
              (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
              (WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
              (WebCore::InspectorDOMStorageAgent::selectDOMStorage):
              (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
              (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
              * inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h.
              (WebCore::InspectorDOMStorageAgent::create):
              (WebCore::InspectorDOMStorageAgent::frontend):
              * inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp.
              (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
              (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
              (WebCore::InspectorDatabaseAgent::executeSQL):
              (WebCore::InspectorDatabaseAgent::databaseForId):
              (WebCore::InspectorDatabaseAgent::selectDatabase):
              (WebCore::InspectorDatabaseAgent::clearFrontend):
              (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
              * inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h.
              (WebCore::InspectorDatabaseAgent::create):
              (WebCore::InspectorDatabaseAgent::frontend):
              * inspector/InspectorFrontendClientLocal.cpp:
              * inspector/InspectorFrontendClientLocal.h:
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.show):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c50cf22
  14. 23 Dec, 2010 3 commits
    • darin@apple.com's avatar
      Try to fix crash seen on GTK bot. · 4c3ca313
      darin@apple.com authored
      * editing/EditorCommand.cpp:
      (WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.
      
      * WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c3ca313
    • jschuh@chromium.org's avatar
      2010-12-23 Justin Schuh <jschuh@chromium.org> · c70d2d68
      jschuh@chromium.org authored
              Reviewed by Eric Seidel.
      
              CSSCursorImageValue destructor should clear referenced element.
              https://bugs.webkit.org/show_bug.cgi?id=51417
      
              Calls correct method to clear image and renames method to avoid future confusion.
      
              Test: svg/css/cursor-image-replace.svg
      
              * css/CSSCursorImageValue.cpp:
              (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::cursorImageValueRemoved):
              * svg/SVGElement.h:
      2010-12-23  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Eric Seidel.
      
              CSSCursorImageValue destructor should clear referenced element.
              https://bugs.webkit.org/show_bug.cgi?id=51417
      
              * svg/css/cursor-image-replace-expected.txt: Added.
              * svg/css/cursor-image-replace.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70d2d68
    • rniwa@webkit.org's avatar
      2010-12-22 Ryosuke Niwa <rniwa@webkit.org> · bfb682fd
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Renamed SelectionController::EDirection to SelectionDirection.
      
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::executeCommand):
      2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Renamed SelectionController::EDirection to SelectionDirection.
      
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::handleKeyboardEvent):
      2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Renamed SelectionController::EDirection to SelectionDirection.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]):
              Takes SelectionDirection instead of SelectionController::EDirection.
              * WebView/WebFrameInternal.h:
              * WebView/WebTextCompletionController.mm:
              (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.
      2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Renamed SelectionController::EDirection to SelectionDirection.
      
              * WebCoreSupport/EditorClientHaiku.cpp:
              (WebCore::EditorClientHaiku::handleKeyboardEvent):
      2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Renamed SelectionController::EDirection to SelectionDirection.
      
              * WebCoreSupport/EditorClientWinCE.cpp:
              (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
      2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Renamed SelectionController::EDirection to SelectionDirection.
      
              * WebCoreSupport/EditorClientEfl.cpp:
              (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
      2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Editor.h doesn't need to include SelectionController.h
              https://bugs.webkit.org/show_bug.cgi?id=51441
      
              Removed #include <Selection.h> from Editor.h.
              Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
              to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h
      
              * WebCore.exp.in: Signature changes.
              * WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
              * editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
              * editing/Editor.cpp:
              (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection.
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
              * editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h
              and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
              * editing/EditorCommand.cpp:
              (WebCore::executeDeleteBackward): Change due to SelectionDirection.
              (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto.
              (WebCore::executeDeleteForward): Ditto.
              (WebCore::executeDeleteToBeginningOfLine): Ditto.
              (WebCore::executeDeleteToBeginningOfParagraph): Ditto.
              (WebCore::executeDeleteToEndOfLine): Ditto.
              (WebCore::executeDeleteToEndOfParagraph): Ditto.
              (WebCore::executeDeleteWordBackward): Ditto.
              (WebCore::executeDeleteWordForward): Ditto.
              (WebCore::executeForwardDelete): Ditto.
              (WebCore::executeMoveBackward): Ditto.
              (WebCore::executeMoveBackwardAndModifySelection): Ditto.
              (WebCore::executeMoveDown): Ditto.
              (WebCore::executeMoveDownAndModifySelection): Ditto.
              (WebCore::executeMoveForward): Ditto.
              (WebCore::executeMoveForwardAndModifySelection): Ditto.
              (WebCore::executeMoveLeft): Ditto.
              (WebCore::executeMoveLeftAndModifySelection): Ditto.
              (WebCore::executeMoveRight): Ditto.
              (WebCore::executeMoveRightAndModifySelection): Ditto.
              (WebCore::executeMoveToBeginningOfDocument): Ditto.
              (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto.
              (WebCore::executeMoveToBeginningOfLine): Ditto.
              (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto.
              (WebCore::executeMoveToBeginningOfParagraph): Ditto.
              (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto.
              (WebCore::executeMoveToBeginningOfSentence): Ditto.
              (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto.
              (WebCore::executeMoveToEndOfDocument): Ditto.
              (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto.
              (WebCore::executeMoveToEndOfSentence): Ditto.
              (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto.
              (WebCore::executeMoveToEndOfLine): Ditto.
              (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto.
              (WebCore::executeMoveToEndOfParagraph): Ditto.
              (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto.
              (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto.
              (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto.
              (WebCore::executeMoveUp): Ditto.
              (WebCore::executeMoveUpAndModifySelection): Ditto.
              (WebCore::executeMoveWordBackward): Ditto.
              (WebCore::executeMoveWordBackwardAndModifySelection): Ditto.
              (WebCore::executeMoveWordForward): Ditto.
              (WebCore::executeMoveWordForwardAndModifySelection): Ditto.
              (WebCore::executeMoveWordLeft): Ditto.
              (WebCore::executeMoveWordLeftAndModifySelection): Ditto.
              (WebCore::executeMoveWordRight): Ditto.
              (WebCore::executeMoveWordRightAndModifySelection): Ditto.
              (WebCore::executeMoveToLeftEndOfLine): Ditto.
              (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto.
              (WebCore::executeMoveToRightEndOfLine): Ditto.
              (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection.
              (WebCore::SelectionController::modify): Ditto.
              * editing/SelectionController.h: Change due to SelectionDirection.
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed): Ditto.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
              * editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection
              in SelectionController.h
              * editing/WritingDirection.h: Added.
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::modify): Change due to SelectionDirection.
              (WebCore::DOMSelection::deleteFromDocument): Ditto.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
              * page/Frame.h: Includes SelectionController.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfb682fd
  15. 22 Dec, 2010 1 commit
  16. 21 Dec, 2010 1 commit
    • andersca@apple.com's avatar
      2010-12-21 Anders Carlsson <andersca@apple.com> · d86d8421
      andersca@apple.com authored
              Reviewed by John Sullivan.
      
              Clicking missing plug-in text does not show a sheet
              https://bugs.webkit.org/show_bug.cgi?id=51403
      
              * WebCore.exp.in:
              Export symbols needed by WebKit2.
      
              * WebCore.xcodeproj/project.pbxproj:
              Make HTMLPlugInImageElement.h a private header.
      
              * html/HTMLPlugInImageElement.h:
              (WebCore::HTMLPlugInImageElement::serviceType):
              (WebCore::HTMLPlugInImageElement::url):
              Make these member functions public.
      2010-12-21  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by John Sullivan.
      
              Clicking missing plug-in text does not show a sheet
              https://bugs.webkit.org/show_bug.cgi?id=51403
      
              Update for changes to the WebPageUIClient.
      
              * MiniBrowser/mac/BrowserWindowController.m:
              (-[BrowserWindowController awakeFromNib]):
              * WebKitTestRunner/TestController.cpp:
              (WTR::createOtherPage):
              (WTR::TestController::initialize):
      2010-12-21  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by John Sullivan.
      
              Clicking missing plug-in text does not show a sheet
              https://bugs.webkit.org/show_bug.cgi?id=51403
      
              * UIProcess/API/C/WKPage.h:
              Add missingPluginButtonClicked to WKPageUIClient.
      
              * UIProcess/WebPageProxy.cpp:        
              (WebKit::WebPageProxy::missingPluginButtonClicked):
              Call the WebUIClient member function.
      
              * UIProcess/WebPageProxy.messages.in:
              Add MissingPluginButtonClicked message.
      
              * UIProcess/WebUIClient.cpp:
              (WebKit::WebUIClient::missingPluginButtonClicked):
              Call the WKPageUIClient callback.
      
              * UIProcess/WebUIClient.h:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::shouldMissingPluginMessageBeButton):
              Always return true for now.
      
              (WebKit::WebChromeClient::missingPluginButtonClicked):
              Send a MissingPluginButtonClicked message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d86d8421
  17. 20 Dec, 2010 1 commit