1. 13 Jan, 2011 23 commits
    • enrica@apple.com's avatar
      Source/WebCore: WebKit2: Add support for drag and drop · 9d9813d0
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52343
      <rdar://problem/7660558>
                     
      Reviewed by Darin Adler.
      
      This patch contains the changes required to support dropping content
      in WebKit on the Mac. The DragData class has been extended to provide
      additional context from the application (keyboard state, modal windows, etc.)
      as well as information of the drag pasteboard being used.
      The support for WebKit as drag source will be added with a separate patch.
      
      * WebCore.exp.in:
      * page/DragController.cpp:
      (WebCore::DragController::dragIsMove): Added DragData parameter.
      (WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
      (WebCore::DragController::concludeEditDrag): Same as above.
      * page/DragController.h: Added parameter to isCopyKeyDown.
      * page/mac/DragControllerMac.mm:
      The following methods have been modified to use the information stored
      in the DragData class.
      (WebCore::DragController::isCopyKeyDown):
      (WebCore::DragController::dragOperation):
      * platform/DragData.h:
      (WebCore::DragData::flags):
      * platform/DragData.cpp: Added default flags parameter to the constructor.
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
      (WebCore::DragData::canSmartReplace):
      (WebCore::DragData::containsColor):
      (WebCore::DragData::containsFiles):
      (WebCore::DragData::asFilenames):
      (WebCore::DragData::containsPlainText):
      (WebCore::DragData::asPlainText):
      (WebCore::DragData::containsCompatibleContent):
      (WebCore::DragData::asURL):
      (WebCore::DragData::asFragment):
      All the following files have been modified to add the DragData
      parameter to isCopyKeyDown. I plan to improve this in the future
      and make isCopyKeyDown not platform specific.
      * page/android/DragControllerAndroid.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/brew/DragControllerBrew.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/chromium/DragControllerChromium.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/efl/DragControllerEfl.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/gtk/DragControllerGtk.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/haiku/DragControllerHaiku.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/mac/DragControllerMac.mm:
      (WebCore::DragController::isCopyKeyDown):
      (WebCore::DragController::dragOperation):
      * page/qt/DragControllerQt.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/win/DragControllerWin.cpp:
      (WebCore::DragController::isCopyKeyDown):
      * page/wx/DragControllerWx.cpp:
      (WebCore::DragController::isCopyKeyDown):
      
      WebKit/mac: WebKit2: Add support for drag and drop
      https://bugs.webkit.org/show_bug.cgi?id=52343
      <rdar://problem/7660558>
              
      Reviewed by Darin Adler.
      
      The DragData class has been extended to provide
      additional context from the application (keyboard state, modal windows, etc.)
      as well as information of the drag pasteboard being used.
      These are the changes to align the behavior for WebKit.
      
      * WebView/WebView.mm:
      (-[WebView applicationFlags:]): Added.
      (-[WebView draggingEntered:]): Added parameter to the DragData constructor.
      (-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
      (-[WebView draggingExited:]): Added parameter to the DragData constructor.
      (-[WebView performDragOperation:]): Added parameter to the DragData constructor.
      
      WebKit2: WebKit2: Add support for drag and drop
      https://bugs.webkit.org/show_bug.cgi?id=52343
      <rdar://problem/7660558>
                     
      Reviewed by Darin Adler.
      
      This patch contains the changes required to support dropping content
      in WebKit on the Mac. The DragData class has been extended to provide
      additional context from the application (keyboard state, modal windows, etc.)
      as well as information of the drag pasteboard being used.
      The support for WebKit as drag source will be added with a separate patch.
      
      * Shared/DragControllerAction.h: Added.
      * UIProcess/API/mac/WKView.mm:
      Added implemention of the methods required to add suport for a drop target.
      To maintain asynchronous communication with the WebProcess, we always return
      the previous calculated value for the drag operation.
      (-[WKView _registerDraggedTypes]):
      (-[WKView initWithFrame:contextRef:pageGroupRef:]):
      (-[WKView applicationFlags:]):
      (-[WKView draggingEntered:]):
      (-[WKView draggingUpdated:]):
      (-[WKView draggingExited:]):
      (-[WKView prepareForDragOperation:]):
      (-[WKView performDragOperation:]):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      (WebKit::WebPageProxy::performDragControllerAction):
      (WebKit::WebPageProxy::didPerformDragControllerAction):
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::dragOperation):
      (WebKit::WebPageProxy::resetDragOperation):
      * UIProcess/WebPageProxy.messages.in:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebDragClient.cpp:
      (WebKit::WebDragClient::willPerformDragDestinationAction):
      (WebKit::WebDragClient::willPerformDragSourceAction):
      (WebKit::WebDragClient::actionMaskForDrag):
      (WebKit::WebDragClient::dragSourceActionMaskForPoint):
      (WebKit::WebDragClient::startDrag):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::performDragControllerAction):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d9813d0
    • ddkilzer@apple.com's avatar
      Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project · de794561
      ddkilzer@apple.com authored
      Not reviewed.
      
      * WebCore.xcodeproj/project.pbxproj: Add missing headers.  Note
      that the corresponding source files were originally added to the
      project in r48559.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de794561
    • zmo@google.com's avatar
      2011-01-12 Zhenyao Mo <zmo@google.com> · fc58bbd9
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Use GC3D types in WebGLRenderingContext and related WebGL classes
              https://bugs.webkit.org/show_bug.cgi?id=51908
      
              * html/canvas/WebGLActiveInfo.h:
              (WebCore::WebGLActiveInfo::create):
              (WebCore::WebGLActiveInfo::type):
              (WebCore::WebGLActiveInfo::size):
              (WebCore::WebGLActiveInfo::WebGLActiveInfo):
              * html/canvas/WebGLBuffer.cpp:
              (WebCore::WebGLBuffer::associateBufferDataImpl):
              (WebCore::WebGLBuffer::associateBufferData):
              (WebCore::WebGLBuffer::associateBufferSubDataImpl):
              (WebCore::WebGLBuffer::associateBufferSubData):
              (WebCore::WebGLBuffer::byteLength):
              (WebCore::WebGLBuffer::getCachedMaxIndex):
              (WebCore::WebGLBuffer::setCachedMaxIndex):
              (WebCore::WebGLBuffer::setTarget):
              * html/canvas/WebGLBuffer.h:
              (WebCore::WebGLBuffer::getTarget):
              * html/canvas/WebGLFramebuffer.cpp:
              (WebCore::WebGLFramebuffer::setAttachment):
              (WebCore::WebGLFramebuffer::getAttachment):
              (WebCore::WebGLFramebuffer::getWidth):
              (WebCore::WebGLFramebuffer::getHeight):
              (WebCore::WebGLFramebuffer::getColorBufferFormat):
              (WebCore::WebGLFramebuffer::initializeRenderbuffers):
              * html/canvas/WebGLFramebuffer.h:
              * html/canvas/WebGLProgram.cpp:
              (WebCore::WebGLProgram::cacheActiveAttribLocations):
              (WebCore::WebGLProgram::numActiveAttribLocations):
              (WebCore::WebGLProgram::getActiveAttribLocation):
              (WebCore::WebGLProgram::isUsingVertexAttrib0):
              * html/canvas/WebGLProgram.h:
              (WebCore::WebGLProgram::getLinkCount):
              * html/canvas/WebGLRenderbuffer.h:
              (WebCore::WebGLRenderbuffer::setInternalFormat):
              (WebCore::WebGLRenderbuffer::getInternalFormat):
              (WebCore::WebGLRenderbuffer::setSize):
              (WebCore::WebGLRenderbuffer::getWidth):
              (WebCore::WebGLRenderbuffer::getHeight):
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::initializeNewContext):
              (WebCore::WebGLRenderingContext::sizeInBytes):
              (WebCore::WebGLRenderingContext::activeTexture):
              (WebCore::WebGLRenderingContext::bindAttribLocation):
              (WebCore::WebGLRenderingContext::bindBuffer):
              (WebCore::WebGLRenderingContext::bindFramebuffer):
              (WebCore::WebGLRenderingContext::bindRenderbuffer):
              (WebCore::WebGLRenderingContext::bindTexture):
              (WebCore::WebGLRenderingContext::blendColor):
              (WebCore::WebGLRenderingContext::blendEquation):
              (WebCore::WebGLRenderingContext::blendEquationSeparate):
              (WebCore::WebGLRenderingContext::blendFunc):
              (WebCore::WebGLRenderingContext::blendFuncSeparate):
              (WebCore::WebGLRenderingContext::bufferData):
              (WebCore::WebGLRenderingContext::bufferSubData):
              (WebCore::WebGLRenderingContext::checkFramebufferStatus):
              (WebCore::WebGLRenderingContext::clear):
              (WebCore::WebGLRenderingContext::clearColor):
              (WebCore::WebGLRenderingContext::clearDepth):
              (WebCore::WebGLRenderingContext::clearStencil):
              (WebCore::WebGLRenderingContext::colorMask):
              (WebCore::WebGLRenderingContext::copyTexImage2D):
              (WebCore::WebGLRenderingContext::copyTexSubImage2D):
              (WebCore::WebGLRenderingContext::createShader):
              (WebCore::WebGLRenderingContext::cullFace):
              (WebCore::WebGLRenderingContext::deleteBuffer):
              (WebCore::WebGLRenderingContext::depthFunc):
              (WebCore::WebGLRenderingContext::depthMask):
              (WebCore::WebGLRenderingContext::depthRange):
              (WebCore::WebGLRenderingContext::disable):
              (WebCore::WebGLRenderingContext::disableVertexAttribArray):
              (WebCore::WebGLRenderingContext::validateElementArraySize):
              (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
              (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
              (WebCore::WebGLRenderingContext::validateRenderingState):
              (WebCore::WebGLRenderingContext::drawArrays):
              (WebCore::WebGLRenderingContext::drawElements):
              (WebCore::WebGLRenderingContext::enable):
              (WebCore::WebGLRenderingContext::enableVertexAttribArray):
              (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
              (WebCore::WebGLRenderingContext::framebufferTexture2D):
              (WebCore::WebGLRenderingContext::frontFace):
              (WebCore::WebGLRenderingContext::generateMipmap):
              (WebCore::WebGLRenderingContext::getActiveAttrib):
              (WebCore::WebGLRenderingContext::getActiveUniform):
              (WebCore::WebGLRenderingContext::getAttachedShaders):
              (WebCore::WebGLRenderingContext::getAttribLocation):
              (WebCore::WebGLRenderingContext::getBufferParameter):
              (WebCore::WebGLRenderingContext::getError):
              (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
              (WebCore::WebGLRenderingContext::getParameter):
              (WebCore::WebGLRenderingContext::getProgramParameter):
              (WebCore::WebGLRenderingContext::getRenderbufferParameter):
              (WebCore::WebGLRenderingContext::getShaderParameter):
              (WebCore::WebGLRenderingContext::getTexParameter):
              (WebCore::WebGLRenderingContext::getUniform):
              (WebCore::WebGLRenderingContext::getUniformLocation):
              (WebCore::WebGLRenderingContext::getVertexAttrib):
              (WebCore::WebGLRenderingContext::getVertexAttribOffset):
              (WebCore::WebGLRenderingContext::hint):
              (WebCore::WebGLRenderingContext::isBuffer):
              (WebCore::WebGLRenderingContext::isEnabled):
              (WebCore::WebGLRenderingContext::isFramebuffer):
              (WebCore::WebGLRenderingContext::isProgram):
              (WebCore::WebGLRenderingContext::isRenderbuffer):
              (WebCore::WebGLRenderingContext::isShader):
              (WebCore::WebGLRenderingContext::isTexture):
              (WebCore::WebGLRenderingContext::lineWidth):
              (WebCore::WebGLRenderingContext::linkProgram):
              (WebCore::WebGLRenderingContext::pixelStorei):
              (WebCore::WebGLRenderingContext::polygonOffset):
              (WebCore::WebGLRenderingContext::readPixels):
              (WebCore::WebGLRenderingContext::renderbufferStorage):
              (WebCore::WebGLRenderingContext::sampleCoverage):
              (WebCore::WebGLRenderingContext::scissor):
              (WebCore::WebGLRenderingContext::stencilFunc):
              (WebCore::WebGLRenderingContext::stencilFuncSeparate):
              (WebCore::WebGLRenderingContext::stencilMask):
              (WebCore::WebGLRenderingContext::stencilMaskSeparate):
              (WebCore::WebGLRenderingContext::stencilOp):
              (WebCore::WebGLRenderingContext::stencilOpSeparate):
              (WebCore::WebGLRenderingContext::texImage2DBase):
              (WebCore::WebGLRenderingContext::texImage2DImpl):
              (WebCore::WebGLRenderingContext::texImage2D):
              (WebCore::WebGLRenderingContext::texParameter):
              (WebCore::WebGLRenderingContext::texParameterf):
              (WebCore::WebGLRenderingContext::texParameteri):
              (WebCore::WebGLRenderingContext::texSubImage2DBase):
              (WebCore::WebGLRenderingContext::texSubImage2DImpl):
              (WebCore::WebGLRenderingContext::texSubImage2D):
              (WebCore::WebGLRenderingContext::uniform1f):
              (WebCore::WebGLRenderingContext::uniform1fv):
              (WebCore::WebGLRenderingContext::uniform1i):
              (WebCore::WebGLRenderingContext::uniform1iv):
              (WebCore::WebGLRenderingContext::uniform2f):
              (WebCore::WebGLRenderingContext::uniform2fv):
              (WebCore::WebGLRenderingContext::uniform2i):
              (WebCore::WebGLRenderingContext::uniform2iv):
              (WebCore::WebGLRenderingContext::uniform3f):
              (WebCore::WebGLRenderingContext::uniform3fv):
              (WebCore::WebGLRenderingContext::uniform3i):
              (WebCore::WebGLRenderingContext::uniform3iv):
              (WebCore::WebGLRenderingContext::uniform4f):
              (WebCore::WebGLRenderingContext::uniform4fv):
              (WebCore::WebGLRenderingContext::uniform4i):
              (WebCore::WebGLRenderingContext::uniform4iv):
              (WebCore::WebGLRenderingContext::uniformMatrix2fv):
              (WebCore::WebGLRenderingContext::uniformMatrix3fv):
              (WebCore::WebGLRenderingContext::uniformMatrix4fv):
              (WebCore::WebGLRenderingContext::vertexAttrib1f):
              (WebCore::WebGLRenderingContext::vertexAttrib1fv):
              (WebCore::WebGLRenderingContext::vertexAttrib2f):
              (WebCore::WebGLRenderingContext::vertexAttrib2fv):
              (WebCore::WebGLRenderingContext::vertexAttrib3f):
              (WebCore::WebGLRenderingContext::vertexAttrib3fv):
              (WebCore::WebGLRenderingContext::vertexAttrib4f):
              (WebCore::WebGLRenderingContext::vertexAttrib4fv):
              (WebCore::WebGLRenderingContext::vertexAttribPointer):
              (WebCore::WebGLRenderingContext::viewport):
              (WebCore::WebGLRenderingContext::getBooleanParameter):
              (WebCore::WebGLRenderingContext::getBooleanArrayParameter):
              (WebCore::WebGLRenderingContext::getFloatParameter):
              (WebCore::WebGLRenderingContext::getIntParameter):
              (WebCore::WebGLRenderingContext::getLongParameter):
              (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
              (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
              (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
              (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
              (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat):
              (WebCore::WebGLRenderingContext::validateTextureBinding):
              (WebCore::WebGLRenderingContext::validateSize):
              (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
              (WebCore::WebGLRenderingContext::validateTexFuncLevel):
              (WebCore::WebGLRenderingContext::validateTexFuncParameters):
              (WebCore::WebGLRenderingContext::validateTexFuncData):
              (WebCore::WebGLRenderingContext::validateDrawMode):
              (WebCore::WebGLRenderingContext::validateStencilFunc):
              (WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
              (WebCore::WebGLRenderingContext::validateBlendEquation):
              (WebCore::WebGLRenderingContext::validateBlendFuncFactors):
              (WebCore::WebGLRenderingContext::validateCapability):
              (WebCore::WebGLRenderingContext::validateUniformParameters):
              (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
              (WebCore::WebGLRenderingContext::validateBufferDataParameters):
              (WebCore::WebGLRenderingContext::vertexAttribfImpl):
              (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
              (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
              * html/canvas/WebGLRenderingContext.h:
              (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
              * html/canvas/WebGLShader.cpp:
              (WebCore::WebGLShader::create):
              (WebCore::WebGLShader::WebGLShader):
              * html/canvas/WebGLShader.h:
              (WebCore::WebGLShader::getType):
              * html/canvas/WebGLTexture.cpp:
              (WebCore::WebGLTexture::setTarget):
              (WebCore::WebGLTexture::setParameteri):
              (WebCore::WebGLTexture::setParameterf):
              (WebCore::WebGLTexture::setLevelInfo):
              (WebCore::WebGLTexture::generateMipmapLevelInfo):
              (WebCore::WebGLTexture::getInternalFormat):
              (WebCore::WebGLTexture::getType):
              (WebCore::WebGLTexture::getWidth):
              (WebCore::WebGLTexture::getHeight):
              (WebCore::WebGLTexture::isNPOT):
              (WebCore::WebGLTexture::mapTargetToIndex):
              (WebCore::WebGLTexture::computeLevelCount):
              (WebCore::WebGLTexture::update):
              (WebCore::WebGLTexture::getLevelInfo):
              * html/canvas/WebGLTexture.h:
              (WebCore::WebGLTexture::LevelInfo::setInfo):
              * html/canvas/WebGLUniformLocation.cpp:
              (WebCore::WebGLUniformLocation::create):
              (WebCore::WebGLUniformLocation::WebGLUniformLocation):
              (WebCore::WebGLUniformLocation::location):
              * html/canvas/WebGLUniformLocation.h:
              * platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc58bbd9
    • jianli@chromium.org's avatar
      Change createObjectURL and revokeObjectURL to put under webkitURL. · 1c19f401
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52257
      
      Reviewed by Darin Fisher.
      
      Source/WebCore:
      
      Note that we add "webkit" vendor prefix to URL that is introduced in
      the latest File API spec.
      
      For the time being, we implement webkitURL as a readonly attribute
      instead of a constructor so that we will not expose prototype property,
      as required by the spec.
      
      * Android.derived.jscbindings.mk:
      * Android.derived.v8bindings.mk:
      * Android.mk:
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pri:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * html/DOMURL.cpp: Added.
      * html/DOMURL.h: Added.
      * html/DOMURL.idl: Added.
      * inspector/front-end/NetworkPanel.js:
      * inspector/front-end/utilities.js:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::webkitURL):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::webkitURL):
      * workers/WorkerContext.h:
      * workers/WorkerContext.idl:
      
      LayoutTests:
      
      Change all related test scripts and results to account for this change.
      
      * fast/dom/Window/script-tests/window-property-descriptors.js:
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/Window/window-properties.html:
      * fast/dom/script-tests/prototype-inheritance-2.js:
      * fast/dom/script-tests/prototype-inheritance.js:
      * fast/files/apply-blob-url-to-img.html:
      * fast/files/apply-blob-url-to-xhr.html:
      * fast/files/create-blob-url-crash.html:
      * fast/files/revoke-blob-url.html:
      * fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
      (onmessage):
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c19f401
    • commit-queue@webkit.org's avatar
      2011-01-13 Emil Eklund <eae@chromium.org> · 129fb5fc
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Setting outerText should convert CR/LF to <br>
              https://bugs.webkit.org/show_bug.cgi?id=52268
      
              Add test for setting Element.outerText.
      
              * fast/dom/set-outer-text-expected.txt: Added.
              * fast/dom/set-outer-text.html: Added.
              * fast/dom/text-node-append-data-remove-crash-expected.txt: Changed
                  expectation to "didn't crash" from "threw dom exception" as test
                  assumed the DOMCharacterDataModified event would fire before the node
                  would be replaced.
              * fast/dom/text-node-append-data-remove-crash.html:
      2011-01-13  Emil Eklund  <eae@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Setting outerText should convert CR/LF to <br>
              https://bugs.webkit.org/show_bug.cgi?id=52268
      
              Make set outerText support line breaks (sharing the text to fragment code
              with setInnerText) and handle empty text nodes the same way IE does.
      
              Test: fast/dom/set-outer-text.html
      
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText
              (WebCore::HTMLElement::setInnerText): Split out text parsing code.
              (WebCore::mergeWithNextTextNode): Split out text node merging code.
              (WebCore::HTMLElement::setOuterText): Added support for line breaks.
              * html/HTMLElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      129fb5fc
    • zmo@google.com's avatar
      2011-01-13 Zhenyao Mo <zmo@google.com> · 4a8acbe1
      zmo@google.com authored
              Reviewed by Kenneth Russell.
      
              Relax the ESSL valid charset a little bit to include " ' `
              https://bugs.webkit.org/show_bug.cgi?id=52396
      
              * html/canvas/WebGLRenderingContext.cpp:
      2011-01-13  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Kenneth Russell.
      
              Relax the ESSL valid charset a little bit to include " ' `
              https://bugs.webkit.org/show_bug.cgi?id=52396
      
              * fast/canvas/webgl/invalid-passed-params-expected.txt:
              * fast/canvas/webgl/invalid-passed-params.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a8acbe1
    • enne@google.com's avatar
      2011-01-13 Adrienne Walker <enne@google.com> · fe00ace1
      enne@google.com authored
              Reviewed by Kenneth Russell.
      
              [chromium] Attempt to fix crash in tiled compositor memcpy
              https://bugs.webkit.org/show_bug.cgi?id=52379
      
              * platform/graphics/chromium/LayerTilerChromium.cpp:
              (WebCore::LayerTilerChromium::update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe00ace1
    • dglazkov@chromium.org's avatar
      Unreviewed, rolling out r75725. · 99dea9ee
      dglazkov@chromium.org authored
      http://trac.webkit.org/changeset/75725
      https://bugs.webkit.org/show_bug.cgi?id=52317
      
      Caused crashes in layout tests.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::initForStyleResolve):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::updateType):
      * html/InputType.cpp:
      * html/InputType.h:
      * html/RangeInputType.cpp:
      * html/RangeInputType.h:
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::defaultEventHandler):
      (WebCore::SliderThumbElement::detach):
      * html/shadow/SliderThumbElement.h:
      (WebCore::SliderThumbElement::SliderThumbElement):
      (WebCore::SliderThumbElement::create):
      * rendering/MediaControlElements.cpp:
      (WebCore::MediaControlInputElement::attach):
      (WebCore::MediaControlInputElement::updateStyle):
      * rendering/RenderSlider.cpp:
      (WebCore::RenderSlider::~RenderSlider):
      (WebCore::RenderSlider::styleDidChange):
      (WebCore::RenderSlider::createThumbStyle):
      (WebCore::RenderSlider::thumbRect):
      (WebCore::RenderSlider::layout):
      (WebCore::RenderSlider::updateFromElement):
      (WebCore::RenderSlider::mouseEventIsInThumb):
      (WebCore::RenderSlider::mouseEventOffsetToThumb):
      (WebCore::RenderSlider::setValueForPosition):
      (WebCore::RenderSlider::positionForOffset):
      (WebCore::RenderSlider::currentPosition):
      (WebCore::RenderSlider::trackSize):
      (WebCore::RenderSlider::forwardEvent):
      (WebCore::RenderSlider::inDragMode):
      * rendering/RenderSlider.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99dea9ee
    • dglazkov@chromium.org's avatar
      2011-01-12 Dimitri Glazkov <dglazkov@chromium.org> · 61dc5b17
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Flip input[type=range] to use the new shadow DOM model.
              https://bugs.webkit.org/show_bug.cgi?id=52317
      
              This is a straight-up flip, minimal change to the logic, which will be
              refactored in a follow-up patch.
      
              Covered by existing tests.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
                  host or parent node to find parent.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
                  shadow DOM subtree.
              * html/InputType.cpp:
              (WebCore::InputType::createShadowSubtree): Added empty decl.
              (WebCore::InputType::destroyShadowSubtree): Added a method to destroy
                  shadow subtree.
              * html/InputType.h: Added defs.
              * html/RangeInputType.cpp:
              (WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
                  slider thumb.
              * html/RangeInputType.h: Adde def.
              * html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
                  to handle cascading appearance.
              (WebCore::RenderSliderThumb::RenderSliderThumb): Added.
              (WebCore::RenderSliderThumb::layout): Moved here the logic from
                  RenderSlider::createThumbStyle.
              (WebCore::SliderThumbElement::createRenderer): Added virtual method to
                  create RenderSliderThumb instance.
              (WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
                  as base class.
              (WebCore::SliderThumbElement::detach): Ditto.
              * html/shadow/SliderThumbElement.h:
              (WebCore::SliderThumbElement::SliderThumbElement): Ditto.
              (WebCore::SliderThumbElement::create): Ditto.
              (WebCore::toSliderThumbElement): Added a casting helper.
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
                  since the whole method is hand-rolled.
              (WebCore::MediaControlInputElement::updateStyle): Ditto.
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
              (WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
              (WebCore::RenderSlider::layout): Ditto.
              (WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
                  SliderThumbElement.
              (WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
              (WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
              (WebCore::RenderSlider::setValueForPosition): Ditto.
              (WebCore::RenderSlider::positionForOffset): Ditto.
              (WebCore::RenderSlider::currentPosition): Ditto.
              (WebCore::RenderSlider::trackSize): Ditto.
              (WebCore::RenderSlider::forwardEvent): Ditto.
              (WebCore::RenderSlider::inDragMode): Ditto.
              * rendering/RenderSlider.h: Added def.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61dc5b17
    • mitz@apple.com's avatar
      <rdar://problem/8098442> Crash in Widget::setFrameRect() · 37aadf59
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52375
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      Test: plugins/destroy-on-setwindow.html
      
      * platform/mac/WidgetMac.mm:
      (WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
      out to the view.
      (WebCore::Widget::getOuterView): Coding style fix.
      (WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
      the views. This is precautionary, since this function does not applear to access member variables
      after such calls.
      * platform/wx/WidgetWx.cpp:
      (WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
      out to the platform widget.
      
      LayoutTests: 
      
      * plugins/destroy-on-setwindow-expected.txt: Added.
      * plugins/destroy-on-setwindow.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37aadf59
    • ossy@webkit.org's avatar
      Unreviewed buildfix after r75715. · 9542f0cc
      ossy@webkit.org authored
      * WebCore.pri:
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9542f0cc
    • pfeldman@chromium.org's avatar
      2011-01-13 Pavel Feldman <pfeldman@chromium.org> · dba82454
      pfeldman@chromium.org authored
              Not reviewed: Qt build fix.
      
              * WebCore.pri:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dba82454
    • pfeldman@chromium.org's avatar
      2011-01-12 Pavel Feldman <pfeldman@chromium.org> · 417eb939
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: embed injected script into the backend.
              https://bugs.webkit.org/show_bug.cgi?id=52312
      
              InjectedScript belongs to the backend of the system and
              should be exposed by means of protocol, not InjectedScriptAccess.
              This patch makes injected script a part of the backend.
              It introduces single manual generation step (xxd -i) that should be
              automated by the build scripts for all the platforms.
      
              * CMakeLists.txt:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::injectedScriptFor):
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::injectedScriptSource):
              * inspector/InjectedScriptHost.h:
              * inspector/Inspector.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/InjectedScript.js: Removed.
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.doLoadedDone.propertyNamesCallback):
              (WebInspector.doLoadedDone):
              * inspector/xxd.pl: Added.
      
      2011-01-12  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: embed injected script into the backend.
              https://bugs.webkit.org/show_bug.cgi?id=52312
      
              * WebKit.grd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      417eb939
    • mnaganov@chromium.org's avatar
      2011-01-13 Mikhail Naganov <mnaganov@chromium.org> · 57207cd5
      mnaganov@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Cleanup after r75613 -- make all UI-facing strings
              to be passed directly to WebInspector.UIString
      
              https://bugs.webkit.org/show_bug.cgi?id=52365
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ApplicationCacheItemsView.js:
              (WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
              (WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
              * inspector/front-end/AuditRules.js:
              (WebInspector.AuditRules.GzipRule.prototype.doRun):
              (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
              (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.EventListenerBreakpointsSidebarPane):
              (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
              * inspector/front-end/CookieItemsView.js:
              (WebInspector.CookieItemsView.prototype._updateWithCookies):
              * inspector/front-end/ImageView.js:
              (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
              (WebInspector.ImageView.prototype._createContentIfNeeded):
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkTimeCalculator.prototype.formatValue):
              (WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
              (WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
              * inspector/front-end/ProfileDataGridTree.js:
              (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
              (WebInspector.ProfileDataGridNode.prototype.get data):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.Type.toUIString):
              (WebInspector.Resource.Type.toString):
              * inspector/front-end/TimelineOverviewPane.js:
              (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel):
              (WebInspector.TimelineCalculator.prototype.formatValue):
              (WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
              (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
              (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
              * inspector/front-end/utilities.js:
              ():
              * Scripts/check-inspector-strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57207cd5
    • commit-queue@webkit.org's avatar
      2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> · 3eb75979
      commit-queue@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Need a way to inform the application when a Netscape plugin is created.
              https://bugs.webkit.org/show_bug.cgi?id=30179
      
              Added "c" style static method for the application to hook up for
              receiving notifications when a plugin is created.
      
              * plugins/symbian/PluginViewSymbian.cpp:
              (qtwebkit_setPluginCreatedCallback):
              (WebCore::PluginView::platformStart):
      2011-01-13  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Need a way to inform the application when a Netscape plugin is created.
              https://bugs.webkit.org/show_bug.cgi?id=30179
      
              Added "c" style static method for the application to hook up for
              receiving notifications when a plugin is created.
      
              * symbian/bwins/QtWebKitu.def:
              * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3eb75979
    • commit-queue@webkit.org's avatar
      2011-01-13 Yi Shen <yi.4.shen@nokia.com> · 4243304f
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] Use a black background color for the video element on Qt Mobile
              https://bugs.webkit.org/show_bug.cgi?id=52252
      
              Use black as the background color for the video element on Qt Mobile.
      
              * css/themeQtMobile.css:
              (video):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4243304f
    • commit-queue@webkit.org's avatar
      2011-01-13 Yi Shen <yi.4.shen@nokia.com> · 4d6a04e1
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Qt] Use a big central media play control button for video element
              https://bugs.webkit.org/show_bug.cgi?id=52315
      
              When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
              all other control buttons for the video element are hidden, except
              a big centralized play button.
      
              No new tests because no client implements requiresFullscreenForVideoPlayback yet.
      
              * WebCore.pri:
              * css/mediaControlsQtFullscreen.css: Added.
              (audio):
              (audio::-webkit-media-controls-panel):
              (video::-webkit-media-controls-panel):
              (video:-webkit-full-page-media::-webkit-media-controls-panel):
              (audio::-webkit-media-controls-mute-button):
              (video::-webkit-media-controls-mute-button):
              (audio::-webkit-media-controls-play-button):
              (video::-webkit-media-controls-play-button):
              (audio::-webkit-media-controls-timeline-container):
              (video::-webkit-media-controls-timeline-container):
              (audio::-webkit-media-controls-current-time-display):
              (video::-webkit-media-controls-current-time-display):
              (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
              (audio::-webkit-media-controls-timeline):
              (video::-webkit-media-controls-timeline):
              (audio::-webkit-media-controls-volume-slider-container):
              (video::-webkit-media-controls-volume-slider-container):
              (audio::-webkit-media-controls-volume-slider):
              (video::-webkit-media-controls-volume-slider):
              (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
              (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
              (audio::-webkit-media-controls-fullscreen-button):
              (video::-webkit-media-controls-fullscreen-button):
              (audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
              (audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
              (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d6a04e1
    • carlosgc@webkit.org's avatar
      2011-01-13 Carlos Garcia Campos <cgarcia@igalia.com> · f34fef7c
      carlosgc@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Paint toggle buttons inconsistent when the object state is indeterminate
              https://bugs.webkit.org/show_bug.cgi?id=52361
      
              Check whether the object state is indeterminate to set the flag
              GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
              buttons.
      
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::paintToggle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f34fef7c
    • xan@webkit.org's avatar
      2011-01-13 Xan Lopez <xlopez@igalia.com> · 74ba663b
      xan@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
              https://bugs.webkit.org/show_bug.cgi?id=42756
      
              The FixedVMPool Allocator does not work well on systems where
              allocating very large amounts of memory upfront is not reasonable,
              like Linux without overcommit enabled. As a workaround, on Linux,
              default to the values used in embedded environments (in the MB
              range), and only jump to the GB range if we detect at runtime that
              overcommit is enabled. Should fix crashes on Linux/x86_64 with
              less than 3 or 4GB of RAM.
      
              * jit/ExecutableAllocatorFixedVMPool.cpp:
              (JSC::FixedVMPoolAllocator::free): use new variables for VM pool
              size and coalesce limit.
              (JSC::ExecutableAllocator::isValid): swap the variables from
              embedded to generic values at runtime, on linux, if overcommit is
              enabled.
              (JSC::ExecutableAllocator::underMemoryPressure): use new variables
              for VM pool size and coalesce limit.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74ba663b
    • commit-queue@webkit.org's avatar
      2011-01-13 Yi Shen <yi.4.shen@nokia.com> · 475201d4
      commit-queue@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Extend the Platform Plugin to support full screen video handler
              https://bugs.webkit.org/show_bug.cgi?id=51249
      
              Make MediaPlayerPrivateQt support a fullscreen player.
      
              No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
              However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
              So, still skip it for Qt.
      
              * WebCore.pro:
              * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
              (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
              (WebCore::MediaPlayerPrivateQt::removeVideoItem):
              (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
              * platform/graphics/qt/MediaPlayerPrivateQt.h:
              (WebCore::MediaPlayerPrivateQt::supportsFullscreen):
              (WebCore::MediaPlayerPrivateQt::mediaPlayer):
      2011-01-13  Yi Shen  <yi.4.shen@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Extend the Platform Plugin to support full screen video handler
              https://bugs.webkit.org/show_bug.cgi?id=51249
      
              Add a new webkit platform plugin interface to support full screen video handler.
      
              * Api/qwebkitplatformplugin.h:
              (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
              (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::ChromeClientQt):
              (WebCore::ChromeClientQt::~ChromeClientQt):
              (WebCore::ChromeClientQt::fullScreenVideo):
              (WebCore::ChromeClientQt::supportsFullscreenForNode):
              (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback):
              (WebCore::ChromeClientQt::enterFullscreenForNode):
              (WebCore::ChromeClientQt::exitFullscreenForNode):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/FullScreenVideoQt.cpp: Added.
              (WebCore::FullScreenVideoQt::FullScreenVideoQt):
              (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
              (WebCore::FullScreenVideoQt::enterFullScreenForNode):
              (WebCore::FullScreenVideoQt::exitFullScreenForNode):
              (WebCore::FullScreenVideoQt::aboutToClose):
              (WebCore::FullScreenVideoQt::mediaPlayer):
              (WebCore::FullScreenVideoQt::mediaPlayerForNode):
              (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
              * WebCoreSupport/FullScreenVideoQt.h: Added.
              (WebCore::FullScreenVideoQt::isValid):
              * WebCoreSupport/QtPlatformPlugin.cpp:
              (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
              * WebCoreSupport/QtPlatformPlugin.h:
              * examples/platformplugin/WebPlugin.cpp:
              (FullScreenVideoWidget::FullScreenVideoWidget):
              (FullScreenVideoWidget::event):
              (FullScreenVideoWidget::keyPressEvent):
              (FullScreenVideoHandler::FullScreenVideoHandler):
              (FullScreenVideoHandler::~FullScreenVideoHandler):
              (FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
              (FullScreenVideoHandler::enterFullScreen):
              (FullScreenVideoHandler::exitFullScreen):
              (WebPlugin::supportsExtension):
              (WebPlugin::createExtension):
              * examples/platformplugin/WebPlugin.h:
              (FullScreenVideoWidget::~FullScreenVideoWidget):
              * examples/platformplugin/platformplugin.pro:
              * examples/platformplugin/qwebkitplatformplugin.h:
              (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
              (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      475201d4
    • mitz@apple.com's avatar
      <rdar://problem/8858548> Disable inheritance of text emphasis marks to ruby text · e15908bc
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52359
      
      Reviewed by Dave Hyatt.
      
      Source/WebCore: 
      
      Test: fast/ruby/text-emphasis.html
      
      * css/html.css:
      (rt):
      
      LayoutTests: 
      
      * fast/ruby/text-emphasis-expected.txt: Added.
      * fast/ruby/text-emphasis.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e15908bc
    • ossy@webkit.org's avatar
      Trivial fix after r75682. · f885239a
      ossy@webkit.org authored
      Rubber-stamped by David Levin.
      
      * loader/FrameLoader.cpp: Remove accidentally committed debug code.
      (WebCore::FrameLoader::shouldClose):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f885239a
    • mjs@apple.com's avatar
      2011-01-12 Maciej Stachowiak <mjs@apple.com> · 74f62170
      mjs@apple.com authored
              Reviewed by David Levin.
      
              Add beforeunload support to WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=52353
      
              * platform/mac-wk2/Skipped: Unskip a test that was failing solely due to missing
              beforeunload support.
      2011-01-12  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by David Levin.
      
              Add beforeunload support to WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=52353
              
              This makes a number of currently failing tests pass.
      
              * WebKitTestRunner/TestController.cpp:
              (WTR::runBeforeUnloadConfirmPanel):
              (WTR::createOtherPage):
              (WTR::TestController::initialize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74f62170
  2. 12 Jan, 2011 17 commits
    • rniwa@webkit.org's avatar
      2011-01-12 Ryosuke Niwa <rniwa@webkit.org> · a0ffb017
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
              https://bugs.webkit.org/show_bug.cgi?id=52241
      
              The bug was caused by RenderTextControl::selection's creating a Range with m_insertText
              which is a shadow DOM div as both start and end containers. Fixed the bug by traversing
              through the descendents of m_innerText and using the right start and end containers to
              create a Range.
      
              Test: fast/forms/focus-change-on-keypress.html
      
              * rendering/RenderTextControl.cpp:
              (WebCore::setContainerAndOffsetForRange): Added; a helper function.
              (WebCore::RenderTextControl::selection): See above.
      2011-01-12  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com)
              https://bugs.webkit.org/show_bug.cgi?id=52241
      
              Added a test to ensure WebKit inserts the character typed by a user when focus's node
              is changed by a presskey event handler.
      
              * fast/forms/focus-change-on-keypress-expected.txt: Added.
              * fast/forms/focus-change-on-keypress.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0ffb017
    • tkent@chromium.org's avatar
      2011-01-12 Kenichi Ishibashi <bashi@google.com> · 46a996c0
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
              https://bugs.webkit.org/show_bug.cgi?id=51905
      
              Calls unregisterFormElementWithFormAttribute() when 'form' attribute
              is removed.
      
              Tests: fast/forms/form-associated-element-crash.html
                     fast/forms/form-associated-element-crash2.html
      
              * html/FormAssociatedElement.cpp:
              (WebCore::FormAssociatedElement::formAttributeChanged):
      
      2011-01-12  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              M_formElementsWithFormAttribute not cleared when FormAssociatedElement is inserted with a null m_form and then removed.
              https://bugs.webkit.org/show_bug.cgi?id=51905
      
              Add test for crash when modifying the form attribute of a form
              associated element before removing it.
      
              * fast/forms/form-associated-element-crash-expected.txt: Added.
              * fast/forms/form-associated-element-crash.html: Added.
              * fast/forms/form-associated-element-crash2-expected.txt: Added.
              * fast/forms/form-associated-element-crash2.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a996c0
    • tkent@chromium.org's avatar
      2011-01-12 Kenichi Ishibashi <bashi@google.com> · d408e11e
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              M_formElementsWithFormAttribute not cleared when Node is moved to another document.
              https://bugs.webkit.org/show_bug.cgi?id=51418
      
              Calls unregisterFormElementWithFormAttribute() when form associated elements
              are moved to another document.
      
              Test: fast/forms/change-form-element-document-crash.html
      
              * html/FormAssociatedElement.cpp:
              (WebCore::FormAssociatedElement::willMoveToNewOwnerDocument): Added.
              * html/FormAssociatedElement.h: Added willMoveToNewOwnerDocument().
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::willMoveToNewOwnerDocument): Added.
              * html/HTMLFormControlElement.h: Added willMoveToNewOwnerDocument().
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::willMoveToNewOwnerDocument): Added.
              * html/HTMLObjectElement.h: Added willMoveToNewOwnerDocument().
              * html/HTMLPlugInImageElement.h: Moves willMoveToNewOwnerDocument() to protected.
      
      2011-01-12  Kenichi Ishibashi  <bashi@google.com>
      
              Reviewed by Kent Tamura.
      
              M_formElementsWithFormAttribute not cleared when Node is moved to another document.
              https://bugs.webkit.org/show_bug.cgi?id=51418
      
              Added test for crash when moving form elements from one document to another.
      
              * fast/forms/change-form-element-document-crash-expected.txt: Added.
              * fast/forms/change-form-element-document-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d408e11e
    • rniwa@webkit.org's avatar
      Unreviwed. Added the missing bug id for r75672. · 994697a7
      rniwa@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      994697a7
    • rniwa@webkit.org's avatar
      2011-01-12 Ryosuke Niwa <rniwa@webkit.org> · 7bfcc007
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Removed instantiation of legacy editing positions.
              Calls to Position::Position are replaced by calls to Position's convenience functions.
      
              Also added firstPositionInOrBeforeNode and lastPositionInOrAfterNode,
              which are functions that return firstPositionInNode and lastPositionInNode respectively
              when the specified node can have children for editing purpose and return positionBeforeNode
              and positionAfterNode respectively otherwise. They can be used to guarantee that we never
              create a bogus position like [img, 0] or [br, 0].
      
              No tests are added since this is a cleanup.
      
              * editing/ApplyBlockElementCommand.cpp:
              (WebCore::ApplyBlockElementCommand::formatSelection):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
              (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStart):
              (WebCore::ApplyStyleCommand::splitTextAtEnd):
              (WebCore::ApplyStyleCommand::splitTextElementAtStart):
              (WebCore::ApplyStyleCommand::splitTextElementAtEnd):
              (WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::computedFontSize):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/ApplyStyleCommand.h:
              * editing/htmlediting.h:
              (WebCore::firstPositionInOrBeforeNode): Added.
              (WebCore::lastPositionInOrAfterNode): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bfcc007
    • weinig@apple.com's avatar
      Another build fix. · 0300e230
      weinig@apple.com authored
      * platform/mac/WheelEventMac.mm:
      (WebCore::phaseForEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0300e230
    • weinig@apple.com's avatar
      Fix build. · 85890a98
      weinig@apple.com authored
      * platform/mac/WheelEventMac.mm:
      (WebCore::phaseForEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85890a98
    • abarth@webkit.org's avatar
      2011-01-12 Adam Barth <abarth@webkit.org> · 191f397d
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove premature optimization from SchemeRegistry
              https://bugs.webkit.org/show_bug.cgi?id=52283
      
              As far as I can tell, this optimization isn't necessary.  I'm slightly
              unsure which benchmarks to run to demonstrate this numerically, but
              none of the benchmarks Chromium tracks were affected by adding a
              similar check for "display-isolated" schemes.
      
              * platform/SchemeRegistry.cpp:
              (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      191f397d
    • enrica@apple.com's avatar
      Build fix, unreviewed. · c9dd7a3c
      enrica@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9dd7a3c
    • bdakin@apple.com's avatar
      Add-on for https://bugs.webkit.org/show_bug.cgi?id=52309 · fd7c5cf6
      bdakin@apple.com authored
      Expose fixed layout through WebKit SPI
      -and corresponding-
      <rdar://problem/8844464>
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      And now with getters!
      * WebCore.exp.in:
      
      WebKit/mac: 
      
      And now with getters!
      * WebView/WebView.mm:
      (-[WebView _useFixedLayout]):
      (-[WebView _fixedLayoutSize]):
      * WebView/WebViewPrivate.h:
      
      WebKit2: 
      
      And now with getters!
      * UIProcess/API/C/WKPage.cpp:
      (WKPageUseFixedLayout):
      (WKPageFixedLayoutSize):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebPageProxy.h:
      (WebKit::WebPageProxy::useFixedLayout):
      (WebKit::WebPageProxy::fixedLayoutSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd7c5cf6
    • weinig@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=52337 · 7791a801
      weinig@apple.com authored
      PlatformWheelEvent should know about the scroll phase on the Mac
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      Add a phase parameter on Mac PlatformWheelEvents.
      
      * platform/PlatformWheelEvent.h:
      (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      (WebCore::PlatformWheelEvent::phase):
      * platform/mac/WheelEventMac.mm:
      (WebCore::phaseForEvent):
      (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      
      WebKit2: 
      
      Add a phase parameter on Mac WebWheelEvent and pipe it down to PlatformWheelEvent.
      
      * Shared/WebEvent.h:
      (WebKit::WebWheelEvent::phase):
      * Shared/WebEventConversion.cpp:
      (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
      * Shared/WebWheelEvent.cpp:
      (WebKit::WebWheelEvent::WebWheelEvent):
      (WebKit::WebWheelEvent::encode):
      (WebKit::WebWheelEvent::decode):
      * Shared/mac/WebEventFactory.mm:
      (WebKit::phaseForEvent):
      (WebKit::WebEventFactory::createWebWheelEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7791a801
    • cmarrin@apple.com's avatar
      2011-01-12 Chris Marrin <cmarrin@apple.com> · 0057c5aa
      cmarrin@apple.com authored
              Unreviewed.
      
              A couple of lines of the patch for https://bugs.webkit.org/show_bug.cgi?id=52321
              were omitted. 
      
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0057c5aa
    • cmarrin@apple.com's avatar
      2011-01-12 Chris Marrin <cmarrin@apple.com> · 95bd99e1
      cmarrin@apple.com authored
              Unreviewed.
      
              Getting rid of an assert that was causing build failures that turns out not to be needed.
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintsWithTransform):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95bd99e1
    • cmarrin@apple.com's avatar
      2011-01-12 Chris Marrin <cmarrin@apple.com> · 4113d29f
      cmarrin@apple.com authored
              Unreviewed.
      
              Another fix for Gtk
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintsWithTransform):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4113d29f
    • cmarrin@apple.com's avatar
      2011-01-12 Chris Marrin <cmarrin@apple.com> · ef189c6b
      cmarrin@apple.com authored
              Unreviewed.
      
              Fix for Gtk and Windows builds
      
              * page/Frame.cpp:
              (WebCore::Frame::scalePage):
              * page/Frame.h:
              * platform/graphics/ca/win/PlatformCALayerWin.cpp:
              (PlatformCALayer::contentsScale):
              (PlatformCALayer::setContentsScale):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef189c6b
    • cmarrin@apple.com's avatar
      2011-01-12 Chris Marrin <cmarrin@apple.com> · d0a9dc7a
      cmarrin@apple.com authored
              UNreviewed.
      
              Fix for the Windows build
      
              * platform/graphics/ca/win/PlatformCALayerWin.cpp:
              (contentsScale):
              (setContentsScale):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a9dc7a
    • cmarrin@apple.com's avatar
      2011-01-12 Chris Marrin <cmarrin@apple.com> · 2cf8acfc
      cmarrin@apple.com authored
              Unreviewed.
      
              Another build fix
      
              * platform/graphics/ca/GraphicsLayerCA.cpp:
              (WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
              * platform/graphics/ca/mac/PlatformCALayerMac.mm:
              (PlatformCALayer::setContentsScale):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cf8acfc