1. 04 Jun, 2006 3 commits
    • darin's avatar
      LayoutTests: · 9d783fab
      darin authored
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
                REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
      
              * fast/loader/link-no-URL.html: Added.
              * fast/loader/link-no-URL-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
                REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
      
              Test: fast/loader/link-no-URL.html
      
              * loader/Cache.h:
              * loader/Cache.cpp:
              (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL
              from the cached object itself. Callers were passing in the wrong URL. When it was a
              null string, it caused the crash mentioned above. But in other cases it may have
              caused some other minor problems as well. Added an assert to catch cases where the
              URL is null (should never happen).
              (WebCore::Cache::requestImage): Changed call site to not pass URL.
              (WebCore::Cache::requestStyleSheet): Ditto.
              (WebCore::Cache::requestScript): Ditto.
              (WebCore::Cache::requestXSLStyleSheet): Ditto.
              (WebCore::Cache::requestXBLDocument): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d783fab
    • ddkilzer's avatar
      LayoutTests: · fb5e6eec
      ddkilzer authored
              Reviewed by hyatt.
      
              - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
                Absolutely positioned objects with relatively positioned inline 
                containing blocks are rendered incorrectly
      
              * fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
              * fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
              * fast/block/positioning/absolute-in-inline-ltr.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl.html: Added.
              * fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
              * fast/block/positioning/absolute-in-inline-short-rtl.html: Added.
      
      WebCore:
      
              Reviewed by hyatt.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
                Absolutely positioned objects with relatively positioned inline 
                containing blocks are rendered incorrectly
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockWidthForPositioned):
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb5e6eec
    • andersca's avatar
      WebCore: · 0315a98f
      andersca authored
      2006-06-04  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
              document.evaluate and createNSResolver miss on namespaced elements
              
              * xpath/XPathExpression.cpp:
              (WebCore::XPathExpression::createExpression):
              Pass the resolver to the parser.
              
              * xpath/XPathResult.cpp:
              (WebCore::XPathResult::iterateNext):
              Fix off-by-one error.
              
              * xpath/impl/XPathExpressionNode.h:
              (WebCore::XPath::EvaluationContext::EvaluationContext):
              Get rid of the resolver in the evaluation context.
              
              * xpath/impl/XPathGrammar.y:
              Fetch the resolver from the parser. Only return the local name.
              
              * xpath/impl/XPathParser.cpp:        
              (WebCore::XPath::Parser::parseStatement):
              * xpath/impl/XPathParser.h:
              (WebCore::XPath::Parser::resolver):
              Update to hold the resolver.
              
              * xpath/impl/XPathStep.cpp:
              (WebCore::XPath::Step::Step):
              If the parser has stored a namespace URI, set it.
              
              (WebCore::XPath::Step::nodeTestMatches):
              Check namespace URIs.
              
              * xpath/impl/XPathStep.h:
              Add m_namespaceURI.
      
      LayoutTests:
      
      2006-06-04  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
              document.evaluate and createNSResolver miss on namespaced elements
      
              * fast/xpath: Added.
              * fast/xpath/xpath-namespaces-expected.txt: Added.
              * fast/xpath/xpath-namespaces.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0315a98f
  2. 03 Jun, 2006 3 commits
    • ddkilzer's avatar
      LayoutTests: · a0cd6749
      ddkilzer authored
              Reviewed by Eric.
      
              Added missing pixel test output:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
              TFOOT borders are copied to THEAD and TBODY
      
              * fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0cd6749
    • ddkilzer's avatar
      LayoutTests: · 6a28aac9
      ddkilzer authored
              Reviewed by mjs.  Tweaked and landed by ddkilzer.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
              With java disabled wrong information is displayed.
      
              * fast/replaced/applet-rendering-java-disabled.html: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.html: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.png: Added.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.
      
      WebCore:
      
              Reviewed by mjs.  Tweaked and landed by ddkilzer.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
              With java disabled wrong information is displayed.
      
              Test: fast/replaced/applet-rendering-java-disabled.html
      
              Match WinIE, render applet content inline when java is
              disabled. 
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::createRenderer):
              * rendering/RenderEmptyApplet.cpp: Removed.
              * rendering/RenderEmptyApplet.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a28aac9
    • thatcher's avatar
      LayoutTests: · dd4c7a30
      thatcher authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
                REGRESSION: Very odd roll-over issues (content disappearing)
      
              * fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
                REGRESSION: Very odd roll-over issues (content disappearing)
      
              Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being
              loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet
              count correct.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4c7a30
  3. 02 Jun, 2006 6 commits
    • ddkilzer's avatar
      JavaScriptCore: · 31459a5c
      ddkilzer authored
              Reviewed by ggaren.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
                Implement $&, $' and $` replacement codes in String.prototype.replace
      
              Test: fast/js/string-replace-3.html
      
              * kjs/string_object.cpp:
              (substituteBackreferences): Added support for $& (matched substring),
              $` (everything preceding matched substring), $' (everything following
              matched substring) and 2-digit back references, and cleaned up a little.
      
      LayoutTests:
      
              Reviewed by ggaren.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
                Implement $&, $' and $` replacement codes in String.prototype.replace
      
              * fast/js/resources/string-replace-3.js: Added.
              * fast/js/string-replace-3-expected.txt: Added.
              * fast/js/string-replace-3.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31459a5c
    • thatcher's avatar
      LayoutTests: · 8991c154
      thatcher authored
              Reviewed by Hyatt, checked in by Tim H.
      
              For: http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
              Added test case to test opacity layers, in particular, opacities
              with a value of zero.
      
             * fast/css/ZeroOpacityLayers.html: Added.
             * fast/css/ZeroOpacityLayers-expected.txt: Added.
             * fast/css/ZeroOpacityLayers-expected.png: Added.
             * fast/css/ZeroOpacityLayers-expected.checksum: Added.
             * fast/css/ZeroOpacityLayers2.html: Added.
             * fast/css/ZeroOpacityLayers2-expected.txt: Added.
             * fast/css/ZeroOpacityLayers2-expected.png: Added.
             * fast/css/ZeroOpacityLayers2-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt, checked in by Tim H.
      
              fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
              Changed RenderLayer to only render layers that are not
              totally transparent.
      
              * rendering/RenderLayer.cpp
              (RenderLayer::paintLayer):
              Changed function to also check if the layer is totally transparent
              and if it is, don't bother painting it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8991c154
    • thatcher's avatar
      LayoutTests: · 864dbca9
      thatcher authored
              Reviewed by Hyatt, checked in by Tim H.
      
              Adding testcase for bug 8223.
      
              * fast/dom/css-inline-style-important-expected.checksum: Added.
              * fast/dom/css-inline-style-important-expected.png: Added.
              * fast/dom/css-inline-style-important-expected.txt: Added.
              * fast/dom/css-inline-style-important.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt, checked in by Tim H.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
              WebKit fails to update style on element via DOM
      
              Handle !important by detecting it and using a different code
              path from normal priority.
      
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::put):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::setProperty):
              * css/CSSStyleDeclaration.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864dbca9
    • darin's avatar
      LayoutTests: · d8c28ba8
      darin authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
                attr(X) does not work
      
              * fast/css-generated-content/016-expected.checksum: Added.
              * fast/css-generated-content/016-expected.png: Added.
              * fast/css-generated-content/016-expected.txt: Added.
              * fast/css-generated-content/016.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
                attr(X) does not work
      
              Test: fast/css-generated-content/016.html
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style
              if the unique bit is set.
              (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property,
              set the unique bit and add to m_selectorAttrs.
      
              * rendering/render_style.cpp: Did a lot of reformatting, and this one real change.
              (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
      
              * rendering/render_style.h:
              (WebCore::RenderStyle::unique): Added. Returns value of m_unique.
              (WebCore::RenderStyle::setUnique): Added. Sets m_unique.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8c28ba8
    • darin's avatar
      Reviewed by Anders. · c8ed75dd
      darin authored
              Updated test so that is will once again exercise the fix for
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
      
              * fast/table/empty-section-crash-expected.txt:
              * fast/table/empty-section-crash.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8ed75dd
    • ddkilzer's avatar
      LayoutTests: · 249f410d
      ddkilzer authored
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-1-expected.png: Ditto.
              * editing/selection/7152-1-expected.txt: Ditto.
              * editing/selection/7152-1.html: Changed text in HTML content.
              * editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-2-expected.png: Ditto.
              * editing/selection/7152-2-expected.txt: Ditto.
              * editing/selection/7152-2.html: Changed text in HTML content.
              * *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.
      
      WebCore:
      
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      249f410d
  4. 01 Jun, 2006 6 commits
    • darin's avatar
      LayoutTests: · bd205a70
      darin authored
              Reviewed by Maciej and Adele
              
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
              Updated and extended select/option form tests 
              
              * fast/forms/HTMLOptionElement_label01.html:
              * fast/forms/HTMLOptionElement_label01-expected.txt:
              * fast/forms/HTMLOptionElement_label01-expected.png:
              * fast/forms/HTMLOptionElement_label02.html:
              * fast/forms/HTMLOptionElement_label02-expected.txt:
              * fast/forms/HTMLOptionElement_label02-expected.png:
              * fast/forms/HTMLOptionElement_label03.html:
              * fast/forms/HTMLOptionElement_label03-expected.txt:
              * fast/forms/HTMLOptionElement_label03-expected.png
              * fast/forms/HTMLOptionElement_label04.html:
              * fast/forms/HTMLOptionElement_label04-expected.txt:
              * fast/forms/HTMLOptionElement_label04-expected.png
              * fast/forms/HTMLOptionElement_label05.html:
              * fast/forms/HTMLOptionElement_label05-expected.txt:
              * fast/forms/HTMLOptionElement_label05-expected.png:
              Updated to reflect success and added some description
              
              * fast/forms/HTMLOptionElement_label06.html:
              * fast/forms/HTMLOptionElement_label06-expected.txt:
              * fast/forms/HTMLOptionElement_label05-expected.png:
              * fast/forms/HTMLOptionElement_label07.html:
              * fast/forms/HTMLOptionElement_label07-expected.txt:
              * fast/forms/HTMLOptionElement_label07-expected.png:
              Added.
      
      WebCore:
      
              Reviewed by Maciej and Adele
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
              REGRESSION: LABEL in OPTION element is clobbering display #TEXT
              Patch provided by Darin.
              
              * rendering/RenderSelect.cpp
              (RenderSelect::updateFromElement): 
              Changed to use the containing text by default, and not the label text
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd205a70
    • darin's avatar
      LayoutTests: · 7869e236
      darin authored
              Reviewed by Hyatt
              
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
              Test the window.screen.pixelDepth and window.screen.colorDepth
              
              * fast/dom/window/window-screen-properties.html: Added
              * fast/dom/window/window-screen-properties-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
              Correcting the value returned for window.screen.pixelDepth and
              window.screen.colorDepth
              
              * platform/mac/ScreenMac.mm
              (screenDepth): 
              Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7869e236
    • andersca's avatar
      WebCore: · 079f44cf
      andersca authored
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
              
              * bindings/js/kjs_window.cpp:
              (KJS::Location::put):
              Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes
              are equal.
              
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:        
              (WebCore::BrowserExtensionMac::historyURL):
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              New function historyURL which returns the complete URL for a given item in the history.
              
              * page/Frame.cpp:
              (WebCore::Frame::scheduleLocationChange):        
              (WebCore::Frame::scheduleHistoryNavigation):
              If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it
              directly.
              
              * platform/KURL.cpp:
              * platform/KURL.h:
              Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.
      
      WebKit:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
      
              * Misc/WebNSURLExtras.m:
              (-[NSString _webkit_URLFragment]):
              Don't include the "#" character in the fragment.
              
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge historyURL:]):
              New function, returns the history URL for a given position in the back/forward list
              
              * WebView/WebFrame.m:
              (-[WebFrame _loadItem:withLoadType:]):
              Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's
              URL up-to-date.
      
      WebKitTools:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController clearBackForwardList]):
              Add clearBackForwardList function to layoutTestController
              
      LayoutTests:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
              
              * fast/dom/location-hash-expected.txt: Added.
              * fast/dom/location-hash.html: Added.
              Added tests.
              
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079f44cf
    • adele's avatar
      LayoutTests: · 65dc279a
      adele authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9124
                Drop shadow obscures "add more stuff" bubble at live.com
      
              * fast/css/find-next-layer-expected.checksum: Added.
              * fast/css/find-next-layer-expected.png: Added.
              * fast/css/find-next-layer-expected.txt: Added.
              * fast/css/find-next-layer.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9124
                Drop shadow obscures "add more stuff" bubble at live.com
      
              Test: fast/css/find-next-layer.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::findNextLayer): Fixed a bug where this function could reach
              two levels down in the layer tree and return 0.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65dc279a
    • adele's avatar
      LayoutTests: · 25e4a011
      adele authored
              Reviewed by Hyatt.
      
              - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9100
                Absolutely positioned replaced elements with all non-auto
                values are rendered incorrectly
      
              * fast/replaced/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
              * fast/replaced/absolute-position-with-auto-width-and-left-and-right.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9100
                Absolutely positioned replaced elements with all non-auto
                values are rendered incorrectly
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Add support for case when all values are specified.
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25e4a011
    • adele's avatar
      LayoutTests: · cdca1364
      adele authored
              Reviewed by Hyatt.
      
              - test and updated results for
                http://bugzilla.opendarwin.org/show_bug.cgi?id=9012
                Row height not updated when cell heights change
      
              * fast/table/row-height-recalc-expected.checksum: Added.
              * fast/table/row-height-recalc-expected.png: Added.
              * fast/table/row-height-recalc-expected.txt: Added.
              * fast/table/row-height-recalc.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9012
                Row height not updated when cell heights change
      
              Test: fast/table/row-height-recalc.html
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::setStyle): Mark the section as needing recalculation
              if the height property changed.
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::setStyle): Ditto.
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::recalcCells): Initialize the grid row height
              to the height of the row element (like addChild() does).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdca1364
  5. 31 May, 2006 3 commits
    • adele's avatar
      LayoutTests: · a9a86b91
      adele authored
              Reviewed by Geoff.
      
              Testcase for http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
      
              * fast/forms/select-reset.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
              selectedIndex for a select after a Form reset() has wrong value
      
              Make sure the list items are reset properly by selecting
              the first option in case no options have the selected attribute
              set.
      
              * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9a86b91
    • adele's avatar
      LayoutTests: · 77712e9d
      adele authored
              Reviewed by Geoff.
      
              Add a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
      
              * fast/dom/document-all-input.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
              "Go" button (search) doesn't work at fifa.com (document.all.FormName)
      
              Allow input elements with name attributes as possible named
              items for document.all.
      
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::checkForNameMatch):
              (WebCore::HTMLCollection::updateNameCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77712e9d
    • bdakin's avatar
      Reviewed by Hyatt. · f0cf2561
      bdakin authored
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6755 CSS3: 
              Borders rounded with border-radius don't draw the roundings
      
              This patch does not draw all of the different border styles 
              perfectly, so I have filed a few followup bugs that I will 
              reference from this Bugzilla.
      
              * platform/GraphicsContext.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::drawArc): drawArc() has different 
              parameters now, but mostly this needs to be implemented to match 
              the Mac side later.
              (WebCore::GraphicsContext::addRoundedRectClip): Just a stub. 
              Implement this later.
              (WebCore::GraphicsContext::addInnerRoundedRectClip): Just a stub. 
              Implement this later.
              * platform/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::drawArc): drawArc() now handles drawing 
              elliptical arcs as well as circular arcs, it also takes a thickness 
              parameter to draw an arc of a given thickness and draws with the 
              appropriate pen style.
              (WebCore::GraphicsContext::addInnerRoundedRectClip): Adds a clip to 
              the inside of an arc instead of to the outside which is already 
              done by addRoundedClipRect()
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBorderArc): Draws the border arcs in 
              the appropriate styles.
              (WebCore::RenderObject::paintBorder): Calls drawBorderArc() when 
              border arcs are needed.
              * rendering/RenderObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0cf2561
  6. 30 May, 2006 2 commits
  7. 26 May, 2006 2 commits
    • adele's avatar
      LayoutTests: · 3be74fe8
      adele authored
              Reviewed by Hyatt.
      
              Added test for new textarea implementation.  Tests
              wrap attributes and form submission.
      
              * fast/forms/textarea-appearance-wrap-expected.txt: Added.
              * fast/forms/textarea-appearance-wrap.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Added support for wrap=hard for new textarea implementation.
      
              Tests: fast/forms/textarea-appearance-wrap.html
      
              * dom/Range.h: Added version of toString that will convert BRs to newlines.
              * dom/Range.cpp: (WebCore::Range::toString):
              * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): 
                When in plain-text mode, and a white-space mode that doesn't collapse whitespace, create a fragment with one text node.
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition): Subtract scroll offset so the absolute position for the containing block is correct.
              (WebCore::nextLinePosition): ditto.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::positionForCoordinates): If the position is equal to the left edge of the box,
              make the affinity downstream so the position doesn't jump back to the previous line.
              (WebCore::RenderText::atLineWrap): The logic was reversed here in a recent change.
              If the box is not at a line break, then its at a line wrap.
              (WebCore::RenderText::caretRect): Only go to the next text box if its at a line wrap and the
               affinity is also downstream.  If its upstream, then the correct box is on the current line.
              (WebCore::RenderText::inlineBox): ditto.
              * rendering/RenderTextField.cpp:
              (WebCore::RenderTextField::updateFromElement): multi line controls don't need to check
               valueMatchesRenderer before updating the renderer.  For textareas, the renderer should always try to update.
               This matches our old textarea behavior.
              (WebCore::RenderTextField::text): Pass true to textContent so it converts BRs to newlines.
              (WebCore::RenderTextField::textWithHardLineBreaks): Iterate through the RootLineBoxes to find the soft wraps and replace them with newlines.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3be74fe8
    • andersca's avatar
      WebCore: · a32b7791
      andersca authored
      2006-05-26  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
              Invoke capturing event listeners when AT_TARGET
              
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::handleLocalEvents):    
              Invoke capturing event listeners for the AT_TARGET phase. This violates the
              DOM spec but it's what Mozilla does.
      
      LayoutTests:
      
      2006-05-26  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
              Invoke capturing event listeners when AT_TARGET
      
              * dom/html/level2/events/dispatchEvent09-expected.txt:
              * dom/xhtml/level2/events/dispatchEvent09-expected.txt:
              These fail now.
              
              * fast/dom/capturing-event-listeners-expected.txt: Added.
              * fast/dom/capturing-event-listeners.html: Added.
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a32b7791
  8. 25 May, 2006 4 commits
  9. 24 May, 2006 4 commits
    • ggaren's avatar
      LayoutTests: · 7e729c2c
      ggaren authored
              - Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9095
              regression: can't select by setting option.selected to true
      
              * fast/dom/option-properties-expected.txt: Added.
              * fast/dom/option-properties.html: Added.
      
      WebCore:
      
              Reviewed by andersca.
              
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9095
              regression: can't select by setting option.selected to true
              
              'text' and 'selected' were erroneously marked read-only for option elements.
              
              * html/HTMLOptionElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e729c2c
    • ggaren's avatar
      JavaScriptCore: · 0dc4ae48
      ggaren authored
              Reviewed by mjs.
              
              - JSC half of fix for <rdar://problem/4557926> TOT REGRESSSION: Crash
              occurs when attempting to view image in slideshow mode at
              http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute
              (KJS::ExecState*) + 312)
      
              On alternate threads, DOMObjects remain in the
              ScriptInterpreter's cache because they're not collected. So, they
              need an opportunity to mark their children.
              
              I'm not particularly happy with this solution because it fails to
              resolve many outstanding issues with the DOM object cache. Since none
              of those issues is a crasher or a serious compatibility concern,
              and since the behavior of other browsers is not much to go on in this
              case, I've filed <rdar://problem/4561439> about that, and I'm moving on 
              with my life.
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * kjs/collector.cpp:
              (KJS::Collector::collect):
              * kjs/internal.cpp:
              (KJS::InterpreterImp::mark):
              * kjs/internal.h:
              * kjs/interpreter.cpp:
              (KJS::Interpreter::mark):
              * kjs/interpreter.h:
      
      LayoutTests:
      
              Layout tests for DOM object cache and garbage collection,
              <rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting 
              to view image in slideshow mode at http://d.smugmug.com/gallery/581716 
              ( KJS::IfNode::execute (KJS::ExecState*) + 312) if you use a PAC file
      
              * fast/dom/gc-8-expected.txt: Added.
              * fast/dom/gc-8.html: Added.
              * fast/dom/gc-9-expected.txt: Added.
              * fast/dom/gc-9.html: Added.
      
      WebCore:
      
              Reviewed by mjs.
      
              - WebCore half of fix for <rdar://problem/4557926> TOT REGRESSION: Crash
              occurs when attempting to view image in slideshow mode at
              http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute
              (KJS::ExecState*) + 312)
      
              On alternate threads, DOMObjects remain in the
              ScriptInterpreter's cache because they're not collected. So, they
              need an opportunity to mark their children.
              
              I'm not particularly happy with this solution because it fails to
              resolve many outstanding issues with the DOM object cache. Since none
              of those issues is a crasher or a serious compatibility concern,
              and since the behavior of other browsers is not much to go on in this
              case, I've filed <rdar://problem/4561439> about that, and I'm moving 
              on with my life.
      
              Also added functionality for testing garbage collection from inside
              DumpRenderTree.
              
              Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest
              objects aren't accessed through the DOM.
              
              Also added JS locking around access to some shared data structures in
              WebCoreJavaScript, even though it probably doesn't matter in practice.
      
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
              (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::mark):
              * bindings/js/kjs_binding.h:
              * bridge/mac/WebCoreJavaScript.h:
              * bridge/mac/WebCoreJavaScript.mm:
              (collect):
              (+[WebCoreJavaScript objectCount]):
              (+[WebCoreJavaScript interpreterCount]):
              (+[WebCoreJavaScript protectedObjectCount]):
              (+[WebCoreJavaScript garbageCollect]):
              (+[WebCoreJavaScript garbageCollectOnAlternateThread:]):
              (+[WebCoreJavaScript shouldPrintExceptions]):
              (+[WebCoreJavaScript setShouldPrintExceptions:]):
      
      WebKitTools:
      
              Reviewed by mjs.
              
              Added 'GCController' to DRT to support garbage collection layout tests.
              
              GCController.collect() and GCController.collectOnAlternateThread() do
              what you would expect. The latter takes a boolean argument sepcifying
              whether to wait for garbage collection to finish before continuing to
              execute script.
      
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/GCController.h: Added.
              * DumpRenderTree/GCController.mm: Added.
              (+[GCController isSelectorExcludedFromWebScript:]):
              (+[GCController webScriptNameForSelector:]):
              (-[GCController collect]):
              (-[GCController collectOnAlternateThread:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dc4ae48
    • andersca's avatar
      WebCore: · 1d0b377c
      andersca authored
      2006-05-24  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
              Implement document.scripts
              
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLDocument::getValueProperty):
              Return document.scripts() instead of a placeholder object.
              
              * dom/Document.cpp:
              (WebCore::Document::scripts):
              * dom/Document.h:
              Add Document::scripts.
              
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::traverseNextItem):
              * html/HTMLCollection.h:
              (WebCore::HTMLCollection::):
              Add scripts collection type which traverses all script elements.
              
      LayoutTests:
      
      2006-05-24  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              Add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
              Implement document.scripts
              
              * fast/dom/document-scripts-expected.txt: Added.
              * fast/dom/document-scripts.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d0b377c
    • andersca's avatar
      WebCore: · 8a6cbcf9
      andersca authored
      2006-05-24  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
              innerText is empty for elements without renderers
      
              * dom/Node.cpp:
              (WebCore::Node::textContent):
              * dom/Node.h:
              Add optional convertBRsToNewlines argument for textContent.
              
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::innerText):
              If the element doesn't have a renderer, return textContent.
      
      LayoutTests:
      
      2006-05-24  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
              innerText is empty for elements without renderers.
              
              * fast/dom/inner-text-with-no-renderer-expected.txt: Added.
              * fast/dom/inner-text-with-no-renderer.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a6cbcf9
  10. 23 May, 2006 1 commit
    • andersca's avatar
      WebCore: · ceaf7df4
      andersca authored
      2006-05-23  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
              Weather2.css incorrectly treated as JavaScript file @ www.live.com
              
              * dom/Element.cpp:
              (WebCore::Element::getAttribute):
              (WebCore::Element::setAttribute):
              (WebCore::Element::removeAttribute):
              (WebCore::Element::getAttributeNode):
              (WebCore::Element::hasAttribute):
              Use new getAttributeItem method.
              
              * dom/NamedAttrMap.cpp:
              (WebCore::NamedAttrMap::getNamedItem):
              (WebCore::NamedAttrMap::removeNamedItem):
              Use new getAttributeItem method.
              
              (WebCore::NamedAttrMap::getAttributeItem):
              * dom/NamedAttrMap.h:
              New method which returns the attribute based on the nodeName.
      
      LayoutTests:
      
      2006-05-23  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Maciej.
      
              Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
              Weather2.css incorrectly treated as JavaScript file @ www.live.com
              
              * dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
              This fails in a different way now.
              
              * dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
              * dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
              * dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
              * dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
              * dom/xhtml/level3/core/noderemovechild28-expected.txt:
              * dom/xhtml/level3/core/noderemovechild29-expected.txt:
              These now pass.
              
              * fast/dom/attribute-namespaces-get-set-expected.txt: Added.
              * fast/dom/attribute-namespaces-get-set.html: Added.
              Add new tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceaf7df4
  11. 22 May, 2006 1 commit
    • lweintraub's avatar
      LayoutTests: · 568a86c1
      lweintraub authored
              Reviewed by eric.
              
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=8393
                <br>s created by createMarkup aren't valid xhtml
                Changes in case from innerHTML
      
              * editing/execCommand/createLink-expected.txt:
              * editing/execCommand/unlink-expected.txt:
              * editing/input/attributed-substring-from-range-lines-expected.txt:
              * fast/dom/Range/range-exceptions-expected.txt:
              * fast/dom/Range/resources/range-exceptions.js:
              * fast/innerHTML/005-expected.txt:
              * fast/innerHTML/innerHTML-custom-tag-expected.txt:
              * fast/innerHTML/innerHTML-cast.html: Added.
              * fast/innerHTML/innerHTML-cast-expected.txt: Added.
              * fast/xsl/xslt-processer-expected.txt:
      
      WebCore:
      
              Reviewed by Eric.
              
              - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8393
                <br>s created by createMarkup aren't valid xhtml
                Fixed uppered output from innerHTML
      
              * editing/markup.cpp:
              (WebCore::startMarkup):
              (WebCore::endMarkup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      568a86c1
  12. 20 May, 2006 2 commits
    • andersca's avatar
      JavaScriptCore: · f4fa2b64
      andersca authored
      2006-05-20  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8993
              Support function declaration in case statements
              
              * kjs/grammar.y: Get rid of StatementList and use SourceElements instead.
              
              * kjs/nodes.cpp:
              (CaseClauseNode::evalStatements):
              (CaseClauseNode::processVarDecls):
              (CaseClauseNode::processFuncDecl):
              (ClauseListNode::processFuncDecl):
              (CaseBlockNode::processFuncDecl):
              (SwitchNode::processFuncDecl):
              * kjs/nodes.h:
              (KJS::CaseClauseNode::CaseClauseNode):
              (KJS::ClauseListNode::ClauseListNode):
              (KJS::ClauseListNode::getClause):
              (KJS::ClauseListNode::getNext):
              (KJS::ClauseListNode::releaseNext):
              (KJS::SwitchNode::SwitchNode):
              Add processFuncDecl for the relevant nodes.        
      
              * kjs/nodes2string.cpp:
              (CaseClauseNode::streamTo):
              next got renamed to source.
      
      LayoutTests:
      
      2006-05-20  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Geoff.
      
              * fast/js/function-declarations-in-switch-statement-expected.txt: Added.
              * fast/js/function-declarations-in-switch-statement.html: Added.
              * fast/js/resources/function-declarations-in-switch-statement.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4fa2b64
    • ap's avatar
      2006-05-20 Mitz Pettel <opendarwin.org@mitzpettel.com> · 0e708ba9
      ap authored
              Reviewed and landed by ap.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
                REGRESSION: ToT crash in WebCore at Zap2it
      
              Test: fast/table/empty-section-crash.html
      
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::paint): Return immediately if the section
              has 0 rows or 0 columns.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e708ba9
  13. 19 May, 2006 2 commits
    • aliceli1's avatar
      · c8c7871f
      aliceli1 authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c7871f
    • ggaren's avatar
      LayoutTests: · 75fecb99
      ggaren authored
              - Test for overriding non-autogenerated global constructors.
      
              * fast/dom/constructors-overriding-expected.txt: Added.
              * fast/dom/constructors-overriding.html: Added.
      
      WebCore:
      
              Reviewed by Eric.
      
              - Fixed non-autogenerated global constructors to match autogenerated
              ones and FF. (Found this bug while @ the GOOG.)
      
              (1) They're no longer read-only, so they can be overridden.
              (2) They now have the default object prototype, so they can do things 
              like 'toString' and 'valueOf', necessary for general functionality,
              including my layout test.
              (3) Their prototype properties are now enumerable and not read-only.
              
              * bindings/js/JSDOMParser.cpp:
              (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
              * bindings/js/JSXMLHttpRequest.h:
              * bindings/js/JSXMLSerializer.cpp:
              (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
              * bindings/js/JSXSLTProcessor.cpp:
              (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
              * bindings/js/kjs_html.cpp:
              (KJS::OptionConstructorImp::OptionConstructorImp):
              (KJS::ImageConstructorImp::ImageConstructorImp):
              * bindings/js/kjs_window.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75fecb99
  14. 18 May, 2006 1 commit
    • darin's avatar
      LayoutTests: · aa857303
      darin authored
              Reviewed by Hyatt.
      
              Tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
              Bug 8896: Absolutely positioned elements should use their parent's
              direction when left, right and width are auto in quirks mode.
      
              * fast/block/positioning/absolute-position-direction-quirk.html: Added.
              * fast/block/positioning/absolute-position-direction-quirk-expected.txt: Added.
              * fast/block/positioning/absolute-position-direction-quirk-expected.png: Added.
              * fast/block/positioning/absolute-position-direction-quirk-expected.checksum: Added.
              * fast/block/positioning/absolute-position-direction-strict.html: Added.
              * fast/block/positioning/absolute-position-direction-strict-expected.txt: Added.
              * fast/block/positioning/absolute-position-direction-strict-expected.png: Added.
              * fast/block/positioning/absolute-position-direction-strict-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
              Bug 8896: Absolutely positioned elements should use their parent's
              direction when left, right and width are auto in quirks mode.
      
              Use the parent's direction instead of the containing
              block's in quirks mode for absolute positioning to match
              WinIE.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              * rendering/RenderBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa857303