1. 04 Jun, 2006 9 commits
    • darin's avatar
      LayoutTests: · 9d783fab
      darin authored
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
                REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
      
              * fast/loader/link-no-URL.html: Added.
              * fast/loader/link-no-URL-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
                REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
      
              Test: fast/loader/link-no-URL.html
      
              * loader/Cache.h:
              * loader/Cache.cpp:
              (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL
              from the cached object itself. Callers were passing in the wrong URL. When it was a
              null string, it caused the crash mentioned above. But in other cases it may have
              caused some other minor problems as well. Added an assert to catch cases where the
              URL is null (should never happen).
              (WebCore::Cache::requestImage): Changed call site to not pass URL.
              (WebCore::Cache::requestStyleSheet): Ditto.
              (WebCore::Cache::requestScript): Ditto.
              (WebCore::Cache::requestXSLStyleSheet): Ditto.
              (WebCore::Cache::requestXBLDocument): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d783fab
    • ggaren's avatar
      Reviewed by Maciej. · 7a104b48
      ggaren authored
              
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9304
              Minor cleanup in JavaScriptCore
      
              * kjs/value.h: Removed redundant declarations
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a104b48
    • darin's avatar
      Reviewed by Adele. · c64965d6
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7291
                REGRESSION: delete key does not work in isIndex fields
      
              * platform/mac/WebCoreTextField.mm:
              (inputElement): Added. Helper function to get the Objective-C wrapper for an
              input element associated with a QTextEdit. Returns nil if the element is not
              an input element. The bug was caused by passing a non-input element to the
              delegate methods.
              (-[KWQTextFieldController controlTextDidBeginEditing:]): Use inputElement
              and don't make the delegate call at all if there is none. This happens only
              with isindex elements; it's not important to have auto-fill work with those.
              (-[KWQTextFieldController controlTextDidEndEditing:]): Ditto.
              (-[KWQTextFieldController controlTextDidChange:]): Ditto.
              (-[KWQTextFieldController control:textShouldEndEditing:]): Ditto.
              (-[KWQTextFieldController control:textView:doCommandBySelector:]): Ditto.
              (-[KWQTextFieldController textView:shouldHandleEvent:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c64965d6
    • darin's avatar
      Reviewed by Anders. · a9406af1
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8995
                memory leak in XPath code -- seen in layout tests
              - fixed malloc error on exit due to SVGDOMImplementation destructor
              - attempted to fix the no-XPATH_SUPPORT build by adding an #if
              - changed around includes and header-file formatting in XPath code
      
              * bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h when
              generating the bindings for XPathNSResolver.
      
              * dom/DOMImplementation.h: Added a virtual destructor for the benefit of
              SVGDOMImplementation.
              * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::~DOMImplementation): Added.
      
              * ksvg2/svg/SVGDOMImplementation.h: Reformatted a bit, removed unneeded declarations.
              * ksvg2/svg/SVGDOMImplementation.cpp:
              (SVGDOMImplementation::~SVGDOMImplementation): Remove commented-out code.
              (SVGDOMImplementation::createDocument): Remove a reference to KDOMView.
      
              * xpath/XPathExpression.cpp:
              (WebCore::XPathExpression::createExpression): Called release to avoid a tiny bit of
              reference count churn.
              (WebCore::XPathExpression::evaluate): Set exception code explicitly, because the code
              relies on it being 0 when the function succeeds.
      
              * xpath/XPathResult.cpp:
              (WebCore::InvalidatingEventListener::InvalidatingEventListener): Removed
              unneeded target node data member.
              (WebCore::XPathResult::XPathResult): Updated for enum name changes and
              InvalidatingEventListener name change. Added an assertion.
      
              * xpath/impl/XPathFunctions.h: Removed the FunctionLibrary class. Changed the parameter
              for createFunction to be a String instead of char*.
              * xpath/impl/XPathFunctions.cpp: Got rid of local implementation of "round", and
              used <wtf/MathExtras.h> instead. Also removed unused Interval::asString. Marked all
              the Interval functions inline.
              (WebCore::XPath::FunSubstring::doEvaluate): Use lround() instead of (long)round().
              (WebCore::XPath::FunLang::doEvaluate): Removed some unneeded temporary String variables.
              Use equalIgnoringCase() instead of calling lower() on two strings.
              (WebCore::XPath::createFunctionMap): Changed how this works so that it's all local to
              this function. Also removed a duplicate entry for the "last" function.
              (WebCore::XPath::createFunction): Changed from a member function to a separate function.
              Also changed so that if the args are not used in the function they are deleted.
              This was one of the sources of the storage leaks.
      
              * xpath/impl/XPathGrammar.y: Put XPATH_SUPPORT ifdef in. Replaced <num> with values of
              specific types (numop, eqop). Updated for name change from AxisType to Axis. Changed
              tokens that were declared as <str> but weren't actually using the string to be
              declared with no type (PLUS, MINUS, OR, AND, DOTDOT, SLASHSLASH). Replaced use of
              unregisterString, unregisterPredicateVector, and unregisterExpressionVector to
              call delete functions instead that both unregister and delete. Change call sites for
              createFunction to just use the String, removing the deprecatedString().latin1() call
              that is no longer needed. Added a call to unregisterParseNode that was missing in the
              "FilterExpr DescendantOrSelf RelativeLocationPath" production.
      
              * xpath/impl/XPathParser.h: Changed Token to hold a String, Step::Axis, NumericOp::Opcode,
              and EqTestOp::Opcode. The token ID number tells us which to use. Rearranged to put the private
              part of the Parser class last. Moved a number of private things inside the cpp file.
              * xpath/impl/XPathParser.cpp:
              (WebCore::XPath::charCat): Made this a separate function, instead of a static member.
              (WebCore::XPath::isAxisName): Ditto. Also put the global axis map inside the function,
              allowing use of a map instead of a map pointer.
              (WebCore::XPath::isNodeTypeName): Ditto.
              (WebCore::XPath::Parser::isOperatorContext): Made this const.
              (WebCore::XPath::Parser::makeTokenAndAdvance): Got rid of the "int" version of this.
              By using the actual types, we can safely use overload instead.
              (WebCore::XPath::Parser::lexString): Use substring() instead of deprecatedString().mid().
              (WebCore::XPath::Parser::lexNumber): Ditto.
              (WebCore::XPath::Parser::lexNCName): Changed to return a bool and a String instead of a
              Token. This avoids the hack of using a token value of "ERROR + 1" which I found quite
              confusing and is also a bit more explicit.
              (WebCore::XPath::Parser::lexQName): Ditto.
              (WebCore::XPath::Parser::nextTokenInternal): Changed to adapt to the changes above and
              to remove some unneeded else statements.
              (WebCore::XPath::Parser::lex): Changed the logic that sets up yylval to use the token ID
              to decide what the type is. This matches what the grammar expects, and removes the need
              for the token object to track which part of the value is good and the need to reserve 0
              to have a special meaning.
              (WebCore::XPath::Parser::parseStatement): Added code to delete the predicates and the
              expressions in the predicate and expression vectors. Before, we were only deleting
              the vectors. This was one of the sources of the storage leaks.
              (WebCore::XPath::Parser::deletePredicateVector): Renamed, and changed to delete
              the vector. However this does not delete the predicates in the vector.
              (WebCore::XPath::Parser::deleteExpressionVector): Renamed, and changed to delete
              the vector. However this does not delete the expressions in the vector.
              (WebCore::XPath::Parser::deleteString): Renamed, and changed to delete the string.
      
              * xpath/impl/XPathPredicate.h:
              * xpath/impl/XPathPredicate.cpp:
              (WebCore::XPath::NumericOp::NumericOp): Changed opcode from an int to an enum, and
              renamed to "opcode" instead of "opCode".
              (WebCore::XPath::NumericOp::doEvaluate): More of the same.
              (WebCore::XPath::EqTestOp::EqTestOp): Ditto.
              (WebCore::XPath::EqTestOp::doEvaluate): Ditto.
              (WebCore::XPath::LogicalOp::LogicalOp): Ditto.
              (WebCore::XPath::LogicalOp::shortCircuitOn): Ditto.
              (WebCore::XPath::Predicate::evaluate): Removed an unneeded "new".
      
              * xpath/impl/XPathStep.h:
              * xpath/impl/XPathStep.cpp: Renamed AxisType to Axis. Removed unused axisAsString
              function and default constructor.
      
              * xpath/impl/XPathValue.h: Renamed the type constants to have a Value suffix,
              instead of the underscore suffix used before on NodeVector and String.
              * xpath/impl/XPathValue.cpp: Updated for name change. Added asserts.
      
              * xpath/impl/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::doEvaluate):
              Use a reference instead of a pointer.
      
              * xpath/XPathEvaluator.cpp:
              * xpath/XPathEvaluator.h:
              * xpath/XPathExpression.h:
              * xpath/XPathNSResolver.cpp:
              * xpath/XPathNSResolver.h:
              * xpath/XPathNamespace.cpp:
              * xpath/XPathNamespace.h:
              * xpath/XPathResult.h:
              * xpath/impl/XPathExpressionNode.cpp:
              * xpath/impl/XPathExpressionNode.h:
              * xpath/impl/XPathPath.cpp:
              * xpath/impl/XPathPath.h:
              * xpath/impl/XPathUtil.cpp:
              * xpath/impl/XPathUtil.h:
              * xpath/impl/XPathVariableReference.h:
              Reformatted and changed includes around; no substantive changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9406af1
    • darin's avatar
      Reviewed by Anders. · 57617054
      darin authored
              - changed deleteAllValues so it can work on "const" collections
                Deleting the values affects the values, not the pointers in the
                collection, so it's legitimate to do it to a const collection,
                and a case of that actually came up in the XPath code.
      
              * wtf/HashMap.h:
              (WTF::deleteAllPairSeconds): Use const iterators.
              (WTF::deleteAllValues): Take const HashMap reference as a parameter.
              * wtf/HashSet.h:
              (WTF::deleteAllValues): Take const HashSet reference as a parameter,
              and use const iterators.
              * wtf/Vector.h:
              (WTF::deleteAllValues): Take const Vector reference as a parameter.
      
              - added more functions that are present in <math.h> on some platforms,
                but not on others; moved here from various files in WebCore
      
              * wtf/MathExtras.h:
              (isinf): Added.
              (isnan): Added.
              (lround): Added.
              (lroundf): Tweaked.
              (round): Added.
              (roundf): Tweaked.
              (signbit): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57617054
    • ddkilzer's avatar
      LayoutTests: · fb5e6eec
      ddkilzer authored
              Reviewed by hyatt.
      
              - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
                Absolutely positioned objects with relatively positioned inline 
                containing blocks are rendered incorrectly
      
              * fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
              * fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
              * fast/block/positioning/absolute-in-inline-ltr.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl.html: Added.
              * fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
              * fast/block/positioning/absolute-in-inline-short-rtl.html: Added.
      
      WebCore:
      
              Reviewed by hyatt.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
                Absolutely positioned objects with relatively positioned inline 
                containing blocks are rendered incorrectly
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockWidthForPositioned):
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb5e6eec
    • ddkilzer's avatar
      WebKitSite: · 8890bb00
      ddkilzer authored
              Reviewed by ggaren.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9303
              JavaScript error when loading WebKit blog page
      
              * blog/wp-content/themes/webkit/sidebar.php: Removed unused JavaScript.  Synced with nav.inc.
              * nav.inc: Removed evil tabs--whitespace change only.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8890bb00
    • ddkilzer's avatar
      WebKitTools: · 8816a4ef
      ddkilzer authored
              Reviewed by darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9299
              Teach svn-create-patch and friends to work with binary files
      
              * Scripts/svn-apply: Updated to use base64-encoded text for binary files when applying patches.
              * Scripts/svn-create-patch: Updated to include binary file content as base64-encoded text in patches.
              * Scripts/svn-unapply: Updated to recognize binary files when unapplying patches.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8816a4ef
    • andersca's avatar
      WebCore: · 0315a98f
      andersca authored
      2006-06-04  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
              document.evaluate and createNSResolver miss on namespaced elements
              
              * xpath/XPathExpression.cpp:
              (WebCore::XPathExpression::createExpression):
              Pass the resolver to the parser.
              
              * xpath/XPathResult.cpp:
              (WebCore::XPathResult::iterateNext):
              Fix off-by-one error.
              
              * xpath/impl/XPathExpressionNode.h:
              (WebCore::XPath::EvaluationContext::EvaluationContext):
              Get rid of the resolver in the evaluation context.
              
              * xpath/impl/XPathGrammar.y:
              Fetch the resolver from the parser. Only return the local name.
              
              * xpath/impl/XPathParser.cpp:        
              (WebCore::XPath::Parser::parseStatement):
              * xpath/impl/XPathParser.h:
              (WebCore::XPath::Parser::resolver):
              Update to hold the resolver.
              
              * xpath/impl/XPathStep.cpp:
              (WebCore::XPath::Step::Step):
              If the parser has stored a namespace URI, set it.
              
              (WebCore::XPath::Step::nodeTestMatches):
              Check namespace URIs.
              
              * xpath/impl/XPathStep.h:
              Add m_namespaceURI.
      
      LayoutTests:
      
      2006-06-04  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
              document.evaluate and createNSResolver miss on namespaced elements
      
              * fast/xpath: Added.
              * fast/xpath/xpath-namespaces-expected.txt: Added.
              * fast/xpath/xpath-namespaces.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0315a98f
  2. 03 Jun, 2006 11 commits
    • ddkilzer's avatar
      LayoutTests: · a0cd6749
      ddkilzer authored
              Reviewed by Eric.
      
              Added missing pixel test output:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
              TFOOT borders are copied to THEAD and TBODY
      
              * fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0cd6749
    • ddkilzer's avatar
      LayoutTests: · 6a28aac9
      ddkilzer authored
              Reviewed by mjs.  Tweaked and landed by ddkilzer.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
              With java disabled wrong information is displayed.
      
              * fast/replaced/applet-rendering-java-disabled.html: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.html: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.png: Added.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.
      
      WebCore:
      
              Reviewed by mjs.  Tweaked and landed by ddkilzer.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
              With java disabled wrong information is displayed.
      
              Test: fast/replaced/applet-rendering-java-disabled.html
      
              Match WinIE, render applet content inline when java is
              disabled. 
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::createRenderer):
              * rendering/RenderEmptyApplet.cpp: Removed.
              * rendering/RenderEmptyApplet.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a28aac9
    • thatcher's avatar
      LayoutTests: · dd4c7a30
      thatcher authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
                REGRESSION: Very odd roll-over issues (content disappearing)
      
              * fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
                REGRESSION: Very odd roll-over issues (content disappearing)
      
              Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being
              loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet
              count correct.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4c7a30
    • ddkilzer's avatar
      WebKitTools: · 6190dbb4
      ddkilzer authored
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9296
              Performance improvement for svn-create-patch
      
              * Scripts/svn-create-patch: Undef $indexPath after all paths have been fixed for a given patch.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6190dbb4
    • darin's avatar
      - fix Windows build · 42dc9411
      darin authored
              * platform/Widget.h: Moved scaleFactor function out of Apple-specific
              section of the header into the common part.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42dc9411
    • bdakin's avatar
      Reviewed by Darin. · 45edb34c
      bdakin authored
              Fix for <rdar://problem/4537274> HiDPI: <canvas> needs to apply a 
              scale. <canvas> needs to scale itself along with whatever scale 
              factor is set on the window.
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::createDrawingContext): Get the scale 
              factor and use it to create a larger buffer and to scale the 
              CGContext.
              * platform/Widget.h: Provide a new function that returns the user 
              space scale factor.
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::scaleFactor): Get the scale factor from the 
              window and return it.
              * platform/win/WidgetWin.cpp:
              (WebCore::Widget::scaleFactor): Just return 1.0f for now.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45edb34c
    • ddkilzer's avatar
      WebKit: · 76ffa516
      ddkilzer authored
              Reviewed by darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9290
              Teach svn-apply and svn-unapply to patch ChangeLogs cleanly
      
              * Scripts/svn-apply: Fixed to apply ChangeLog patches without failing.
              * Scripts/svn-unapply: Ditto.  Also simplified reversing a deletion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76ffa516
    • sfalken's avatar
      2006-06-03 Steve Falkenburg <sfalken@apple.com> · f06f4993
      sfalken authored
              Reviewed by hyatt.
              
              Removed unused code.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f06f4993
    • sfalken's avatar
      2006-06-03 Steve Falkenburg <sfalken@apple.com> · 784de872
      sfalken authored
              Reviewed by hyatt.
              
              Switch Spinneret to new hosting mechanism
      
              * Spinneret/Spinneret.sln:
              * Spinneret/Spinneret/Spinneret.cpp:
              (SpinneretWebHost::updateAddressBar):
              (SpinneretWebHost::QueryInterface):
              (SpinneretWebHost::AddRef):
              (SpinneretWebHost::Release):
              (resizeSubViews):
              (_tWinMain):
              (WndProc):
              (MyEditProc):
              (About):
              (loadURL):
              * Spinneret/Spinneret/Spinneret.h:
              (SpinneretWebHost::didStartProvisionalLoadForFrame):
              (SpinneretWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
              (SpinneretWebHost::didFailProvisionalLoadWithError):
              (SpinneretWebHost::didCommitLoadForFrame):
              (SpinneretWebHost::didReceiveTitle):
              (SpinneretWebHost::didReceiveIcon):
              (SpinneretWebHost::didFinishLoadForFrame):
              (SpinneretWebHost::didFailLoadWithError):
              (SpinneretWebHost::didChangeLocationWithinPageForFrame):
              (SpinneretWebHost::willPerformClientRedirectToURL):
              (SpinneretWebHost::didCancelClientRedirectForFrame):
              (SpinneretWebHost::willCloseFrame):
              (SpinneretWebHost::windowScriptObjectAvailable):
              * Spinneret/Spinneret/Spinneret.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      784de872
    • sfalken's avatar
      2006-06-03 Steve Falkenburg <sfalken@apple.com> · 577e455b
      sfalken authored
              Reviewed by hyatt.
              
              Add implementation of loadHTMLString for Spinneret
      
              * COM/WebFrame.cpp:
              (WebFrame::loadHTMLString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      577e455b
    • sfalken's avatar
      2006-06-03 Steve Falkenburg <sfalken@apple.com> · a41fd2c4
      sfalken authored
              Reviewed by hyatt.
      
              Don't send empty referrers.  Fixes image load fail on Spinneret default content.
      
              * platform/win/TransferJobWin.cpp:
              (WebCore::TransferJob::start):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a41fd2c4
  3. 02 Jun, 2006 18 commits
    • ddkilzer's avatar
      JavaScriptCore: · 31459a5c
      ddkilzer authored
              Reviewed by ggaren.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
                Implement $&, $' and $` replacement codes in String.prototype.replace
      
              Test: fast/js/string-replace-3.html
      
              * kjs/string_object.cpp:
              (substituteBackreferences): Added support for $& (matched substring),
              $` (everything preceding matched substring), $' (everything following
              matched substring) and 2-digit back references, and cleaned up a little.
      
      LayoutTests:
      
              Reviewed by ggaren.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
                Implement $&, $' and $` replacement codes in String.prototype.replace
      
              * fast/js/resources/string-replace-3.js: Added.
              * fast/js/string-replace-3-expected.txt: Added.
              * fast/js/string-replace-3.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31459a5c
    • adele's avatar
      Reviewed by Darin. · 7fd972a6
      adele authored
              Windows theme for textareas.  Also made some formatting changes. 
      
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::supportsFocus):
              (WebCore::RenderThemeWin::getThemeData):
              (WebCore::RenderThemeWin::adjustButtonStyle):
              (WebCore::RenderThemeWin::adjustTextFieldStyle):
              (WebCore::RenderThemeWin::adjustTextAreaStyle):
              (WebCore::RenderThemeWin::paintTextArea):
              * rendering/RenderThemeWin.h:
              (WebCore::RenderThemeWin::supportsHover):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fd972a6
    • thatcher's avatar
      Reviewed by Hyatt, checked in by Tim H. · 83434681
      thatcher authored
              Explicitly run perl on *.pl files instead of relying
              on Windows shell figuring out which program to run for
              this extention.
      
              * DerivedSources.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83434681
    • adele's avatar
      Reviewed by Darin. · 022e27a6
      adele authored
              Set incremental linking to no. This seems to fix a build problem I was seeing
              where dftables couldn't find a dll. 
      
              * JavaScriptCore.vcproj/dftables/dftables.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      022e27a6
    • thatcher's avatar
      LayoutTests: · 8991c154
      thatcher authored
              Reviewed by Hyatt, checked in by Tim H.
      
              For: http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
              Added test case to test opacity layers, in particular, opacities
              with a value of zero.
      
             * fast/css/ZeroOpacityLayers.html: Added.
             * fast/css/ZeroOpacityLayers-expected.txt: Added.
             * fast/css/ZeroOpacityLayers-expected.png: Added.
             * fast/css/ZeroOpacityLayers-expected.checksum: Added.
             * fast/css/ZeroOpacityLayers2.html: Added.
             * fast/css/ZeroOpacityLayers2-expected.txt: Added.
             * fast/css/ZeroOpacityLayers2-expected.png: Added.
             * fast/css/ZeroOpacityLayers2-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt, checked in by Tim H.
      
              fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
              Changed RenderLayer to only render layers that are not
              totally transparent.
      
              * rendering/RenderLayer.cpp
              (RenderLayer::paintLayer):
              Changed function to also check if the layer is totally transparent
              and if it is, don't bother painting it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8991c154
    • thatcher's avatar
      LayoutTests: · 864dbca9
      thatcher authored
              Reviewed by Hyatt, checked in by Tim H.
      
              Adding testcase for bug 8223.
      
              * fast/dom/css-inline-style-important-expected.checksum: Added.
              * fast/dom/css-inline-style-important-expected.png: Added.
              * fast/dom/css-inline-style-important-expected.txt: Added.
              * fast/dom/css-inline-style-important.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt, checked in by Tim H.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
              WebKit fails to update style on element via DOM
      
              Handle !important by detecting it and using a different code
              path from normal priority.
      
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::put):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::setProperty):
              * css/CSSStyleDeclaration.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864dbca9
    • mjs's avatar
      Reviewed by Geoff, checked in by Maciej. · 8fb7021f
      mjs authored
              
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9236
              REGRESSION: focus method does not work on some elements before they are laid out
              
              * dom/Element.cpp: (WebCore::Element::focus): Do the updateLayout call before
              calling isFocusable, since isFocusable looks at the size of the renderer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fb7021f
    • sfalken's avatar
      2006-06-02 Steve Falkenburg <sfalken@apple.com> · ffa0bf6f
      sfalken authored
              Reviewed by darin.
              
              Updated build script
      
              * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffa0bf6f
    • sfalken's avatar
      2006-06-02 Steve Falkenburg <sfalken@apple.com> · 17f579c8
      sfalken authored
              Reviewed by darin.
              
              Updated to latest hosting interface
      
              * WebFramePrivate.cpp:
              (WebKit::WebFramePrivate::openURL):
              (WebKit::WebFramePrivate::setTitle):
              (WebKit::WebFramePrivate::setStatusText):
              * WebFramePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17f579c8
    • sfalken's avatar
      2006-06-02 Steve Falkenburg <sfalken@apple.com> · 4eea401f
      sfalken authored
              Reviewed by darin.
      
              Platform hookup fixes
      
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::urlSelected):
              (WebCore::FrameWin::setTitle):
              (WebCore::FrameWin::setStatusBarText):
              * bridge/win/FrameWin.h:
              * platform/win/TemporaryLinkStubs.cpp:
              (FrameWin::overrideMediaType):
              * platform/win/TransferJobWin.cpp:
              (WebCore::TransferJobWndProc):
              (WebCore::TransferJob::start):
              (WebCore::TransferJob::fileLoadTimer):
              (WebCore::TransferJob::cancel):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eea401f
    • sfalken's avatar
      2006-06-02 Steve Falkenburg <sfalken@apple.com> · fa2897ed
      sfalken authored
              Reviewed by darin.
      
              New hosting for Spinneret to avoid static linking
      
              * COM: Added.
              * COM/Interfaces: Added.
              * COM/Interfaces/DOMCSS.idl: Added.
              * COM/Interfaces/DOMCore.idl: Added.
              * COM/Interfaces/DOMHTML.idl: Added.
              * COM/Interfaces/DOMRange.idl: Added.
              * COM/Interfaces/IWebArchive.idl: Added.
              * COM/Interfaces/IWebAttributedString.idl: Added.
              * COM/Interfaces/IWebBackForwardList.idl: Added.
              * COM/Interfaces/IWebDataSource.idl: Added.
              * COM/Interfaces/IWebDocument.idl: Added.
              * COM/Interfaces/IWebDownload.idl: Added.
              * COM/Interfaces/IWebEditingDelegate.idl: Added.
              * COM/Interfaces/IWebError.idl: Added.
              * COM/Interfaces/IWebFrame.idl: Added.
              * COM/Interfaces/IWebFrameLoadDelegate.idl: Added.
              * COM/Interfaces/IWebFrameView.idl: Added.
              * COM/Interfaces/IWebHistoryItem.idl: Added.
              * COM/Interfaces/IWebIconDatabase.idl: Added.
              * COM/Interfaces/IWebImage.idl: Added.
              * COM/Interfaces/IWebMutableURLRequest.idl: Added.
              * COM/Interfaces/IWebNotification.idl: Added.
              * COM/Interfaces/IWebPolicyDelegate.idl: Added.
              * COM/Interfaces/IWebPreferences.idl: Added.
              * COM/Interfaces/IWebResource.idl: Added.
              * COM/Interfaces/IWebResourceLoadDelegate.idl: Added.
              * COM/Interfaces/IWebScriptObject.idl: Added.
              * COM/Interfaces/IWebUIDelegate.idl: Added.
              * COM/Interfaces/IWebURLAuthenticationChallenge.idl: Added.
              * COM/Interfaces/IWebURLRequest.idl: Added.
              * COM/Interfaces/IWebURLResponse.idl: Added.
              * COM/Interfaces/IWebUndoManager.idl: Added.
              * COM/Interfaces/IWebView.idl: Added.
              * COM/Interfaces/WebKit.idl: Added.
              * COM/WebBackForwardList.cpp: Added.
              (WebBackForwardList::WebBackForwardList):
              (WebBackForwardList::~WebBackForwardList):
              (WebBackForwardList::createInstance):
              (WebBackForwardList::QueryInterface):
              (WebBackForwardList::AddRef):
              (WebBackForwardList::Release):
              (WebBackForwardList::addItem):
              (WebBackForwardList::goBack):
              (WebBackForwardList::goForward):
              (WebBackForwardList::goToItem):
              (WebBackForwardList::backItem):
              (WebBackForwardList::currentItem):
              (WebBackForwardList::forwardItem):
              (WebBackForwardList::backListWithLimit):
              (WebBackForwardList::forwardListWithLimit):
              (WebBackForwardList::capacity):
              (WebBackForwardList::setCapacity):
              (WebBackForwardList::backListCount):
              (WebBackForwardList::forwardListCount):
              (WebBackForwardList::containsItem):
              (WebBackForwardList::itemAtIndex):
              (WebBackForwardList::setPageCacheSize):
              (WebBackForwardList::pageCacheSize):
              * COM/WebBackForwardList.h: Added.
              * COM/WebDataSource.cpp: Added.
              (WebDataSource::WebDataSource):
              (WebDataSource::~WebDataSource):
              (WebDataSource::createInstance):
              (WebDataSource::QueryInterface):
              (WebDataSource::AddRef):
              (WebDataSource::Release):
              (WebDataSource::initWithRequest):
              (WebDataSource::data):
              (WebDataSource::representation):
              (WebDataSource::webFrame):
              (WebDataSource::initialRequest):
              (WebDataSource::request):
              (WebDataSource::response):
              (WebDataSource::textEncodingName):
              (WebDataSource::isLoading):
              (WebDataSource::pageTitle):
              (WebDataSource::unreachableURL):
              (WebDataSource::webArchive):
              (WebDataSource::mainResource):
              (WebDataSource::subresources):
              (WebDataSource::subresourceForURL):
              (WebDataSource::addSubresource):
              * COM/WebDataSource.h: Added.
              * COM/WebFrame.cpp: Added.
              (WebFrame::WebFramePrivate::WebFramePrivate):
              (WebFrame::WebFramePrivate::~WebFramePrivate):
              (WebFrame::WebFrame):
              (WebFrame::~WebFrame):
              (WebFrame::createInstance):
              (WebFrame::QueryInterface):
              (WebFrame::AddRef):
              (WebFrame::Release):
              (WebFrame::initWithName):
              (WebFrame::name):
              (WebFrame::webView):
              (WebFrame::frameView):
              (WebFrame::DOMDocument):
              (WebFrame::frameElement):
              (WebFrame::loadRequest):
              (WebFrame::loadData):
              (WebFrame::loadHTMLString):
              (WebFrame::loadAlternateHTMLString):
              (WebFrame::loadArchive):
              (WebFrame::dataSource):
              (WebFrame::provisionalDataSource):
              (WebFrame::stopLoading):
              (WebFrame::reload):
              (WebFrame::findFrameNamed):
              (WebFrame::parentFrame):
              (WebFrame::childFrames):
              (WebFrame::paint):
              (WebFrame::impl):
              (WebFrame::loadDataSource):
              (WebFrame::loading):
              (WebFrame::goToItem):
              (WebFrame::loadItem):
              (WebSystemMainMemory):
              (WebFrame::getObjectCacheSize):
              (WebFrame::receivedRedirect):
              (WebFrame::receivedResponse):
              (WebFrame::receivedData):
              (WebFrame::receivedAllData):
              (WebFrame::openURL):
              (WebFrame::submitForm):
              (WebFrame::setTitle):
              (WebFrame::setStatusText):
              * COM/WebFrame.h: Added.
              * COM/WebHistoryItem.cpp: Added.
              (WebHistoryItem::WebHistoryItem):
              (WebHistoryItem::~WebHistoryItem):
              (WebHistoryItem::createInstance):
              (WebHistoryItem::QueryInterface):
              (WebHistoryItem::AddRef):
              (WebHistoryItem::Release):
              (WebHistoryItem::initWithURLString):
              (WebHistoryItem::originalURLString):
              (WebHistoryItem::URLString):
              (WebHistoryItem::title):
              (WebHistoryItem::lastVisitedTimeInterval):
              (WebHistoryItem::setAlternateTitle):
              (WebHistoryItem::alternateTitle):
              (WebHistoryItem::icon):
              * COM/WebHistoryItem.h: Added.
              * COM/WebIconDatabase.cpp: Added.
              (WebIconDatabase::WebIconDatabase):
              (WebIconDatabase::~WebIconDatabase):
              (WebIconDatabase::createInstance):
              (WebIconDatabase::QueryInterface):
              (WebIconDatabase::AddRef):
              (WebIconDatabase::Release):
              (WebIconDatabase::sharedIconDatabase):
              (WebIconDatabase::iconForURL):
              (WebIconDatabase::defaultIconWithSize):
              (WebIconDatabase::retainIconForURL):
              (WebIconDatabase::releaseIconForURL):
              (WebIconDatabase::delayDatabaseCleanup):
              (WebIconDatabase::allowDatabaseCleanup):
              * COM/WebIconDatabase.h: Added.
              * COM/WebKitClassFactory.cpp: Added.
              (WebKitClassFactory::WebKitClassFactory):
              (WebKitClassFactory::~WebKitClassFactory):
              (WebKitClassFactory::QueryInterface):
              (WebKitClassFactory::AddRef):
              (WebKitClassFactory::Release):
              (WebKitClassFactory::CreateInstance):
              (WebKitClassFactory::LockServer):
              * COM/WebKitClassFactory.h: Added.
              * COM/WebKitDLL.cpp: Added.
              (DllMain):
              (DllGetClassObject):
              (DllCanUnloadNow):
              (DllUnregisterServer):
              (DllRegisterServer):
              * COM/WebKitDLL.h: Added.
              * COM/WebMutableURLRequest.cpp: Added.
              (WebMutableURLRequest::WebMutableURLRequest):
              (WebMutableURLRequest::~WebMutableURLRequest):
              (WebMutableURLRequest::createInstance):
              (WebMutableURLRequest::QueryInterface):
              (WebMutableURLRequest::AddRef):
              (WebMutableURLRequest::Release):
              (WebMutableURLRequest::requestWithURL):
              (WebMutableURLRequest::allHTTPHeaderFields):
              (WebMutableURLRequest::cachePolicy):
              (WebMutableURLRequest::HTTPBody):
              (WebMutableURLRequest::HTTPBodyStream):
              (WebMutableURLRequest::HTTPMethod):
              (WebMutableURLRequest::HTTPShouldHandleCookies):
              (WebMutableURLRequest::initWithURL):
              (WebMutableURLRequest::mainDocumentURL):
              (WebMutableURLRequest::timeoutInterval):
              (WebMutableURLRequest::URL):
              (WebMutableURLRequest::valueForHTTPHeaderField):
              (WebMutableURLRequest::addValue):
              (WebMutableURLRequest::setAllHTTPHeaderFields):
              (WebMutableURLRequest::setCachePolicy):
              (WebMutableURLRequest::setHTTPBody):
              (WebMutableURLRequest::setHTTPBodyStream):
              (WebMutableURLRequest::setHTTPMethod):
              (WebMutableURLRequest::setHTTPShouldHandleCookies):
              (WebMutableURLRequest::setMainDocumentURL):
              (WebMutableURLRequest::setTimeoutInterval):
              (WebMutableURLRequest::setURL):
              (WebMutableURLRequest::setValue):
              (WebMutableURLRequest::setFormData):
              (WebMutableURLRequest::formData):
              * COM/WebMutableURLRequest.h: Added.
              * COM/WebView.cpp: Added.
              (WebView::WebView):
              (WebView::~WebView):
              (WebView::createInstance):
              (WebView::mouseMoved):
              (WebView::mouseDown):
              (WebView::mouseUp):
              (WebView::mouseDoubleClick):
              (WebView::keyPress):
              (registerWebView):
              (WebViewWndProc):
              (calculateScrollDelta):
              (scrollMessageForKey):
              (WebView::goToItem):
              (WebView::QueryInterface):
              (WebView::AddRef):
              (WebView::Release):
              (WebView::canShowMIMEType):
              (WebView::canShowMIMETypeAsHTML):
              (WebView::MIMETypesShownAsHTML):
              (WebView::setMIMETypesShownAsHTML):
              (WebView::URLFromPasteboard):
              (WebView::URLTitleFromPasteboard):
              (WebView::initWithFrame):
              (WebView::setUIDelegate):
              (WebView::uiDelegate):
              (WebView::setResourceLoadDelegate):
              (WebView::resourceLoadDelegate):
              (WebView::setDownloadDelegate):
              (WebView::downloadDelegate):
              (WebView::setFrameLoadDelegate):
              (WebView::frameLoadDelegate):
              (WebView::setPolicyDelegate):
              (WebView::policyDelegate):
              (WebView::mainFrame):
              (WebView::backForwardList):
              (WebView::setMaintainsBackForwardList):
              (WebView::goBack):
              (WebView::goForward):
              (WebView::goToBackForwardItem):
              (WebView::setTextSizeMultiplier):
              (WebView::textSizeMultiplier):
              (WebView::setApplicationNameForUserAgent):
              (WebView::applicationNameForUserAgent):
              (WebView::setCustomUserAgent):
              (WebView::customUserAgent):
              (WebView::userAgentForURL):
              (WebView::supportsTextEncoding):
              (WebView::setCustomTextEncodingName):
              (WebView::customTextEncodingName):
              (WebView::setMediaStyle):
              (WebView::mediaStyle):
              (WebView::stringByEvaluatingJavaScriptFromString):
              (WebView::windowScriptObject):
              (WebView::setPreferences):
              (WebView::preferences):
              (WebView::setPreferencesIdentifier):
              (WebView::preferencesIdentifier):
              (WebView::setHostWindow):
              (WebView::hostWindow):
              (WebView::searchFor):
              (WebView::registerViewClass):
              (WebView::takeStringURLFrom):
              (WebView::stopLoading):
              (WebView::reload):
              (WebView::canGoBack):
              (WebView::canGoForward):
              (WebView::canMakeTextLarger):
              (WebView::makeTextLarger):
              (WebView::canMakeTextSmaller):
              (WebView::makeTextSmaller):
              (WebView::computedStyleForElement):
              (WebView::editableDOMRangeForPoint):
              (WebView::setSelectedDOMRange):
              (WebView::selectedDOMRange):
              (WebView::selectionAffinity):
              (WebView::setEditable):
              (WebView::isEditable):
              (WebView::setTypingStyle):
              (WebView::typingStyle):
              (WebView::setSmartInsertDeleteEnabled):
              (WebView::smartInsertDeleteEnabled):
              (WebView::setContinuousSpellCheckingEnabled):
              (WebView::isContinuousSpellCheckingEnabled):
              (WebView::spellCheckerDocumentTag):
              (WebView::undoManager):
              (WebView::setEditingDelegate):
              (WebView::editingDelegate):
              (WebView::styleDeclarationWithText):
              (WebView::replaceSelectionWithNode):
              (WebView::replaceSelectionWithText):
              (WebView::replaceSelectionWithMarkupString):
              (WebView::replaceSelectionWithArchive):
              (WebView::deleteSelection):
              (WebView::applyStyle):
              (WebView::copy):
              (WebView::cut):
              (WebView::paste):
              (WebView::copyFont):
              (WebView::pasteFont):
              (WebView::delete_):
              (WebView::pasteAsPlainText):
              (WebView::pasteAsRichText):
              (WebView::changeFont):
              (WebView::changeAttributes):
              (WebView::changeDocumentBackgroundColor):
              (WebView::changeColor):
              (WebView::alignCenter):
              (WebView::alignJustified):
              (WebView::alignLeft):
              (WebView::alignRight):
              (WebView::checkSpelling):
              (WebView::showGuessPanel):
              (WebView::performFindPanelAction):
              (WebView::startSpeaking):
              (WebView::stopSpeaking):
              (WebView::viewWindow):
              * COM/WebView.h: Added.
              * WebKit.vcproj: Added.
              * WebKit.vcproj/Interfaces.vcproj: Added.
              * WebKit.vcproj/WebKit.def: Added.
              * WebKit.vcproj/WebKit.rc: Added.
              * WebKit.vcproj/WebKit.sln: Added.
              * WebKit.vcproj/WebKit.vcproj: Added.
              * WebKit.vcproj/WebKitGUID.vcproj: Added.
              * WebKit.vcproj/autoversion.h: Added.
              * WebKit.vcproj/resource.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa2897ed
    • darin's avatar
      LayoutTests: · d8c28ba8
      darin authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
                attr(X) does not work
      
              * fast/css-generated-content/016-expected.checksum: Added.
              * fast/css-generated-content/016-expected.png: Added.
              * fast/css-generated-content/016-expected.txt: Added.
              * fast/css-generated-content/016.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
                attr(X) does not work
      
              Test: fast/css-generated-content/016.html
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style
              if the unique bit is set.
              (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property,
              set the unique bit and add to m_selectorAttrs.
      
              * rendering/render_style.cpp: Did a lot of reformatting, and this one real change.
              (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
      
              * rendering/render_style.h:
              (WebCore::RenderStyle::unique): Added. Returns value of m_unique.
              (WebCore::RenderStyle::setUnique): Added. Sets m_unique.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8c28ba8
    • darin's avatar
      Reviewed by Anders. · c8ed75dd
      darin authored
              Updated test so that is will once again exercise the fix for
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
      
              * fast/table/empty-section-crash-expected.txt:
              * fast/table/empty-section-crash.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8ed75dd
    • ddkilzer's avatar
      LayoutTests: · 249f410d
      ddkilzer authored
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-1-expected.png: Ditto.
              * editing/selection/7152-1-expected.txt: Ditto.
              * editing/selection/7152-1.html: Changed text in HTML content.
              * editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-2-expected.png: Ditto.
              * editing/selection/7152-2-expected.txt: Ditto.
              * editing/selection/7152-2.html: Changed text in HTML content.
              * *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.
      
      WebCore:
      
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      249f410d
    • darin's avatar
      * WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup · 5d3bf990
      darin authored
              by include NSObject as a superclass (oops!).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d3bf990
    • darin's avatar
      - try to fix Windows build · 45466717
      darin authored
              * bridge/win/FrameWin.cpp: Added include of Decoder.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45466717
    • darin's avatar
      WebCore: · 0836a37b
      darin authored
              Reviewed by Maciej.
      
              - WebCore doesn't need to load WebKit images any more; removed code for that
      
              * WebCore.exp: Removed WebCoreImageRendererFactory.
              * WebCore.xcodeproj/project.pbxproj: Removed WebCoreImageRendererFactory.h/mm.
              * bridge/mac/WebCoreFrameBridge.mm: Removed include of WebCoreImageRendererFactory.h.
              * platform/mac/ImageMac.mm: Removed include of WebCoreImageRendererFactory.h.
              * platform/mac/WebCoreImageRendererFactory.h: Removed.
              * platform/mac/WebCoreImageRendererFactory.m: Removed.
      
      WebKit:
      
              Reviewed by Maciej.
      
              - WebCore doesn't need to load WebKit images any more; removed code for that
      
              * Resources/missing_image.tiff: Removed.
              * WebCoreSupport/WebImageRendererFactory.h: Removed.
      
              * WebCoreSupport/WebImageRendererFactory.m: Moved @interface in here.
              Removed all but the "threaded decoding" calls that older Safari calls.
              This file can go altogether when compatibility with that older Safari
              is no longer needed.
      
              * WebKit.xcodeproj/project.pbxproj: Removed WebImageRendererFactory.h
              and missing_image.tiff.
      
              * WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): Removed call
              to [WebImageRendererFactory createSharedFactory].
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0836a37b
    • darin's avatar
      Reviewed by Geoff, tweaked a bit by Darin. · b4483824
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9064
                Split dom2_traversalimpl.* into separate files (one class per file).
      
              * WebCore.xcodeproj/project.pbxproj: Updated for new files.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
      
              * bindings/js/kjs_traversal.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/objc/DOM.mm:
              * dom/Document.cpp:
              * dom/Document.h:
              Updated includes.
      
              * dom/NodeFilter.cpp: Added.
              * dom/NodeFilter.h: Added.
              * dom/NodeFilterCondition.cpp: Added.
              * dom/NodeFilterCondition.h: Added.
              * dom/NodeIterator.cpp: Added.
              * dom/NodeIterator.h: Added.
              * dom/Traversal.cpp: Added.
              * dom/Traversal.h: Added.
              * dom/TreeWalker.cpp: Added.
              * dom/TreeWalker.h: Added.
      
              * dom/dom2_traversalimpl.cpp: Removed.
              * dom/dom2_traversalimpl.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4483824
  4. 01 Jun, 2006 2 commits
    • darin's avatar
      LayoutTests: · bd205a70
      darin authored
              Reviewed by Maciej and Adele
              
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
              Updated and extended select/option form tests 
              
              * fast/forms/HTMLOptionElement_label01.html:
              * fast/forms/HTMLOptionElement_label01-expected.txt:
              * fast/forms/HTMLOptionElement_label01-expected.png:
              * fast/forms/HTMLOptionElement_label02.html:
              * fast/forms/HTMLOptionElement_label02-expected.txt:
              * fast/forms/HTMLOptionElement_label02-expected.png:
              * fast/forms/HTMLOptionElement_label03.html:
              * fast/forms/HTMLOptionElement_label03-expected.txt:
              * fast/forms/HTMLOptionElement_label03-expected.png
              * fast/forms/HTMLOptionElement_label04.html:
              * fast/forms/HTMLOptionElement_label04-expected.txt:
              * fast/forms/HTMLOptionElement_label04-expected.png
              * fast/forms/HTMLOptionElement_label05.html:
              * fast/forms/HTMLOptionElement_label05-expected.txt:
              * fast/forms/HTMLOptionElement_label05-expected.png:
              Updated to reflect success and added some description
              
              * fast/forms/HTMLOptionElement_label06.html:
              * fast/forms/HTMLOptionElement_label06-expected.txt:
              * fast/forms/HTMLOptionElement_label05-expected.png:
              * fast/forms/HTMLOptionElement_label07.html:
              * fast/forms/HTMLOptionElement_label07-expected.txt:
              * fast/forms/HTMLOptionElement_label07-expected.png:
              Added.
      
      WebCore:
      
              Reviewed by Maciej and Adele
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
              REGRESSION: LABEL in OPTION element is clobbering display #TEXT
              Patch provided by Darin.
              
              * rendering/RenderSelect.cpp
              (RenderSelect::updateFromElement): 
              Changed to use the containing text by default, and not the label text
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd205a70
    • darin's avatar
      LayoutTests: · 7869e236
      darin authored
              Reviewed by Hyatt
              
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
              Test the window.screen.pixelDepth and window.screen.colorDepth
              
              * fast/dom/window/window-screen-properties.html: Added
              * fast/dom/window/window-screen-properties-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
              Correcting the value returned for window.screen.pixelDepth and
              window.screen.colorDepth
              
              * platform/mac/ScreenMac.mm
              (screenDepth): 
              Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7869e236