1. 30 Mar, 2011 40 commits
    • oliver@apple.com's avatar
      Rollout r82500 · 9d5d1b0f
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d5d1b0f
    • mdelaney@apple.com's avatar
      Fixed changelong entry typpos. · c4695b2f
      mdelaney@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4695b2f
    • yi.4.shen@nokia.com's avatar
      2011-03-30 Yi Shen <yi.4.shen@nokia.com> · e340f6ca
      yi.4.shen@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
              https://bugs.webkit.org/show_bug.cgi?id=57020
      
              Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
      
              * tests/qwebview/tst_qwebview.cpp:
              (tst_QWebView::focusInputTypes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e340f6ca
    • mdelaney@apple.com's avatar
      2011-03-29 Matthew Delaney <mdelaney@apple.com> · 9f35efbb
      mdelaney@apple.com authored
              Reviewed by Simon Fraser.
      
              Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG
      
              https://bugs.webkit.org/show_bug.cgi?id=53134
      
              * wtf/Platform.h: Added in WTF flag for using the Accelerate framework
      2011-03-29  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Simon Fraser.
      
              Use the Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG
      
              https://bugs.webkit.org/show_bug.cgi?id=53134
      
              Test: fast/canvas/getPutImageDataPairTest.html
      
              * platform/graphics/cg/ImageBufferCG.cpp:
      2011-03-25  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Simon Fraser.
      
              Use Accelerate vImage vectorized (un)premultiplyImageData functions for ImageBufferCG.cpp
              https://bugs.webkit.org/show_bug.cgi?id=53134
      
              * fast/canvas/canvas-getImageData-expected.txt: Resetting expected results for this test due to test change.
              * fast/canvas/canvas-getImageData.html: Removed the section of this test that incorrectly assumes the 
                rounding behavior of initial inputed data.
              * fast/canvas/getPutImageDataPairTest-expected.txt: Added.
              * fast/canvas/getPutImageDataPairTest.html: A new test to make sure that a batch of paired putImageData(getImageData)
                calls doesn't accumulate any error per the spec.
              * fast/canvas/rgba-parsing-expected.txt: Reset the results for this test since the initial rgba rounding values are
                now different. Note: the spec does not define how they *should* be rounded, so having them there is basically just
                for bookkeeping to know when our rounding behavior changes since it could be early warning of related real issues.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f35efbb
    • sfalken@apple.com's avatar
      Should turn off frame pointer omission (FPO) for Release (not Production) builds · c48a978a
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=54403
      
      Reviewed by Adam Roben.
      
      Leave it enabled for Windows Production builds.
      Disabling this optimization improves stack traces for memory and performance tools like umdh and xperf.
              
      We use both /Oy- and OmitFramePointers="false" since OmitFramePointers="false" isnt' enough
      to override /O2.
      
      * win/tools/vsprops/release.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c48a978a
    • aroben@apple.com's avatar
      Stop ignoring leaks in CGGradientCreateWithColorStops · 975d7b60
      aroben@apple.com authored
      Fixes <rdar://problem/7888547>.
      
      Rubber-stamped by John Sullivan.
      
      * Scripts/old-run-webkit-tests:
      (countAndPrintLeaks): Removed some code to ignore those leaks.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      975d7b60
    • mrobinson@webkit.org's avatar
      2011-03-30 Martin Robinson <mrobinson@igalia.com> · 9a936c79
      mrobinson@webkit.org authored
              Try to fix the WinCairo build.
      
              * platform/graphics/win/GraphicsContextCairoWin.cpp:
              (WebCore::GraphicsContext::platformInit): Fix misspelling of GraphicsContextPlatformPrivateToplevel.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a936c79
    • sfalken@apple.com's avatar
      Share most vsprops between Release and Production builds in releaseproduction.vsprops · 1d1fbc3e
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57508
      
      Reviewed by Adam Roben.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreRelease.vsprops:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleaseCairoCFLite.vsprops:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
      * JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
      * JavaScriptCore.vcproj/WTF/WTFRelease.vsprops:
      * JavaScriptCore.vcproj/WTF/WTFReleaseCairoCFLite.vsprops:
      * JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
      * JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
      * JavaScriptCore.vcproj/jsc/jscRelease.vsprops:
      * JavaScriptCore.vcproj/jsc/jscReleaseCairoCFLite.vsprops:
      * JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
      * JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
      * JavaScriptCore.vcproj/testapi/testapiRelease.vsprops:
      * JavaScriptCore.vcproj/testapi/testapiReleaseCairoCFLite.vsprops:
      
      Source/WebCore: 
      
      * WebCore.vcproj/QTMovieWinProduction.vsprops:
      * WebCore.vcproj/QTMovieWinRelease.vsprops:
      * WebCore.vcproj/QTMovieWinReleaseCairoCFLite.vsprops:
      * WebCore.vcproj/WebCoreProduction.vsprops:
      * WebCore.vcproj/WebCoreRelease.vsprops:
      * WebCore.vcproj/WebCoreReleaseCairoCFLite.vsprops:
      
      Source/WebKit/win: 
      
      * WebKit.vcproj/InterfacesProduction.vsprops:
      * WebKit.vcproj/InterfacesRelease.vsprops:
      * WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
      * WebKit.vcproj/WebKitGUIDProduction.vsprops:
      * WebKit.vcproj/WebKitGUIDRelease.vsprops:
      * WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
      * WebKit.vcproj/WebKitLibProduction.vsprops:
      * WebKit.vcproj/WebKitLibRelease.vsprops:
      * WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
      
      Source/WebKit2: 
      
      * win/WebKit2Production.vsprops:
      * win/WebKit2Release.vsprops:
      * win/WebKit2ReleaseCairoCFLite.vsprops:
      * win/WebKit2WebProcessProduction.vsprops:
      * win/WebKit2WebProcessRelease.vsprops:
      * win/WebKit2WebProcessReleaseCairoCFLite.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d1fbc3e
    • sfalken@apple.com's avatar
      Add some dynamic annotations to JavaScriptCore/wtf · 3be60b06
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=53747
      
      Patch by Timur Iskhodzhanov <timurrrr@google.com> on 2011-03-30
      Reviewed by Alexey Proskuryakov.
      
      By using these annotations we can improve the precision of finding
      WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
      These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
      
      These files don't add new functionality, so don't need extra tests.
      
      * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3be60b06
    • sfalken@apple.com's avatar
      Share most vsprops between Release and Production builds in releaseproduction.vsprops · 6349b8d3
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57508
      
      Reviewed by Adam Roben.
      
      * win/tools/vsprops/release.vsprops:
      * win/tools/vsprops/releaseproduction.vsprops: Copied from WebKitLibraries/win/tools/vsprops/release.vsprops.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6349b8d3
    • mrowe@apple.com's avatar
      Explicitly prevent testapi and minidom from being installed rather than relying · 85db1011
      mrowe@apple.com authored
      on Xcode's current behavior of not installing if INSTALL_PATH is not explicitly
      set at the target level.
      
      Reviewed by Adam Roben.
      
      <rdar://problem/9206357>
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85db1011
    • levin@chromium.org's avatar
      Add some dynamic annotations to JavaScriptCore/wtf · fa5e6724
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53747
      
      Patch by Timur Iskhodzhanov <timurrrr@google.com> on 2011-03-30
      Reviewed by Alexey Proskuryakov.
      
      By using these annotations we can improve the precision of finding
      WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
      These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
      
      These files don't add new functionality, so don't need extra tests.
      
      Source/JavaScriptCore:
      
      * GNUmakefile.am:
      * JavaScriptCore.gypi:
      * JavaScriptCore.vcproj/WTF/WTF.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * wtf/CMakeLists.txt:
      * wtf/DynamicAnnotations.cpp: Added.
      (WTFAnnotateBenignRaceSized):
      (WTFAnnotateHappensBefore):
      (WTFAnnotateHappensAfter):
      * wtf/DynamicAnnotations.h: Added.
      * wtf/ThreadSafeRefCounted.h:
      (WTF::ThreadSafeRefCountedBase::derefBase):
      * wtf/text/StringStatics.cpp:
      (WTF::StringImpl::empty):
      
      Source/JavaScriptGlue:
      
      * ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
      
      Source/WebCore:
      
      * ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
      
      Tools:
      
      * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa5e6724
    • mjs@apple.com's avatar
      Ensure consistent, readable working directory for WebProcess before entering sandbox · 9aa851a5
      mjs@apple.com authored
      <rdar://problem/8951176>
      
      Patch by Ivan Krstić <ike@apple.com> on 2011-03-30
      Reviewed by Oliver Hunt.
      
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::WebProcess::platformInitializeWebProcess):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa851a5
    • jberlin@webkit.org's avatar
      http/tests/uri/username-with-no-hostname.html is flaky due to preload scanner · 3551bffc
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57496
      
      Unreviewed, this test has been flakey on a bunch of platforms, so disable it to keep the
      bots green.
      
      * http/tests/uri/username-with-no-hostname.html: Removed.
      * http/tests/uri/username-with-no-hostname.html-disabled: Copied from http/tests/uri/username-with-no-hostname.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3551bffc
    • mrobinson@webkit.org's avatar
      2011-03-30 Martin Robinson <mrobinson@igalia.com> · 3feb8077
      mrobinson@webkit.org authored
              Skip a test which requires missing resource load callback dumps on GTK+.
              Better clump another failing test.
      
              * platform/gtk/Skipped: Update the skipped list.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3feb8077
    • mrobinson@webkit.org's avatar
      2011-03-30 Martin Robinson <mrobinson@igalia.com> · 1ec45f8d
      mrobinson@webkit.org authored
              Try to fix the EFL build.
      
              * platform/efl/RenderThemeEfl.cpp:
              (WebCore::RenderThemeEfl::paintThemePart): Use the new cairo_t accessor on the platform context.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ec45f8d
    • inferno@chromium.org's avatar
      2011-03-30 Abhishek Arya <inferno@chromium.org> · 2da9b7ad
      inferno@chromium.org authored
              Reviewed by Simon Fraser.
      
              Tests that we do not crash when removing inline style
              from a node that is not a html element.
              https://bugs.webkit.org/show_bug.cgi?id=57348
      
              * editing/execCommand/remove-format-non-html-element-crash-expected.txt: Added.
              * editing/execCommand/remove-format-non-html-element-crash.html: Added.
      2011-03-30  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Simon Fraser.
      
              Fix wrong type assumptions in editing code. Move code
              from ASSERTs to hard checks.
              https://bugs.webkit.org/show_bug.cgi?id=57348
      
              Test: editing/execCommand/remove-format-non-html-element-crash.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::getRGBAFontColor):
              (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
              * editing/DeleteButtonController.cpp:
              (WebCore::enclosingDeletableElement):
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::textDirection):
              (WebCore::EditingStyle::prepareToApplyAt):
              * editing/Editor.cpp:
              (WebCore::Editor::textDirectionForSelection):
              * editing/FormatBlockCommand.cpp:
              (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da9b7ad
    • senorblanco@chromium.org's avatar
      2011-03-30 Stephen White <senorblanco@chromium.org> · f88c8c95
      senorblanco@chromium.org authored
              Reviewed by Kenneth Russell.
      
              Speed up clipping in accelerated 2D canvas.
              https://bugs.webkit.org/show_bug.cgi?id=57464
      
              Instead of clearing the entire stencil buffer when removing clipping paths, we erase the path with a DECR stencil operation.
              Covered by canvas/philip/tests/2d.path.clip.intersect.html, and others.
      
              * platform/graphics/chromium/GLES2Canvas.cpp:
              (WebCore::PathAndTransform::PathAndTransform):
              New structure to keep track of the CTM at the time the clipping path was added.
              (WebCore::GLES2Canvas::State::State):
              Replace m_clippingEnabled with a count of total clipping paths.
              (WebCore::GLES2Canvas::clearRect):
              Check the total clipping path count, instead of m_clippingEnabled.
              (WebCore::GLES2Canvas::fillPath):
              (WebCore::GLES2Canvas::fillRect):
              Perform state application after doing shadows.  This is necessary
              since restore() may now leave clipping enabled.
              (WebCore::GLES2Canvas::clipPath):
              Explicitly specify the stencil operation as INCR.  Store the current
              transformation when saving clipping paths.
              (WebCore::GLES2Canvas::restore):
              Don't clear the stencil buffer and re-draw active paths on each restore.
              Erase the old paths with DECR.
              (WebCore::GLES2Canvas::drawTexturedRect):
              Check m_numClippingPaths instead of m_clippingEnabled.
              (WebCore::GLES2Canvas::beginShadowDraw):
              Perform state application when drawing hard shadows.
              (WebCore::GLES2Canvas::endShadowDraw):
              Check m_numClippingPaths instead of m_clippingEnabled.
              (WebCore::GLES2Canvas::beginStencilDraw):
              Make the stencil op a parameter to beginShadowDraw().
              (WebCore::GLES2Canvas::applyClipping):
              Compare against the total number of stencil paths, not just the ones in
              the current state.
              * platform/graphics/chromium/GLES2Canvas.h:
              Make the stencil op a parameter to beginShadowDraw().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f88c8c95
    • dglazkov@chromium.org's avatar
      2011-03-29 Dimitri Glazkov <dglazkov@chromium.org> · 2a3276fc
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.
              https://bugs.webkit.org/show_bug.cgi?id=57419
      
              Refactoring, covered by existing tests.
      
              * dom/EventDispatcher.cpp:
              (WebCore::EventDispatcher::dispatchMouseEvent): Reordered and clarified names.
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::create): Added a new factory method that takes PlatformMouseEvent.
              * dom/MouseEvent.h: Added decl.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a3276fc
    • oliver@apple.com's avatar
      2011-03-30 Oliver Hunt <oliver@apple.com> · 887a036f
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make StructureChain GC allocated
              https://bugs.webkit.org/show_bug.cgi?id=56695
      
              Make StructureChain GC allocated, and make the various owners
              mark it correctly.
      
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::dump):
              (JSC::CodeBlock::derefStructures):
              (JSC::CodeBlock::refStructures):
              (JSC::CodeBlock::markAggregate):
              * bytecode/Instruction.h:
              (JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
              (JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
              (JSC::PolymorphicAccessStructureList::derefStructures):
              (JSC::PolymorphicAccessStructureList::markAggregate):
              (JSC::Instruction::Instruction):
              * bytecode/StructureStubInfo.cpp:
              (JSC::StructureStubInfo::deref):
              (JSC::StructureStubInfo::markAggregate):
              * bytecode/StructureStubInfo.h:
              (JSC::StructureStubInfo::initGetByIdChain):
              (JSC::StructureStubInfo::initPutByIdTransition):
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::privateExecute):
              * jit/JITOpcodes.cpp:
              (JSC::JIT::emit_op_jneq_ptr):
              * jit/JITOpcodes32_64.cpp:
              (JSC::JIT::emit_op_jneq_ptr):
              * jit/JITPropertyAccess.cpp:
              (JSC::JIT::privateCompileGetByIdChainList):
              * jit/JITPropertyAccess32_64.cpp:
              (JSC::JIT::privateCompileGetByIdChainList):
              * jit/JITStubs.cpp:
              (JSC::getPolymorphicAccessStructureListSlot):
              (JSC::DEFINE_STUB_FUNCTION):
              * runtime/JSCell.h:
              * runtime/JSGlobalData.cpp:
              (JSC::JSGlobalData::JSGlobalData):
              * runtime/JSGlobalData.h:
              * runtime/JSGlobalObject.cpp:
              (JSC::markIfNeeded):
              * runtime/JSGlobalObject.h:
              (JSC::Structure::prototypeChain):
              * runtime/JSObject.h:
              (JSC::JSObject::markChildrenDirect):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::create):
              (JSC::JSPropertyNameIterator::get):
              (JSC::JSPropertyNameIterator::markChildren):
              * runtime/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::setCachedPrototypeChain):
              * runtime/MarkStack.h:
              (JSC::MarkStack::append):
              * runtime/Structure.h:
              (JSC::Structure::cachedPrototypeChainSlot):
              * runtime/StructureChain.cpp:
              (JSC::StructureChain::StructureChain):
              * runtime/StructureChain.h:
              (JSC::StructureChain::create):
              (JSC::StructureChain::createStructure):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      887a036f
    • arv@chromium.org's avatar
      2011-03-30 Erik Arvidsson <arv@chromium.org> · 49cf016f
      arv@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Missing DOM bindings for a ping
              https://bugs.webkit.org/show_bug.cgi?id=51955
      
              * fast/dom/ping-attribute-dom-binding-expected.txt: Added.
              * fast/dom/ping-attribute-dom-binding.html: Added.
      2011-03-30  Erik Arvidsson  <arv@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              Missing DOM bindings for a ping
              https://bugs.webkit.org/show_bug.cgi?id=51955
      
              Test: fast/dom/ping-attribute-dom-binding.html
      
              * html/HTMLAnchorElement.idl:
              * html/HTMLAreaElement.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49cf016f
    • mihaip@chromium.org's avatar
      2011-03-30 Mihai Parparita <mihaip@chromium.org> · 350a236b
      mihaip@chromium.org authored
              Fix remaining unexpected Chromium Snow Leopard image failures.
      
              Current Leopard baselines in chromium-mac/ are moved to
              chromium-mac-leopard/.
      
              * platform/chromium-mac-leopard/fast/forms/input-align-image-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-align-image-expected.checksum.
              * platform/chromium-mac-leopard/fast/forms/input-align-image-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-align-image-expected.png.
              * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-type-change-expected.checksum.
              * platform/chromium-mac-leopard/fast/forms/input-type-change-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/input-type-change-expected.png.
              * platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum.
              * platform/chromium-mac-leopard/fast/forms/listbox-bidi-align-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png.
              * platform/chromium-mac-leopard/fast/text/drawBidiText-expected.checksum: Copied from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.checksum.
              * platform/chromium-mac-leopard/fast/text/drawBidiText-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/text/drawBidiText-expected.png.
              * platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Copied from LayoutTests/platform/chromium-mac/media/video-transformed-expected.checksum.
              * platform/chromium-mac-leopard/media/video-transformed-expected.png: Copied from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
              * platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.checksum: Copied from LayoutTests/platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum.
              * platform/chromium-mac-leopard/scrollbars/listbox-scrollbar-combinations-expected.png: Copied from LayoutTests/platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png.
              * platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.checksum: Copied from LayoutTests/platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum.
              * platform/chromium-mac-leopard/scrollbars/overflow-scrollbar-combinations-expected.png: Copied from LayoutTests/platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png.
              * platform/chromium-mac-leopard/svg/text/foreignObject-text-clipping-bug-expected.checksum: Copied from LayoutTests/platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.checksum.
              * platform/chromium-mac-leopard/svg/text/foreignObject-text-clipping-bug-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png.
              * platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum.
              * platform/chromium-mac-leopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png.
              * platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Copied from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum.
              * platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Copied from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png.
              * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Removed.
              * platform/chromium-mac/fast/forms/input-align-image-expected.checksum:
              * platform/chromium-mac/fast/forms/input-align-image-expected.png:
              * platform/chromium-mac/fast/forms/input-type-change-expected.checksum:
              * platform/chromium-mac/fast/forms/input-type-change-expected.png:
              * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.checksum:
              * platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png:
              * platform/chromium-mac/fast/text/drawBidiText-expected.checksum:
              * platform/chromium-mac/fast/text/drawBidiText-expected.png:
              * platform/chromium-mac/media/video-transformed-expected.checksum:
              * platform/chromium-mac/media/video-transformed-expected.png:
              * platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
              * platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
              * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
              * platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
              * platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.checksum:
              * platform/chromium-mac/svg/text/foreignObject-text-clipping-bug-expected.png:
              * platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
              * platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
              * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
              * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      350a236b
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 375de318
      ap@apple.com authored
              REGRESSION (r82320): Spacebar no longer pages down
              https://bugs.webkit.org/show_bug.cgi?id=57423
              <rdar://problem/9207702>
      
              Also includes some unrelated cleanup that I had in my tree.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Added an assertion that the event is
              being dispatched to the right frame.
              (-[WebHTMLView setMarkedText:selectedRange:]): Use 0 for a pointer, not NULL.
              (-[WebHTMLView doCommandBySelector:]): Update eventInterpretationHadSideEffects with "|=".
              Even if this specific command hasn't been handled, that doesn't nullify side effects from
              previous commands.
              (-[WebHTMLView insertText:]): Besides looking at the return value of insertText() to fix the
              bug, removed setting _private->interpretKeyEventsParameters to 0. I don't see any way for
              another WebHTMLView NSTextInput method to be called from within insertText:, so no one is
              going to look at it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      375de318
    • mrobinson@webkit.org's avatar
      2011-03-30 Martin Robinson <mrobinson@igalia.com> · 03d82ab5
      mrobinson@webkit.org authored
              Reviewed by Dirk Schulze.
      
              [Cairo] Better separate the concerns of GraphicsContextCairo
              https://bugs.webkit.org/show_bug.cgi?id=55150
      
              Add a PlatformContextCairo which right now stores the cairo_t* for a
              GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
              and image masking layers into this PlatformContextCairo class.
      
              No new tests. This patch is only a code cleanup.
      
              * GNUmakefile.am:
              * platform/graphics/GraphicsContext.h: The platform context is no longer a
              cairo_t, but our new class the PlatformContextCairo.
              * platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
              * platform/graphics/cairo/FontCairo.cpp: Ditto.
              * platform/graphics/cairo/GradientCairo.cpp: Ditto.
              * platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical
              changes which now reference platformContext()->cr() to get the cairo_t.
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the
              PlatformContextCairo instead of the cairo_t.
              * platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
              * platform/graphics/cairo/ImageCairo.cpp: Ditto.
              * platform/graphics/cairo/PathCairo.cpp: Ditto.
              * platform/graphics/cairo/PlatformContextCairo.cpp: Added.
              * platform/graphics/cairo/PlatformContextCairo.h: Added.
              * platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
              * platform/graphics/gtk/IconGtk.cpp: Ditto.
              * platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out
              m_data with a private section containing the platform context instead of
              just a cairo_t.
              * platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
              * platform/gtk/WidgetRenderingContext.cpp: Ditto.
              (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
              * plugins/gtk/PluginViewGtk.cpp: Ditto.
      2011-03-30  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Dirk Schulze.
      
              [Cairo] Better separate the concerns of GraphicsContextCairo
              https://bugs.webkit.org/show_bug.cgi?id=55150
      
              Add a PlatformContextCairo which right now stores the cairo_t* for a
              GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
              and image masking layers into this PlatformContextCairo class.
      
              * webkit/webkitwebframe.cpp:
              (draw_page_callback):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_expose_event):
              (webkit_web_view_draw):
      2011-03-30  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Dirk Schulze.
      
              [Cairo] Better separate the concerns of GraphicsContextCairo
              https://bugs.webkit.org/show_bug.cgi?id=55150
      
              * WebFrame.cpp:
              (hdcFromContext): Modify this method to take PlatformContextCairo
              instead of a cairo_t.
              (WebFrame::spoolPage): Update to reflect new platform context.
              (WebFrame::spoolPages): Ditto.
              * WebFrame.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03d82ab5
    • sfalken@apple.com's avatar
      Remove unnecessary NDEBUG define. · 38a89544
      sfalken@apple.com authored
      Rubber stamped by Adam Roben.
      
      * win/tools/vsprops/production.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38a89544
    • paroga@webkit.org's avatar
      2011-03-30 Patrick Gansterer <paroga@webkit.org> · c441bcdd
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r82465.
      
              * CMakeListsWinCE.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c441bcdd
    • sfalken@apple.com's avatar
      2011-03-30 Steve Falkenburg <sfalken@apple.com> · 788e4820
      sfalken@apple.com authored
              Reviewed by Adam Roben.
      
              Update Windows production build logic for new production configurations
              https://bugs.webkit.org/show_bug.cgi?id=57494
      
              * win/tools/vsprops/common.vsprops:
              * win/tools/vsprops/production.vsprops: Added.
      2011-03-30  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Adam Roben.
      
              Update Windows production build logic for new production configurations
              https://bugs.webkit.org/show_bug.cgi?id=57494
      
              * JavaScriptCore.vcproj/JavaScriptCore.make:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreProduction.vsprops:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGO.vsprops:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreReleasePGOOptimize.vsprops:
              * JavaScriptCore.vcproj/WTF/WTFProduction.vsprops:
              * JavaScriptCore.vcproj/WTF/WTFReleasePGO.vsprops:
              * JavaScriptCore.vcproj/jsc/jscProduction.vsprops:
              * JavaScriptCore.vcproj/jsc/jscReleasePGO.vsprops:
              * JavaScriptCore.vcproj/testapi/testapiProduction.vsprops:
      2011-03-30  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Adam Roben.
      
              Update Windows production build logic for new production configurations
              https://bugs.webkit.org/show_bug.cgi?id=57494
      
              * WebKit.vcproj/InterfacesProduction.vsprops:
              * WebKit.vcproj/WebKit.make:
              * WebKit.vcproj/WebKitGUIDProduction.vsprops:
              * WebKit.vcproj/WebKitLibProduction.vsprops:
      2011-03-30  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Adam Roben.
      
              Update Windows production build logic for new production configurations
              https://bugs.webkit.org/show_bug.cgi?id=57494
      
              * WebCore.vcproj/QTMovieWinProduction.vsprops:
              * WebCore.vcproj/WebCore.make:
              * WebCore.vcproj/WebCoreProduction.vsprops:
      2011-03-30  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Brady Eidson.
      
              WebKit2: Attempting to view css file from url causes it to download
              <rdar://problem/9102611>
              https://bugs.webkit.org/show_bug.cgi?id=57501
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::canShowMIMEType):
              Match WebKit1 by allowing any MIME type that starts with "text/"
              except the ones we explicitly blacklist.
      2011-03-30  Steve Falkenburg  <sfalken@apple.com>
      
              Reviewed by Adam Roben.
      
              Update Windows production build logic for new production configurations
              https://bugs.webkit.org/show_bug.cgi?id=57494
      
              * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
              * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
              * DumpRenderTree/win/ImageDiffProduction.vsprops:
              * FindSafari/FindSafariProduction.vsprops:
              * FindSafari/FindSafariReleasePGO.vsprops:
              * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
              * WebKitAPITest/WebKitAPITestProduction.vsprops:
              * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
              * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
              * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
              * WinLauncher/WinLauncherProduction.vsprops:
              * record-memory-win/record-memory-winProduction.vsprops:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788e4820
    • weinig@apple.com's avatar
      WebKit2: Attempting to view css file from url causes it to download · 3f660c5b
      weinig@apple.com authored
      <rdar://problem/9102611>
      https://bugs.webkit.org/show_bug.cgi?id=57501
      
      Reviewed by Brady Eidson.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * platform/MIMETypeRegistry.cpp:
      (WebCore::initializeUnsupportedTextMIMETypes):
      (WebCore::initializeMIMETypeRegistry):
      (WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
      (WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
      * platform/MIMETypeRegistry.h:
      Add set of unsupported text MIME types, taken from WebKit/mac.
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLRepresentation.h:
      * WebView/WebHTMLRepresentation.mm:
      (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
      * WebView/WebHTMLView.mm:
      (+[WebHTMLView unsupportedTextMIMETypes]):
      Re-factor unsupportedTextMIMETypes to pull from WebCore's
      MIMETypeRegistry, so that the list can be shared with WebKit2.
      
      Source/WebKit2: 
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::canShowMIMEType):
      Match WebKit1 by allowing any MIME type that starts with "text/"
      except the ones we explicitly blacklist.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f660c5b
    • mihaip@chromium.org's avatar
      2011-03-30 Mihai Parparita <mihaip@chromium.org> · d22df47b
      mihaip@chromium.org authored
              Put expected PNG for fast/multicol/max-height-columns-block.html in the
              right directory (fix after r82480).
      
              * platform/chromium-mac-leopard/fast/multicol/max-height-columns-block-expected.png: Renamed from LayoutTests/platform/chromium-mac-leopard/fast/max-height-columns-block-expected.png.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d22df47b
    • mihaip@chromium.org's avatar
      2011-03-30 Mihai Parparita <mihaip@chromium.org> · af81349c
      mihaip@chromium.org authored
              Fix more tests for Chromium Snow Leopard.
      
              Most are due to mismatched checksum files (like r82480), some also
              needed updated chromium-mac baselines.
      
              * platform/chromium-mac-leopard/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Renamed from LayoutTests/platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png.
              * platform/chromium-mac-leopard/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png: Copied from LayoutTests/platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png.
              * platform/chromium-mac-leopard/editing/inserting/4875189-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/4875189-2-expected.png.
              * platform/chromium-mac-leopard/editing/pasteboard/5387578-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/5387578-expected.png.
              * platform/chromium-mac-leopard/editing/pasteboard/paste-table-cells-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png.
              * platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png.
              * platform/chromium-mac-leopard/fast/block/float/014-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/block/float/014-expected.png.
              * platform/chromium-mac-leopard/fast/block/float/clear-element-too-wide-for-containing-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.png.
              * platform/chromium-mac-leopard/fast/borders/border-radius-inline-flow-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png.
              * platform/chromium-mac-leopard/fast/canvas/canvas-zoom-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/canvas/canvas-zoom-expected.png.
              * platform/chromium-mac-leopard/fast/canvas/image-pattern-rotate-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png.
              * platform/chromium-mac-leopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png.
              * platform/chromium-mac-leopard/fast/forms/textfield-focus-ring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textfield-focus-ring-expected.png.
              * platform/chromium-mac-leopard/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png.
              * platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png.
              * platform/chromium-mac-leopard/fast/inline/inline-focus-ring-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/inline/inline-focus-ring-expected.png.
              * platform/chromium-mac-leopard/fast/replaced/absolute-image-sizing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png.
              * platform/chromium-mac-leopard/fast/replaced/image-onload-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/image-onload-expected.png.
              * platform/chromium-mac-leopard/fast/replaced/image-sizing-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/replaced/image-sizing-expected.png.
              * platform/chromium-mac-leopard/fast/text/basic/002-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/basic/002-expected.png.
              * platform/chromium-mac-leopard/fast/text/word-break-soft-hyphen-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.png.
              * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png.
              * platform/chromium-mac-leopard/svg/custom/focus-ring-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/focus-ring-expected.png.
              * platform/chromium-mac-leopard/svg/filters/filterRes-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filterRes-expected.png.
              * platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Removed.
              * platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum:
              * platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.png:
              * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Removed.
              * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Removed.
              * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Removed.
              * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum:
              * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.png:
              * platform/chromium-mac/fast/block/float/014-expected.checksum:
              * platform/chromium-mac/fast/block/float/014-expected.png:
              * platform/chromium-mac/fast/block/float/clear-element-too-wide-for-containing-block-expected.checksum: Removed.
              * platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.checksum: Removed.
              * platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Removed.
              * platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum:
              * platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
              * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Removed.
              * platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Removed.
              * platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
              * platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png:
              * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Removed.
              * platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Removed.
              * platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum:
              * platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
              * platform/chromium-mac/fast/replaced/image-onload-expected.checksum:
              * platform/chromium-mac/fast/replaced/image-onload-expected.png:
              * platform/chromium-mac/fast/replaced/image-sizing-expected.checksum:
              * platform/chromium-mac/fast/replaced/image-sizing-expected.png:
              * platform/chromium-mac/fast/text/basic/002-expected.checksum: Removed.
              * platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Removed.
              * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
              * platform/chromium-mac/svg/custom/focus-ring-expected.png:
              * platform/chromium-mac/svg/filters/filterRes-expected.checksum: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af81349c
    • robert@webkit.org's avatar
      2011-03-30 Robert Hogan <robert@webkit.org> · 0ef481d1
      robert@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] Fix LoadHTMLStringItem::invoke() after r75966
      
              Unskip http/tests/navigation/go-back-to-error-page.html
      
              https://bugs.webkit.org/show_bug.cgi?id=52614
      
              * platform/qt/Skipped:
      2011-03-30  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Antonio Gomes.
      
              [Qt] Fix LoadHTMLStringItem::invoke() after r75966
      
              Add DRT support for loading an alternate HTML string
              for error pages. This allows Qt to unskip
              http/tests/navigation/go-back-to-error-page.html.
      
              https://bugs.webkit.org/show_bug.cgi?id=52614
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::setAlternateHtml):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2011-03-30  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Antonio Gomes.
      
              [Qt] Fix LoadHTMLStringItem::invoke() after r75966
              Unskip http/tests/navigation/go-back-to-error-page.html
      
              Also add the location of DumpRenderTreeSupportQt.h
              to DRT's include paths.
      
              https://bugs.webkit.org/show_bug.cgi?id=52614
      
              * DumpRenderTree/qt/DumpRenderTree.pro:
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              * DumpRenderTree/qt/DumpRenderTreeQt.h:
              * DumpRenderTree/qt/GCControllerQt.cpp:
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::queueLoadHTMLString):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/qt/PlainTextControllerQt.cpp:
              * DumpRenderTree/qt/TextInputControllerQt.cpp:
              * DumpRenderTree/qt/WorkQueueItemQt.cpp:
              (LoadAlternateHTMLStringItem::invoke):
              * DumpRenderTree/qt/WorkQueueItemQt.h:
              (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
              * QtTestBrowser/QtTestBrowser.pro:
              * QtTestBrowser/launcherwindow.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ef481d1
    • mihaip@chromium.org's avatar
      2011-03-30 Mihai Parparita <mihaip@chromium.org> · 1b295ebe
      mihaip@chromium.org authored
              Fix editing/deleting for Chromium Snow Leopard.
      
              Same mismatched checksum story as r82480.
      
              * platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/4845371-expected.png.
              * platform/chromium-mac-leopard/editing/deleting/5126166-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/5126166-expected.png.
              * platform/chromium-mac-leopard/editing/deleting/5483370-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/5483370-expected.png.
              * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Removed.
              * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Removed.
              * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b295ebe
    • bweinstein@apple.com's avatar
      Crash when closing "Add Bookmark" dialog using the Enter Key · 385fec0e
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57294
      <rdar://problem/9044756>
      
      Reviewed by Darin Adler.
      
      Protect the FrameView in EventHandler::keyEvent, like we do in other EventHandler
      functions that could destroy the frame.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::keyEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      385fec0e
    • mihaip@chromium.org's avatar
      2011-03-30 Mihai Parparita <mihaip@chromium.org> · e874f70c
      mihaip@chromium.org authored
              Fix svg/dynamic-updates/SVGFEConvolveMatrixElement* for Chromium Snow Leopard.
      
              There were lone .checksum files in chromium-mac-leopard/ (similar to
              r82480), now they should have corresponding .pngs too.
      
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png.
              * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png.
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
              * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e874f70c
    • abarth@webkit.org's avatar
      2011-03-30 Adam Barth <abarth@webkit.org> · 591b881a
      abarth@webkit.org authored
              Reviewed by Adam Roben.
      
              SheriffBot rollouts take too long
              https://bugs.webkit.org/show_bug.cgi?id=57498
      
              We used to build before landing rollouts via the commit-queue to
              prevent further breakage, but now that our individual commit-queue
              machines are slower, building takes too long.  I can't remember the
              last time a rollout broke compile.  It seems like just landing the
              patch is the better trade-off.
      
              * Scripts/webkitpy/tool/bot/commitqueuetask.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      591b881a
    • mrobinson@webkit.org's avatar
      2011-03-30 Martin Robinson <mrobinson@igalia.com> · 2ab8e08b
      mrobinson@webkit.org authored
              Update some GTK+ results after r82411.
      
              * platform/gtk/svg/text/bidi-reorder-value-lists-expected.checksum:
              * platform/gtk/svg/text/bidi-reorder-value-lists-expected.png:
              * platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt:
              * platform/gtk/svg/text/font-size-below-point-five-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ab8e08b
    • abarth@webkit.org's avatar
      2011-03-30 Sheriff Bot <webkit.review.bot@gmail.com> · 173c4686
      abarth@webkit.org authored
              Unreviewed, rolling out r82463.
              http://trac.webkit.org/changeset/82463
              https://bugs.webkit.org/show_bug.cgi?id=57482
      
              Assertion failure in Node::rendererIsEditable on multiple
              editing tests (Requested by aroben|meeting on #webkit).
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
              * css/CSSValueKeywords.in:
              * rendering/style/RenderStyle.h:
              * rendering/style/RenderStyleConstants.h:
      2011-03-30  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r82463.
              http://trac.webkit.org/changeset/82463
              https://bugs.webkit.org/show_bug.cgi?id=57482
      
              Assertion failure in Node::rendererIsEditable on multiple
              editing tests (Requested by aroben|meeting on #webkit).
      
              * css3/unicode-bidi-plaintext-parse-expected.txt: Removed.
              * css3/unicode-bidi-plaintext-parse.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      173c4686
    • jam@chromium.org's avatar
      2011-03-29 John Abd-El-Malek <jam@chromium.org> · 755b87b4
      jam@chromium.org authored
              Reviewed by Tony Chang.
      
              [chromium]: Remove the code that called WebViewClient for spelling now that chromium is updated
              https://bugs.webkit.org/show_bug.cgi?id=57396
      
              * DEPS:
              * public/WebFrame.h:
              * public/WebView.h:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::handleCurrentKeyboardEvent):
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::checkSpellingOfString):
              (WebKit::EditorClientImpl::requestCheckingOfString):
              (WebKit::EditorClientImpl::getAutoCorrectSuggestionForMisspelledWord):
              (WebKit::EditorClientImpl::updateSpellingUIWithMisspelledWord):
              (WebKit::EditorClientImpl::showSpellingUI):
              (WebKit::EditorClientImpl::spellingUIIsShowing):
              * src/WebViewImpl.cpp:
              (WebKit::WebView::create):
              * src/WebViewImpl.h:
              * src/WebWorkerBase.cpp:
              (WebKit::WebWorkerBase::initializeLoader):
              * tests/PopupMenuTest.cpp:
              (WebKit::SelectPopupMenuTest::SetUp):
              * tests/WebFrameTest.cpp:
              (WebKit::TEST_F):
              * tests/WebPageSerializerTest.cpp:
              (WebKit::WebPageSerializerTest::SetUp):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      755b87b4
    • mihaip@chromium.org's avatar
      2011-03-30 Mihai Parparita <mihaip@chromium.org> · ace7929a
      mihaip@chromium.org authored
              Fix fast/multicol for Chromium Snow Leopard.
      
              We somehow ended up with only .checksum files in chromium-mac-leopard/
              (due to r67681 and then moved by r73376). The checksums in chromium-mac/
              were identical, so I deleted those and moved the corresponding .png
              to chromium-mac-leopard/, to live alongside its checksum.
      
              The mac/ baselines are correct for Snow Leopard, so we don't actually
              need any updates to get the tests to pass.
      
              * platform/chromium-mac-leopard/fast/max-height-columns-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/max-height-columns-block-expected.png.
              * platform/chromium-mac-leopard/fast/multicol/margin-collapse-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/margin-collapse-expected.png.
              * platform/chromium-mac-leopard/fast/multicol/positioned-split-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/positioned-split-expected.png.
              * platform/chromium-mac-leopard/fast/multicol/single-line-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/single-line-expected.png.
              * platform/chromium-mac-leopard/fast/multicol/table-margin-collapse-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/table-margin-collapse-expected.png.
              * platform/chromium-mac-leopard/fast/multicol/unsplittable-inline-block-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.png.
              * platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/single-line-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Removed.
              * platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ace7929a
    • abarth@webkit.org's avatar
      Remove platform/chromium-mac-snowleopard · 99324313
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57486
      
      Tools: 
      
      This directory no longer exists, so we can remove it from the fallback
      chain.
      
      * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
      
      LayoutTests: 
      
      Remove empty directories.
      
      * platform/chromium-mac-snowleopard: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99324313