1. 12 Apr, 2011 40 commits
    • tkent@chromium.org's avatar
      2011-04-12 Kent Tamura <tkent@chromium.org> · 9ceafc16
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
              https://bugs.webkit.org/show_bug.cgi?id=57426
      
              * platform/chromium/test_expectations.txt:
                Remove validation-message-appearance.html because it becomes non-flaky
                by the DRT change.
      2011-04-12  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
              https://bugs.webkit.org/show_bug.cgi?id=57426
      
              * public/WebSettings.h: Declare new function.
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
               Passing the specified value to WebCore::Settings.
              * src/WebSettingsImpl.h: Declare new function.
      2011-04-12  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
              https://bugs.webkit.org/show_bug.cgi?id=57426
      
              * DumpRenderTree/chromium/WebPreferences.cpp:
              (WebPreferences::applyTo): Disable the validation message timer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ceafc16
    • commit-queue@webkit.org's avatar
      2011-04-12 Luke Macpherson <macpherson@chromium.org> · 230edaf2
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Implement remaining Background and Mask css properties in CSSStyleApplyProperty
              https://bugs.webkit.org/show_bug.cgi?id=58390
      
              No new tests required as no functionality changed.
      
              * css/CSSStyleApplyProperty.cpp:
              (WebCore::ApplyPropertyExpanding): Class to expand one property to 0-4 properties.
              (WebCore::ApplyPropertyExpandingSuppressValue): Expand properties but suppress applyValue.
      
              (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
              (WebCore::CSSStyleSelector::applyProperty): Remove implementations that have been moved to CSSStyleApplyProperty.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      230edaf2
    • commit-queue@webkit.org's avatar
      2011-04-12 Sergey Glazunov <serg.glazunov@gmail.com> · 085298dd
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Element::setAttribute should check the namespace of an id attribute
              https://bugs.webkit.org/show_bug.cgi?id=58359
      
              * fast/dom/id-attribute-with-namespace-crash-expected.txt: Added.
              * fast/dom/id-attribute-with-namespace-crash.html: Added.
      2011-04-12  Sergey Glazunov  <serg.glazunov@gmail.com>
      
              Reviewed by Dimitri Glazkov.
      
              Element::setAttribute should check the namespace of an id attribute
              https://bugs.webkit.org/show_bug.cgi?id=58359
      
              Test: fast/dom/id-attribute-with-namespace-crash.html
      
              * dom/Element.cpp:
              (WebCore::Element::setAttribute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      085298dd
    • commit-queue@webkit.org's avatar
      2011-04-12 Mike Lawther <mikelawther@chromium.org> · 93378e4a
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Update boolean operators in RenderStyle to be compatible with check-webkit-style
              https://bugs.webkit.org/show_bug.cgi?id=58409
      
              No new functionality, so no new tests.
      
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::operator==):
              (WebCore::RenderStyle::inheritedNotEqual):
              (WebCore::positionedObjectMoved):
              (WebCore::RenderStyle::diff):
              (WebCore::RenderStyle::applyTransform):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::isOriginalDisplayInlineType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93378e4a
    • ap@apple.com's avatar
      2011-04-12 Alexey Proskuryakov <ap@apple.com> · 3d50fb94
      ap@apple.com authored
              Reviewed by Oliver Hunt.
      
              REGRESSION (WebKit2): Input methods are active in non-editable content
              https://bugs.webkit.org/show_bug.cgi?id=58404
              <rdar://problem/9275940>
      
              * UIProcess/API/mac/WKView.mm:
              (-[WKView insertText:]): Re-add the old variant of this function, because it's not only part
              of deprecated NSTextInput protocol, but it's also part of NSResponder, and it's called when
              the input context in nil.
              (-[WKView inputContext]): Return nil when not in editable content.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d50fb94
    • caseq@chromium.org's avatar
      2011-04-12 Andrey Kosyakov <caseq@chromium.org> · 33c9fa50
      caseq@chromium.org authored
              Unreviewed. Added chromium baselines for new tests.
      
              * platform/chromium/test_expectations.txt:
              * platform/chromium-linux/fast/borders/bidi-002-expected.png: Added.
              * platform/chromium-linux/fast/borders/bidi-004-expected.png: Added.
              * platform/chromium-linux/fast/borders/bidi-009a-expected.png: Added.
              * platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Added.
              * platform/chromium-mac-leopard/fast/borders/bidi-002-expected.png: Added.
              * platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Added.
              * platform/chromium-mac-leopard/fast/borders/bidi-009a-expected.png: Added.
              * platform/chromium-win/fast/borders/bidi-002-expected.png: Added.
              * platform/chromium-win/fast/borders/bidi-002-expected.txt: Added.
              * platform/chromium-win/fast/borders/bidi-004-expected.png: Added.
              * platform/chromium-win/fast/borders/bidi-004-expected.txt: Added.
              * platform/chromium-win/fast/borders/bidi-009a-expected.png: Added.
              * platform/chromium-win/fast/borders/bidi-009a-expected.txt: Added.
              * platform/chromium-win/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
              * platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33c9fa50
    • luiz@webkit.org's avatar
      [Qt] QNetworkReplyHandler refactoring: remove nested event loop. · 359819e3
      luiz@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58375
      
      Reviewed by Andreas Kling.
      
      As QNAM now makes actual synchronous loads there is no need for a nested event loop
      in ResourceHandleQt.
      
      Moving the call for QNetworkReplyWrapper::synchronousLoad from
      ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
      redirections to work in synchronous requests.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::start):
      * platform/network/qt/QNetworkReplyHandler.h:
      * platform/network/qt/ResourceHandleQt.cpp:
      (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
      (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
      (WebCore::WebCoreSynchronousLoader::didReceiveData):
      (WebCore::WebCoreSynchronousLoader::didFinishLoading):
      (WebCore::WebCoreSynchronousLoader::didFail):
      (WebCore::ResourceHandle::loadResourceSynchronously):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      359819e3
    • vangelis@chromium.org's avatar
      2011-04-12 Vangelis Kokkevis <vangelis@chromium.org> · 5ac48b8c
      vangelis@chromium.org authored
              Reviewed by James Robinson.
      
              [chromium] Adding layout test for:
              https://bugs.webkit.org/show_bug.cgi?id=58397
      
              * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.checksum: Added.
              * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.png: Added.
              * platform/chromium-gpu-mac/platform/chromium/compositing/child-layer-3d-sorting-expected.txt: Added.
              * platform/chromium/compositing/child-layer-3d-sorting.html: Added.
              * platform/chromium/test_expectations.txt:
      2011-04-12  Vangelis Kokkevis  <vangelis@chromium.org>
      
              Reviewed by James Robinson.
      
              [chromium] Move the calculation of the layer's z coordinate to the
              right spot so that it can be picked up by its sublayers.
              https://bugs.webkit.org/show_bug.cgi?id=58397
      
              Test: platform/chromium/compositing/child-layer-3d-sorting.html
      
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ac48b8c
    • commit-queue@webkit.org's avatar
      2011-04-12 Antoine Labour <piman@chromium.org> · 414a4c08
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Allow WebView users to recreate dependent contexts after a context lost
              event. Similarly to the startup case, a temporary context gets created,
              that gets used by the layer renderer once it itself gets recreated.
              https://bugs.webkit.org/show_bug.cgi?id=58385
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::reallocateRenderer): use the temporary context to
              recreate the layer renderer if it's valid.
              (WebKit::WebViewImpl::graphicsContext3D): create a temporary context if
              the layer renderer's context is lost.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      414a4c08
    • koz@chromium.org's avatar
      2011-04-12 James Kozianski <koz@chromium.org> · 53eb4b8e
      koz@chromium.org authored
              Unreviewed.
      
              Adding myself to committers.py.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53eb4b8e
    • luiz@webkit.org's avatar
      [Qt] QNetworkReplyHandler refactoring: signal queue · 04652f05
      luiz@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57075
      
      Reviewed by Andreas Kling.
      
      The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
      stop that queue when loading is deferred. This way almost all the deferred logic can be removed
      from QNetworkReplyHandler class and encapsulated in its own class.
      
      To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
      methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
      This together with empting the queue at wrapper destruction time makes sure that the handler will
      not receive calls from a dead wrapper.
      
      The new class is named QNetworkReplyHandlerCallQueue.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
      (WebCore::QNetworkReplyHandlerCallQueue::push):
      (WebCore::QNetworkReplyHandlerCallQueue::lock):
      (WebCore::QNetworkReplyHandlerCallQueue::unlock):
      (WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
      (WebCore::QNetworkReplyHandlerCallQueue::flush):
      (WebCore::QueueLocker::QueueLocker):
      (WebCore::QueueLocker::~QueueLocker):
      (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
      (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
      (WebCore::QNetworkReplyWrapper::receiveMetaData):
      (WebCore::QNetworkReplyWrapper::readyRead):
      (WebCore::QNetworkReplyWrapper::didReceiveFinished):
      (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
      (WebCore::QNetworkReplyHandler::resetState):
      (WebCore::QNetworkReplyHandler::release):
      (WebCore::QNetworkReplyHandler::finish):
      (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      (WebCore::QNetworkReplyHandler::forwardData):
      (WebCore::QNetworkReplyHandler::start):
      (WebCore::QNetworkReplyHandler::synchronousLoad):
      * platform/network/qt/QNetworkReplyHandler.h:
      (WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
      (WebCore::QNetworkReplyHandlerCallQueue::clear):
      (WebCore::QNetworkReplyWrapper::synchronousLoad):
      (WebCore::QNetworkReplyHandler::setLoadingDeferred):
      * platform/network/qt/ResourceHandleQt.cpp:
      (WebCore::ResourceHandle::loadResourceSynchronously):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04652f05
    • tkent@chromium.org's avatar
      2011-04-12 Kenichi Ishibashi <bashi@chromium.org> · d31b8ced
      tkent@chromium.org authored
              Reviewed by Kent Tamura.
      
              Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
              https://bugs.webkit.org/show_bug.cgi?id=58247
      
              Added tests which ensure calculation of m_associatedElementsAfterIndex
              doesn't get wrong.
      
              * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1-expected.txt: Added.
              * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html: Added.
              * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2-expected.txt: Added.
              * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html: Added.
      2011-04-12  Kenichi Ishibashi  <bashi@chromium.org>
      
              Reviewed by Kent Tamura.
      
              Fix wrong calculation of HTMLFormElement::m_associatedElementsAfterIndex.
              https://bugs.webkit.org/show_bug.cgi?id=58247
      
              - Increment m_associatedElementsAfterIndex when the form owner and an
              inserted form associated element have the same parent chain.
              - Always iterate over m_associatedElements to decrease indexes when a
              form associated element is removed. This is needed for a case that the
              form associated element is removed from the form element due to
              deleting the 'form' attribute. No behavioral change expected with this
              change.
      
              Tests: fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html
                     fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail2.html
      
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::formElementIndexWithFormAttribute):
              Incremet m_associatedElementsAfterIndex when compareDocumentPosition()
              returns DOCUMENT_POSITION_CONTAINED_BY.
              (WebCore::HTMLFormElement::removeFormElement):
              Always iterate m_associatedElements to adjust indexes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d31b8ced
    • diegohcg@webkit.org's avatar
      2011-04-12 Diego Gonzalez <diegohcg@webkit.org> · 6b0071c7
      diegohcg@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Do not show scrollbars when use mobile theme
              https://bugs.webkit.org/show_bug.cgi?id=58380
      
              * platform/qt/ScrollbarThemeQt.cpp:
              (WebCore::ScrollbarThemeQt::scrollbarThickness):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b0071c7
    • commit-queue@webkit.org's avatar
      2011-04-12 Anantanarayanan G Iyengar <ananta@chromium.org> · 51d6d1b6
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              The default backspace event handler should mark the event as handled if navigation succeeds.
              https://bugs.webkit.org/show_bug.cgi?id=58379
      
              We should mark the event as handled only if we were able to successfully navigate backwards or forwards.
              These navigations can fail if there is now back/forward history. This can occur in cases like ChromeFrame
              where history is managed by an external browser like IE.
      
              No new tests added as this scenario can occur when the history view is split across two browsers (WebKit and IE)
              It is non trivial to simulate this environment.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::defaultBackspaceEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51d6d1b6
    • beidson@apple.com's avatar
      <rdar://problem/9029193> and https://bugs.webkit.org/show_bug.cgi?id=58406 · 386e2965
      beidson@apple.com authored
      Bringing up the context menu on a link might also follow the link.
      
      Reviewed by Maciej Stachowiak.
      
      This patch adds a flag that is set just before the WebProcess tells the UIProcess to show a context menu.
      
      As long as this flag is set, the WebProcess will ignore any other mouse events that might have queued up
      by the time the UIProcess gets around to showing the menu.
      
      After the UIProcess is done showing the menu, it messages back telling the WebProcess to clear the flag
      and resume normal MouseEvent handling.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showContextMenu): No matter what internalShowContextMenu does, always notify
        the WebProcess that any context menu is now hidden.
      (WebKit::WebPageProxy::internalShowContextMenu):
      * UIProcess/WebPageProxy.h:
      
      * WebProcess/WebPage/WebContextMenu.cpp:
      (WebKit::WebContextMenu::show): Since we're telling the UIProcess to show the menu, tell the WebPage a
        context menu is showing so it will stop handling mouse events.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      (WebKit::WebPage::mouseEvent): Don't try to handle mouse events if a context menu is flagged as showing.
      
      Add accessors to twiddle the "context menu showing" flag:
      * WebProcess/WebPage/WebPage.h:
      (WebKit::WebPage::contextMenuShowing):
      (WebKit::WebPage::contextMenuHidden):
      * WebProcess/WebPage/WebPage.messages.in: Add the ContextMenuHidden message.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      386e2965
    • weinig@apple.com's avatar
      Quarantine related sandbox denial when downloading files · a1ff8be5
      weinig@apple.com authored
      <rdar://problem/9203736>
      
      Reviewed by Maciej Stachowiak.
      
      * WebProcess/com.apple.WebProcess.sb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1ff8be5
    • weinig@apple.com's avatar
      Sandbox violations dragging an image to the desktop. · e68eaacd
      weinig@apple.com authored
      <rdar://problem/9261834>
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/com.apple.WebProcess.sb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e68eaacd
    • rniwa@webkit.org's avatar
      2011-04-12 Ryosuke Niwa <rniwa@webkit.org> · 5eb8d169
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Make availableWidth and totalOverhangWidth in findNextLineBreak member variables of LineWidth
              https://bugs.webkit.org/show_bug.cgi?id=58400
      
              Added m_availableWidth and m_overhangWidth to LineWidth this allows us to encapsulate m_overhangWidth.
      
              * rendering/RenderBlock.h:
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::LineWidth::LineWidth):
              (WebCore::LineWidth::fitsOnLine): Added; returns true if current width + first argument <= availableWidth.
              (WebCore::LineWidth::availableWidth): Added.
              (WebCore::LineWidth::setAvailableWidth): Added; takes LineOffsets.
              (WebCore::LineWidth::applyOverhang): Added; obtains the overhang width from ruby run and inflates
              the available width.
              (WebCore::LineWidth::fitBelowFloats): Moved from RenderBlock.
              (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eb8d169
    • alexis.menard@openbossa.org's avatar
      2011-04-12 Alexis Menard <alexis.menard@openbossa.org> · d83f8dab
      alexis.menard@openbossa.org authored
              Unreviewed warning fix.
      
              MediaControlElements has been moved to html/shadow.
      
              * WebCore.pro:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d83f8dab
    • weinig@apple.com's avatar
      Sandbox violations trying to access ~/Library/Keyboard Layouts and ~/Library/Input Methods · 70d5edc1
      weinig@apple.com authored
      <rdar://problem/8973159> 
      
      Reviewed by Cameron Zwarich.
      
      * WebProcess/com.apple.WebProcess.sb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70d5edc1
    • yael.aharon@nokia.com's avatar
      Rename onEndChain and make it a static method. · fd15c115
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=58403
      
      Reviewed by Eric Seidel.
      
      No new tests since this is refactoring only.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::isLastChildForRenderer):
      (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
      * rendering/InlineFlowBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd15c115
    • jianli@chromium.org's avatar
      Unreviewed, update chromium test expectations. · 1f566435
      jianli@chromium.org authored
      Mark array-proto-func-property-getter-except.html and full-screen-zIndex.html
      as filed in chromium.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f566435
    • eric.carlson@apple.com's avatar
      2011-04-12 Eric Carlson <eric.carlson@apple.com> · 13519c85
      eric.carlson@apple.com authored
              Not reviewed, build fix.
      
              Fix non-accelerated build after r83667.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): Guard call to 
                  mediaPlayerRenderingModeChanged with USE(ACCELERATED_COMPOSITING.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13519c85
    • xan@webkit.org's avatar
      2011-04-12 Xan Lopez <xlopez@igalia.com> · 78b659e2
      xan@webkit.org authored
              Unreviewed build fix.
      
              * webkit/webkitwebhistoryitem.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78b659e2
    • enne@google.com's avatar
      2011-04-12 Adrienne Walker <enne@google.com> · ddaca98e
      enne@google.com authored
              Reviewed by James Robinson.
      
              [chromium] TilingData mishandles very small texture sizes
              https://bugs.webkit.org/show_bug.cgi?id=58364
      
              Use zero tiles when the texture size is too small for tiling.
      
              * platform/graphics/gpu/TilingData.cpp:
              (WebCore::TilingData::TilingData):
              (WebCore::TilingData::setMaxTextureSize):
      2011-04-12  Adrienne Walker  <enne@google.com>
      
              Reviewed by James Robinson.
      
              [chromium] TilingData mishandles very small texture sizes
              https://bugs.webkit.org/show_bug.cgi?id=58364
      
              Update test to properly handle texture sizes of 0-3.
      
              * tests/TilingDataTest.cpp:
              (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddaca98e
    • ossy@webkit.org's avatar
      2011-04-12 Csaba Osztrogonác <ossy@webkit.org> · 12393721
      ossy@webkit.org authored
              Unreviewed, rolling out r83634 and r83659.
              http://trac.webkit.org/changeset/83634
              http://trac.webkit.org/changeset/83659
              https://bugs.webkit.org/show_bug.cgi?id=57075
      
              It made 2 tests time out
      
              * platform/network/qt/QNetworkReplyHandler.cpp:
              (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
              (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
              (WebCore::QNetworkReplyWrapper::receiveMetaData):
              (WebCore::QNetworkReplyWrapper::didReceiveFinished):
              (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
              (WebCore::QNetworkReplyHandler::resetState):
              (WebCore::QNetworkReplyHandler::setLoadingDeferred):
              (WebCore::QNetworkReplyHandler::resumeDeferredLoad):
              (WebCore::QNetworkReplyHandler::release):
              (WebCore::QNetworkReplyHandler::finish):
              (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
              (WebCore::QNetworkReplyHandler::forwardData):
              (WebCore::QNetworkReplyHandler::start):
              * platform/network/qt/QNetworkReplyHandler.h:
              * platform/network/qt/ResourceHandleQt.cpp:
              (WebCore::WebCoreSynchronousLoader::resourceResponse):
              (WebCore::WebCoreSynchronousLoader::resourceError):
              (WebCore::WebCoreSynchronousLoader::data):
              (WebCore::WebCoreSynchronousLoader::setReplyFinished):
              (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
              (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
              (WebCore::WebCoreSynchronousLoader::didReceiveData):
              (WebCore::WebCoreSynchronousLoader::didFinishLoading):
              (WebCore::WebCoreSynchronousLoader::didFail):
              (WebCore::WebCoreSynchronousLoader::waitForCompletion):
              (WebCore::ResourceHandle::loadResourceSynchronously):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12393721
    • weinig@apple.com's avatar
      2011-04-12 Sam Weinig <sam@webkit.org> · 0fcf06e7
      weinig@apple.com authored
              Reviewed by Simon Fraser.
      
              Frames prevent scrolling containing page
              <rdar://problem/8990409>
              https://bugs.webkit.org/show_bug.cgi?id=58392
      
              Also fixes:
              Should rubber-band on pages with no scrollbars
              <rdar://problem/9034280>
      
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView):
              Make the main frame rubber-band horizontally and vertically always.
      
              * platform/ScrollTypes.h:
              Add ScrollElasticity enum.
      
              * platform/ScrollableArea.cpp:
              Default to no elasticity.
      
              (WebCore::ScrollableArea::ScrollableArea):
              * platform/ScrollableArea.h:
              (WebCore::ScrollableArea::setVerticalScrollElasticity):
              (WebCore::ScrollableArea::verticalScrollElasticity):
              (WebCore::ScrollableArea::setHorizontalScrollElasticity):
              (WebCore::ScrollableArea::horizontalScrollElasticity):
              Add state for horizontal and vertical elasticity.
      
              * platform/mac/ScrollAnimatorMac.mm:
              (WebCore::ScrollAnimatorMac::handleWheelEvent):
              Bail out of new scrolling behavior if we can't rubber-band. By bailing before
              accepting the wheel event, we allow the wheel event to be forwarded. We will
              need to refine this logic to allow subframe scrolling in the future.
      
              (WebCore::ScrollAnimatorMac::allowsVerticalStretching):
              (WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
              Switch stretching behavior based on the ScrollableArea's elasticity.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fcf06e7
    • ggaren@apple.com's avatar
      2011-04-12 Geoffrey Garen <ggaren@apple.com> · c0afe47d
      ggaren@apple.com authored
              Not reviewed.
      
              Try to fix the Chromium build.
              
              Why have one URL when you can have two at twice the price?
      
              * platform/KURL.h:
              (WebCore::KURL::KURL):
              (WebCore::KURL::isHashTableDeletedValue):
              * platform/KURLGoogle.cpp:
              (WebCore::KURLGooglePrivate::KURLGooglePrivate):
              * platform/KURLGooglePrivate.h: Added a GoogleURL path for KURL's hash
              table deleted value constructor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0afe47d
    • ossy@webkit.org's avatar
      [Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails · a5d0ad0a
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58396
      
      * platform/qt/Skipped: Add http/tests/misc/favicon-loads-with-icon-loading-override.html
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5d0ad0a
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58395 · 3ec01208
      barraclough@apple.com authored
      Exceptions thrown from property getters called from Array prototype functions can be missed
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      This is caught by an ASSERT in the top of Interpreter::executeCall.
      Check for exceptions after accessing properties that could be getters.
      
      * runtime/ArrayPrototype.cpp:
      (JSC::arrayProtoFuncSort):
      (JSC::arrayProtoFuncFilter):
      (JSC::arrayProtoFuncMap):
      (JSC::arrayProtoFuncEvery):
      (JSC::arrayProtoFuncForEach):
      (JSC::arrayProtoFuncSome):
      (JSC::arrayProtoFuncReduce):
      (JSC::arrayProtoFuncReduceRight):
          - Add exception checks.
      
      LayoutTests: 
      
      Added layout test.
      
      * fast/js/array-proto-func-property-getter-except-expected.txt: Added.
      * fast/js/array-proto-func-property-getter-except.html: Added.
      * fast/js/script-tests/array-proto-func-property-getter-except.js: Added.
      (test.propertyGetter):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ec01208
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58280 · d0a103de
      slewis@apple.com authored
      Fix a layout test by correctly comparing enums, and not adding exceptions.
      
      Reviewed by Oliver Hunt.
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::SerializedScriptValue::create):
      (WebCore::SerializedScriptValue::deserialize):
      * bindings/js/SerializedScriptValue.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a103de
    • eric.carlson@apple.com's avatar
      2011-04-12 Eric Carlson <eric.carlson@apple.com> · b3134c30
      eric.carlson@apple.com authored
              Reviewed by Simon Fraser.
      
              Apple movie trailers play only audio
              https://bugs.webkit.org/show_bug.cgi?id=58339
              <rdar://problem/9237606>
      
              No new tests, covered by existing layout and manual tests.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Do the logging before calling any functions.
              (WebCore::HTMLMediaElement::mediaPlayerFirstVideoFrameAvailable): New, if still displaying the poster 
                  change the display mode to Video and force a style recalc so the video layer gets hooked
                  up the the render tree.
              * html/HTMLMediaElement.h: Define new display mode, PosterWaitingForVideo, to signal that we
                  want to stop displaying the poster as soon as the first frame of video is available.
      
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::setDisplayMode): Change display mode to PosterWaitingForVideo when
                  we want to display Video but the media engines doesn't have the first frame yet.
              * html/HTMLVideoElement.h:
              (WebCore::HTMLVideoElement::shouldDisplayPosterImage): Update to return true when display mode
                  is PosterWaitingForVideo.
      
              * manual-tests/media-elements/video-replaces-poster.html: Clean up bit-rot from patch changes.
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::firstVideoFrameAvailable): New, passthrough from media engien to element.
              * platform/graphics/MediaPlayer.h:
              (WebCore::MediaPlayerClient::mediaPlayerFirstVideoFrameAvailable):
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Initialize 
                  m_haveReportedFirstVideoFrame and m_playWhenFramesAvailable.
              (WebCore::MediaPlayerPrivateAVFoundation::play): Don't actually start playback until the first
                  frame of video has loaded, or audio will begin to play before we can show video.
              (WebCore::MediaPlayerPrivateAVFoundation::pause): Clear m_playWhenFramesAvailable.
              (WebCore::MediaPlayerPrivateAVFoundation::updateStates): When first frame of video is
                  available, inform elment and begin playback if it was previousl requested.
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Correct logging.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Ditto.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay): Renamed from play.
              (WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause): Rename from pause.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3134c30
    • jianli@chromium.org's avatar
      2011-04-12 Jian Li <jianli@chromium.org> · c5dca8b8
      jianli@chromium.org authored
              Unreviewed, rolling out r83649.
              http://trac.webkit.org/changeset/83649
              https://bugs.webkit.org/show_bug.cgi?id=57563
      
              This patch causes compiling errors for chromium
      
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
              (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
              (WebCore::Font::drawComplexText):
              * platform/graphics/chromium/ImageBufferData.h:
              * platform/graphics/chromium/LayerChromium.h:
              * platform/graphics/chromium/LayerRendererChromium.h:
              * platform/graphics/chromium/PlatformCanvas.cpp:
              (WebCore::PlatformCanvas::resize):
              * platform/graphics/chromium/PlatformCanvas.h:
              * platform/graphics/chromium/TransparencyWin.cpp:
              (WebCore::TransparencyWin::compositeTextComposite):
              (WebCore::TransparencyWin::makeLayerOpaque):
              * platform/graphics/skia/ImageBufferSkia.cpp:
              (WebCore::ImageBuffer::ImageBuffer):
              * platform/graphics/skia/ImageSkia.cpp:
              (WebCore::paintSkBitmap):
              (WebCore::Image::drawPattern):
              * platform/graphics/skia/PlatformContextSkia.cpp:
              (WebCore::PlatformContextSkia::PlatformContextSkia):
              (WebCore::PlatformContextSkia::setCanvas):
              (WebCore::PlatformContextSkia::isPrinting):
              (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
              * platform/graphics/skia/PlatformContextSkia.h:
              (WebCore::PlatformContextSkia::canvas):
      2011-04-12  Jian Li  <jianli@chromium.org>
      
              Unreviewed, rolling out r83649.
              http://trac.webkit.org/changeset/83649
              https://bugs.webkit.org/show_bug.cgi?id=57563
      
              This patch causes compiling errors for chromium
      
              * public/WebCanvas.h:
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::printPage):
              * tests/TransparencyWinTest.cpp:
              (WebCore::drawNativeRect):
              (WebCore::getPixelAt):
              (WebCore::clearTopLayerAlphaChannel):
              (WebCore::clearTopLayerAlphaPixel):
              (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5dca8b8
    • enrica@apple.com's avatar
      Implement non-activating clicks to allow dragging out of a background window. · ad24ce63
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=55053
      <rdar://problem/9042197>
      
      Source/WebCore: 
      
      Reviewed by Alexey Proskuryakov.
      
      * WebCore.exp.in: Added new exported method.
      
      Source/WebKit2: 
      
      Reviewed by Alexey Proskuryakov and Sam Weinig.
      
      Added methods to WKView to support non activating click. Unfortunately both
      methods require a synchronous call to the WebProcess to decide what to do.
      acceptFirstMouse is called only if shouldDelayWindowOrderingForEvent returns
      true. In order to minimize the number of synchronous calls, we send the request
      only if our window is not the key window.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView acceptsFirstMouse:]):
      (-[WKView shouldDelayWindowOrderingForEvent:]):
      * UIProcess/WebPageProxy.h:
      * UIProcess/mac/WebPageProxyMac.mm:
      (WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
      (WebKit::WebPageProxy::acceptsFirstMouse):
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::shouldDelayWindowOrderingEvent):
      (WebKit::WebPage::acceptsFirstMouse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad24ce63
    • ggaren@apple.com's avatar
      2011-04-12 Oliver Hunt <oliver@apple.com> · 64efd16c
      ggaren@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make API callback objects use weak handles to run their finalizers
              https://bugs.webkit.org/show_bug.cgi?id=58389
      
              Make the API object's private data struct act as a finalizer for
              an api object if the callback object has a API defined finalizer.
      
              * API/JSCallbackObject.cpp:
              (JSC::JSCallbackObjectData::finalize):
              * API/JSCallbackObject.h:
              * API/JSCallbackObjectFunctions.h:
              (JSC::::init):
              * heap/Handle.h:
      2011-04-12  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Geoffrey Garen.
      
              Cleaned up hash traits, and added hash traits for handles
              https://bugs.webkit.org/show_bug.cgi?id=58381
      
              * dom/QualifiedName.h: Use new SimpleClassHashTraits to avoid duplication.
      
              * platform/KURL.h:
              (WebCore::KURL::KURL):
              (WebCore::KURL::isHashTableDeletedValue): Added explicit hash table
              deleted value constructor, to be more explicit and enable use of
              SimpleClassHashTraits.
      
              * platform/KURLHash.h: Use new SimpleClassHashTraits to avoid duplication.
      
              * platform/graphics/FontCache.cpp: Ditto.
              * platform/network/ProtectionSpaceHash.h: Ditto.
              * svg/properties/SVGAnimatedPropertyDescription.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64efd16c
    • jer.noble@apple.com's avatar
      Unreviewed; add two new tests to the mac-wk2 SkippedList. · 454b7599
      jer.noble@apple.com authored
      Skip fullscreen/video-specified-size.html and fullscreen/full-screen-zIndex.html
      
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      454b7599
    • ap@apple.com's avatar
      Reviewed by Oliver Hunt. · 5870a0aa
      ap@apple.com authored
              Crash when serializing a null AttributedString
              https://bugs.webkit.org/show_bug.cgi?id=58393
              <rdar://problem/9275326>
      
              * Shared/mac/AttributedString.mm:
              (WebKit::AttributedString::encode):
              (WebKit::AttributedString::decode):
              Prefix the serialized value with an isNull tag.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5870a0aa
    • oliver@apple.com's avatar
      2011-04-12 Oliver Hunt <oliver@apple.com> · f558d753
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Make API callback objects use weak handles to run their finalizers
              https://bugs.webkit.org/show_bug.cgi?id=58389
      
              Make the API object's private data struct act as a finalizer for
              an api object if the callback object has a API defined finalizer.
      
              * API/JSCallbackObject.cpp:
              (JSC::JSCallbackObjectData::finalize):
              * API/JSCallbackObject.h:
              * API/JSCallbackObjectFunctions.h:
              (JSC::::init):
              * heap/Handle.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f558d753
    • jam@chromium.org's avatar
      2011-04-12 John Abd-El-Malek <jam@chromium.org> · 002eff5f
      jam@chromium.org authored
              Reviewed by Jian Li.
      
              [chromium] Fix spellcheck regression in context menus
              https://bugs.webkit.org/show_bug.cgi?id=58386
      
              * src/ContextMenuClientImpl.cpp:
              (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
      2011-04-12  John Abd-El-Malek  <jam@chromium.org>
      
              Reviewed by Jian Li.
      
              [chromium] Fix spellcheck regression in context menus
              https://bugs.webkit.org/show_bug.cgi?id=58386
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      002eff5f
    • luiz@webkit.org's avatar
      [Qt] QNetworkReplyHandler refactoring: remove nested event loop. · 1e62afc0
      luiz@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58375
      
      Reviewed by Andreas Kling.
      
      As QNAM now makes actual synchronous loads there is no need for a nested event loop
      in ResourceHandleQt.
      
      Moving the call for QNetworkReplyWrapper::synchronousLoad from
      ResourceHandle::loadResourceSynchronously to QNetworkReplyHandler::start for the
      redirections to work in synchronous requests.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandler::start):
      * platform/network/qt/QNetworkReplyHandler.h:
      * platform/network/qt/ResourceHandleQt.cpp:
      (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
      (WebCore::WebCoreSynchronousLoader::didReceiveResponse):
      (WebCore::WebCoreSynchronousLoader::didReceiveData):
      (WebCore::WebCoreSynchronousLoader::didFinishLoading):
      (WebCore::WebCoreSynchronousLoader::didFail):
      (WebCore::ResourceHandle::loadResourceSynchronously):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e62afc0