Commits · 9cc9ebd710eb4688efed764f8565371bcd93476c · App_Technologies / webkit

19 May, 2007 1 commit

Fix a glitch in view source mode attribute names. · 9cc9ebd7

hyatt authored May 19, 2007

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9cc9ebd7

18 May, 2007 39 commits

"Linkify" view source mode links. · 3ab65053

hyatt authored May 19, 2007

        Reviewed by andersca

        * css/view-source.css:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
        (WebCore::HTMLViewSourceDocument::addLink):
        * html/HTMLViewSourceDocument.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3ab65053

2007-05-18 Oliver Hunt <oliver@apple.com> · fada1d18

oliver authored May 19, 2007

WebCore:

        Reviewed by Sam

        No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
        Need to expose CachedResourceClient constructor

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13782 
        REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode
        
        r21533 made used a DOMElement as the source for promise data, this meant it had to 
        clear the dragging pasteboard following the drag.  In DRT a drag is non-blocking
        so this resulted in us prematurely clearing the pasteboard.  
        
        This patch avoids this problem by referencing the source CachedImage rather than the
        DOMElement, so we don't need to worry about retaining an entire document forever, so
        we don't need to clear the dragging pasteboard following the drag.
        
        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
          Extract the underlying CachedImage from a DOMElement
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
          Use a CachedImage instead of a DOMElement
          
        * WebCoreSupport/WebDragClient.mm:
        (WebDragClient::startDrag):
        
        * WebKit.xcodeproj/project.pbxproj:
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate dealloc]):
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView pasteboardChangedOwner:]):
        (-[WebHTMLView pasteboard:provideDataForType:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        (-[WebHTMLView WebCore::]):
        (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
          Use CachedImage rather than DOMElement as promised data source
          
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

fada1d18

Fix more malformed test cases. · 9e91d431

hyatt authored May 18, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9e91d431

Fix more malformed test cases. · b191499c

hyatt authored May 18, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b191499c

Fix more malformed test cases. · ddaeb591

hyatt authored May 18, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ddaeb591

Fix more malformed test cases. · b13523b4

hyatt authored May 18, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b13523b4

Fix more malformed test cases. · affe5907

hyatt authored May 18, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

affe5907

Beating my head against these malformed http/navigation tests still. · e53ddcdc
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
e53ddcdc
Beating my head against these malformed http/navigation tests still. · 7514029e
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
7514029e
Beating my head against these malformed http/navigation tests still. · 99310486
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
99310486
Beating my head against these malformed http/navigation tests still. · 2686cdab
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
2686cdab
Beating my head against these malformed http/navigation tests still. · ee3d188c
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
ee3d188c
Beating my head against these malformed http/navigation tests still. · 1ad60ff9
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
1ad60ff9
Fixing broken http/navigation test cases that were written with malformed HTML. · 6cfc6d56
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
6cfc6d56
Fixing broken http/navigation test cases that were written with malformed HTML. · 765df842
hyatt authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
765df842
Fixed potential crash with ASSERT in download due to previous commit. · 89c952f8
tristan authored May 18, 2007
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
89c952f8

Fix for <rdar://problem/5214338 > REGRESSION: / mishandled in · 1abaea48

hyatt authored May 18, 2007

        HTML tokenization (13780).

        Reviewed by ggaren

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute):
        (WebCore::HTMLTokenizer::parseTag):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1abaea48

Added bugzilla link · cd1a5729

beidson authored May 18, 2007



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cd1a5729

* WebCoreSupport/WebFrameLoaderClient.mm: · 810b5594

tristan authored May 18, 2007

        (WebFrameLoaderClient::download):
        asked the webframeloaderclient for its webview's history and
        injected the originated url into the created WebDownload



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

810b5594

Reviewed by Maciej · 9e87bdef

beidson authored May 18, 2007

        <rdar://problem/5166149> - window.open() causes server to be hit twice

        This regressed in http://trac.webkit.org/projects/webkit/changeset/14637
        That patch was to fix broken behavior when opening an already existant window.
        The unfortunate side effect was to cause the server to be hit twice.  
        Once during the call to frame->loader()->createWindow(), and again via a 
        scheduled redirection.

        I decided to restore the original de-facto behavior by making the new window
        open via a scheduled redirection - there is a FIXME that was already here that
        explains the reason why we have to do it this way for now.

        Additionally, there were two distinct places that had their own logic to open
        a new window - the logic for window.open() and the logic for 
        window.showModalDialog().  The logic was almost identical so I condensed them
        into one utility function that takes a flag to handle the slig...

9e87bdef

LayoutTests: · a211a4ba

weinig authored May 18, 2007

        Reviewed by Geoff.

        - update results to account for new JSHTMLElements that are being
          auto-generated and can now produce Constructors.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Geoff.

        Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
        HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.

        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createJSHTMLWrapper):
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * html/HTMLTableCaptionElement.idl:
...

a211a4ba

Reviewed by Kevin Decker · c0da6ab1

sullivan authored May 18, 2007

        
        Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is,
        a couple of hours more modern.)

        * WebView/WebUIDelegatePrivate.h:
        add showPanel: parameter to just-introduced delegate method webView:saveFrameView:

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        pass NO for new showPanel: parameter, and update comment



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c0da6ab1

Reviewed by John. · 891d02a0

mjs authored May 18, 2007

        
        <rdar://problem/5204792> REGRESSION (r21367): System widgets are drawn with vertical/horizontal scroll bars
        
        No test because the bug requires calling setAllowsScrolling: to reproduce.

        * WebView/WebFrameView.mm:
        (-[WebFrameView setAllowsScrolling:]): Update the FrameView's scroll state as well as the one
        on WebDynamicScrollBarsView, otherwise this setting won't stick if the frame has already loaded
        a document.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

891d02a0

Not Reviewed, buildbot test fix. · 62aca5a3

mjs authored May 18, 2007

        
        - updated results for the last fiew checkins.
        
        * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
        * fast/dom/replaceChild-expected.txt:
        * http/tests/loading/bad-scheme-subframe-expected.txt:
        * webarchive/loading/test-loading-archive-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

62aca5a3

2007-05-18 Oliver Hunt <oliver@apple.com> · 1be0bf39

oliver authored May 18, 2007

        Reviewed by Sam.

        Fix for <rdar://problem/5211122> DRT crash below
        SVGTimer::applyAnimations when page cache is enabled 
        (SVG animation timers do not properly cancel themselves)

        There were still a few paths in the SVG Animation code
        that could cause timers to be created and used.  This 
        patch inserts addition SVG_EXPERIMENTAL blocks to prevent
        these timers from being used.

        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::startAnimations):
        * ksvg2/misc/SVGTimer.cpp:
        (WebCore::SVGTimer::animationsByElement):
        (WebCore::SVGTimer::applyAnimations):
        (WebCore::SVGTimer::notifyAll):
        (WebCore::SVGTimer::addNotify):
        (WebCore::SVGTimer::removeNotify):
        * ksvg2/misc/TimeScheduler.cpp:
        (WebCore::TimeScheduler::addTimer):
        (WebCore::TimeScheduler::connectIntervalTimer):
        (WebCore::TimeScheduler::disconnectIntervalTimer):
        (WebCore::TimeScheduler::startAnimations):
        (WebCore::TimeScheduler::toggleAnimations):
        (WebCore::TimeScheduler::timerFired):
        * ksvg2/svg/SVGAnimationElement.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1be0bf39

Fixed spelling error. · b5f0a2f7

ggaren authored May 18, 2007

        
        * WebView/WebViewPrivate.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b5f0a2f7

Reviewed by Mitz. · 0a6389e0

weinig authored May 18, 2007

        Update test results after Hyatt's update of view-source
        to include line numbers and a gutter.

        * fast/frames/viewsource-attribute-expected.checksum:
        * fast/frames/viewsource-attribute-expected.png:
        * fast/frames/viewsource-attribute-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0a6389e0

Reviewed by Kevin Decker · ae0c4bec

sullivan authored May 18, 2007

        
        WebKit part of fix for 5201499 (support for PDFKit UI for saving PDFs to disk)
        
        Also, the PDFKit mechanism for notifying clients about "Open File Externally" was
        changed from a notification to a delegate method. The notification was new to 
        Leopard, so removing it doesn't affect clients in the field.

        * WebView/WebUIDelegatePrivate.h:
        Declared new UI delegate method webView:saveFrameView:, analogous to the existing
        webView:printFrameView:

        * WebView/WebPDFView.mm:
        removed declaration of _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewDidMoveToWindow]):
        don't observe _webkit_PDFKitLaunchNotification
        (-[WebPDFView viewWillMoveToWindow:]):
        ditto
        (-[WebPDFView PDFViewOpenPDFInNativeApplication:]):
        new PDFKit delegate method, replaces our use of _webkit_PDFKitLaunchNotification
        (-[WebPDFView PDFViewSavePDFToDownloadFolder:]):
        new PDFKit delegate method, calls through to new WebKit UI delegate method



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ae0c4bec

Patch from Marius Bugge Monsen to fix clipboard crash. · 52093102

zack authored May 18, 2007

Return a valid pointer to a Clipboard object
from newGeneralClipboard.
r=me


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

52093102

Changed the QWebPage::loadProgressChange API to have an integer (percent) argument · c4d8cc23

hausmann authored May 18, 2007

instead of a double precision float.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c4d8cc23

Keyboard event crash fix by Marius Bugge Monsen. · 60a67aed

zack authored May 18, 2007

The default constructed KeyboardEvent has
no PlatformKeyboardEvent.
r=me


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

60a67aed

2007-05-18 Oliver Hunt <oliver@apple.com> · 489093bc

oliver authored May 18, 2007

        Reviewed by Mark.

        Fix capitalisation of resources referenced by test case. 

        * svg/carto.net/window.svg:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

489093bc

2007-05-18 Mark Rowe <mrowe@apple.com> · 355f477b

bdash authored May 18, 2007

        Reviewed by Oliver.

        Force LC_ALL to C when parsing locale-specific strings in 'svn' output.

        * Scripts/svn-create-patch:
        * Scripts/webkitdirs.pm:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

355f477b

2007-05-18 Mark Rowe <mrowe@apple.com> · 0d4ebb85

bdash authored May 18, 2007

        Attempt to fix the Gdk build after r21562.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (Widget::isEnabled):
        * platform/gdk/WidgetGdk.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0d4ebb85

2007-05-18 Adam Treat <treat@kde.org> · c00a762f

lars authored May 18, 2007

        Reviewed by Lars

        Remove dead code.

        * platform/Widget.h:
        * platform/mac/WidgetMac.mm:
        * platform/qt/WidgetQt.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c00a762f

2007-05-18 Holger Freyther <zecke@selfish.org> · d0c0d4ff

bdash authored May 18, 2007

        Reviewed by Maciej.

        Return true to make loading of pages working again

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::canHandleRequest):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d0c0d4ff

2007-05-18 Holger Freyther <zecke@selfish.org> · 2f045e58

bdash authored May 18, 2007

        Reviewed by Maciej.

        Make WebCore::Widget use GtkWidget to fix focus handling.

        * WebCore.pro: Add PlatformScrollBar
        * platform/ScrollView.h: Gtk stuff
        * platform/Widget.h: Take a GtkWidget
        * platform/gdk/PlatformScrollBarGdk.cpp: Added.
        (PlatformScrollbar::PlatformScrollbar):
        (PlatformScrollbar::~PlatformScrollbar):
        (PlatformScrollbar::width):
        (PlatformScrollbar::height):
        (PlatformScrollbar::setEnabled):
        (PlatformScrollbar::paint):
        (PlatformScrollbar::updateThumbPosition):
        (PlatformScrollbar::updateThumbProportion):
        (PlatformScrollbar::setRect):
        * platform/gdk/ScreenGdk.cpp: Implement depth handling
        (WebCore::screenDepth):
        * platform/gdk/ScrollViewGdk.cpp: use setGtkWidget, not setDrawable
        (WebCore::ScrollView::setGtkWidget):
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/gdk/WidgetGdk.cpp:
        (WebCore::Widget::Widget):
        (WebCore::Widget::gtkWidget):
        (WebCore::Widget::setGtkWidget):
        (WebCore::Widget::hasFocus):
        (WebCore::Widget::setFocus):

2007-05-18  Holger Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        * GdkLauncher/main.cpp: Call setGtkWidget
        (main):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2f045e58

Reviewed by Zack · f188d973

lars authored May 18, 2007

        Correctly implement initialiseSupportedImageMIMETypes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f188d973

2007-05-18 Holger Hans Peter Freyther <zecke@selfish.org> · ffaee62c

bdash authored May 18, 2007

        Reviewed by Maciej.

        Build fix for non-Qt and non-Mac ports.

        * html/HTMLCanvasElement.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ffaee62c